CINXE.COM
LKML: (Vincent Hanquez): "[PATCH
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: (Vincent Hanquez): "[PATCH</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by (Vincent Hanquez)" href="/groupie.php?aid=6578" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/26"> [26]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/26/112" onclick="this.href='/lkml/headers'+'/2005/4/26/112';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/26/112">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/4/26/112">First message in thread</a></li><li class="origin"><a href="/lkml/2005/4/26/125">(Vincent Hanquez)</a><ul><li><a href="/lkml/2005/4/26/125">Vincent Hanquez</a></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/26/112/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Subject</td><td class="rp" itemprop="name">"[PATCH</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Tue, 26 Apr 2005 12:38:05 +0200 (CEST)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">(Vincent Hanquez)</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Hi,<br /><br />The following patch use the user_mode macro where it's possible.<br /><br />Please apply, or comments.<br /><br /> Signed-off-by: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk><br /><br />diff -Naur linux-2.6.12-rc3.1/arch/i386/kernel/process.c linux-2.6.12-rc3.2/arch/i386/kernel/process.c<br />--- linux-2.6.12-rc3.1/arch/i386/kernel/process.c 2005-04-22 12:10:22.000000000 +0100<br />+++ linux-2.6.12-rc3.2/arch/i386/kernel/process.c 2005-04-25 16:09:25.000000000 +0100<br />@@ -262,7 +262,7 @@<br /> printk("EIP: %04x:[<%08lx>] CPU: %d\n",0xffff & regs->xcs,regs->eip, smp_processor_id());<br /> print_symbol("EIP is at %s\n", regs->eip);<br /> <br />- if (regs->xcs & 3)<br />+ if (user_mode(regs))<br /> printk(" ESP: %04x:%08lx",0xffff & regs->xss,regs->esp);<br /> printk(" EFLAGS: %08lx %s (%s)\n",<br /> regs->eflags, print_tainted(), system_utsname.release);<br />diff -Naur linux-2.6.12-rc3.1/arch/i386/kernel/signal.c linux-2.6.12-rc3.2/arch/i386/kernel/signal.c<br />--- linux-2.6.12-rc3.1/arch/i386/kernel/signal.c 2005-04-21 11:45:46.000000000 +0100<br />+++ linux-2.6.12-rc3.2/arch/i386/kernel/signal.c 2005-04-25 16:09:53.000000000 +0100<br />@@ -599,7 +599,7 @@<br /> * kernel mode. Just return without doing anything<br /> * if so.<br /> */<br />- if ((regs->xcs & 3) != 3)<br />+ if (!user_mode(regs))<br /> return 1;<br /> <br /> if (current->flags & PF_FREEZE) {<br />diff -Naur linux-2.6.12-rc3.1/arch/i386/kernel/traps.c linux-2.6.12-rc3.2/arch/i386/kernel/traps.c<br />--- linux-2.6.12-rc3.1/arch/i386/kernel/traps.c 2005-04-21 11:45:46.000000000 +0100<br />+++ linux-2.6.12-rc3.2/arch/i386/kernel/traps.c 2005-04-25 16:12:34.000000000 +0100<br />@@ -209,7 +209,7 @@<br /> <br /> esp = (unsigned long) (&regs->esp);<br /> ss = __KERNEL_DS;<br />- if (regs->xcs & 3) {<br />+ if (user_mode(regs)) {<br /> in_kernel = 0;<br /> esp = regs->esp;<br /> ss = regs->xss & 0xffff;<br />@@ -265,7 +265,7 @@<br /> char c;<br /> unsigned long eip;<br /> <br />- if (regs->xcs & 3)<br />+ if (user_mode(regs))<br /> goto no_bug; /* Not in kernel */<br /> <br /> eip = regs->eip;<br />@@ -353,7 +353,7 @@<br /> <br /> static inline void die_if_kernel(const char * str, struct pt_regs * regs, long err)<br /> {<br />- if (!(regs->eflags & VM_MASK) && !(3 & regs->xcs))<br />+ if (!user_mode_vm(regs))<br /> die(str, regs, err);<br /> }<br /> <br />@@ -366,7 +366,7 @@<br /> goto trap_signal;<br /> }<br /> <br />- if (!(regs->xcs & 3))<br />+ if (!user_mode(regs))<br /> goto kernel_trap;<br /> <br /> trap_signal: {<br />@@ -487,7 +487,7 @@<br /> if (regs->eflags & VM_MASK)<br /> goto gp_in_vm86;<br /> <br />- if (!(regs->xcs & 3))<br />+ if (!user_mode(regs))<br /> goto gp_in_kernel;<br /> <br /> current->thread.error_code = error_code;<br />@@ -713,7 +713,7 @@<br /> * check for kernel mode by just checking the CPL<br /> * of CS.<br /> */<br />- if ((regs->xcs & 3) == 0)<br />+ if (!user_mode(regs))<br /> goto clear_TF_reenable;<br /> }<br /> <br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-26 12:47 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>