CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Ladislav Michl: [PATCH] ds1337 3/4</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Ladislav Michl" href="/groupie.php?aid=21763" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/7"> [7]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/7/268" onclick="this.href='/lkml/headers'+'/2005/4/7/268';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/7/268">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/3/31/279">First message in thread</a></li><li><a href="/lkml/2005/4/7/151">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/7/242">Greg KH</a><ul><li class="origin"><a href="/lkml/2005/4/8/95">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/95">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/145">Ladislav Michl</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/269">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/80">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/134">Ladislav Michl</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/271">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/104">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/124">Ladislav Michl</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/275">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/7/284">Greg KH</a><ul><li><a href="/lkml/2005/4/8/131">Ladislav Michl</a></li></ul></li><li><a href="/lkml/2005/4/8/79">"Jean Delvare"</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/247">Jean Delvare</a><ul><li><a href="/lkml/2005/4/7/266">Ladislav Michl</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/7/268/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 8 Apr 2005 01:18:48 +0200</td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">[PATCH] ds1337 3/4</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Ladislav Michl <></td></tr></table></td><td></td></tr></table><pre itemprop="articleBody"><br />dev_{dbg,err} functions should print client's device name. data->id can<br />be dropped from message, because device is determined by bus it hangs on<br />(it has fixed address).<br /><br />--- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-04-08 00:36:15.072302800 +0200<br />+++ linux-omap/drivers/i2c/chips/ds1337.c 2005-04-08 00:44:44.130914128 +0200<br />@@ -95,7 +95,6 @@ static inline int ds1337_read(struct i2c<br /> */<br /> static int ds1337_get_datetime(struct i2c_client *client, struct rtc_time *dt)<br /> {<br />- struct ds1337_data *data = i2c_get_clientdata(client);<br /> int result;<br /> u8 buf[7];<br /> u8 val;<br />@@ -103,9 +102,7 @@ static int ds1337_get_datetime(struct i2<br /> u8 offs = 0;<br /> <br /> if (!dt) {<br />- dev_dbg(&client->adapter->dev, "%s: EINVAL: dt=NULL\n",<br />- __FUNCTION__);<br />-<br />+ dev_dbg(&client->dev, "%s: EINVAL: dt=NULL\n", __FUNCTION__);<br /> return -EINVAL;<br /> }<br /> <br />@@ -121,8 +118,7 @@ static int ds1337_get_datetime(struct i2<br /> <br /> result = i2c_transfer(client->adapter, msg, 2);<br /> <br />- dev_dbg(&client->adapter->dev,<br />- "%s: [%d] %02x %02x %02x %02x %02x %02x %02x\n",<br />+ dev_dbg(&client->dev, "%s: [%d] %02x %02x %02x %02x %02x %02x %02x\n",<br /> __FUNCTION__, result, buf[0], buf[1], buf[2], buf[3],<br /> buf[4], buf[5], buf[6]);<br /> <br />@@ -139,14 +135,13 @@ static int ds1337_get_datetime(struct i2<br /> if (buf[5] & 0x80)<br /> dt->tm_year += 100;<br /> <br />- dev_dbg(&client->adapter->dev, "%s: secs=%d, mins=%d, "<br />+ dev_dbg(&client->dev, "%s: secs=%d, mins=%d, "<br /> "hours=%d, mday=%d, mon=%d, year=%d, wday=%d\n",<br /> __FUNCTION__, dt->tm_sec, dt->tm_min,<br /> dt->tm_hour, dt->tm_mday,<br /> dt->tm_mon, dt->tm_year, dt->tm_wday);<br /> } else {<br />- dev_err(&client->adapter->dev, "ds1337[%d]: error reading "<br />- "data! %d\n", data->id, result);<br />+ dev_err(&client->dev, "error reading data! %d\n", result);<br /> result = -EIO;<br /> }<br /> <br />@@ -155,20 +150,17 @@ static int ds1337_get_datetime(struct i2<br /> <br /> static int ds1337_set_datetime(struct i2c_client *client, struct rtc_time *dt)<br /> {<br />- struct ds1337_data *data = i2c_get_clientdata(client);<br /> int result;<br /> u8 buf[8];<br /> u8 val;<br /> struct i2c_msg msg[1];<br /> <br /> if (!dt) {<br />- dev_dbg(&client->adapter->dev, "%s: EINVAL: dt=NULL\n",<br />- __FUNCTION__);<br />-<br />+ dev_dbg(&client->dev, "%s: EINVAL: dt=NULL\n", __FUNCTION__);<br /> return -EINVAL;<br /> }<br /> <br />- dev_dbg(&client->adapter->dev, "%s: secs=%d, mins=%d, hours=%d, "<br />+ dev_dbg(&client->dev, "%s: secs=%d, mins=%d, hours=%d, "<br /> "mday=%d, mon=%d, year=%d, wday=%d\n", __FUNCTION__,<br /> dt->tm_sec, dt->tm_min, dt->tm_hour,<br /> dt->tm_mday, dt->tm_mon, dt->tm_year, dt->tm_wday);<br />@@ -195,8 +187,7 @@ static int ds1337_set_datetime(struct i2<br /> <br /> result = i2c_transfer(client->adapter, msg, 1);<br /> if (result < 0) {<br />- dev_err(&client->adapter->dev, "ds1337[%d]: error "<br />- "writing data! %d\n", data->id, result);<br />+ dev_err(&client->dev, "error writing data! %d\n", result);<br /> result = -EIO;<br /> } else {<br /> result = 0;<br />@@ -208,7 +199,7 @@ static int ds1337_set_datetime(struct i2<br /> static int ds1337_command(struct i2c_client *client, unsigned int cmd,<br /> void *arg)<br /> {<br />- dev_dbg(&client->adapter->dev, "%s: cmd=%d\n", __FUNCTION__, cmd);<br />+ dev_dbg(&client->dev, "%s: cmd=%d\n", __FUNCTION__, cmd);<br /> <br /> switch (cmd) {<br /> case DS1337_GET_DATE:<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-08 01:26 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>