CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Ladislav Michl: [PATCH] ds1337 1/4</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Ladislav Michl" href="/groupie.php?aid=21763" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/7"> [7]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/7/275" onclick="this.href='/lkml/headers'+'/2005/4/7/275';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/7/275">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/3/31/279">First message in thread</a></li><li><a href="/lkml/2005/4/7/151">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/7/242">Greg KH</a><ul><li><a href="/lkml/2005/4/7/268">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/95">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/145">Ladislav Michl</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/269">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/80">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/134">Ladislav Michl</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/271">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/8/104">"Jean Delvare"</a><ul><li><a href="/lkml/2005/4/8/124">Ladislav Michl</a></li></ul></li></ul></li><li class="origin"><a href="/lkml/2005/4/7/284">Ladislav Michl</a><ul><li><a href="/lkml/2005/4/7/284">Greg KH</a><ul><li><a href="/lkml/2005/4/8/131">Ladislav Michl</a></li></ul></li><li><a href="/lkml/2005/4/8/79">"Jean Delvare"</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/7/247">Jean Delvare</a><ul><li><a href="/lkml/2005/4/7/266">Ladislav Michl</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/7/275/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 8 Apr 2005 01:17:58 +0200</td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">[PATCH] ds1337 1/4</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Ladislav Michl <></td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Thu, Apr 07, 2005 at 02:18:39PM -0700, Greg KH wrote:<br />> Jean's point is that you should send an individual patch for each type<br />> of individual change. It's ok to say "patch 3 requires you to have<br />> applied patches 1 and 2" and so on. Please split this up better.<br /><br />Here it is...<br /><br />Use i2c_transfer to send message, so we get proper bus locking.<br /><br />===== drivers/i2c/chips/ds1337.c 1.1 vs edited =====<br />--- 1.1/drivers/i2c/chips/ds1337.c 2005-03-31 22:58:08 +02:00<br />+++ edited/drivers/i2c/chips/ds1337.c 2005-04-08 00:18:45 +02:00<br />@@ -3,7 +3,7 @@<br /> *<br /> * Copyright (C) 2005 James Chapman <jchapman@katalix.com><br /> *<br />- * based on linux/drivers/acron/char/pcf8583.c<br />+ * based on linux/drivers/acorn/char/pcf8583.c<br /> * Copyright (C) 2000 Russell King<br /> *<br /> * This program is free software; you can redistribute it and/or modify<br />@@ -119,8 +119,7 @@<br /> msg[1].len = sizeof(buf);<br /> msg[1].buf = &buf[0];<br /> <br />- result = client->adapter->algo->master_xfer(client->adapter,<br />- &msg[0], 2);<br />+ result = i2c_transfer(client->adapter, msg, 2);<br /> <br /> dev_dbg(&client->adapter->dev,<br /> "%s: [%d] %02x %02x %02x %02x %02x %02x %02x\n",<br />@@ -194,8 +193,7 @@<br /> msg[0].len = sizeof(buf);<br /> msg[0].buf = &buf[0];<br /> <br />- result = client->adapter->algo->master_xfer(client->adapter,<br />- &msg[0], 1);<br />+ result = i2c_transfer(client->adapter, msg, 1);<br /> if (result < 0) {<br /> dev_err(&client->adapter->dev, "ds1337[%d]: error "<br /> "writing data! %d\n", data->id, result);<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-08 01:38 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>