CINXE.COM
LKML: Roman Zippel: Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Roman Zippel: Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Roman Zippel" href="/groupie.php?aid=23" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/15"> [15]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/15/119" onclick="this.href='/lkml/headers'+'/2005/12/15/119';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/15/119">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/15/54">First message in thread</a></li><li><a href="/lkml/2005/12/15/54">Al Viro</a><ul><li class="origin"><a href="/lkml/2005/12/15/122">Roman Zippel</a><ul><li><a href="/lkml/2005/12/15/122">Christoph Hellwig</a><ul><li><a href="/lkml/2005/12/15/126">Roman Zippel</a></li></ul></li><li><a href="/lkml/2005/12/15/212">Al Viro</a></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Thu, 15 Dec 2005 12:58:12 +0100 (CET)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Roman Zippel <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Hi,<br /><br />On Thu, 15 Dec 2005, Al Viro wrote:<br /><br />> Move the sanity check for NR_IRQS being no more than 1<<HARDIRQ_BITS<br />> from asm-m68k/hardirq.h to asm-m68k/irq.h; needed since NR_IRQS is<br />> not necessary know at the points of inclusion of asm/hardirq.h due<br />> to the rather ugly header dependencies on m68k. Fix is by far simpler<br />> than trying to massage those dependencies...<br /><br />I disagree.<br /><br />> diff --git a/include/asm-m68k/hardirq.h b/include/asm-m68k/hardirq.h<br />> index 728318b..5e1c582 100644<br />> --- a/include/asm-m68k/hardirq.h<br />> +++ b/include/asm-m68k/hardirq.h<br />> @@ -14,13 +14,4 @@ typedef struct {<br />> <br />> #define HARDIRQ_BITS 8<br />> <br />> -/*<br />> - * The hardirq mask has to be large enough to have<br />> - * space for potentially all IRQ sources in the system<br />> - * nesting on a single CPU:<br />> - */<br />> -#if (1 << HARDIRQ_BITS) < NR_IRQS<br />> -# error HARDIRQ_BITS is too low!<br />> -#endif<br />> -<br />> #endif<br /><br />You separate the definition from the check, now you push the <br />responsibility to get the order right to the header users.<br />Sorry, but I prefer to fix the header dependencies than scatter things <br />which belong together over multiple files.<br /><br />bye, Roman<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-15 13:01 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>