CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Chris Wright: [PATCH 07/11] [NETFILTER]: Fix DHCP + MASQUERADE problem</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Chris Wright" href="/groupie.php?aid=852" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/9"> [Sep]</a> 聽 <a class="nb" href="/lkml/2005/9/14"> [14]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/9/14/425" onclick="this.href='/lkml/headers'+'/2005/9/14/425';">[headers]</a>聽 <a href="/lkml/bounce/2005/9/14/425">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/9/14/412">First message in thread</a></li><li><a href="/lkml/2005/9/14/412">Chris Wright</a><ul><li><a href="/lkml/2005/9/14/413">Chris Wright</a><ul><li><a href="/lkml/2005/9/14/443">David Lang</a><ul><li><a href="/lkml/2005/9/14/446">Andrew Morton</a><ul><li><a href="/lkml/2005/9/14/447">David Lang</a></li></ul></li><li><a href="/lkml/2005/9/15/24">Chris Wright</a><ul><li><a href="/lkml/2005/9/15/140">David Lang</a></li></ul></li></ul></li><li><a href="/lkml/2005/9/15/137">Martin Mares</a></li></ul></li><li><a href="/lkml/2005/9/14/414">Chris Wright</a></li><li><a href="/lkml/2005/9/14/415">Chris Wright</a></li><li><a href="/lkml/2005/9/14/416">Chris Wright</a></li><li><a href="/lkml/2005/9/14/417">Chris Wright</a></li><li><a href="/lkml/2005/9/14/418">Chris Wright</a></li><li><a href="/lkml/2005/9/14/419">Chris Wright</a></li><li><a href="/lkml/2005/9/14/420">Chris Wright</a></li><li><a href="/lkml/2005/9/14/421">Chris Wright</a></li><li><a href="/lkml/2005/9/14/423">Chris Wright</a></li><li class="origin"><a href="">Chris Wright</a></li><li><a href="/lkml/2005/9/15/97">Alexander Nyberg</a><ul><li><a href="/lkml/2005/9/15/293">Chris Wright</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/9/14/425/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 14 Sep 2005 18:03:50 -0700</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Chris Wright <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">[PATCH 07/11] [NETFILTER]: Fix DHCP + MASQUERADE problem</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">-stable review patch. If anyone has any objections, please let us know.<br />------------------<br /><br />In 2.6.13-rcX the MASQUERADE target was changed not to exclude local<br />packets for better source address consistency. This breaks DHCP clients<br />using UDP sockets when the DHCP requests are caught by a MASQUERADE rule<br />because the MASQUERADE target drops packets when no address is configured<br />on the outgoing interface. This patch makes it ignore packets with a<br />source address of 0.<br /><br />Thanks to Rusty for this suggestion.<br /><br />Signed-off-by: Patrick McHardy <kaber@trash.net><br />Signed-off-by: Chris Wright <chrisw@osdl.org><br />---<br /> net/ipv4/netfilter/ipt_MASQUERADE.c | 6 ++++++<br /> 1 files changed, 6 insertions(+)<br /><br />Index: linux-2.6.13.y/net/ipv4/netfilter/ipt_MASQUERADE.c<br />===================================================================<br />--- linux-2.6.13.y.orig/net/ipv4/netfilter/ipt_MASQUERADE.c<br />+++ linux-2.6.13.y/net/ipv4/netfilter/ipt_MASQUERADE.c<br />@@ -95,6 +95,12 @@ masquerade_target(struct sk_buff **pskb,<br /> IP_NF_ASSERT(ct && (ctinfo == IP_CT_NEW || ctinfo == IP_CT_RELATED<br /> || ctinfo == IP_CT_RELATED + IP_CT_IS_REPLY));<br /> <br />+ /* Source address is 0.0.0.0 - locally generated packet that is<br />+ * probably not supposed to be masqueraded.<br />+ */<br />+ if (ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.ip == 0)<br />+ return NF_ACCEPT;<br />+<br /> mr = targinfo;<br /> rt = (struct rtable *)(*pskb)->dst;<br /> newsrc = inet_select_addr(out, rt->rt_gateway, RT_SCOPE_UNIVERSE);<br />--<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-09-15 03:11 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>