LKML: Jernej =?utf-8?B?xaBrcmFiZWM=?=: Re: [PATCH 2/3] drm/sun4i: Add more parameters to sunxi

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Jernej =?utf-8?B?xaBrcmFiZWM=?=: Re: [PATCH 2/3] drm/sun4i: Add more parameters to sunxi_engine commit callback</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Jernej =?utf-8?B?xaBrcmFiZWM=?=" href="/groupie.php?aid=" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2024"> [2024]</a> 聽 <a class="nb" href="/lkml/2024/2"> [Feb]</a> 聽 <a class="nb" href="/lkml/2024/2/22"> [22]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2024/2/22/1376" onclick="this.href='/lkml/headers'+'/2024/2/22/1376';">[headers]</a>聽 <a href="/lkml/bounce/2024/2/22/1376">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2024/2/16/1166">First message in thread</a></li><li><a href="/lkml/2024/2/16/1166">=?UTF-8?q?Ond=C5=99ej=20Jirman?=</a><ul><li><a href="/lkml/2024/2/16/1165">=?UTF-8?q?Ond=C5=99ej=20Jirman?=</a><ul><li class="origin"><a href="">Jernej =?utf-8?B?xaBrcmFiZWM=?=</a></li></ul></li><li><a href="/lkml/2024/2/16/1167">=?UTF-8?q?Ond=C5=99ej=20Jirman?=</a><ul><li><a href="/lkml/2024/2/22/1396">Jernej =?utf-8?B?xaBrcmFiZWM=?=</a></li></ul></li><li><a href="/lkml/2024/2/16/1168">=?UTF-8?q?Ond=C5=99ej=20Jirman?=</a><ul><li><a href="/lkml/2024/2/21/822">Maxime Ripard</a><ul><li><a href="/lkml/2024/2/21/886">=?utf-8?Q?Ond=C5=99ej?= Jirman</a></li><li><a href="/lkml/2024/2/22/1401">Jernej =?utf-8?B?xaBrcmFiZWM=?=</a><ul><li><a href="/lkml/2024/2/24/66">=?utf-8?Q?Ond=C5=99ej?= Jirman</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">From</td><td class="rp" itemprop="author">Jernej 艩krabec <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 2/3] drm/sun4i: Add more parameters to sunxi_engine commit callback</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Thu, 22 Feb 2024 20:18:13 +0100</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Dne petek, 16. februar 2024 ob 20:04:25 CET je Ond艡ej Jirman napisal(a): > From: Ondrej Jirman <megi@xff.cz> > > These will be needed later on when we move layer configuration to > crtc update. > > Signed-off-by: Ondrej Jirman <megi@xff.cz> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +++- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 5 ++++- > drivers/gpu/drm/sun4i/sunxi_engine.h | 13 ++++++++++--- > 4 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c > index 335fd0edb904..e89eb96d3131 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > @@ -69,7 +69,9 @@ static void sun4i_backend_disable_color_correction(struct sunxi_engine *engine) > SUN4I_BACKEND_OCCTL_ENABLE, 0); > } > > -static void sun4i_backend_commit(struct sunxi_engine *engine) > +static void sun4i_backend_commit(struct sunxi_engine *engine, > + struct drm_crtc *crtc, > + struct drm_atomic_state *state) > { > DRM_DEBUG_DRIVER("Committing changes\n"); > > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/sun4i_crtc.c > index c06d7cd45388..18e74047b0f5 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c > +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c > @@ -91,7 +91,7 @@ static void sun4i_crtc_atomic_flush(struct drm_crtc *crtc, > > DRM_DEBUG_DRIVER("Committing plane changes\n"); > > - sunxi_engine_commit(scrtc->engine); > + sunxi_engine_commit(scrtc->engine, crtc, state); > > if (event) { > crtc->state->event = NULL; > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c > index 1e681314e379..bdeb9b80e038 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -16,6 +16,7 @@ > #include <linux/platform_device.h> > #include <linux/reset.h> > > +#include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_crtc.h> > #include <drm/drm_framebuffer.h> > @@ -249,7 +250,9 @@ int sun8i_mixer_drm_format_to_hw(u32 format, u32 *hw_format) > return -EINVAL; > } > > -static void sun8i_mixer_commit(struct sunxi_engine *engine) > +static void sun8i_mixer_commit(struct sunxi_engine *engine, > + struct drm_crtc *crtc, > + struct drm_atomic_state *state) > { > DRM_DEBUG_DRIVER("Committing changes\n"); > > diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h > index ec8cf9b2bda4..ec0c4932f15c 100644 > --- a/drivers/gpu/drm/sun4i/sunxi_engine.h > +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h > @@ -7,6 +7,7 @@ > #define _SUNXI_ENGINE_H_ > > struct drm_plane; > +struct drm_crtc; > struct drm_device; > struct drm_crtc_state; > struct drm_display_mode; > @@ -59,7 +60,9 @@ struct sunxi_engine_ops { > * > * This function is optional. > */ > - void (*commit)(struct sunxi_engine *engine); > + void (*commit)(struct sunxi_engine *engine, > + struct drm_crtc *crtc, > + struct drm_atomic_state *state); > > /** > * @layers_init: > @@ -144,12 +147,16 @@ struct sunxi_engine { > /** > * sunxi_engine_commit() - commit all changes of the engine > * @engine: pointer to the engine > + * @crtc: pointer to crtc the engine is associated with > + * @state: atomic state > */ > static inline void > -sunxi_engine_commit(struct sunxi_engine *engine) > +sunxi_engine_commit(struct sunxi_engine *engine, > + struct drm_crtc *crtc, > + struct drm_atomic_state *state) > { > if (engine->ops && engine->ops->commit) > - engine->ops->commit(engine); > + engine->ops->commit(engine, crtc, state); > } > > /** > </pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2024-05-27 15:17 聽聽 [from the cache] 漏2003-2020 <a href="http://blog.jasper.es/">Jasper Spaans</a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: Jernej =?utf-8?B?xaBrcmFiZWM=?=: Re: [PATCH 2/3] drm/sun4i: Add more parameters to sunxi_engine commit callback