CINXE.COM

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US" lang="en-US"> <head> <link rel="icon" href="/static/ded2583c00a1/hgicon.png" type="image/png" /> <meta name="robots" content="index, nofollow"/> <link rel="stylesheet" href="/static/ded2583c00a1/style-gitweb.css" type="text/css" /> <style type="text/css"> div.feed { float: right; } a img { border-width: 0px; } div.log_link { width: 80px; background-color: white; } div.log_body { padding-left: 96px; } </style> <script type="text/javascript" src="/static/ded2583c00a1/mercurial.js"></script> <meta property="og:image" content="/static/ded2583c00a1/moz-logo-bw-rgb.svg"/> <meta property="og:type" content="website"/> <title>autoland: changeset 759116:b242a74d26b05a576b4828c1976a906dfaa1b7ad</title> <link rel="alternate" type="application/atom+xml" href="/integration/autoland/atom-log" title="Atom feed for autoland"/> <link rel="alternate" type="application/rss+xml" href="/integration/autoland/rss-log" title="RSS feed for autoland"/> <meta property="og:title" content="autoland @ b242a74d26b0" /> <meta property="og:url" content="/integration/autoland/rev/b242a74d26b0" /> <meta property="og:description" content="Bug 1924882 - [devtools] Use default color in getThemeColorAsRgba when getCssVariableColor returns null. r=devtools-reviewers,bomsy." /> </head> <body> <div class="page_header"> <div class="logo"> <a href="https://firefox-source-docs.mozilla.org/contributing/vcs/mercurial.html"> <img src="/static/ded2583c00a1/moz-logo-bw-rgb.svg" alt="mercurial" /> </a> </div> <a href="/">Mercurial</a> > <a href="/integration">integration</a> > <a href="/integration/autoland">autoland</a> / changeset / b242a74d26b05a576b4828c1976a906dfaa1b7ad </div> <div class="page_nav"> <div> <a href="/integration/autoland/summary">summary</a> | <a href="/integration/autoland/shortlog/b242a74d26b0">shortlog</a> | <a href="/integration/autoland/log/b242a74d26b0">changelog</a> | <a href="/integration/autoland/pushloghtml">pushlog</a> | <a href="/integration/autoland/graph/b242a74d26b0">graph</a> | <a href="/integration/autoland/tags">tags</a> | <a href="/integration/autoland/bookmarks">bookmarks</a> | <a href="/integration/autoland/branches">branches</a> | <a href="/integration/autoland/file/b242a74d26b0">files</a> | changeset | <a href="/integration/autoland/raw-rev/b242a74d26b0">raw</a> | <a href="/integration/autoland/archive/b242a74d26b0.zip">zip</a> | <a href="/integration/autoland/help">help</a> </div> <div class="search"> <form id="searchform" action="/integration/autoland/log"> <input name="rev" type="text" value="" size="40" /> <div id="hint">Find changesets by keywords (author, files, the commit message), revision number or hash, or <a href="/integration/autoland/help/revsets">revset expression</a>.</div> </form> </div> </div> <div class="title"> <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1924882">Bug 1924882</a> - [devtools] Use default color in getThemeColorAsRgba when getCssVariableColor returns null. r=devtools-reviewers,bomsy. <span class="logtags"></span> </div> <div class="title_text"> <table cellspacing="0"> <tr><td>author</td><td>Nicolas Chevobbe <nchevobbe@mozilla.com></td></tr> <tr><td></td><td class="date age">Tue, 22 Oct 2024 08:45:01 +0000</td></tr> <tr> <td>changeset 759116</td> <td style="font-family:monospace"><a class="list" href="/integration/autoland/rev/b242a74d26b05a576b4828c1976a906dfaa1b7ad">b242a74d26b05a576b4828c1976a906dfaa1b7ad</a></td> </tr> <tr> <td>parent 759115</td> <td style="font-family:monospace"> <a class="list" href="/integration/autoland/rev/01534b93408ce725f8de7889f3290c14b7b1caf7">01534b93408ce725f8de7889f3290c14b7b1caf7</a> </td> </tr> <tr> <td>child 759117</td> <td style="font-family:monospace"> <a class="list" href="/integration/autoland/rev/b4aa9dc712e1a1d906ad33fcf991059d08d80d0f">b4aa9dc712e1a1d906ad33fcf991059d08d80d0f</a> </td> </tr> <tr><td>push id</td><td><a href="/integration/autoland/pushloghtml?changeset=b242a74d26b05a576b4828c1976a906dfaa1b7ad">216437</a></td></tr> <tr><td>push user</td><td>nchevobbe@mozilla.com</td></tr> <tr><td>push date</td><td class="date age">Tue, 22 Oct 2024 08:47:39 +0000</td></tr> <tr><td>treeherder</td><td>autoland@b242a74d26b0 [<a href="https://treeherder.mozilla.org/jobs?repo=autoland&revision=b242a74d26b05a576b4828c1976a906dfaa1b7ad">default view</a>] [<a href="https://treeherder.mozilla.org/jobs?repo=autoland&revision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception">failures only]</td></tr> <tr><td>perfherder</td><td>[<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=autoland&originalRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&newProject=autoland&newRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&framework=1" target="_blank">talos</a>] [<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=autoland&originalRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&newProject=autoland&newRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&framework=2" target="_blank">build metrics</a>] [<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=autoland&originalRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&newProject=autoland&newRevision=b242a74d26b05a576b4828c1976a906dfaa1b7ad&framework=6" target="_blank">platform microbench</a>] (compared to previous push)</td></tr> <tr><td>reviewers</td><td><a href="/integration/autoland/log?rev=reviewer%28devtools-reviewers%29&revcount=50">devtools-reviewers</a>, <a href="/integration/autoland/log?rev=reviewer%28bomsy%29&revcount=50">bomsy</a></td></tr> <tr><td>bugs</td><td><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1924882">1924882</a></td></tr> <tr><td>milestone</td><td>133.0a1</td></tr> <tr><td>first release with</td><td><div><div class="firefoxreleasecsetentry"> <div>nightly linux32</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/c71b363392005528e26f9cf9b72b308f9691866a">c71b36339200</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#c71b36339200nightlylinux3220241022213158">20241022213158</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-21-31-58-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly linux64</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/c71b363392005528e26f9cf9b72b308f9691866a">c71b36339200</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#c71b36339200nightlylinux6420241022213158">20241022213158</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-21-31-58-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly mac</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/c71b363392005528e26f9cf9b72b308f9691866a">c71b36339200</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#c71b36339200nightlymac20241022213158">20241022213158</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-21-31-58-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win32</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/c71b363392005528e26f9cf9b72b308f9691866a">c71b36339200</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#c71b36339200nightlywin3220241022213158">20241022213158</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-21-31-58-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win64</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/c71b363392005528e26f9cf9b72b308f9691866a">c71b36339200</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#c71b36339200nightlywin6420241022213158">20241022213158</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-21-31-58-mozilla-central/">files</a> </div></div></div></td></tr> <tr><td>last release without</td><td><div><div class="firefoxreleasecsetentry"> <div>nightly linux32</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/1fc2a51d27a0c4340b0e92d4cb4b5c017157a286">1fc2a51d27a0</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#1fc2a51d27a0nightlylinux3220241022095236">20241022095236</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-09-52-36-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly linux64</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/1fc2a51d27a0c4340b0e92d4cb4b5c017157a286">1fc2a51d27a0</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#1fc2a51d27a0nightlylinux6420241022095236">20241022095236</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-09-52-36-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly mac</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/1fc2a51d27a0c4340b0e92d4cb4b5c017157a286">1fc2a51d27a0</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#1fc2a51d27a0nightlymac20241022095236">20241022095236</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-09-52-36-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win32</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/1fc2a51d27a0c4340b0e92d4cb4b5c017157a286">1fc2a51d27a0</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#1fc2a51d27a0nightlywin3220241022095236">20241022095236</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-09-52-36-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win64</div> <div class="firefoxreleasecsetdetails"> <a href="/integration/autoland/rev/1fc2a51d27a0c4340b0e92d4cb4b5c017157a286">1fc2a51d27a0</a> / 133.0a1 / <a href="/integration/autoland/firefoxreleases#1fc2a51d27a0nightlywin6420241022095236">20241022095236</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2024/10/2024-10-22-09-52-36-mozilla-central/">files</a> </div></div></div></td></tr> </table></div> <div class="page_body description"><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1924882">Bug 1924882</a> - [devtools] Use default color in getThemeColorAsRgba when getCssVariableColor returns null. r=devtools-reviewers,bomsy. This shouldn't happen but we got report that it did. Let's hotfix this first so we avoid crashes, and we'll come up with a proper fix later. Differential Revision: <a href="https://phabricator.services.mozilla.com/D226316">https://phabricator.services.mozilla.com/D226316</a></div> <div class="list_head"></div> <div class="title_text"> <table cellspacing="0"> <tr class="parity0"> <td><a class="list" href="/integration/autoland/diff/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">devtools/client/netmonitor/src/widgets/WaterfallBackground.js</a></td> <td></td> <td class="link"> <a href="/integration/autoland/file/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">file</a> | <a href="/integration/autoland/annotate/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">annotate</a> | <a href="/integration/autoland/diff/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">diff</a> | <a href="/integration/autoland/comparison/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">comparison</a> | <a href="/integration/autoland/log/b242a74d26b05a576b4828c1976a906dfaa1b7ad/devtools/client/netmonitor/src/widgets/WaterfallBackground.js">revisions</a> </td> </tr> </table></div> <div class="page_body diffblocks"><div class="diffblock"><pre class="sourcelines"> <a href="#l1.1"></a><span id="l1.1" class="difflineminus">--- a/devtools/client/netmonitor/src/widgets/WaterfallBackground.js</span> <a href="#l1.2"></a><span id="l1.2" class="difflineplus">+++ b/devtools/client/netmonitor/src/widgets/WaterfallBackground.js</span> <a href="#l1.3"></a><span id="l1.3" class="difflineat">@@ -150,17 +150,23 @@ class WaterfallBackground {</span> <a href="#l1.4"></a><span id="l1.4"> * The name of the variable defining the color</span> <a href="#l1.5"></a><span id="l1.5"> * @return {Array} RGBA array for the color.</span> <a href="#l1.6"></a><span id="l1.6"> */</span> <a href="#l1.7"></a><span id="l1.7"> getThemeColorAsRgba(colorVariableName) {</span> <a href="#l1.8"></a><span id="l1.8"> const colorStr = getCssVariableColor(</span> <a href="#l1.9"></a><span id="l1.9"> colorVariableName,</span> <a href="#l1.10"></a><span id="l1.10"> document.ownerGlobal</span> <a href="#l1.11"></a><span id="l1.11"> );</span> <a href="#l1.12"></a><span id="l1.12" class="difflineminus">- const { r, g, b, a } = InspectorUtils.colorToRGBA(colorStr, document);</span> <a href="#l1.13"></a><span id="l1.13" class="difflineplus">+ const { r, g, b, a } = InspectorUtils.colorToRGBA(</span> <a href="#l1.14"></a><span id="l1.14" class="difflineplus">+ // In theory colorStr shouldn't be null, but we got report that it was for someone (Bug 1924882).</span> <a href="#l1.15"></a><span id="l1.15" class="difflineplus">+ // Until we actually get to the cause of this, let's use a default color that works</span> <a href="#l1.16"></a><span id="l1.16" class="difflineplus">+ // for both light and dark themes.</span> <a href="#l1.17"></a><span id="l1.17" class="difflineplus">+ colorStr || "#000",</span> <a href="#l1.18"></a><span id="l1.18" class="difflineplus">+ document</span> <a href="#l1.19"></a><span id="l1.19" class="difflineplus">+ );</span> <a href="#l1.20"></a><span id="l1.20"> return [r, g, b, a * 255];</span> <a href="#l1.21"></a><span id="l1.21"> }</span> <a href="#l1.22"></a><span id="l1.22"> </span> <a href="#l1.23"></a><span id="l1.23"> destroy() {</span> <a href="#l1.24"></a><span id="l1.24"> this.setImageElement("waterfall-background", null);</span> <a href="#l1.25"></a><span id="l1.25"> }</span> <a href="#l1.26"></a><span id="l1.26"> }</span> <a href="#l1.27"></a><span id="l1.27"> </span></pre></div></div> <div class="page_footer"> <div class="page_footer_text">autoland</div> <div class="page_footer_text" style="padding-left: 10px">Deployed from <a href="https://hg.mozilla.org/hgcustom/version-control-tools/rev/ded2583c00a1">ded2583c00a1</a> at 2024-10-24T15:36:54Z.</div> <div class="rss_logo"> <a href="/integration/autoland/rss-log">RSS</a> <a href="/integration/autoland/atom-log">Atom</a> </div> <br /> </div> </body> </html>