CINXE.COM
Fix a -Wlogical-not-parentheses warning in zephyr | Review Request | Review Board
<!DOCTYPE html> <html class="reviewable-page"data-ink-color-scheme="light" data-theme="light"> <head> <meta http-equiv="X-UA-Compatible" content="IE=10; IE=9; IE=8; IE=7; IE=EDGE" /> <title>Fix a -Wlogical-not-parentheses warning in zephyr | Review Request | Review Board</title> <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" /> <meta property="og:title" content="Review Request #731: Fix a -Wlogical-not-parentheses warning in zephyr" /> <meta property="og:description" content="Fix a -Wlogical-not-parentheses warning in zephyr" /> <meta property="og:url" content="https://reviews.imfreedom.org/r/731/" /> <meta name="twitter:title" content="Review Request #731: Fix a -Wlogical-not-parentheses warning in zephyr" /> <meta name="twitter:description" content="Fix a -Wlogical-not-parentheses warning in zephyr" /> <meta name="twitter:url" content="https://reviews.imfreedom.org/r/731/" /> <meta name="twitter:label1" content="Repository" /> <meta name="twitter:data1" content="pidgin/pidgin" /> <meta name="twitter:label2" content="Branch" /> <meta name="twitter:data2" content="release-2.x.y" /> <script type="text/javascript"> var AJAX_SERIAL = "1739850268", TEMPLATE_SERIAL = "1734508815", SITE_ROOT = "/", MANUAL_URL = 'https://www.reviewboard.org/docs/manual/7.0/', STATIC_URLS = { 'rb/images/favicon_notify.ico': '/static/rb/images/favicon_notify.43aac64f3b61.ico', 'rb/images/resize-grip.png': '/static/rb/images/resize-grip.b822a7e06419.png', 'rb/images/logo.png': '/static/rb/images/logo.cc81d3ae01b2.png' }; </script> <link rel="shortcut icon" type="image/x-icon" href="/static/rb/images/favicon.3161c840d49e.ico" /> <link rel="apple-touch-icon-precomposed" type="image/png" href="/static/rb/images/apple-home-icon.fd8758a2ebe3.png" /> <link href="/static/rb/css/common.min.0d669a5311e5.css" rel="stylesheet" type="text/css" /> <link href="/static/djblets/css/ui.min.eb108b206fbf.css" rel="stylesheet" type="text/css" /> <link href="/static/rb/css/reviews.min.804a7ef66e9d.css" rel="stylesheet" type="text/css" /> <style type="text/css"> .ew { background: #ee3434; } </style> <link href="/static/ext/rbpowerpack.extension.PowerPackExtension/css/default.min.0e31d8a33dee.css" rel="stylesheet" type="text/css" /> <link href="/static/ext/rbintegrations.extension.RBIntegrationsExtension/css/fields.min.67c87e1db8fe.css" rel="stylesheet" type="text/css" /> <script type="text/javascript" src="/static/lib/js/3rdparty-base.min.6c92630a910a.js" charset="utf-8"></script> </head> <body class="reviewable-page "> <div id="container"> <header class="rb-c-topbar" id="topbar" role="banner"> <div class="rb-c-topbar__header" id="headerbar"> <div class="rb-c-topbar__product-info" id="rbinfo"> <a href="/" aria-label="Home"> <img class="rb-c-topbar__product-logo" id="logo" aria-hidden="true" src="/static/rb/images/logo.cc81d3ae01b2.png" srcset="/static/rb/images/logo.cc81d3ae01b2.png 1x, /static/rb/images/logo@2x.4e25cc3cacef.png 2x" alt="" border="0" width="60" height="57"> </a> <h1 class="rb-c-topbar__product-name" id="title"> <a href="/" aria-label="Home">Review Board</a> <span class="rb-c-topbar__product-version"> 7.0.3 </span> </h1> </div> <div class="rb-c-topbar__nav-toggle" id="nav_toggle" role="button" aria-label="Toggle navigation"><span class="ink-i-mobile-menu"></span></div> <div class="rb-c-topbar__search" roel="search"> <form method="get" action="/search/"> <div class="rb-c-search-field" id="search"> <span class="fa fa-search"></span> <input class="rb-c-search-field__input" type="search" name="q" placeholder="Search" id="search_field" /> </div> </form> </div> <nav class="rb-c-topbar__actions rb-c-actions" aria-label="Account and product" role="presentation"> <menu class="rb-c-actions__content" id="accountnav" role="menu"> <li class="rb-c-actions__action" role="presentation"><a id="action-login" href="/account/login/?next=/r/731/" role="menuitem" > Log in </a></li> <li class="rb-c-actions__action" id="action-support-menu" role="menuitem"><a href="#" role="presentation" aria-label="Support"><label class="rb-c-actions__action-label"> Support </label><span class="ink-i-dropdown"></span></a><a id="action-documentation" href="https://www.reviewboard.org/docs/manual/7.0/" role="menuitem" style="display: none;"> Documentation </a><a id="action-support" href="/support/" role="menuitem" style="display: none;"> Get Support </a></li> <li class="rb-c-actions__action" id="action-follow-menu" role="menuitem"><a href="#" role="presentation" aria-label="Follow"><label class="rb-c-actions__action-label"> Follow </label><span class="ink-i-dropdown"></span></a><a id="action-follow-rss" href="https://www.reviewboard.org/news/" role="menuitem" style="display: none;"><span class="rb-icon-rss"></span> Review Board News </a><a id="action-follow-bluesky" href="https://bsky.app/profile/reviewboard.bsky.social" role="menuitem" style="display: none;"><span class="rb-icon-brand-bluesky"></span> BlueSky </a><a id="action-follow-facebook" href="https://facebook.com/reviewboard.org" role="menuitem" style="display: none;"><span class="rb-icon-brand-facebook"></span> Facebook </a><a id="action-follow-linkedin" href="https://www.linkedin.com/company/reviewboard/" role="menuitem" style="display: none;"><span class="rb-icon-brand-linkedin"></span> LinkedIn </a><a id="action-follow-mastodon" href="https://mastodon.online/@reviewboard" role="menuitem" style="display: none;"><span class="rb-icon-brand-mastodon"></span> Mastodon </a><a id="action-follow-reddit" href="https://reddit.com/r/reviewboard" role="menuitem" style="display: none;"><span class="rb-icon-brand-reddit"></span> Reddit </a><a id="action-follow-twitter" href="https://twitter.com/reviewboard/" role="menuitem" style="display: none;"><span class="rb-icon-brand-twitter"></span> Twitter </a><a id="action-follow-youtube" href="https://www.youtube.com/channel/UCTnwzlRTtx8wQOmyXiA_iCg" role="menuitem" style="display: none;"><span class="rb-icon-brand-youtube"></span> YouTube </a></li> </menu> </nav> </div> <div class="rb-c-topbar__nav-container" id="navbar-container"> <nav class="rb-c-topbar__main-nav" aria-label="Main pages"> <ul class="rb-c-topbar__nav-items" id="navbar"> <li class="rb-c-topbar__nav-item"><a href="/r/">All Review Requests</a></li> <li class="rb-c-topbar__nav-item"><a href="/users/">Users</a></li> <li class="rb-c-topbar__nav-item"><a href="/groups/">Groups</a></li> </ul> </nav> <noscript> <div class="rb-c-alert -is-error"> <div class="rb-c-alert__content"> <h3 class="rb-c-alert__heading">Review Board requires JavaScript to be enabled.</h3> <p> Please make sure that JavaScript is enabled in your browser. If you are using a browser extension to selectively enable or disable JavaScript, make sure it's enabled for this server. </p> </div> </div> </noscript> </div> </header> <div id="page-sidebar" class="rb-c-page-sidebar"> <header class="rb-c-page-sidebar__mobile-header"> <ul class="rb-c-page-sidebar__mobile-user-actions"> <li><a href="/account/login/?next=/r/731/"><span class="fa fa-sign-in"></span> Log in</a></li> <li><a href="/account/register/">Register</a></li> </ul> </header> <div id="page-sidebar-panes" class="rb-c-page-sidebar__panes"> <div id="page-sidebar-main-pane" class="rb-c-page-sidebar__pane -is-shown"> <div id="page-sidebar-main-content" class="rb-c-page-sidebar__pane-content"> <nav class="rb-c-sidebar" aria-label="Sidebar"> <ul class="rb-c-sidebar__items"> <li class="rb-c-sidebar__section -is-mobile-only"> <header class="rb-c-sidebar__section-header">Review Board</header> <ul class="rb-c-sidebar__items"> <li class="rb-c-sidebar__nav-item"><a class="rb-c-sidebar__item-label" href="/r/">All Review Requests</a></li> <li class="rb-c-sidebar__nav-item"><a class="rb-c-sidebar__item-label" href="/users/">Users</a></li> <li class="rb-c-sidebar__nav-item"><a class="rb-c-sidebar__item-label" href="/groups/">Groups</a></li> </ul> </li> </ul> </nav> </div> </div> </div> <footer class="rb-c-page-sidebar__mobile-footer"> <ul> <li><a href="https://www.reviewboard.org/docs/manual/7.0/"><span class="fa fa-book"></span> Docs</a></li> <li><a href="/support/"><span class="fa fa-question-circle"></span> Support</a></li> </ul> </footer> </div> <div id="page-container"> <div id="unified-banner" class="rb-c-unified-banner"> <div class="rb-c-unified-banner__review"> <div class="rb-c-unified-banner__controls"> <div class="rb-c-unified-banner__mode-selector"></div> <div class="rb-c-unified-banner__draft-actions"> </div> <menu class="rb-c-unified-banner__review-actions rb-c-actions" role="menu"> </menu> </div> <div class="rb-c-unified-banner__changedesc"> <p> <label for="field_change_description"> Describe your changes (optional): </label> </p> <pre id="field_change_description" class="field field-text-area" data-field-id="field_change_description"></pre> </div> </div> <div class="rb-c-unified-banner__dock"></div> </div> <div id="error"></div> <div id="content_container"> <main id="content"> <div id="review-request"> <div id="review-request-banners"></div> <section class="rb-c-review-request" aria-label="Review Request information"> <header class="rb-c-review-request__header"> <div class="rb-c-actions" role="presentation"> <menu class="rb-c-actions__content -is-left" role="menu"> </menu> <menu class="rb-c-actions__content -is-right -has-mobile-menu" role="menu"> <li class="rb-c-actions__action rb-o-mobile-menu-label" role="presentation"> <a href="#" aria-controls="review-request-mobile-actions-menu-content" aria-expanded="false" aria-haspopup="true" ><span class="ink-i-mobile-menu" aria-hidden="true"></span></a> </li> <div class="rb-o-mobile-menu" id="review-request-mobile-actions-menu-content"> <li class="rb-c-actions__action" role="presentation"><a id="action-download-diff" href="/r/731/diff/raw/" role="menuitem" > Download Diff </a></li> </div> </menu> </div> <menu class="rb-c-review-request-tabs" role="menu"> <li class="rb-c-review-request-tabs__tab -is-active" role="presentation"> <a role="menuitem" href="/r/731/" aria-current="page" >Reviews</a> </li> <li class="rb-c-review-request-tabs__tab" role="presentation"> <a role="menuitem" href="/r/731/diff/#index_header" >Diff</a> </li> </menu> </header> <div class="rb-c-review-request__fields"> <div class="rb-c-review-request__summary"> <div class="rb-c-review-request-fieldset -has-inline-fields" aria-label="Review request summary" role="group"> <div class="rb-c-review-request-field" aria-labelledby="field_label_summary" role="group"> <label class="rb-c-review-request-field__label" id="field_label_summary" for="field_summary">Summary</label> <div class="rb-c-review-request-field__value"> <h1 id="field_summary" data-field-id="summary" class="field required editable" >Fix a -Wlogical-not-parentheses warning in zephyr</h1> </div> </div> </div> <p> Review Request #<a href="/r/731/">731</a> — Created June 7, 2021 and submitted <time class="timesince" datetime="2021-06-07T23:00:28.188489-05:00">June 7, 2021, 11 p.m.</time> </p> </div> <div class="rb-c-review-request__warning" id="review-request-warning"></div> <div class="rb-c-review-request__details" id="review-request-details"> <div class="rb-c-review-request-fieldset -is-tabular -has-inline-fields" id="fieldset_info_head" aria-labelledby="fieldset_label_info" role="group"> <h3 class="rb-c-review-request-fieldset__label" id="fieldset_label_info"> Information </h3> <div class="rb-c-review-request-field" aria-labelledby="field_label_submitter" role="group"> <label class="rb-c-review-request-field__label" id="field_label_submitter" for="field_submitter">Owner</label> <div class="rb-c-review-request-field__value"> <span id="field_submitter" data-field-id="submitter" class="field required editable" ><a class="user" href="/users/grim/">grim</a></span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_repository" role="group"> <label class="rb-c-review-request-field__label" id="field_label_repository" for="field_repository">Repository</label> <div class="rb-c-review-request-field__value"> <span id="field_repository" data-field-id="repository" class="field " >pidgin/pidgin</span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_branch" role="group"> <label class="rb-c-review-request-field__label" id="field_label_branch" for="field_branch">Branch</label> <div class="rb-c-review-request-field__value"> <span id="field_branch" data-field-id="branch" class="field editable" >release-2.x.y</span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_bugs_closed" role="group"> <label class="rb-c-review-request-field__label" id="field_label_bugs_closed" for="field_bugs_closed">Bugs</label> <div class="rb-c-review-request-field__value"> <span id="field_bugs_closed" data-field-id="bugs_closed" class="field comma-editable editable" ><a class="bug" href="/r/731/bugs/PIDGIN-17528/">PIDGIN-17528</a></span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_depends_on" role="group"> <label class="rb-c-review-request-field__label" id="field_label_depends_on" for="field_depends_on">Depends On</label> <div class="rb-c-review-request-field__value"> <span id="field_depends_on" data-field-id="depends_on" class="field comma-editable editable" ></span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_commit_id" role="group"> <label class="rb-c-review-request-field__label" id="field_label_commit_id" for="field_commit_id">Commit</label> <div class="rb-c-review-request-field__value"> <span id="field_commit_id" data-field-id="commit_id" class="field " >4b2eee4409dc</span> </div> </div> </div> <div class="rb-c-review-request-fieldset -is-tabular -has-inline-fields" id="fieldset_reviewers_head" aria-labelledby="fieldset_label_reviewers" role="group"> <h3 class="rb-c-review-request-fieldset__label" id="fieldset_label_reviewers"> Reviewers </h3> <div class="rb-c-review-request-field" aria-labelledby="field_label_target_groups" role="group"> <label class="rb-c-review-request-field__label" id="field_label_target_groups" for="field_target_groups">Groups</label> <div class="rb-c-review-request-field__value"> <span id="field_target_groups" data-field-id="target_groups" class="field comma-editable editable" ><a href="/groups/pidgin/">pidgin</a></span> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_target_people" role="group"> <label class="rb-c-review-request-field__label" id="field_label_target_people" for="field_target_people">People</label> <div class="rb-c-review-request-field__value"> <span id="field_target_people" data-field-id="target_people" class="field comma-editable editable" ></span> </div> </div> </div> </div> <div class="rb-c-review-request__main" id="review-request-main"> <div class="rb-c-review-request-fieldset" aria-label="Main fields" role="group"> <div class="rb-c-review-request-field" aria-labelledby="field_label_description" role="group"> <label class="rb-c-review-request-field__label" id="field_label_description" for="field_description">Description</label> <div class="rb-c-review-request-field__value"> <pre id="field_description" data-field-id="description" class="field required rich-text field-text-area editable" data-allow-markdown="True" >Fix a -Wlogical-not-parentheses warning in zephyr</pre> </div> </div> <div class="rb-c-review-request-field" aria-labelledby="field_label_testing_done" role="group"> <label class="rb-c-review-request-field__label" id="field_label_testing_done" for="field_testing_done">Testing Done</label> <div class="rb-c-review-request-field__value"> <pre id="field_testing_done" data-field-id="testing_done" class="field rich-text field-text-area editable" data-allow-markdown="True" ><p>Compiled using clang with <code>-Wlogical-not-parentheses</code> and verified the warning was gone.</p></pre> </div> </div> </div> </div> <div class="rb-c-review-request__extra" id="review-request-extra"> <div class="rb-c-review-request-fieldset" aria-label="Extra fields" role="group"> <div id="file-list-container" class="rb-c-review-request-field" style="display: none;" aria-labelledby="file_list_container_label" aria-busy="true" aria-live="polite" role="group"> <label class="rb-c-review-request-field__label" id="file_list_container_label"> Files <span class="djblets-o-spinner" aria-label="Loading file attachments"></span> </label> <div class="rb-c-review-request__value" id="file-list"> <br clear="both" /> </div> </div> <div class="rb-c-review-request__field" id="issue-summary" style="display: none;" aria-labelledby="issue_summary_table_label" role="group"> <a name="issue-summary"></a> <label class="rb-c-review-request-field__label" id="issue_summary_table_label">Issues</label> <div class="rb-c-review-request-field__value"> <div class="rb-c-review-request-field-tabular rb-c-issue-summary-table"> <header class="rb-c-review-request-field-tabular__header"> <div class="rb-c-review-request-field-tabular__filters"> <select class="rb-c-review-request-field-tabular__filter rb-c-issue-summary-table__reviewer-filter"> <option value="all">All Users</option> </select> </div> <ul class="rb-c-tabs"> <li class="rb-c-tabs__tab -is-active" title="Open issues" data-issue-state="open"> <label class="rb-c-tabs__tab-label"> <span class="rb-icon rb-icon-issue-open"></span> <span class="rb-c-issue-summary-table__counter">0</span> </label> </li> <li class="rb-c-tabs__tab" title="Issues waiting for verification" data-issue-state="verifying"> <label class="rb-c-tabs__tab-label"> <span class="rb-icon rb-icon-issue-verifying"></span> <span class="rb-c-issue-summary-table__counter">0</span> </label> </li> <li class="rb-c-tabs__tab" title="Resolved issues" data-issue-state="resolved"> <label class="rb-c-tabs__tab-label"> <span class="rb-icon rb-icon-issue-resolved"></span> <span class="rb-c-issue-summary-table__counter">0</span> </label> </li> <li class="rb-c-tabs__tab" title="Dropped issues" data-issue-state="dropped"> <label class="rb-c-tabs__tab-label"> <span class="rb-icon rb-icon-issue-dropped"></span> <span class="rb-c-issue-summary-table__counter">0</span> </label> </li> <li class="rb-c-tabs__tab" title="All issues" data-issue-state="all"> <label class="rb-c-tabs__tab-label"> <span class="rb-c-tabs__tab-label-full">All Issues:</span> <span class="rb-c-tabs__tab-label-short">All:</span> <span class="rb-c-issue-summary-table__counter">0</span> </label> </li> </ul> </header> <table class="rb-c-review-request-field-tabular__data"> <thead> <tr> <th class="-is-sortable">Description</th> <th class="-is-sortable">From</th> <th class="-is-sortable">Last Updated</th> </tr> </thead> <tbody> </tbody> </table> </div> </div> </div> </div> </div> </div> </section> </div> <div id="reviews"> <ul id="view_controls"> <li> <a href="#" id="expand-all"> <span class="fa fa-plus"></span> <span>Expand All</span> </a> </li> <li> <a href="#" id="collapse-all"> <span class="fa fa-minus"></span> <span>Collapse All</span> </a> </li> </ul> <div id="review704" class="review-request-page-entry review has-avatar"> <a name="review704"></a> <div class="box-statuses"> <div class="box-status ship-it"> <div class="avatar-container"> <img src="https://secure.gravatar.com/avatar/05006805126be7e0c1b0fe9e0d1211d9?s=48&d=mm" alt="QuLogic" width="48" height="48" srcset="https://secure.gravatar.com/avatar/05006805126be7e0c1b0fe9e0d1211d9?s=48&d=mm 1x, https://secure.gravatar.com/avatar/05006805126be7e0c1b0fe9e0d1211d9?s=96&d=mm 2x, https://secure.gravatar.com/avatar/05006805126be7e0c1b0fe9e0d1211d9?s=144&d=mm 3x" class="avatar djblets-o-avatar"> </div> <div class="labels-container"> <label class="ship-it-label"> Ship it! </label> </div> </div> </div> <div class="review-request-page-entry-contents "> <div class="header "> <div class="collapse-button btn"><div class="rb-icon rb-icon-collapse-review"></div></div> <div class="header-details"> <div class="summary"> <span class="review-request-page-entry-title"> <a href="/users/QuLogic/" class="user">QuLogic</a> </span></div> <a href="#review704" class="timestamp"><time class="timesince" datetime="2021-06-07T22:55:53.106391-05:00">June 7, 2021, 10:55 p.m.</time></a> </div> </div> <div class="banners"></div> <div class="body"> <ol class="review-comments"> <li> <div class="review-comment-details "> <div class="review-comment"> <pre class="reviewtext body_top rich-text">Ship It!</pre> </div> </div> <div class="review-comment-thread"> <div id="rcbt-704" class="comment-section" data-context-type="body_top" data-reply-anchor-prefix="header-reply" > <div class="issue-indicator"></div> <ol class="reply-comments"> </ol> </div> </div> </li> <li style="display: none;"> <div class="review-comment-details"> <div class="review-comment"> <pre class="reviewtext body_bottom rich-text"></pre> </div> </div> <div class="review-comment-thread"> <div id="rcbb-704" class="comment-section" data-context-type="body_bottom" data-reply-anchor-prefix="footer-reply" > <div class="issue-indicator"></div> <ol class="reply-comments"> </ol> </div> </div> </li> </ol> </div> </div> </div> <div id="changedesc589" class="review-request-page-entry changedesc has-avatar"> <a name="changedesc589"></a> <div class="box-statuses"> <div class="box-status "> <div class="avatar-container"> <img src="https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=48&d=mm" alt="grim" width="48" height="48" srcset="https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=48&d=mm 1x, https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=96&d=mm 2x, https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=144&d=mm 3x" class="avatar djblets-o-avatar"> </div> <div class="labels-container"></div> </div> </div> <div class="review-request-page-entry-contents collapsed"> <div class="header "> <div class="collapse-button btn"><div class="rb-icon rb-icon-expand-review"></div></div> <div class="header-details"> <div class="summary"> <span class="review-request-page-entry-title">Review request changed</span></div> <a href="#changedesc589" class="timestamp"><time class="timesince" datetime="2021-06-07T22:58:48.792075-05:00">June 7, 2021, 10:58 p.m.</time></a> </div> </div> <div class="banners"></div> <div class="body"> <dl class="rb-c-review-request-changed-fields" aria-label="Changed fields"> <div class="rb-c-review-request-changed-fields__field"> <dt class="rb-c-review-request-changed-fields__label" id="changedesc-589-testing-done-label"> Testing Done: </dt> <dd class="rb-c-review-request-changed-fields__value" aria-labelledby="changedesc-589-testing-done-label"> <table class="diffed-text-area"><tr class="replace-old"> <td class="marker">~</td> <td class="marker"> </td> <td class="line rich-text"><p>Compiled with <code>-Wlogical-not-parentheses</code> and verified the warning was gone.</p></td></tr><tr class="replace-new"> <td class="marker"> </td> <td class="marker">~</td> <td class="line rich-text"><p>Compiled<span class="hl"> using clang</span> with <code>-Wlogical-not-parentheses</code> and verified the warning was gone.</p></td></tr></table> </dd> </div> </dl> </div> </div> </div> <div id="changedesc590" class="review-request-page-entry changedesc has-avatar"> <a name="changedesc590"></a> <div class="box-statuses"> <div class="box-status "> <div class="avatar-container"> <img src="https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=48&d=mm" alt="grim" width="48" height="48" srcset="https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=48&d=mm 1x, https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=96&d=mm 2x, https://secure.gravatar.com/avatar/c52ffc14fb858840c9c9378f7b24a79e?s=144&d=mm 3x" class="avatar djblets-o-avatar"> </div> <div class="labels-container"></div> </div> </div> <div class="review-request-page-entry-contents "> <div class="header "> <div class="collapse-button btn"><div class="rb-icon rb-icon-collapse-review"></div></div> <div class="header-details"> <div class="summary"> <span class="review-request-page-entry-title">Review request changed</span></div> <a href="#changedesc590" class="timestamp"><time class="timesince" datetime="2021-06-07T23:00:28.188489-05:00">June 7, 2021, 11 p.m.</time></a> </div> </div> <div class="banners"></div> <div class="body"> <dl class="rb-c-review-request-changed-fields" aria-label="Changed fields"> <div class="rb-c-review-request-changed-fields__field"> <dt class="rb-c-review-request-changed-fields__label" id="changedesc-590-status-label"> Status: </dt> <dd class="rb-c-review-request-changed-fields__value" aria-labelledby="changedesc-590-status-label"> Completed </dd> </div> </dl> </div> </div> </div> </div> </main> </div> </div> </div> <div id="activity-indicator" style="display: none;"> <span class="ink-c-spinner"></span> <span class="indicator-text">Loading...</span> </div> <script src="/jsi18n/"></script> <script type="text/javascript" src="/static/lib/js/3rdparty.min.fb70252812ab.js" charset="utf-8"></script> <script type="text/javascript" src="/static/djblets/js/jquery.gravy.min.cd98f6cef6a8.js" charset="utf-8"></script> <script type="text/javascript" src="/static/djblets/js/utils.min.d9ed9ed2fdfc.js" charset="utf-8"></script> <script type="text/javascript" src="/static/djblets/js/extensions.min.2fe2a8d87c8f.js" charset="utf-8"></script> <script type="text/javascript" src="/static/djblets/js/widgets.min.69290e03edbf.js" charset="utf-8"></script> <script type="text/javascript" src="/static/rb/js/base.min.1e5b9dd8cec5.js" charset="utf-8"></script> <script type="text/javascript" src="/static/rb/js/ui.min.7dd5adbfad45.js" charset="utf-8"></script> <script> RB.Product = {"isRelease": true, "manualURL": "https://www.reviewboard.org/docs/manual/7.0/", "name": "Review Board", "version": "7.0.3", "versionInfo": [7, 0, 3, 0, "final", 0]}; RB.UserSession.create({"authenticated": false, "loginURL": "/account/login/"}); RB.EnabledFeatures = { issueVerification: true, generalComments: true, unifiedBanner: true }; </script> <script type="text/javascript" src="/static/rb/js/reviews.min.29269a355c01.js" charset="utf-8"></script> <script type="text/javascript" src="/static/rb/js/review-request-page.min.e26bb8cf0455.js" charset="utf-8"></script> <script> RB.PageManager.setupPage({ viewType: RB.ReviewRequestPage.ReviewRequestPageView, viewOptions: {}, modelType: RB.ReviewRequestPage.ReviewRequestPage, modelAttrs: { updatesURL: "/r/731/_updates/", "checkForUpdates": true, "editorData": {"closeDescriptionRenderedText": "", "commits": null, "forceViewUserDraft": false, "hasDraft": false, "mutableByUser": false, "showSendEmail": true, "statusMutableByUser": false, "userDraftExists": false, "viewingUserDraft": false}, "extraReviewRequestDraftData": {}, "lastActivityTimestamp": "2021-06-08T03:58:48Z", "reviewRequestData": {"branch": "release-2.x.y", "bugTrackerURL": "/r/731/bugs/--bug_id--/", "bugsClosed": ["PIDGIN-17528"], "closeDescription": "", "closeDescriptionRichText": false, "description": "Fix a -Wlogical-not-parentheses warning in zephyr", "descriptionRichText": false, "hasDraft": false, "id": 731, "lastUpdatedTimestamp": "2021-06-08T03:58:48Z", "localSitePrefix": "", "public": true, "repository": {"id": 1, "name": "pidgin/pidgin", "requiresBasedir": false, "requiresChangeNumber": false, "scmtoolName": "Mercurial", "supportsPostCommit": true}, "reviewURL": "/r/731/", "state": "CLOSE_SUBMITTED", "summary": "Fix a -Wlogical-not-parentheses warning in zephyr", "targetGroups": [{"name": "pidgin", "url": "/groups/pidgin/"}], "targetPeople": [], "testingDone": "Compiled using clang with `-Wlogical-not-parentheses` and verified the warning was gone.", "testingDoneRichText": true} }, modelOptions: {parse: true} }); </script> <script type="text/javascript" src="/static/ext/rbpowerpack.extension.PowerPackExtension/js/libpdf.min.5ca6e7b502db.js" charset="utf-8"></script> <script type="text/javascript" src="/static/ext/rbpowerpack.extension.PowerPackExtension/js/powerpack-pdf.min.399535a89655.js" charset="utf-8"></script> <script type="text/javascript" src="/static/ext/rbintegrations.extension.RBIntegrationsExtension/js/fields.min.f373fc4d93aa.js" charset="utf-8"></script> <script> RB.PageManager.beforeRender(function(page) { var reviewRequestEditorView = page.reviewRequestEditorView, model = reviewRequestEditorView.model; reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.SummaryFieldView({ el: $('#field_summary'), fieldID: 'summary', fieldLabel: 'Summary', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.DescriptionFieldView({ el: $('#field_description'), fieldID: 'description', fieldLabel: 'Description', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.TestingDoneFieldView({ el: $('#field_testing_done'), fieldID: 'testing_done', fieldLabel: 'Testing Done', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.OwnerFieldView({ el: $('#field_submitter'), fieldID: 'submitter', fieldLabel: 'Owner', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.BranchFieldView({ el: $('#field_branch'), fieldID: 'branch', fieldLabel: 'Branch', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.BugsFieldView({ el: $('#field_bugs_closed'), fieldID: 'bugs_closed', fieldLabel: 'Bugs', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.DependsOnFieldView({ el: $('#field_depends_on'), fieldID: 'depends_on', fieldLabel: 'Depends On', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.TargetGroupsFieldView({ el: $('#field_target_groups'), fieldID: 'target_groups', fieldLabel: 'Groups', model: model })); reviewRequestEditorView.addFieldView( new RB.ReviewRequestFields.TargetPeopleFieldView({ el: $('#field_target_people'), fieldID: 'target_people', fieldLabel: 'People', model: model })); }); RB.PageManager.beforeRender(function(page) { page.addEntryView(new RB.ReviewRequestPage.InitialStatusUpdatesEntryView({ el: $('#initial_status_updates'), reviewRequestEditorView: page.reviewRequestEditorView, model: new RB.ReviewRequestPage.StatusUpdatesEntry({ id: '0', collapsed: true, addedTimestamp: "2021-06-08T03:48:17Z", updatedTimestamp: "2021-06-08T03:48:17Z", typeID: 'initial_status_updates', "pendingStatusUpdates": false, reviewRequestEditor: page.model.reviewRequestEditor }, { parse: true }) })); page.addEntryView(new RB.ReviewRequestPage.ReviewEntryView({ el: $('#review704'), reviewRequestEditorView: page.reviewRequestEditorView, model: new RB.ReviewRequestPage.ReviewEntry({ id: '704', collapsed: false, addedTimestamp: "2021-06-08T03:55:53Z", updatedTimestamp: "2021-06-08T03:55:53Z", typeID: 'review', "reviewData": {"authorName": "QuLogic", "bodyBottom": "", "bodyTop": "Ship It!", "id": 704, "public": true, "shipIt": true}, reviewRequestEditor: page.model.reviewRequestEditor }, { parse: true }) })); page.addEntryView(new RB.ReviewRequestPage.ChangeEntryView({ el: $('#changedesc589'), reviewRequestEditorView: page.reviewRequestEditorView, model: new RB.ReviewRequestPage.ChangeEntry({ id: '589', collapsed: true, addedTimestamp: "2021-06-08T03:58:48Z", updatedTimestamp: "2021-06-08T03:58:48Z", typeID: 'changedesc', "pendingStatusUpdates": false, reviewRequestEditor: page.model.reviewRequestEditor }, { parse: true }) })); page.addEntryView(new RB.ReviewRequestPage.ChangeEntryView({ el: $('#changedesc590'), reviewRequestEditorView: page.reviewRequestEditorView, model: new RB.ReviewRequestPage.ChangeEntry({ id: '590', collapsed: false, addedTimestamp: "2021-06-08T04:00:28Z", updatedTimestamp: "2021-06-08T04:00:28Z", typeID: 'changedesc', "pendingStatusUpdates": false, reviewRequestEditor: page.model.reviewRequestEditor }, { parse: true }) })); }); </script> <script> RB.PageManager.beforeRender(function(page) { page.addActionView(new RB.Actions.ActionView({ el: $('#action-login'), model: new RB.Actions.Action( {"actionId": "login", "visible": true, "domID": "action-login", "label": "Log in", "url": "/account/login/?next=/r/731/"}, { parse: true }) })); page.addActionView(new RB.Actions.MenuActionView({ el: $('#action-support-menu'), model: new RB.Actions.MenuAction( {"actionId": "support-menu", "visible": true, "domID": "action-support-menu", "label": "Support", "url": "#", "children": ["documentation", "support"]}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-documentation'), model: new RB.Actions.Action( {"actionId": "documentation", "visible": true, "domID": "action-documentation", "label": "Documentation", "url": "https://www.reviewboard.org/docs/manual/7.0/"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-support'), model: new RB.Actions.Action( {"actionId": "support", "visible": true, "domID": "action-support", "label": "Get Support", "url": "/support/"}, { parse: true }) })); page.addActionView(new RB.Actions.MenuActionView({ el: $('#action-follow-menu'), model: new RB.Actions.MenuAction( {"actionId": "follow-menu", "visible": true, "domID": "action-follow-menu", "label": "Follow", "url": "#", "children": ["follow-rss", "follow-bluesky", "follow-facebook", "follow-linkedin", "follow-mastodon", "follow-reddit", "follow-twitter", "follow-youtube"]}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-rss'), model: new RB.Actions.Action( {"actionId": "follow-rss", "visible": true, "domID": "action-follow-rss", "iconClass": "rb-icon-rss", "label": "Review Board News", "url": "https://www.reviewboard.org/news/"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-bluesky'), model: new RB.Actions.Action( {"actionId": "follow-bluesky", "visible": true, "domID": "action-follow-bluesky", "iconClass": "rb-icon-brand-bluesky", "label": "BlueSky", "url": "https://bsky.app/profile/reviewboard.bsky.social"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-facebook'), model: new RB.Actions.Action( {"actionId": "follow-facebook", "visible": true, "domID": "action-follow-facebook", "iconClass": "rb-icon-brand-facebook", "label": "Facebook", "url": "https://facebook.com/reviewboard.org"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-linkedin'), model: new RB.Actions.Action( {"actionId": "follow-linkedin", "visible": true, "domID": "action-follow-linkedin", "iconClass": "rb-icon-brand-linkedin", "label": "LinkedIn", "url": "https://www.linkedin.com/company/reviewboard/"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-mastodon'), model: new RB.Actions.Action( {"actionId": "follow-mastodon", "visible": true, "domID": "action-follow-mastodon", "iconClass": "rb-icon-brand-mastodon", "label": "Mastodon", "url": "https://mastodon.online/@reviewboard"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-reddit'), model: new RB.Actions.Action( {"actionId": "follow-reddit", "visible": true, "domID": "action-follow-reddit", "iconClass": "rb-icon-brand-reddit", "label": "Reddit", "url": "https://reddit.com/r/reviewboard"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-twitter'), model: new RB.Actions.Action( {"actionId": "follow-twitter", "visible": true, "domID": "action-follow-twitter", "iconClass": "rb-icon-brand-twitter", "label": "Twitter", "url": "https://twitter.com/reviewboard/"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-follow-youtube'), model: new RB.Actions.Action( {"actionId": "follow-youtube", "visible": true, "domID": "action-follow-youtube", "iconClass": "rb-icon-brand-youtube", "label": "YouTube", "url": "https://www.youtube.com/channel/UCTnwzlRTtx8wQOmyXiA_iCg"}, { parse: true }) })); page.addActionView(new RB.Actions.ActionView({ el: $('#action-download-diff'), model: new RB.Actions.Action( {"actionId": "download-diff", "visible": true, "domID": "action-download-diff", "label": "Download Diff", "url": "/r/731/diff/raw/"}, { parse: true }) })); }); </script> </body> </html>