CINXE.COM
The WebM Project | Code Reviews
<!DOCTYPE html> <!--[if lt IE 7]><html class="no-js lt-ie9 lt-ie8 lt-ie7"><![endif]--> <!--[if IE 7]><html class="no-js lt-ie9 lt-ie8"><![endif]--> <!--[if IE 8]><html class="no-js lt-ie9"><![endif]--> <!--[if gt IE 8]><!--><html class="no-js"><!--<![endif]--> <head> <meta charset="utf-8"> <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>The WebM Project | Code Reviews </title> <meta name="google-site-verification" content="k48O6zrnreFHIEU7DjyqpOK8REgb_WD1_OyorIE4Ti0"> <!-- Included CSS Files --> <link rel="stylesheet" href="/media/css/bootstrap.css" nonce="B86dTeWMlIeciTohppd7ww"> <style type="text/css"> body { padding-top: 80px; } </style> <link rel="stylesheet" href="/media/css/bootstrap-responsive.css" nonce="B86dTeWMlIeciTohppd7ww"> <link rel="stylesheet" href="/media/css/webm.css" nonce="B86dTeWMlIeciTohppd7ww"> <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js" nonce="B86dTeWMlIeciTohppd7ww"></script> <script src="https://storage.googleapis.com/downloads.webmproject.org/media/js/bootstrap.min.js" nonce="B86dTeWMlIeciTohppd7ww"></script> <link rel="shortcut icon" href="/media/images/webm-48px.png"> <!-- <link rel="apple-touch-icon" href="/media/images/apple-touch-icon.png"> <link rel="apple-touch-icon" sizes="72x72" href="/media/images/apple-touch-icon-72x72.png"> <link rel="apple-touch-icon" sizes="114x114" href="/media/images/apple-touch-icon-114x114.png"> --> </head> <body class="None" id="None"> <div id="not-footer"> <header> <div class="navbar navbar-fixed-top"> <div class="navbar-inner"> <div class="container"> <!-- .btn-navbar is used as the toggle for collapsed navbar content --> <a class="btn btn-navbar" data-toggle="collapse" data-target=".nav-collapse"> <span class="icon-bar"></span> <span class="icon-bar"></span> <span class="icon-bar"></span> </a> <a class="brand" href="/" title="The WebM Project" style="padding: 0; margin: 3px 20px 0 0;"><img src="/media/images/webm-558x156.png" alt="" style="height: 46px; padding: 0"></a> <!-- Everything we want hidden at 940px or less, place within .nav-collapse --> <div class="nav-collapse collapse"> <ul class="nav"> <li class="dropdown"> <a href="#" class="dropdown-toggle" data-toggle="dropdown"> About <b class="caret"></b> </a> <ul class="dropdown-menu"> <li><a href="/about/">About WebM</a></li> <li><a href="/about/press/">Press Info</a></li> <li><a href="/about/faq/">FAQ</a></li> <li><a href="/about/discuss/">Discuss</a></li> <li><a href="/about/supporters/">Supporters</a></li> <li class="divider"></li> <li><a href="/vp9/">VP9 Codec</a></li> </ul> </li> <li class="dropdown"> <a href="#" class="dropdown-toggle" data-toggle="dropdown">Developer <b class="caret"></b></a> <ul class="dropdown-menu"> <li><a href="/code/">Overview & Code Repos</a></li> <li><a href="/code/contribute/">Contribute</a> <li><a href="/code/contribute/submitting-patches/">Submitting Patches</a></li> <li><a href="/code/contribute/code-reviews/">Code Reviews</a></li> <li><a href="/code/contribute/workflow/">Workflow</a></li> <li><a href="/code/contribute/conventions/">Conventions</a></li> <li class="divider"></li> <li><a href="https://build.webmproject.org/jenkins/">Continuous Integration</a></li> <li class="divider"></li> <li><a href="/code/bug-reporting/">Bug Reporting</a></li> <li><a href="/code/build-prerequisites/">Build Prerequisites</a></li> <li><a href="/code/repository-layout/">Repository Layout</a></li> <li><a href="/code/releases/">Releases</a></li> <li><a href="/code/roadmap/">Roadmap</a></li> </ul> </li> <li class="dropdown"> <a href="#" class="dropdown-toggle" data-toggle="dropdown">Docs <b class="caret"></b></a> <ul class="dropdown-menu"> <li><a href="/vp9/">Draft VP9 Bitstream Format</a></li> <li><a href="/vp9/mp4/">VP Codec ISO Media File Format Binding (MP4)</a></li> <li><a href="/vp9/levels/">VP9 Levels and Decoder Testing</a></li> <li><a href="http://datatracker.ietf.org/doc/rfc6386/">RFC 6386: VP8 Data Format</a></li> <li><a href="/docs/container/">WebM Container Format</a></li> <li><a href="/docs/webm-encryption/">WebM Encryption</a></li> <li><a href="http://tools.ietf.org/html/draft-ietf-payload-vp8">VP8 RTP Proposal (Draft)</a></li> <li><a href="/docs/encoder-parameters/">Encoder Examples</a></li> <li><a href="http://wiki.webmproject.org/">Wiki</a></li> </ul> </li> <li><a href="/tools/">Tools</a></li> </ul> <script type="text/javascript" src="https://www.google.com/jsapi" nonce="B86dTeWMlIeciTohppd7ww"></script> <script type="text/javascript" nonce="B86dTeWMlIeciTohppd7ww"> google.load('search', '1'); google.setOnLoadCallback(function() { google.search.CustomSearchControl.attachAutoCompletion( '003367860376540524942:a7a4auyo1la', document.getElementById('q'), 'cse-search-box'); }); </script> <form action="https://www.google.com/cse" class="navbar-search pull-right searchbox"> <div class="control-group"> <div class="controls"> <div class="input-prepend"> <span class="add-on"><i class="icon-search"></i></span><input type="text" name="q" id="q" autocomplete="on" class="span2" placeholder="" style="background-image: none;"> <input type="hidden" name="cx" value="003367860376540524942:a7a4auyo1la"> <input type="hidden" name="ie" value="UTF-8"> </div> </div> </div> </form> </div> </div><!-- /container --> </div> </div> </header> <div class="container"> <div class="row"> <div class="span10 offset1"> <ul class="breadcrumb"> <li><a href="/"> Home </a><span class="divider">></span> </li> <li><a href="/code/"> Code </a><span class="divider">></span> </li> <li><a href="/code/contribute/"> Contribute </a><span class="divider">></span> </li> <li class="active"> Code Reviews </li> </ul> </div> </div> <div class="row"> <div class="span10 offset1"> <h2>Code Reviews</h2> <p><a class="btn btn-mini btn-primary toggle-all tocbutton pull-right" href="#">Show Contents</a></p> <div class="toc"> <ul> <li><a href="#reviewing-a-change">Reviewing a Change</a></li> <li><a href="#verifying-a-change">Verifying a Change</a></li> <li><a href="#viewing-diffs-and-comments">Viewing Diffs and Comments</a></li> <li><a href="#adding-comments">Adding Comments</a></li> </ul> </div> <p>This page describes the WebM Project code review process.</p> <h3 id="reviewing-a-change">Reviewing a Change</h3> <p>To be the Approver for a change, you need to determine the following:</p> <ul> <li>Is this change valid?</li> <li>Does this change introduce design flaws that will cause problems in the future?</li> <li>Does this change following the best practices that have been established for this project?</li> <li>Is this change a good way to perform the described function?</li> <li>Does this change introduce any security or instability risks?</li> </ul> <p>Depending on the branch this change will be committed to, some of these criteria are relaxed. See the <a href="/code/repository-layout/">repository layout</a> page for more information on our branch policy.</p> <p>If you approve of the change, you will then mark it with LGTM ("Looks Good to Me") within Gerrit.</p> <h3 id="verifying-a-change">Verifying a Change</h3> <p>To verify a change, you should:</p> <ul> <li>Patch the change into your local client using one of the Download commands.</li> <li>Build and test the change.</li> <li>Within Gerrit use <strong>Publish Comments</strong> to mark the commit as "Verified", or "Fails" (and add a message explaining what problems were identified).</li> </ul> <h3 id="viewing-diffs-and-comments">Viewing Diffs and Comments</h3> <p>To open the details of the change within Gerrit, click on the <strong>Id number</strong> or <strong>Subject</strong> of a change. To compare the established code with the updated code, click the file name under <strong>Side-by-side diffs</strong>.</p> <h3 id="adding-comments">Adding Comments</h3> <p>Anyone in the community can use Gerrit to add inline comments to code submissions. A good comment will be relevant to the line or section of code to which it is attached in Gerrit. It might be a short and constructive suggestion about how a line of code could be improved, or it might be an explanation from the author about why the code makes sense the way it is.</p> <p>To add an inline comment, double-click the relevant line of the code and write your comment in the text box that opens. When you click Save, only you can see your comment.</p> <p>To publish your comments so that others using Gerrit will be able to see them, click the <strong>Publish Comments</strong> button. Your comments will be emailed to all relevant parties for this change, including the change owner, the patch set uploader (if different from the owner), and all current reviewers.</p> </div> </div> <div class="row"> <div class="span10 offset1"> </div> </div> </div> <!-- /container --> </div> <footer class=""> <div class="container handfoot"> <div class="row"> <section class="span2 offset1"> <h6>About</h6> <ul> <li><a href="/about/">About WebM</a></li> <li><a href="/about/faq/">FAQ</a></li> <li><a href="/about/discuss/">Discuss</a></li> <li><a href="/about/supporters/">Supporters</a></li> </ul> <h6>More</h6> <ul> <li><a href="/tools/">Tools</a></li> <li><a href="/license/">Licenses</a></li> <li><a href="https://storage.googleapis.com/downloads.webmproject.org/releases/webm/index.html" class="no-ext">Downloads</a></li> <li><a href="/cross-license/">VP8 Cross-License</a></li> </ul> </section> <section class="span2"> <h6>Developer</h6> <ul> <li><a href="/code/">Overview</a></li> <li><a href="/code/contribute/">Contribute</a></li> <li><a href="/code/contribute/submitting-patches/">Submitting Patches</a></li> <li><a href="/code/contribute/code-reviews/">Code Reviews</a></li> <li><a href="/code/contribute/workflow/">Workflow</a></li> <li><a href="/code/contribute/conventions/">Conventions</a></li> <li><a href="/code/bug-reporting/">Bug Reporting</a></li> <li><a href="/code/build-prerequisites/">Build Prerequisites</a></li> <li><a href="/code/repository-layout/">Repository Layout</a></li> <li><a href="/code/releases/">Releases</a></li> <li><a href="/code/roadmap/">Roadmap</a></li> </ul> </section> <section class="span3"> <h6>Docs</h6> <ul> <li><a href="/docs/webm-sdk/">WebM Codec SDK</a></li> <li><a href="/docs/container/">WebM Container Format</a></li> <li><a href="/docs/webm-encryption/">WebM Encryption</a></li> <li><a href="http://tools.ietf.org/html/draft-ietf-payload-vp8">VP8 RTP Proposal (Draft)</a></li> <li><a href="http://datatracker.ietf.org/doc/rfc6386/">RFC 6386: VP8 Data Format</a></li> <li><a href="/docs/encoder-parameters/">Encoder Examples</a></li> <li><a href="http://wiki.webmproject.org/">Wiki</a></li> </ul> </section> <section class="span3 badges" style="text-align: center;"> <div class="row"> <div class="span3" style="margin-bottom: 1em; margin-top: 1em;"> Copyright 2010 - <script type="text/javascript" nonce="B86dTeWMlIeciTohppd7ww">document.write(new Date().getFullYear()); </script><br> The WebM Project </div> </div> <div class="row"> <div class="span3" style="margin-bottom: 1em;"> <a href="http://www.w3.org/html/logo/" class="no-ext"><img src="/media/images/html5-logo.png" alt="HTML5 Powered with CSS3 / Styling, and Semantics" title="HTML5 Powered with CSS3 / Styling, and Semantics"></a> </div> </div> <div class="row"> <div class="span3"> <a href="mailto:webmaster@webmproject.org">webmaster@webmproject.org</a> </div> </div> </section> </div> </div> </footer> <script nonce="B86dTeWMlIeciTohppd7ww"> $(document).ready(function(){ $("a.tocbutton").click(function () { $("div.toc").slideToggle("slow"); var text = $(this).text() == 'Show Contents' ? 'Hide Contents' : 'Show Contents'; $(this).text(text); }); $("a[href*='http://']:not([href*='http://www.webmproject.org'])").not("[href^='http://blog.webmproject.org']").not("[href^='http://wiki.webmproject.org']").not("[href^='http://build.webmproject.org']").attr("target","_blank").addClass("ext").attr("title","Opens new window"); }); </script> <!-- Analytics --> <script type="text/javascript" nonce="B86dTeWMlIeciTohppd7ww"> var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www."); document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E")); </script> <script type="text/javascript" nonce="B86dTeWMlIeciTohppd7ww"> try { var pageTracker = _gat._getTracker("UA-16111505-1"); pageTracker._setDomainName(".webmproject.org"); pageTracker._trackPageview(); } catch(err) {} </script> </body> </html>