CINXE.COM
Catch the "hooks" branch up with "develop" with a big ol' merge by ximinez · Pull Request #4927 · XRPLF/rippled · GitHub
<!DOCTYPE html> <html lang="en" data-color-mode="auto" data-light-theme="light" data-dark-theme="dark" data-a11y-animated-images="system" data-a11y-link-underlines="true" > <head> <meta charset="utf-8"> <link rel="dns-prefetch" href="https://github.githubassets.com"> <link rel="dns-prefetch" href="https://avatars.githubusercontent.com"> <link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com"> <link rel="dns-prefetch" href="https://user-images.githubusercontent.com/"> <link rel="preconnect" href="https://github.githubassets.com" crossorigin> <link rel="preconnect" href="https://avatars.githubusercontent.com"> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/light-3e154969b9f9.css" /><link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/dark-9c5b7a476542.css" /><link data-color-theme="dark_dimmed" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_dimmed-afda8eb0fb33.css" /><link data-color-theme="dark_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_high_contrast-2494e44ccdc5.css" /><link data-color-theme="dark_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_colorblind-56fff47acadc.css" /><link data-color-theme="light_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_colorblind-71cd4cc132ec.css" /><link data-color-theme="light_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_high_contrast-fd5499848985.css" /><link data-color-theme="light_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_tritanopia-31d17ba3e139.css" /><link data-color-theme="dark_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_tritanopia-68d6b2c79663.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-primitives-4cf0d59ab51a.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-af846850481e.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/global-e41ff91f8baa.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/github-d3b66f11d613.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/repository-1e3bbbee6b91.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/pull-requests-531a3fdee92a.css" /> <script type="application/json" id="client-env">{"locale":"en","featureFlags":["copilot_new_references_ui","copilot_beta_features_opt_in","copilot_chat_static_thread_suggestions","copilot_conversational_ux_history_refs","copilot_implicit_context","copilot_smell_icebreaker_ux","experimentation_azure_variant_endpoint","failbot_handle_non_errors","geojson_azure_maps","ghost_pilot_confidence_truncation_25","ghost_pilot_confidence_truncation_40","hovercard_accessibility","issues_react_new_timeline","issues_react_avatar_refactor","issues_react_remove_placeholders","issues_react_cache_fix_workaround","issues_react_blur_item_picker_on_close","marketing_pages_search_explore_provider","remove_child_patch","sample_network_conn_type","site_metered_billing_update","issues_react_first_time_contribution_banner","jk_navigation_in_list_view","ui_commands_respect_modals","lifecycle_label_name_updates"]}</script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/wp-runtime-118ecaabd77e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_dompurify_dist_purify_js-b73fdff77a4e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover_js-aff936e590ed.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_arianotify-polyfill_ariaNotify-polyfill_js-node_modules_github_mi-247092-740e4ddd559d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_failbot_failbot_ts-a46544e9ee5e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/environment-cd35650c2e9c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_primer_behaviors_dist_esm_index_mjs-4aa4b0e95669.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_selector-observer_dist_index_esm_js-f690fd9ae3d5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_relative-time-element_dist_index_js-6d3967acd51c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_combobox-nav_dist_index_js-node_modules_github_g-emoji-element_di-6ce195-53781cbc550f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_auto-complete-element_dist_index_js-node_modules_github_catalyst_-6afc16-3cdfa69a0406.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_text-expander-element_dist_index_js-f5498b8d4e5d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_filter-input-element_dist_index_js-node_modules_github_remote-inp-b5f1d7-492b5042c841.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-1f651a-1e3d784c897c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co-7671f1-dc6cac136d88.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/github-elements-71486356f507.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/element-registry-e3ab8405ef80.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_braintree_browser-detection_dist_browser-detection_js-node_modules_githu-bb80ec-634de60bacfa.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_lit-html_lit-html_js-ce7225a304c5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_hydro-analytics-client_dist_analytics-client_js-node_modules_gith-f3aee1-e6893db9c19e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_morphdom_dist_morphdom-e-7c534c-f8a5485c982a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_turbo_dist_turbo_es2017-esm_js-858e043fcf76.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-893f9f-6cf3320416b8.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_scroll-anchoring_dist_scroll-anchoring_esm_js-node_modules_stacktrace-pa-a71630-6f3c4f0189d8.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_color-convert_index_js-0e07cc183eed.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_quote-selection_dist_index_js-node_modules_github_session-resume_-0b5e12-889cec8cf448.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_updatable-content_updatable-content_ts-eae9df0dd562.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_task-list_ts-app_assets_modules_github_sso_ts-ui_packages-900dde-18d1c91a7872.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_sticky-scroll-into-view_ts-7cbef09a422c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_ajax-error_ts-app_assets_modules_github_behaviors_include-d0d0a6-0e9fa537dc4f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_commenting_edit_ts-app_assets_modules_github_behaviors_ht-83c235-c89801ebbe15.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/behaviors-93287f4de493.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_catalyst_lib_index_js-f6223d90c7ba.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-global-3366f6b6298e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_virtualized-list_es_index_js-node_modules_github_template-parts_lib_index_js-96453a51f920.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_stacktrace-parser_dist_stack-trace-parser_esm_js-node_modules_github_bro-b0a862-4d8589138d1e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-0e9dbe-d2bcedf65682.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_ref-selector_ts-043af64042a1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/codespaces-4158520ad4d7.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_primer_live-region-element-32d343-56ceead9587a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_delegated-events_di-cc9bcb-ea42a360c5ae.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_diffs_blob-lines_ts-app_assets_modules_github_diffs_linkable-line-n-b8c0ea-77a5219efe36.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/diffs-bc5dd2707d5a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/scanning-36c6f3eaa22e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_catalyst_lib_inde-dbbea9-9b97703a4e6a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/code-menu-3118a76a2829.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/primer-react-765944243383.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-core-cd0a67881543.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-lib-7b7b5264f6c1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/octicons-react-45c3a19dd792.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_emotion_is-prop-valid_dist_emotion-is-prop-valid_esm_js-node_modules_emo-62da9f-54c0c921f04b.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-e7dcdd-285fc29e9fa5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover-fn_js-4896ddd4b7bb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-subscriptions-menu-1490f5bef85d.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.9fa170e9435ed4b922b9.module.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/notifications-subscriptions-menu.1bcff9205c241e99cff2.module.css" /> <title>Catch the "hooks" branch up with "develop" with a big ol' merge by ximinez · Pull Request #4927 · XRPLF/rippled · GitHub</title> <meta name="route-pattern" content="/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)" data-turbo-transient> <meta name="route-controller" content="voltron_pull_requests_fragments" data-turbo-transient> <meta name="route-action" content="pull_request_layout" data-turbo-transient> <meta name="current-catalog-service-hash" content="ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b"> <meta name="request-id" content="DD6C:EFDEB:2DD155:32ADBF:67434797" data-pjax-transient="true"/><meta name="html-safe-nonce" content="86d06123cb02e52146d5b8d18e117ee7f07ae4e796ab1a2ec7b312c88c740617" data-pjax-transient="true"/><meta name="visitor-payload" content="eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDZDOkVGREVCOjJERDE1NTozMkFEQkY6Njc0MzQ3OTciLCJ2aXNpdG9yX2lkIjoiNzU0MDkzMDM2NDAxODIxNDgwNyIsInJlZ2lvbl9lZGdlIjoic291dGhlYXN0YXNpYSIsInJlZ2lvbl9yZW5kZXIiOiJzb3V0aGVhc3Rhc2lhIn0=" data-pjax-transient="true"/><meta name="visitor-hmac" content="91327690ec81dd496dd63a9ba6f391e290bc6cf323fe4bafe798f9e8d99caa7f" data-pjax-transient="true"/> <meta name="hovercard-subject-tag" content="pull_request:1740180726" data-turbo-transient> <meta name="github-keyboard-shortcuts" content="repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot" data-turbo-transient="true" /> <meta name="selected-link" value="repo_pulls" data-turbo-transient> <link rel="assets" href="https://github.githubassets.com/"> <meta name="google-site-verification" content="Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I"> <meta name="octolytics-url" content="https://collector.github.com/github/collect" /> <meta name="analytics-location" content="/<user-name>/<repo-name>/voltron/pull_requests_fragments/pull_request_layout" data-turbo-transient="true" /> <meta name="user-login" content=""> <meta name="viewport" content="width=device-width"> <meta name="description" content="High Level Overview of Change Note that this is not fully functional code! It is being merged into the hooks branch, which is still "in-development". This branch merges develop into hooks, and make..."> <link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub"> <link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub"> <meta property="fb:app_id" content="1401488693436528"> <meta name="apple-itunes-app" content="app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/XRPLF/rippled/4927/pull_request_layout" /> <meta name="twitter:image" content="https://opengraph.githubassets.com/c912ea2dcb6c9e168decd9f0caf48f7bea171766ed5f08929d7210e9e66bbf98/XRPLF/rippled/pull/4927" /><meta name="twitter:site" content="@github" /><meta name="twitter:card" content="summary_large_image" /><meta name="twitter:title" content="Catch the "hooks" branch up with "develop" with a big ol' merge by ximinez · Pull Request #4927 · XRPLF/rippled" /><meta name="twitter:description" content="High Level Overview of Change Note that this is not fully functional code! It is being merged into the hooks branch, which is still &amp;quot;in-development&amp;quot;. This branch merges develop in..." /> <meta property="og:image" content="https://opengraph.githubassets.com/c912ea2dcb6c9e168decd9f0caf48f7bea171766ed5f08929d7210e9e66bbf98/XRPLF/rippled/pull/4927" /><meta property="og:image:alt" content="High Level Overview of Change Note that this is not fully functional code! It is being merged into the hooks branch, which is still &quot;in-development&quot;. This branch merges develop into hooks..." /><meta property="og:image:width" content="1200" /><meta property="og:image:height" content="600" /><meta property="og:site_name" content="GitHub" /><meta property="og:type" content="object" /><meta property="og:title" content="Catch the "hooks" branch up with "develop" with a big ol' merge by ximinez · Pull Request #4927 · XRPLF/rippled" /><meta property="og:url" content="https://github.com/XRPLF/rippled/pull/4927" /><meta property="og:description" content="High Level Overview of Change Note that this is not fully functional code! It is being merged into the hooks branch, which is still &quot;in-development&quot;. This branch merges develop into hooks..." /><meta property="og:author:username" content="ximinez" /> <meta name="hostname" content="github.com"> <meta name="expected-hostname" content="github.com"> <meta http-equiv="x-pjax-version" content="272935131c2027f789efabd5bf30904ffaea35908a22afd03d8f75128cee7e1b" data-turbo-track="reload"> <meta http-equiv="x-pjax-csp-version" content="ace39c3b6632770952207593607e6e0be0db363435a8b877b1f96abe6430f345" data-turbo-track="reload"> <meta http-equiv="x-pjax-css-version" content="8968ee26e93ec8c6d3c4e91c77fb9d206091689d451ebbcddeca3832587a5b30" data-turbo-track="reload"> <meta http-equiv="x-pjax-js-version" content="c4972ae1cf5d4607c47252349fc1b47a24ff0ea303e5a8fbbe18ec27725a87ee" data-turbo-track="reload"> <meta name="turbo-cache-control" content="no-preview" data-turbo-transient=""> <meta name="voltron-timing" value="1153"> <meta name="go-import" content="github.com/XRPLF/rippled git https://github.com/XRPLF/rippled.git"> <meta name="octolytics-dimension-user_id" content="67929741" /><meta name="octolytics-dimension-user_login" content="XRPLF" /><meta name="octolytics-dimension-repository_id" content="2724167" /><meta name="octolytics-dimension-repository_nwo" content="XRPLF/rippled" /><meta name="octolytics-dimension-repository_public" content="true" /><meta name="octolytics-dimension-repository_is_fork" content="false" /><meta name="octolytics-dimension-repository_network_root_id" content="2724167" /><meta name="octolytics-dimension-repository_network_root_nwo" content="XRPLF/rippled" /> <meta name="turbo-body-classes" content="logged-out env-production page-responsive"> <meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats"> <meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors"> <link rel="mask-icon" href="https://github.githubassets.com/assets/pinned-octocat-093da3e6fa40.svg" color="#000000"> <link rel="alternate icon" class="js-site-favicon" type="image/png" href="https://github.githubassets.com/favicons/favicon.png"> <link rel="icon" class="js-site-favicon" type="image/svg+xml" href="https://github.githubassets.com/favicons/favicon.svg" data-base-href="https://github.githubassets.com/favicons/favicon"> <meta name="theme-color" content="#1e2327"> <meta name="color-scheme" content="light dark" /> <link rel="manifest" href="/manifest.json" crossOrigin="use-credentials"> </head> <body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div data-turbo-body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div class="position-relative header-wrapper js-header-wrapper "> <a href="#start-of-content" data-skip-target-assigned="false" class="px-2 py-4 color-bg-accent-emphasis color-fg-on-emphasis show-on-focus js-skip-to-content">Skip to content</a> <span data-view-component="true" class="progress-pjax-loader Progress position-fixed width-full"> <span style="width: 0%;" data-view-component="true" class="Progress-item progress-pjax-loader-bar left-0 top-0 color-bg-accent-emphasis"></span> </span> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_ui-commands_ui-commands_ts-d25fac54a6bc.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/keyboard-shortcuts-dialog-ed30662f9578.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.9fa170e9435ed4b922b9.module.css" /> <react-partial partial-name="keyboard-shortcuts-dialog" data-ssr="false" data-attempted-ssr="false" > <script type="application/json" data-target="react-partial.embeddedData">{"props":{"docsUrl":"https://docs.github.com/get-started/accessibility/keyboard-shortcuts"}}</script> <div data-target="react-partial.reactRoot"></div> </react-partial> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-94fd67-cf3dd69d89eb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/sessions-8fa3b694f335.js"></script> <header class="HeaderMktg header-logged-out js-details-container js-header Details f4 py-3" role="banner" data-is-top="true" data-color-mode=light data-light-theme=light data-dark-theme=dark> <h2 class="sr-only">Navigation Menu</h2> <button type="button" class="HeaderMktg-backdrop d-lg-none border-0 position-fixed top-0 left-0 width-full height-full js-details-target" aria-label="Toggle navigation"> <span class="d-none">Toggle navigation</span> </button> <div class="d-flex flex-column flex-lg-row flex-items-center px-3 px-md-4 px-lg-5 height-full position-relative z-1"> <div class="d-flex flex-justify-between flex-items-center width-full width-lg-auto"> <div class="flex-1"> <button aria-label="Toggle navigation" aria-expanded="false" type="button" data-view-component="true" class="js-details-target js-nav-padding-recalculate js-header-menu-toggle Button--link Button--medium Button d-lg-none color-fg-inherit p-1"> <span class="Button-content"> <span class="Button-label"><div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div></span> </span> </button> </div> <a class="mr-lg-3 color-fg-inherit flex-order-2 js-prevent-focus-on-mobile-nav" href="/" aria-label="Homepage" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Logomark;ref_loc:Header"}"> <svg height="32" aria-hidden="true" viewBox="0 0 24 24" version="1.1" width="32" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <div class="flex-1 flex-order-2 text-right"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2FXRPLF%2Frippled%2Fpull%2F4927" class="HeaderMenu-link HeaderMenu-button d-inline-flex d-lg-none flex-order-1 f5 no-underline border color-border-default rounded-2 px-2 py-1 color-fg-inherit js-prevent-focus-on-mobile-nav" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="7be60257a340ee77bd181e51240bbe88c513048f85ffb3ab64f16f4e63ac76da" data-analytics-event="{"category":"Marketing nav","action":"click to Sign in","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> </div> <div class="HeaderMenu js-header-menu height-fit position-lg-relative d-lg-flex flex-column flex-auto top-0"> <div class="HeaderMenu-wrapper d-flex flex-column flex-self-start flex-lg-row flex-auto rounded rounded-lg-0"> <nav class="HeaderMenu-nav" aria-label="Global"> <ul class="d-lg-flex list-style-none"> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Product <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"product","tag":"link","label":"github_copilot_link_product_navbar"}" href="https://github.com/features/copilot"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Write better code with AI </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"security","context":"product","tag":"link","label":"security_link_product_navbar"}" href="https://github.com/features/security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Security</div> Find and fix vulnerabilities </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"actions","context":"product","tag":"link","label":"actions_link_product_navbar"}" href="https://github.com/features/actions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-workflow color-fg-subtle mr-3"> <path d="M1 3a2 2 0 0 1 2-2h6.5a2 2 0 0 1 2 2v6.5a2 2 0 0 1-2 2H7v4.063C7 16.355 7.644 17 8.438 17H12.5v-2.5a2 2 0 0 1 2-2H21a2 2 0 0 1 2 2V21a2 2 0 0 1-2 2h-6.5a2 2 0 0 1-2-2v-2.5H8.437A2.939 2.939 0 0 1 5.5 15.562V11.5H3a2 2 0 0 1-2-2Zm2-.5a.5.5 0 0 0-.5.5v6.5a.5.5 0 0 0 .5.5h6.5a.5.5 0 0 0 .5-.5V3a.5.5 0 0 0-.5-.5ZM14.5 14a.5.5 0 0 0-.5.5V21a.5.5 0 0 0 .5.5H21a.5.5 0 0 0 .5-.5v-6.5a.5.5 0 0 0-.5-.5Z"></path> </svg> <div> <div class="color-fg-default h4">Actions</div> Automate any workflow </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"codespaces","context":"product","tag":"link","label":"codespaces_link_product_navbar"}" href="https://github.com/features/codespaces"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-codespaces color-fg-subtle mr-3"> <path d="M3.5 3.75C3.5 2.784 4.284 2 5.25 2h13.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 18.75 13H5.25a1.75 1.75 0 0 1-1.75-1.75Zm-2 12c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v4a1.75 1.75 0 0 1-1.75 1.75H3.25a1.75 1.75 0 0 1-1.75-1.75ZM5.25 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h13.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Zm-2 12a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h17.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25Z"></path><path d="M10 17.75a.75.75 0 0 1 .75-.75h6.5a.75.75 0 0 1 0 1.5h-6.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> <div> <div class="color-fg-default h4">Codespaces</div> Instant dev environments </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"issues","context":"product","tag":"link","label":"issues_link_product_navbar"}" href="https://github.com/features/issues"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-issue-opened color-fg-subtle mr-3"> <path d="M12 1c6.075 0 11 4.925 11 11s-4.925 11-11 11S1 18.075 1 12 5.925 1 12 1ZM2.5 12a9.5 9.5 0 0 0 9.5 9.5 9.5 9.5 0 0 0 9.5-9.5A9.5 9.5 0 0 0 12 2.5 9.5 9.5 0 0 0 2.5 12Zm9.5 2a2 2 0 1 1-.001-3.999A2 2 0 0 1 12 14Z"></path> </svg> <div> <div class="color-fg-default h4">Issues</div> Plan and track work </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"code_review","context":"product","tag":"link","label":"code_review_link_product_navbar"}" href="https://github.com/features/code-review"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-review color-fg-subtle mr-3"> <path d="M10.3 6.74a.75.75 0 0 1-.04 1.06l-2.908 2.7 2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M1.5 4.25c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v12.5a1.75 1.75 0 0 1-1.75 1.75h-9.69l-3.573 3.573A1.458 1.458 0 0 1 5 21.043V18.5H3.25a1.75 1.75 0 0 1-1.75-1.75ZM3.25 4a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h2.5a.75.75 0 0 1 .75.75v3.19l3.72-3.72a.749.749 0 0 1 .53-.22h10a.25.25 0 0 0 .25-.25V4.25a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Review</div> Manage code changes </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"discussions","context":"product","tag":"link","label":"discussions_link_product_navbar"}" href="https://github.com/features/discussions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Discussions</div> Collaborate outside of code </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"code_search","context":"product","tag":"link","label":"code_search_link_product_navbar"}" href="https://github.com/features/code-search"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-square color-fg-subtle mr-3"> <path d="M10.3 8.24a.75.75 0 0 1-.04 1.06L7.352 12l2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M2 3.75C2 2.784 2.784 2 3.75 2h16.5c.966 0 1.75.784 1.75 1.75v16.5A1.75 1.75 0 0 1 20.25 22H3.75A1.75 1.75 0 0 1 2 20.25Zm1.75-.25a.25.25 0 0 0-.25.25v16.5c0 .138.112.25.25.25h16.5a.25.25 0 0 0 .25-.25V3.75a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Search</div> Find more, search less </div> </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="product-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="product-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"all_features","context":"product","tag":"link","label":"all_features_link_product_navbar"}" href="https://github.com/features"> All features </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"documentation","context":"product","tag":"link","label":"documentation_link_product_navbar"}" href="https://docs.github.com"> Documentation <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"github_skills","context":"product","tag":"link","label":"github_skills_link_product_navbar"}" href="https://skills.github.com"> GitHub Skills <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"blog","context":"product","tag":"link","label":"blog_link_product_navbar"}" href="https://github.blog"> Blog <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Solutions <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 pb-lg-3 mb-3 mb-lg-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-company-size-heading">By company size</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-company-size-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"enterprises","context":"solutions","tag":"link","label":"enterprises_link_solutions_navbar"}" href="https://github.com/enterprise"> Enterprises </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"small_and_medium_teams","context":"solutions","tag":"link","label":"small_and_medium_teams_link_solutions_navbar"}" href="https://github.com/team"> Small and medium teams </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"startups","context":"solutions","tag":"link","label":"startups_link_solutions_navbar"}" href="https://github.com/enterprise/startups"> Startups </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-use-case-heading">By use case</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-use-case-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devsecops","context":"solutions","tag":"link","label":"devsecops_link_solutions_navbar"}" href="/solutions/use-case/devsecops"> DevSecOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"solutions","tag":"link","label":"devops_link_solutions_navbar"}" href="/solutions/use-case/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ci_cd","context":"solutions","tag":"link","label":"ci_cd_link_solutions_navbar"}" href="/solutions/use-case/ci-cd"> CI/CD </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_use_cases","context":"solutions","tag":"link","label":"view_all_use_cases_link_solutions_navbar"}" href="/solutions/use-case"> View all use cases </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-industry-heading">By industry</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-industry-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"healthcare","context":"solutions","tag":"link","label":"healthcare_link_solutions_navbar"}" href="/solutions/industry/healthcare"> Healthcare </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"financial_services","context":"solutions","tag":"link","label":"financial_services_link_solutions_navbar"}" href="/solutions/industry/financial-services"> Financial services </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"manufacturing","context":"solutions","tag":"link","label":"manufacturing_link_solutions_navbar"}" href="/solutions/industry/manufacturing"> Manufacturing </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"government","context":"solutions","tag":"link","label":"government_link_solutions_navbar"}" href="/solutions/industry/government"> Government </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_industries","context":"solutions","tag":"link","label":"view_all_industries_link_solutions_navbar"}" href="/solutions/industry"> View all industries </a></li> </ul> </div> </div> <div class="HeaderMenu-trailing-link rounded-bottom-2 flex-shrink-0 mt-lg-4 px-lg-4 py-4 py-lg-3 f5 text-semibold"> <a href="/solutions"> View all solutions <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-right HeaderMenu-trailing-link-icon"> <path d="M6.22 3.22a.75.75 0 0 1 1.06 0l4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L9.94 8 6.22 4.28a.75.75 0 0 1 0-1.06Z"></path> </svg> </a> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Resources <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-topics-heading">Topics</span> <ul class="list-style-none f5" aria-labelledby="resources-topics-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ai","context":"resources","tag":"link","label":"ai_link_resources_navbar"}" href="/resources/articles/ai"> AI </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"resources","tag":"link","label":"devops_link_resources_navbar"}" href="/resources/articles/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"security","context":"resources","tag":"link","label":"security_link_resources_navbar"}" href="/resources/articles/security"> Security </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"software_development","context":"resources","tag":"link","label":"software_development_link_resources_navbar"}" href="/resources/articles/software-development"> Software Development </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all","context":"resources","tag":"link","label":"view_all_link_resources_navbar"}" href="/resources/articles"> View all </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="resources-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"learning_pathways","context":"resources","tag":"link","label":"learning_pathways_link_resources_navbar"}" href="https://resources.github.com/learn/pathways"> Learning Pathways <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"white_papers_ebooks_webinars","context":"resources","tag":"link","label":"white_papers_ebooks_webinars_link_resources_navbar"}" href="https://resources.github.com"> White papers, Ebooks, Webinars <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"customer_stories","context":"resources","tag":"link","label":"customer_stories_link_resources_navbar"}" href="https://github.com/customer-stories"> Customer Stories </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"partners","context":"resources","tag":"link","label":"partners_link_resources_navbar"}" href="https://partner.github.com"> Partners <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Open Source <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"github_sponsors","context":"open_source","tag":"link","label":"github_sponsors_link_open_source_navbar"}" href="/sponsors"> <div> <div class="color-fg-default h4">GitHub Sponsors</div> Fund open source developers </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"the_readme_project","context":"open_source","tag":"link","label":"the_readme_project_link_open_source_navbar"}" href="https://github.com/readme"> <div> <div class="color-fg-default h4">The ReadME Project</div> GitHub community articles </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="open-source-repositories-heading">Repositories</span> <ul class="list-style-none f5" aria-labelledby="open-source-repositories-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"topics","context":"open_source","tag":"link","label":"topics_link_open_source_navbar"}" href="https://github.com/topics"> Topics </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"trending","context":"open_source","tag":"link","label":"trending_link_open_source_navbar"}" href="https://github.com/trending"> Trending </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"collections","context":"open_source","tag":"link","label":"collections_link_open_source_navbar"}" href="https://github.com/collections"> Collections </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Enterprise <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"enterprise_platform","context":"enterprise","tag":"link","label":"enterprise_platform_link_enterprise_navbar"}" href="/enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-stack color-fg-subtle mr-3"> <path d="M11.063 1.456a1.749 1.749 0 0 1 1.874 0l8.383 5.316a1.751 1.751 0 0 1 0 2.956l-8.383 5.316a1.749 1.749 0 0 1-1.874 0L2.68 9.728a1.751 1.751 0 0 1 0-2.956Zm1.071 1.267a.25.25 0 0 0-.268 0L3.483 8.039a.25.25 0 0 0 0 .422l8.383 5.316a.25.25 0 0 0 .268 0l8.383-5.316a.25.25 0 0 0 0-.422Z"></path><path d="M1.867 12.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path><path d="M1.867 16.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path> </svg> <div> <div class="color-fg-default h4">Enterprise platform</div> AI-powered developer platform </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="enterprise-available-add-ons-heading">Available add-ons</span> <ul class="list-style-none f5" aria-labelledby="enterprise-available-add-ons-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"advanced_security","context":"enterprise","tag":"link","label":"advanced_security_link_enterprise_navbar"}" href="https://github.com/enterprise/advanced-security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Advanced Security</div> Enterprise-grade security features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"enterprise","tag":"link","label":"github_copilot_link_enterprise_navbar"}" href="/features/copilot#enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Enterprise-grade AI features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"premium_support","context":"enterprise","tag":"link","label":"premium_support_link_enterprise_navbar"}" href="/premium-support"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Premium Support</div> Enterprise-grade 24/7 support </div> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <a class="HeaderMenu-link no-underline px-0 px-lg-2 py-3 py-lg-2 d-block d-lg-inline-block" data-analytics-event="{"location":"navbar","action":"pricing","context":"global","tag":"link","label":"pricing_link_global_navbar"}" href="https://github.com/pricing">Pricing</a> </li> </ul> </nav> <div class="d-flex flex-column flex-lg-row width-full flex-justify-end flex-lg-items-center text-center mt-3 mt-lg-0 text-lg-left ml-lg-3"> <qbsearch-input class="search-input" data-scope="repo:XRPLF/rippled" data-custom-scopes-path="/search/custom_scopes" data-delete-custom-scopes-csrf="m-aGozxhmuR45RktPCmmn8EAD7GwqCh_Fg6mpR6yvFSOQJCutUL4Grn7W1hVhnpDjPMfZwGPPtr3emTCJpe4hA" data-max-custom-scopes="10" data-header-redesign-enabled="false" data-initial-value="" data-blackbird-suggestions-path="/search/suggestions" data-jump-to-suggestions-path="/_graphql/GetSuggestedNavigationDestinations" data-current-repository="XRPLF/rippled" data-current-org="XRPLF" data-current-owner="" data-logged-in="false" data-copilot-chat-enabled="false" data-nl-search-enabled="false" data-retain-scroll-position="true"> <div class="search-input-container search-with-dialog position-relative d-flex flex-row flex-items-center mr-4 rounded" data-action="click:qbsearch-input#searchInputContainerClicked" > <button type="button" class="header-search-button placeholder input-button form-control d-flex flex-1 flex-self-stretch flex-items-center no-wrap width-full py-0 pl-2 pr-0 text-left border-0 box-shadow-none" data-target="qbsearch-input.inputButton" aria-label="Search or jump to…" aria-haspopup="dialog" placeholder="Search or jump to..." data-hotkey=s,/ autocapitalize="off" data-analytics-event="{"location":"navbar","action":"searchbar","context":"global","tag":"input","label":"searchbar_input_global_navbar"}" data-action="click:qbsearch-input#handleExpand" > <div class="mr-2 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </div> <span class="flex-1" data-target="qbsearch-input.inputButtonText">Search or jump to...</span> <div class="d-flex" data-target="qbsearch-input.hotkeyIndicator"> <svg xmlns="http://www.w3.org/2000/svg" width="22" height="20" aria-hidden="true" class="mr-1"><path fill="none" stroke="#979A9C" opacity=".4" d="M3.5.5h12c1.7 0 3 1.3 3 3v13c0 1.7-1.3 3-3 3h-12c-1.7 0-3-1.3-3-3v-13c0-1.7 1.3-3 3-3z"></path><path fill="#979A9C" d="M11.8 6L8 15.1h-.9L10.8 6h1z"></path></svg> </div> </button> <input type="hidden" name="type" class="js-site-search-type-field"> <div class="Overlay--hidden " data-modal-dialog-overlay> <modal-dialog data-action="close:qbsearch-input#handleClose cancel:qbsearch-input#handleClose" data-target="qbsearch-input.searchSuggestionsDialog" role="dialog" id="search-suggestions-dialog" aria-modal="true" aria-labelledby="search-suggestions-dialog-header" data-view-component="true" class="Overlay Overlay--width-large Overlay--height-auto"> <h1 id="search-suggestions-dialog-header" class="sr-only">Search code, repositories, users, issues, pull requests...</h1> <div class="Overlay-body Overlay-body--paddingNone"> <div data-view-component="true"> <div class="search-suggestions position-fixed width-full color-shadow-large border color-fg-default color-bg-default overflow-hidden d-flex flex-column query-builder-container" style="border-radius: 12px;" data-target="qbsearch-input.queryBuilderContainer" hidden > <!-- '"` --><!-- </textarea></xmp> --></option></form><form id="query-builder-test-form" action="" accept-charset="UTF-8" method="get"> <query-builder data-target="qbsearch-input.queryBuilder" id="query-builder-query-builder-test" data-filter-key=":" data-view-component="true" class="QueryBuilder search-query-builder"> <div class="FormControl FormControl--fullWidth"> <label id="query-builder-test-label" for="query-builder-test" class="FormControl-label sr-only"> Search </label> <div class="QueryBuilder-StyledInput width-fit " data-target="query-builder.styledInput" > <span id="query-builder-test-leadingvisual-wrap" class="FormControl-input-leadingVisualWrap QueryBuilder-leadingVisualWrap"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search FormControl-input-leadingVisual"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </span> <div data-target="query-builder.styledInputContainer" class="QueryBuilder-StyledInputContainer"> <div aria-hidden="true" class="QueryBuilder-StyledInputContent" data-target="query-builder.styledInputContent" ></div> <div class="QueryBuilder-InputWrapper"> <div aria-hidden="true" class="QueryBuilder-Sizer" data-target="query-builder.sizer"></div> <input id="query-builder-test" name="query-builder-test" value="" autocomplete="off" type="text" role="combobox" spellcheck="false" aria-expanded="false" aria-describedby="validation-191a30e9-3f74-495d-9942-575fa7c597d3" data-target="query-builder.input" data-action=" input:query-builder#inputChange blur:query-builder#inputBlur keydown:query-builder#inputKeydown focus:query-builder#inputFocus " data-view-component="true" class="FormControl-input QueryBuilder-Input FormControl-medium" /> </div> </div> <span class="sr-only" id="query-builder-test-clear">Clear</span> <button role="button" id="query-builder-test-clear-button" aria-labelledby="query-builder-test-clear query-builder-test-label" data-target="query-builder.clearButton" data-action=" click:query-builder#clear focus:query-builder#clearButtonFocus blur:query-builder#clearButtonBlur " variant="small" hidden="hidden" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium mr-1 px-2 py-0 d-flex flex-items-center rounded-1 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x-circle-fill Button-visual"> <path d="M2.343 13.657A8 8 0 1 1 13.658 2.343 8 8 0 0 1 2.343 13.657ZM6.03 4.97a.751.751 0 0 0-1.042.018.751.751 0 0 0-.018 1.042L6.94 8 4.97 9.97a.749.749 0 0 0 .326 1.275.749.749 0 0 0 .734-.215L8 9.06l1.97 1.97a.749.749 0 0 0 1.275-.326.749.749 0 0 0-.215-.734L9.06 8l1.97-1.97a.749.749 0 0 0-.326-1.275.749.749 0 0 0-.734.215L8 6.94Z"></path> </svg> </button> </div> <template id="search-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </template> <template id="code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="file-code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-file-code"> <path d="M4 1.75C4 .784 4.784 0 5.75 0h5.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v8.586A1.75 1.75 0 0 1 14.25 15h-9a.75.75 0 0 1 0-1.5h9a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 10 4.25V1.5H5.75a.25.25 0 0 0-.25.25v2.5a.75.75 0 0 1-1.5 0Zm1.72 4.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l1.47-1.47-1.47-1.47a.75.75 0 0 1 0-1.06ZM3.28 7.78 1.81 9.25l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Zm8.22-6.218V4.25c0 .138.112.25.25.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"></path> </svg> </template> <template id="history-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-history"> <path d="m.427 1.927 1.215 1.215a8.002 8.002 0 1 1-1.6 5.685.75.75 0 1 1 1.493-.154 6.5 6.5 0 1 0 1.18-4.458l1.358 1.358A.25.25 0 0 1 3.896 6H.25A.25.25 0 0 1 0 5.75V2.104a.25.25 0 0 1 .427-.177ZM7.75 4a.75.75 0 0 1 .75.75v2.992l2.028.812a.75.75 0 0 1-.557 1.392l-2.5-1A.751.751 0 0 1 7 8.25v-3.5A.75.75 0 0 1 7.75 4Z"></path> </svg> </template> <template id="repo-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> </template> <template id="bookmark-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bookmark"> <path d="M3 2.75C3 1.784 3.784 1 4.75 1h6.5c.966 0 1.75.784 1.75 1.75v11.5a.75.75 0 0 1-1.227.579L8 11.722l-3.773 3.107A.751.751 0 0 1 3 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v9.91l3.023-2.489a.75.75 0 0 1 .954 0l3.023 2.49V2.75a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="plus-circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-plus-circle"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm7.25-3.25v2.5h2.5a.75.75 0 0 1 0 1.5h-2.5v2.5a.75.75 0 0 1-1.5 0v-2.5h-2.5a.75.75 0 0 1 0-1.5h2.5v-2.5a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-dot-fill"> <path d="M8 4a4 4 0 1 1 0 8 4 4 0 0 1 0-8Z"></path> </svg> </template> <template id="trash-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-trash"> <path d="M11 1.75V3h2.25a.75.75 0 0 1 0 1.5H2.75a.75.75 0 0 1 0-1.5H5V1.75C5 .784 5.784 0 6.75 0h2.5C10.216 0 11 .784 11 1.75ZM4.496 6.675l.66 6.6a.25.25 0 0 0 .249.225h5.19a.25.25 0 0 0 .249-.225l.66-6.6a.75.75 0 0 1 1.492.149l-.66 6.6A1.748 1.748 0 0 1 10.595 15h-5.19a1.75 1.75 0 0 1-1.741-1.575l-.66-6.6a.75.75 0 1 1 1.492-.15ZM6.5 1.75V3h3V1.75a.25.25 0 0 0-.25-.25h-2.5a.25.25 0 0 0-.25.25Z"></path> </svg> </template> <template id="team-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-people"> <path d="M2 5.5a3.5 3.5 0 1 1 5.898 2.549 5.508 5.508 0 0 1 3.034 4.084.75.75 0 1 1-1.482.235 4 4 0 0 0-7.9 0 .75.75 0 0 1-1.482-.236A5.507 5.507 0 0 1 3.102 8.05 3.493 3.493 0 0 1 2 5.5ZM11 4a3.001 3.001 0 0 1 2.22 5.018 5.01 5.01 0 0 1 2.56 3.012.749.749 0 0 1-.885.954.752.752 0 0 1-.549-.514 3.507 3.507 0 0 0-2.522-2.372.75.75 0 0 1-.574-.73v-.352a.75.75 0 0 1 .416-.672A1.5 1.5 0 0 0 11 5.5.75.75 0 0 1 11 4Zm-5.5-.5a2 2 0 1 0-.001 3.999A2 2 0 0 0 5.5 3.5Z"></path> </svg> </template> <template id="project-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-project"> <path d="M1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0ZM1.5 1.75v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25ZM11.75 3a.75.75 0 0 1 .75.75v7.5a.75.75 0 0 1-1.5 0v-7.5a.75.75 0 0 1 .75-.75Zm-8.25.75a.75.75 0 0 1 1.5 0v5.5a.75.75 0 0 1-1.5 0ZM8 3a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0v-3.5A.75.75 0 0 1 8 3Z"></path> </svg> </template> <template id="pencil-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-pencil"> <path d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"></path> </svg> </template> <template id="copilot-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot"> <path d="M7.998 15.035c-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.201-.508-.254-1.084-.254-1.656 0-.87.128-1.769.693-2.484.579-.733 1.494-1.124 2.724-1.261 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095v1.872c0 .766-3.351 3.795-8.002 3.795Zm0-1.485c2.28 0 4.584-1.11 5.002-1.433V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-1.146 0-2.059-.327-2.71-.991A3.222 3.222 0 0 1 8 6.303a3.24 3.24 0 0 1-.544.743c-.65.664-1.563.991-2.71.991-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433ZM6.762 2.83c-.193-.206-.637-.413-1.682-.297-1.019.113-1.479.404-1.713.7-.247.312-.369.789-.369 1.554 0 .793.129 1.171.308 1.371.162.181.519.379 1.442.379.853 0 1.339-.235 1.638-.54.315-.322.527-.827.617-1.553.117-.935-.037-1.395-.241-1.614Zm4.155-.297c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Z"></path><path d="M6.25 9.037a.75.75 0 0 1 .75.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 .75-.75Zm4.25.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="copilot-error-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot-error"> <path d="M16 11.24c0 .112-.072.274-.21.467L13 9.688V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-.198 0-.388-.009-.571-.029L6.833 5.226a4.01 4.01 0 0 0 .17-.782c.117-.935-.037-1.395-.241-1.614-.193-.206-.637-.413-1.682-.297-.683.076-1.115.231-1.395.415l-1.257-.91c.579-.564 1.413-.877 2.485-.996 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095Zm-5.083-8.707c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Zm2.511 11.074c-1.393.776-3.272 1.428-5.43 1.428-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.18-.455-.241-.963-.252-1.475L.31 4.107A.747.747 0 0 1 0 3.509V3.49a.748.748 0 0 1 .625-.73c.156-.026.306.047.435.139l14.667 10.578a.592.592 0 0 1 .227.264.752.752 0 0 1 .046.249v.022a.75.75 0 0 1-1.19.596Zm-1.367-.991L5.635 7.964a5.128 5.128 0 0 1-.889.073c-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433 1.539 0 3.089-.505 4.063-.934Z"></path> </svg> </template> <template id="workflow-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-workflow"> <path d="M0 1.75C0 .784.784 0 1.75 0h3.5C6.216 0 7 .784 7 1.75v3.5A1.75 1.75 0 0 1 5.25 7H4v4a1 1 0 0 0 1 1h4v-1.25C9 9.784 9.784 9 10.75 9h3.5c.966 0 1.75.784 1.75 1.75v3.5A1.75 1.75 0 0 1 14.25 16h-3.5A1.75 1.75 0 0 1 9 14.25v-.75H5A2.5 2.5 0 0 1 2.5 11V7h-.75A1.75 1.75 0 0 1 0 5.25Zm1.75-.25a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Zm9 9a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="book-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> </template> <template id="code-review-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-review"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 13H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 14.543V13H1.75A1.75 1.75 0 0 1 0 11.25v-8.5C0 1.784.784 1 1.75 1ZM1.5 2.75v8.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-8.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm5.28 1.72a.75.75 0 0 1 0 1.06L5.31 7l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.75.75 0 0 1 1.06 0Zm2.44 0a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L10.69 7 9.22 5.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="codespaces-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-codespaces"> <path d="M0 11.25c0-.966.784-1.75 1.75-1.75h12.5c.966 0 1.75.784 1.75 1.75v3A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm2-9.5C2 .784 2.784 0 3.75 0h8.5C13.216 0 14 .784 14 1.75v5a1.75 1.75 0 0 1-1.75 1.75h-8.5A1.75 1.75 0 0 1 2 6.75Zm1.75-.25a.25.25 0 0 0-.25.25v5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-5a.25.25 0 0 0-.25-.25Zm-2 9.5a.25.25 0 0 0-.25.25v3c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-3a.25.25 0 0 0-.25-.25Z"></path><path d="M7 12.75a.75.75 0 0 1 .75-.75h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> </template> <template id="comment-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment"> <path d="M1 2.75C1 1.784 1.784 1 2.75 1h10.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 13.25 12H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 13.543V12H2.75A1.75 1.75 0 0 1 1 10.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="comment-discussion-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </template> <template id="organization-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-organization"> <path d="M1.75 16A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0h8.5C11.216 0 12 .784 12 1.75v12.5c0 .085-.006.168-.018.25h2.268a.25.25 0 0 0 .25-.25V8.285a.25.25 0 0 0-.111-.208l-1.055-.703a.749.749 0 1 1 .832-1.248l1.055.703c.487.325.779.871.779 1.456v5.965A1.75 1.75 0 0 1 14.25 16h-3.5a.766.766 0 0 1-.197-.026c-.099.017-.2.026-.303.026h-3a.75.75 0 0 1-.75-.75V14h-1v1.25a.75.75 0 0 1-.75.75Zm-.25-1.75c0 .138.112.25.25.25H4v-1.25a.75.75 0 0 1 .75-.75h2.5a.75.75 0 0 1 .75.75v1.25h2.25a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM3.75 6h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 3.75A.75.75 0 0 1 3.75 3h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 3.75Zm4 3A.75.75 0 0 1 7.75 6h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 7 6.75ZM7.75 3h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 9.75A.75.75 0 0 1 3.75 9h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 9.75ZM7.75 9h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="rocket-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-rocket"> <path d="M14.064 0h.186C15.216 0 16 .784 16 1.75v.186a8.752 8.752 0 0 1-2.564 6.186l-.458.459c-.314.314-.641.616-.979.904v3.207c0 .608-.315 1.172-.833 1.49l-2.774 1.707a.749.749 0 0 1-1.11-.418l-.954-3.102a1.214 1.214 0 0 1-.145-.125L3.754 9.816a1.218 1.218 0 0 1-.124-.145L.528 8.717a.749.749 0 0 1-.418-1.11l1.71-2.774A1.748 1.748 0 0 1 3.31 4h3.204c.288-.338.59-.665.904-.979l.459-.458A8.749 8.749 0 0 1 14.064 0ZM8.938 3.623h-.002l-.458.458c-.76.76-1.437 1.598-2.02 2.5l-1.5 2.317 2.143 2.143 2.317-1.5c.902-.583 1.74-1.26 2.499-2.02l.459-.458a7.25 7.25 0 0 0 2.123-5.127V1.75a.25.25 0 0 0-.25-.25h-.186a7.249 7.249 0 0 0-5.125 2.123ZM3.56 14.56c-.732.732-2.334 1.045-3.005 1.148a.234.234 0 0 1-.201-.064.234.234 0 0 1-.064-.201c.103-.671.416-2.273 1.15-3.003a1.502 1.502 0 1 1 2.12 2.12Zm6.94-3.935c-.088.06-.177.118-.266.175l-2.35 1.521.548 1.783 1.949-1.2a.25.25 0 0 0 .119-.213ZM3.678 8.116 5.2 5.766c.058-.09.117-.178.176-.266H3.309a.25.25 0 0 0-.213.119l-1.2 1.95ZM12 5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </template> <template id="shield-check-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield-check"> <path d="m8.533.133 5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667l5.25-1.68a1.748 1.748 0 0 1 1.066 0Zm-.61 1.429.001.001-5.25 1.68a.251.251 0 0 0-.174.237V7c0 1.36.275 2.666 1.057 3.859.784 1.194 2.121 2.342 4.366 3.298a.196.196 0 0 0 .154 0c2.245-.957 3.582-2.103 4.366-3.297C13.225 9.666 13.5 8.358 13.5 7V3.48a.25.25 0 0 0-.174-.238l-5.25-1.68a.25.25 0 0 0-.153 0ZM11.28 6.28l-3.5 3.5a.75.75 0 0 1-1.06 0l-1.5-1.5a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l.97.97 2.97-2.97a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="heart-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-heart"> <path d="m8 14.25.345.666a.75.75 0 0 1-.69 0l-.008-.004-.018-.01a7.152 7.152 0 0 1-.31-.17 22.055 22.055 0 0 1-3.434-2.414C2.045 10.731 0 8.35 0 5.5 0 2.836 2.086 1 4.25 1 5.797 1 7.153 1.802 8 3.02 8.847 1.802 10.203 1 11.75 1 13.914 1 16 2.836 16 5.5c0 2.85-2.045 5.231-3.885 6.818a22.066 22.066 0 0 1-3.744 2.584l-.018.01-.006.003h-.002ZM4.25 2.5c-1.336 0-2.75 1.164-2.75 3 0 2.15 1.58 4.144 3.365 5.682A20.58 20.58 0 0 0 8 13.393a20.58 20.58 0 0 0 3.135-2.211C12.92 9.644 14.5 7.65 14.5 5.5c0-1.836-1.414-3-2.75-3-1.373 0-2.609.986-3.029 2.456a.749.749 0 0 1-1.442 0C6.859 3.486 5.623 2.5 4.25 2.5Z"></path> </svg> </template> <template id="server-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-server"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v4c0 .372-.116.717-.314 1 .198.283.314.628.314 1v4a1.75 1.75 0 0 1-1.75 1.75H1.75A1.75 1.75 0 0 1 0 12.75v-4c0-.358.109-.707.314-1a1.739 1.739 0 0 1-.314-1v-4C0 1.784.784 1 1.75 1ZM1.5 2.75v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm.25 5.75a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25ZM7 4.75A.75.75 0 0 1 7.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5A.75.75 0 0 1 7 4.75ZM7.75 10h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM3 4.75A.75.75 0 0 1 3.75 4h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 4.75ZM3.75 10h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="globe-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-globe"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM5.78 8.75a9.64 9.64 0 0 0 1.363 4.177c.255.426.542.832.857 1.215.245-.296.551-.705.857-1.215A9.64 9.64 0 0 0 10.22 8.75Zm4.44-1.5a9.64 9.64 0 0 0-1.363-4.177c-.307-.51-.612-.919-.857-1.215a9.927 9.927 0 0 0-.857 1.215A9.64 9.64 0 0 0 5.78 7.25Zm-5.944 1.5H1.543a6.507 6.507 0 0 0 4.666 5.5c-.123-.181-.24-.365-.352-.552-.715-1.192-1.437-2.874-1.581-4.948Zm-2.733-1.5h2.733c.144-2.074.866-3.756 1.58-4.948.12-.197.237-.381.353-.552a6.507 6.507 0 0 0-4.666 5.5Zm10.181 1.5c-.144 2.074-.866 3.756-1.58 4.948-.12.197-.237.381-.353.552a6.507 6.507 0 0 0 4.666-5.5Zm2.733-1.5a6.507 6.507 0 0 0-4.666-5.5c.123.181.24.365.353.552.714 1.192 1.436 2.874 1.58 4.948Z"></path> </svg> </template> <template id="issue-opened-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </template> <template id="device-mobile-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-mobile"> <path d="M3.75 0h8.5C13.216 0 14 .784 14 1.75v12.5A1.75 1.75 0 0 1 12.25 16h-8.5A1.75 1.75 0 0 1 2 14.25V1.75C2 .784 2.784 0 3.75 0ZM3.5 1.75v12.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM8 13a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path> </svg> </template> <template id="package-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-package"> <path d="m8.878.392 5.25 3.045c.54.314.872.89.872 1.514v6.098a1.75 1.75 0 0 1-.872 1.514l-5.25 3.045a1.75 1.75 0 0 1-1.756 0l-5.25-3.045A1.75 1.75 0 0 1 1 11.049V4.951c0-.624.332-1.201.872-1.514L7.122.392a1.75 1.75 0 0 1 1.756 0ZM7.875 1.69l-4.63 2.685L8 7.133l4.755-2.758-4.63-2.685a.248.248 0 0 0-.25 0ZM2.5 5.677v5.372c0 .09.047.171.125.216l4.625 2.683V8.432Zm6.25 8.271 4.625-2.683a.25.25 0 0 0 .125-.216V5.677L8.75 8.432Z"></path> </svg> </template> <template id="credit-card-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-credit-card"> <path d="M10.75 9a.75.75 0 0 0 0 1.5h1.5a.75.75 0 0 0 0-1.5h-1.5Z"></path><path d="M0 3.75C0 2.784.784 2 1.75 2h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 14H1.75A1.75 1.75 0 0 1 0 12.25ZM14.5 6.5h-13v5.75c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25Zm0-2.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25V5h13Z"></path> </svg> </template> <template id="play-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </template> <template id="gift-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-gift"> <path d="M2 2.75A2.75 2.75 0 0 1 4.75 0c.983 0 1.873.42 2.57 1.232.268.318.497.668.68 1.042.183-.375.411-.725.68-1.044C9.376.42 10.266 0 11.25 0a2.75 2.75 0 0 1 2.45 4h.55c.966 0 1.75.784 1.75 1.75v2c0 .698-.409 1.301-1 1.582v4.918A1.75 1.75 0 0 1 13.25 16H2.75A1.75 1.75 0 0 1 1 14.25V9.332C.409 9.05 0 8.448 0 7.75v-2C0 4.784.784 4 1.75 4h.55c-.192-.375-.3-.8-.3-1.25ZM7.25 9.5H2.5v4.75c0 .138.112.25.25.25h4.5Zm1.5 0v5h4.5a.25.25 0 0 0 .25-.25V9.5Zm0-4V8h5.5a.25.25 0 0 0 .25-.25v-2a.25.25 0 0 0-.25-.25Zm-7 0a.25.25 0 0 0-.25.25v2c0 .138.112.25.25.25h5.5V5.5h-5.5Zm3-4a1.25 1.25 0 0 0 0 2.5h2.309c-.233-.818-.542-1.401-.878-1.793-.43-.502-.915-.707-1.431-.707ZM8.941 4h2.309a1.25 1.25 0 0 0 0-2.5c-.516 0-1 .205-1.43.707-.337.392-.646.975-.879 1.793Z"></path> </svg> </template> <template id="code-square-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-square"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25Zm7.47 3.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L10.69 8 9.22 6.53a.75.75 0 0 1 0-1.06ZM6.78 6.53 5.31 8l1.47 1.47a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="device-desktop-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-desktop"> <path d="M14.25 1c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 14.25 12h-3.727c.099 1.041.52 1.872 1.292 2.757A.752.752 0 0 1 11.25 16h-6.5a.75.75 0 0 1-.565-1.243c.772-.885 1.192-1.716 1.292-2.757H1.75A1.75 1.75 0 0 1 0 10.25v-7.5C0 1.784.784 1 1.75 1ZM1.75 2.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25ZM9.018 12H6.982a5.72 5.72 0 0 1-.765 2.5h3.566a5.72 5.72 0 0 1-.765-2.5Z"></path> </svg> </template> <div class="position-relative"> <ul role="listbox" class="ActionListWrap QueryBuilder-ListWrap" aria-label="Suggestions" data-action=" combobox-commit:query-builder#comboboxCommit mousedown:query-builder#resultsMousedown " data-target="query-builder.resultsList" data-persist-list=false id="query-builder-test-results" ></ul> </div> <div class="FormControl-inlineValidation" id="validation-191a30e9-3f74-495d-9942-575fa7c597d3" hidden="hidden"> <span class="FormControl-inlineValidation--visual"> <svg aria-hidden="true" height="12" viewBox="0 0 12 12" version="1.1" width="12" data-view-component="true" class="octicon octicon-alert-fill"> <path d="M4.855.708c.5-.896 1.79-.896 2.29 0l4.675 8.351a1.312 1.312 0 0 1-1.146 1.954H1.33A1.313 1.313 0 0 1 .183 9.058ZM7 7V3H5v4Zm-1 3a1 1 0 1 0 0-2 1 1 0 0 0 0 2Z"></path> </svg> </span> <span></span> </div> </div> <div data-target="query-builder.screenReaderFeedback" aria-live="polite" aria-atomic="true" class="sr-only"></div> </query-builder></form> <div class="d-flex flex-row color-fg-muted px-3 text-small color-bg-default search-feedback-prompt"> <a target="_blank" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax" data-view-component="true" class="Link color-fg-accent text-normal ml-2"> Search syntax tips </a> <div class="d-flex flex-1"></div> </div> </div> </div> </div> </modal-dialog></div> </div> <div data-action="click:qbsearch-input#retract" class="dark-backdrop position-fixed" hidden data-target="qbsearch-input.darkBackdrop"></div> <div class="color-fg-default"> <dialog-helper> <dialog data-target="qbsearch-input.feedbackDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="feedback-dialog" aria-modal="true" aria-labelledby="feedback-dialog-title" aria-describedby="feedback-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="feedback-dialog-title"> Provide feedback </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="feedback-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="feedback-dialog-title"> <div data-view-component="true" class="Overlay-body"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form id="code-search-feedback-form" data-turbo="false" action="/search/feedback" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="Li24rjaQgls/V3EF45GmTiklsEKQciLhUKqal43m0HQSBMrWt8zO8RKXTC2ERCEB2Tl0qJwDaKSaaa6NZcn0Tg==" /> <p>We read every piece of feedback, and take your input very seriously.</p> <textarea name="feedback" class="form-control width-full mb-2" style="height: 120px" id="feedback"></textarea> <input name="include_email" id="include_email" aria-label="Include my email address so I can be contacted" class="form-control mr-2" type="checkbox"> <label for="include_email" style="font-weight: normal">Include my email address so I can be contacted</label> </form></div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd"> <button data-close-dialog-id="feedback-dialog" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="code-search-feedback-form" data-action="click:qbsearch-input#submitFeedback" type="submit" data-view-component="true" class="btn-primary btn"> Submit feedback </button> </div> </dialog></dialog-helper> <custom-scopes data-target="qbsearch-input.customScopesManager"> <dialog-helper> <dialog data-target="custom-scopes.customScopesModalDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="custom-scopes-dialog" aria-modal="true" aria-labelledby="custom-scopes-dialog-title" aria-describedby="custom-scopes-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header Overlay-header--divided"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="custom-scopes-dialog-title"> Saved searches </h1> <h2 id="custom-scopes-dialog-description" class="Overlay-description">Use saved searches to filter your results more quickly</h2> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="custom-scopes-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="custom-scopes-dialog-title"> <div data-view-component="true" class="Overlay-body"> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <div hidden class="create-custom-scope-form" data-target="custom-scopes.createCustomScopeForm"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form id="custom-scopes-dialog-form" data-turbo="false" action="/search/custom_scopes" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="nUIaLy8/MK3CLiDjNTORSuOFiqANz+pwxlM56mFXV9msmejs1SMxY/htmL9FlYSrxBua+TB5xM6NUaaizl10tQ==" /> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <input type="hidden" id="custom_scope_id" name="custom_scope_id" data-target="custom-scopes.customScopesIdField"> <div class="form-group"> <label for="custom_scope_name">Name</label> <auto-check src="/search/custom_scopes/check_name" required> <input type="text" name="custom_scope_name" id="custom_scope_name" data-target="custom-scopes.customScopesNameField" class="form-control" autocomplete="off" placeholder="github-ruby" required maxlength="50"> <input type="hidden" data-csrf="true" value="nuLZaN930LI1/blzF/XurpnBCsP5I8TrztkE54kNmGhIqgQNwTRAEj/K1KnrUPvwKDZu/D3MjA93JvNjytPYMA==" /> </auto-check> </div> <div class="form-group"> <label for="custom_scope_query">Query</label> <input type="text" name="custom_scope_query" id="custom_scope_query" data-target="custom-scopes.customScopesQueryField" class="form-control" autocomplete="off" placeholder="(repo:mona/a OR repo:mona/b) AND lang:python" required maxlength="500"> </div> <p class="text-small color-fg-muted"> To see all available qualifiers, see our <a class="Link--inTextBlock" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax">documentation</a>. </p> </form> </div> <div data-target="custom-scopes.manageCustomScopesForm"> <div data-target="custom-scopes.list"></div> </div> </div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd Overlay-footer--divided"> <button data-action="click:custom-scopes#customScopesCancel" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="custom-scopes-dialog-form" data-action="click:custom-scopes#customScopesSubmit" data-target="custom-scopes.customScopesSubmitButton" type="submit" data-view-component="true" class="btn-primary btn"> Create saved search </button> </div> </dialog></dialog-helper> </custom-scopes> </div> </qbsearch-input> <div class="position-relative HeaderMenu-link-wrap d-lg-inline-block"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2FXRPLF%2Frippled%2Fpull%2F4927" class="HeaderMenu-link HeaderMenu-link--sign-in HeaderMenu-button flex-shrink-0 no-underline d-none d-lg-inline-flex border border-lg-0 rounded rounded-lg-0 px-2 py-1" style="margin-left: 12px;" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="7be60257a340ee77bd181e51240bbe88c513048f85ffb3ab64f16f4e63ac76da" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> <a href="/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=XRPLF%2Frippled" class="HeaderMenu-link HeaderMenu-link--sign-up HeaderMenu-button flex-shrink-0 d-flex d-lg-inline-flex no-underline border color-border-default rounded px-2 py-1" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="7be60257a340ee77bd181e51240bbe88c513048f85ffb3ab64f16f4e63ac76da" data-analytics-event="{"category":"Sign up","action":"click to sign up for account","label":"ref_page:/<user-name>/<repo-name>/voltron/pull_requests_fragments/pull_request_layout;ref_cta:Sign up;ref_loc:header logged out"}" > Sign up </a> <button type="button" class="sr-only js-header-menu-focus-trap d-block d-lg-none">Reseting focus</button> </div> </div> </div> </div> </header> <div hidden="hidden" data-view-component="true" class="js-stale-session-flash stale-session-flash flash flash-warn flash-full"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span class="js-stale-session-flash-signed-in" hidden>You signed in with another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-signed-out" hidden>You signed out in another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-switched" hidden>You switched accounts on another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <button id="icon-button-4c916737-33a2-48c7-8c75-30585e2c207c" aria-labelledby="tooltip-42d73a3b-985f-4176-a210-6fa9d392acc1" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium flash-close js-flash-close"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x Button-visual"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button><tool-tip id="tooltip-42d73a3b-985f-4176-a210-6fa9d392acc1" for="icon-button-4c916737-33a2-48c7-8c75-30585e2c207c" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Dismiss alert</tool-tip> </div> </div> <div id="start-of-content" class="show-on-focus"></div> <div id="js-flash-container" class="flash-container" data-turbo-replace> <template class="js-flash-template"> <div class="flash flash-full {{ className }}"> <div > <button autofocus class="flash-close js-flash-close" type="button" aria-label="Dismiss this message"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div aria-atomic="true" role="alert" class="js-flash-alert"> <div>{{ message }}</div> </div> </div> </div> </template> </div> <div class="application-main " data-commit-hovercards-enabled data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled > <div itemscope itemtype="http://schema.org/SoftwareSourceCode" class=""> <main id="js-repo-pjax-container" > <div id="repository-container-header" class="pt-3 hide-full-screen" style="background-color: var(--page-header-bgColor, var(--color-page-header-bg));" data-turbo-replace> <div class="d-flex flex-nowrap flex-justify-end mb-3 px-3 px-lg-5" style="gap: 1rem;"> <div class="flex-auto min-width-0 width-fit"> <div class=" d-flex flex-wrap flex-items-center wb-break-word f3 text-normal"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo color-fg-muted mr-2"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> <span class="author flex-self-stretch" itemprop="author"> <a class="url fn" rel="author" data-hovercard-type="organization" data-hovercard-url="/orgs/XRPLF/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/XRPLF"> XRPLF </a> </span> <span class="mx-1 flex-self-stretch color-fg-muted">/</span> <strong itemprop="name" class="mr-2 flex-self-stretch"> <a data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" href="/XRPLF/rippled">rippled</a> </strong> <span></span><span class="Label Label--secondary v-align-middle mr-1">Public</span> </div> </div> <div id="repository-details-container" class="flex-shrink-0" data-turbo-replace style="max-width: 70%;"> <ul class="pagehead-actions flex-shrink-0 d-none d-md-inline" style="padding: 2px 0;"> <li> <a href="/login?return_to=%2FXRPLF%2Frippled" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="7b36ffd0af8fe9a688c143e211c4185fd2dfedb7fd05284a7930b868a14a1ce9" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bell mr-2"> <path d="M8 16a2 2 0 0 0 1.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 0 0 8 16ZM3 5a5 5 0 0 1 10 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.519 1.519 0 0 1 13.482 13H2.518a1.516 1.516 0 0 1-1.263-2.36l1.703-2.554A.255.255 0 0 0 3 7.947Zm5-3.5A3.5 3.5 0 0 0 4.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.017.017 0 0 0-.003.01l.001.006c0 .002.002.004.004.006l.006.004.007.001h10.964l.007-.001.006-.004.004-.006.001-.007a.017.017 0 0 0-.003-.01l-1.703-2.554a1.745 1.745 0 0 1-.294-.97V5A3.5 3.5 0 0 0 8 1.5Z"></path> </svg>Notifications </a> <tool-tip id="tooltip-e0b8cb17-8b9e-43c1-b841-8c7bd2f7d0cb" for="repository-details-watch-button" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be signed in to change notification settings</tool-tip> </li> <li> <a icon="repo-forked" id="fork-button" href="/login?return_to=%2FXRPLF%2Frippled" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"repo details fork button","repository_id":2724167,"auth_type":"LOG_IN","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="0ab024ae988ac256f80e7f7dd3f23e74f8b4e464f5fe8535522f4467f815d895" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-forked mr-2"> <path d="M5 5.372v.878c0 .414.336.75.75.75h4.5a.75.75 0 0 0 .75-.75v-.878a2.25 2.25 0 1 1 1.5 0v.878a2.25 2.25 0 0 1-2.25 2.25h-1.5v2.128a2.251 2.251 0 1 1-1.5 0V8.5h-1.5A2.25 2.25 0 0 1 3.5 6.25v-.878a2.25 2.25 0 1 1 1.5 0ZM5 3.25a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Zm6.75.75a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm-3 8.75a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Z"></path> </svg>Fork <span id="repo-network-counter" data-pjax-replace="true" data-turbo-replace="true" title="1,469" data-view-component="true" class="Counter">1.5k</span> </a> </li> <li> <div data-view-component="true" class="BtnGroup d-flex"> <a href="/login?return_to=%2FXRPLF%2Frippled" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"star button","repository_id":2724167,"auth_type":"LOG_IN","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="01a2f2300204ef4b41327943685117c5ffce0d73e3c3c5b955d45d680bc8f7f6" aria-label="You must be signed in to star a repository" data-view-component="true" class="tooltipped tooltipped-sw btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-star v-align-text-bottom d-inline-block mr-2"> <path d="M8 .25a.75.75 0 0 1 .673.418l1.882 3.815 4.21.612a.75.75 0 0 1 .416 1.279l-3.046 2.97.719 4.192a.751.751 0 0 1-1.088.791L8 12.347l-3.766 1.98a.75.75 0 0 1-1.088-.79l.72-4.194L.818 6.374a.75.75 0 0 1 .416-1.28l4.21-.611L7.327.668A.75.75 0 0 1 8 .25Zm0 2.445L6.615 5.5a.75.75 0 0 1-.564.41l-3.097.45 2.24 2.184a.75.75 0 0 1 .216.664l-.528 3.084 2.769-1.456a.75.75 0 0 1 .698 0l2.77 1.456-.53-3.084a.75.75 0 0 1 .216-.664l2.24-2.183-3.096-.45a.75.75 0 0 1-.564-.41L8 2.694Z"></path> </svg><span data-view-component="true" class="d-inline"> Star </span> <span id="repo-stars-counter-star" aria-label="4531 users starred this repository" data-singular-suffix="user starred this repository" data-plural-suffix="users starred this repository" data-turbo-replace="true" title="4,531" data-view-component="true" class="Counter js-social-count">4.5k</span> </a></div> </li> </ul> </div> </div> <div id="responsive-meta-container" data-turbo-replace> </div> <nav data-pjax="#js-repo-pjax-container" aria-label="Repository" data-view-component="true" class="js-repo-nav js-sidenav-container-pjax js-responsive-underlinenav overflow-hidden UnderlineNav px-3 px-md-4 px-lg-5"> <ul data-view-component="true" class="UnderlineNav-body list-style-none"> <li data-view-component="true" class="d-inline-flex"> <a id="code-tab" href="/XRPLF/rippled" data-tab-item="i0code-tab" data-selected-links="repo_source repo_downloads repo_commits repo_releases repo_tags repo_branches repo_packages repo_deployments repo_attestations /XRPLF/rippled" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g c" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Code","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code UnderlineNav-octicon d-none d-sm-inline"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> <span data-content="Code">Code</span> <span id="code-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="issues-tab" href="/XRPLF/rippled/issues" data-tab-item="i1issues-tab" data-selected-links="repo_issues repo_labels repo_milestones /XRPLF/rippled/issues" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g i" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Issues","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> <span data-content="Issues">Issues</span> <span id="issues-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="341" data-view-component="true" class="Counter">341</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="pull-requests-tab" href="/XRPLF/rippled/pulls" data-tab-item="i2pull-requests-tab" data-selected-links="repo_pulls checks /XRPLF/rippled/pulls" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g p" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Pull requests","target":"UNDERLINE_NAV.TAB"}" aria-current="page" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item selected"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> <span data-content="Pull requests">Pull requests</span> <span id="pull-requests-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="61" data-view-component="true" class="Counter">61</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="discussions-tab" href="/XRPLF/rippled/discussions" data-tab-item="i3discussions-tab" data-selected-links="repo_discussions /XRPLF/rippled/discussions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g g" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Discussions","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> <span data-content="Discussions">Discussions</span> <span id="discussions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="actions-tab" href="/XRPLF/rippled/actions" data-tab-item="i4actions-tab" data-selected-links="repo_actions /XRPLF/rippled/actions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g a" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Actions","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> <span data-content="Actions">Actions</span> <span id="actions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="projects-tab" href="/XRPLF/rippled/projects" data-tab-item="i5projects-tab" data-selected-links="repo_projects new_repo_project repo_project /XRPLF/rippled/projects" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g b" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Projects","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-table UnderlineNav-octicon d-none d-sm-inline"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25ZM6.5 6.5v8h7.75a.25.25 0 0 0 .25-.25V6.5Zm8-1.5V1.75a.25.25 0 0 0-.25-.25H6.5V5Zm-13 1.5v7.75c0 .138.112.25.25.25H5v-8ZM5 5V1.5H1.75a.25.25 0 0 0-.25.25V5Z"></path> </svg> <span data-content="Projects">Projects</span> <span id="projects-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="1" data-view-component="true" class="Counter">1</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="wiki-tab" href="/XRPLF/rippled/wiki" data-tab-item="i6wiki-tab" data-selected-links="repo_wiki /XRPLF/rippled/wiki" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g w" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Wiki","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book UnderlineNav-octicon d-none d-sm-inline"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> <span data-content="Wiki">Wiki</span> <span id="wiki-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="security-tab" href="/XRPLF/rippled/security" data-tab-item="i7security-tab" data-selected-links="security overview alerts policy token_scanning code_scanning /XRPLF/rippled/security" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g s" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Security","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield UnderlineNav-octicon d-none d-sm-inline"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span data-content="Security">Security</span> <include-fragment src="/XRPLF/rippled/security/overall-count" accept="text/fragment+html"></include-fragment> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="insights-tab" href="/XRPLF/rippled/pulse" data-tab-item="i8insights-tab" data-selected-links="repo_graphs repo_contributors dependency_graph dependabot_updates pulse people community /XRPLF/rippled/pulse" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Insights","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> <span data-content="Insights">Insights</span> <span id="insights-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> </ul> <div style="visibility:hidden;" data-view-component="true" class="UnderlineNav-actions js-responsive-underlinenav-overflow position-absolute pr-3 pr-md-4 pr-lg-5 right-0"> <action-menu data-select-variant="none" data-view-component="true"> <focus-group direction="vertical" mnemonics retain> <button id="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-button" popovertarget="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-overlay" aria-controls="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-list" aria-haspopup="true" aria-labelledby="tooltip-46bda093-a67c-4a9c-8fd9-e3fa30040a9c" type="button" data-view-component="true" class="Button Button--iconOnly Button--secondary Button--medium UnderlineNav-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-46bda093-a67c-4a9c-8fd9-e3fa30040a9c" for="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-button" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Additional navigation options</tool-tip> <anchored-position id="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-overlay" anchor="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-button" align="start" side="outside-bottom" anchor-offset="normal" popover="auto" data-view-component="true"> <div data-view-component="true" class="Overlay Overlay--size-auto"> <div data-view-component="true" class="Overlay-body Overlay-body--paddingNone"> <action-list> <div data-view-component="true"> <ul aria-labelledby="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-button" id="action-menu-abdc6d7b-ad52-45c8-905a-bff39c82a03b-list" role="menu" data-view-component="true" class="ActionListWrap--inset ActionListWrap"> <li hidden="hidden" data-menu-item="i0code-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-3b73273c-0719-4773-adf0-5bc00c43e7a9" href="/XRPLF/rippled" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Code </span> </a> </li> <li hidden="hidden" data-menu-item="i1issues-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-76e00d5b-aaa4-4584-a9fe-3377c497dac1" href="/XRPLF/rippled/issues" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Issues </span> </a> </li> <li hidden="hidden" data-menu-item="i2pull-requests-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-7bedb6ee-b0a0-4ee6-a170-56348258d5c5" href="/XRPLF/rippled/pulls" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Pull requests </span> </a> </li> <li hidden="hidden" data-menu-item="i3discussions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-989430a2-1884-4090-af2f-849527133bcc" href="/XRPLF/rippled/discussions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Discussions </span> </a> </li> <li hidden="hidden" data-menu-item="i4actions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-3b2cfabd-e8a9-4e20-9604-2e69dcce0629" href="/XRPLF/rippled/actions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Actions </span> </a> </li> <li hidden="hidden" data-menu-item="i5projects-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-2f9fa392-bcd8-4675-94df-d07e100b3734" href="/XRPLF/rippled/projects" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-table"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25ZM6.5 6.5v8h7.75a.25.25 0 0 0 .25-.25V6.5Zm8-1.5V1.75a.25.25 0 0 0-.25-.25H6.5V5Zm-13 1.5v7.75c0 .138.112.25.25.25H5v-8ZM5 5V1.5H1.75a.25.25 0 0 0-.25.25V5Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Projects </span> </a> </li> <li hidden="hidden" data-menu-item="i6wiki-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-7686f0a1-8735-4c1b-8d3b-0d4e5f07030b" href="/XRPLF/rippled/wiki" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Wiki </span> </a> </li> <li hidden="hidden" data-menu-item="i7security-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-9b3301e1-0cbf-4b66-a0b8-729d4c9456ab" href="/XRPLF/rippled/security" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Security </span> </a> </li> <li hidden="hidden" data-menu-item="i8insights-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-9f084ab1-c6aa-4999-a095-e4f6674e2748" href="/XRPLF/rippled/pulse" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Insights </span> </a> </li> </ul> </div></action-list> </div> </div></anchored-position> </focus-group> </action-menu></div> </nav> </div> <turbo-frame id="repo-content-turbo-frame" target="_top" data-turbo-action="advance" class=""> <div id="repo-content-pjax-container" class="repository-content " > <div class="clearfix new-discussion-timeline js-check-all-container container-xl px-3 px-md-4 px-lg-5 mt-4" data-pjax="" data-turbo-frame=""> <div class="clearfix js-issues-results"> <div id="partial-discussion-header" class="gh-header mb-3 js-details-container Details js-socket-channel js-updatable-content pull request js-pull-header-details" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-url="/XRPLF/rippled/pull/4927/partials/title?sticky=true" data-channel-event-name="title_updated" data-pull-is-open="true" data-gid="PR_kwDOACmRR85nuQz2"> <div class="gh-header-show "> <div class="d-flex flex-column flex-md-row"> <div class="gh-header-actions mt-0 mb-3 mb-md-2 ml-1 flex-md-order-1 flex-shrink-0 d-flex flex-items-center gap-1"> <details class="details-reset details-overlay details-overlay-dark float-right" > <summary class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue </summary> <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast overflow-auto" aria-label="Sign up for GitHub"> <button aria-label="Close dialog" data-close-dialog="" type="button" data-view-component="true" class="Link--muted btn-link position-absolute p-4 right-0"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div class="d-flex flex-column p-4"> <div class="mt-3 mb-2 text-center"> <svg height="60" aria-hidden="true" viewBox="0 0 24 24" version="1.1" width="60" data-view-component="true" class="octicon octicon-comment-discussion color-fg-accent"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> </div> <div class="px-4"> <p class="text-center mb-4"> <strong>Have a question about this project?</strong> Sign up for a free GitHub account to open an issue and contact its maintainers and the community. </p> <div class="d-flex flex-items-center"> <a href="/signup?return_to=%2FXRPLF%2Frippled%2Fissues%2Fnew%2Fchoose" data-view-component="true" class="btn-primary btn mx-auto"> Sign up for GitHub </a> </div> <p class="mt-4 color-fg-muted text-center">By clicking “Sign up for GitHub”, you agree to our <a class="Link--inTextBlock" href="https://docs.github.com/terms" target="_blank">terms of service</a> and <a class="Link--inTextBlock" href="https://docs.github.com/privacy" target="_blank">privacy statement</a>. We’ll occasionally send you account related emails.</p> <p class="mt-4 color-fg-muted text-center"> Already on GitHub? <a data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"new issue modal","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="fbd11cd6931884da67517b52449fdec78bcc04ef921c029d76ea19c2d5e9f221" class="Link--inTextBlock" href="/login?return_to=%2FXRPLF%2Frippled%2Fissues%2Fnew%2Fchoose">Sign in</a> to your account </p> </div> </div> </details-dialog> </details> <div class="flex-auto text-right d-block d-md-none"> <a href="#issue-comment-box" class="py-1">Jump to bottom</a> </div> </div> <h1 class="gh-header-title mb-2 lh-condensed f1 mr-0 flex-auto wb-break-word"> <bdi class="js-issue-title markdown-title">Catch the "hooks" branch up with "develop" with a big ol' merge</bdi> <span class="f1-light color-fg-muted">#4927</span> </h1> </div> </div> <div class="d-flex flex-items-center flex-wrap mt-0 gh-header-meta"> <div class="flex-shrink-0 mb-2 flex-self-start flex-md-self-center"> <span reviewable_state="ready" title="Status: Open" data-view-component="true" class="State State--open"> <svg height="16" class="octicon octicon-git-pull-request" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path></svg> Open </span> </div> <div class="flex-auto min-width-0 mb-2"> <a class="author Link--secondary text-bold css-truncate css-truncate-target expandable" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez">ximinez</a> wants to merge <span class="js-updating-pull-request-commits-count">514</span> commits into <span title="XRPLF/rippled:hooks" class="commit-ref css-truncate user-select-contain expandable base-ref"><a title="XRPLF/rippled:hooks" class="no-underline " href="/XRPLF/rippled/tree/hooks"><span class="css-truncate-target">XRPLF</span>:<span class="css-truncate-target">hooks</span></a></span><span></span> <div class="commit-ref-dropdown"> <details class="details-reset details-overlay select-menu commitish-suggester" id="branch-select-menu"> <summary class="btn btn-sm select-menu-button branch"> <i>base:</i> <span class="css-truncate css-truncate-target">hooks</span> </summary> <input-demux-context-wrapper data-context-type="baseChange"> <div class="SelectMenu"> <div class="SelectMenu-modal"> <header class="SelectMenu-header"> <span class="SelectMenu-title">Choose a base branch</span> <button class="SelectMenu-closeButton" type="button" data-toggle-for="branch-select-menu"><svg aria-label="Close menu" aria-hidden="false" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </header> <input-demux data-action="tab-container-change:input-demux#storeInput tab-container-changed:input-demux#updateInput"> <div class="SelectMenu-filter"> <input data-target="input-demux.source" id="context-commitish-filter-field" class="SelectMenu-input form-control" aria-owns="ref-list-branches" data-controls-ref-menu-id="ref-list-branches" autofocus autocomplete="off" aria-label="Find a branch" placeholder="Find a branch" type="text" > </div> <tab-container class="d-flex flex-column js-branches-tags-tabs" style="min-height: 0;"> <div class="SelectMenu-tabs" role="tablist" data-target="input-demux.control" hidden> <button class="SelectMenu-tab" type="button" role="tab" aria-selected="true">Branches</button> <button class="SelectMenu-tab" type="button" role="tab">Tags</button> </div> <div role="tabpanel" id="ref-list-branches" data-filter-placeholder="Find a branch" tabindex="" class="d-flex flex-column flex-auto"> <ref-selector type="branch" data-targets="input-demux.sinks" data-action=" input-entered:ref-selector#inputEntered tab-selected:ref-selector#tabSelected focus-list:ref-selector#focusFirstListMember " query-endpoint="/XRPLF/rippled/refs" cache-key="v0:1731956634.0" current-committish="aG9va3M=" default-branch="ZGV2ZWxvcA==" name-with-owner="WFJQTEYvcmlwcGxlZA==" prefetch-on-mouseover > <template data-target="ref-selector.fetchFailedTemplate"> <div class="SelectMenu-message" data-index="{{ index }}">Could not load branches</div> </template> <template data-target="ref-selector.noMatchTemplate"> <div class="height-full width-full d-flex flex-items-center pl-3"> <span>Branch not found: <strong>{{ refName }}</strong></span> </div> </template> <div data-target="ref-selector.listContainer" role="menu" class="SelectMenu-list m-0" > <div class="SelectMenu-loading pt-3 pb-0 overflow-hidden"> <span data-view-component="true"> <svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg> <span class="sr-only">Loading</span> </span> </div> </div> <template data-target="ref-selector.itemTemplate"> <button type="button" class="SelectMenu-item" role="menuitemradio" rel="nofollow" aria-checked="{{ isCurrent }}" data-index="{{ index }}" data-action="click:input-demux-context-wrapper#onItemSelected"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check SelectMenu-icon SelectMenu-icon--check"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> <span class="flex-1 css-truncate css-truncate-overflow {{ isFilteringClass }} js-ref-name">{{ refName }}</span> <span hidden="{{ isNotDefault }}" class="Label Label--secondary flex-self-start">default</span> </button> </template> </ref-selector> </div> <div role="tabpanel" id="tags-menu" data-filter-placeholder="Find a tag" tabindex="" hidden class="d-flex flex-column flex-auto"> <ref-selector type="tag" data-action=" input-entered:ref-selector#inputEntered tab-selected:ref-selector#tabSelected focus-list:ref-selector#focusFirstListMember " data-targets="input-demux.sinks" query-endpoint="/XRPLF/rippled/refs" cache-key="v0:1731956634.0" current-committish="aG9va3M=" default-branch="ZGV2ZWxvcA==" name-with-owner="WFJQTEYvcmlwcGxlZA==" > <template data-target="ref-selector.fetchFailedTemplate"> <div class="SelectMenu-message" data-index="{{ index }}">Could not load tags</div> </template> <template data-target="ref-selector.noMatchTemplate"> <div class="SelectMenu-message" data-index="{{ index }}">Nothing to show</div> </template> <template data-target="ref-selector.itemTemplate"> <button type="button" class="SelectMenu-item" role="menuitemradio" rel="nofollow" aria-checked="{{ isCurrent }}" data-index="{{ index }}" data-action="click:input-demux-context-wrapper#onItemSelected"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check SelectMenu-icon SelectMenu-icon--check"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> <span class="flex-1 css-truncate css-truncate-overflow {{ isFilteringClass }} js-ref-name">{{ refName }}</span> <span hidden="{{ isNotDefault }}" class="Label Label--secondary flex-self-start">default</span> </button> </template> <div data-target="ref-selector.listContainer" role="menu" class="SelectMenu-list" > <div class="SelectMenu-loading pt-3 pb-0 overflow-hidden"> <span data-view-component="true"> <svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg> <span class="sr-only">Loading</span> </span> </div> </div> </ref-selector> </div> </tab-container> </input-demux> </div> </div> <template class="js-change-base-template"> <div class="Box-header"> <h3 class="Box-title">Are you sure you want to change the base?</h3> </div> <div class="Box-body"> Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated. </div> <div class="Box-footer"> <button form="change-base-form" type="submit" data-view-component="true" class="btn-block js-change-base-form-button Button--primary Button--medium Button"> <span class="Button-content"> <span class="Button-label"><span data-view-component="true"> <svg style="display: none" width="16" height="16" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="js-change-base-spinner v-align-text-bottom mr-1 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg> <span class="sr-only">Loading</span> </span> <span>Change base</span></span> </span> </button> </div> </template> </input-demux-context-wrapper> </details> <!-- '"` --><!-- </textarea></xmp> --></option></form><form id="change-base-form" data-turbo="false" action="/XRPLF/rippled/pull/4927/change_base" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="7Y52KEESznFWuI9BOFjsxk05Fs9wsp/d4EP40vWIz92omY3bcy9F6Ly6KfaalrsElUAMXUK9eIEjsL+RFwpyaA==" /> <input type="hidden" id="pull-change-base-branch-field" name="new_base_binary" class="js-new-base-branch"> </form> </div> from <span title="ximinez/rippled:hooks-merge" class="commit-ref css-truncate user-select-contain expandable head-ref"><a title="ximinez/rippled:hooks-merge" class="no-underline " href="/ximinez/rippled/tree/hooks-merge"><span class="css-truncate-target">ximinez</span>:<span class="css-truncate-target">hooks-merge</span></a></span><span><span data-view-component="true"> <clipboard-copy aria-label="Copy" data-copy-feedback="Copied!" value="ximinez:hooks-merge" data-view-component="true" class="Link--onHover js-copy-branch color-fg-muted d-inline-block ml-1"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg style="display: none;" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check color-fg-success"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span></span> <span class="d-inline-block"> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/primer-react-765944243383.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-core-cd0a67881543.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-lib-7b7b5264f6c1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/octicons-react-45c3a19dd792.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_emotion_is-prop-valid_dist_emotion-is-prop-valid_esm_js-node_modules_emo-62da9f-54c0c921f04b.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-e7dcdd-285fc29e9fa5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover-fn_js-4896ddd4b7bb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/pull-requests-processing-indicator-48cbe3d4fbab.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.9fa170e9435ed4b922b9.module.css" /> <react-partial partial-name="pull-requests-processing-indicator" data-ssr="false" data-attempted-ssr="false" > <script type="application/json" data-target="react-partial.embeddedData">{"props":{"processingIndicatorUrl":"/XRPLF/rippled/pull/4927/partials/processing_indicator","repositoryId":2724167,"pullRequestId":1740180726}}</script> <div data-target="react-partial.reactRoot"></div> </react-partial> </span> </div> </div> <div class="js-sticky js-sticky-offset-scroll top-0 gh-header-sticky"> <div class="sticky-content"> <div class="d-flex flex-items-center flex-justify-between mt-2"> <div class="d-flex flex-row flex-items-center min-width-0"> <div class="mr-2 mb-2 flex-shrink-0"> <span reviewable_state="ready" title="Status: Open" data-view-component="true" class="State State--open"> <svg height="16" class="octicon octicon-git-pull-request" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path></svg> Open </span> </div> <div class="min-width-0 mr-2 mb-2"> <h1 class="d-flex text-bold f5"> <a class="js-issue-title css-truncate css-truncate-target Link--primary width-fit markdown-title js-smoothscroll-anchor" href="#top"> Catch the "hooks" branch up with "develop" with a big ol' merge </a> <span class="gh-header-number color-fg-muted pl-1">#4927</span> </h1> <div class="meta color-fg-muted css-truncate css-truncate-target d-block width-fit"> <a class="author Link--secondary text-bold css-truncate css-truncate-target expandable" data-hovercard-z-index-override="111" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez">ximinez</a> wants to merge <span class="js-updating-pull-request-commits-count">514</span> commits into <span title="XRPLF/rippled:hooks" class="commit-ref css-truncate user-select-contain expandable "><a title="XRPLF/rippled:hooks" class="no-underline " href="/XRPLF/rippled/tree/hooks"><span class="css-truncate-target">XRPLF</span>:<span class="css-truncate-target">hooks</span></a></span><span></span> from <span title="ximinez/rippled:hooks-merge" class="commit-ref css-truncate user-select-contain expandable head-ref"><a title="ximinez/rippled:hooks-merge" class="no-underline " href="/ximinez/rippled/tree/hooks-merge"><span class="css-truncate-target">ximinez</span>:<span class="css-truncate-target">hooks-merge</span></a></span><span><span data-view-component="true"> <clipboard-copy aria-label="Copy" data-copy-feedback="Copied!" value="ximinez:hooks-merge" data-view-component="true" class="Link--onHover js-copy-branch color-fg-muted d-inline-block ml-1"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg style="display: none;" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check color-fg-success"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span></span> </div> </div> </div> </div> </div> </div> <div class="gh-header-shadow color-shadow-small js-notification-shelf-offset-top"></div> </div> <div class="px-3 px-md-0 ml-n3 mr-n3 mx-md-0 tabnav"> <div class="tabnav-extra float-right d-none d-md-block"> <span class="diffstat" id="diffstat"> <span class="color-fg-success"> +209,392 </span> <span class="color-fg-danger"> −130,850 </span> <span> <span class="diffstat-block-added"></span><span class="diffstat-block-added"></span><span class="diffstat-block-added"></span><span class="diffstat-block-deleted"></span><span class="diffstat-block-neutral"></span> </span> </span> </div> <nav class="tabnav-tabs d-flex overflow-auto" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" aria-label="Pull request tabs"> <a href="/XRPLF/rippled/pull/4927" class="tabnav-tab flex-shrink-0 selected" aria-current="page"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion d-none d-md-inline-block"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> Conversation <span id="conversation_tab_counter" title="1" data-view-component="true" class="Counter">1</span> </a> <a href="/XRPLF/rippled/pull/4927/commits" class="tabnav-tab flex-shrink-0 " > <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit d-none d-md-inline-block"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg> Commits <span id="commits_tab_counter" title="250" data-view-component="true" class="Counter js-updateable-pull-request-commits-count">250</span> </a> <a href="/XRPLF/rippled/pull/4927/checks" class="tabnav-tab flex-shrink-0 "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-checklist d-none d-md-inline-block"> <path d="M2.5 1.75v11.5c0 .138.112.25.25.25h3.17a.75.75 0 0 1 0 1.5H2.75A1.75 1.75 0 0 1 1 13.25V1.75C1 .784 1.784 0 2.75 0h8.5C12.216 0 13 .784 13 1.75v7.736a.75.75 0 0 1-1.5 0V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13.274 9.537v-.001l-4.557 4.45a.75.75 0 0 1-1.055-.008l-1.943-1.95a.75.75 0 0 1 1.062-1.058l1.419 1.425 4.026-3.932a.75.75 0 1 1 1.048 1.074ZM4.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM4 7.75A.75.75 0 0 1 4.75 7h2a.75.75 0 0 1 0 1.5h-2A.75.75 0 0 1 4 7.75Z"></path> </svg> Checks <span id="checks_tab_counter" title="20" data-view-component="true" class="Counter">20</span> </a> <a href="/XRPLF/rippled/pull/4927/files" class="tabnav-tab flex-shrink-0 "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-file-diff d-none d-md-inline-block"> <path d="M1 1.75C1 .784 1.784 0 2.75 0h7.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16H2.75A1.75 1.75 0 0 1 1 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h10.5a.25.25 0 0 0 .25-.25V4.664a.25.25 0 0 0-.073-.177l-2.914-2.914a.25.25 0 0 0-.177-.073ZM8 3.25a.75.75 0 0 1 .75.75v1.5h1.5a.75.75 0 0 1 0 1.5h-1.5v1.5a.75.75 0 0 1-1.5 0V7h-1.5a.75.75 0 0 1 0-1.5h1.5V4A.75.75 0 0 1 8 3.25Zm-3 8a.75.75 0 0 1 .75-.75h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1-.75-.75Z"></path> </svg> Files changed <span id="files_tab_counter" title="1,974" data-view-component="true" class="Counter">1,974</span> </a> </nav> </div> <div id="discussion_bucket" class="pull-request-tab-content is-visible js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjY6dGltZWxpbmUiLCJ0IjoxNzMyNDYyNDg3fQ==--5e2df1a23b6ae3a47ac95516b854c580e9828a935d67b1cf9089d5ad1eaeace6"> <div data-view-component="true" class="Layout Layout--flowRow-until-md Layout--sidebarPosition-end Layout--sidebarPosition-flowRow-end"> <div data-view-component="true" class="Layout-main"> <h2 class="sr-only">Conversation</h2> <div class="pull-discussion-timeline js-pull-discussion-timeline js-quote-selection-container js-review-state-classes" data-quote-markdown=".js-comment-body" data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled data-team-hovercards-enabled data-hpc > <template class="js-file-alert-template"> <div data-view-component="true" class="flash flash-warn flash-full d-flex flex-items-center"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span> This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. <a class="Link--inTextBlock" href="https://github.co/hiddenchars" target="_blank">Learn more about bidirectional Unicode characters</a> </span> <div data-view-component="true" class="flash-action"> <a href="{{ revealButtonHref }}" data-view-component="true" class="btn-sm btn"> Show hidden characters </a> </div> </div></template> <template class="js-line-alert-template"> <span aria-label="This line has hidden Unicode characters" data-view-component="true" class="line-alert tooltipped tooltipped-e"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </span></template> <div class="js-discussion ml-0 pl-0 ml-md-6 pl-md-3" > <div class="TimelineItem TimelineItem--condensed pt-0 js-comment-container js-socket-channel js-updatable-content js-command-palette-pull-body" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/pull/4927/partials/body" data-channel-event-name="body_updated" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e"> <div data-view-component="true" class="TimelineItem ml-0 p-0"> <a href="/ximinez" data-view-component="true" class="TimelineItem-avatar avatar circle lh-0 Link"><img data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" src="https://avatars.githubusercontent.com/u/6757714?s=60&v=4" alt="ximinez" size="40" height="40" width="40" data-view-component="true" /></a> </div><div class= "timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0" id="issue-2150478360"> <div id="pullrequest-1740180726" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment editable-comment timeline-comment--caret reorderable-task-lists timeline-comment ml-n3 unminimized-comment"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issue-2150478360-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has been invited to collaborate on the rippled repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Collaborator</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/6757714?s=48&v=4" alt="@ximinez" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block d-md-none mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez">ximinez</a> </strong> commented <a href="#issue-2150478360" id="issue-2150478360-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2024-02-23T06:59:17Z" class="no-wrap">Feb 23, 2024</relative-time></a> <span class="js-comment-edit-history"> <span class="d-inline-block color-fg-muted">•</span> <details class="details-overlay details-reset d-inline-block dropdown hx_dropdown-fullscreen"> <summary class="btn-link no-underline color-fg-muted js-notice"> <div class="position-relative"> <span> edited </span> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down v-align-middle"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </div> </summary> <details-menu class="dropdown-menu dropdown-menu-s width-auto py-0 js-comment-edit-history-menu" style="max-width: 352px; z-index: 99;" src="/user_content_edits/show_edit_history_log/PR_kwDOACmRR85nuQz2" preload > <include-fragment class="my-3" style="min-width: 100px;" aria-label="Loading..."> <span data-view-component="true"> <svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="mx-auto d-block anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg> <span class="sr-only">Loading</span> </span> </include-fragment> </details-menu> </details> </span> </div> </h3> </div> <div> <div class="edit-comment-hide"> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <h2 dir="auto">High Level Overview of Change</h2> <p dir="auto"><em>Note that this is not fully functional code! It is being merged into the <code class="notranslate">hooks</code> branch, which is still "in-development".</em></p> <p dir="auto">This branch merges <code class="notranslate">develop</code> into <code class="notranslate">hooks</code>, and makes some fixes / updates to get it <em>partially</em> working.</p> <p dir="auto">Results by OS:</p> <ol dir="auto"> <li>It builds on Linux, but a unit test run doesn't finish. Some relatively simple unit tests fail. e.g. <code class="notranslate">AccountSet</code>.</li> <li>It doesn't build on Windows / MSVC, but it gets a lot further than the original PR did. Notably, it is able to download and set up the <code class="notranslate">wasmedge</code> dependency using Conan. All of the errors appear to be limited to <code class="notranslate">applyHook.cpp</code>, and all appear to be due to parsing / preprocessing errors with the massively complex macros in <code class="notranslate">macros.h</code></li> <li>It builds with MacOS clang, but fails to start: <code class="notranslate">dyld[6586]: Library not loaded: /opt/homebrew/opt/llvm/lib/libLLVM.dylib Referenced from: <68C35517-5F51-3521-A8EE-2CE9D9882E28> /Users/ed/.conan/data/wasmedge/0.9.0/_/_/package/72521513b9fee5d76bcfd97cf0256cfa56cb3897/lib/libwasmedge_c.dylib</code></li> </ol> <p dir="auto">I have made no significant effort to fix any remaining issues, and I don't intend to, though I will be happy to accept contributions. This is not intended to be working code, just to get the branch caught up so that someone else can get it working.</p> <h3 dir="auto">Context of Change</h3> <p dir="auto">This is a follow up to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1298806544" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4225" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4225/hovercard" href="https://github.com/XRPLF/rippled/pull/4225">#4225</a>, which also only affected that branch.</p> <h3 dir="auto">Type of Change</h3> <ul class="contains-task-list"> <li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds functionality)</li> <li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Breaking change (fix or feature that would cause existing functionality to not work as expected)</li> <li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tests (you added tests for code that already exists, or your new feature included in this PR)</li> </ul> <h2 dir="auto">Future Tasks</h2> <p dir="auto">Significant work and debugging needs to be done to get this "ready for prime time".</p> <p dir="auto"><em>Note that this is not fully functional code! It is being merged into the <code class="notranslate">hooks</code> branch, which is still "in-development".</em></p> </div> </task-lists> </div> </div> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-comment-update" id="issue-2150478360-edit-form" data-type="json" data-turbo="false" action="/XRPLF/rippled/issues/4927" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="JAa_mn4ZdWjnAkoMTSn66ARVjFUqoWZtABiNPr5kiCjAaSr5j_Ovtk_SJIHpwDOQW9pbPvQjpsru-FkpVIvILQ" autocomplete="off" /> <include-fragment loading="lazy" src="/XRPLF/rippled/issues/4927/edit_form?textarea_id=issue-2150478360-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-pick-reaction" data-turbo="false" action="/XRPLF/rippled/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="FztKsLd5lVPyoGah3HCpuzSbsCO_zqmyHTYCPpuyob8UHfuPv7uTi0i28pShb9jx3Skh-msd2X0c-QkRccFrEg" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="PR_kwDOACmRR85nuQz2"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> <div id="js-timeline-progressive-loader" data-timeline-item-src="XRPLF/rippled/timeline_focused_item?after_cursor=Y3Vyc29yOnYyOpPPAAABi4l3yfgH2gAzMTc0MDE4MDcyNjo4NTM0MmIyMWM4NTlmM2QxYWFkZTE0NGQ0N2NlZmFhYWRmYjY2OGVm&before_cursor=Y3Vyc29yOnYyOpPPAAABkkno3jgH2gAzMTc0MDE4MDcyNjo4ZTJjODVkMTRkZTlkZmEwNDM5NGUzMDkxMGRlMTNkNTNlNDVmMGZm&id=PR_kwDOACmRR85nuQz2" ></div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOAQcC_9oAKDNkZWE3OGQzNGI5NGM3MjhlZjgzNGU3YTA1ODIwMmY4NmNmODNlM2Q"> <div> <div id="commits-pushed-3dea78d" data-view-component="true" class="TimelineItem pb-1"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-commit-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/StefanVK/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/StefanVK">StefanVK</a> <span >and others</span> added <span >30</span> commits <a href="#commits-pushed-3dea78d" data-view-component="true" class="Link--inTextBlock Link--secondary Link"> <relative-time tense="past" datetime="2023-10-03T21:21:36-07:00" data-view-component="true">October 3, 2023 21:21</relative-time> </a></div> </div> <div > <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/StefanVK/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/StefanVK"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/22466524?s=40&v=4" width="20" height="20" alt="@StefanVK" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: asan stack-use-after-scope in soci::use with rvalues (#4676) Address a stack-use-after-scope issue when using rvalues with `soci::use`. Replace rvalues with lvalues to ensure the scope extends beyond the end of the expression. The issue arises from `soci` taking a reference to the rvalue without copying its value or extending its lifetime. `soci` references rvalues in `soci::use_container` and then the address in `soci_use_type`. For types like `int`, memory access post-lifetime is unlikely to cause issues. However, for `std::string`, the backing heap memory can be freed and potentially reused, leading to a potential segmentation fault. This was detected on x86_64 using clang-15 with asan. asan confirms resolution of the issue. Fix #4675" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3dea78d34b94c728ef834e7a058202f86cf83e3d">fix: asan stack-use-after-scope in soci::use with rvalues (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1868608670" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4676" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4676/hovercard" href="https://github.com/XRPLF/rippled/pull/4676">XRPLF#4676</a><a title="fix: asan stack-use-after-scope in soci::use with rvalues (#4676) Address a stack-use-after-scope issue when using rvalues with `soci::use`. Replace rvalues with lvalues to ensure the scope extends beyond the end of the expression. The issue arises from `soci` taking a reference to the rvalue without copying its value or extending its lifetime. `soci` references rvalues in `soci::use_container` and then the address in `soci_use_type`. For types like `int`, memory access post-lifetime is unlikely to cause issues. However, for `std::string`, the backing heap memory can be freed and potentially reused, leading to a potential segmentation fault. This was detected on x86_64 using clang-15 with asan. asan confirms resolution of the issue. Fix #4675" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3dea78d34b94c728ef834e7a058202f86cf83e3d">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDNkZWE3OGQzNGI5NGM3MjhlZjgzNGU3YTA1ODIwMmY4NmNmODNlM2Q" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozZGVhNzhkMzRiOTRjNzI4ZWY4MzRlN2EwNTgyMDJmODZjZjgzZTNkIiwidCI6MTczMjQ2MjQ4OH0=--38428d71a2323c68d0a3ff7961699a51eab1d9435e7c1b741692b564f31de29d" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=3dea78d34b94c728ef834e7a058202f86cf83e3d"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="3dea78d34b94c728ef834e7a058202f86cf83e3d" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/3dea78d34b94c728ef834e7a058202f86cf83e3d" class="Link--secondary">3dea78d</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Address a stack-use-after-scope issue when using rvalues with `soci::use`. Replace rvalues with lvalues to ensure the scope extends beyond the end of the expression. The issue arises from `soci` taking a reference to the rvalue without copying its value or extending its lifetime. `soci` references rvalues in `soci::use_container` and then the address in `soci_use_type`. For types like `int`, memory access post-lifetime is unlikely to cause issues. However, for `std::string`, the backing heap memory can be freed and potentially reused, leading to a potential segmentation fault. This was detected on x86_64 using clang-15 with asan. asan confirms resolution of the issue. <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4675.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1868606470" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4675" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4675/hovercard" href="https://github.com/XRPLF/rippled/issues/4675">XRPLF#4675</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs(API-CHANGELOG): clarify account_info response (#4724)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0c43eb39735d5f9c735e77fbaa4855f9465324de">docs(API-CHANGELOG): clarify account_info response (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1910098260" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4724" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4724/hovercard" href="https://github.com/XRPLF/rippled/pull/4724">XRPLF#4724</a><a title="docs(API-CHANGELOG): clarify account_info response (#4724)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0c43eb39735d5f9c735e77fbaa4855f9465324de">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDBjNDNlYjM5NzM1ZDVmOWM3MzVlNzdmYmFhNDg1NWY5NDY1MzI0ZGU" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDowYzQzZWIzOTczNWQ1ZjljNzM1ZTc3ZmJhYTQ4NTVmOTQ2NTMyNGRlIiwidCI6MTczMjQ2MjQ4OH0=--69f836582b731149ba2ff5b03292cbfe81199180d6ffa3dfaaca888a42780562" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=0c43eb39735d5f9c735e77fbaa4855f9465324de"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="0c43eb39735d5f9c735e77fbaa4855f9465324de" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/0c43eb39735d5f9c735e77fbaa4855f9465324de" class="Link--secondary">0c43eb3</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/sokkaofthewatertribe/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sokkaofthewatertribe"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/140777955?s=40&v=4" width="20" height="20" alt="@sokkaofthewatertribe" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix typo in SECURITY.md (#4662)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/40ebbecac8f9bb49195c965bbe1c9bb5159957d4">fix typo in SECURITY.md (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1854958723" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4662" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4662/hovercard" href="https://github.com/XRPLF/rippled/pull/4662">XRPLF#4662</a><a title="fix typo in SECURITY.md (#4662)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/40ebbecac8f9bb49195c965bbe1c9bb5159957d4">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDQwZWJiZWNhYzhmOWJiNDkxOTVjOTY1YmJlMWM5YmI1MTU5OTU3ZDQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo0MGViYmVjYWM4ZjliYjQ5MTk1Yzk2NWJiZTFjOWJiNTE1OTk1N2Q0IiwidCI6MTczMjQ2MjQ4OH0=--7a66be1df5dba5c0dc00398a755e47ffe7887c8a0cf4eda54dc8b2192a445a43" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=40ebbecac8f9bb49195c965bbe1c9bb5159957d4"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="40ebbecac8f9bb49195c965bbe1c9bb5159957d4" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/40ebbecac8f9bb49195c965bbe1c9bb5159957d4" class="Link--secondary">40ebbec</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/mDuo13/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mDuo13"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/7515597?s=40&v=4" width="20" height="20" alt="@mDuo13" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="refactor: reunify transaction common fields: (#4715) Make transactions and pseudo-transactions share the same commonFields again. This regularizes the code in a nice way. While this technically allows pseudo-transactions to have a TicketSequence field, pseudo-transactions are only ever constructed by code paths that don't add such a field, so this is not a transaction processing change. It may be possible to add a separate check to ensure TicketSequence (and other fields that don't make sense on pseudo-transactions) are never added to pseudo-transactions, but that should not be necessary. (TicketSequence is not the only common field that can not and does not appear in pseudo-transactions.) Note: TicketSequence is already documented as a common field. Related: #4637 Fix #4714" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/4e84ad6cd7ecf7d51e8e8bdded9af195443daa8b">refactor: reunify transaction common fields: (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1901644943" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4715" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4715/hovercard" href="https://github.com/XRPLF/rippled/pull/4715">XRPLF#4715</a><a title="refactor: reunify transaction common fields: (#4715) Make transactions and pseudo-transactions share the same commonFields again. This regularizes the code in a nice way. While this technically allows pseudo-transactions to have a TicketSequence field, pseudo-transactions are only ever constructed by code paths that don't add such a field, so this is not a transaction processing change. It may be possible to add a separate check to ensure TicketSequence (and other fields that don't make sense on pseudo-transactions) are never added to pseudo-transactions, but that should not be necessary. (TicketSequence is not the only common field that can not and does not appear in pseudo-transactions.) Note: TicketSequence is already documented as a common field. Related: #4637 Fix #4714" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/4e84ad6cd7ecf7d51e8e8bdded9af195443daa8b">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDRlODRhZDZjZDdlY2Y3ZDUxZThlOGJkZGVkOWFmMTk1NDQzZGFhOGI" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo0ZTg0YWQ2Y2Q3ZWNmN2Q1MWU4ZThiZGRlZDlhZjE5NTQ0M2RhYThiIiwidCI6MTczMjQ2MjQ4OH0=--a67a3b3c1e6fa480d8d44f180553b9493650f622c998a1de4fde283acdf3f6a1" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=4e84ad6cd7ecf7d51e8e8bdded9af195443daa8b"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="4e84ad6cd7ecf7d51e8e8bdded9af195443daa8b" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/4e84ad6cd7ecf7d51e8e8bdded9af195443daa8b" class="Link--secondary">4e84ad6</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Make transactions and pseudo-transactions share the same commonFields again. This regularizes the code in a nice way. While this technically allows pseudo-transactions to have a TicketSequence field, pseudo-transactions are only ever constructed by code paths that don't add such a field, so this is not a transaction processing change. It may be possible to add a separate check to ensure TicketSequence (and other fields that don't make sense on pseudo-transactions) are never added to pseudo-transactions, but that should not be necessary. (TicketSequence is not the only common field that can not and does not appear in pseudo-transactions.) Note: TicketSequence is already documented as a common field. Related: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1829981879" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4637" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4637/hovercard" href="https://github.com/XRPLF/rippled/pull/4637">XRPLF#4637</a> <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4714.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1901455244" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4714" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4714/hovercard" href="https://github.com/XRPLF/rippled/issues/4714">XRPLF#4714</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/seelabs/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/seelabs"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/5853458?s=40&v=4" width="20" height="20" alt="@seelabs" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="refactor: reduce boilerplate in applySteps: (#4710) When a new transactor is added, there are several places in applySteps that need to be modified. This patch refactors the code so only one function needs to be modified." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ec8626046bfb6e11145c4ab65149daba5518a812">refactor: reduce boilerplate in applySteps: (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1898674661" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4710" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4710/hovercard" href="https://github.com/XRPLF/rippled/pull/4710">XRPLF#4710</a><a title="refactor: reduce boilerplate in applySteps: (#4710) When a new transactor is added, there are several places in applySteps that need to be modified. This patch refactors the code so only one function needs to be modified." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ec8626046bfb6e11145c4ab65149daba5518a812">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGVjODYyNjA0NmJmYjZlMTExNDVjNGFiNjUxNDlkYWJhNTUxOGE4MTI" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDplYzg2MjYwNDZiZmI2ZTExMTQ1YzRhYjY1MTQ5ZGFiYTU1MThhODEyIiwidCI6MTczMjQ2MjQ4OH0=--3ad3b595021ebb242f9104bc78864cc054b844305ce413ba0b8a8b2863e97800" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=ec8626046bfb6e11145c4ab65149daba5518a812"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="ec8626046bfb6e11145c4ab65149daba5518a812" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/ec8626046bfb6e11145c4ab65149daba5518a812" class="Link--secondary">ec86260</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">When a new transactor is added, there are several places in applySteps that need to be modified. This patch refactors the code so only one function needs to be modified.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/dangell7/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dangell7"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/25502424?s=40&v=4" width="20" height="20" alt="@dangell7" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <code><a title="`fixDisallowIncomingV1`: allow issuers to authorize trust lines (#4721) Context: The `DisallowIncoming` amendment provides an option to block incoming trust lines from reaching your account. The asfDisallowIncomingTrustline AccountSet Flag, when enabled, prevents any incoming trust line from being created. However, it was too restrictive: it would block an issuer from authorizing a trust line, even if the trust line already exists. Consider: 1. Issuer sets asfRequireAuth on their account. 2. User sets asfDisallowIncomingTrustline on their account. 3. User submits tx to SetTrust to Issuer. At this point, without `fixDisallowIncomingV1` active, the issuer would not be able to authorize the trust line. The `fixDisallowIncomingV1` amendment, once activated, allows an issuer to authorize a trust line even after the user sets the asfDisallowIncomingTrustline flag, as long as the trust line already exists." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/6ba9450c8988be3c74027a9fc53870e491fa1c6a">fixDisallowIncomingV1</a></code><a title="`fixDisallowIncomingV1`: allow issuers to authorize trust lines (#4721) Context: The `DisallowIncoming` amendment provides an option to block incoming trust lines from reaching your account. The asfDisallowIncomingTrustline AccountSet Flag, when enabled, prevents any incoming trust line from being created. However, it was too restrictive: it would block an issuer from authorizing a trust line, even if the trust line already exists. Consider: 1. Issuer sets asfRequireAuth on their account. 2. User sets asfDisallowIncomingTrustline on their account. 3. User submits tx to SetTrust to Issuer. At this point, without `fixDisallowIncomingV1` active, the issuer would not be able to authorize the trust line. The `fixDisallowIncomingV1` amendment, once activated, allows an issuer to authorize a trust line even after the user sets the asfDisallowIncomingTrustline flag, as long as the trust line already exists." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/6ba9450c8988be3c74027a9fc53870e491fa1c6a">: allow issuers to authorize trust lines (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1907527886" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4721" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4721/hovercard" href="https://github.com/XRPLF/rippled/pull/4721">XRPL…</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDZiYTk0NTBjODk4OGJlM2M3NDAyN2E5ZmM1Mzg3MGU0OTFmYTFjNmE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo2YmE5NDUwYzg5ODhiZTNjNzQwMjdhOWZjNTM4NzBlNDkxZmExYzZhIiwidCI6MTczMjQ2MjQ4OH0=--5deecd0d29e870833f5e103837ccaf739f6292b62a2f4cf5fa0ffb02d6cc90c0" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=6ba9450c8988be3c74027a9fc53870e491fa1c6a"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="6ba9450c8988be3c74027a9fc53870e491fa1c6a" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/6ba9450c8988be3c74027a9fc53870e491fa1c6a" class="Link--secondary">6ba9450</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1907527886" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4721" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4721/hovercard" href="https://github.com/XRPLF/rippled/pull/4721">…F#4721</a>) Context: The `DisallowIncoming` amendment provides an option to block incoming trust lines from reaching your account. The asfDisallowIncomingTrustline AccountSet Flag, when enabled, prevents any incoming trust line from being created. However, it was too restrictive: it would block an issuer from authorizing a trust line, even if the trust line already exists. Consider: 1. Issuer sets asfRequireAuth on their account. 2. User sets asfDisallowIncomingTrustline on their account. 3. User submits tx to SetTrust to Issuer. At this point, without `fixDisallowIncomingV1` active, the issuer would not be able to authorize the trust line. The `fixDisallowIncomingV1` amendment, once activated, allows an issuer to authorize a trust line even after the user sets the asfDisallowIncomingTrustline flag, as long as the trust line already exists.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/florent-uzio/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/florent-uzio"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/36513774?s=40&v=4" width="20" height="20" alt="@florent-uzio" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs(rippled-example.cfg): add P2P link compression (#4753) P2P link compression is a feature added in 1.6.0 by #3287. https://xrpl.org/enable-link-compression.html If the default changes in the future - for example, as currently proposed by #4387 - the comment will be updated at that time. Fix #4656" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ced14ec1ab9736536160f959b50b3a6560187c03">docs(rippled-example.cfg): add P2P link compression (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1930054106" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4753" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4753/hovercard" href="https://github.com/XRPLF/rippled/pull/4753">XRPLF#4753</a><a title="docs(rippled-example.cfg): add P2P link compression (#4753) P2P link compression is a feature added in 1.6.0 by #3287. https://xrpl.org/enable-link-compression.html If the default changes in the future - for example, as currently proposed by #4387 - the comment will be updated at that time. Fix #4656" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ced14ec1ab9736536160f959b50b3a6560187c03">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGNlZDE0ZWMxYWI5NzM2NTM2MTYwZjk1OWI1MGIzYTY1NjAxODdjMDM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpjZWQxNGVjMWFiOTczNjUzNjE2MGY5NTliNTBiM2E2NTYwMTg3YzAzIiwidCI6MTczMjQ2MjQ4OH0=--5cc5d0bd6d018e2046ef6b3be62cf8e9b03a069d51f5e34666889a27c0993d1d" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=ced14ec1ab9736536160f959b50b3a6560187c03"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="ced14ec1ab9736536160f959b50b3a6560187c03" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/ced14ec1ab9736536160f959b50b3a6560187c03" class="Link--secondary">ced14ec</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">P2P link compression is a feature added in 1.6.0 by <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="576915162" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3287" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/3287/hovercard" href="https://github.com/XRPLF/rippled/pull/3287">XRPLF#3287</a>. <a href="https://xrpl.org/enable-link-compression.html" rel="nofollow">https://xrpl.org/enable-link-compression.html</a> If the default changes in the future - for example, as currently proposed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1533603131" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4387" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4387/hovercard" href="https://github.com/XRPLF/rippled/pull/4387">XRPLF#4387</a> - the comment will be updated at that time. <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4656.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1851040769" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4656" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4656/hovercard" href="https://github.com/XRPLF/rippled/issues/4656">XRPLF#4656</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs(API-CHANGELOG): add `XRPFees` change (#4741) * Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/053b69c63f3fbe94db9820c8021eff9fc38ac8fa">docs(API-CHANGELOG): add</a> <code><a title="docs(API-CHANGELOG): add `XRPFees` change (#4741) * Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/053b69c63f3fbe94db9820c8021eff9fc38ac8fa">XRPFees</a></code> <a title="docs(API-CHANGELOG): add `XRPFees` change (#4741) * Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/053b69c63f3fbe94db9820c8021eff9fc38ac8fa">change (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1924680099" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4741" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4741/hovercard" href="https://github.com/XRPLF/rippled/pull/4741">XRPLF#4741</a><a title="docs(API-CHANGELOG): add `XRPFees` change (#4741) * Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/053b69c63f3fbe94db9820c8021eff9fc38ac8fa">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDA1M2I2OWM2M2YzZmJlOTRkYjk4MjBjODAyMWVmZjlmYzM4YWM4ZmE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDowNTNiNjljNjNmM2ZiZTk0ZGI5ODIwYzgwMjFlZmY5ZmMzOGFjOGZhIiwidCI6MTczMjQ2MjQ4OH0=--34d06f0ee24264e44605a5d3aa507e13982a762db409a003dc7ce766f4f7d91d" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=053b69c63f3fbe94db9820c8021eff9fc38ac8fa"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="053b69c63f3fbe94db9820c8021eff9fc38ac8fa" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/053b69c63f3fbe94db9820c8021eff9fc38ac8fa" class="Link--secondary">053b69c</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">* Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="ci: reenable Windows CI build with Artifactory support (#4596) Artifactory support was added to the `nix` builds with #4556. This extends that support to the Windows build. Now the Windows build works; CI will build and test a Windows release build. This only affects CI and does not change any C++ code. * Copy the remote setup step outcome fix from #4716 discussion * Allow the Windows job to succeed if tests fail: * Currently the tests do not always pass, even on a single threaded run on the GitHub runners. So we are using parallel runs and mark the test step as allowed to fail (continue-on-error). * At this point, it's more important that the build succeeds than that the tests succeed, because: * We've got plenty of test coverage on the other jobs. * Test failures are much rarer than build failures because of cross-platform issues. * Having a test failure locally doesn't interrupt a workflow nearly as much as a build failure. Note that Conan Center cannot hold the binaries we need. They do not build the configurations we need, and they will not add them. ## Future Tasks This introduces a new bottleneck since the build and test takes over an hour. Speed up the job by: * Making this job run on heavy Windows runners. * Increasing the number of hardware threads." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3e08c390f5f18b308ace0dbdbb27fa02e49141fa">ci: reenable Windows CI build with Artifactory support (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1779893292" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4596" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4596/hovercard" href="https://github.com/XRPLF/rippled/pull/4596">XRPLF#4596</a><a title="ci: reenable Windows CI build with Artifactory support (#4596) Artifactory support was added to the `nix` builds with #4556. This extends that support to the Windows build. Now the Windows build works; CI will build and test a Windows release build. This only affects CI and does not change any C++ code. * Copy the remote setup step outcome fix from #4716 discussion * Allow the Windows job to succeed if tests fail: * Currently the tests do not always pass, even on a single threaded run on the GitHub runners. So we are using parallel runs and mark the test step as allowed to fail (continue-on-error). * At this point, it's more important that the build succeeds than that the tests succeed, because: * We've got plenty of test coverage on the other jobs. * Test failures are much rarer than build failures because of cross-platform issues. * Having a test failure locally doesn't interrupt a workflow nearly as much as a build failure. Note that Conan Center cannot hold the binaries we need. They do not build the configurations we need, and they will not add them. ## Future Tasks This introduces a new bottleneck since the build and test takes over an hour. Speed up the job by: * Making this job run on heavy Windows runners. * Increasing the number of hardware threads." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3e08c390f5f18b308ace0dbdbb27fa02e49141fa">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDNlMDhjMzkwZjVmMThiMzA4YWNlMGRiZGJiMjdmYTAyZTQ5MTQxZmE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozZTA4YzM5MGY1ZjE4YjMwOGFjZTBkYmRiYjI3ZmEwMmU0OTE0MWZhIiwidCI6MTczMjQ2MjQ4OH0=--670a5b059d9b06f9499825ddb6ccc7d95b42c5420f02ed7cedffdd44c4b36d7f" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=3e08c390f5f18b308ace0dbdbb27fa02e49141fa"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="3e08c390f5f18b308ace0dbdbb27fa02e49141fa" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/3e08c390f5f18b308ace0dbdbb27fa02e49141fa" class="Link--secondary">3e08c39</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Artifactory support was added to the `nix` builds with <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1742012950" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4556" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4556/hovercard" href="https://github.com/XRPLF/rippled/pull/4556">XRPLF#4556</a>. This extends that support to the Windows build. Now the Windows build works; CI will build and test a Windows release build. This only affects CI and does not change any C++ code. * Copy the remote setup step outcome fix from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1903799205" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4716" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4716/hovercard" href="https://github.com/XRPLF/rippled/pull/4716">XRPLF#4716</a> discussion * Allow the Windows job to succeed if tests fail: * Currently the tests do not always pass, even on a single threaded run on the GitHub runners. So we are using parallel runs and mark the test step as allowed to fail (continue-on-error). * At this point, it's more important that the build succeeds than that the tests succeed, because: * We've got plenty of test coverage on the other jobs. * Test failures are much rarer than build failures because of cross-platform issues. * Having a test failure locally doesn't interrupt a workflow nearly as much as a build failure. Note that Conan Center cannot hold the binaries we need. They do not build the configurations we need, and they will not add them. ## Future Tasks This introduces a new bottleneck since the build and test takes over an hour. Speed up the job by: * Making this job run on heavy Windows runners. * Increasing the number of hardware threads.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ckeshava/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ckeshava"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/21219765?s=40&v=4" width="20" height="20" alt="@ckeshava" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix(CI): update workflow for uploading binaries to artifactory (#4746) Update the nix CI runner. This commit does not modify any source code files. The unix builds were successful, but the binaries were not uploaded to the internal artifactory. This PR borrows an idea from @ximinez to attempt to fix this issue. After successful authentication, the `outcome` variable contains a string. In the upload step, we are checking if outcome == 'success' as a prerequisite for uploading the binary. This commit updates the contents of the `outcome` variable." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1151fba415a5949adfa1bca8bebf135355a0619c">fix(CI): update workflow for uploading binaries to artifactory (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1926904938" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4746" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4746/hovercard" href="https://github.com/XRPLF/rippled/pull/4746">XRPLF…</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDExNTFmYmE0MTVhNTk0OWFkZmExYmNhOGJlYmYxMzUzNTVhMDYxOWM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoxMTUxZmJhNDE1YTU5NDlhZGZhMWJjYThiZWJmMTM1MzU1YTA2MTljIiwidCI6MTczMjQ2MjQ4OH0=--d2d0f284aefd0ff867fdc5f0e2f24081f597c1cf6cbeca96d61cc6e1f6bb70ac" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=1151fba415a5949adfa1bca8bebf135355a0619c"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="1151fba415a5949adfa1bca8bebf135355a0619c" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/1151fba415a5949adfa1bca8bebf135355a0619c" class="Link--secondary">1151fba</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1926904938" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4746" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4746/hovercard" href="https://github.com/XRPLF/rippled/pull/4746">…#4746</a>) Update the nix CI runner. This commit does not modify any source code files. The unix builds were successful, but the binaries were not uploaded to the internal artifactory. This PR borrows an idea from <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ximinez">@ximinez</a> to attempt to fix this issue. After successful authentication, the `outcome` variable contains a string. In the upload step, we are checking if outcome == 'success' as a prerequisite for uploading the binary. This commit updates the contents of the `outcome` variable.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix(PathRequest): remove incorrect assert (#4743) The assert is saying that the only reason `pathFinder` would be null is if the request was aborted (connection dropped, etc.). That's what `continueCallback()` checks. But that is very clearly not true if you look at `getPathFinder`, which calls `findPaths`, which can return false for many reasons. Fix #4744" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/50cc1cf0c97f6f3cbf8deb6e532804d3196fa319">fix(PathRequest): remove incorrect assert (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1926785916" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4743" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4743/hovercard" href="https://github.com/XRPLF/rippled/pull/4743">XRPLF#4743</a><a title="fix(PathRequest): remove incorrect assert (#4743) The assert is saying that the only reason `pathFinder` would be null is if the request was aborted (connection dropped, etc.). That's what `continueCallback()` checks. But that is very clearly not true if you look at `getPathFinder`, which calls `findPaths`, which can return false for many reasons. Fix #4744" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/50cc1cf0c97f6f3cbf8deb6e532804d3196fa319">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDUwY2MxY2YwYzk3ZjZmM2NiZjhkZWI2ZTUzMjgwNGQzMTk2ZmEzMTk" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo1MGNjMWNmMGM5N2Y2ZjNjYmY4ZGViNmU1MzI4MDRkMzE5NmZhMzE5IiwidCI6MTczMjQ2MjQ4OH0=--0e375d841c58a525c3e02b345cf37ad5fe03ac46cdc0a7dddbfad0828b1e588e" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=50cc1cf0c97f6f3cbf8deb6e532804d3196fa319"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="50cc1cf0c97f6f3cbf8deb6e532804d3196fa319" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/50cc1cf0c97f6f3cbf8deb6e532804d3196fa319" class="Link--secondary">50cc1cf</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">The assert is saying that the only reason `pathFinder` would be null is if the request was aborted (connection dropped, etc.). That's what `continueCallback()` checks. But that is very clearly not true if you look at `getPathFinder`, which calls `findPaths`, which can return false for many reasons. <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4744.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1926795601" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4744" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4744/hovercard" href="https://github.com/XRPLF/rippled/issues/4744">XRPLF#4744</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/JST5000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/JST5000"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/19694186?s=40&v=4" width="20" height="20" alt="@JST5000" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs(conan.md): fix broken link to conanfile.py (#4740)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/c915984340e999cf8224e7d9377eeee8acbc0f2e">docs(conan.md): fix broken link to conanfile.py (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1924647885" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4740" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4740/hovercard" href="https://github.com/XRPLF/rippled/pull/4740">XRPLF#4740</a><a title="docs(conan.md): fix broken link to conanfile.py (#4740)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/c915984340e999cf8224e7d9377eeee8acbc0f2e">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGM5MTU5ODQzNDBlOTk5Y2Y4MjI0ZTdkOTM3N2VlZWU4YWNiYzBmMmU" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpjOTE1OTg0MzQwZTk5OWNmODIyNGU3ZDkzNzdlZWVlOGFjYmMwZjJlIiwidCI6MTczMjQ2MjQ4OH0=--ff02a4916d984e5c8b2212bdd22781154b17ac934d414ddd620cb2ea1c000c39" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=c915984340e999cf8224e7d9377eeee8acbc0f2e"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="c915984340e999cf8224e7d9377eeee8acbc0f2e" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/c915984340e999cf8224e7d9377eeee8acbc0f2e" class="Link--secondary">c915984</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix(CI): Call python to upgrade pip on Windows (#4768) In Windows, we need to call `python` in order for the `pip` upgrade command to work. This changes the GitHub Actions Windows CI job to use the correct command to upgrade PIP, fixing this error: ``` ERROR: To modify pip, please run the following command: C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe -m pip install --upgrade pip ``` A future task is to make job run on heavy Windows runners so that it doesn't take so long. Context: #4596" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1fde585003c286841e3884012bef000d1ff5f4ee">fix(CI): Call python to upgrade pip on Windows (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1945685769" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4768" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4768/hovercard" href="https://github.com/XRPLF/rippled/pull/4768">XRPLF#4768</a><a title="fix(CI): Call python to upgrade pip on Windows (#4768) In Windows, we need to call `python` in order for the `pip` upgrade command to work. This changes the GitHub Actions Windows CI job to use the correct command to upgrade PIP, fixing this error: ``` ERROR: To modify pip, please run the following command: C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe -m pip install --upgrade pip ``` A future task is to make job run on heavy Windows runners so that it doesn't take so long. Context: #4596" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1fde585003c286841e3884012bef000d1ff5f4ee">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDFmZGU1ODUwMDNjMjg2ODQxZTM4ODQwMTJiZWYwMDBkMWZmNWY0ZWU" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoxZmRlNTg1MDAzYzI4Njg0MWUzODg0MDEyYmVmMDAwZDFmZjVmNGVlIiwidCI6MTczMjQ2MjQ4OH0=--b14b7709076daf49ec38e46d97f932e49e8aeebfe039354cc37bb82f43d4256f" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=1fde585003c286841e3884012bef000d1ff5f4ee"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="1fde585003c286841e3884012bef000d1ff5f4ee" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/1fde585003c286841e3884012bef000d1ff5f4ee" class="Link--secondary">1fde585</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">In Windows, we need to call `python` in order for the `pip` upgrade command to work. This changes the GitHub Actions Windows CI job to use the correct command to upgrade PIP, fixing this error: ``` ERROR: To modify pip, please run the following command: C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe -m pip install --upgrade pip ``` A future task is to make job run on heavy Windows runners so that it doesn't take so long. Context: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1779893292" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4596" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4596/hovercard" href="https://github.com/XRPLF/rippled/pull/4596">XRPLF#4596</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Set version to 2.0.0-b3" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1fc1eb9f68cb23d07a1858ed001bf5d57e304d81">Set version to 2.0.0-b3</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDFmYzFlYjlmNjhjYjIzZDA3YTE4NThlZDAwMWJmNWQ1N2UzMDRkODE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoxZmMxZWI5ZjY4Y2IyM2QwN2ExODU4ZWQwMDFiZjVkNTdlMzA0ZDgxIiwidCI6MTczMjQ2MjQ4OH0=--726344f8bb867b0ee703b6338edf15a3afc859f2da9cb84d45f4949eeba1d5aa" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=1fc1eb9f68cb23d07a1858ed001bf5d57e304d81"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="1fc1eb9f68cb23d07a1858ed001bf5d57e304d81" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/1fc1eb9f68cb23d07a1858ed001bf5d57e304d81" class="Link--secondary">1fc1eb9</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs(pull_request_template): add API Impact section (#4757)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/be6ac7e7a17bbe26a47de8c8ef9340c31c14fb46">docs(pull_request_template): add API Impact section (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1936013646" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4757" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4757/hovercard" href="https://github.com/XRPLF/rippled/pull/4757">XRPLF#4757</a><a title="docs(pull_request_template): add API Impact section (#4757)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/be6ac7e7a17bbe26a47de8c8ef9340c31c14fb46">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGJlNmFjN2U3YTE3YmJlMjZhNDdkZThjOGVmOTM0MGMzMWMxNGZiNDY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpiZTZhYzdlN2ExN2JiZTI2YTQ3ZGU4YzhlZjkzNDBjMzFjMTRmYjQ2IiwidCI6MTczMjQ2MjQ4OH0=--ee610af659307cc1799f3474999afd5ccac82efc1bab196415c6fde029848812" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=be6ac7e7a17bbe26a47de8c8ef9340c31c14fb46"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="be6ac7e7a17bbe26a47de8c8ef9340c31c14fb46" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/be6ac7e7a17bbe26a47de8c8ef9340c31c14fb46" class="Link--secondary">be6ac7e</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/scottschurr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/scottschurr"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/7840379?s=40&v=4" width="20" height="20" alt="@scottschurr" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="refactor(peerfinder): use LogicError in PeerFinder::Logic (#4562) It might be possible for the server code to indirect through certain `end()` iterators. While a debug build would catch this problem with `assert()`s, a release build would crash. If there are problems in this area in the future, it is best to get a definitive indication of the nature of the error regardless of whether it's a debug or release build. To accomplish this, these `assert`s are converted into `LogicError`s that will produce a reasonable error message when they fire." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/b69156ac0113bac36f999c3343a58678953a825d">refactor(peerfinder): use LogicError in PeerFinder::Logic (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1746916287" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4562" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4562/hovercard" href="https://github.com/XRPLF/rippled/pull/4562">XRPLF#4562</a><a title="refactor(peerfinder): use LogicError in PeerFinder::Logic (#4562) It might be possible for the server code to indirect through certain `end()` iterators. While a debug build would catch this problem with `assert()`s, a release build would crash. If there are problems in this area in the future, it is best to get a definitive indication of the nature of the error regardless of whether it's a debug or release build. To accomplish this, these `assert`s are converted into `LogicError`s that will produce a reasonable error message when they fire." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/b69156ac0113bac36f999c3343a58678953a825d">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGI2OTE1NmFjMDExM2JhYzM2Zjk5OWMzMzQzYTU4Njc4OTUzYTgyNWQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpiNjkxNTZhYzAxMTNiYWMzNmY5OTljMzM0M2E1ODY3ODk1M2E4MjVkIiwidCI6MTczMjQ2MjQ4OH0=--1950cf012e3c7f8de032fb6d8f9bae12e5cbb90ed3c1d783a3dbb98fe03ed821" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=b69156ac0113bac36f999c3343a58678953a825d"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="b69156ac0113bac36f999c3343a58678953a825d" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/b69156ac0113bac36f999c3343a58678953a825d" class="Link--secondary">b69156a</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">It might be possible for the server code to indirect through certain `end()` iterators. While a debug build would catch this problem with `assert()`s, a release build would crash. If there are problems in this area in the future, it is best to get a definitive indication of the nature of the error regardless of whether it's a debug or release build. To accomplish this, these `assert`s are converted into `LogicError`s that will produce a reasonable error message when they fire.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/dangell7/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dangell7"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/25502424?s=40&v=4" width="20" height="20" alt="@dangell7" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Update the reserved hook error code name to `tecHOOK_REJECTED` (#4559) The old name was `tecHOOK_ERROR`" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/41cd337506f24630a55b628f2ac0df541081c818">Update the reserved hook error code name to</a> <code><a title="Update the reserved hook error code name to `tecHOOK_REJECTED` (#4559) The old name was `tecHOOK_ERROR`" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/41cd337506f24630a55b628f2ac0df541081c818">tecHOOK_REJECTED</a></code> <a title="Update the reserved hook error code name to `tecHOOK_REJECTED` (#4559) The old name was `tecHOOK_ERROR`" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/41cd337506f24630a55b628f2ac0df541081c818">(</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1744576226" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4559" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4559/hovercard" href="https://github.com/XRPLF/rippled/pull/4559">XRPLF…</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDQxY2QzMzc1MDZmMjQ2MzBhNTViNjI4ZjJhYzBkZjU0MTA4MWM4MTg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo0MWNkMzM3NTA2ZjI0NjMwYTU1YjYyOGYyYWMwZGY1NDEwODFjODE4IiwidCI6MTczMjQ2MjQ4OH0=--e7419a896c7eb4f3b5b2f923c48e47c2cd7d4e6269ba1ea03e32abb31035056b" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=41cd337506f24630a55b628f2ac0df541081c818"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="41cd337506f24630a55b628f2ac0df541081c818" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/41cd337506f24630a55b628f2ac0df541081c818" class="Link--secondary">41cd337</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1744576226" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4559" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4559/hovercard" href="https://github.com/XRPLF/rippled/pull/4559">…#4559</a>) The old name was `tecHOOK_ERROR`</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/mvadari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvadari"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/8029314?s=40&v=4" width="20" height="20" alt="@mvadari" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <code><a title="`DID`: Decentralized identifiers (DIDs) (XLS-40): (#4636) Implement native support for W3C DIDs. Add a new ledger object: `DID`. Add two new transactions: 1. `DIDSet`: create or update the `DID` object. 2. `DIDDelete`: delete the `DID` object. This meets the requirements specified in the DID v1.0 specification currently recommended by the W3C Credentials Community Group. The DID format for the XRP Ledger conforms to W3C DID standards. The objects can be created and owned by any XRPL account holder. The transactions can be integrated by any service, wallet, or application." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/b421945e717a29e81b029adea576b24cd2068051">DID</a></code><a title="`DID`: Decentralized identifiers (DIDs) (XLS-40): (#4636) Implement native support for W3C DIDs. Add a new ledger object: `DID`. Add two new transactions: 1. `DIDSet`: create or update the `DID` object. 2. `DIDDelete`: delete the `DID` object. This meets the requirements specified in the DID v1.0 specification currently recommended by the W3C Credentials Community Group. The DID format for the XRP Ledger conforms to W3C DID standards. The objects can be created and owned by any XRPL account holder. The transactions can be integrated by any service, wallet, or application." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/b421945e717a29e81b029adea576b24cd2068051">: Decentralized identifiers (DIDs) (XLS-40): (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1829762224" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4636" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4636/hovercard" href="https://github.com/XRPLF/rippled/pull/4636">XRPLF#4636</a><a title="`DID`: Decentralized identifiers (DIDs) (XLS-40): (#4636) Implement native support for W3C DIDs. Add a new ledger object: `DID`. Add two new transactions: 1. `DIDSet`: create or update the `DID` object. 2. `DIDDelete`: delete the `DID` object. This meets the requirements specified in the DID v1.0 specification currently recommended by the W3C Credentials Community Group. The DID format for the XRP Ledger conforms to W3C DID standards. The objects can be created and owned by any XRPL account holder. The transactions can be integrated by any service, wallet, or application." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/b421945e717a29e81b029adea576b24cd2068051">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGI0MjE5NDVlNzE3YTI5ZTgxYjAyOWFkZWE1NzZiMjRjZDIwNjgwNTE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpiNDIxOTQ1ZTcxN2EyOWU4MWIwMjlhZGVhNTc2YjI0Y2QyMDY4MDUxIiwidCI6MTczMjQ2MjQ4OH0=--fb316847c69eec3e11da19c0f42b5d731542e54c96e4d28f09b8b61dac6a6f4b" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=b421945e717a29e81b029adea576b24cd2068051"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="b421945e717a29e81b029adea576b24cd2068051" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/b421945e717a29e81b029adea576b24cd2068051" class="Link--secondary">b421945</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Implement native support for W3C DIDs. Add a new ledger object: `DID`. Add two new transactions: 1. `DIDSet`: create or update the `DID` object. 2. `DIDDelete`: delete the `DID` object. This meets the requirements specified in the DID v1.0 specification currently recommended by the W3C Credentials Community Group. The DID format for the XRP Ledger conforms to W3C DID standards. The objects can be created and owned by any XRPL account holder. The transactions can be integrated by any service, wallet, or application.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start AvatarStack--two " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/mvadari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvadari"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/8029314?s=40&v=4" width="20" height="20" alt="@mvadari" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/RichardAH/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/RichardAH"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/19866478?s=40&v=4" width="20" height="20" alt="@RichardAH" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="feat(rpc): add `server_definitions` method (#4703) Add a new RPC / WS call for `server_definitions`, which returns an SDK-compatible `definitions.json` (binary enum definitions) generated by the server. This enables clients/libraries to dynamically work with new fields and features, such as ones that may become available on side chains. Clients query `server_definitions` on a node from the network they want to work with, and immediately know how to speak that node's binary "language", even if new features are added to it in the future (as long as there are no new serialized types that the software doesn't know how to serialize/deserialize). Example: ```js > {"command": "server_definitions"} < { "result": { "FIELDS": [ [ "Generic", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": 0, "type": "Unknown" } ], [ "Invalid", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": -1, "type": "Unknown" } ], [ "ObjectEndMarker", { "isSerialized": false, "isSigningField": true, "isVLEncoded": false, "nth": 1, "type": "STObject" } ], ... ``` Close #3657 --------- Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/078bd606c73e73fc242c59b67866143deb19df04">feat(rpc): add</a> <code><a title="feat(rpc): add `server_definitions` method (#4703) Add a new RPC / WS call for `server_definitions`, which returns an SDK-compatible `definitions.json` (binary enum definitions) generated by the server. This enables clients/libraries to dynamically work with new fields and features, such as ones that may become available on side chains. Clients query `server_definitions` on a node from the network they want to work with, and immediately know how to speak that node's binary "language", even if new features are added to it in the future (as long as there are no new serialized types that the software doesn't know how to serialize/deserialize). Example: ```js > {"command": "server_definitions"} < { "result": { "FIELDS": [ [ "Generic", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": 0, "type": "Unknown" } ], [ "Invalid", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": -1, "type": "Unknown" } ], [ "ObjectEndMarker", { "isSerialized": false, "isSigningField": true, "isVLEncoded": false, "nth": 1, "type": "STObject" } ], ... ``` Close #3657 --------- Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/078bd606c73e73fc242c59b67866143deb19df04">server_definitions</a></code> <a title="feat(rpc): add `server_definitions` method (#4703) Add a new RPC / WS call for `server_definitions`, which returns an SDK-compatible `definitions.json` (binary enum definitions) generated by the server. This enables clients/libraries to dynamically work with new fields and features, such as ones that may become available on side chains. Clients query `server_definitions` on a node from the network they want to work with, and immediately know how to speak that node's binary "language", even if new features are added to it in the future (as long as there are no new serialized types that the software doesn't know how to serialize/deserialize). Example: ```js > {"command": "server_definitions"} < { "result": { "FIELDS": [ [ "Generic", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": 0, "type": "Unknown" } ], [ "Invalid", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": -1, "type": "Unknown" } ], [ "ObjectEndMarker", { "isSerialized": false, "isSigningField": true, "isVLEncoded": false, "nth": 1, "type": "STObject" } ], ... ``` Close #3657 --------- Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/078bd606c73e73fc242c59b67866143deb19df04">method (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1895146533" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4703" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4703/hovercard" href="https://github.com/XRPLF/rippled/pull/4703">XRPLF#4703</a><a title="feat(rpc): add `server_definitions` method (#4703) Add a new RPC / WS call for `server_definitions`, which returns an SDK-compatible `definitions.json` (binary enum definitions) generated by the server. This enables clients/libraries to dynamically work with new fields and features, such as ones that may become available on side chains. Clients query `server_definitions` on a node from the network they want to work with, and immediately know how to speak that node's binary "language", even if new features are added to it in the future (as long as there are no new serialized types that the software doesn't know how to serialize/deserialize). Example: ```js > {"command": "server_definitions"} < { "result": { "FIELDS": [ [ "Generic", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": 0, "type": "Unknown" } ], [ "Invalid", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": -1, "type": "Unknown" } ], [ "ObjectEndMarker", { "isSerialized": false, "isSigningField": true, "isVLEncoded": false, "nth": 1, "type": "STObject" } ], ... ``` Close #3657 --------- Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/078bd606c73e73fc242c59b67866143deb19df04">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDA3OGJkNjA2YzczZTczZmMyNDJjNTliNjc4NjYxNDNkZWIxOWRmMDQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDowNzhiZDYwNmM3M2U3M2ZjMjQyYzU5YjY3ODY2MTQzZGViMTlkZjA0IiwidCI6MTczMjQ2MjQ4OH0=--4827b97d10626200614f45d191f31e641e2b5dfb20bc48a3fcfe27c7242ef8de" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=078bd606c73e73fc242c59b67866143deb19df04"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="078bd606c73e73fc242c59b67866143deb19df04" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/078bd606c73e73fc242c59b67866143deb19df04" class="Link--secondary">078bd60</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Add a new RPC / WS call for `server_definitions`, which returns an SDK-compatible `definitions.json` (binary enum definitions) generated by the server. This enables clients/libraries to dynamically work with new fields and features, such as ones that may become available on side chains. Clients query `server_definitions` on a node from the network they want to work with, and immediately know how to speak that node's binary "language", even if new features are added to it in the future (as long as there are no new serialized types that the software doesn't know how to serialize/deserialize). Example: ```js > {"command": "server_definitions"} < { "result": { "FIELDS": [ [ "Generic", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": 0, "type": "Unknown" } ], [ "Invalid", { "isSerialized": false, "isSigningField": false, "isVLEncoded": false, "nth": -1, "type": "Unknown" } ], [ "ObjectEndMarker", { "isSerialized": false, "isSigningField": true, "isVLEncoded": false, "nth": 1, "type": "STObject" } ], ... ``` <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #3657.">Close</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="737049530" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3657" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/3657/hovercard" href="https://github.com/XRPLF/rippled/issues/3657">XRPLF#3657</a> --------- Co-authored-by: Richard Holland <richard.holland@starstone.co.nz></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start AvatarStack--two " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/dangell7/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dangell7"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/25502424?s=40&v=4" width="20" height="20" alt="@dangell7" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/RichardAH/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/RichardAH"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/19866478?s=40&v=4" width="20" height="20" alt="@RichardAH" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: allow pseudo-transactions to omit NetworkID (#4737) The Network ID logic should not be applied to pseudo-transactions. This allows amendments to enable on a network with an ID > 1024. Context: - NetworkID: https://github.com/XRPLF/rippled/pull/4370 - Pseudo-transactions: https://xrpl.org/pseudo-transaction-types.html Fix #4736 --------- Co-authored-by: RichardAH <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8d86c5e17d14b013ad9139e79743e6674e58744a">fix: allow pseudo-transactions to omit NetworkID (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1922301964" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4737" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4737/hovercard" href="https://github.com/XRPLF/rippled/pull/4737">XRPLF#4737</a><a title="fix: allow pseudo-transactions to omit NetworkID (#4737) The Network ID logic should not be applied to pseudo-transactions. This allows amendments to enable on a network with an ID > 1024. Context: - NetworkID: https://github.com/XRPLF/rippled/pull/4370 - Pseudo-transactions: https://xrpl.org/pseudo-transaction-types.html Fix #4736 --------- Co-authored-by: RichardAH <richard.holland@starstone.co.nz>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8d86c5e17d14b013ad9139e79743e6674e58744a">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDhkODZjNWUxN2QxNGIwMTNhZDkxMzllNzk3NDNlNjY3NGU1ODc0NGE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4ZDg2YzVlMTdkMTRiMDEzYWQ5MTM5ZTc5NzQzZTY2NzRlNTg3NDRhIiwidCI6MTczMjQ2MjQ4OH0=--90690f1b34b6bc7e17a1fbc9e8cdb28bf2f99f2cde01ce694276fc6a710779af" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=8d86c5e17d14b013ad9139e79743e6674e58744a"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="8d86c5e17d14b013ad9139e79743e6674e58744a" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/8d86c5e17d14b013ad9139e79743e6674e58744a" class="Link--secondary">8d86c5e</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">The Network ID logic should not be applied to pseudo-transactions. This allows amendments to enable on a network with an ID > 1024. Context: - NetworkID: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1503235193" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4370" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4370/hovercard" href="https://github.com/XRPLF/rippled/pull/4370">XRPLF#4370</a> - Pseudo-transactions: <a href="https://xrpl.org/pseudo-transaction-types.html" rel="nofollow">https://xrpl.org/pseudo-transaction-types.html</a> <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4736.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1922258462" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4736" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4736/hovercard" href="https://github.com/XRPLF/rippled/issues/4736">XRPLF#4736</a> --------- Co-authored-by: RichardAH <richard.holland@starstone.co.nz></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/shichengsg002/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/shichengsg002"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/147461171?s=40&v=4" width="20" height="20" alt="@shichengsg002" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix(CI): set permission for doxygen workflow (#4756)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/5af9dc5abd5ba4dc955a6eb96701dea390c636e8">fix(CI): set permission for doxygen workflow (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1934557121" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4756" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4756/hovercard" href="https://github.com/XRPLF/rippled/pull/4756">XRPLF#4756</a><a title="fix(CI): set permission for doxygen workflow (#4756)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/5af9dc5abd5ba4dc955a6eb96701dea390c636e8">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDVhZjlkYzVhYmQ1YmE0ZGM5NTVhNmViOTY3MDFkZWEzOTBjNjM2ZTg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo1YWY5ZGM1YWJkNWJhNGRjOTU1YTZlYjk2NzAxZGVhMzkwYzYzNmU4IiwidCI6MTczMjQ2MjQ4OH0=--5a61be1f8cef069fb81d1b2dfa449cfa892c0bf7d5d3f3b9b1d34f55ab3aa9ed" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=5af9dc5abd5ba4dc955a6eb96701dea390c636e8"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="5af9dc5abd5ba4dc955a6eb96701dea390c636e8" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/5af9dc5abd5ba4dc955a6eb96701dea390c636e8" class="Link--secondary">5af9dc5</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="perf(CI): use unity builds to speed up Windows CI (#4780) The unity build speeds up compilation by bundling multiple source files into one larger file. This reduces Windows CI build time by up to 50%. As described in #4596, the automatic Windows builds take a very long time. Unity builds are significantly faster - currently about 45 min, much closer to the typical MacOS (35-40 minutes) and nix (~30 minutes) run times. This is intended as a stopgap solution until a more resourced and reliable runner is available. No C++ code was changed. This only affects CI." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/5026cbdaf362b74b927fc6d78aa78d08d1668883">perf(CI): use unity builds to speed up Windows CI (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1955105929" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4780" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4780/hovercard" href="https://github.com/XRPLF/rippled/pull/4780">XRPLF#4780</a><a title="perf(CI): use unity builds to speed up Windows CI (#4780) The unity build speeds up compilation by bundling multiple source files into one larger file. This reduces Windows CI build time by up to 50%. As described in #4596, the automatic Windows builds take a very long time. Unity builds are significantly faster - currently about 45 min, much closer to the typical MacOS (35-40 minutes) and nix (~30 minutes) run times. This is intended as a stopgap solution until a more resourced and reliable runner is available. No C++ code was changed. This only affects CI." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/5026cbdaf362b74b927fc6d78aa78d08d1668883">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDUwMjZjYmRhZjM2MmI3NGI5MjdmYzZkNzhhYTc4ZDA4ZDE2Njg4ODM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo1MDI2Y2JkYWYzNjJiNzRiOTI3ZmM2ZDc4YWE3OGQwOGQxNjY4ODgzIiwidCI6MTczMjQ2MjQ4OH0=--24a38167fe821da02694b640e40e5c0a017a0c867d16c300a27ab150f90df23f" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=5026cbdaf362b74b927fc6d78aa78d08d1668883"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="5026cbdaf362b74b927fc6d78aa78d08d1668883" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/5026cbdaf362b74b927fc6d78aa78d08d1668883" class="Link--secondary">5026cbd</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">The unity build speeds up compilation by bundling multiple source files into one larger file. This reduces Windows CI build time by up to 50%. As described in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1779893292" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4596" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4596/hovercard" href="https://github.com/XRPLF/rippled/pull/4596">XRPLF#4596</a>, the automatic Windows builds take a very long time. Unity builds are significantly faster - currently about 45 min, much closer to the typical MacOS (35-40 minutes) and nix (~30 minutes) run times. This is intended as a stopgap solution until a more resourced and reliable runner is available. No C++ code was changed. This only affects CI.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/823856?s=40&v=4" width="20" height="20" alt="@Bronek" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title='APIv2(DeliverMax): add alias for Amount in Payment transactions (#4733) Using the "Amount" field in Payment transactions can cause incorrect interpretation. There continue to be problems from the use of this field. "Amount" is rarely the correct field to use; instead, "delivered_amount" (or "DeliveredAmount") should be used. Rename the "Amount" field to "DeliverMax", a less misleading name. With api_version: 2, remove the "Amount" field from Payment transactions. - Input: "DeliverMax" in `tx_json` is an alias for "Amount" - sign - submit (in sign-and-submit mode) - submit_multisigned - sign_for - Output: Add "DeliverMax" where transactions are provided by the API - ledger - tx - tx_history - account_tx - transaction_entry - subscribe (transactions stream) - Output: Remove "Amount" from API version 2 Fix #3484 Fix #3902' data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/397268394b80574419fddafe77aa75ea11ad9cfe">APIv2(DeliverMax): add alias for Amount in Payment transactions (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1918136159" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4733" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4733/hovercard" href="https://github.com/XRPLF/rippled/pull/4733">XRPL…</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDM5NzI2ODM5NGI4MDU3NDQxOWZkZGFmZTc3YWE3NWVhMTFhZDljZmU" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozOTcyNjgzOTRiODA1NzQ0MTlmZGRhZmU3N2FhNzVlYTExYWQ5Y2ZlIiwidCI6MTczMjQ2MjQ4OH0=--5634c8d97aa956097fdbd032c9e58a8f8b8dce4811fbca85b0ca4dbab623a94a" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=397268394b80574419fddafe77aa75ea11ad9cfe"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="397268394b80574419fddafe77aa75ea11ad9cfe" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/397268394b80574419fddafe77aa75ea11ad9cfe" class="Link--secondary">3972683</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1918136159" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4733" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4733/hovercard" href="https://github.com/XRPLF/rippled/pull/4733">…F#4733</a>) Using the "Amount" field in Payment transactions can cause incorrect interpretation. There continue to be problems from the use of this field. "Amount" is rarely the correct field to use; instead, "delivered_amount" (or "DeliveredAmount") should be used. Rename the "Amount" field to "DeliverMax", a less misleading name. With api_version: 2, remove the "Amount" field from Payment transactions. - Input: "DeliverMax" in `tx_json` is an alias for "Amount" - sign - submit (in sign-and-submit mode) - submit_multisigned - sign_for - Output: Add "DeliverMax" where transactions are provided by the API - ledger - tx - tx_history - account_tx - transaction_entry - subscribe (transactions stream) - Output: Remove "Amount" from API version 2 <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #3484.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="648438618" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3484" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/3484/hovercard" href="https://github.com/XRPLF/rippled/issues/3484">XRPLF#3484</a> <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #3902.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="966488183" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3902" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/3902/hovercard" href="https://github.com/XRPLF/rippled/issues/3902">XRPLF#3902</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Set version to 2.0.0-b4" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/2a66bb3fc725435db5d3551e390001e9352b63a9">Set version to 2.0.0-b4</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDJhNjZiYjNmYzcyNTQzNWRiNWQzNTUxZTM5MDAwMWU5MzUyYjYzYTk" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoyYTY2YmIzZmM3MjU0MzVkYjVkMzU1MWUzOTAwMDFlOTM1MmI2M2E5IiwidCI6MTczMjQ2MjQ4OH0=--408084291794767ebe595f17662ac1f196b8a380055e0a05d36dca06a1a280c3" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=2a66bb3fc725435db5d3551e390001e9352b63a9"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="2a66bb3fc725435db5d3551e390001e9352b63a9" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/2a66bb3fc725435db5d3551e390001e9352b63a9" class="Link--secondary">2a66bb3</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/mtrippled/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mtrippled"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/7728157?s=40&v=4" width="20" height="20" alt="@mtrippled" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs: clarify definition of network health (#4729) Update the documentation to describe network health with more nuance as well as context about related factors." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3e5f770a3869874d4ee144d91288b00a09ed87f3">docs: clarify definition of network health (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1912434909" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4729" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4729/hovercard" href="https://github.com/XRPLF/rippled/pull/4729">XRPLF#4729</a><a title="docs: clarify definition of network health (#4729) Update the documentation to describe network health with more nuance as well as context about related factors." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3e5f770a3869874d4ee144d91288b00a09ed87f3">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDNlNWY3NzBhMzg2OTg3NGQ0ZWUxNDRkOTEyODhiMDBhMDllZDg3ZjM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozZTVmNzcwYTM4Njk4NzRkNGVlMTQ0ZDkxMjg4YjAwYTA5ZWQ4N2YzIiwidCI6MTczMjQ2MjQ4OH0=--6319966ba2851fdb7a3643f50acd909810f04529a264a907669801a99f078095" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=3e5f770a3869874d4ee144d91288b00a09ed87f3"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="3e5f770a3869874d4ee144d91288b00a09ed87f3" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/3e5f770a3869874d4ee144d91288b00a09ed87f3" class="Link--secondary">3e5f770</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Update the documentation to describe network health with more nuance as well as context about related factors.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/823856?s=40&v=4" width="20" height="20" alt="@Bronek" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="APIv2: remove tx_history and ledger_header (#4759) Remove `tx_history` and `ledger_header` methods from API version 2. Update `RPC::Handler` to allow for methods (or method implementations) to be API version specific. This partially resolves #4727. We can now store multiple handlers with the same name, as long as they belong to different (non-overlapping) API versions. This necessarily impacts the handler lookup algorithm and its complexity; however, there is no performance loss on x86_64 architecture, and only minimal performance loss on arm64 (around 10ns). This design change gives us extra flexibility evolving the API in the future, including other parts of #4727. In API version 2, `tx_history` and `ledger_header` are no longer recognised; if they are called, `rippled` will return error `unknownCmd` Resolve #3638 Resolve #3539" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1eac4d2c07eaac04178ff53c7288bc46c6ce7da0">APIv2: remove tx_history and ledger_header (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1938605052" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4759" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4759/hovercard" href="https://github.com/XRPLF/rippled/pull/4759">XRPLF#4759</a><a title="APIv2: remove tx_history and ledger_header (#4759) Remove `tx_history` and `ledger_header` methods from API version 2. Update `RPC::Handler` to allow for methods (or method implementations) to be API version specific. This partially resolves #4727. We can now store multiple handlers with the same name, as long as they belong to different (non-overlapping) API versions. This necessarily impacts the handler lookup algorithm and its complexity; however, there is no performance loss on x86_64 architecture, and only minimal performance loss on arm64 (around 10ns). This design change gives us extra flexibility evolving the API in the future, including other parts of #4727. In API version 2, `tx_history` and `ledger_header` are no longer recognised; if they are called, `rippled` will return error `unknownCmd` Resolve #3638 Resolve #3539" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/1eac4d2c07eaac04178ff53c7288bc46c6ce7da0">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDFlYWM0ZDJjMDdlYWFjMDQxNzhmZjUzYzcyODhiYzQ2YzZjZTdkYTA" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoxZWFjNGQyYzA3ZWFhYzA0MTc4ZmY1M2M3Mjg4YmM0NmM2Y2U3ZGEwIiwidCI6MTczMjQ2MjQ4OH0=--6035c82eadee3d439b63b02e986d011fac66b6dcd41ebe119be6f63201f8e447" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=1eac4d2c07eaac04178ff53c7288bc46c6ce7da0"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="1eac4d2c07eaac04178ff53c7288bc46c6ce7da0" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/1eac4d2c07eaac04178ff53c7288bc46c6ce7da0" class="Link--secondary">1eac4d2</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Remove `tx_history` and `ledger_header` methods from API version 2. Update `RPC::Handler` to allow for methods (or method implementations) to be API version specific. This partially <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4727.">resolves</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1912090574" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4727" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4727/hovercard" href="https://github.com/XRPLF/rippled/issues/4727">XRPLF#4727</a>. We can now store multiple handlers with the same name, as long as they belong to different (non-overlapping) API versions. This necessarily impacts the handler lookup algorithm and its complexity; however, there is no performance loss on x86_64 architecture, and only minimal performance loss on arm64 (around 10ns). This design change gives us extra flexibility evolving the API in the future, including other parts of <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1912090574" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4727" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4727/hovercard" href="https://github.com/XRPLF/rippled/issues/4727">XRPLF#4727</a>. In API version 2, `tx_history` and `ledger_header` are no longer recognised; if they are called, `rippled` will return error `unknownCmd` <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #3638.">Resolve</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="722355026" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3638" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/3638/hovercard" href="https://github.com/XRPLF/rippled/issues/3638">XRPLF#3638</a> <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #3539.">Resolve</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="657302599" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/3539" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/3539/hovercard" href="https://github.com/XRPLF/rippled/issues/3539">XRPLF#3539</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/823856?s=40&v=4" width="20" height="20" alt="@Bronek" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: remove include <ranges> (#4788) Remove dependency on `<ranges>` header, since it is not implemented by all compilers which we want to support. This code change only affects unit tests. Resolve https://github.com/XRPLF/rippled/issues/4787" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ac02e56519e4c70bf7ec3755b34188935ff97f34">fix: remove include <ranges> (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1961973411" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4788" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4788/hovercard" href="https://github.com/XRPLF/rippled/pull/4788">XRPLF#4788</a><a title="fix: remove include <ranges> (#4788) Remove dependency on `<ranges>` header, since it is not implemented by all compilers which we want to support. This code change only affects unit tests. Resolve https://github.com/XRPLF/rippled/issues/4787" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ac02e56519e4c70bf7ec3755b34188935ff97f34">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGFjMDJlNTY1MTllNGM3MGJmN2VjMzc1NWIzNDE4ODkzNWZmOTdmMzQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDphYzAyZTU2NTE5ZTRjNzBiZjdlYzM3NTViMzQxODg5MzVmZjk3ZjM0IiwidCI6MTczMjQ2MjQ4OH0=--0a2f4913836829de1cecae11772d298399e99898f090f1f21be099c77542caf0" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=ac02e56519e4c70bf7ec3755b34188935ff97f34"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="ac02e56519e4c70bf7ec3755b34188935ff97f34" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/ac02e56519e4c70bf7ec3755b34188935ff97f34" class="Link--secondary">ac02e56</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Remove dependency on `<ranges>` header, since it is not implemented by all compilers which we want to support. This code change only affects unit tests. <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4787.">Resolve</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1961947113" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4787" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4787/hovercard" href="https://github.com/XRPLF/rippled/issues/4787">XRPLF#4787</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start AvatarStack--two " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/3341098?s=40&v=4" width="20" height="20" alt="@gregtatcam" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/scottschurr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/scottschurr"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/7840379?s=40&v=4" width="20" height="20" alt="@scottschurr" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <code><a title="`fixFillOrKill`: fix offer crossing with tfFillOrKill (#4694) Introduce the `fixFillOrKill` amendment. Fix an edge case occurring when an offer with `tfFillOrKill` set (but without `tfSell` set) fails to cross an offer with a better rate. If `tfFillOrKill` is set, then the owner must receive the full TakerPays. Without this amendment, an offer fails if the entire `TakerGets` is not spent. With this amendment, when `tfSell` is not set, the entire `TakerGets` does not have to be spent. For details about OfferCreate, see: https://xrpl.org/offercreate.html Fix #4684 --------- Co-authored-by: Scott Schurr <scott@ripple.com>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3b624d8bf84225c633b2f5a07ad6585215e87cc6">fixFillOrKill</a></code><a title="`fixFillOrKill`: fix offer crossing with tfFillOrKill (#4694) Introduce the `fixFillOrKill` amendment. Fix an edge case occurring when an offer with `tfFillOrKill` set (but without `tfSell` set) fails to cross an offer with a better rate. If `tfFillOrKill` is set, then the owner must receive the full TakerPays. Without this amendment, an offer fails if the entire `TakerGets` is not spent. With this amendment, when `tfSell` is not set, the entire `TakerGets` does not have to be spent. For details about OfferCreate, see: https://xrpl.org/offercreate.html Fix #4684 --------- Co-authored-by: Scott Schurr <scott@ripple.com>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3b624d8bf84225c633b2f5a07ad6585215e87cc6">: fix offer crossing with tfFillOrKill (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1887656687" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4694" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4694/hovercard" href="https://github.com/XRPLF/rippled/pull/4694">XRPLF#4694</a><a title="`fixFillOrKill`: fix offer crossing with tfFillOrKill (#4694) Introduce the `fixFillOrKill` amendment. Fix an edge case occurring when an offer with `tfFillOrKill` set (but without `tfSell` set) fails to cross an offer with a better rate. If `tfFillOrKill` is set, then the owner must receive the full TakerPays. Without this amendment, an offer fails if the entire `TakerGets` is not spent. With this amendment, when `tfSell` is not set, the entire `TakerGets` does not have to be spent. For details about OfferCreate, see: https://xrpl.org/offercreate.html Fix #4684 --------- Co-authored-by: Scott Schurr <scott@ripple.com>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3b624d8bf84225c633b2f5a07ad6585215e87cc6">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDNiNjI0ZDhiZjg0MjI1YzYzM2IyZjVhMDdhZDY1ODUyMTVlODdjYzY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozYjYyNGQ4YmY4NDIyNWM2MzNiMmY1YTA3YWQ2NTg1MjE1ZTg3Y2M2IiwidCI6MTczMjQ2MjQ4OH0=--8270d67b4aff41634d8a7e42abbda0cfa7db82bbb60b08709e4508232f08392e" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=3b624d8bf84225c633b2f5a07ad6585215e87cc6"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="3b624d8bf84225c633b2f5a07ad6585215e87cc6" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/3b624d8bf84225c633b2f5a07ad6585215e87cc6" class="Link--secondary">3b624d8</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Introduce the `fixFillOrKill` amendment. Fix an edge case occurring when an offer with `tfFillOrKill` set (but without `tfSell` set) fails to cross an offer with a better rate. If `tfFillOrKill` is set, then the owner must receive the full TakerPays. Without this amendment, an offer fails if the entire `TakerGets` is not spent. With this amendment, when `tfSell` is not set, the entire `TakerGets` does not have to be spent. For details about OfferCreate, see: <a href="https://xrpl.org/offercreate.html" rel="nofollow">https://xrpl.org/offercreate.html</a> <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #4684.">Fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1876452795" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4684" data-hovercard-type="issue" data-hovercard-url="/XRPLF/rippled/issues/4684/hovercard" href="https://github.com/XRPLF/rippled/issues/4684">XRPLF#4684</a> --------- Co-authored-by: Scott Schurr <scott@ripple.com></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/StefanVK/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/StefanVK"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/22466524?s=40&v=4" width="20" height="20" alt="@StefanVK" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: remove unused variable (#4677) With clang 15, an unused-but-set-variable warning was emitted: PostgresDatabase.cpp:178:14: warning: variable 'expNumResults' set but not used [-Wunused-but-set-variable] uint32_t expNumResults = 1;" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/26b0322aa577f379b303a6cfc07e465f0d1b0b57">fix: remove unused variable (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1868628206" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4677" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4677/hovercard" href="https://github.com/XRPLF/rippled/pull/4677">XRPLF#4677</a><a title="fix: remove unused variable (#4677) With clang 15, an unused-but-set-variable warning was emitted: PostgresDatabase.cpp:178:14: warning: variable 'expNumResults' set but not used [-Wunused-but-set-variable] uint32_t expNumResults = 1;" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/26b0322aa577f379b303a6cfc07e465f0d1b0b57">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDI2YjAzMjJhYTU3N2YzNzliMzAzYTZjZmMwN2U0NjVmMGQxYjBiNTc" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoyNmIwMzIyYWE1NzdmMzc5YjMwM2E2Y2ZjMDdlNDY1ZjBkMWIwYjU3IiwidCI6MTczMjQ2MjQ4OH0=--f8df7a2b4cb2a8b866fd8cc769f9e1a971612dc5e7d5c51ba4f3172276d37a25" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=26b0322aa577f379b303a6cfc07e465f0d1b0b57"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="26b0322aa577f379b303a6cfc07e465f0d1b0b57" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/26b0322aa577f379b303a6cfc07e465f0d1b0b57" class="Link--secondary">26b0322</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">With clang 15, an unused-but-set-variable warning was emitted: PostgresDatabase.cpp:178:14: warning: variable 'expNumResults' set but not used [-Wunused-but-set-variable] uint32_t expNumResults = 1;</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="chore: delete unused Dockerfile (#4791)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/85342b21c859f3d1aade144d47cefaaadfb668ef">chore: delete unused Dockerfile (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1968964203" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4791" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4791/hovercard" href="https://github.com/XRPLF/rippled/pull/4791">XRPLF#4791</a><a title="chore: delete unused Dockerfile (#4791)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/85342b21c859f3d1aade144d47cefaaadfb668ef">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDg1MzQyYjIxYzg1OWYzZDFhYWRlMTQ0ZDQ3Y2VmYWFhZGZiNjY4ZWY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4NTM0MmIyMWM4NTlmM2QxYWFkZTE0NGQ0N2NlZmFhYWRmYjY2OGVmIiwidCI6MTczMjQ2MjQ4OH0=--7189fbccd173928095316b34e7312d7a873ff978385de7e67f68a7e2566c9f0d" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=85342b21c859f3d1aade144d47cefaaadfb668ef"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="85342b21c859f3d1aade144d47cefaaadfb668ef" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/85342b21c859f3d1aade144d47cefaaadfb668ef" class="Link--secondary">85342b2</a> </code> </div> </div> </div> </div> </div> </div> </div> </div> </div> <div id="js-progressive-timeline-item-container"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="ajax-pagination-form js-ajax-pagination pagination-loader-container mt-4 mb-4 ml-0 text-center" data-turbo="false" action="/XRPLF/rippled/pull/4927/timeline_more_items?after_cursor=Y3Vyc29yOnYyOpPPAAABi4l3yfgH2gAzMTc0MDE4MDcyNjo4NTM0MmIyMWM4NTlmM2QxYWFkZTE0NGQ0N2NlZmFhYWRmYjY2OGVm&before_cursor=Y3Vyc29yOnYyOpPPAAABkkno3jgH2gAzMTc0MDE4MDcyNjo4ZTJjODVkMTRkZTlkZmEwNDM5NGUzMDkxMGRlMTNkNTNlNDVmMGZm" accept-charset="UTF-8" method="get"> <div class="discussion-item-header pt-0"> <div class="Box d-inline-flex flex-column"> <button type="submit" class="color-fg-muted ajax-pagination-btn no-underline pb-0 pt-2 px-4 mt-0 mb-1 color-bg-default border-0"> 206 hidden items </button> <button type="submit" class="ajax-pagination-btn no-underline pb-1 pt-0 px-4 mt-0 mb-1 color-bg-default border-0" data-disable-with="Loading…"> Load more… </button> </div> </div> </div> </form> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOAQcC_9oAKDhlMmM4NWQxNGRlOWRmYTA0Mzk0ZTMwOTEwZGUxM2Q1M2U0NWYwZmY"> <div> <div id="commits-pushed-8e2c85d" data-view-component="true" class="TimelineItem pb-1"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-commit-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot">intelliot</a> <span >and others</span> added <span >12</span> commits <a href="#commits-pushed-8e2c85d" data-view-component="true" class="Link--inTextBlock Link--secondary Link"> <relative-time tense="past" datetime="2024-10-01T14:07:31-07:00" data-view-component="true">October 1, 2024 14:07</relative-time> </a></div> </div> <div > <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/81505?s=40&v=4" width="20" height="20" alt="@intelliot" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title='docs: clean up API-CHANGELOG.md (#5064) Move the newest information to the top, i.e., use reverse chronological order within each of the two sections ("API Versions" and "XRP Ledger server versions")' data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8e2c85d14de9dfa04394e30910de13d53e45f0ff">docs: clean up API-CHANGELOG.md (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2406364182" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5064" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5064/hovercard" href="https://github.com/XRPLF/rippled/pull/5064">XRPLF#5064</a><a title='docs: clean up API-CHANGELOG.md (#5064) Move the newest information to the top, i.e., use reverse chronological order within each of the two sections ("API Versions" and "XRP Ledger server versions")' data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8e2c85d14de9dfa04394e30910de13d53e45f0ff">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDhlMmM4NWQxNGRlOWRmYTA0Mzk0ZTMwOTEwZGUxM2Q1M2U0NWYwZmY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4ZTJjODVkMTRkZTlkZmEwNDM5NGUzMDkxMGRlMTNkNTNlNDVmMGZmIiwidCI6MTczMjQ2MjQ4OH0=--24600b3175e6d099440dc09eec52eef1b7edc37200890ae21b4c2344cd029306" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=8e2c85d14de9dfa04394e30910de13d53e45f0ff"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="8e2c85d14de9dfa04394e30910de13d53e45f0ff" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/8e2c85d14de9dfa04394e30910de13d53e45f0ff" class="Link--secondary">8e2c85d</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Move the newest information to the top, i.e., use reverse chronological order within each of the two sections ("API Versions" and "XRP Ledger server versions")</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ckeshava/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ckeshava"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/21219765?s=40&v=4" width="20" height="20" alt="@ckeshava" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Expand Error Message for rpcInternal (#4959) Validator operators have been confused by the rpcInternal error, which can occur if the server is not running in another process." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/bf4a7b6ce8bffd0e098831d95d056e70a433ccce">Expand Error Message for rpcInternal (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2198043291" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/4959" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/4959/hovercard" href="https://github.com/XRPLF/rippled/pull/4959">XRPLF#4959</a><a title="Expand Error Message for rpcInternal (#4959) Validator operators have been confused by the rpcInternal error, which can occur if the server is not running in another process." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/bf4a7b6ce8bffd0e098831d95d056e70a433ccce">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGJmNGE3YjZjZThiZmZkMGUwOTg4MzFkOTVkMDU2ZTcwYTQzM2NjY2U" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpiZjRhN2I2Y2U4YmZmZDBlMDk4ODMxZDk1ZDA1NmU3MGE0MzNjY2NlIiwidCI6MTczMjQ2MjQ4OH0=--1792be466f012f9e57b9569a96f76832f7ba6464bf264724e614bef743d228e7" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=bf4a7b6ce8bffd0e098831d95d056e70a433ccce"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="bf4a7b6ce8bffd0e098831d95d056e70a433ccce" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/bf4a7b6ce8bffd0e098831d95d056e70a433ccce" class="Link--secondary">bf4a7b6</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Validator operators have been confused by the rpcInternal error, which can occur if the server is not running in another process.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Update clang-format workflow" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/f6d647d6c3041b887ad753309eea917a6a9e5e22">Update clang-format workflow</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGY2ZDY0N2Q2YzMwNDFiODg3YWQ3NTMzMDllZWE5MTdhNmE5ZTVlMjI" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpmNmQ2NDdkNmMzMDQxYjg4N2FkNzUzMzA5ZWVhOTE3YTZhOWU1ZTIyIiwidCI6MTczMjQ2MjQ4OH0=--d3ac3212a7de36ee3a13eb3b85e41dba2e9cd390ca629ab65de700cfd53973d7" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=f6d647d6c3041b887ad753309eea917a6a9e5e22"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="f6d647d6c3041b887ad753309eea917a6a9e5e22" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/f6d647d6c3041b887ad753309eea917a6a9e5e22" class="Link--secondary">f6d647d</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Update clang-format settings" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/decb3c178e3286ed10d1b6c00301d82531b7b5b1">Update clang-format settings</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGRlY2IzYzE3OGUzMjg2ZWQxMGQxYjZjMDAzMDFkODI1MzFiN2I1YjE" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpkZWNiM2MxNzhlMzI4NmVkMTBkMWI2YzAwMzAxZDgyNTMxYjdiNWIxIiwidCI6MTczMjQ2MjQ4OH0=--69fd08d245b45f34f00bc1f66e63229e9c704716e1e138b93b5e5e022619f60c" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=decb3c178e3286ed10d1b6c00301d82531b7b5b1"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="decb3c178e3286ed10d1b6c00301d82531b7b5b1" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/decb3c178e3286ed10d1b6c00301d82531b7b5b1" class="Link--secondary">decb3c1</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Update pre-commit hook" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/e7cd03325b4ef8360d540518d2d4ab1d513a7e3a">Update pre-commit hook</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGU3Y2QwMzMyNWI0ZWY4MzYwZDU0MDUxOGQyZDRhYjFkNTEzYTdlM2E" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDplN2NkMDMzMjViNGVmODM2MGQ1NDA1MThkMmQ0YWIxZDUxM2E3ZTNhIiwidCI6MTczMjQ2MjQ4OH0=--6fc324737be5e62bb509b2d3d4809054fee6c24584087f3c54bb84a578a84d3e" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=e7cd03325b4ef8360d540518d2d4ab1d513a7e3a"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="e7cd03325b4ef8360d540518d2d4ab1d513a7e3a" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/e7cd03325b4ef8360d540518d2d4ab1d513a7e3a" class="Link--secondary">e7cd033</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Reformat code with clang-format-18" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/552377c76f55b403a1c876df873a23d780fcc81c">Reformat code with clang-format-18</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDU1MjM3N2M3NmY1NWI0MDNhMWM4NzZkZjg3M2EyM2Q3ODBmY2M4MWM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo1NTIzNzdjNzZmNTViNDAzYTFjODc2ZGY4NzNhMjNkNzgwZmNjODFjIiwidCI6MTczMjQ2MjQ4OH0=--fd4d64679412a12e18ee71473ce0b009b96fa3eac4da51f173cc70be1dea88e1" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=552377c76f55b403a1c876df873a23d780fcc81c"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="552377c76f55b403a1c876df873a23d780fcc81c" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/552377c76f55b403a1c876df873a23d780fcc81c" class="Link--secondary">552377c</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Ignore reformat when blaming" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/f0dabd14460d11d31b9d79a44a73d264d1e003ec">Ignore reformat when blaming</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGYwZGFiZDE0NDYwZDExZDMxYjlkNzlhNDRhNzNkMjY0ZDFlMDAzZWM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpmMGRhYmQxNDQ2MGQxMWQzMWI5ZDc5YTQ0YTczZDI2NGQxZTAwM2VjIiwidCI6MTczMjQ2MjQ4OH0=--80ccf1c41a6f75699036a8370921a3cd39db42c16b025a06587045e479f9eb55" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=f0dabd14460d11d31b9d79a44a73d264d1e003ec"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="f0dabd14460d11d31b9d79a44a73d264d1e003ec" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/f0dabd14460d11d31b9d79a44a73d264d1e003ec" class="Link--secondary">f0dabd1</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Consolidate definitions of fields, objects, transactions, and features (#5122)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/63209c2646717db4c330c92ed435e8c7e6d4a35b">Consolidate definitions of fields, objects, transactions, and features (</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDYzMjA5YzI2NDY3MTdkYjRjMzMwYzkyZWQ0MzVlOGM3ZTZkNGEzNWI" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo2MzIwOWMyNjQ2NzE3ZGI0YzMzMGM5MmVkNDM1ZThjN2U2ZDRhMzViIiwidCI6MTczMjQ2MjQ4OH0=--82167be352c939be45db9bbf37895f80aa1252b2f078a55fd89c4e832849daa1" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=63209c2646717db4c330c92ed435e8c7e6d4a35b"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="63209c2646717db4c330c92ed435e8c7e6d4a35b" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/63209c2646717db4c330c92ed435e8c7e6d4a35b" class="Link--secondary">63209c2</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2511276241" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5122" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5122/hovercard" href="https://github.com/XRPLF/rippled/pull/5122">XRPLF#5122</a>)</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start AvatarStack--three-plus " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/3341098?s=40&v=4" width="20" height="20" alt="@gregtatcam" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/shawnxie999/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/shawnxie999"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/35279399?s=40&v=4" width="20" height="20" alt="@shawnxie999" class=" avatar-user" /> </a> <div class="avatar-more avatar" ></div> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/HowardHinnant/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/HowardHinnant"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6708789?s=40&v=4" width="20" height="20" alt="@HowardHinnant" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1133852?s=40&v=4" width="20" height="20" alt="@thejohnfreeman" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Introduce MPT support (XLS-33d): (#5143) Amendment: - MPTokensV1 New Transactions: - MPTokenIssuanceCreate - MPTokenIssuanceDestroy - MPTokenIssuanceSet - MPTokenAuthorize Modified Transactions: - Payment - Clawback New Objects: - MPTokenIssuance - MPToken API updates: - ledger_entry - account_objects - ledger_data Other: - Add += and -= operators to ValueProxy Read full spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens --------- Co-authored-by: Shawn Xie <shawnxie920@gmail.com> Co-authored-by: Howard Hinnant <howard.hinnant@gmail.com> Co-authored-by: Ed Hennis <ed@ripple.com> Co-authored-by: John Freeman <jfreeman08@gmail.com>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/23c37fa50600f0442bf353cb8ce3324f81919e80">Introduce MPT support (XLS-33d): (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2535548399" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5143" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5143/hovercard" href="https://github.com/XRPLF/rippled/pull/5143">XRPLF#5143</a><a title="Introduce MPT support (XLS-33d): (#5143) Amendment: - MPTokensV1 New Transactions: - MPTokenIssuanceCreate - MPTokenIssuanceDestroy - MPTokenIssuanceSet - MPTokenAuthorize Modified Transactions: - Payment - Clawback New Objects: - MPTokenIssuance - MPToken API updates: - ledger_entry - account_objects - ledger_data Other: - Add += and -= operators to ValueProxy Read full spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens --------- Co-authored-by: Shawn Xie <shawnxie920@gmail.com> Co-authored-by: Howard Hinnant <howard.hinnant@gmail.com> Co-authored-by: Ed Hennis <ed@ripple.com> Co-authored-by: John Freeman <jfreeman08@gmail.com>" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/23c37fa50600f0442bf353cb8ce3324f81919e80">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDIzYzM3ZmE1MDYwMGYwNDQyYmYzNTNjYjhjZTMzMjRmODE5MTllODA" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoyM2MzN2ZhNTA2MDBmMDQ0MmJmMzUzY2I4Y2UzMzI0ZjgxOTE5ZTgwIiwidCI6MTczMjQ2MjQ4OH0=--d395fd01a93e2347449b2fbc60dae1ea28c6e9343df87192d6b4fe3f8ea1a8f6" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=23c37fa50600f0442bf353cb8ce3324f81919e80"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="23c37fa50600f0442bf353cb8ce3324f81919e80" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/23c37fa50600f0442bf353cb8ce3324f81919e80" class="Link--secondary">23c37fa</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Amendment: - MPTokensV1 New Transactions: - MPTokenIssuanceCreate - MPTokenIssuanceDestroy - MPTokenIssuanceSet - MPTokenAuthorize Modified Transactions: - Payment - Clawback New Objects: - MPTokenIssuance - MPToken API updates: - ledger_entry - account_objects - ledger_data Other: - Add += and -= operators to ValueProxy Read full spec: <a href="https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens">https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens</a> --------- Co-authored-by: Shawn Xie <shawnxie920@gmail.com> Co-authored-by: Howard Hinnant <howard.hinnant@gmail.com> Co-authored-by: Ed Hennis <ed@ripple.com> Co-authored-by: John Freeman <jfreeman08@gmail.com></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/BobConanDev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/BobConanDev"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/183866110?s=40&v=4" width="20" height="20" alt="@BobConanDev" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title='Update RELEASENOTES.md (#5154) fix the typo "concensus" -> "consensus"' data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ab5d450d3c249a8396731988eefad21e433e3618">Update RELEASENOTES.md (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2574180983" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5154" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5154/hovercard" href="https://github.com/XRPLF/rippled/pull/5154">XRPLF#5154</a><a title='Update RELEASENOTES.md (#5154) fix the typo "concensus" -> "consensus"' data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ab5d450d3c249a8396731988eefad21e433e3618">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGFiNWQ0NTBkM2MyNDlhODM5NjczMTk4OGVlZmFkMjFlNDMzZTM2MTg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDphYjVkNDUwZDNjMjQ5YTgzOTY3MzE5ODhlZWZhZDIxZTQzM2UzNjE4IiwidCI6MTczMjQ2MjQ4OH0=--6953ec2f7a70c4961d62e3e2e7480231631cada095ecbfc13fd5f0e69e73def8" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=ab5d450d3c249a8396731988eefad21e433e3618"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="ab5d450d3c249a8396731988eefad21e433e3618" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/ab5d450d3c249a8396731988eefad21e433e3618" class="Link--secondary">ab5d450</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">fix the typo "concensus" -> "consensus"</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/yinyiqian1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/yinyiqian1"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/171949508?s=40&v=4" width="20" height="20" alt="@yinyiqian1" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: reject invalid markers in account_objects RPC calls (#5046)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d4a5f8390ee7fc84a62f4169d794ef3d04b303b0">fix: reject invalid markers in account_objects RPC calls (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2350052896" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5046" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5046/hovercard" href="https://github.com/XRPLF/rippled/pull/5046">XRPLF#5046</a><a title="fix: reject invalid markers in account_objects RPC calls (#5046)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d4a5f8390ee7fc84a62f4169d794ef3d04b303b0">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGQ0YTVmODM5MGVlN2ZjODRhNjJmNDE2OWQ3OTRlZjNkMDRiMzAzYjA" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpkNGE1ZjgzOTBlZTdmYzg0YTYyZjQxNjlkNzk0ZWYzZDA0YjMwM2IwIiwidCI6MTczMjQ2MjQ4OH0=--784971cfba40887448e0879fd08c68b00ad848ce284e056c657a5bcc2b852c8e" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=d4a5f8390ee7fc84a62f4169d794ef3d04b303b0"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="d4a5f8390ee7fc84a62f4169d794ef3d04b303b0" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/d4a5f8390ee7fc84a62f4169d794ef3d04b303b0" class="Link--secondary">d4a5f83</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/13349202?s=40&v=4" width="20" height="20" alt="@vlntb" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="docs: Add protobuf dependencies to linux setup instructions (#5156)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0d887ad815f59576aac3ee5fb4b3f021c482af2d">docs: Add protobuf dependencies to linux setup instructions (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2588378211" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5156" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5156/hovercard" href="https://github.com/XRPLF/rippled/pull/5156">XRPLF#5156</a><a title="docs: Add protobuf dependencies to linux setup instructions (#5156)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0d887ad815f59576aac3ee5fb4b3f021c482af2d">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDBkODg3YWQ4MTVmNTk1NzZhYWMzZWU1ZmI0YjNmMDIxYzQ4MmFmMmQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDowZDg4N2FkODE1ZjU5NTc2YWFjM2VlNWZiNGIzZjAyMWM0ODJhZjJkIiwidCI6MTczMjQ2MjQ4OH0=--8fedc291290e2c3c0a36dfae9c12487c8a48668c1d3991dea83583a3fc035cd5" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=0d887ad815f59576aac3ee5fb4b3f021c482af2d"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="0d887ad815f59576aac3ee5fb4b3f021c482af2d" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/0d887ad815f59576aac3ee5fb4b3f021c482af2d" class="Link--secondary">0d887ad</a> </code> </div> </div> </div> </div> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="RRE_lADOACmRR86ALbIYzwAAAAN-5rEo"> <div id="event-15013949736" data-view-component="true" class="TimelineItem js-targetable-element"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-eye"> <path d="M8 2c1.981 0 3.671.992 4.933 2.078 1.27 1.091 2.187 2.345 2.637 3.023a1.62 1.62 0 0 1 0 1.798c-.45.678-1.367 1.932-2.637 3.023C11.67 13.008 9.981 14 8 14c-1.981 0-3.671-.992-4.933-2.078C1.797 10.83.88 9.576.43 8.898a1.62 1.62 0 0 1 0-1.798c.45-.677 1.367-1.931 2.637-3.022C4.33 2.992 6.019 2 8 2ZM1.679 7.932a.12.12 0 0 0 0 .136c.411.622 1.241 1.75 2.366 2.717C5.176 11.758 6.527 12.5 8 12.5c1.473 0 2.825-.742 3.955-1.715 1.124-.967 1.954-2.096 2.366-2.717a.12.12 0 0 0 0-.136c-.412-.621-1.242-1.75-2.366-2.717C10.824 4.242 9.473 3.5 8 3.5c-1.473 0-2.825.742-3.955 1.715-1.124.967-1.954 2.096-2.366 2.717ZM8 10a2 2 0 1 1-.001-3.999A2 2 0 0 1 8 10Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/13349202?s=40&u=c50c772c7e4d7cc07072d2779ddb904bed72b289&v=4" width="20" height="20" alt="@vlntb" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb">vlntb</a> self-requested a review <a href="#event-15013949736" data-view-component="true" class="css-truncate css-truncate-target Link--secondary Link"> <relative-time tense="past" datetime="2024-10-30T18:06:30Z" data-view-component="true">October 30, 2024 18:06</relative-time> </a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOAQcC_9oAKGQ2ZGJmMGUwYTYyNmFlY2E4ZGVmMTYzYTg5ZjU4YWYxOWRkNTBiNTA"> <div> <div > <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/alloynetworks/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/alloynetworks"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/45832257?s=40&v=4" width="20" height="20" alt="@alloynetworks" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Add hubs.xrpkuwait.com to bootstrap (#5169)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d6dbf0e0a626aeca8def163a89f58af19dd50b50">Add hubs.xrpkuwait.com to bootstrap (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2622998732" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5169" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5169/hovercard" href="https://github.com/XRPLF/rippled/pull/5169">XRPLF#5169</a><a title="Add hubs.xrpkuwait.com to bootstrap (#5169)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d6dbf0e0a626aeca8def163a89f58af19dd50b50">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGQ2ZGJmMGUwYTYyNmFlY2E4ZGVmMTYzYTg5ZjU4YWYxOWRkNTBiNTA" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpkNmRiZjBlMGE2MjZhZWNhOGRlZjE2M2E4OWY1OGFmMTlkZDUwYjUwIiwidCI6MTczMjQ2MjQ4OH0=--4bb23bb696fa0e275ea0498372acd9223f34889a6d43b1f8756e386d6ffd7575" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=d6dbf0e0a626aeca8def163a89f58af19dd50b50"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="d6dbf0e0a626aeca8def163a89f58af19dd50b50" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/d6dbf0e0a626aeca8def163a89f58af19dd50b50" class="Link--secondary">d6dbf0e</a> </code> </div> </div> </div> </div> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="HRFPE_lADOACmRR86ALbIYzwAAAAOCj3bK"> <div id="event-15075342026" data-view-component="true" class="TimelineItem js-targetable-element"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/6757714?s=40&u=5db10ed49dfbf972f38215083bf6545c071d589b&v=4" width="20" height="20" alt="@ximinez" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez">ximinez</a> <a data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":1740180726,"repository_id":2724167,"event_id":15075342026,"originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="961be43780e83a3edfb4305471600c63d82783dcd248d92d9c4c2d0465b31bb8" href="/XRPLF/rippled/compare/74cbbe448574146c4ea91edc5c7dc058052584e9..64b15c72b5ff52c1951fd5edc645e9709e8a08cd" data-view-component="true" class="Link--inTextBlock Link--secondary Link">force-pushed</a> the <span class="commit-ref user-select-contain"> <span > <span class=" css-truncate-target">hooks-merge</span> </span> </span> branch from <a href="/XRPLF/rippled/commit/74cbbe448574146c4ea91edc5c7dc058052584e9" data-view-component="true" class="Link--primary Link text-bold"> <code>74cbbe4</code> </a> to <a href="/XRPLF/rippled/commit/64b15c72b5ff52c1951fd5edc645e9709e8a08cd" data-view-component="true" class="Link--primary Link text-bold"> <code>64b15c7</code> </a> <a href="/XRPLF/rippled/compare/74cbbe448574146c4ea91edc5c7dc058052584e9..64b15c72b5ff52c1951fd5edc645e9709e8a08cd" data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":1740180726,"repository_id":2724167,"event_id":15075342026,"originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="961be43780e83a3edfb4305471600c63d82783dcd248d92d9c4c2d0465b31bb8" data-view-component="true" class="Button--invisible Button--small Button Button--invisible-noVisuals float-right ml-2"> <span class="Button-content"> <span class="Button-label">Compare</span> </span> </a> <a href="#event-15075342026" data-view-component="true" class="css-truncate css-truncate-target Link--secondary Link"> <relative-time tense="past" datetime="2024-11-01T22:25:08Z" data-view-component="true">November 1, 2024 22:25</relative-time> </a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOAQcC_9oAKDU0YTM1MGJlNzlhNDU1ZmVjN2I5MWNjYWIxZDc5ZGYwYmU4YmM1ZmQ"> <div> <div id="commits-pushed-54a350b" data-view-component="true" class="TimelineItem pb-1"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-commit-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/yinyiqian1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/yinyiqian1">yinyiqian1</a> <span >and others</span> added <span >12</span> commits <a href="#commits-pushed-54a350b" data-view-component="true" class="Link--inTextBlock Link--secondary Link"> <relative-time tense="past" datetime="2024-11-04T15:27:57-05:00" data-view-component="true">November 4, 2024 15:27</relative-time> </a></div> </div> <div > <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/yinyiqian1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/yinyiqian1"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/171949508?s=40&v=4" width="20" height="20" alt="@yinyiqian1" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Add AMMClawback Transaction (XLS-0073d) (#5142) Amendment: - AMMClawback New Transactions: - AMMClawback Modified Transactions: - AMMCreate - AMMDeposit" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/54a350be79a455fec7b91ccab1d79df0be8bc5fd">Add AMMClawback Transaction (XLS-0073d) (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2535268346" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5142" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5142/hovercard" href="https://github.com/XRPLF/rippled/pull/5142">XRPLF#5142</a><a title="Add AMMClawback Transaction (XLS-0073d) (#5142) Amendment: - AMMClawback New Transactions: - AMMClawback Modified Transactions: - AMMCreate - AMMDeposit" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/54a350be79a455fec7b91ccab1d79df0be8bc5fd">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDU0YTM1MGJlNzlhNDU1ZmVjN2I5MWNjYWIxZDc5ZGYwYmU4YmM1ZmQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo1NGEzNTBiZTc5YTQ1NWZlYzdiOTFjY2FiMWQ3OWRmMGJlOGJjNWZkIiwidCI6MTczMjQ2MjQ4OH0=--d1eab17aa74ebc624a3a579a5c01a17143a6cdb8b11452dacebd797440984d9c" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=54a350be79a455fec7b91ccab1d79df0be8bc5fd"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="54a350be79a455fec7b91ccab1d79df0be8bc5fd" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/54a350be79a455fec7b91ccab1d79df0be8bc5fd" class="Link--secondary">54a350b</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">Amendment: - AMMClawback New Transactions: - AMMClawback Modified Transactions: - AMMCreate - AMMDeposit</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/3341098?s=40&v=4" width="20" height="20" alt="@gregtatcam" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Fix unity build (#5179)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d57cced17b40304c48f74259509d121e0a6afa76">Fix unity build (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2634121789" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5179" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5179/hovercard" href="https://github.com/XRPLF/rippled/pull/5179">XRPLF#5179</a><a title="Fix unity build (#5179)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/d57cced17b40304c48f74259509d121e0a6afa76">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGQ1N2NjZWQxN2I0MDMwNGM0OGY3NDI1OTUwOWQxMjFlMGE2YWZhNzY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpkNTdjY2VkMTdiNDAzMDRjNDhmNzQyNTk1MDlkMTIxZTBhNmFmYTc2IiwidCI6MTczMjQ2MjQ4OH0=--e608181b2a46bdf2e8c074876ef4a5ec86b1b82c3254c284515b07ab2b4ba5be" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=d57cced17b40304c48f74259509d121e0a6afa76"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="d57cced17b40304c48f74259509d121e0a6afa76" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/d57cced17b40304c48f74259509d121e0a6afa76" class="Link--secondary">d57cced</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/3341098?s=40&v=4" width="20" height="20" alt="@gregtatcam" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Add fixAMMv1_2 amendment (#5176) * Add reserve check on AMM Withdraw * Try AMM max offer if changeSpotPriceQuality() fails" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ec61f5e9d32114eac1a2020c3b26abc7299e49e8">Add fixAMMv1_2 amendment (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2628966516" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5176" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5176/hovercard" href="https://github.com/XRPLF/rippled/pull/5176">XRPLF#5176</a><a title="Add fixAMMv1_2 amendment (#5176) * Add reserve check on AMM Withdraw * Try AMM max offer if changeSpotPriceQuality() fails" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/ec61f5e9d32114eac1a2020c3b26abc7299e49e8">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGVjNjFmNWU5ZDMyMTE0ZWFjMWEyMDIwYzNiMjZhYmM3Mjk5ZTQ5ZTg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDplYzYxZjVlOWQzMjExNGVhYzFhMjAyMGMzYjI2YWJjNzI5OWU0OWU4IiwidCI6MTczMjQ2MjQ4OH0=--bb9c3dd8e64ea8f8d0a2374f90967ef839c0c04b97a7992e3d43d091910b9354" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=ec61f5e9d32114eac1a2020c3b26abc7299e49e8"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="ec61f5e9d32114eac1a2020c3b26abc7299e49e8" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/ec61f5e9d32114eac1a2020c3b26abc7299e49e8" class="Link--secondary">ec61f5e</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">* Add reserve check on AMM Withdraw * Try AMM max offer if changeSpotPriceQuality() fails</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/3341098?s=40&v=4" width="20" height="20" alt="@gregtatcam" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Fix token comparison in Payment (#5172) * Checks only Currency or MPT Issuance ID part of the Asset object. * Resolves temREDUNDANT regression detected in testing." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/c5c0e70e23d8f0ae06147e8cad9050f5bacc207c">Fix token comparison in Payment (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2627028059" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5172" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5172/hovercard" href="https://github.com/XRPLF/rippled/pull/5172">XRPLF#5172</a><a title="Fix token comparison in Payment (#5172) * Checks only Currency or MPT Issuance ID part of the Asset object. * Resolves temREDUNDANT regression detected in testing." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/c5c0e70e23d8f0ae06147e8cad9050f5bacc207c">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKGM1YzBlNzBlMjNkOGYwYWUwNjE0N2U4Y2FkOTA1MGY1YmFjYzIwN2M" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDpjNWMwZTcwZTIzZDhmMGFlMDYxNDdlOGNhZDkwNTBmNWJhY2MyMDdjIiwidCI6MTczMjQ2MjQ4OH0=--066df0732a6b648cdd1815538fb75c5c1c64563337e2e2f263f4a894f123d6e3" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=c5c0e70e23d8f0ae06147e8cad9050f5bacc207c"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="c5c0e70e23d8f0ae06147e8cad9050f5bacc207c" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/c5c0e70e23d8f0ae06147e8cad9050f5bacc207c" class="Link--secondary">c5c0e70</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">* Checks only Currency or MPT Issuance ID part of the Asset object. * Resolves temREDUNDANT regression detected in testing.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/oleks-rip/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/oleks-rip"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/115580134?s=40&v=4" width="20" height="20" alt="@oleks-rip" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Introduce Credentials support (XLS-70d): (#5103) Amendment: - Credentials New Transactions: - CredentialCreate - CredentialAccept - CredentialDelete Modified Transactions: - DepositPreauth - Payment - EscrowFinish - PaymentChannelClaim - AccountDelete New Object: - Credential Modified Object: - DepositPreauth API updates: - ledger_entry - account_objects - ledger_data - deposit_authorized Read full spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8e827e32ace41a410a738ccb8ee19c064469b337">Introduce Credentials support (XLS-70d): (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2483591019" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5103" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5103/hovercard" href="https://github.com/XRPLF/rippled/pull/5103">XRPLF#5103</a><a title="Introduce Credentials support (XLS-70d): (#5103) Amendment: - Credentials New Transactions: - CredentialCreate - CredentialAccept - CredentialDelete Modified Transactions: - DepositPreauth - Payment - EscrowFinish - PaymentChannelClaim - AccountDelete New Object: - Credential Modified Object: - DepositPreauth API updates: - ledger_entry - account_objects - ledger_data - deposit_authorized Read full spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8e827e32ace41a410a738ccb8ee19c064469b337">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDhlODI3ZTMyYWNlNDFhNDEwYTczOGNjYjhlZTE5YzA2NDQ2OWIzMzc" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4ZTgyN2UzMmFjZTQxYTQxMGE3MzhjY2I4ZWUxOWMwNjQ0NjliMzM3IiwidCI6MTczMjQ2MjQ4OH0=--f368b6928f7d3f5644dd591b6bf25613a0780b98ba0a2e059e510023d830802e" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=8e827e32ace41a410a738ccb8ee19c064469b337"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="8e827e32ace41a410a738ccb8ee19c064469b337" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/8e827e32ace41a410a738ccb8ee19c064469b337" class="Link--secondary">8e827e3</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap"> Amendment: - Credentials New Transactions: - CredentialCreate - CredentialAccept - CredentialDelete Modified Transactions: - DepositPreauth - Payment - EscrowFinish - PaymentChannelClaim - AccountDelete New Object: - Credential Modified Object: - DepositPreauth API updates: - ledger_entry - account_objects - ledger_data - deposit_authorized Read full spec: <a href="https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials">https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials</a></pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/823856?s=40&v=4" width="20" height="20" alt="@Bronek" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Fix potential deadlock (#5124) * 2.2.2 changed functions acquireAsync and NetworkOPsImp::recvValidation to add an item to a collection under lock, unlock, do some work, then lock again to do remove the item. It will deadlock if an exception is thrown while adding the item - before unlocking. * Replace ScopedUnlock with scope_unlock." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/9e48fc0c834e8a6e340c521e9ec58b97b944c1fd">Fix potential deadlock (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2513504157" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5124" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5124/hovercard" href="https://github.com/XRPLF/rippled/pull/5124">XRPLF#5124</a><a title="Fix potential deadlock (#5124) * 2.2.2 changed functions acquireAsync and NetworkOPsImp::recvValidation to add an item to a collection under lock, unlock, do some work, then lock again to do remove the item. It will deadlock if an exception is thrown while adding the item - before unlocking. * Replace ScopedUnlock with scope_unlock." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/9e48fc0c834e8a6e340c521e9ec58b97b944c1fd">)</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDllNDhmYzBjODM0ZThhNmUzNDBjNTIxZTllYzU4Yjk3Yjk0NGMxZmQ" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo5ZTQ4ZmMwYzgzNGU4YTZlMzQwYzUyMWU5ZWM1OGI5N2I5NDRjMWZkIiwidCI6MTczMjQ2MjQ4OH0=--a8be5d0cee4754bddf69795bfb219b8ee7ea0d116170da3240637347ab0d3d03" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=9e48fc0c834e8a6e340c521e9ec58b97b944c1fd"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="9e48fc0c834e8a6e340c521e9ec58b97b944c1fd" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/9e48fc0c834e8a6e340c521e9ec58b97b944c1fd" class="Link--secondary">9e48fc0</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">* 2.2.2 changed functions acquireAsync and NetworkOPsImp::recvValidation to add an item to a collection under lock, unlock, do some work, then lock again to do remove the item. It will deadlock if an exception is thrown while adding the item - before unlocking. * Replace ScopedUnlock with scope_unlock.</pre> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/shawnxie999/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/shawnxie999"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/35279399?s=40&v=4" width="20" height="20" alt="@shawnxie999" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Replace Uint192 with Hash192 in server_definitions response (#5177)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/7b18006193c261fefda45e1ef05ac1c48375047c">Replace Uint192 with Hash192 in server_definitions response (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2629469848" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5177" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5177/hovercard" href="https://github.com/XRPLF/rippled/pull/5177">XRPLF#5177</a><a title="Replace Uint192 with Hash192 in server_definitions response (#5177)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/7b18006193c261fefda45e1ef05ac1c48375047c">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDdiMTgwMDYxOTNjMjYxZmVmZGE0NWUxZWYwNWFjMWM0ODM3NTA0N2M" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo3YjE4MDA2MTkzYzI2MWZlZmRhNDVlMWVmMDVhYzFjNDgzNzUwNDdjIiwidCI6MTczMjQ2MjQ4OH0=--6b5736aeec3fd72b5a78e0ba9194bee603b6fd42a12808195707c67e86fa728d" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=7b18006193c261fefda45e1ef05ac1c48375047c"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="7b18006193c261fefda45e1ef05ac1c48375047c" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/7b18006193c261fefda45e1ef05ac1c48375047c" class="Link--secondary">7b18006</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Set version to 2.3.0-rc1" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/9d58f11a60881b3edb5de80cae52d8b758ae30a8">Set version to 2.3.0-rc1</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDlkNThmMTFhNjA4ODFiM2VkYjVkZTgwY2FlNTJkOGI3NThhZTMwYTg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo5ZDU4ZjExYTYwODgxYjNlZGI1ZGU4MGNhZTUyZDhiNzU4YWUzMGE4IiwidCI6MTczMjQ2MjQ4OH0=--73720dd2f55f69dca4a35e6cbcd63c8c09bca49d0c00144ce181ba802ac25a59" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=9d58f11a60881b3edb5de80cae52d8b758ae30a8"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="9d58f11a60881b3edb5de80cae52d8b758ae30a8" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/9d58f11a60881b3edb5de80cae52d8b758ae30a8" class="Link--secondary">9d58f11</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/823856?s=40&v=4" width="20" height="20" alt="@Bronek" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Fix ledger_entry crash on invalid credentials request (#5189)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/2316d843d7f9bc6963b3519f4464913c27eb7335">Fix ledger_entry crash on invalid credentials request (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2652477975" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5189" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5189/hovercard" href="https://github.com/XRPLF/rippled/pull/5189">XRPLF#5189</a><a title="Fix ledger_entry crash on invalid credentials request (#5189)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/2316d843d7f9bc6963b3519f4464913c27eb7335">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDIzMTZkODQzZDdmOWJjNjk2M2IzNTE5ZjQ0NjQ5MTNjMjdlYjczMzU" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDoyMzE2ZDg0M2Q3ZjliYzY5NjNiMzUxOWY0NDY0OTEzYzI3ZWI3MzM1IiwidCI6MTczMjQ2MjQ4OH0=--70a376ebdb289c509cc1a089b96777bff4812106d6e0991931b5c3f3de1d818b" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=2316d843d7f9bc6963b3519f4464913c27eb7335"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="2316d843d7f9bc6963b3519f4464913c27eb7335" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/2316d843d7f9bc6963b3519f4464913c27eb7335" class="Link--secondary">2316d84</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/mvadari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvadari"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/8029314?s=40&v=4" width="20" height="20" alt="@mvadari" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">fix: include</a> <code><a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">index</a></code> <a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">in</a> <code><a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">server_definitions</a></code> <a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">RPC (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2653406483" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5190" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5190/hovercard" href="https://github.com/XRPLF/rippled/pull/5190">XRPLF#5190</a><a title="fix: include `index` in `server_definitions` RPC (#5190)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDgxODYyNTM3MDdmMmY2MGQxNTY2ODc4YWY1MDY1Nzk5YjZlYjBlZjg" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4MTg2MjUzNzA3ZjJmNjBkMTU2Njg3OGFmNTA2NTc5OWI2ZWIwZWY4IiwidCI6MTczMjQ2MjQ4OH0=--ef289635888875c5a3da853f66b0e39c19dd62ee264be9d184201ef4470dc8aa" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=8186253707f2f60d1566878af5065799b6eb0ef8"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="8186253707f2f60d1566878af5065799b6eb0ef8" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/8186253707f2f60d1566878af5065799b6eb0ef8" class="Link--secondary">8186253</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Set version to 2.3.0-rc2" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/838978b86957534e801859e805f748627af9529c">Set version to 2.3.0-rc2</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDgzODk3OGI4Njk1NzUzNGU4MDE4NTllODA1Zjc0ODYyN2FmOTUyOWM" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDo4Mzg5NzhiODY5NTc1MzRlODAxODU5ZTgwNWY3NDg2MjdhZjk1MjljIiwidCI6MTczMjQ2MjQ4OH0=--29bda75d0fdf011df9eff9fc40cb144c7fd1742fcf97465fdd6086363984d981" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=838978b86957534e801859e805f748627af9529c"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="838978b86957534e801859e805f748627af9529c" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/838978b86957534e801859e805f748627af9529c" class="Link--secondary">838978b</a> </code> </div> </div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/oleks-rip/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/oleks-rip"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/115580134?s=40&v=4" width="20" height="20" alt="@oleks-rip" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="fix: check for valid ammID field in amm_info RPC (#5188)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0ec17b6026298dc150099b66a2cecad0fe561d1b">fix: check for valid ammID field in amm_info RPC (</a><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2650498062" data-permission-text="Title is private" data-url="https://github.com/XRPLF/rippled/issues/5188" data-hovercard-type="pull_request" data-hovercard-url="/XRPLF/rippled/pull/5188/hovercard" href="https://github.com/XRPLF/rippled/pull/5188">XRPLF#5188</a><a title="fix: check for valid ammID field in amm_info RPC (#5188)" data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/0ec17b6026298dc150099b66a2cecad0fe561d1b">)</a> </code> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDBlYzE3YjYwMjYyOThkYzE1MDA5OWI2NmEyY2VjYWQwZmU1NjFkMWI" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDowZWMxN2I2MDI2Mjk4ZGMxNTAwOTliNjZhMmNlY2FkMGZlNTYxZDFiIiwidCI6MTczMjQ2MjQ4OH0=--9e5773a2e438fe01673109255747c8b7062b7a6d6a29498eafaf532443c33501" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=0ec17b6026298dc150099b66a2cecad0fe561d1b"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="0ec17b6026298dc150099b66a2cecad0fe561d1b" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/0ec17b6026298dc150099b66a2cecad0fe561d1b" class="Link--secondary">0ec17b6</a> </code> </div> </div> </div> </div> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="PRR_kwDOACmRR86SJ6-p"> <div class=""> <div id="pullrequestreview-2452074409" class="js-comment js-updatable-content js-socket-channel js-targetable-element js-minimize-container" data-gid="PRR_kwDOACmRR86SJ6-p" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0X3JldmlldzoyNDUyMDc0NDA5IiwidCI6MTczMjQ2MjQ4OH0=--0016aac8dd7204063622b5b8e8211a135ba0c48be212c48a6970ed4e9bbe7071" data-url="/XRPLF/rippled/pull/4927/partials/reviews/2452074409" > <div data-view-component="true" class="TimelineItem"> <a href="/vlntb" data-view-component="true" class="TimelineItem-avatar avatar circle lh-0 Link"><img data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" src="https://avatars.githubusercontent.com/u/13349202?s=60&v=4" alt="vlntb" size="40" height="40" width="40" data-view-component="true" /></a> <div aria-label="Only reviews by reviewers with write access count toward mergeability" aria-role="image" data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body d-flex flex-column flex-md-row flex-justify-start"> <div class="flex-auto flex-md-self-center"> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb">vlntb</a> </strong> approved these changes <span class="color-fg-muted"> <a href="#pullrequestreview-2452074409" class="js-timestamp Link--secondary" id="pullrequestreview-2452074409-permalink"> <relative-time datetime="2024-11-21T16:46:44Z" class="no-wrap">Nov 21, 2024</relative-time> </a> </span> </div> <div class="ml-md-2 mt-md-0 mt-2 flex-shrink-0"> <a href="/XRPLF/rippled/pull/4927/files" data-view-component="true" class="Button--invisible Button--small Button Button--invisible-noVisuals ml-0 ml-md-2"> <span class="Button-content"> <span class="Button-label">View reviewed changes</span> </span> </a> </div> </div> </div> <div data-view-component="true" class="TimelineItem pt-0"> <div data-view-component="true" class="TimelineItem-body"> <div id="pullrequestreview-2452074409" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment timeline-comment--caret timeline-comment--caret-nw timeline-comment ml-n3 unminimized-comment"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="pullrequestreview-2452074409-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has been invited to collaborate on the rippled repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Collaborator</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/13349202?s=48&v=4" alt="@vlntb" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block d-md-none mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb">vlntb</a> </strong> left a comment </div> </h3> </div> <a href="#pullrequestreview-2452074409" class="d-none"></a> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/XRPLF/rippled/pull/4927/reviews/2452074409/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="B5LEayL3T7DxG90qhskgbVc9WQ39vEm0KkFgkynEqKB7TEnHsuSQJ38jBOlLbQis4yiIn-iK10ieMMtTfsPYyg" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">I went through the last 20 synchronizations with develop to check that merges didn't produce any obvious errors. Looks good to me.</p> </div> </task-lists> </div> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-comment-update" data-type="json" data-turbo="false" action="/XRPLF/rippled/pull/4927/reviews/2452074409/update" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="-Vdy_0R0WQ7KwJ4i1TUzHjo5e0UGTQfbiBD9z8TbGwK0ienXTYlNJtJaAPmVGBPNs7CHuPvTMwZYpBwdR3zuHA" autocomplete="off" /> <include-fragment loading="lazy" src="/XRPLF/rippled/pull/4927/reviews/2452074409/update/edit_form?textarea_id=pullrequestreview-2452074409-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container has-reactions d-flex"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-pick-reaction" data-turbo="false" action="/XRPLF/rippled/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="uUz7aTM5ft4Y6hlAsTIfM9_wVw3c-9Ss8fBlu_pLeIpcCD7jyuGhIgX3vC48LehHrSbfRe29HhsnqrSA253vrQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="PRR_kwDOACmRR86SJ6-p"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-0f6dd3" value="HOORAY react" data-button-index-position="3" data-reaction-label="Hooray" data-reaction-content="tada" aria-pressed="false" aria-label="hooray (1): vlntb, 04:46PM on November 21" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline mr-2"> <g-emoji alias="tada" fallback-src="https://github.githubassets.com/assets/1f389-36899a2cb781.png" class="social-button-emoji">🎉</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-57d14607-f166-4c47-ac34-b7dfb1f121ee" for="reactions--reaction_button_component-0f6dd3" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute">ximinez reacted with hooray emoji</tool-tip> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="ximinez reacted with hooray emoji"> <g-emoji alias="tada" fallback-src="https://github.githubassets.com/assets/1f389-36899a2cb781.png" class="social-button-emoji mr-2">🎉</g-emoji> <span>1 reaction</span> </li> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> <div data-view-component="true" class="TimelineItem py-0 pl-4"> <div data-view-component="true" class="TimelineItem-body my-0"> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOAQcC_9oAKDNlM2U4YTNiNjY4ODAxOGQxNzYzOGQxZmYyNTAxYzlhMzU3Mjg5ZGY"> <div> <div > <div data-view-component="true" class="TimelineItem TimelineItem--condensed"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <div class="js-details-container Details js-socket-channel js-updatable-content"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/6757714?s=40&v=4" width="20" height="20" alt="@ximinez" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Merge remote-tracking branch 'upstream/develop' into hooks-merge * upstream/develop: (505 commits) fix: check for valid ammID field in amm_info RPC (5188) Set version to 2.3.0-rc2 fix: include `index` in `server_definitions` RPC (5190) Fix ledger_entry crash on invalid credentials request (5189) Set version to 2.3.0-rc1 Replace Uint192 with Hash192 in server_definitions response (5177) Fix potential deadlock (5124) Introduce Credentials support (XLS-70d): (5103) Fix token comparison in Payment (5172) Add fixAMMv1_2 amendment (5176) Fix unity build (5179) Add AMMClawback Transaction (XLS-0073d) (5142) Add hubs.xrpkuwait.com to bootstrap (5169) docs: Add protobuf dependencies to linux setup instructions (5156) fix: reject invalid markers in account_objects RPC calls (5046) Update RELEASENOTES.md (5154) Introduce MPT support (XLS-33d): (5143) Consolidate definitions of fields, objects, transactions, and features (5122) Ignore reformat when blaming Reformat code with clang-format-18 ..." data-pjax="true" class="Link--secondary markdown-title" href="/XRPLF/rippled/pull/4927/commits/3e3e8a3b6688018d17638d1ff2501c9a357289df">Merge remote-tracking branch 'upstream/develop' into hooks-merge</a> </code> <span class="hidden-text-expander inline"> <button aria-expanded="false" type="button" data-view-component="true" class="ellipsis-expander js-details-target btn"> … </button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="C_kwDOAQcC_9oAKDNlM2U4YTNiNjY4ODAxOGQxNzYzOGQxZmYyNTAxYzlhMzU3Mjg5ZGY" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="s" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <span class="Skeleton d-inline-block mr-1" style="width:75px; height:14px; margin-bottom:-4px;"></span> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> <div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNzI0MTY3OmNvbW1pdDozZTNlOGEzYjY2ODgwMThkMTc2MzhkMWZmMjUwMWM5YTM1NzI4OWRmIiwidCI6MTczMjQ2MjQ4OH0=--eac00ab6d038e9b2bc0220d5b66871808d4b310082451de704d19eed53b3921f" data-url="/XRPLF/rippled/pull/4927/partials/commit_status_icon?oid=3e3e8a3b6688018d17638d1ff2501c9a357289df"> <batch-deferred-content class="d-inline-block" data-url="/XRPLF/rippled/commits/checks-statuses-rollups"> <input type="hidden" name="oid" value="3e3e8a3b6688018d17638d1ff2501c9a357289df" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="disable_live_updates" value="false" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <div class="commit-build-statuses"> <span class="Skeleton d-inline-block" style="width:12px; height:12px;"></span> </div> </batch-deferred-content> </div> </div> <div class="text-right ml-1"> <code> <a href="/XRPLF/rippled/pull/4927/commits/3e3e8a3b6688018d17638d1ff2501c9a357289df" class="Link--secondary">3e3e8a3</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">* upstream/develop: (505 commits) fix: check for valid ammID field in amm_info RPC (5188) Set version to 2.3.0-rc2 fix: include `index` in `server_definitions` RPC (5190) Fix ledger_entry crash on invalid credentials request (5189) Set version to 2.3.0-rc1 Replace Uint192 with Hash192 in server_definitions response (5177) Fix potential deadlock (5124) Introduce Credentials support (XLS-70d): (5103) Fix token comparison in Payment (5172) Add fixAMMv1_2 amendment (5176) Fix unity build (5179) Add AMMClawback Transaction (XLS-0073d) (5142) Add hubs.xrpkuwait.com to bootstrap (5169) docs: Add protobuf dependencies to linux setup instructions (5156) fix: reject invalid markers in account_objects RPC calls (5046) Update RELEASENOTES.md (5154) Introduce MPT support (XLS-33d): (5143) Consolidate definitions of fields, objects, transactions, and features (5122) Ignore reformat when blaming Reformat code with clang-format-18 ...</pre> </div> </div> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="HRFPE_lADOACmRR86ALbIYzwAAAAOWTmz6"> <div id="event-15406623994" data-view-component="true" class="TimelineItem js-targetable-element"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/6757714?s=40&u=5db10ed49dfbf972f38215083bf6545c071d589b&v=4" width="20" height="20" alt="@ximinez" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez">ximinez</a> <a data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":1740180726,"repository_id":2724167,"event_id":15406623994,"originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="da6ff7e6241170d0bf15d5ce071d1677253fc33c18c0cb447f29a48373b63bd6" href="/XRPLF/rippled/compare/9efcc9f45ee70ab443624cd9a884e41ca20229f5..3e3e8a3b6688018d17638d1ff2501c9a357289df" data-view-component="true" class="Link--inTextBlock Link--secondary Link">force-pushed</a> the <span class="commit-ref user-select-contain"> <span > <span class=" css-truncate-target">hooks-merge</span> </span> </span> branch from <a href="/XRPLF/rippled/commit/9efcc9f45ee70ab443624cd9a884e41ca20229f5" data-view-component="true" class="Link--primary Link text-bold"> <code>9efcc9f</code> </a> to <a href="/XRPLF/rippled/commit/3e3e8a3b6688018d17638d1ff2501c9a357289df" data-view-component="true" class="Link--primary Link text-bold"> <code>3e3e8a3</code> </a> <a href="/XRPLF/rippled/compare/9efcc9f45ee70ab443624cd9a884e41ca20229f5..3e3e8a3b6688018d17638d1ff2501c9a357289df" data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":1740180726,"repository_id":2724167,"event_id":15406623994,"originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="da6ff7e6241170d0bf15d5ce071d1677253fc33c18c0cb447f29a48373b63bd6" data-view-component="true" class="Button--invisible Button--small Button Button--invisible-noVisuals float-right ml-2"> <span class="Button-content"> <span class="Button-label">Compare</span> </span> </a> <a href="#event-15406623994" data-view-component="true" class="css-truncate css-truncate-target Link--secondary Link"> <relative-time tense="past" datetime="2024-11-23T04:07:14Z" data-view-component="true">November 23, 2024 04:07</relative-time> </a> </div> </div> </div> <!-- Rendered timeline since 2024-11-22 20:07:14 --> <div id="partial-timeline" class="js-timeline-marker js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg4fQ==--9c959dceb6bd274a3acced693d7fe24918dd2f5474272d519f6eafa950ba067f" data-url="/XRPLF/rippled/pull/4927/partials/unread_timeline?since=2024-11-22T20%3A07%3A14.000000000-08%3A00" data-channel-event-name="timeline_updated" data-last-modified="2024-11-22T20:07:14.000000000-08:00" data-gid="PR_kwDOACmRR85nuQz2"> <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="d-none js-timeline-marker-form" data-turbo="false" action="/_graphql/MarkNotificationSubjectAsRead" accept-charset="UTF-8" data-remote="true" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="ZlH+ekhlONajWUgpoXBF7WJF0p/bp9ydrZPxJq47MLiQ4EPOdeloSWGpofxRY0FeLcRsYHPjD3mB29hI6jDA9w==" /> <input type="hidden" name="variables[subjectId]" value="PR_kwDOACmRR85nuQz2"> </form> </div> </div> <div class="discussion-timeline-actions"> <div id="issue-comment-box"> <div data-view-component="true" class="flash flash-warn mt-3"> <a rel="nofollow" class="btn btn-primary" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":2724167,"auth_type":"SIGN_UP","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="76f81e6aeffe30fecb5e943ff6b352a595f1132eda305176140aec4286f9b641" href="/join?source=comment-repo">Sign up for free</a> <strong>to join this conversation on GitHub</strong>. Already have an account? <a rel="nofollow" class="Link--inTextBlock" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":2724167,"auth_type":"LOG_IN","originating_url":"https://github.com/XRPLF/rippled/pull/4927","user_id":null}}" data-hydro-click-hmac="1acf20a4f33e0374050e238086f7b09a4ec6e3f6e73cdf0b885836385100d844" data-test-selector="comments-sign-in-link" href="/login?return_to=https%3A%2F%2Fgithub.com%2FXRPLF%2Frippled%2Fpull%2F4927">Sign in to comment</a> </div> </div> </div> </div> </div> <div data-view-component="true" class="Layout-sidebar"> <div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-channel-event-name="sidebar_updated" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=issues%2Fsidebar" data-project-hovercards-enabled> <div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item position-relative js-socket-channel js-updatable-content" data-team-hovercards-enabled data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=pull_requests%2Fsidebar%2Fshow%2Freviewers" data-channel-event-name="reviewers_updated" > <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-issue-sidebar-form" aria-label="Select reviewers" data-reviewers-team-size-check-url="/XRPLF/rippled/pull/4927/review-requests/team-size-check" data-turbo="false" action="/XRPLF/rippled/pull/4927/review-requests" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="PubZEL1EE8qxTFsTcScRrGkAsCfwa0rlniZQIHpjrXXDP82lsjo1fmVf5vF4+TXVUD4Ts/SfOHUi4VzBWwm16w==" /> <input type="hidden" name="partial_last_updated" id="partial_last_updated" value="1732462487" autocomplete="off" class="form-control" /> <div class="js-large-teams-check-warning-container"></div> <div class="discussion-sidebar-heading text-bold"> Reviewers </div> <span class="css-truncate"> <p class="d-flex"> <span class="d-flex min-width-0 flex-1 js-hovercard-left" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard?bot=copilot-pull-request-reviewer" data-assignee-name="vlntb"> <a class="no-underline" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb"> <img class="avatar mr-1 avatar-user" src="https://avatars.githubusercontent.com/u/13349202?s=40&v=4" width="20" height="20" alt="@vlntb" /> </a> <a class="assignee Link--primary css-truncate-target width-fit" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb"> <span class="css-truncate-target width-fit v-align-middle">vlntb</span> </a></span> <a id="review-status-vlntb" class="flex-order-1" href="/XRPLF/rippled/pull/4927/files/7b51c4d43b94292d1785f16efffb05a768ad9deb"> <span class="reviewers-status-icon text-center"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check color-fg-muted"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </span> </a> <tool-tip id="tooltip-f929f5d7-edae-415a-9cbc-3d32ce49a0ac" for="review-status-vlntb" popover="manual" data-direction="nw" data-type="label" data-view-component="true" class="sr-only position-absolute">vlntb approved these changes</tool-tip> </p> <p class="d-flex"> <span class="d-flex min-width-0 flex-1 js-hovercard-left" data-hovercard-type="user" data-hovercard-url="/users/RichardAH/hovercard?bot=copilot-pull-request-reviewer" data-assignee-name="RichardAH"> <a class="no-underline" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/RichardAH"> <img class="avatar mr-1 avatar-user" src="https://avatars.githubusercontent.com/u/19866478?s=40&v=4" width="20" height="20" alt="@RichardAH" /> </a> <a class="assignee Link--primary css-truncate-target width-fit" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/RichardAH"> <span class="css-truncate-target width-fit v-align-middle">RichardAH</span> </a></span> <button name="button" type="button" id="awaiting-review-RichardAH" class="btn-link flex-order-2"> <span class="reviewers-status-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-dot-fill hx_dot-fill-pending-icon"> <path d="M8 4a4 4 0 1 1 0 8 4 4 0 0 1 0-8Z"></path> </svg> </span> </button> <tool-tip id="tooltip-b5fc1c16-4831-46d9-b2d5-8b5bec79e913" for="awaiting-review-RichardAH" popover="manual" data-direction="nw" data-type="label" data-view-component="true" class="sr-only position-absolute">Awaiting requested review from RichardAH</tool-tip> </p> </span> </form></div> <div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=issues%2Fsidebar%2Fshow%2Fassignees" data-channel-event-name="assignees_updated" > <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-issue-sidebar-form" aria-label="Select assignees" data-turbo="false" action="/XRPLF/rippled/issues/4927/assignees" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="mnvXbaWD4eUmTIZ0LARp1Oqj3UfR1jqu2DfLSCzzCrrt3umiPamDsfkfengrDwcahWK7puDYyOm4nfrE57nijA==" /> <div class="discussion-sidebar-heading text-bold"> Assignees </div> <span class="css-truncate js-issue-assignees"> No one assigned </span> </form></div> <div class="discussion-sidebar-item js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=issues%2Fsidebar%2Fshow%2Flabels" data-channel-event-name="labels_updated" > <div class="discussion-sidebar-heading text-bold"> Labels </div> <div class="js-issue-labels d-flex flex-wrap"> None yet </div> </div> <div class="discussion-sidebar-item js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=issues%2Fsidebar%2Fshow%2Fprojects" data-channel-event-name="projects_updated" > <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-issue-sidebar-form" aria-label="Select projects" data-turbo="false" action="/XRPLF/rippled/projects/issues/4927" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="jSdfw4EyY3quU7MtXdJVo5NHfnY5O61f5ZNK3NhiLQoBXDMCzIIHRAeJkBGMH7Mwr/qxdaJSKpQPPaL4zLUqrA==" /> <div class="discussion-sidebar-heading text-bold"> Projects </div> <div aria-live="polite"> </div> <span class="css-truncate sidebar-progress-bar"> None yet </span> </form> </div> <div class="discussion-sidebar-item sidebar-progress-bar js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE3NDAxODA3MjYiLCJ0IjoxNzMyNDYyNDg3fQ==--238fc0f0e3d5c761da16b591dd7218ca1c5cb0ac98083be875a3fe2fe541828e" data-gid="PR_kwDOACmRR85nuQz2" data-url="/XRPLF/rippled/issues/4927/show_partial?partial=issues%2Fsidebar%2Fshow%2Fmilestone" data-channel-event-name="milestone_updated" > <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-issue-sidebar-form" aria-label="Select milestones" data-turbo="false" action="/XRPLF/rippled/issues/4927/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="70rwPBfYfZG+QQ8gfqv0VjyzacLDpyI8R7oR+UTKePREFqpY4DVxrTmD2CFN+YR9UhpyXo4FowCKeJc0WSJHdw==" /> <div class="discussion-sidebar-heading text-bold"> Milestone </div> No milestone </form></div> <create-branch data-default-repo="XRPLF/rippled" data-selected-nwo="XRPLF/rippled" data-default-source-branch="develop" data-sidebar-url="/XRPLF/rippled/issues/closing_references/partials/sidebar?source_id=2150478360&source_type=ISSUE" class="discussion-sidebar-item d-block"> <div class="js-discussion-sidebar-item" data-target="create-branch.sidebarContainer"> <div data-issue-and-pr-hovercards-enabled > <development-menu> <!-- '"` --><!-- </textarea></xmp> --></option></form><form data-target="create-branch.developmentForm" data-turbo="false" class="js-issue-sidebar-form" aria-label="Link issues" action="/XRPLF/rippled/issues/closing_references?source_id=1740180726&source_type=PULL_REQUEST" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="gMVGqBV0ZIUqoSD+xDiBCrpDTtot/glPos1WafGMVngCySNMI+wZVVXkW8Qb8u4kI7XdXcY1qV1dg+Azsv/csA==" /> <div class="discussion-sidebar-heading text-bold"> Development </div> <p>Successfully merging this pull request may close these issues.</p> <include-fragment src="/XRPLF/rippled/pull/4927/partials/links?has_github_issues=false"></include-fragment> </form> </development-menu> </div> </div> </create-branch> <div id="partial-users-participants" class="discussion-sidebar-item"> <div class="participation"> <div class="discussion-sidebar-heading text-bold"> 38 participants </div> <div class="participation-avatars d-flex flex-wrap"> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/ximinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ximinez"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/6757714?s=52&v=4" width="26" height="26" alt="@ximinez" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/vlntb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vlntb"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/13349202?s=52&v=4" width="26" height="26" alt="@vlntb" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/WhiteHuskys/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/WhiteHuskys"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/100718307?s=52&v=4" width="26" height="26" alt="@WhiteHuskys" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/StefanVK/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/StefanVK"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/22466524?s=52&v=4" width="26" height="26" alt="@StefanVK" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/intelliot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/intelliot"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/81505?s=52&v=4" width="26" height="26" alt="@intelliot" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/sokkaofthewatertribe/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sokkaofthewatertribe"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/140777955?s=52&v=4" width="26" height="26" alt="@sokkaofthewatertribe" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/mDuo13/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mDuo13"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/7515597?s=52&v=4" width="26" height="26" alt="@mDuo13" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/seelabs/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/seelabs"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/5853458?s=52&v=4" width="26" height="26" alt="@seelabs" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/dangell7/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dangell7"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/25502424?s=52&v=4" width="26" height="26" alt="@dangell7" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/florent-uzio/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/florent-uzio"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/36513774?s=52&v=4" width="26" height="26" alt="@florent-uzio" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/ckeshava/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ckeshava"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/21219765?s=52&v=4" width="26" height="26" alt="@ckeshava" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/JST5000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/JST5000"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/19694186?s=52&v=4" width="26" height="26" alt="@JST5000" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/scottschurr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/scottschurr"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/7840379?s=52&v=4" width="26" height="26" alt="@scottschurr" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/mvadari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvadari"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/8029314?s=52&v=4" width="26" height="26" alt="@mvadari" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/shichengsg002/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/shichengsg002"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/147461171?s=52&v=4" width="26" height="26" alt="@shichengsg002" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/Bronek/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Bronek"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/823856?s=52&v=4" width="26" height="26" alt="@Bronek" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/mtrippled/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mtrippled"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/7728157?s=52&v=4" width="26" height="26" alt="@mtrippled" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/gregtatcam/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/gregtatcam"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/3341098?s=52&v=4" width="26" height="26" alt="@gregtatcam" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/pwang200/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/pwang200"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/354723?s=52&v=4" width="26" height="26" alt="@pwang200" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/manojsdoshi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/manojsdoshi"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/4910181?s=52&v=4" width="26" height="26" alt="@manojsdoshi" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/legleux/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/legleux"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/455257?s=52&v=4" width="26" height="26" alt="@legleux" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/sophiax851/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sophiax851"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/106177003?s=52&v=4" width="26" height="26" alt="@sophiax851" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/hoos/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/hoos"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/93653?s=52&v=4" width="26" height="26" alt="@hoos" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/thejohnfreeman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thejohnfreeman"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1133852?s=52&v=4" width="26" height="26" alt="@thejohnfreeman" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/shawnxie999/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/shawnxie999"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/35279399?s=52&v=4" width="26" height="26" alt="@shawnxie999" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/oleks-rip/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/oleks-rip"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/115580134?s=52&v=4" width="26" height="26" alt="@oleks-rip" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/alloynetworks/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/alloynetworks"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/45832257?s=52&v=4" width="26" height="26" alt="@alloynetworks" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/xiaoxianBoy/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/xiaoxianBoy"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/22361503?s=52&v=4" width="26" height="26" alt="@xiaoxianBoy" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/nbougalis/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/nbougalis"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/5085415?s=52&v=4" width="26" height="26" alt="@nbougalis" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/godexsoft/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/godexsoft"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/385326?s=52&v=4" width="26" height="26" alt="@godexsoft" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/todaymoon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/todaymoon"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/170532330?s=52&v=4" width="26" height="26" alt="@todaymoon" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/tequdev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/tequdev"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/69445828?s=52&v=4" width="26" height="26" alt="@tequdev" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/yinyiqian1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/yinyiqian1"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/171949508?s=52&v=4" width="26" height="26" alt="@yinyiqian1" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/dashangcun/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dashangcun"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/171347066?s=52&v=4" width="26" height="26" alt="@dashangcun" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/jscottbranson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/jscottbranson"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/18340247?s=52&v=4" width="26" height="26" alt="@jscottbranson" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/luozexuan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/luozexuan"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/169808909?s=52&v=4" width="26" height="26" alt="@luozexuan" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/vvysokikh1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/vvysokikh1"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/129996061?s=52&v=4" width="26" height="26" alt="@vvysokikh1" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/BobConanDev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/BobConanDev"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/183866110?s=52&v=4" width="26" height="26" alt="@BobConanDev" /> </a> </div> </div> </div> </div> </div> </div> </div> </div> <div hidden> <span class="js-add-to-batch-enabled">Add this suggestion to a batch that can be applied as a single commit.</span> <span class="js-unchanged-suggestion">This suggestion is invalid because no changes were made to the code.</span> <span class="js-closed-pull">Suggestions cannot be applied while the pull request is closed.</span> <span class="js-viewing-subset-changes">Suggestions cannot be applied while viewing a subset of changes.</span> <span class="js-one-suggestion-per-line">Only one suggestion per line can be applied in a batch.</span> <span class="js-reenable-add-to-batch">Add this suggestion to a batch that can be applied as a single commit.</span> <span class="js-validation-on-left-blob">Applying suggestions on deleted lines is not supported.</span> <span class="js-validation-on-right-blob">You must change the existing code in this line in order to create a valid suggestion.</span> <span class="js-outdated-comment">Outdated suggestions cannot be applied.</span> <span class="js-resolved-thread">This suggestion has been applied or marked resolved.</span> <span class="js-pending-review">Suggestions cannot be applied from pending reviews.</span> <span class="js-is-multiline">Suggestions cannot be applied on multi-line comments.</span> <span class="js-in-merge-queue">Suggestions cannot be applied while the pull request is queued to merge.</span> <span class="js-head-oid-not-loaded">Suggestion cannot be applied right now. Please check back later.</span> <div class="form-group errored m-0 error js-suggested-changes-inline-validation-template d-flex" style="cursor: default;"> <span class="js-suggested-changes-inline-error-message position-relative error m-0" style="max-width: inherit;"></span> </div> </div> </div> </div> </turbo-frame> </main> </div> </div> <footer class="footer pt-8 pb-6 f6 color-fg-muted p-responsive" role="contentinfo" > <h2 class='sr-only'>Footer</h2> <div class="d-flex flex-justify-center flex-items-center flex-column-reverse flex-lg-row flex-wrap flex-lg-nowrap"> <div class="d-flex flex-items-center flex-shrink-0 mx-2"> <a aria-label="Homepage" title="GitHub" class="footer-octicon mr-2" href="https://github.com"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <span> © 2024 GitHub, Inc. </span> </div> <nav aria-label="Footer"> <h3 class="sr-only" id="sr-footer-heading">Footer navigation</h3> <ul class="list-style-none d-flex flex-justify-center flex-wrap mb-2 mb-lg-0" aria-labelledby="sr-footer-heading"> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to Terms","label":"text:terms"}" href="https://docs.github.com/site-policy/github-terms/github-terms-of-service" data-view-component="true" class="Link--secondary Link">Terms</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to privacy","label":"text:privacy"}" href="https://docs.github.com/site-policy/privacy-policies/github-privacy-statement" data-view-component="true" class="Link--secondary Link">Privacy</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to security","label":"text:security"}" href="https://github.com/security" data-view-component="true" class="Link--secondary Link">Security</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to status","label":"text:status"}" href="https://www.githubstatus.com/" data-view-component="true" class="Link--secondary Link">Status</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to docs","label":"text:docs"}" href="https://docs.github.com/" data-view-component="true" class="Link--secondary Link">Docs</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to contact","label":"text:contact"}" href="https://support.github.com?tags=dotcom-footer" data-view-component="true" class="Link--secondary Link">Contact</a> </li> <li class="mx-2" > <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"cookies","context":"subfooter","tag":"link","label":"cookies_link_subfooter_footer"}" > Manage cookies </button> </cookie-consent-link> </li> <li class="mx-2"> <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"dont_share_info","context":"subfooter","tag":"link","label":"dont_share_info_link_subfooter_footer"}" > Do not share my personal information </button> </cookie-consent-link> </li> </ul> </nav> </div> </footer> <ghcc-consent id="ghcc" class="position-fixed bottom-0 left-0" style="z-index: 999999" data-initial-cookie-consent-allowed="" data-cookie-consent-required="false"></ghcc-consent> <div id="ajax-error-message" class="ajax-error-message flash flash-error" hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <button type="button" class="flash-close js-ajax-error-dismiss" aria-label="Dismiss error"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> You can’t perform that action at this time. </div> <template id="site-details-dialog"> <details class="details-reset details-overlay details-overlay-dark lh-default color-fg-default hx_rsm" open> <summary role="button" aria-label="Close dialog"></summary> <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast hx_rsm-dialog hx_rsm-modal"> <button class="Box-btn-octicon m-0 btn-octicon position-absolute right-0 top-0" type="button" aria-label="Close dialog" data-close-dialog> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div class="octocat-spinner my-6 js-details-dialog-spinner"></div> </details-dialog> </details> </template> <div class="Popover js-hovercard-content position-absolute" style="display: none; outline: none;"> <div class="Popover-message Popover-message--bottom-left Popover-message--large Box color-shadow-large" style="width:360px;"> </div> </div> <template id="snippet-clipboard-copy-button"> <div class="zeroclipboard-container position-absolute right-0 top-0"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn js-clipboard-copy m-2 p-0" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon m-2"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none m-2"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> <template id="snippet-clipboard-copy-button-unpositioned"> <div class="zeroclipboard-container"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn btn-invisible js-clipboard-copy m-2 p-0 d-flex flex-justify-center flex-items-center" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> </div> <div id="js-global-screen-reader-notice" class="sr-only mt-n1" aria-live="polite" aria-atomic="true" ></div> <div id="js-global-screen-reader-notice-assertive" class="sr-only mt-n1" aria-live="assertive" aria-atomic="true"></div> </body> </html>