#16053 (Back to Authors and Users link redirects to the wrong screen)

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><script type="text/javascript" src="https://web-static.archive.org/_static/js/bundle-playback.js?v=7YQSqjSh" charset="utf-8"></script> <script type="text/javascript" src="https://web-static.archive.org/_static/js/wombat.js?v=txqj7nKC" charset="utf-8"></script> <script>window.RufflePlayer=window.RufflePlayer||{};window.RufflePlayer.config={"autoplay":"on","unmuteOverlay":"hidden"};</script> <script type="text/javascript" src="https://web-static.archive.org/_static/js/ruffle/ruffle.js"></script> <script type="text/javascript"> __wm.init("https://web.archive.org/web"); __wm.wombat("http://core.trac.wordpress.org:80/ticket/16053","20110104091219","https://web.archive.org/","web","https://web-static.archive.org/_static/", "1294132339"); </script> <link rel="stylesheet" type="text/css" href="https://web-static.archive.org/_static/css/banner-styles.css?v=p7PEIJWi" /> <link rel="stylesheet" type="text/css" href="https://web-static.archive.org/_static/css/iconochive.css?v=3PDvdIFv" />  <title> #16053 (Back to Authors and Users link redirects to the wrong screen) – WordPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> <link rel="search" href="/web/20110104091219/http://core.trac.wordpress.org/search"/> <link rel="prev" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16052" title="Ticket #16052"/> <link rel="last" href="/ticket/16093" title="Ticket #16093"/> <link rel="help" href="/wiki/TracGuide"/> <link rel="alternate" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=csv" type="text/csv" class="csv" title="Comma-delimited Text"/><link rel="alternate" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text"/><link rel="alternate" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=rss" type="application/rss+xml" class="rss" title="RSS Feed"/> <link rel="next" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16054" title="Ticket #16054"/> <link rel="start" href="/wiki"/> <link rel="stylesheet" href="/web/20110104091219cs_/http://core.trac.wordpress.org/chrome/common/css/trac.css" type="text/css"/><link rel="stylesheet" href="/web/20110104091219cs_/http://core.trac.wordpress.org/chrome/common/css/ticket.css" type="text/css"/> <link rel="first" href="/ticket/1" title="Ticket #1"/> <link rel="shortcut icon" href="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link rel="icon" href="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link type="application/opensearchdescription+xml" rel="search" href="/web/20110104091219/http://core.trac.wordpress.org/search/opensearch" title="Search WordPress Trac"/> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="03d36f6caa5399343317c90f"; </script> <script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/jquery.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/babel.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/trac.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/search.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/folding.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/wikitoolbar.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/resizer.js"></script><script type="text/javascript" src="/web/20110104091219js_/http://core.trac.wordpress.org/chrome/common/js/auto_preview.js"></script>  <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); var args = {realm: "ticket", id: 16053, escape_newlines: 0} $("#comment").autoPreview("/wiki_render", args, function(textarea, text, rendered) { $("#ticketchange div.comment").html(rendered); if (rendered) $("#ticketchange").show(); else if ($("#ticketchange ul.changes").length == 0) $("#ticketchange").hide(); }); $("#trac-comment-editor textarea").autoPreview("/wiki_render", args, function(textarea, text, rendered) { var comment = $("#trac-comment-editor").next("div.comment"); comment.html(rendered); if (rendered) comment.show(); else comment.hide(); }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); /* only enable control elements for the currently selected action */ var actions = $("#action input[name='action']"); function updateActionFields() { actions.each(function () { $(this).siblings().find("*[id]").enable($(this).checked()); $(this).siblings().filter("*[id]").enable($(this).checked()); }); } actions.click(updateActionFields); updateActionFields(); }); </script> </head> <body> <div id="banner"> <div id="header"> <a id="logo" href="/web/20110104091219/http://core.trac.wordpress.org/"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/site/trac-logo.png" alt="WordPress Trac" height="80" width="474"/></a> </div> <form id="search" action="/web/20110104091219/http://core.trac.wordpress.org/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value=""/> <input type="submit" value="Search"/> </div> </form> <div id="metanav" class="nav"> <ul> <li class="first"><a href="/web/20110104091219/http://core.trac.wordpress.org/login">Login</a></li><li><a href="/web/20110104091219/http://core.trac.wordpress.org/prefs">Preferences</a></li><li><a href="/web/20110104091219/http://core.trac.wordpress.org/wiki/TracGuide">Help/Guide</a></li><li class="last"><a href="/web/20110104091219/http://core.trac.wordpress.org/about">About Trac</a></li> </ul> </div> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/web/20110104091219/http://core.trac.wordpress.org/wiki">Wiki</a></li><li><a href="/web/20110104091219/http://core.trac.wordpress.org/timeline">Timeline</a></li><li><a href="/web/20110104091219/http://core.trac.wordpress.org/roadmap">Roadmap</a></li><li><a href="/web/20110104091219/http://core.trac.wordpress.org/browser">Browse Source</a></li><li class="active"><a href="/web/20110104091219/http://core.trac.wordpress.org/report">View Tickets</a></li><li class="last"><a href="/web/20110104091219/http://core.trac.wordpress.org/search">Search</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16052" title="Ticket #16052">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16054" title="Ticket #16054">Next Ticket</a> →</span></li> </ul> <hr/> </div> <div id="content" class="ticket"> <h1 id="trac-ticket-title"> <a href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053">Ticket #16053</a> <span class="status">(closed defect (bug): fixed)</span> </h1> <div id="ticket"> <div class="date"> <p>Opened <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T19%3A55%3A38Z&precision=second" title="2010-12-31T19:55:38Z in Timeline">4 days</a> ago</p> <p>Last modified <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T22%3A30%3A49Z&precision=second" title="2011-01-01T22:30:49Z in Timeline">2 days</a> ago</p> </div> <h2 class="summary searchable">Back to Authors and Users link redirects to the wrong screen</h2> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&reporter=PeteMall">PeteMall</a> </td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> </td> </tr> <tr> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&priority=normal">normal</a> </td> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="milestone" href="/web/20110104091219/http://core.trac.wordpress.org/milestone/3.1">3.1</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&component=Network+Admin">Network Admin</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&version=3.1">3.1</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&severity=normal">normal</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&keywords=%7Ehas-patch">has-patch</a> <a href="/web/20110104091219/http://core.trac.wordpress.org/query?status=%21closed&keywords=%7Ecommit">commit</a> </td> </tr><tr> <th id="h_cc"> Cc: </th> <td headers="h_cc" class="searchable"> </td> <th> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p> When you edit a user from network admin site-users screen, the "← Back to Authors and Users" link redirects the user to the network/users.php instead of network/site-users.php?id=x </p> </div> </div> </div> <div id="attachments"> <h2 class="foldable">Attachments</h2> <div> <dl class="attachments"> <dt> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.diff" title="View attachment">16053.diff</a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.diff" class="trac-rawlink" title="Download"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> (<span title="1666 bytes">1.6 KB</span>) - added by <em>PeteMall</em> <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T21%3A08%3A56Z&precision=second" title="2010-12-31T21:08:56Z in Timeline">4 days</a> ago. </dt> <dt> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.2.diff" title="View attachment">16053.2.diff</a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.2.diff" class="trac-rawlink" title="Download"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> (<span title="1666 bytes">1.6 KB</span>) - added by <em>PeteMall</em> <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T21%3A12%3A59Z&precision=second" title="2010-12-31T21:12:59Z in Timeline">3 days</a> ago. </dt> <dt> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.3.diff" title="View attachment">16053.3.diff</a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.3.diff" class="trac-rawlink" title="Download"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> (<span title="2522 bytes">2.5 KB</span>) - added by <em>SergeyBiryukov</em> <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T12%3A20%3A44Z&precision=second" title="2011-01-01T12:20:44Z in Timeline">3 days</a> ago. </dt> <dt> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.4.diff" title="View attachment">16053.4.diff</a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.4.diff" class="trac-rawlink" title="Download"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> (<span title="2963 bytes">2.9 KB</span>) - added by <em>nacin</em> <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T22%3A25%3A27Z&precision=second" title="2011-01-01T22:25:27Z in Timeline">2 days</a> ago. </dt> </dl> </div> </div> <div> <h2 class="foldable">Change History</h2> <div id="changelog"> <div class="change" id="trac-change-1"> <h3 class="change"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">comment:1</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T20%3A21%3A42Z&precision=second" title="2010-12-31T20:21:42Z in Timeline">4 days</a> ago by SergeyBiryukov </h3> <div class="comment searchable"> <p> Also, after editing a user on <tt>network/users.php</tt> the referer is empty: </p> <pre class="wiki">/wp-admin/network/user-edit.php?user_id=4&updated=true&wp_http_referer </pre> </div> </div> <div class="change"> <h3 class="change"> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T21%3A08%3A56Z&precision=second" title="2010-12-31T21:08:56Z in Timeline">4 days</a> ago by PeteMall </h3> <ul class="changes"> <li> <strong>attachment</strong> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.diff"><em>16053.diff</em></a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.diff" title="Download" class="trac-rawlink"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change"> <h3 class="change"> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2010-12-31T21%3A12%3A59Z&precision=second" title="2010-12-31T21:12:59Z in Timeline">3 days</a> ago by PeteMall </h3> <ul class="changes"> <li> <strong>attachment</strong> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.2.diff"><em>16053.2.diff</em></a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.2.diff" title="Download" class="trac-rawlink"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-2"> <h3 class="change"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">comment:2</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T05%3A12%3A04Z&precision=second" title="2011-01-01T05:12:04Z in Timeline">3 days</a> ago by garyc40 </h3> <ul class="changes"> <li> <strong>Keywords</strong> <em>has-patch</em> <em>needs-testing</em> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change"> <h3 class="change"> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T12%3A20%3A44Z&precision=second" title="2011-01-01T12:20:44Z in Timeline">3 days</a> ago by SergeyBiryukov </h3> <ul class="changes"> <li> <strong>attachment</strong> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.3.diff"><em>16053.3.diff</em></a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.3.diff" title="Download" class="trac-rawlink"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-3"> <h3 class="change"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">comment:3</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T12%3A20%3A59Z&precision=second" title="2011-01-01T12:20:59Z in Timeline">3 days</a> ago by SergeyBiryukov </h3> <div class="comment searchable"> <p> Fixed empty referer. </p> </div> </div> <div class="change" id="trac-change-4"> <h3 class="change"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">comment:4</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T21%3A49%3A44Z&precision=second" title="2011-01-01T21:49:44Z in Timeline">2 days</a> ago by nacin </h3> <div class="comment searchable"> <p> Looks good. </p> </div> </div> <div class="change"> <h3 class="change"> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T22%3A25%3A27Z&precision=second" title="2011-01-01T22:25:27Z in Timeline">2 days</a> ago by nacin </h3> <ul class="changes"> <li> <strong>attachment</strong> <a href="/web/20110104091219/http://core.trac.wordpress.org/attachment/ticket/16053/16053.4.diff"><em>16053.4.diff</em></a> <a href="/web/20110104091219/http://core.trac.wordpress.org/raw-attachment/ticket/16053/16053.4.diff" title="Download" class="trac-rawlink"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/download.png" alt="Download"/></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-5"> <h3 class="change"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">comment:5</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T22%3A27%3A36Z&precision=second" title="2011-01-01T22:27:36Z in Timeline">2 days</a> ago by nacin </h3> <ul class="changes"> <li> <strong>Keywords</strong> <em>commit</em> added; <em>needs-testing</em> removed </li> </ul> <div class="comment searchable"> <p> Final patch works for me. Modified the URL generation a bit -- network_admin_url() and full esc_url() -- and in user-edit, we're now only adding the wp_http_referer argument if there is one, preventing a URL that looks like: </p> <pre class="wiki">user-edit.php?user_id=2&updated=true&wp_http_referer </pre><p> Tested every way possible. Offering commit. </p> </div> </div> <div class="change" id="trac-change-6"> <h3 class="change"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">comment:6</a> </span> </span> Changed <a class="timeline" href="/web/20110104091219/http://core.trac.wordpress.org/timeline?from=2011-01-01T22%3A30%3A49Z&precision=second" title="2011-01-01T22:30:49Z in Timeline">2 days</a> ago by nacin </h3> <ul class="changes"> <li> <strong>Status</strong> changed from <em>new</em> to <em>closed</em> </li><li> <strong>Resolution</strong> set to <em>fixed</em> </li> </ul> <div class="comment searchable"> <p> (In <a class="changeset" href="/web/20110104091219/http://core.trac.wordpress.org/changeset/17201" title="Allow us to return from whence we came. Specify wp_http_referer for ...">[17201]</a>) Allow us to return from whence we came. Specify wp_http_referer for user-edit in the network admin, as we may come from network/users or site-users. props PeteMall, SergeyBiryukov, fixes <a class="closed ticket" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053" title="defect (bug): Back to Authors and Users link redirects to the wrong screen (closed: fixed)">#16053</a>. </p> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/web/20110104091219/http://core.trac.wordpress.org/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/web/20110104091219/http://core.trac.wordpress.org/ticket/16053?format=rss" class="rss">RSS Feed</a> </li> </ul> </div> </div> <div id="footer" lang="en" xml:lang="en"><hr/> <a id="tracpowered" href="https://web.archive.org/web/20110104091219/http://trac.edgewall.org/"><img src="/web/20110104091219im_/http://core.trac.wordpress.org/chrome/common/trac_logo_mini.png" height="30" width="107" alt="Trac Powered"/></a> <p class="left">Powered by <a href="/web/20110104091219/http://core.trac.wordpress.org/about"><strong>Trac 0.12.1</strong></a><br/> By <a href="https://web.archive.org/web/20110104091219/http://www.edgewall.org/">Edgewall Software</a>.</p> <p class="right">A <a href="https://web.archive.org/web/20110104091219/http://wordpress.org/">WordPress</a> Project</p> </div> </body> </html>

CINXE.COM

#16053 (Back to Authors and Users link redirects to the wrong screen) – WordPress Trac