LKML: David Brownell: Re: [PATCH] USB: usbnet uses netif_msg

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: David Brownell: Re: [PATCH] USB: usbnet uses netif_msg_*() ethtool filtering</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by David Brownell" href="/groupie.php?aid=1336" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/3"> [Mar]</a> 聽 <a class="nb" href="/lkml/2005/3/30"> [30]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/3/30/286" onclick="this.href='/lkml/headers'+'/2005/3/30/286';">[headers]</a>聽 <a href="/lkml/bounce/2005/3/30/286">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/3/30/280">First message in thread</a></li><li><a href="/lkml/2005/3/30/280">Jeff Garzik</a><ul><li class="origin"><a href="/lkml/2005/3/30/290">David Brownell</a><ul><li><a href="/lkml/2005/3/30/290">Jeff Garzik</a><ul><li><a href="/lkml/2005/3/30/307">David Brownell</a></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">From</td><td class="rp" itemprop="author">David Brownell <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH] USB: usbnet uses netif_msg_*() ethtool filtering</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 30 Mar 2005 16:50:17 -0800</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Wednesday 30 March 2005 4:30 pm, Jeff Garzik wrote:<br />> Linux Kernel Mailing List wrote:<br />> > ChangeSet 1.2181.4.72, 2005/03/24 15:31:29-08:00, david-b@pacbell.net<br />> > <br />> > [PATCH] USB: usbnet uses netif_msg_*() ethtool filtering<br />> > <br />> > This converts most of the usbnet code to actually use the ethtool<br />> > message flags. The ASIX code is left untouched, since there are<br />> > a bunch of patches pending there ... that's where the remaining<br />> > handful of "sparse -Wbitwise" warnings come from.<br />> > <br />> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net><br />> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de><br />> <br />> It would be nice if people at least CC'd me on net driver patches.<br /><br />Sorry. When drivers fit multiple classifications (e.g. USB _and_ NET,<br />or USB _and_ PCI _and_ PM, etc) it's unfortunately routine that not all<br />interested parties see them until something hits LKML. Even when the<br />changes have significant cross-subsystem impact (these don't).<br /><br /><br />> netfi_msg_ifdown() is only for __interface__ up/down events; as such, <br />> there should be only one message of this type in dev->open(), and one <br />> message of this type in dev->stop().<br /><br />I was going by the only writeup I've ever seen, which doesn't mention<br />such a rule at all. The messages you highlighted are compatible with<br />these rules: the interface is actually going down at that point.<br /><br /> <a href="http://www.tux.org/hypermail/linux-vortex/2001-Nov/0021.html">http://www.tux.org/hypermail/linux-vortex/2001-Nov/0021.html</a><br /><br />If there are other rules, they belong in Documentation/netif-msg.txt<br />don't they? That way folk won't be forced to guess. Or risk<br />accidentally following the "wrong" set of rules...<br /><br /><br />> > @@ -3044,7 +3047,7 @@<br />> > <br />> > memset(urb->transfer_buffer, 0, urb->transfer_buffer_length);<br />> > status = usb_submit_urb (urb, GFP_ATOMIC);<br />> > - if (status != 0)<br />> > + if (status != 0 && netif_msg_timer (dev))<br />> > deverr(dev, "intr resubmit --> %d", status);<br />> > }<br />> > <br />> <br />> this looks more like a debugging message?<br /><br />It's an error of the "what do I do now??" variety, triggered by<br />what's effectively a timer callback. USB interrupt transfers<br />are polled by the host controller according to a schedule that's<br />maintained by the HCD.<br /><br />- Dave<br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-06 13:31 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: David Brownell: Re: [PATCH] USB: usbnet uses netif_msg_*() ethtool filtering