CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Brad Boyer: Re: [PATCH 33/36] m68k: drivers/scsi/mac53c94.c __iomem annotations</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Brad Boyer" href="/groupie.php?aid=2705" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/24"> [24]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/24/72" onclick="this.href='/lkml/headers'+'/2005/12/24/72';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/24/72">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/21/346">First message in thread</a></li><li><a href="/lkml/2005/12/24/68">Brad Boyer</a><ul><li><a href="/lkml/2005/12/24/71">Al Viro</a><ul><li class="origin"><a href="">Brad Boyer</a></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Sat, 24 Dec 2005 14:44:12 -0800</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Brad Boyer <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 33/36] m68k: drivers/scsi/mac53c94.c __iomem annotations</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Sat, Dec 24, 2005 at 10:32:30PM +0000, Al Viro wrote:<br />> Speaking of mac_esp, there's a pending patch for NCR53C9x.c fixing PIO<br />> breakage in esp_do_data().<br />> /* read fifo */<br />> for(j=0;j<fifocnt;j++)<br />> SCptr->SCp.ptr[i++] = esp_read(eregs->esp_fdata);<br />> <br />> is not a good thing to do when we set .ptr to (char *)virt_to_phys_(....).<br />> <br />> It works mostly by accident on e.g. 840AV, until you get a minimally<br />> non-trivial memory mapping. The same thing happens on the write side.<br />> Fix is obvious (find phys_to_virt(SCptr->SCp.ptr) in the PIO branch<br />> and use it). I've put that in -bird, will show up in tonight's snapshot...<br /><br />It's only partly by accident. Early on in the development, someone put in<br />a fixed mapping with physical == virtual for the I/O space. Lots of the<br />drivers for internal devices on m68k macs take advantage of this and<br />use the physical addresses as pointers. They should be fixed, I guess.<br /><br />> BTW, what's the situation with DMA on 840AV? If you have any patches<br />> to test, I've got such box and being what it is, it's not tied by any<br />> work...<br /><br />No, I haven't done much of anything with it. I do have a Q840AV, but the<br />DMA engine I really wanted to get working was the one on the IIfx. The<br />disk performance of the mac_scsi driver makes the IIfx nearly useless.<br />I almost got it working, but I can't figure out how to get the interrupts<br />for the DMA completion to work properly. The DMA for the AV models is<br />several steps down on my list at the moment. There are a couple other<br />people that have looked at it, but noone is especially active.<br /><br /> Brad Boyer<br /> flar@allandria.com<br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-24 23:46 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>