CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Ingo Molnar: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Ingo Molnar" href="/groupie.php?aid=18" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/13"> [13]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/13/83" onclick="this.href='/lkml/headers'+'/2005/12/13/83';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/13/83">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/12/244">First message in thread</a></li><li><a href="/lkml/2005/12/13/30">Ingo Molnar</a><ul><li><a href="/lkml/2005/12/13/32">Andi Kleen</a><ul><li><a href="/lkml/2005/12/13/74">Andrew Morton</a><ul><li><a href="/lkml/2005/12/13/76">Andi Kleen</a><ul><li><a href="/lkml/2005/12/13/79">Andrew Morton</a></li><li><a href="/lkml/2005/12/13/82">Christoph Hellwig</a></li><li><a href="/lkml/2005/12/13/88">Ingo Molnar</a></li><li><a href="/lkml/2005/12/13/223">Linus Torvalds</a></li></ul></li><li><a href="/lkml/2005/12/13/81">Christoph Hellwig</a><ul><li><a href="/lkml/2005/12/13/93">Andrew Morton</a></li></ul></li></ul></li></ul></li><li><a href="/lkml/2005/12/13/33">Arjan van de Ven</a><ul><li class="origin"><a href="/lkml/2005/12/13/87">Ingo Molnar</a><ul><li><a href="/lkml/2005/12/13/87">Andi Kleen</a><ul><li><a href="/lkml/2005/12/13/100">Ingo Molnar</a></li><li><a href="/lkml/2005/12/13/101">Ingo Molnar</a></li></ul></li><li><a href="/lkml/2005/12/13/95">Arjan van de Ven</a></li></ul></li></ul></li><li><a href="/lkml/2005/12/13/78">Christoph Hellwig</a><ul><li><a href="/lkml/2005/12/13/102">Ingo Molnar</a><ul><li><a href="/lkml/2005/12/13/109">Ingo Molnar</a><ul><li><a href="/lkml/2005/12/13/250">Paul Jackson</a></li></ul></li></ul></li></ul></li><li><a href="/lkml/2005/12/13/108">Ingo Molnar</a></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Tue, 13 Dec 2005 10:03:49 +0100</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Ingo Molnar <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody"><br />* Arjan van de Ven <arjan@infradead.org> wrote:<br /><br />> > even better than that, why not use the solution that we've implemented <br />> > for the -rt patchset, more than a year ago?<br />> > <br />> > the solution i took was this:<br />> > <br />> > - i did not touch the 'struct semaphore' namespace, but introduced a<br />> > 'struct compat_semaphore'.<br />> <br />> which I think is wrong. THis naming sucks. Sure doing a full sed on <br />> the tree is not pretty but it's also not THAT painful. And the pain of <br />> wrong names is something the kernel needs to carry around for years.<br /><br />well, i'm all for renaming struct semaphore to struct mutex, but dont <br />the same arguments apply as to 'struct timer_list'?<br /><br />just to see the scope, i've attached semaphore-to-mutex.patch, which <br />just dumbly converts all 'struct semaphore' occurances to 'struct <br />mutex', against Linus-git-curr:<br /><br /> 405 files changed, 568 insertions(+), 568 deletions(-)<br /><br />it's not _that_ bad, if done overnight. It does not touch any of the <br />down/up APIs. Touching those would create a monster patch and monster <br />impact.<br /><br /> Ingo<br />[unhandled content-type:application/x-bzip2]</pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-13 10:08 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>