CINXE.COM
LKML: Bao Zhao: Re: typo in debugfs code comments?
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Bao Zhao: Re: typo in debugfs code comments?</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Bao Zhao" href="/groupie.php?aid=30937" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/10"> [10]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/10/22" onclick="this.href='/lkml/headers'+'/2005/12/10/22';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/10/22">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/9/278">First message in thread</a></li><li><a href="/lkml/2005/12/9/278">Bao Zhao</a><ul><li><a href="/lkml/2005/12/9/303">Greg KH</a><ul><li class="origin"><a href="/lkml/2005/12/10/38">Bao Zhao</a><ul><li><a href="/lkml/2005/12/10/38">Greg KH</a></li></ul></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/12/10/22/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 9 Dec 2005 23:50:12 -0800 (PST)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Bao Zhao <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: typo in debugfs code comments?</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody"><br /><br />--- Greg KH <greg@kroah.com> wrote:<br /><br />> On Fri, Dec 09, 2005 at 06:01:34PM -0800, Bao Zhao<br />> wrote:<br />> > I think that the comments of debugfs_create_u16<br />> and<br />> > debugfs_create_u32 <br />> > have the copy and paste error.<br />> > <br />> > below is original comments.<br />> > /**<br />> > * debugfs_create_u16 - create a file in the<br />> debugfs<br />> > filesystem that is used to read and write a<br />> unsigned 8<br />> > bit value.<br />> > *<br />> > <br />> > /**<br />> > * debugfs_create_u32 - create a file in the<br />> debugfs<br />> > filesystem that is used to read and write a<br />> unsigned 8<br />> > bit value.<br />> > *<br />> > <br />> > It should be "a unsigned 16 bit value" and "a<br />> unsigned<br />> > 32 bit value"<br />> <br />> Heh, cut and paste comments :)<br />> <br />> Care to send me a patch, as per<br />> Documentation/SubmittingPatches to fix<br />> this up?<br />> <br />> thanks,<br />> <br />> greg k-h<br />> <br /><br />This patch fixes cut and paste error in debugfs.<br /><br />Signed-off-by: Zhao Bao <baozhaolinuxer@yahoo.com><br /><br />---<br /><br />--- linux-2.6.14.3/fs/debugfs/file.c.orig 2005-12-03<br />17:39:41.000000000 -0500<br />+++ linux-2.6.14.3/fs/debugfs/file.c 2005-12-03<br />17:41:15.000000000 -0500<br />@@ -98,7 +98,7 @@ static u64 debugfs_u16_get(void<br />*data)<br /> DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get,<br />debugfs_u16_set, "%llu\n");<br /> <br /> /**<br />- * debugfs_create_u16 - create a file in the debugfs<br />filesystem that is used to read and write a unsigned 8<br />bit value.<br />+ * debugfs_create_u16 - create a file in the debugfs<br />filesystem that is used to read and write a unsigned<br />16 bit value.<br /> *<br /> * @name: a pointer to a string containing the name<br />of the file to create.<br /> * @mode: the permission that the file should have<br />@@ -140,7 +140,7 @@ static u64 debugfs_u32_get(void<br />*data)<br /> DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get,<br />debugfs_u32_set, "%llu\n");<br /> <br /> /**<br />- * debugfs_create_u32 - create a file in the debugfs<br />filesystem that is used to read and write a unsigned 8<br />bit value.<br />+ * debugfs_create_u32 - create a file in the debugfs<br />filesystem that is used to read and write a unsigned<br />32 bit value.<br /> *<br /> * @name: a pointer to a string containing the name<br />of the file to create.<br /> * @mode: the permission that the file should have<br /><br /><br />__________________________________________________<br />Do You Yahoo!?<br />Tired of spam? Yahoo! Mail has the best spam protection around <br /><a href="https://mail.yahoo.com">http://mail.yahoo.com</a> <br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-10 08:52 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>