CINXE.COM

<!DOCTYPE html> <html lang="en" data-color-mode="auto" data-light-theme="light" data-dark-theme="dark" data-a11y-animated-images="system" data-a11y-link-underlines="true" > <head> <meta charset="utf-8"> <link rel="dns-prefetch" href="https://github.githubassets.com"> <link rel="dns-prefetch" href="https://avatars.githubusercontent.com"> <link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com"> <link rel="dns-prefetch" href="https://user-images.githubusercontent.com/"> <link rel="preconnect" href="https://github.githubassets.com" crossorigin> <link rel="preconnect" href="https://avatars.githubusercontent.com"> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/light-3e154969b9f9.css" /><link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/dark-9c5b7a476542.css" /><link data-color-theme="dark_dimmed" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_dimmed-afda8eb0fb33.css" /><link data-color-theme="dark_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_high_contrast-2494e44ccdc5.css" /><link data-color-theme="dark_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_colorblind-56fff47acadc.css" /><link data-color-theme="light_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_colorblind-71cd4cc132ec.css" /><link data-color-theme="light_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_high_contrast-fd5499848985.css" /><link data-color-theme="light_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_tritanopia-31d17ba3e139.css" /><link data-color-theme="dark_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_tritanopia-68d6b2c79663.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-primitives-4cf0d59ab51a.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-af846850481e.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/global-8b10f05a77e6.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/github-d3b66f11d613.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/repository-9c77ed90200e.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/pull-requests-531a3fdee92a.css" /> <script type="application/json" id="client-env">{"locale":"en","featureFlags":["copilot_new_references_ui","copilot_beta_features_opt_in","copilot_chat_static_thread_suggestions","copilot_conversational_ux_history_refs","copilot_implicit_context","copilot_smell_icebreaker_ux","experimentation_azure_variant_endpoint","failbot_handle_non_errors","geojson_azure_maps","ghost_pilot_confidence_truncation_25","ghost_pilot_confidence_truncation_40","hovercard_accessibility","issues_react_new_timeline","issues_react_avatar_refactor","issues_react_remove_placeholders","issues_react_blur_item_picker_on_close","marketing_pages_search_explore_provider","react_keyboard_shortcuts_dialog","remove_child_patch","sample_network_conn_type","site_metered_billing_update","issues_react_first_time_contribution_banner","ui_commands_respect_modals","lifecycle_label_name_updates"]}</script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/wp-runtime-0c166a63ca9a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_dompurify_dist_purify_js-b73fdff77a4e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover_js-aff936e590ed.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_arianotify-polyfill_ariaNotify-polyfill_js-node_modules_github_mi-247092-740e4ddd559d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_failbot_failbot_ts-93b6a0551aa9.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/environment-cd35650c2e9c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_primer_behaviors_dist_esm_index_mjs-4aa4b0e95669.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_selector-observer_dist_index_esm_js-f690fd9ae3d5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_relative-time-element_dist_index_js-6d3967acd51c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_combobox-nav_dist_index_js-node_modules_github_g-emoji-element_di-6ce195-53781cbc550f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_auto-complete-element_dist_index_js-node_modules_github_catalyst_-6afc16-3cdfa69a0406.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_text-expander-element_dist_index_js-f5498b8d4e5d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_filter-input-element_dist_index_js-node_modules_github_remote-inp-b5f1d7-492b5042c841.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-1f651a-1e3d784c897c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co-7671f1-dc6cac136d88.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/github-elements-71486356f507.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/element-registry-e3ab8405ef80.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_braintree_browser-detection_dist_browser-detection_js-node_modules_githu-bb80ec-634de60bacfa.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_lit-html_lit-html_js-ce7225a304c5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_hydro-analytics-client_dist_analytics-client_js-node_modules_gith-f3aee1-e6893db9c19e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_morphdom_dist_morphdom-e-7c534c-f8a5485c982a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_turbo_dist_turbo_es2017-esm_js-858e043fcf76.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-893f9f-6cf3320416b8.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_scroll-anchoring_dist_scroll-anchoring_esm_js-node_modules_stacktrace-pa-a71630-6f3c4f0189d8.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_color-convert_index_js-0e07cc183eed.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_quote-selection_dist_index_js-node_modules_github_session-resume_-0b5e12-889cec8cf448.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_updatable-content_updatable-content_ts-eae9df0dd562.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_task-list_ts-app_assets_modules_github_sso_ts-ui_packages-900dde-18d1c91a7872.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_sticky-scroll-into-view_ts-7cbef09a422c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_ajax-error_ts-app_assets_modules_github_behaviors_include-d0d0a6-0e9fa537dc4f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_commenting_edit_ts-app_assets_modules_github_behaviors_ht-83c235-c89801ebbe15.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/behaviors-a6e4c4c86bfa.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_catalyst_lib_index_js-f6223d90c7ba.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-global-3366f6b6298e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_virtualized-list_es_index_js-node_modules_github_template-parts_lib_index_js-96453a51f920.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_stacktrace-parser_dist_stack-trace-parser_esm_js-node_modules_github_bro-b0a862-4d8589138d1e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-0e9dbe-d2bcedf65682.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_ref-selector_ts-043af64042a1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/codespaces-4158520ad4d7.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-core-cd0a67881543.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-lib-7b7b5264f6c1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_tanstack_query-core_build_modern_queryClient_js-e40bb86d3e93.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_tanstack_query-core_build_modern_queryObserver_js-node_modules_tanstack_-defd52-585c05e837f3.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_primer_live-region-element-32d343-56ceead9587a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_delegated-events_di-cc9bcb-ea42a360c5ae.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_diffs_blob-lines_ts-app_assets_modules_github_diffs_linkable-line-n-b8c0ea-77a5219efe36.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/diffs-26b30052e1d0.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/scanning-36c6f3eaa22e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_catalyst_lib_inde-dbbea9-9b97703a4e6a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/code-menu-13971a40799a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/primer-react-765944243383.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-core-cd0a67881543.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-lib-7b7b5264f6c1.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/octicons-react-45c3a19dd792.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_tanstack_query-core_build_modern_queryClient_js-e40bb86d3e93.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_emotion_is-prop-valid_dist_emotion-is-prop-valid_esm_js-node_modules_emo-37e3d5-31653d7f2342.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-e7dcdd-285fc29e9fa5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover-fn_js-4896ddd4b7bb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-subscriptions-menu-3eda30673b32.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.9fa170e9435ed4b922b9.module.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/notifications-subscriptions-menu.1bcff9205c241e99cff2.module.css" /> <title>when a template is missing for the default render, do head no_content instead by sb8244 · Pull Request #19377 · rails/rails · GitHub</title> <meta name="route-pattern" content="/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)" data-turbo-transient> <meta name="route-controller" content="voltron_pull_requests_fragments" data-turbo-transient> <meta name="route-action" content="pull_request_layout" data-turbo-transient> <meta name="current-catalog-service-hash" content="ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b"> <meta name="request-id" content="CDD6:22F134:118041C:13BB08E:67476FD2" data-pjax-transient="true"/><meta name="html-safe-nonce" content="c4c52f7b5c1f5966aacee49c63874bd037e01b433ad001f00010e9703efa6664" data-pjax-transient="true"/><meta name="visitor-payload" content="eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREQ2OjIyRjEzNDoxMTgwNDFDOjEzQkIwOEU6Njc0NzZGRDIiLCJ2aXNpdG9yX2lkIjoiNTYwODQ1OTQxNDU4MDcxOTU3MCIsInJlZ2lvbl9lZGdlIjoic291dGhlYXN0YXNpYSIsInJlZ2lvbl9yZW5kZXIiOiJzb3V0aGVhc3Rhc2lhIn0=" data-pjax-transient="true"/><meta name="visitor-hmac" content="58150809ae525424aa2afe29689cfc7ee0c74708e19c15297a3286d293a9dbb1" data-pjax-transient="true"/> <meta name="hovercard-subject-tag" content="pull_request:31341031" data-turbo-transient> <meta name="github-keyboard-shortcuts" content="repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot" data-turbo-transient="true" /> <meta name="selected-link" value="repo_pulls" data-turbo-transient> <link rel="assets" href="https://github.githubassets.com/"> <meta name="google-site-verification" content="Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I"> <meta name="octolytics-url" content="https://collector.github.com/github/collect" /> <meta name="analytics-location" content="/<user-name>/<repo-name>/voltron/pull_requests_fragments/pull_request_layout" data-turbo-transient="true" /> <meta name="user-login" content=""> <meta name="viewport" content="width=device-width"> <meta name="description" content="Fixes #19036 #19036 (comment) I want to do a comparison like: def default_render(*args) if template_exists?(action, _prefixes) render(*args) else head :no_content ..."> <link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub"> <link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub"> <meta property="fb:app_id" content="1401488693436528"> <meta name="apple-itunes-app" content="app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rails/rails/19377/pull_request_layout" /> <meta name="twitter:image" content="https://opengraph.githubassets.com/51deb751efc55825556c0fd7b740a49a85194c989ad46638e7f405aa1e10af0d/rails/rails/pull/19377" /><meta name="twitter:site" content="@github" /><meta name="twitter:card" content="summary_large_image" /><meta name="twitter:title" content="when a template is missing for the default render, do head no_content instead by sb8244 · Pull Request #19377 · rails/rails" /><meta name="twitter:description" content="Fixes #19036 #19036 (comment) I want to do a comparison like: def default_render(*args) if template_exists?(action, _prefixes) render(*args) else head :no_content ..." /> <meta property="og:image" content="https://opengraph.githubassets.com/51deb751efc55825556c0fd7b740a49a85194c989ad46638e7f405aa1e10af0d/rails/rails/pull/19377" /><meta property="og:image:alt" content="Fixes #19036 #19036 (comment) I want to do a comparison like: def default_render(*args) if template_exists?(action, _prefixes) render(*args) else head :no_content ..." /><meta property="og:image:width" content="1200" /><meta property="og:image:height" content="600" /><meta property="og:site_name" content="GitHub" /><meta property="og:type" content="object" /><meta property="og:title" content="when a template is missing for the default render, do head no_content instead by sb8244 · Pull Request #19377 · rails/rails" /><meta property="og:url" content="https://github.com/rails/rails/pull/19377" /><meta property="og:description" content="Fixes #19036 #19036 (comment) I want to do a comparison like: def default_render(*args) if template_exists?(action, _prefixes) render(*args) else head :no_content ..." /><meta property="og:author:username" content="sb8244" /> <meta name="hostname" content="github.com"> <meta name="expected-hostname" content="github.com"> <meta http-equiv="x-pjax-version" content="cc7767a0c18d7e936a37ec4b8ef829934f464822634943ba0cbdcb5e25e14f1d" data-turbo-track="reload"> <meta http-equiv="x-pjax-csp-version" content="ace39c3b6632770952207593607e6e0be0db363435a8b877b1f96abe6430f345" data-turbo-track="reload"> <meta http-equiv="x-pjax-css-version" content="15b18460ccb38585911f0182c65a829cc58635f60a4a305813e3a2bc7ff7d158" data-turbo-track="reload"> <meta http-equiv="x-pjax-js-version" content="b683bfe8ba503fb752a8a7e87a8162efe7eaf74732202ad69805baa0fa057db8" data-turbo-track="reload"> <meta name="turbo-cache-control" content="no-preview" data-turbo-transient=""> <meta name="voltron-timing" value="2215"> <meta name="go-import" content="github.com/rails/rails git https://github.com/rails/rails.git"> <meta name="octolytics-dimension-user_id" content="4223" /><meta name="octolytics-dimension-user_login" content="rails" /><meta name="octolytics-dimension-repository_id" content="8514" /><meta name="octolytics-dimension-repository_nwo" content="rails/rails" /><meta name="octolytics-dimension-repository_public" content="true" /><meta name="octolytics-dimension-repository_is_fork" content="false" /><meta name="octolytics-dimension-repository_network_root_id" content="8514" /><meta name="octolytics-dimension-repository_network_root_nwo" content="rails/rails" /> <meta name="turbo-body-classes" content="logged-out env-production page-responsive"> <meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats"> <meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors"> <link rel="mask-icon" href="https://github.githubassets.com/assets/pinned-octocat-093da3e6fa40.svg" color="#000000"> <link rel="alternate icon" class="js-site-favicon" type="image/png" href="https://github.githubassets.com/favicons/favicon.png"> <link rel="icon" class="js-site-favicon" type="image/svg+xml" href="https://github.githubassets.com/favicons/favicon.svg" data-base-href="https://github.githubassets.com/favicons/favicon"> <meta name="theme-color" content="#1e2327"> <meta name="color-scheme" content="light dark" /> <link rel="manifest" href="/manifest.json" crossOrigin="use-credentials"> </head> <body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div data-turbo-body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div class="position-relative header-wrapper js-header-wrapper "> <a href="#start-of-content" data-skip-target-assigned="false" class="px-2 py-4 color-bg-accent-emphasis color-fg-on-emphasis show-on-focus js-skip-to-content">Skip to content</a> <span data-view-component="true" class="progress-pjax-loader Progress position-fixed width-full"> <span style="width: 0%;" data-view-component="true" class="Progress-item progress-pjax-loader-bar left-0 top-0 color-bg-accent-emphasis"></span> </span> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/primer-react-765944243383.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/octicons-react-45c3a19dd792.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_emotion_is-prop-valid_dist_emotion-is-prop-valid_esm_js-node_modules_emo-37e3d5-31653d7f2342.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-e7dcdd-285fc29e9fa5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover-fn_js-4896ddd4b7bb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/keyboard-shortcuts-dialog-78b8b9792a5f.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.9fa170e9435ed4b922b9.module.css" /> <react-partial partial-name="keyboard-shortcuts-dialog" data-ssr="false" data-attempted-ssr="false" > <script type="application/json" data-target="react-partial.embeddedData">{"props":{"docsUrl":"https://docs.github.com/get-started/accessibility/keyboard-shortcuts"}}</script> <div data-target="react-partial.reactRoot"></div> </react-partial> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-94fd67-cf3dd69d89eb.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/sessions-8fa3b694f335.js"></script> <header class="HeaderMktg header-logged-out js-details-container js-header Details f4 py-3" role="banner" data-is-top="true" data-color-mode=light data-light-theme=light data-dark-theme=dark> <h2 class="sr-only">Navigation Menu</h2> <button type="button" class="HeaderMktg-backdrop d-lg-none border-0 position-fixed top-0 left-0 width-full height-full js-details-target" aria-label="Toggle navigation"> <span class="d-none">Toggle navigation</span> </button> <div class="d-flex flex-column flex-lg-row flex-items-center px-3 px-md-4 px-lg-5 height-full position-relative z-1"> <div class="d-flex flex-justify-between flex-items-center width-full width-lg-auto"> <div class="flex-1"> <button aria-label="Toggle navigation" aria-expanded="false" type="button" data-view-component="true" class="js-details-target js-nav-padding-recalculate js-header-menu-toggle Button--link Button--medium Button d-lg-none color-fg-inherit p-1"> <span class="Button-content"> <span class="Button-label"><div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div></span> </span> </button> </div> <a class="mr-lg-3 color-fg-inherit flex-order-2 js-prevent-focus-on-mobile-nav" href="/" aria-label="Homepage" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Logomark;ref_loc:Header"}"> <svg height="32" aria-hidden="true" viewBox="0 0 24 24" version="1.1" width="32" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <div class="flex-1 flex-order-2 text-right"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F19377" class="HeaderMenu-link HeaderMenu-button d-inline-flex d-lg-none flex-order-1 f5 no-underline border color-border-default rounded-2 px-2 py-1 color-fg-inherit js-prevent-focus-on-mobile-nav" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="024b860bf7e8697f6fcefd460ac513dbcfba5c38a54267c8d9d80677268696c8" data-analytics-event="{"category":"Marketing nav","action":"click to Sign in","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> </div> <div class="HeaderMenu js-header-menu height-fit position-lg-relative d-lg-flex flex-column flex-auto top-0"> <div class="HeaderMenu-wrapper d-flex flex-column flex-self-start flex-lg-row flex-auto rounded rounded-lg-0"> <nav class="HeaderMenu-nav" aria-label="Global"> <ul class="d-lg-flex list-style-none"> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Product <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"product","tag":"link","label":"github_copilot_link_product_navbar"}" href="https://github.com/features/copilot"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Write better code with AI </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"security","context":"product","tag":"link","label":"security_link_product_navbar"}" href="https://github.com/features/security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Security</div> Find and fix vulnerabilities </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"actions","context":"product","tag":"link","label":"actions_link_product_navbar"}" href="https://github.com/features/actions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-workflow color-fg-subtle mr-3"> <path d="M1 3a2 2 0 0 1 2-2h6.5a2 2 0 0 1 2 2v6.5a2 2 0 0 1-2 2H7v4.063C7 16.355 7.644 17 8.438 17H12.5v-2.5a2 2 0 0 1 2-2H21a2 2 0 0 1 2 2V21a2 2 0 0 1-2 2h-6.5a2 2 0 0 1-2-2v-2.5H8.437A2.939 2.939 0 0 1 5.5 15.562V11.5H3a2 2 0 0 1-2-2Zm2-.5a.5.5 0 0 0-.5.5v6.5a.5.5 0 0 0 .5.5h6.5a.5.5 0 0 0 .5-.5V3a.5.5 0 0 0-.5-.5ZM14.5 14a.5.5 0 0 0-.5.5V21a.5.5 0 0 0 .5.5H21a.5.5 0 0 0 .5-.5v-6.5a.5.5 0 0 0-.5-.5Z"></path> </svg> <div> <div class="color-fg-default h4">Actions</div> Automate any workflow </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"codespaces","context":"product","tag":"link","label":"codespaces_link_product_navbar"}" href="https://github.com/features/codespaces"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-codespaces color-fg-subtle mr-3"> <path d="M3.5 3.75C3.5 2.784 4.284 2 5.25 2h13.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 18.75 13H5.25a1.75 1.75 0 0 1-1.75-1.75Zm-2 12c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v4a1.75 1.75 0 0 1-1.75 1.75H3.25a1.75 1.75 0 0 1-1.75-1.75ZM5.25 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h13.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Zm-2 12a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h17.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25Z"></path><path d="M10 17.75a.75.75 0 0 1 .75-.75h6.5a.75.75 0 0 1 0 1.5h-6.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> <div> <div class="color-fg-default h4">Codespaces</div> Instant dev environments </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"issues","context":"product","tag":"link","label":"issues_link_product_navbar"}" href="https://github.com/features/issues"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-issue-opened color-fg-subtle mr-3"> <path d="M12 1c6.075 0 11 4.925 11 11s-4.925 11-11 11S1 18.075 1 12 5.925 1 12 1ZM2.5 12a9.5 9.5 0 0 0 9.5 9.5 9.5 9.5 0 0 0 9.5-9.5A9.5 9.5 0 0 0 12 2.5 9.5 9.5 0 0 0 2.5 12Zm9.5 2a2 2 0 1 1-.001-3.999A2 2 0 0 1 12 14Z"></path> </svg> <div> <div class="color-fg-default h4">Issues</div> Plan and track work </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"code_review","context":"product","tag":"link","label":"code_review_link_product_navbar"}" href="https://github.com/features/code-review"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-review color-fg-subtle mr-3"> <path d="M10.3 6.74a.75.75 0 0 1-.04 1.06l-2.908 2.7 2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M1.5 4.25c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v12.5a1.75 1.75 0 0 1-1.75 1.75h-9.69l-3.573 3.573A1.458 1.458 0 0 1 5 21.043V18.5H3.25a1.75 1.75 0 0 1-1.75-1.75ZM3.25 4a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h2.5a.75.75 0 0 1 .75.75v3.19l3.72-3.72a.749.749 0 0 1 .53-.22h10a.25.25 0 0 0 .25-.25V4.25a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Review</div> Manage code changes </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"discussions","context":"product","tag":"link","label":"discussions_link_product_navbar"}" href="https://github.com/features/discussions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Discussions</div> Collaborate outside of code </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"code_search","context":"product","tag":"link","label":"code_search_link_product_navbar"}" href="https://github.com/features/code-search"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-square color-fg-subtle mr-3"> <path d="M10.3 8.24a.75.75 0 0 1-.04 1.06L7.352 12l2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M2 3.75C2 2.784 2.784 2 3.75 2h16.5c.966 0 1.75.784 1.75 1.75v16.5A1.75 1.75 0 0 1 20.25 22H3.75A1.75 1.75 0 0 1 2 20.25Zm1.75-.25a.25.25 0 0 0-.25.25v16.5c0 .138.112.25.25.25h16.5a.25.25 0 0 0 .25-.25V3.75a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Search</div> Find more, search less </div> </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="product-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="product-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"all_features","context":"product","tag":"link","label":"all_features_link_product_navbar"}" href="https://github.com/features"> All features </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"documentation","context":"product","tag":"link","label":"documentation_link_product_navbar"}" href="https://docs.github.com"> Documentation <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"github_skills","context":"product","tag":"link","label":"github_skills_link_product_navbar"}" href="https://skills.github.com"> GitHub Skills <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"blog","context":"product","tag":"link","label":"blog_link_product_navbar"}" href="https://github.blog"> Blog <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Solutions <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 pb-lg-3 mb-3 mb-lg-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-company-size-heading">By company size</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-company-size-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"enterprises","context":"solutions","tag":"link","label":"enterprises_link_solutions_navbar"}" href="https://github.com/enterprise"> Enterprises </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"small_and_medium_teams","context":"solutions","tag":"link","label":"small_and_medium_teams_link_solutions_navbar"}" href="https://github.com/team"> Small and medium teams </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"startups","context":"solutions","tag":"link","label":"startups_link_solutions_navbar"}" href="https://github.com/enterprise/startups"> Startups </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-use-case-heading">By use case</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-use-case-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devsecops","context":"solutions","tag":"link","label":"devsecops_link_solutions_navbar"}" href="/solutions/use-case/devsecops"> DevSecOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"solutions","tag":"link","label":"devops_link_solutions_navbar"}" href="/solutions/use-case/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ci_cd","context":"solutions","tag":"link","label":"ci_cd_link_solutions_navbar"}" href="/solutions/use-case/ci-cd"> CI/CD </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_use_cases","context":"solutions","tag":"link","label":"view_all_use_cases_link_solutions_navbar"}" href="/solutions/use-case"> View all use cases </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-industry-heading">By industry</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-industry-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"healthcare","context":"solutions","tag":"link","label":"healthcare_link_solutions_navbar"}" href="/solutions/industry/healthcare"> Healthcare </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"financial_services","context":"solutions","tag":"link","label":"financial_services_link_solutions_navbar"}" href="/solutions/industry/financial-services"> Financial services </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"manufacturing","context":"solutions","tag":"link","label":"manufacturing_link_solutions_navbar"}" href="/solutions/industry/manufacturing"> Manufacturing </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"government","context":"solutions","tag":"link","label":"government_link_solutions_navbar"}" href="/solutions/industry/government"> Government </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_industries","context":"solutions","tag":"link","label":"view_all_industries_link_solutions_navbar"}" href="/solutions/industry"> View all industries </a></li> </ul> </div> </div> <div class="HeaderMenu-trailing-link rounded-bottom-2 flex-shrink-0 mt-lg-4 px-lg-4 py-4 py-lg-3 f5 text-semibold"> <a href="/solutions"> View all solutions <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-right HeaderMenu-trailing-link-icon"> <path d="M6.22 3.22a.75.75 0 0 1 1.06 0l4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L9.94 8 6.22 4.28a.75.75 0 0 1 0-1.06Z"></path> </svg> </a> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Resources <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-topics-heading">Topics</span> <ul class="list-style-none f5" aria-labelledby="resources-topics-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ai","context":"resources","tag":"link","label":"ai_link_resources_navbar"}" href="/resources/articles/ai"> AI </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"resources","tag":"link","label":"devops_link_resources_navbar"}" href="/resources/articles/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"security","context":"resources","tag":"link","label":"security_link_resources_navbar"}" href="/resources/articles/security"> Security </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"software_development","context":"resources","tag":"link","label":"software_development_link_resources_navbar"}" href="/resources/articles/software-development"> Software Development </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all","context":"resources","tag":"link","label":"view_all_link_resources_navbar"}" href="/resources/articles"> View all </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="resources-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"learning_pathways","context":"resources","tag":"link","label":"learning_pathways_link_resources_navbar"}" href="https://resources.github.com/learn/pathways"> Learning Pathways <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"white_papers_ebooks_webinars","context":"resources","tag":"link","label":"white_papers_ebooks_webinars_link_resources_navbar"}" href="https://resources.github.com"> White papers, Ebooks, Webinars <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"customer_stories","context":"resources","tag":"link","label":"customer_stories_link_resources_navbar"}" href="https://github.com/customer-stories"> Customer Stories </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"partners","context":"resources","tag":"link","label":"partners_link_resources_navbar"}" href="https://partner.github.com"> Partners <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Open Source <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"github_sponsors","context":"open_source","tag":"link","label":"github_sponsors_link_open_source_navbar"}" href="/sponsors"> <div> <div class="color-fg-default h4">GitHub Sponsors</div> Fund open source developers </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"the_readme_project","context":"open_source","tag":"link","label":"the_readme_project_link_open_source_navbar"}" href="https://github.com/readme"> <div> <div class="color-fg-default h4">The ReadME Project</div> GitHub community articles </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="open-source-repositories-heading">Repositories</span> <ul class="list-style-none f5" aria-labelledby="open-source-repositories-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"topics","context":"open_source","tag":"link","label":"topics_link_open_source_navbar"}" href="https://github.com/topics"> Topics </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"trending","context":"open_source","tag":"link","label":"trending_link_open_source_navbar"}" href="https://github.com/trending"> Trending </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"collections","context":"open_source","tag":"link","label":"collections_link_open_source_navbar"}" href="https://github.com/collections"> Collections </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Enterprise <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"enterprise_platform","context":"enterprise","tag":"link","label":"enterprise_platform_link_enterprise_navbar"}" href="/enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-stack color-fg-subtle mr-3"> <path d="M11.063 1.456a1.749 1.749 0 0 1 1.874 0l8.383 5.316a1.751 1.751 0 0 1 0 2.956l-8.383 5.316a1.749 1.749 0 0 1-1.874 0L2.68 9.728a1.751 1.751 0 0 1 0-2.956Zm1.071 1.267a.25.25 0 0 0-.268 0L3.483 8.039a.25.25 0 0 0 0 .422l8.383 5.316a.25.25 0 0 0 .268 0l8.383-5.316a.25.25 0 0 0 0-.422Z"></path><path d="M1.867 12.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path><path d="M1.867 16.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path> </svg> <div> <div class="color-fg-default h4">Enterprise platform</div> AI-powered developer platform </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="enterprise-available-add-ons-heading">Available add-ons</span> <ul class="list-style-none f5" aria-labelledby="enterprise-available-add-ons-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"advanced_security","context":"enterprise","tag":"link","label":"advanced_security_link_enterprise_navbar"}" href="https://github.com/enterprise/advanced-security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Advanced Security</div> Enterprise-grade security features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"enterprise","tag":"link","label":"github_copilot_link_enterprise_navbar"}" href="/features/copilot#enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Enterprise-grade AI features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"premium_support","context":"enterprise","tag":"link","label":"premium_support_link_enterprise_navbar"}" href="/premium-support"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Premium Support</div> Enterprise-grade 24/7 support </div> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <a class="HeaderMenu-link no-underline px-0 px-lg-2 py-3 py-lg-2 d-block d-lg-inline-block" data-analytics-event="{"location":"navbar","action":"pricing","context":"global","tag":"link","label":"pricing_link_global_navbar"}" href="https://github.com/pricing">Pricing</a> </li> </ul> </nav> <div class="d-flex flex-column flex-lg-row width-full flex-justify-end flex-lg-items-center text-center mt-3 mt-lg-0 text-lg-left ml-lg-3"> <qbsearch-input class="search-input" data-scope="repo:rails/rails" data-custom-scopes-path="/search/custom_scopes" data-delete-custom-scopes-csrf="Vv0pU8TffoeWNK7ZdqsNU8l19x6M8ZHSKEGXaOHVNggTZlHtVlG2qmkHmuWeSJj6f4rFlbAnOUpY-98eTHk5Hg" data-max-custom-scopes="10" data-header-redesign-enabled="false" data-initial-value="" data-blackbird-suggestions-path="/search/suggestions" data-jump-to-suggestions-path="/_graphql/GetSuggestedNavigationDestinations" data-current-repository="rails/rails" data-current-org="rails" data-current-owner="" data-logged-in="false" data-copilot-chat-enabled="false" data-nl-search-enabled="false" data-retain-scroll-position="true"> <div class="search-input-container search-with-dialog position-relative d-flex flex-row flex-items-center mr-4 rounded" data-action="click:qbsearch-input#searchInputContainerClicked" > <button type="button" class="header-search-button placeholder input-button form-control d-flex flex-1 flex-self-stretch flex-items-center no-wrap width-full py-0 pl-2 pr-0 text-left border-0 box-shadow-none" data-target="qbsearch-input.inputButton" aria-label="Search or jump to…" aria-haspopup="dialog" placeholder="Search or jump to..." data-hotkey=s,/ autocapitalize="off" data-analytics-event="{"location":"navbar","action":"searchbar","context":"global","tag":"input","label":"searchbar_input_global_navbar"}" data-action="click:qbsearch-input#handleExpand" > <div class="mr-2 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </div> <span class="flex-1" data-target="qbsearch-input.inputButtonText">Search or jump to...</span> <div class="d-flex" data-target="qbsearch-input.hotkeyIndicator"> <svg xmlns="http://www.w3.org/2000/svg" width="22" height="20" aria-hidden="true" class="mr-1"><path fill="none" stroke="#979A9C" opacity=".4" d="M3.5.5h12c1.7 0 3 1.3 3 3v13c0 1.7-1.3 3-3 3h-12c-1.7 0-3-1.3-3-3v-13c0-1.7 1.3-3 3-3z"></path><path fill="#979A9C" d="M11.8 6L8 15.1h-.9L10.8 6h1z"></path></svg> </div> </button> <input type="hidden" name="type" class="js-site-search-type-field"> <div class="Overlay--hidden " data-modal-dialog-overlay> <modal-dialog data-action="close:qbsearch-input#handleClose cancel:qbsearch-input#handleClose" data-target="qbsearch-input.searchSuggestionsDialog" role="dialog" id="search-suggestions-dialog" aria-modal="true" aria-labelledby="search-suggestions-dialog-header" data-view-component="true" class="Overlay Overlay--width-large Overlay--height-auto"> <h1 id="search-suggestions-dialog-header" class="sr-only">Search code, repositories, users, issues, pull requests...</h1> <div class="Overlay-body Overlay-body--paddingNone"> <div data-view-component="true"> <div class="search-suggestions position-fixed width-full color-shadow-large border color-fg-default color-bg-default overflow-hidden d-flex flex-column query-builder-container" style="border-radius: 12px;" data-target="qbsearch-input.queryBuilderContainer" hidden > </option></form><form id="query-builder-test-form" action="" accept-charset="UTF-8" method="get"> <query-builder data-target="qbsearch-input.queryBuilder" id="query-builder-query-builder-test" data-filter-key=":" data-view-component="true" class="QueryBuilder search-query-builder"> <div class="FormControl FormControl--fullWidth"> <label id="query-builder-test-label" for="query-builder-test" class="FormControl-label sr-only"> Search </label> <div class="QueryBuilder-StyledInput width-fit " data-target="query-builder.styledInput" > <span id="query-builder-test-leadingvisual-wrap" class="FormControl-input-leadingVisualWrap QueryBuilder-leadingVisualWrap"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search FormControl-input-leadingVisual"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </span> <div data-target="query-builder.styledInputContainer" class="QueryBuilder-StyledInputContainer"> <div aria-hidden="true" class="QueryBuilder-StyledInputContent" data-target="query-builder.styledInputContent" ></div> <div class="QueryBuilder-InputWrapper"> <div aria-hidden="true" class="QueryBuilder-Sizer" data-target="query-builder.sizer"></div> <input id="query-builder-test" name="query-builder-test" value="" autocomplete="off" type="text" role="combobox" spellcheck="false" aria-expanded="false" aria-describedby="validation-df6cf187-12c8-4379-a88e-c497bccd6beb" data-target="query-builder.input" data-action=" input:query-builder#inputChange blur:query-builder#inputBlur keydown:query-builder#inputKeydown focus:query-builder#inputFocus " data-view-component="true" class="FormControl-input QueryBuilder-Input FormControl-medium" /> </div> </div> <span class="sr-only" id="query-builder-test-clear">Clear</span> <button role="button" id="query-builder-test-clear-button" aria-labelledby="query-builder-test-clear query-builder-test-label" data-target="query-builder.clearButton" data-action=" click:query-builder#clear focus:query-builder#clearButtonFocus blur:query-builder#clearButtonBlur " variant="small" hidden="hidden" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium mr-1 px-2 py-0 d-flex flex-items-center rounded-1 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x-circle-fill Button-visual"> <path d="M2.343 13.657A8 8 0 1 1 13.658 2.343 8 8 0 0 1 2.343 13.657ZM6.03 4.97a.751.751 0 0 0-1.042.018.751.751 0 0 0-.018 1.042L6.94 8 4.97 9.97a.749.749 0 0 0 .326 1.275.749.749 0 0 0 .734-.215L8 9.06l1.97 1.97a.749.749 0 0 0 1.275-.326.749.749 0 0 0-.215-.734L9.06 8l1.97-1.97a.749.749 0 0 0-.326-1.275.749.749 0 0 0-.734.215L8 6.94Z"></path> </svg> </button> </div> <template id="search-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </template> <template id="code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="file-code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-file-code"> <path d="M4 1.75C4 .784 4.784 0 5.75 0h5.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v8.586A1.75 1.75 0 0 1 14.25 15h-9a.75.75 0 0 1 0-1.5h9a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 10 4.25V1.5H5.75a.25.25 0 0 0-.25.25v2.5a.75.75 0 0 1-1.5 0Zm1.72 4.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l1.47-1.47-1.47-1.47a.75.75 0 0 1 0-1.06ZM3.28 7.78 1.81 9.25l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Zm8.22-6.218V4.25c0 .138.112.25.25.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"></path> </svg> </template> <template id="history-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-history"> <path d="m.427 1.927 1.215 1.215a8.002 8.002 0 1 1-1.6 5.685.75.75 0 1 1 1.493-.154 6.5 6.5 0 1 0 1.18-4.458l1.358 1.358A.25.25 0 0 1 3.896 6H.25A.25.25 0 0 1 0 5.75V2.104a.25.25 0 0 1 .427-.177ZM7.75 4a.75.75 0 0 1 .75.75v2.992l2.028.812a.75.75 0 0 1-.557 1.392l-2.5-1A.751.751 0 0 1 7 8.25v-3.5A.75.75 0 0 1 7.75 4Z"></path> </svg> </template> <template id="repo-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> </template> <template id="bookmark-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bookmark"> <path d="M3 2.75C3 1.784 3.784 1 4.75 1h6.5c.966 0 1.75.784 1.75 1.75v11.5a.75.75 0 0 1-1.227.579L8 11.722l-3.773 3.107A.751.751 0 0 1 3 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v9.91l3.023-2.489a.75.75 0 0 1 .954 0l3.023 2.49V2.75a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="plus-circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-plus-circle"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm7.25-3.25v2.5h2.5a.75.75 0 0 1 0 1.5h-2.5v2.5a.75.75 0 0 1-1.5 0v-2.5h-2.5a.75.75 0 0 1 0-1.5h2.5v-2.5a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-dot-fill"> <path d="M8 4a4 4 0 1 1 0 8 4 4 0 0 1 0-8Z"></path> </svg> </template> <template id="trash-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-trash"> <path d="M11 1.75V3h2.25a.75.75 0 0 1 0 1.5H2.75a.75.75 0 0 1 0-1.5H5V1.75C5 .784 5.784 0 6.75 0h2.5C10.216 0 11 .784 11 1.75ZM4.496 6.675l.66 6.6a.25.25 0 0 0 .249.225h5.19a.25.25 0 0 0 .249-.225l.66-6.6a.75.75 0 0 1 1.492.149l-.66 6.6A1.748 1.748 0 0 1 10.595 15h-5.19a1.75 1.75 0 0 1-1.741-1.575l-.66-6.6a.75.75 0 1 1 1.492-.15ZM6.5 1.75V3h3V1.75a.25.25 0 0 0-.25-.25h-2.5a.25.25 0 0 0-.25.25Z"></path> </svg> </template> <template id="team-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-people"> <path d="M2 5.5a3.5 3.5 0 1 1 5.898 2.549 5.508 5.508 0 0 1 3.034 4.084.75.75 0 1 1-1.482.235 4 4 0 0 0-7.9 0 .75.75 0 0 1-1.482-.236A5.507 5.507 0 0 1 3.102 8.05 3.493 3.493 0 0 1 2 5.5ZM11 4a3.001 3.001 0 0 1 2.22 5.018 5.01 5.01 0 0 1 2.56 3.012.749.749 0 0 1-.885.954.752.752 0 0 1-.549-.514 3.507 3.507 0 0 0-2.522-2.372.75.75 0 0 1-.574-.73v-.352a.75.75 0 0 1 .416-.672A1.5 1.5 0 0 0 11 5.5.75.75 0 0 1 11 4Zm-5.5-.5a2 2 0 1 0-.001 3.999A2 2 0 0 0 5.5 3.5Z"></path> </svg> </template> <template id="project-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-project"> <path d="M1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0ZM1.5 1.75v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25ZM11.75 3a.75.75 0 0 1 .75.75v7.5a.75.75 0 0 1-1.5 0v-7.5a.75.75 0 0 1 .75-.75Zm-8.25.75a.75.75 0 0 1 1.5 0v5.5a.75.75 0 0 1-1.5 0ZM8 3a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0v-3.5A.75.75 0 0 1 8 3Z"></path> </svg> </template> <template id="pencil-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-pencil"> <path d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"></path> </svg> </template> <template id="copilot-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot"> <path d="M7.998 15.035c-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.201-.508-.254-1.084-.254-1.656 0-.87.128-1.769.693-2.484.579-.733 1.494-1.124 2.724-1.261 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095v1.872c0 .766-3.351 3.795-8.002 3.795Zm0-1.485c2.28 0 4.584-1.11 5.002-1.433V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-1.146 0-2.059-.327-2.71-.991A3.222 3.222 0 0 1 8 6.303a3.24 3.24 0 0 1-.544.743c-.65.664-1.563.991-2.71.991-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433ZM6.762 2.83c-.193-.206-.637-.413-1.682-.297-1.019.113-1.479.404-1.713.7-.247.312-.369.789-.369 1.554 0 .793.129 1.171.308 1.371.162.181.519.379 1.442.379.853 0 1.339-.235 1.638-.54.315-.322.527-.827.617-1.553.117-.935-.037-1.395-.241-1.614Zm4.155-.297c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Z"></path><path d="M6.25 9.037a.75.75 0 0 1 .75.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 .75-.75Zm4.25.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="copilot-error-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot-error"> <path d="M16 11.24c0 .112-.072.274-.21.467L13 9.688V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-.198 0-.388-.009-.571-.029L6.833 5.226a4.01 4.01 0 0 0 .17-.782c.117-.935-.037-1.395-.241-1.614-.193-.206-.637-.413-1.682-.297-.683.076-1.115.231-1.395.415l-1.257-.91c.579-.564 1.413-.877 2.485-.996 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095Zm-5.083-8.707c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Zm2.511 11.074c-1.393.776-3.272 1.428-5.43 1.428-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.18-.455-.241-.963-.252-1.475L.31 4.107A.747.747 0 0 1 0 3.509V3.49a.748.748 0 0 1 .625-.73c.156-.026.306.047.435.139l14.667 10.578a.592.592 0 0 1 .227.264.752.752 0 0 1 .046.249v.022a.75.75 0 0 1-1.19.596Zm-1.367-.991L5.635 7.964a5.128 5.128 0 0 1-.889.073c-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433 1.539 0 3.089-.505 4.063-.934Z"></path> </svg> </template> <template id="workflow-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-workflow"> <path d="M0 1.75C0 .784.784 0 1.75 0h3.5C6.216 0 7 .784 7 1.75v3.5A1.75 1.75 0 0 1 5.25 7H4v4a1 1 0 0 0 1 1h4v-1.25C9 9.784 9.784 9 10.75 9h3.5c.966 0 1.75.784 1.75 1.75v3.5A1.75 1.75 0 0 1 14.25 16h-3.5A1.75 1.75 0 0 1 9 14.25v-.75H5A2.5 2.5 0 0 1 2.5 11V7h-.75A1.75 1.75 0 0 1 0 5.25Zm1.75-.25a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Zm9 9a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="book-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> </template> <template id="code-review-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-review"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 13H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 14.543V13H1.75A1.75 1.75 0 0 1 0 11.25v-8.5C0 1.784.784 1 1.75 1ZM1.5 2.75v8.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-8.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm5.28 1.72a.75.75 0 0 1 0 1.06L5.31 7l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.75.75 0 0 1 1.06 0Zm2.44 0a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L10.69 7 9.22 5.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="codespaces-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-codespaces"> <path d="M0 11.25c0-.966.784-1.75 1.75-1.75h12.5c.966 0 1.75.784 1.75 1.75v3A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm2-9.5C2 .784 2.784 0 3.75 0h8.5C13.216 0 14 .784 14 1.75v5a1.75 1.75 0 0 1-1.75 1.75h-8.5A1.75 1.75 0 0 1 2 6.75Zm1.75-.25a.25.25 0 0 0-.25.25v5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-5a.25.25 0 0 0-.25-.25Zm-2 9.5a.25.25 0 0 0-.25.25v3c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-3a.25.25 0 0 0-.25-.25Z"></path><path d="M7 12.75a.75.75 0 0 1 .75-.75h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> </template> <template id="comment-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment"> <path d="M1 2.75C1 1.784 1.784 1 2.75 1h10.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 13.25 12H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 13.543V12H2.75A1.75 1.75 0 0 1 1 10.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="comment-discussion-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </template> <template id="organization-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-organization"> <path d="M1.75 16A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0h8.5C11.216 0 12 .784 12 1.75v12.5c0 .085-.006.168-.018.25h2.268a.25.25 0 0 0 .25-.25V8.285a.25.25 0 0 0-.111-.208l-1.055-.703a.749.749 0 1 1 .832-1.248l1.055.703c.487.325.779.871.779 1.456v5.965A1.75 1.75 0 0 1 14.25 16h-3.5a.766.766 0 0 1-.197-.026c-.099.017-.2.026-.303.026h-3a.75.75 0 0 1-.75-.75V14h-1v1.25a.75.75 0 0 1-.75.75Zm-.25-1.75c0 .138.112.25.25.25H4v-1.25a.75.75 0 0 1 .75-.75h2.5a.75.75 0 0 1 .75.75v1.25h2.25a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM3.75 6h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 3.75A.75.75 0 0 1 3.75 3h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 3.75Zm4 3A.75.75 0 0 1 7.75 6h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 7 6.75ZM7.75 3h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 9.75A.75.75 0 0 1 3.75 9h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 9.75ZM7.75 9h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="rocket-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-rocket"> <path d="M14.064 0h.186C15.216 0 16 .784 16 1.75v.186a8.752 8.752 0 0 1-2.564 6.186l-.458.459c-.314.314-.641.616-.979.904v3.207c0 .608-.315 1.172-.833 1.49l-2.774 1.707a.749.749 0 0 1-1.11-.418l-.954-3.102a1.214 1.214 0 0 1-.145-.125L3.754 9.816a1.218 1.218 0 0 1-.124-.145L.528 8.717a.749.749 0 0 1-.418-1.11l1.71-2.774A1.748 1.748 0 0 1 3.31 4h3.204c.288-.338.59-.665.904-.979l.459-.458A8.749 8.749 0 0 1 14.064 0ZM8.938 3.623h-.002l-.458.458c-.76.76-1.437 1.598-2.02 2.5l-1.5 2.317 2.143 2.143 2.317-1.5c.902-.583 1.74-1.26 2.499-2.02l.459-.458a7.25 7.25 0 0 0 2.123-5.127V1.75a.25.25 0 0 0-.25-.25h-.186a7.249 7.249 0 0 0-5.125 2.123ZM3.56 14.56c-.732.732-2.334 1.045-3.005 1.148a.234.234 0 0 1-.201-.064.234.234 0 0 1-.064-.201c.103-.671.416-2.273 1.15-3.003a1.502 1.502 0 1 1 2.12 2.12Zm6.94-3.935c-.088.06-.177.118-.266.175l-2.35 1.521.548 1.783 1.949-1.2a.25.25 0 0 0 .119-.213ZM3.678 8.116 5.2 5.766c.058-.09.117-.178.176-.266H3.309a.25.25 0 0 0-.213.119l-1.2 1.95ZM12 5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </template> <template id="shield-check-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield-check"> <path d="m8.533.133 5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667l5.25-1.68a1.748 1.748 0 0 1 1.066 0Zm-.61 1.429.001.001-5.25 1.68a.251.251 0 0 0-.174.237V7c0 1.36.275 2.666 1.057 3.859.784 1.194 2.121 2.342 4.366 3.298a.196.196 0 0 0 .154 0c2.245-.957 3.582-2.103 4.366-3.297C13.225 9.666 13.5 8.358 13.5 7V3.48a.25.25 0 0 0-.174-.238l-5.25-1.68a.25.25 0 0 0-.153 0ZM11.28 6.28l-3.5 3.5a.75.75 0 0 1-1.06 0l-1.5-1.5a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l.97.97 2.97-2.97a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="heart-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-heart"> <path d="m8 14.25.345.666a.75.75 0 0 1-.69 0l-.008-.004-.018-.01a7.152 7.152 0 0 1-.31-.17 22.055 22.055 0 0 1-3.434-2.414C2.045 10.731 0 8.35 0 5.5 0 2.836 2.086 1 4.25 1 5.797 1 7.153 1.802 8 3.02 8.847 1.802 10.203 1 11.75 1 13.914 1 16 2.836 16 5.5c0 2.85-2.045 5.231-3.885 6.818a22.066 22.066 0 0 1-3.744 2.584l-.018.01-.006.003h-.002ZM4.25 2.5c-1.336 0-2.75 1.164-2.75 3 0 2.15 1.58 4.144 3.365 5.682A20.58 20.58 0 0 0 8 13.393a20.58 20.58 0 0 0 3.135-2.211C12.92 9.644 14.5 7.65 14.5 5.5c0-1.836-1.414-3-2.75-3-1.373 0-2.609.986-3.029 2.456a.749.749 0 0 1-1.442 0C6.859 3.486 5.623 2.5 4.25 2.5Z"></path> </svg> </template> <template id="server-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-server"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v4c0 .372-.116.717-.314 1 .198.283.314.628.314 1v4a1.75 1.75 0 0 1-1.75 1.75H1.75A1.75 1.75 0 0 1 0 12.75v-4c0-.358.109-.707.314-1a1.739 1.739 0 0 1-.314-1v-4C0 1.784.784 1 1.75 1ZM1.5 2.75v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm.25 5.75a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25ZM7 4.75A.75.75 0 0 1 7.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5A.75.75 0 0 1 7 4.75ZM7.75 10h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM3 4.75A.75.75 0 0 1 3.75 4h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 4.75ZM3.75 10h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="globe-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-globe"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM5.78 8.75a9.64 9.64 0 0 0 1.363 4.177c.255.426.542.832.857 1.215.245-.296.551-.705.857-1.215A9.64 9.64 0 0 0 10.22 8.75Zm4.44-1.5a9.64 9.64 0 0 0-1.363-4.177c-.307-.51-.612-.919-.857-1.215a9.927 9.927 0 0 0-.857 1.215A9.64 9.64 0 0 0 5.78 7.25Zm-5.944 1.5H1.543a6.507 6.507 0 0 0 4.666 5.5c-.123-.181-.24-.365-.352-.552-.715-1.192-1.437-2.874-1.581-4.948Zm-2.733-1.5h2.733c.144-2.074.866-3.756 1.58-4.948.12-.197.237-.381.353-.552a6.507 6.507 0 0 0-4.666 5.5Zm10.181 1.5c-.144 2.074-.866 3.756-1.58 4.948-.12.197-.237.381-.353.552a6.507 6.507 0 0 0 4.666-5.5Zm2.733-1.5a6.507 6.507 0 0 0-4.666-5.5c.123.181.24.365.353.552.714 1.192 1.436 2.874 1.58 4.948Z"></path> </svg> </template> <template id="issue-opened-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </template> <template id="device-mobile-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-mobile"> <path d="M3.75 0h8.5C13.216 0 14 .784 14 1.75v12.5A1.75 1.75 0 0 1 12.25 16h-8.5A1.75 1.75 0 0 1 2 14.25V1.75C2 .784 2.784 0 3.75 0ZM3.5 1.75v12.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM8 13a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path> </svg> </template> <template id="package-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-package"> <path d="m8.878.392 5.25 3.045c.54.314.872.89.872 1.514v6.098a1.75 1.75 0 0 1-.872 1.514l-5.25 3.045a1.75 1.75 0 0 1-1.756 0l-5.25-3.045A1.75 1.75 0 0 1 1 11.049V4.951c0-.624.332-1.201.872-1.514L7.122.392a1.75 1.75 0 0 1 1.756 0ZM7.875 1.69l-4.63 2.685L8 7.133l4.755-2.758-4.63-2.685a.248.248 0 0 0-.25 0ZM2.5 5.677v5.372c0 .09.047.171.125.216l4.625 2.683V8.432Zm6.25 8.271 4.625-2.683a.25.25 0 0 0 .125-.216V5.677L8.75 8.432Z"></path> </svg> </template> <template id="credit-card-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-credit-card"> <path d="M10.75 9a.75.75 0 0 0 0 1.5h1.5a.75.75 0 0 0 0-1.5h-1.5Z"></path><path d="M0 3.75C0 2.784.784 2 1.75 2h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 14H1.75A1.75 1.75 0 0 1 0 12.25ZM14.5 6.5h-13v5.75c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25Zm0-2.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25V5h13Z"></path> </svg> </template> <template id="play-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </template> <template id="gift-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-gift"> <path d="M2 2.75A2.75 2.75 0 0 1 4.75 0c.983 0 1.873.42 2.57 1.232.268.318.497.668.68 1.042.183-.375.411-.725.68-1.044C9.376.42 10.266 0 11.25 0a2.75 2.75 0 0 1 2.45 4h.55c.966 0 1.75.784 1.75 1.75v2c0 .698-.409 1.301-1 1.582v4.918A1.75 1.75 0 0 1 13.25 16H2.75A1.75 1.75 0 0 1 1 14.25V9.332C.409 9.05 0 8.448 0 7.75v-2C0 4.784.784 4 1.75 4h.55c-.192-.375-.3-.8-.3-1.25ZM7.25 9.5H2.5v4.75c0 .138.112.25.25.25h4.5Zm1.5 0v5h4.5a.25.25 0 0 0 .25-.25V9.5Zm0-4V8h5.5a.25.25 0 0 0 .25-.25v-2a.25.25 0 0 0-.25-.25Zm-7 0a.25.25 0 0 0-.25.25v2c0 .138.112.25.25.25h5.5V5.5h-5.5Zm3-4a1.25 1.25 0 0 0 0 2.5h2.309c-.233-.818-.542-1.401-.878-1.793-.43-.502-.915-.707-1.431-.707ZM8.941 4h2.309a1.25 1.25 0 0 0 0-2.5c-.516 0-1 .205-1.43.707-.337.392-.646.975-.879 1.793Z"></path> </svg> </template> <template id="code-square-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-square"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25Zm7.47 3.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L10.69 8 9.22 6.53a.75.75 0 0 1 0-1.06ZM6.78 6.53 5.31 8l1.47 1.47a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="device-desktop-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-desktop"> <path d="M14.25 1c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 14.25 12h-3.727c.099 1.041.52 1.872 1.292 2.757A.752.752 0 0 1 11.25 16h-6.5a.75.75 0 0 1-.565-1.243c.772-.885 1.192-1.716 1.292-2.757H1.75A1.75 1.75 0 0 1 0 10.25v-7.5C0 1.784.784 1 1.75 1ZM1.75 2.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25ZM9.018 12H6.982a5.72 5.72 0 0 1-.765 2.5h3.566a5.72 5.72 0 0 1-.765-2.5Z"></path> </svg> </template> <div class="position-relative"> <ul role="listbox" class="ActionListWrap QueryBuilder-ListWrap" aria-label="Suggestions" data-action=" combobox-commit:query-builder#comboboxCommit mousedown:query-builder#resultsMousedown " data-target="query-builder.resultsList" data-persist-list=false id="query-builder-test-results" ></ul> </div> <div class="FormControl-inlineValidation" id="validation-df6cf187-12c8-4379-a88e-c497bccd6beb" hidden="hidden"> <span class="FormControl-inlineValidation--visual"> <svg aria-hidden="true" height="12" viewBox="0 0 12 12" version="1.1" width="12" data-view-component="true" class="octicon octicon-alert-fill"> <path d="M4.855.708c.5-.896 1.79-.896 2.29 0l4.675 8.351a1.312 1.312 0 0 1-1.146 1.954H1.33A1.313 1.313 0 0 1 .183 9.058ZM7 7V3H5v4Zm-1 3a1 1 0 1 0 0-2 1 1 0 0 0 0 2Z"></path> </svg> </span> <span></span> </div> </div> <div data-target="query-builder.screenReaderFeedback" aria-live="polite" aria-atomic="true" class="sr-only"></div> </query-builder></form> <div class="d-flex flex-row color-fg-muted px-3 text-small color-bg-default search-feedback-prompt"> <a target="_blank" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax" data-view-component="true" class="Link color-fg-accent text-normal ml-2"> Search syntax tips </a> <div class="d-flex flex-1"></div> </div> </div> </div> </div> </modal-dialog></div> </div> <div data-action="click:qbsearch-input#retract" class="dark-backdrop position-fixed" hidden data-target="qbsearch-input.darkBackdrop"></div> <div class="color-fg-default"> <dialog-helper> <dialog data-target="qbsearch-input.feedbackDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="feedback-dialog" aria-modal="true" aria-labelledby="feedback-dialog-title" aria-describedby="feedback-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="feedback-dialog-title"> Provide feedback </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="feedback-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="feedback-dialog-title"> <div data-view-component="true" class="Overlay-body"> </option></form><form id="code-search-feedback-form" data-turbo="false" action="/search/feedback" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="mBnv9eaRsAsWkNxKkgrF6ej5q2HQoYPdZv9U8yiN0yw2NprZgNINUpTUZr1KirauWkwKxXcCXJRTfAsEwLnJYA==" /> <p>We read every piece of feedback, and take your input very seriously.</p> <textarea name="feedback" class="form-control width-full mb-2" style="height: 120px" id="feedback"></textarea> <input name="include_email" id="include_email" aria-label="Include my email address so I can be contacted" class="form-control mr-2" type="checkbox"> <label for="include_email" style="font-weight: normal">Include my email address so I can be contacted</label> </form></div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd"> <button data-close-dialog-id="feedback-dialog" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="code-search-feedback-form" data-action="click:qbsearch-input#submitFeedback" type="submit" data-view-component="true" class="btn-primary btn"> Submit feedback </button> </div> </dialog></dialog-helper> <custom-scopes data-target="qbsearch-input.customScopesManager"> <dialog-helper> <dialog data-target="custom-scopes.customScopesModalDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="custom-scopes-dialog" aria-modal="true" aria-labelledby="custom-scopes-dialog-title" aria-describedby="custom-scopes-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header Overlay-header--divided"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="custom-scopes-dialog-title"> Saved searches </h1> <h2 id="custom-scopes-dialog-description" class="Overlay-description">Use saved searches to filter your results more quickly</h2> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="custom-scopes-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="custom-scopes-dialog-title"> <div data-view-component="true" class="Overlay-body"> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <div hidden class="create-custom-scope-form" data-target="custom-scopes.createCustomScopeForm"> </option></form><form id="custom-scopes-dialog-form" data-turbo="false" action="/search/custom_scopes" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="VufwL43/llrXmkCNxU2JpVDM+YzOOqB3gqBV4YqE8qCIqDZgDPubh3nc1xnebJ5gcYnbIeibnE9XIiHzl1QzlA==" /> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <input type="hidden" id="custom_scope_id" name="custom_scope_id" data-target="custom-scopes.customScopesIdField"> <div class="form-group"> <label for="custom_scope_name">Name</label> <auto-check src="/search/custom_scopes/check_name" required> <input type="text" name="custom_scope_name" id="custom_scope_name" data-target="custom-scopes.customScopesNameField" class="form-control" autocomplete="off" placeholder="github-ruby" required maxlength="50"> <input type="hidden" data-csrf="true" value="SdO/iabE+OAKVUFGBGZXxdz/FvcfxTbfv3XLRBIYYjJVyzKq70uxPQ/wI0cYQlR/6CbkSugIX2dPyP5stb1/mg==" /> </auto-check> </div> <div class="form-group"> <label for="custom_scope_query">Query</label> <input type="text" name="custom_scope_query" id="custom_scope_query" data-target="custom-scopes.customScopesQueryField" class="form-control" autocomplete="off" placeholder="(repo:mona/a OR repo:mona/b) AND lang:python" required maxlength="500"> </div> <p class="text-small color-fg-muted"> To see all available qualifiers, see our <a class="Link--inTextBlock" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax">documentation</a>. </p> </form> </div> <div data-target="custom-scopes.manageCustomScopesForm"> <div data-target="custom-scopes.list"></div> </div> </div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd Overlay-footer--divided"> <button data-action="click:custom-scopes#customScopesCancel" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="custom-scopes-dialog-form" data-action="click:custom-scopes#customScopesSubmit" data-target="custom-scopes.customScopesSubmitButton" type="submit" data-view-component="true" class="btn-primary btn"> Create saved search </button> </div> </dialog></dialog-helper> </custom-scopes> </div> </qbsearch-input> <div class="position-relative HeaderMenu-link-wrap d-lg-inline-block"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F19377" class="HeaderMenu-link HeaderMenu-link--sign-in HeaderMenu-button flex-shrink-0 no-underline d-none d-lg-inline-flex border border-lg-0 rounded rounded-lg-0 px-2 py-1" style="margin-left: 12px;" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="024b860bf7e8697f6fcefd460ac513dbcfba5c38a54267c8d9d80677268696c8" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> <a href="/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rails%2Frails" class="HeaderMenu-link HeaderMenu-link--sign-up HeaderMenu-button flex-shrink-0 d-flex d-lg-inline-flex no-underline border color-border-default rounded px-2 py-1" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="024b860bf7e8697f6fcefd460ac513dbcfba5c38a54267c8d9d80677268696c8" data-analytics-event="{"category":"Sign up","action":"click to sign up for account","label":"ref_page:/<user-name>/<repo-name>/voltron/pull_requests_fragments/pull_request_layout;ref_cta:Sign up;ref_loc:header logged out"}" > Sign up </a> <button type="button" class="sr-only js-header-menu-focus-trap d-block d-lg-none">Reseting focus</button> </div> </div> </div> </div> </header> <div hidden="hidden" data-view-component="true" class="js-stale-session-flash stale-session-flash flash flash-warn flash-full"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span class="js-stale-session-flash-signed-in" hidden>You signed in with another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-signed-out" hidden>You signed out in another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-switched" hidden>You switched accounts on another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <button id="icon-button-551bdd71-9e18-4f2a-9194-f8b2e1d2cd2d" aria-labelledby="tooltip-4ee8393e-37e3-4368-9a04-43160bea5768" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium flash-close js-flash-close"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x Button-visual"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button><tool-tip id="tooltip-4ee8393e-37e3-4368-9a04-43160bea5768" for="icon-button-551bdd71-9e18-4f2a-9194-f8b2e1d2cd2d" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Dismiss alert</tool-tip> </div> </div> <div id="start-of-content" class="show-on-focus"></div> <div id="js-flash-container" class="flash-container" data-turbo-replace> <template class="js-flash-template"> <div class="flash flash-full {{ className }}"> <div > <button autofocus class="flash-close js-flash-close" type="button" aria-label="Dismiss this message"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div aria-atomic="true" role="alert" class="js-flash-alert"> <div>{{ message }}</div> </div> </div> </div> </template> </div> <div class="application-main " data-commit-hovercards-enabled data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled > <div itemscope itemtype="http://schema.org/SoftwareSourceCode" class=""> <main id="js-repo-pjax-container" > <div id="repository-container-header" class="pt-3 hide-full-screen" style="background-color: var(--page-header-bgColor, var(--color-page-header-bg));" data-turbo-replace> <div class="d-flex flex-nowrap flex-justify-end mb-3 px-3 px-lg-5" style="gap: 1rem;"> <div class="flex-auto min-width-0 width-fit"> <div class=" d-flex flex-wrap flex-items-center wb-break-word f3 text-normal"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo color-fg-muted mr-2"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> <span class="author flex-self-stretch" itemprop="author"> <a class="url fn" rel="author" data-hovercard-type="organization" data-hovercard-url="/orgs/rails/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rails"> rails </a> </span> <span class="mx-1 flex-self-stretch color-fg-muted">/</span> <strong itemprop="name" class="mr-2 flex-self-stretch"> <a data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" href="/rails/rails">rails</a> </strong> <span></span><span class="Label Label--secondary v-align-middle mr-1">Public</span> </div> </div> <div id="repository-details-container" class="flex-shrink-0" data-turbo-replace style="max-width: 70%;"> <ul class="pagehead-actions flex-shrink-0 d-none d-md-inline" style="padding: 2px 0;"> <li> <a href="/login?return_to=%2Frails%2Frails" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="e78f91674176d922269f4a51fa89bf2b13be1b729a4d3a033e16180582e29c31" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bell mr-2"> <path d="M8 16a2 2 0 0 0 1.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 0 0 8 16ZM3 5a5 5 0 0 1 10 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.519 1.519 0 0 1 13.482 13H2.518a1.516 1.516 0 0 1-1.263-2.36l1.703-2.554A.255.255 0 0 0 3 7.947Zm5-3.5A3.5 3.5 0 0 0 4.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.017.017 0 0 0-.003.01l.001.006c0 .002.002.004.004.006l.006.004.007.001h10.964l.007-.001.006-.004.004-.006.001-.007a.017.017 0 0 0-.003-.01l-1.703-2.554a1.745 1.745 0 0 1-.294-.97V5A3.5 3.5 0 0 0 8 1.5Z"></path> </svg>Notifications </a> <tool-tip id="tooltip-e1bfc707-c661-4e20-a869-7188c93b063d" for="repository-details-watch-button" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be signed in to change notification settings</tool-tip> </li> <li> <a icon="repo-forked" id="fork-button" href="/login?return_to=%2Frails%2Frails" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"repo details fork button","repository_id":8514,"auth_type":"LOG_IN","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="ea3d234a9aa54680ed0b3912adc6ccb2d1d52d40dbb2a43a07bab1bf89e9c345" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-forked mr-2"> <path d="M5 5.372v.878c0 .414.336.75.75.75h4.5a.75.75 0 0 0 .75-.75v-.878a2.25 2.25 0 1 1 1.5 0v.878a2.25 2.25 0 0 1-2.25 2.25h-1.5v2.128a2.251 2.251 0 1 1-1.5 0V8.5h-1.5A2.25 2.25 0 0 1 3.5 6.25v-.878a2.25 2.25 0 1 1 1.5 0ZM5 3.25a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Zm6.75.75a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm-3 8.75a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Z"></path> </svg>Fork <span id="repo-network-counter" data-pjax-replace="true" data-turbo-replace="true" title="21,700" data-view-component="true" class="Counter">21.7k</span> </a> </li> <li> <div data-view-component="true" class="BtnGroup d-flex"> <a href="/login?return_to=%2Frails%2Frails" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"star button","repository_id":8514,"auth_type":"LOG_IN","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="7833c280ad3949ec1f5e4bca10c9aa4fdcbf955fde8911f1ca5659ef34d6a638" aria-label="You must be signed in to star a repository" data-view-component="true" class="tooltipped tooltipped-sw btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-star v-align-text-bottom d-inline-block mr-2"> <path d="M8 .25a.75.75 0 0 1 .673.418l1.882 3.815 4.21.612a.75.75 0 0 1 .416 1.279l-3.046 2.97.719 4.192a.751.751 0 0 1-1.088.791L8 12.347l-3.766 1.98a.75.75 0 0 1-1.088-.79l.72-4.194L.818 6.374a.75.75 0 0 1 .416-1.28l4.21-.611L7.327.668A.75.75 0 0 1 8 .25Zm0 2.445L6.615 5.5a.75.75 0 0 1-.564.41l-3.097.45 2.24 2.184a.75.75 0 0 1 .216.664l-.528 3.084 2.769-1.456a.75.75 0 0 1 .698 0l2.77 1.456-.53-3.084a.75.75 0 0 1 .216-.664l2.24-2.183-3.096-.45a.75.75 0 0 1-.564-.41L8 2.694Z"></path> </svg><span data-view-component="true" class="d-inline"> Star </span> <span id="repo-stars-counter-star" aria-label="56133 users starred this repository" data-singular-suffix="user starred this repository" data-plural-suffix="users starred this repository" data-turbo-replace="true" title="56,133" data-view-component="true" class="Counter js-social-count">56.1k</span> </a></div> </li> </ul> </div> </div> <div id="responsive-meta-container" data-turbo-replace> </div> <nav data-pjax="#js-repo-pjax-container" aria-label="Repository" data-view-component="true" class="js-repo-nav js-sidenav-container-pjax js-responsive-underlinenav overflow-hidden UnderlineNav px-3 px-md-4 px-lg-5"> <ul data-view-component="true" class="UnderlineNav-body list-style-none"> <li data-view-component="true" class="d-inline-flex"> <a id="code-tab" href="/rails/rails" data-tab-item="i0code-tab" data-selected-links="repo_source repo_downloads repo_commits repo_releases repo_tags repo_branches repo_packages repo_deployments repo_attestations /rails/rails" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g c" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Code","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code UnderlineNav-octicon d-none d-sm-inline"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> <span data-content="Code">Code</span> <span id="code-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="issues-tab" href="/rails/rails/issues" data-tab-item="i1issues-tab" data-selected-links="repo_issues repo_labels repo_milestones /rails/rails/issues" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g i" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Issues","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> <span data-content="Issues">Issues</span> <span id="issues-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="527" data-view-component="true" class="Counter">527</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="pull-requests-tab" href="/rails/rails/pulls" data-tab-item="i2pull-requests-tab" data-selected-links="repo_pulls checks /rails/rails/pulls" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g p" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Pull requests","target":"UNDERLINE_NAV.TAB"}" aria-current="page" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item selected"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> <span data-content="Pull requests">Pull requests</span> <span id="pull-requests-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="730" data-view-component="true" class="Counter">730</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="discussions-tab" href="/rails/rails/discussions" data-tab-item="i3discussions-tab" data-selected-links="repo_discussions /rails/rails/discussions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g g" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Discussions","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> <span data-content="Discussions">Discussions</span> <span id="discussions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="actions-tab" href="/rails/rails/actions" data-tab-item="i4actions-tab" data-selected-links="repo_actions /rails/rails/actions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g a" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Actions","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> <span data-content="Actions">Actions</span> <span id="actions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="security-tab" href="/rails/rails/security" data-tab-item="i5security-tab" data-selected-links="security overview alerts policy token_scanning code_scanning /rails/rails/security" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g s" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Security","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield UnderlineNav-octicon d-none d-sm-inline"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span data-content="Security">Security</span> <include-fragment src="/rails/rails/security/overall-count" accept="text/fragment+html"></include-fragment> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="insights-tab" href="/rails/rails/pulse" data-tab-item="i6insights-tab" data-selected-links="repo_graphs repo_contributors dependency_graph dependabot_updates pulse people community /rails/rails/pulse" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Insights","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> <span data-content="Insights">Insights</span> <span id="insights-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> </ul> <div style="visibility:hidden;" data-view-component="true" class="UnderlineNav-actions js-responsive-underlinenav-overflow position-absolute pr-3 pr-md-4 pr-lg-5 right-0"> <action-menu data-select-variant="none" data-view-component="true"> <focus-group direction="vertical" mnemonics retain> <button id="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-button" popovertarget="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-overlay" aria-controls="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-list" aria-haspopup="true" aria-labelledby="tooltip-6cf83ef3-bcb8-4db1-bc8a-5a377f01da5a" type="button" data-view-component="true" class="Button Button--iconOnly Button--secondary Button--medium UnderlineNav-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-6cf83ef3-bcb8-4db1-bc8a-5a377f01da5a" for="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-button" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Additional navigation options</tool-tip> <anchored-position id="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-overlay" anchor="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-button" align="start" side="outside-bottom" anchor-offset="normal" popover="auto" data-view-component="true"> <div data-view-component="true" class="Overlay Overlay--size-auto"> <div data-view-component="true" class="Overlay-body Overlay-body--paddingNone"> <action-list> <div data-view-component="true"> <ul aria-labelledby="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-button" id="action-menu-66bdd9d7-b43e-4315-a972-38178c014d5a-list" role="menu" data-view-component="true" class="ActionListWrap--inset ActionListWrap"> <li hidden="hidden" data-menu-item="i0code-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-efdceb4a-5749-4978-bd27-98c1a041893c" href="/rails/rails" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Code </span> </a> </li> <li hidden="hidden" data-menu-item="i1issues-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-79d6f5ad-b349-4dea-b6c2-3550ca819c7c" href="/rails/rails/issues" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Issues </span> </a> </li> <li hidden="hidden" data-menu-item="i2pull-requests-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-56da2745-5c65-4a80-b202-bdc9438cb7a2" href="/rails/rails/pulls" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Pull requests </span> </a> </li> <li hidden="hidden" data-menu-item="i3discussions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-15d97c48-a57a-447e-ade9-3d8deef6d595" href="/rails/rails/discussions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Discussions </span> </a> </li> <li hidden="hidden" data-menu-item="i4actions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-299620dc-d4a2-4b57-9229-895cb52ba30f" href="/rails/rails/actions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Actions </span> </a> </li> <li hidden="hidden" data-menu-item="i5security-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-7903e25c-8efd-4410-8664-083c94c9a1c3" href="/rails/rails/security" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Security </span> </a> </li> <li hidden="hidden" data-menu-item="i6insights-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-0f3f88b8-89e3-4ba1-8b7c-aaf9be4c3725" href="/rails/rails/pulse" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Insights </span> </a> </li> </ul> </div></action-list> </div> </div></anchored-position> </focus-group> </action-menu></div> </nav> </div> <turbo-frame id="repo-content-turbo-frame" target="_top" data-turbo-action="advance" class=""> <div id="repo-content-pjax-container" class="repository-content " > <div class="clearfix new-discussion-timeline js-check-all-container container-xl px-3 px-md-4 px-lg-5 mt-4" data-pjax="" data-turbo-frame=""> <div class="clearfix js-issues-results"> <div id="partial-discussion-header" class="gh-header mb-3 js-details-container Details js-socket-channel js-updatable-content pull request js-pull-header-details" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-url="/rails/rails/pull/19377/partials/title?sticky=true" data-channel-event-name="title_updated" data-pull-is-open="false" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE="> <div class="gh-header-show "> <div class="d-flex flex-column flex-md-row"> <div class="gh-header-actions mt-0 mb-3 mb-md-2 ml-1 flex-md-order-1 flex-shrink-0 d-flex flex-items-center gap-1"> <details class="details-reset details-overlay details-overlay-dark float-right" > <summary class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue </summary> <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast overflow-auto" aria-label="Sign up for GitHub"> <button aria-label="Close dialog" data-close-dialog="" type="button" data-view-component="true" class="Link--muted btn-link position-absolute p-4 right-0"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div class="d-flex flex-column p-4"> <div class="mt-3 mb-2 text-center"> <svg height="60" aria-hidden="true" viewBox="0 0 24 24" version="1.1" width="60" data-view-component="true" class="octicon octicon-comment-discussion color-fg-accent"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> </div> <div class="px-4"> <p class="text-center mb-4"> <strong>Have a question about this project?</strong> Sign up for a free GitHub account to open an issue and contact its maintainers and the community. </p> <div class="d-flex flex-items-center"> <a href="/signup?return_to=%2Frails%2Frails%2Fissues%2Fnew%2Fchoose" data-view-component="true" class="btn-primary btn mx-auto"> Sign up for GitHub </a> </div> <p class="mt-4 color-fg-muted text-center">By clicking “Sign up for GitHub”, you agree to our <a class="Link--inTextBlock" href="https://docs.github.com/terms" target="_blank">terms of service</a> and <a class="Link--inTextBlock" href="https://docs.github.com/privacy" target="_blank">privacy statement</a>. We’ll occasionally send you account related emails.</p> <p class="mt-4 color-fg-muted text-center"> Already on GitHub? <a data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"new issue modal","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="e72cf905573d06efa7405af67eaad5a8291f8473c9a8763cb94917cf22ffee5d" class="Link--inTextBlock" href="/login?return_to=%2Frails%2Frails%2Fissues%2Fnew%2Fchoose">Sign in</a> to your account </p> </div> </div> </details-dialog> </details> <div class="flex-auto text-right d-block d-md-none"> <a href="#issue-comment-box" class="py-1">Jump to bottom</a> </div> </div> <h1 class="gh-header-title mb-2 lh-condensed f1 mr-0 flex-auto wb-break-word"> <bdi class="js-issue-title markdown-title">when a template is missing for the default render, do head no_content instead</bdi> <span class="f1-light color-fg-muted">#19377</span> </h1> </div> </div> <div class="d-flex flex-items-center flex-wrap mt-0 gh-header-meta"> <div class="flex-shrink-0 mb-2 flex-self-start flex-md-self-center"> <span reviewable_state="ready" title="Status: Merged" data-view-component="true" class="State State--merged"> <svg height="16" class="octicon octicon-git-merge" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path d="M5.45 5.154A4.25 4.25 0 0 0 9.25 7.5h1.378a2.251 2.251 0 1 1 0 1.5H9.25A5.734 5.734 0 0 1 5 7.123v3.505a2.25 2.25 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.95-.218ZM4.25 13.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm8.5-4.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5ZM5 3.25a.75.75 0 1 0 0 .005V3.25Z"></path></svg> Merged </span> </div> <div class="flex-auto min-width-0 mb-2"> <a class="author Link--secondary text-bold css-truncate css-truncate-target expandable" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh">dhh</a> merged 1 commit into <span title="rails/rails:master" class="commit-ref css-truncate user-select-contain expandable "><a title="rails/rails:master" class="no-underline " href="/rails/rails/tree/master"><span class="css-truncate-target">rails</span>:<span class="css-truncate-target">master</span></a></span><span></span> from <span title="sb8244/rails:issue-19036" class="commit-ref css-truncate user-select-contain expandable head-ref"><a title="sb8244/rails:issue-19036" class="no-underline " href="/sb8244/rails/tree/issue-19036"><span class="css-truncate-target">sb8244</span>:<span class="css-truncate-target">issue-19036</span></a></span><span><span data-view-component="true"> <clipboard-copy aria-label="Copy" data-copy-feedback="Copied!" value="sb8244:issue-19036" data-view-component="true" class="Link--onHover js-copy-branch color-fg-muted d-inline-block ml-1"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg style="display: none;" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check color-fg-success"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span></span> <relative-time datetime="2015-04-06T10:40:02Z" class="no-wrap">Apr 6, 2015</relative-time> </div> </div> <div class="js-sticky js-sticky-offset-scroll top-0 gh-header-sticky"> <div class="sticky-content"> <div class="d-flex flex-items-center flex-justify-between mt-2"> <div class="d-flex flex-row flex-items-center min-width-0"> <div class="mr-2 mb-2 flex-shrink-0"> <span reviewable_state="ready" title="Status: Merged" data-view-component="true" class="State State--merged"> <svg height="16" class="octicon octicon-git-merge" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path d="M5.45 5.154A4.25 4.25 0 0 0 9.25 7.5h1.378a2.251 2.251 0 1 1 0 1.5H9.25A5.734 5.734 0 0 1 5 7.123v3.505a2.25 2.25 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.95-.218ZM4.25 13.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm8.5-4.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5ZM5 3.25a.75.75 0 1 0 0 .005V3.25Z"></path></svg> Merged </span> </div> <div class="min-width-0 mr-2 mb-2"> <h1 class="d-flex text-bold f5"> <a class="js-issue-title css-truncate css-truncate-target Link--primary width-fit markdown-title js-smoothscroll-anchor" href="#top"> when a template is missing for the default render, do head no_content instead </a> <span class="gh-header-number color-fg-muted pl-1">#19377</span> </h1> <div class="meta color-fg-muted css-truncate css-truncate-target d-block width-fit"> <a class="author Link--secondary text-bold css-truncate css-truncate-target expandable" data-hovercard-z-index-override="111" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh">dhh</a> merged 1 commit into <span title="rails/rails:master" class="commit-ref css-truncate user-select-contain expandable "><a title="rails/rails:master" class="no-underline " href="/rails/rails/tree/master"><span class="css-truncate-target">rails</span>:<span class="css-truncate-target">master</span></a></span><span></span> from <span title="sb8244/rails:issue-19036" class="commit-ref css-truncate user-select-contain expandable head-ref"><a title="sb8244/rails:issue-19036" class="no-underline " href="/sb8244/rails/tree/issue-19036"><span class="css-truncate-target">sb8244</span>:<span class="css-truncate-target">issue-19036</span></a></span><span><span data-view-component="true"> <clipboard-copy aria-label="Copy" data-copy-feedback="Copied!" value="sb8244:issue-19036" data-view-component="true" class="Link--onHover js-copy-branch color-fg-muted d-inline-block ml-1"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg style="display: none;" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check color-fg-success"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span></span> <relative-time datetime="2015-04-06T10:40:02Z" class="no-wrap">Apr 6, 2015</relative-time> </div> </div> </div> </div> </div> </div> <div class="gh-header-shadow color-shadow-small js-notification-shelf-offset-top"></div> </div> <div class="px-3 px-md-0 ml-n3 mr-n3 mx-md-0 tabnav"> <div class="tabnav-extra float-right d-none d-md-block"> <span class="diffstat" id="diffstat"> <span class="color-fg-success"> +31 </span> <span class="color-fg-danger"> −8 </span> <span> <span class="diffstat-block-added"></span><span class="diffstat-block-added"></span><span class="diffstat-block-added"></span><span class="diffstat-block-deleted"></span><span class="diffstat-block-neutral"></span> </span> </span> </div> <nav class="tabnav-tabs d-flex overflow-auto" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" aria-label="Pull request tabs"> <a href="/rails/rails/pull/19377" class="tabnav-tab flex-shrink-0 selected" aria-current="page"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion d-none d-md-inline-block"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> Conversation <span id="conversation_tab_counter" title="61" data-view-component="true" class="Counter">61</span> </a> <a href="/rails/rails/pull/19377/commits" class="tabnav-tab flex-shrink-0 " > <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit d-none d-md-inline-block"> <path d="M11.93 8.5a4.002 4.002 0 0 1-7.86 0H.75a.75.75 0 0 1 0-1.5h3.32a4.002 4.002 0 0 1 7.86 0h3.32a.75.75 0 0 1 0 1.5Zm-1.43-.75a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg> Commits <span id="commits_tab_counter" title="1" data-view-component="true" class="Counter js-updateable-pull-request-commits-count">1</span> </a> <a href="/rails/rails/pull/19377/checks" class="tabnav-tab flex-shrink-0 "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-checklist d-none d-md-inline-block"> <path d="M2.5 1.75v11.5c0 .138.112.25.25.25h3.17a.75.75 0 0 1 0 1.5H2.75A1.75 1.75 0 0 1 1 13.25V1.75C1 .784 1.784 0 2.75 0h8.5C12.216 0 13 .784 13 1.75v7.736a.75.75 0 0 1-1.5 0V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13.274 9.537v-.001l-4.557 4.45a.75.75 0 0 1-1.055-.008l-1.943-1.95a.75.75 0 0 1 1.062-1.058l1.419 1.425 4.026-3.932a.75.75 0 1 1 1.048 1.074ZM4.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM4 7.75A.75.75 0 0 1 4.75 7h2a.75.75 0 0 1 0 1.5h-2A.75.75 0 0 1 4 7.75Z"></path> </svg> Checks <span id="checks_tab_counter" title="0" data-view-component="true" class="Counter">0</span> </a> <a href="/rails/rails/pull/19377/files" class="tabnav-tab flex-shrink-0 "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-file-diff d-none d-md-inline-block"> <path d="M1 1.75C1 .784 1.784 0 2.75 0h7.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0 1 13.25 16H2.75A1.75 1.75 0 0 1 1 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h10.5a.25.25 0 0 0 .25-.25V4.664a.25.25 0 0 0-.073-.177l-2.914-2.914a.25.25 0 0 0-.177-.073ZM8 3.25a.75.75 0 0 1 .75.75v1.5h1.5a.75.75 0 0 1 0 1.5h-1.5v1.5a.75.75 0 0 1-1.5 0V7h-1.5a.75.75 0 0 1 0-1.5h1.5V4A.75.75 0 0 1 8 3.25Zm-3 8a.75.75 0 0 1 .75-.75h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1-.75-.75Z"></path> </svg> Files changed <span id="files_tab_counter" title="4" data-view-component="true" class="Counter">4</span> </a> </nav> </div> <div id="discussion_bucket" class="pull-request-tab-content is-visible js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxOnRpbWVsaW5lIiwidCI6MTczMjczNDkzMH0=--e40ecc24f13e23526fe9392f983779c4ea422e1bf16f34c6acf6f220ba579dc4"> <div data-view-component="true" class="Layout Layout--flowRow-until-md Layout--sidebarPosition-end Layout--sidebarPosition-flowRow-end"> <div data-view-component="true" class="Layout-main"> <h2 class="sr-only">Conversation</h2> <div class="pull-discussion-timeline js-pull-discussion-timeline js-quote-selection-container js-review-state-classes" data-quote-markdown=".js-comment-body" data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled data-team-hovercards-enabled data-hpc > <template class="js-file-alert-template"> <div data-view-component="true" class="flash flash-warn flash-full d-flex flex-items-center"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span> This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. <a class="Link--inTextBlock" href="https://github.co/hiddenchars" target="_blank">Learn more about bidirectional Unicode characters</a> </span> <div data-view-component="true" class="flash-action"> <a href="{{ revealButtonHref }}" data-view-component="true" class="btn-sm btn"> Show hidden characters </a> </div> </div></template> <template class="js-line-alert-template"> <span aria-label="This line has hidden Unicode characters" data-view-component="true" class="line-alert tooltipped tooltipped-e"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </span></template> <div class="js-discussion ml-0 pl-0 ml-md-6 pl-md-3" > <div class="TimelineItem TimelineItem--condensed pt-0 js-comment-container js-socket-channel js-updatable-content js-command-palette-pull-body" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/pull/19377/partials/body" data-channel-event-name="body_updated" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6"> <div data-view-component="true" class="TimelineItem ml-0 p-0"> <a href="/sb8244" data-view-component="true" class="TimelineItem-avatar avatar circle lh-0 Link"><img data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" src="https://avatars.githubusercontent.com/u/1231659?s=60&v=4" alt="sb8244" size="40" height="40" width="40" data-view-component="true" /></a> </div><div class= "timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0" id="issue-62416392"> <div id="pullrequest-31341031" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment editable-comment timeline-comment--caret reorderable-task-lists timeline-comment ml-n3 unminimized-comment"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issue-62416392-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/1231659?s=48&v=4" alt="@sb8244" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block d-md-none mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issue-62416392" id="issue-62416392-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T14:42:51Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div> <div class="edit-comment-hide"> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto"><span class="issue-keyword">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" href="https://github.com/rails/rails/issues/19036">#19036</a></p> <p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard?comment_id=82362962&comment_type=issue_comment" href="https://github.com/rails/rails/issues/19036#issuecomment-82362962">#19036 (comment)</a></p> <p dir="auto">I want to do a comparison like:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content=" def default_render(*args) if template_exists?(action, _prefixes) render(*args) else head :no_content end end"><pre class="notranslate"> <span class="pl-k">def</span> <span class="pl-en">default_render</span><span class="pl-kos">(</span>*<span class="pl-s1">args</span><span class="pl-kos">)</span> <span class="pl-k">if</span> <span class="pl-en">template_exists?</span><span class="pl-kos">(</span><span class="pl-en">action</span><span class="pl-kos">,</span> <span class="pl-en">_prefixes</span><span class="pl-kos">)</span> <span class="pl-en">render</span><span class="pl-kos">(</span>*<span class="pl-s1">args</span><span class="pl-kos">)</span> <span class="pl-k">else</span> <span class="pl-en">head</span> <span class="pl-pds">:no_content</span> <span class="pl-k">end</span> <span class="pl-k">end</span></pre></div> <p dir="auto">However, there is no way (that I know of) to access the action at this point, it is simply the method. I opted for rescuing <code class="notranslate">MissingTemplate</code> as an iteration 1 that I will look into refactoring. Ideally, the logic for rendering <code class="notranslate">default_render</code> vs <code class="notranslate">head :no_content</code> will happen in <code class="notranslate">ImplicitRender#send_action</code> and not in default_render.</p> </div> </task-lists> </div> </div> </option></form><form class="js-comment-update" id="issue-62416392-edit-form" data-type="json" data-turbo="false" action="/rails/rails/issues/19377" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="hrpsJ2skOkQXE9eYiqfusYOZ6xOpbZdGuxuKKrnIGtLF5OBaoDAn-j75G7BlToIHz9AFqJRFcgefLCSEGN0-_w" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/issues/19377/edit_form?textarea_id=issue-62416392-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="hMwr0igixf_ZFKWjkFnVrEeJwqf9DMRLApBaW3_RlJmcuR7dwnM14Wkf0FE41P404iehaMKCi98xg2JyMcXZhw" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE="> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> <div id="js-timeline-progressive-loader" data-timeline-item-src="rails/rails/timeline_focused_item?after_cursor=Y3Vyc29yOnYyOpPPAAABTIozmqABqTI3MzYzMzA3MQ%3D%3D&before_cursor=Y3Vyc29yOnYyOpPPAAABTI5Qy9ABqTI3NDAzMDU2NA%3D%3D&id=MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE%3D" ></div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjA3NTQyNjA6djI="> <div id="diff-for-comment-26578923" class="js-comment"> <div data-view-component="true" class="TimelineItem"> <img src="https://avatars.githubusercontent.com/u/1231659?s=60&v=4" alt="sb8244" size="40" height="40" width="40" data-view-component="true" class="TimelineItem-avatar avatar circle" /> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-eye"> <path d="M8 2c1.981 0 3.671.992 4.933 2.078 1.27 1.091 2.187 2.345 2.637 3.023a1.62 1.62 0 0 1 0 1.798c-.45.678-1.367 1.932-2.637 3.023C11.67 13.008 9.981 14 8 14c-1.981 0-3.671-.992-4.933-2.078C1.797 10.83.88 9.576.43 8.898a1.62 1.62 0 0 1 0-1.798c.45-.677 1.367-1.931 2.637-3.022C4.33 2.992 6.019 2 8 2ZM1.679 7.932a.12.12 0 0 0 0 .136c.411.622 1.241 1.75 2.366 2.717C5.176 11.758 6.527 12.5 8 12.5c1.473 0 2.825-.742 3.955-1.715 1.124-.967 1.954-2.096 2.366-2.717a.12.12 0 0 0 0-.136c-.412-.621-1.242-1.75-2.366-2.717C10.824 4.242 9.473 3.5 8 3.5c-1.473 0-2.825.742-3.955 1.715-1.124.967-1.954 2.096-2.366 2.717ZM8 10a2 2 0 1 1-.001-3.999A2 2 0 0 1 8 10Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> reviewed <a href="#discussion-diff-26578923" class="Link--secondary Link--inTextBlock"> <relative-time datetime="2015-03-17T14:50:04Z" class="no-wrap">Mar 17, 2015</relative-time> </a> <div class="float-right"> <a href="/rails/rails/pull/19377/files/cc9be3de97f06ed46fa8d23ca4d2f5d176bc6c43#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" data-view-component="true" class="btn-sm btn"> View reviewed changes </a> </div> </div> </div> <div data-view-component="true" class="TimelineItem pt-0"> <div data-view-component="true" class="TimelineItem-body ml-4 mt-0"> <turbo-frame id="review-thread-or-comment-id-20754260" target="_top"> <details open="open" data-resolved="false" data-view-component="true" class="review-thread-component js-comment-container js-resolvable-timeline-thread-container Details-element details-reset mb-3 border rounded-2"> <summary role="button" data-view-component="true" class="py-2 px-3 rounded-2 color-bg-subtle"> <div class="d-flex flex-items-center"> <span class="flex-auto mr-3 d-flex flex-items-center"> <a href="/rails/rails/pull/19377/files#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" class="text-mono text-small Link--primary wb-break-all mr-2">actionpack/lib/action_controller/metal/implicit_render.rb</a> </span> </div> </summary> <div data-view-component="true"> <div class="blob-wrapper border-bottom js-check-bidi"> <deferred-diff-lines class="awaiting-highlight" data-url="/rails/rails/pull/19377/review_thread_syntax_highlighted_diff_lines"> <input type="hidden" name="pull_request_review_thread_id" value="20754260" data-targets="deferred-diff-lines.inputs" autocomplete="off" /> <table class="diff-table tab-size js-diff-table" data-tab-size="8" data-paste-markdown-skip> <tr data-position="0"> <td class="blob-num blob-num-hunk non-expandable" data-line-number="..."></td> <td class="blob-num blob-num-hunk non-expandable" data-line-number="..."></td> <td class="blob-code blob-code-inner blob-code-hunk" colspan="2">@@ -8,6 +8,8 @@ def send_action(method, *args)</td> </tr> <tr> <td data-line-number="8" class="blob-num blob-num-context"></td> <td data-line-number="8" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"><br></span> </td> </tr> <tr> <td data-line-number="9" class="blob-num blob-num-context"></td> <td data-line-number="9" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> def default_render(*args)</span> </td> </tr> <tr> <td data-line-number="10" class="blob-num blob-num-context"></td> <td data-line-number="10" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> render(*args)</span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="11" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> rescue ActionView::MissingTemplate</span> </td> </tr> </table> </deferred-diff-lines></div> <div class="js-inline-comments-container"> <div class="js-line-comments js-suggested-changes-container js-suggested-changes-contents js-quote-selection-container" data-quote-markdown=".js-comment-body"> <div class="js-comments-holder" > <div id="discussion_r26578923" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r26578923-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/1231659?s=48&v=4" alt="@sb8244" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> <a href="#discussion_r26578923" id="discussion_r26578923-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T14:50:04Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/26578923/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="QWRPLycww4HLbt6G5gqAm7PodBWdzpagT-52Rto_F00J-ze5zzmIJJMLFXJpM_XVIPIKesP55AFBADxXSeyo-A" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">Concerns around this being slow / an exceptional state when it doesn't need to be. It should be once-per-request code path, and it was exceptional but being handled.</p> <p dir="auto">I'm happy to check if the template exists or not, just need to find out how to turn a method into the correct template name.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/26578923" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="HEI5jq_5sDfG2Y-bAEdHse6uCDvRrpA23fGIYVibh5Ka_wok4Mg-C5_sgszj9k0ZXcdXx6bnU1AZ2kg_hWezVQ" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/26578923/edit_form?textarea_id=discussion_r26578923-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="snvsaBmL86GfZbp0LimlSCGOsKw64fhGI7__2oAySlNuLNydZB5bBiqc0d5jOsGpurCTfrN7w7rgmK6pjA2A-A" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTc4OTIz"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> </div> </div> </details></turbo-frame> </div> </div></div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyMzk2MzY2"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyMzk2MzY2" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDgyMzk2MzY2/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/47848?s=80&u=41ccf0d1865a17f47d140f73a3293f1f3559fc0f&v=4" width="40" height="40" alt="@rafaelfranca" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-82396366"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="e62a22cfa3f2fefb393fbdddab78ff6eba3f785cf2ba1678f00886bb1fa18160"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-82396366-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user is a member of the rails organization." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Member</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca">rafaelfranca</a> </strong> commented <a href="#issuecomment-82396366" id="issuecomment-82396366-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T15:04:10Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <blockquote> <p dir="auto">Ideally, the logic for rendering default_render vs head :no_content will happen in ImplicitRender#send_action and not in default_render.</p> </blockquote> <p dir="auto">Yes, this is the best solution here. Lets split <code class="notranslate">default_render</code> in two methods, one that calls <code class="notranslate">render</code> if the template exists and other that call <code class="notranslate">head :no_content</code> if it doesn't.</p> <p dir="auto">Also it is missing a test for implicit render with non-defined actions.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="lPvqMZdHsFJcz3y61AbYoZlEyBopG7ENy8-scbffPZ1IrNrE6tIY9ek2FxCZFbxAAnrryKCBivEI6P0Cu-D3Ng" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDgyMzk2MzY2"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-82396366-edit-form" data-turbo="false" action="/rails/rails/issue_comments/82396366" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="zJ8KFHOTerM7IdVQ0+q8MGnalyZZ2quUmGjHywX3VrS6AaijNWItedncQoIF06015pCM3yWIbbKDFjtV26XN7w==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/82396366/edit_form?textarea_id=issuecomment-82396366-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOkxhYmVsZWRFdmVudDI1Njk3NDkyMg=="> <div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-256974922"> <div class="TimelineItem-badge "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-tag color-fg-inherit"> <path d="M1 7.775V2.75C1 1.784 1.784 1 2.75 1h5.025c.464 0 .91.184 1.238.513l6.25 6.25a1.75 1.75 0 0 1 0 2.474l-5.026 5.026a1.75 1.75 0 0 1-2.474 0l-6.25-6.25A1.752 1.752 0 0 1 1 7.775Zm1.5 0c0 .066.026.13.073.177l6.25 6.25a.25.25 0 0 0 .354 0l5.025-5.025a.25.25 0 0 0 0-.354l-6.25-6.25a.25.25 0 0 0-.177-.073H2.75a.25.25 0 0 0-.25.25ZM6 5a1 1 0 1 1 0 2 1 1 0 0 1 0-2Z"></path> </svg> </div> <div class="TimelineItem-body"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/47848?s=40&u=41ccf0d1865a17f47d140f73a3293f1f3559fc0f&v=4" width="20" height="20" alt="@rafaelfranca" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca">rafaelfranca</a> added the <a id="label-d6907d" href="/rails/rails/labels/actionview" data-name="actionview" style="--label-r:215;--label-g:225;--label-b:2;--label-h:62;--label-s:98;--label-l:44;" data-view-component="true" class="IssueLabel hx_IssueLabel d-inline-block v-align-middle"> actionview </a> label <a href="#event-256974922" class="Link--secondary"><relative-time datetime="2015-03-17T15:04:27Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyMzk2ODU0"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyMzk2ODU0" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDgyMzk2ODU0/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-82396854"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="2cfa2fcf8b8076da2c511acdf5cfd156d5f8f34ee83f2c40c8a874a690df27db"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-82396854-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-82396854" id="issuecomment-82396854-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T15:06:08Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rafaelfranca">@rafaelfranca</a> in send_action, how do you get access to the action_name from the method? I need this to do template_exists as the method/action_name may differ.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="w8TAHhY2zsL11lnei8Bs0APRqXCLo912AogOY0FLcZcfk_Dra6NmZUAvMnTG0wgxmO-KogI55orBr18QTXS7PA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDgyMzk2ODU0"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-82396854-edit-form" data-turbo="false" action="/rails/rails/issue_comments/82396854" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="ZaNlu1fSOdZiJ+dVAqvsoFy2ThrlyP7qZUmYMWoVs+4gQ45w6VvH+9bI+V7H+03ImB32UbHEYiDovkRLXHrT3Q==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/82396854/edit_form?textarea_id=issuecomment-82396854-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIwOkNyb3NzUmVmZXJlbmNlZEV2ZW50NTQ3NzI5MDE="> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=40&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="20" height="20" alt="@sb8244" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> mentioned this pull request <a class="Link--secondary" href="#ref-issue-58527495" > <relative-time datetime="2015-03-17T15:07:31Z" class="no-wrap">Mar 17, 2015</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-issue-58527495" > <a href="/rails/rails/issues/19036" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard"> Controller actions should default to head :ok if no template exists <span class="color-fg-muted text-normal" >#19036</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Closed" data-view-component="true" class="State State--merged State--small d-flex flex-items-center"> <svg aria-hidden="true" height="12" viewBox="0 0 16 16" version="1.1" width="12" data-view-component="true" class="octicon octicon-issue-closed flex-items-center mr-1"> <path d="M11.28 6.78a.75.75 0 0 0-1.06-1.06L7.25 8.69 5.78 7.22a.75.75 0 0 0-1.06 1.06l2 2a.75.75 0 0 0 1.06 0l3.5-3.5Z"></path><path d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0Zm-1.5 0a6.5 6.5 0 1 0-13 0 6.5 6.5 0 0 0 13 0Z"></path> </svg> Closed </span> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNDAwNzg4"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNDAwNzg4" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDgyNDAwNzg4/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/47848?s=80&u=41ccf0d1865a17f47d140f73a3293f1f3559fc0f&v=4" width="40" height="40" alt="@rafaelfranca" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-82400788"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="782c3886f1dd49d3d27f1ba912d686d06fd1903e6a22069785e45a9d2a196998"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-82400788-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user is a member of the rails organization." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Member</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca">rafaelfranca</a> </strong> commented <a href="#issuecomment-82400788" id="issuecomment-82400788-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T15:13:18Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">It will hardly differ. <code class="notranslate">method_name</code> is <code class="notranslate">action_name</code>, unless you don't have an action with that name and your controller responds to <code class="notranslate">action_missing</code>. If that is the case the <code class="notranslate">performed?</code> will return true since <code class="notranslate">action_missing</code> will set the response body and we will not call <code class="notranslate">default_render</code> anyway.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="v9jXEuBrkw82SEYZcPNQDGASwgrEo-yaIvz4ZY5MYCdjj-fnnf47qIOxLbM94DTt-yzh2E0512bh26kWgnOqjA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDgyNDAwNzg4"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-82400788-edit-form" data-turbo="false" action="/rails/rails/issue_comments/82400788" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="OtwZPjBRb/orOMyMhjCdezwhVWbaswt2Jaow9sBDiw2cu4azBFF2GTQzJSGcE1AKaMpdLZeRuUlYdrZLiX/kPA==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/82400788/edit_form?textarea_id=issuecomment-82400788-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNjQzMTM5"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNjQzMTM5" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDgyNjQzMTM5/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-82643139"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="94dc42e0b781bbc5a5c031a3112808c27907fc8c0bd8acc5fb688658b8be6d5d"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-82643139-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-82643139" id="issuecomment-82643139-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-17T23:42:42Z" class="no-wrap">Mar 17, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rafaelfranca">@rafaelfranca</a> I think that variants through off the <code class="notranslate">method_name</code> vs <code class="notranslate">action_name</code>. For example, this spec fails because it thinks a template does not exist and renders a <code class="notranslate">head :no_content</code> instead of the mobile variant.</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content=" def test_variant_with_implicit_rendering @request.variant = :mobile get :variant_with_implicit_rendering assert_equal "text/html", @response.content_type assert_equal "mobile", @response.body end"><pre class="notranslate"> <span class="pl-k">def</span> <span class="pl-en">test_variant_with_implicit_rendering</span> <span class="pl-c1">@request</span><span class="pl-kos">.</span><span class="pl-en">variant</span> <span class="pl-c1">=</span> <span class="pl-pds">:mobile</span> <span class="pl-en">get</span> <span class="pl-pds">:variant_with_implicit_rendering</span> <span class="pl-en">assert_equal</span> <span class="pl-s">"text/html"</span><span class="pl-kos">,</span> <span class="pl-c1">@response</span><span class="pl-kos">.</span><span class="pl-en">content_type</span> <span class="pl-en">assert_equal</span> <span class="pl-s">"mobile"</span><span class="pl-kos">,</span> <span class="pl-c1">@response</span><span class="pl-kos">.</span><span class="pl-en">body</span> <span class="pl-k">end</span></pre></div> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="EWIvB8IBX_bNjmzWJ8reWf3I69W43Gf2eNwUO7M-8MjNNR_yv5T3UXh3B3xq2bq4ZvbIBzFGXAq7-0VIvwE6Yw" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDgyNjQzMTM5"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-82643139-edit-form" data-turbo="false" action="/rails/rails/issue_comments/82643139" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="kqBwxVHzXRKN3N/Po8gmQxFR20OEvw3v3elIpxRkzLJ3iyeEfKZ2GidX+F8QP/wKaIuU/0Jm039k14EyiHnD7w==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/82643139/edit_form?textarea_id=issuecomment-82643139-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNjc3Mzg5"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDgyNjc3Mzg5" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDgyNjc3Mzg5/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-82677389"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="b35fffa60b0484439dfd6c73888a39407e7a8d5907be19afcd761519cdf3c7ee"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-82677389-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-82677389" id="issuecomment-82677389-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-03-18T01:48:27Z" class="no-wrap">Mar 18, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Looking into variant implicit rendering more. It looks like the default behavior is to render the variant name. I can not find where in actionpack or actionview this behavior is defined at.</p> <p dir="auto">Should the default for variants be to render the variant name, or head :no_content?</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="Cl42Ls0RQSJ4e_kTrLed9pgfKZVeYB1kfgmRpxFD3o3WCQbbsITphc2CkrnhpPkXAyEKR9f6Jpi9LsDUHXwUJg" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDgyNjc3Mzg5"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-82677389-edit-form" data-turbo="false" action="/rails/rails/issue_comments/82677389" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="IdBStJ5W9+5lVBgaF9HUmkpfMEuNhqgp/ZlW132mTfCUJy1IHDzmhRQj1eC3m/N3jJfI+MarAITeqZs11zFAbw==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/82677389/edit_form?textarea_id=issuecomment-82677389-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MDg0Mjc4"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MDg0Mjc4" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5MDg0Mjc4/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89084278"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="8cd0d9d3ae473a24ba0485414456ef5388969af20c49363b3c89ded7219dc5ea"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89084278-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89084278" id="issuecomment-89084278-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-02T23:55:01Z" class="no-wrap">Apr 2, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rafaelfranca">@rafaelfranca</a> do you have any feedback on how to approach the implicit variant rendering?</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="x12akRPey09YCfmhIgB-GGKeYVLoE4Sq05whNi6lvPobCqpkbktj6O3wkgtvExr5-aBCgGGJv1YQu3BFIpp2UQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5MDg0Mjc4"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89084278-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89084278" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="VWAhghDdr69DQ0x2iptM5y1b6UE6W99wyY2M0nq/mUIDTIFmK1N6KxQgTph6aIsnrXTLwRmI7bJp1/M4ks6nHw==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89084278/edit_form?textarea_id=issuecomment-89084278-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MzAyNDY2"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MzAyNDY2" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5MzAyNDY2/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89302466"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="6a0de582520732b050755728de9182d98ffbf052aceb531da4ea49c7a7ecb4b5"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89302466-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89302466" id="issuecomment-89302466-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-03T14:22:02Z" class="no-wrap">Apr 3, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sb8244">@sb8244</a> what does render the variant name mean? Can you show a code example?</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="Ie5XO1xLj1RXnhVSUJbAGCzZRXJyDZGkM9YOEPWxysL9uWfOId4n8-JnfvgdhaT5t-dmoPuXqljw8V9j-Y4AaQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5MzAyNDY2"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89302466-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89302466" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="TeFf25K5ZYGT1D6ccV6SSfpPmiM+CEiSxQjaKfR+O1c8mgcviKuLojm6xc5Po+AyyilOytrU/SXvWV3iQnyISw==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89302466/edit_form?textarea_id=issuecomment-89302466-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MzA2MDgy"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5MzA2MDgy" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5MzA2MDgy/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89306082"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="41ae0d120f3868427897adc54cf11b31a124f7fc9342e3c21f3ab3e2c09ba6e1"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89306082-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89306082" id="issuecomment-89306082-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-03T14:37:32Z" class="no-wrap">Apr 3, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Sure <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kaspth">@kaspth</a></p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content=" def test_variant_with_implicit_rendering @request.variant = :mobile get :variant_with_implicit_rendering assert_equal "text/html", @response.content_type assert_equal "mobile", @response.body end"><pre class="notranslate"> <span class="pl-k">def</span> <span class="pl-en">test_variant_with_implicit_rendering</span> <span class="pl-c1">@request</span><span class="pl-kos">.</span><span class="pl-en">variant</span> <span class="pl-c1">=</span> <span class="pl-pds">:mobile</span> <span class="pl-en">get</span> <span class="pl-pds">:variant_with_implicit_rendering</span> <span class="pl-en">assert_equal</span> <span class="pl-s">"text/html"</span><span class="pl-kos">,</span> <span class="pl-c1">@response</span><span class="pl-kos">.</span><span class="pl-en">content_type</span> <span class="pl-en">assert_equal</span> <span class="pl-s">"mobile"</span><span class="pl-kos">,</span> <span class="pl-c1">@response</span><span class="pl-kos">.</span><span class="pl-en">body</span> <span class="pl-k">end</span></pre></div> <p dir="auto">This test is expecting that the behavior of an implicit rendering of a variant is the variant name. However, it seems like this behavior is going to change based on this PR, so that the default behavior is a <code class="notranslate">HEAD no-content</code>.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="-SITXpMHQUbVJFgrOkTiKLsHppZxNbunu-VfaCxAcdAldSOr7pLp4WDdM4F3V4bJIDmFRPivgFt4wg4bIH-7ew" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5MzA2MDgy"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89306082-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89306082" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="q31dAcpXedTF6FBENmrx2E8myi49ZQksx7mKRBeU4EIxjEcH74Sa671ACELM+ZUjpK6iL8FymPDVfOubPT/jfA==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89306082/edit_form?textarea_id=issuecomment-89306082-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjA3NTQyNjI6djI="> <div id="diff-for-comment-27772234" class="js-comment"> <div data-view-component="true" class="TimelineItem"> <img src="https://avatars.githubusercontent.com/u/350807?s=60&v=4" alt="kaspth" size="40" height="40" width="40" data-view-component="true" class="TimelineItem-avatar avatar circle" /> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-eye"> <path d="M8 2c1.981 0 3.671.992 4.933 2.078 1.27 1.091 2.187 2.345 2.637 3.023a1.62 1.62 0 0 1 0 1.798c-.45.678-1.367 1.932-2.637 3.023C11.67 13.008 9.981 14 8 14c-1.981 0-3.671-.992-4.933-2.078C1.797 10.83.88 9.576.43 8.898a1.62 1.62 0 0 1 0-1.798c.45-.677 1.367-1.931 2.637-3.022C4.33 2.992 6.019 2 8 2ZM1.679 7.932a.12.12 0 0 0 0 .136c.411.622 1.241 1.75 2.366 2.717C5.176 11.758 6.527 12.5 8 12.5c1.473 0 2.825-.742 3.955-1.715 1.124-.967 1.954-2.096 2.366-2.717a.12.12 0 0 0 0-.136c-.412-.621-1.242-1.75-2.366-2.717C10.824 4.242 9.473 3.5 8 3.5c-1.473 0-2.825.742-3.955 1.715-1.124.967-1.954 2.096-2.366 2.717ZM8 10a2 2 0 1 1-.001-3.999A2 2 0 0 1 8 10Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> reviewed <a href="#discussion-diff-27772234" class="Link--secondary Link--inTextBlock"> <relative-time datetime="2015-04-04T21:24:11Z" class="no-wrap">Apr 4, 2015</relative-time> </a> <div class="float-right"> <a href="/rails/rails/pull/19377/files/c9e9023625218a7f2dfbf5d8edfb0c5ee0c49e23#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" data-view-component="true" class="btn-sm btn"> View reviewed changes </a> </div> </div> </div> <div data-view-component="true" class="TimelineItem pt-0"> <div data-view-component="true" class="TimelineItem-body ml-4 mt-0"> <turbo-frame id="review-thread-or-comment-id-20754262" target="_top"> <details open="open" data-resolved="false" data-view-component="true" class="review-thread-component js-comment-container js-resolvable-timeline-thread-container Details-element details-reset mb-3 border rounded-2"> <summary role="button" data-view-component="true" class="py-2 px-3 rounded-2 color-bg-subtle"> <div class="d-flex flex-items-center"> <span class="flex-auto mr-3 d-flex flex-items-center"> <a href="/rails/rails/pull/19377/files#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" class="text-mono text-small Link--primary wb-break-all mr-2">actionpack/lib/action_controller/metal/implicit_render.rb</a> </span> </div> </summary> <div data-view-component="true"> <div class="blob-wrapper border-bottom js-check-bidi"> <deferred-diff-lines class="awaiting-highlight" data-url="/rails/rails/pull/19377/review_thread_syntax_highlighted_diff_lines"> <input type="hidden" name="pull_request_review_thread_id" value="20754262" data-targets="deferred-diff-lines.inputs" autocomplete="off" /> <table class="diff-table tab-size js-diff-table" data-tab-size="8" data-paste-markdown-skip> <tr> <td data-line-number="6" class="blob-num blob-num-deletion"></td> <td class="blob-num blob-num-deletion empty-cell"></td> <td class="blob-code blob-code-deletion"> <span class="blob-code-inner blob-code-marker-deletion"> ret</span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="5" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> return ret if performed?</span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="6" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"><br></span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="7" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> if template_exists?(method, _prefixes)</span> </td> </tr> </table> </deferred-diff-lines></div> <div class="js-inline-comments-container"> <div class="js-line-comments js-suggested-changes-container js-suggested-changes-contents js-quote-selection-container" data-quote-markdown=".js-comment-body"> <div class="js-comments-holder" > <div id="discussion_r27772234" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27772234-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/350807?s=48&v=4" alt="@kaspth" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> <a href="#discussion_r27772234" id="discussion_r27772234-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-04T21:24:11Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27772234/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="n9fNa5dJ2dFzOM8WFwMINVPfd0o9ztObKLTvB1Av1y7LDKu-AcLtkF7iIZJ8aOBdM-BJLbQIv0ihpE779KBW4w" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">Because of this do we still need <code class="notranslate">method_for_action</code> down below?</p> <p dir="auto">Alternatively, we might be able to implement this as:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content="def default_head(*) logger.info "No template found for #{self.class.name}#{action_name}, rendering head :no_content" head :no_content end def method_for_action(action_name) if method = super method elsif template_exists?(action_name.to_s, _prefixes) "default_render" else "default_head" end end"><pre class="notranslate"><span class="pl-k">def</span> <span class="pl-en">default_head</span><span class="pl-kos">(</span>*<span class="pl-kos">)</span> <span class="pl-en">logger</span><span class="pl-kos">.</span><span class="pl-en">info</span> <span class="pl-s">"No template found for <span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-smi">self</span><span class="pl-kos">.</span><span class="pl-en">class</span><span class="pl-kos">.</span><span class="pl-en">name</span><span class="pl-kos">}</span></span><span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-en">action_name</span><span class="pl-kos">}</span></span>, rendering head :no_content"</span> <span class="pl-en">head</span> <span class="pl-pds">:no_content</span> <span class="pl-k">end</span> <span class="pl-k">def</span> <span class="pl-en">method_for_action</span><span class="pl-kos">(</span><span class="pl-s1">action_name</span><span class="pl-kos">)</span> <span class="pl-k">if</span> <span class="pl-s1">method</span> <span class="pl-c1">=</span> <span class="pl-smi">super</span> <span class="pl-s1">method</span> <span class="pl-k">elsif</span> <span class="pl-en">template_exists?</span><span class="pl-kos">(</span><span class="pl-s1">action_name</span><span class="pl-kos">.</span><span class="pl-en">to_s</span><span class="pl-kos">,</span> <span class="pl-en">_prefixes</span><span class="pl-kos">)</span> <span class="pl-s">"default_render"</span> <span class="pl-k">else</span> <span class="pl-s">"default_head"</span> <span class="pl-k">end</span> <span class="pl-k">end</span></pre></div> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27772234" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="-lQdfkuiObAQq2zWuqNxFYi49eMuPno953oSfngIr6IfVuc1QQ_Br0uDvQA1gsAXL5fAS3BZSDYSzdbK36WwPA" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27772234/edit_form?textarea_id=discussion_r27772234-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="fiQEzESuvul1bhAoELRNCwQAdXKCPYzwDpZKEMDrinmiczQ5OTsWTsCXe4Jdpynqnz5WoAuntwzNsRtjzNRA0g" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzcyMjM0"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> <div id="discussion_r27777921" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27777921-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/1231659?s=48&v=4" alt="@sb8244" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> <a href="#discussion_r27777921" id="discussion_r27777921-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:59:14Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777921/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="pG-xVI-GkRDMDkDImIHXhTxDnYSWG6PbjAi9GaZtaHCOrzR-ucOJLGHZLovXd_M9Czdu2Rx-2vcgCINdjSsRRg" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto"><code class="notranslate">method_for_action</code> is important when you are rendering a method that doesn't exist (super is nil in that case). Implementing it like you proposed is how it should be handled, although template_exists? is not picking up variants correctly here as well as in <code class="notranslate">send_action</code>.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777921" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="MdVKwblF5Jg5cIVwVxZxliEIN5Vj493yewiaeX5RJVGVNz-K7gYgm72qviUwGyb8hivmDL8NHxv-zDaTTzY5Yw" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27777921/edit_form?textarea_id=discussion_r27777921-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="E6vUmUqJH1XLVPudTDThMVIYyBKPbUlenYLZ7R18MyPP_ORsNxy38n6tkDcBJ4XQySbrwAb3cqJepYieEUP5iA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc3OTIx"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> <div id="discussion_r27777955" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27777955-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/1231659?s=48&v=4" alt="@sb8244" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> <a href="#discussion_r27777955" id="discussion_r27777955-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T15:06:07Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777955/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="peCiWQiA8tBTnJWiuENodw5p0RRi7TllBkDbGqAsCxN8WY0ty-Fi3gfhpbCYZbp7Ckjni84K6CmMgTReLsPqfg" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">I propose as leaving <code class="notranslate">method_for_action</code> alone. The current method body is:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content=" def method_for_action(action_name) super || if template_exists?(action_name.to_s, _prefixes) "default_render" end end"><pre class="notranslate"> <span class="pl-k">def</span> <span class="pl-en">method_for_action</span><span class="pl-kos">(</span><span class="pl-s1">action_name</span><span class="pl-kos">)</span> <span class="pl-smi">super</span> || <span class="pl-k">if</span> <span class="pl-en">template_exists?</span><span class="pl-kos">(</span><span class="pl-s1">action_name</span><span class="pl-kos">.</span><span class="pl-en">to_s</span><span class="pl-kos">,</span> <span class="pl-en">_prefixes</span><span class="pl-kos">)</span> <span class="pl-s">"default_render"</span> <span class="pl-k">end</span> <span class="pl-k">end</span></pre></div> <p dir="auto">The reason I say this is that the default behavior of <code class="notranslate">default_head</code> should apply when there is a valid method that doesn't call render but not in the case of there being no method at all. This could lead to more complex errors such as getting <code class="notranslate">head :no_content</code> that doesn't seem to apply to a method.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777955" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="NpTwIg3vCzyBAP_zeJRrHRjz8SjGZXyjw4hTSIOKjckjisVJw4Sc4PcC0rFWMrmRRDE8daybMsIcMQSLTbNaIA" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27777955/edit_form?textarea_id=discussion_r27777955-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="zyejyOKBj-IDEgUldI1fOKgf3a-t74ip4WGeOmHul9oTcJM9nxQnRbbrbo85njvZMyH-fSR1s1UiRs9JbdFdcQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc3OTU1"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> </div> </div> </details></turbo-frame> </div> </div></div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjY5NTI0"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjY5NTI0" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5NjY5NTI0/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89669524"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="c04858b032d2a5286e8436ead5095efc7f252a4ad0c42881a122ee1bc55f53fe"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89669524-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89669524" id="issuecomment-89669524-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-04T21:24:17Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Ah, I see where I went astray. The default render for variants just renders the correct template, say <code class="notranslate">show.html+mobile.erb</code>.</p> <p dir="auto">That's why you can't find any rendering of the variant name defined in Action Pack or Action View. The reason you're seeing <code class="notranslate">assert_equal "mobile", @response.body</code> in the test, is that the template rendered by the test only contains the word "mobile". You can see it here: <a href="https://github.com/sb8244/rails/blob/issue-19036/actionpack/test/fixtures/respond_to/variant_with_implicit_rendering.html%2Bmobile.erb">https://github.com/sb8244/rails/blob/issue-19036/actionpack/test/fixtures/respond_to/variant_with_implicit_rendering.html%2Bmobile.erb</a></p> <p dir="auto">To answer your question <code class="notranslate">head :no_content</code> is what we want.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="nrXrcD-iyhlIJwexLwT02b6LbSMZcgF8fqJ6JrzhqotC4tuFQjdivv3ebBtiF5A4JbVO8ZDoOoC9hStVsN5gIA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5NjY5NTI0"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89669524-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89669524" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="QnDq4g5EXieVTuJj4X4Xi64V1ZzgLE9Ru5yIRFz/gLy6ZtdmA57QAwZPkdi/51QR1hcHZGyPe+JCFQTU9Qducg==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89669524/edit_form?textarea_id=issuecomment-89669524-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjA3NTQyNjM6djI="> <div id="diff-for-comment-27772257" class="js-comment"> <div data-view-component="true" class="TimelineItem"> <img src="https://avatars.githubusercontent.com/u/350807?s=60&v=4" alt="kaspth" size="40" height="40" width="40" data-view-component="true" class="TimelineItem-avatar avatar circle" /> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-eye"> <path d="M8 2c1.981 0 3.671.992 4.933 2.078 1.27 1.091 2.187 2.345 2.637 3.023a1.62 1.62 0 0 1 0 1.798c-.45.678-1.367 1.932-2.637 3.023C11.67 13.008 9.981 14 8 14c-1.981 0-3.671-.992-4.933-2.078C1.797 10.83.88 9.576.43 8.898a1.62 1.62 0 0 1 0-1.798c.45-.677 1.367-1.931 2.637-3.022C4.33 2.992 6.019 2 8 2ZM1.679 7.932a.12.12 0 0 0 0 .136c.411.622 1.241 1.75 2.366 2.717C5.176 11.758 6.527 12.5 8 12.5c1.473 0 2.825-.742 3.955-1.715 1.124-.967 1.954-2.096 2.366-2.717a.12.12 0 0 0 0-.136c-.412-.621-1.242-1.75-2.366-2.717C10.824 4.242 9.473 3.5 8 3.5c-1.473 0-2.825.742-3.955 1.715-1.124.967-1.954 2.096-2.366 2.717ZM8 10a2 2 0 1 1-.001-3.999A2 2 0 0 1 8 10Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> reviewed <a href="#discussion-diff-27772257" class="Link--secondary Link--inTextBlock"> <relative-time datetime="2015-04-04T21:26:47Z" class="no-wrap">Apr 4, 2015</relative-time> </a> <div class="float-right"> <a href="/rails/rails/pull/19377/files/c9e9023625218a7f2dfbf5d8edfb0c5ee0c49e23#diff-9ef8aebe4c9fbca2848a09a472aa01e96ce9da701de826a0cb9e90497a538f2f" data-view-component="true" class="btn-sm btn"> View reviewed changes </a> </div> </div> </div> <div data-view-component="true" class="TimelineItem pt-0"> <div data-view-component="true" class="TimelineItem-body ml-4 mt-0"> <turbo-frame id="review-thread-or-comment-id-20754263" target="_top"> <details open="open" data-resolved="false" data-view-component="true" class="review-thread-component js-comment-container js-resolvable-timeline-thread-container Details-element details-reset mb-3 border rounded-2"> <summary role="button" data-view-component="true" class="py-2 px-3 rounded-2 color-bg-subtle"> <div class="d-flex flex-items-center"> <span class="flex-auto mr-3 d-flex flex-items-center"> <a href="/rails/rails/pull/19377/files#diff-9ef8aebe4c9fbca2848a09a472aa01e96ce9da701de826a0cb9e90497a538f2f" class="text-mono text-small Link--primary wb-break-all mr-2">actionpack/test/controller/mime/respond_to_test.rb</a> </span> </div> </summary> <div data-view-component="true"> <div class="blob-wrapper border-bottom js-check-bidi"> <deferred-diff-lines class="awaiting-highlight" data-url="/rails/rails/pull/19377/review_thread_syntax_highlighted_diff_lines"> <input type="hidden" name="pull_request_review_thread_id" value="20754263" data-targets="deferred-diff-lines.inputs" autocomplete="off" /> <table class="diff-table tab-size js-diff-table" data-tab-size="8" data-paste-markdown-skip> <tr data-position="0"> <td class="blob-num blob-num-hunk non-expandable" data-line-number="..."></td> <td class="blob-num blob-num-hunk non-expandable" data-line-number="..."></td> <td class="blob-code blob-code-inner blob-code-hunk" colspan="2">@@ -608,16 +608,20 @@ def test_invalid_format</td> </tr> <tr> <td data-line-number="608" class="blob-num blob-num-context"></td> <td data-line-number="608" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> end</span> </td> </tr> <tr> <td data-line-number="609" class="blob-num blob-num-context"></td> <td data-line-number="609" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"><br></span> </td> </tr> <tr> <td data-line-number="610" class="blob-num blob-num-context"></td> <td data-line-number="610" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> def test_invalid_variant</span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="611" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> logger = ActiveSupport::LogSubscriber::TestHelper::MockLogger.new</span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="612" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> ActionController::Base.logger = logger</span> </td> </tr> </table> </deferred-diff-lines></div> <div class="js-inline-comments-container"> <div class="js-line-comments js-suggested-changes-container js-suggested-changes-contents js-quote-selection-container" data-quote-markdown=".js-comment-body"> <div class="js-comments-holder" > <div id="discussion_r27772257" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27772257-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/350807?s=48&v=4" alt="@kaspth" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> <a href="#discussion_r27772257" id="discussion_r27772257-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-04T21:26:47Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27772257/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="X6yNQYh2a9fpjR2YEXWBdJOkyHn-5VKYjGTZDeEMz6IrqsP1JbJ8VJjivCgxZsqHhdbmyvrpQFwEcsn8-jVMRw" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">This test overwrites the logger, which will leek into other tests. You have to capture the original value and then set it again after the tests:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content="def test_invalid_variant logger = ActiveSupport::LogSubscriber::TestHelper::MockLogger.new old_logger, ActionController::Base.logger = ActionController::Base.logger, logger # tests... ensure ActionController::Base.logger = old_logger end"><pre class="notranslate"><span class="pl-k">def</span> <span class="pl-en">test_invalid_variant</span> <span class="pl-s1">logger</span> <span class="pl-c1">=</span> <span class="pl-v">ActiveSupport</span>::<span class="pl-v">LogSubscriber</span>::<span class="pl-v">TestHelper</span>::<span class="pl-v">MockLogger</span><span class="pl-kos">.</span><span class="pl-en">new</span> <span class="pl-s1">old_logger</span><span class="pl-kos">,</span> <span class="pl-v">ActionController</span>::<span class="pl-v">Base</span><span class="pl-kos">.</span><span class="pl-s1">logger</span> <span class="pl-c1">=</span> <span class="pl-v">ActionController</span>::<span class="pl-v">Base</span><span class="pl-kos">.</span><span class="pl-s1">logger</span><span class="pl-kos">,</span> <span class="pl-s1">logger</span> <span class="pl-c"># tests...</span> <span class="pl-k">ensure</span> <span class="pl-v">ActionController</span>::<span class="pl-v">Base</span><span class="pl-kos">.</span><span class="pl-s1">logger</span> <span class="pl-c1">=</span> <span class="pl-s1">old_logger</span> <span class="pl-k">end</span></pre></div> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27772257" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="Lo4XIcFpXIzhnGN-LNvtqL9s4a8ah6Pg6mhkyc1jIrSHSu126ObtVEJeDV77YpCAQFC3G3tmg29lYuq0Yo2vPg" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27772257/edit_form?textarea_id=discussion_r27772257-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="9zDbuLSHeB-TbpHz-S7YIZdbzKsN0LxlP4zoiPC3rCErZ-tNyRLQuCaX-lm0PbzADGXveYRKh5n8q7n7_Ihmig" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzcyMjU3"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> </div> </div> </details></turbo-frame> </div> </div></div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjcwMDg4"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjcwMDg4" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5NjcwMDg4/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89670088"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="d92fa7a41ae41519312752ffabb44e2530845c7c13b83c4df0be698e8adaa2de"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89670088-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89670088" id="issuecomment-89670088-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-04T21:33:10Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sb8244">@sb8244</a> Left a few notes. We also need an entry at the top of Action Pack's CHANGELOG.md file. Finally squash all your commits into one.</p> <p dir="auto">Once those things have been addressed, we should be good to go, 👍.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="jpoMrQCVa2V_dyTooDI3f_IqSDa3rkHRdfULPYLimQZSzTxYfQDDwsqOT0LtIVOeaRRr5D40ei220lpOjt1TrQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5NjcwMDg4"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89670088-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89670088" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="ECFiusvDoygKDW0QSqnNiHwD69lr2B7A+WvNR5ycQqHvbe8RC8Ad6hZQdOcxQUAzD9RvKIn3Q80kZrf9vWyGqA==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89670088/edit_form?textarea_id=issuecomment-89670088-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOkxhYmVsZWRFdmVudDI3MzQyNTgyNA=="> <div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-273425824"> <div class="TimelineItem-badge "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-tag color-fg-inherit"> <path d="M1 7.775V2.75C1 1.784 1.784 1 2.75 1h5.025c.464 0 .91.184 1.238.513l6.25 6.25a1.75 1.75 0 0 1 0 2.474l-5.026 5.026a1.75 1.75 0 0 1-2.474 0l-6.25-6.25A1.752 1.752 0 0 1 1 7.775Zm1.5 0c0 .066.026.13.073.177l6.25 6.25a.25.25 0 0 0 .354 0l5.025-5.025a.25.25 0 0 0 0-.354l-6.25-6.25a.25.25 0 0 0-.177-.073H2.75a.25.25 0 0 0-.25.25ZM6 5a1 1 0 1 1 0 2 1 1 0 0 1 0-2Z"></path> </svg> </div> <div class="TimelineItem-body"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=40&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="20" height="20" alt="@kaspth" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> added <a id="label-1797cf" href="/rails/rails/labels/actionpack" data-name="actionpack" style="--label-r:255;--label-g:247;--label-b:0;--label-h:58;--label-s:100;--label-l:50;" data-view-component="true" class="IssueLabel hx_IssueLabel d-inline-block v-align-middle"> actionpack </a> and removed <a id="label-8ea5c5" href="/rails/rails/labels/actionview" data-name="actionview" style="--label-r:215;--label-g:225;--label-b:2;--label-h:62;--label-s:98;--label-l:44;" data-view-component="true" class="IssueLabel hx_IssueLabel d-inline-block v-align-middle"> actionview </a> labels <a href="#event-273425824" class="Link--secondary"><relative-time datetime="2015-04-04T21:33:26Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </div> <div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-273425840"> <div class="TimelineItem-badge "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-milestone color-fg-inherit"> <path d="M7.75 0a.75.75 0 0 1 .75.75V3h3.634c.414 0 .814.147 1.13.414l2.07 1.75a1.75 1.75 0 0 1 0 2.672l-2.07 1.75a1.75 1.75 0 0 1-1.13.414H8.5v5.25a.75.75 0 0 1-1.5 0V10H2.75A1.75 1.75 0 0 1 1 8.25v-3.5C1 3.784 1.784 3 2.75 3H7V.75A.75.75 0 0 1 7.75 0Zm4.384 8.5a.25.25 0 0 0 .161-.06l2.07-1.75a.248.248 0 0 0 0-.38l-2.07-1.75a.25.25 0 0 0-.161-.06H2.75a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h9.384Z"></path> </svg> </div> <div class="TimelineItem-body"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=40&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="20" height="20" alt="@kaspth" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> added this to the <a href="/rails/rails/milestone/47" class="Link--primary text-bold">5.0.0</a> milestone <a href="#event-273425840" class="Link--secondary"><relative-time datetime="2015-04-04T21:33:33Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjcwMTgx"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NjcwMTgx" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5NjcwMTgx/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89670181"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="165e7a178a2fa7e81890778b8494244c3b5d2dac99ca9277e7099eee42e34902"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89670181-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89670181" id="issuecomment-89670181-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-04T21:35:50Z" class="no-wrap">Apr 4, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rafaelfranca">@rafaelfranca</a> do we need a deprecation warning for this too or an upgrade flag (raise instead of no content)?</p> <p dir="auto">We might even be able to remove the missing template error completely.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="gSsnopNkhzyO55kI94kpiMcNoIIhA7RiW5F4AkTvN_9dfBdX7vEvmzse8qK6mk1pXDODUKiZj56YtilxSND9VA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5NjcwMTgx"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89670181-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89670181" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="OtWnn06cLxZfdrrJeE9sl2JilY2ErdrsffeMua9UVuujKYcE3cGasNbtbtU7PngPridzE3HoCjOA0VgdRCX9lQ==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89670181/edit_form?textarea_id=issuecomment-89670181-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NzcwNjE2"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NzcwNjE2" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5NzcwNjE2/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89770616"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="943c32abb9f1bad72112e0e75ba0628007ac8fb5c68498bb1624877abb17636f"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89770616-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89770616" id="issuecomment-89770616-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T13:32:46Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kaspth">@kaspth</a> in the case of mobile template being rendered, wouldn't we want that in this specific test? There is a template that exists, so <code class="notranslate">head :no_content</code> would be unexpected behavior. If the variant doesn't have a template, then it should be a head no_content.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="VtWuJJ7H4aGuUXYiPpk45w2_o4wN-Pf9ticBer0EXZeKgp7R41JJBhuoHYhzilwGloGAXoRizAF1AFAJsTuXPA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5NzcwNjE2"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89770616-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89770616" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="2ussETp57jX7i2vUyzPgMhHmvVlTFw2/rc+GCdhdZGtpQilzuBVsI2wZwc89+STnQGBbLP8CnVacwuEf3kHm8g==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89770616/edit_form?textarea_id=issuecomment-89770616-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzc4MDM3"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzc4MDM3" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5Nzc4MDM3/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89778037"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="5fd54bc64fd29869c620a6926ba729082219fe5903cebcf579ee9a696780fa1e"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89778037-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89778037" id="issuecomment-89778037-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:18:14Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sb8244">@sb8244</a> sorry, for not being clearer. What you're saying is what we want: render the variant template if it's there or <code class="notranslate">head :no_content</code>.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="lKVNzV0SPv35bVxxsTnoLpnu6OkGcTLEXFWRw3blhENI8n04IIeWWkyUN9v8KozPAtDLO4_rCTifcsCwetpO6A" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5Nzc4MDM3"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89778037-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89778037" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="Jjkz0yH+9OPlyOkN8efH613olHqd3Sk2dXagcbEkltICi+IZIfBoXiwq+LnMGAWWrYnYYUyi36dcZDSV39XLDg==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89778037/edit_form?textarea_id=issuecomment-89778037-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzc5MDU3"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzc5MDU3" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5Nzc5MDU3/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89779057"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="e7e9ea4262608af6c0adda643e117b4af4ceefe1b87b3e89fb879a30156e3b6d"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89779057-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89779057" id="issuecomment-89779057-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:22:30Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Awesome, I'm digging through template_exists? now to figure out how to properly pass the variant. It's not getting used currently so <code class="notranslate">template_exists?(method, _prefixes)</code> is returning false.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="3TiPV4jx_G0fK-ZrrDazowuz4HlO1En0EmN8785aaIkBb7-i9WRUyqrSjcHhJddCkI3Dq8dOcgjRRC2cwmWiIg" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5Nzc5MDU3"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89779057-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89779057" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="5pny/kFZKBOLKACegXvzr2yQ5W4d0QPFCApuvT5ElvqWHvVa5+J3e7G/aBm/tBnzQllWIgpUbegNMVi6GxYPjw==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89779057/edit_form?textarea_id=issuecomment-89779057-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NzgwMzUy"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5NzgwMzUy" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5NzgwMzUy/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89780352"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="f417da24b3641b7bee9842e282ad039a8e7e209fde78919c7f06a54f441b57c7"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89780352-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89780352" id="issuecomment-89780352-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:29:30Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">I've determined these will work:</p> <div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="template_exists?(method, _prefixes, false, {}, { variants: request.variant })"><pre class="notranslate"><code class="notranslate">template_exists?(method, _prefixes, false, {}, { variants: request.variant }) </code></pre></div> <p dir="auto">or set .variants</p> <div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="lookup_context.variants = request.variant"><pre class="notranslate"><code class="notranslate">lookup_context.variants = request.variant </code></pre></div> <p dir="auto">Any preference?</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="wLD8Wsl31Os7bSXpVby5oZpTzhOOLPtuXXltrhxFJvMc58yvtOJ8TI6UTkMYr91AAW3twQe2wJKeXjzdEHrsWA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5NzgwMzUy"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89780352-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89780352" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="Lu5bnfJBBwOV9e44w9TxevzTYSCR8YZMQtm2CWCodTHTH85/ifs2n+GgEC8lzm8zN2wILjL6o7OopUH8hpwyMg==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89780352/edit_form?textarea_id=issuecomment-89780352-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg3Mjc2"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg3Mjc2" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5Nzg3Mjc2/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89787276"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="af23d7edaa80aa78edd25e3ab8dedd08e3ae7795f23b53d04687362874ad0683"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89787276-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89787276" id="issuecomment-89787276-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:49:25Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sb8244">@sb8244</a> do we need either of those? The way I see it variants are already handled.</p> <p dir="auto">For instance the original tests would render the correct template if the correct variant was set and otherwise raise <code class="notranslate">MissingTemplate</code>.<br> It seems the variant is extracted in the resolver too: </p><div class="Box Box--condensed my-2"> <div class="Box-header f6"> <p class="mb-0 text-bold"> <a href="https://github.com/rails/rails/blob/24637e577c0c8139434bada14911f376ec2634e9/actionview/lib/action_view/template/resolver.rb#L188">rails/actionview/lib/action_view/template/resolver.rb</a> </p> <p class="mb-0 color-fg-muted"> Line 188 in <a data-pjax="true" class="commit-tease-sha Link--inTextBlock" href="/rails/rails/commit/24637e577c0c8139434bada14911f376ec2634e9">24637e5</a> </p> </div> <div itemprop="text" class="Box-body p-0 blob-wrapper blob-wrapper-embedded data"> <table class="highlight tab-size mb-0 js-file-line-container" data-tab-size="8" data-paste-markdown-skip=""> <tbody><tr class="border-0"> <td id="L188" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="188"></td> <td id="LC188" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s1">handler</span><span class="pl-kos">,</span> <span class="pl-s1">format</span><span class="pl-kos">,</span> <span class="pl-s1">variant</span> <span class="pl-c1">=</span> <span class="pl-en">extract_handler_and_format_and_variant</span><span class="pl-kos">(</span><span class="pl-s1">template</span><span class="pl-kos">,</span> <span class="pl-s1">formats</span><span class="pl-kos">)</span> </td> </tr> </tbody></table> </div> </div> .<p></p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="yKOlUL4cUvCh2YnPxizApGtdpJXUNiQ0aIhBscQJsbUU9JWlw4n6VxQg4mWLP6RF8GOHR12sH8irrxDCyDZ7Hg" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5Nzg3Mjc2"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89787276-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89787276" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="7r2HfVkyQti4JY9/kU8JSraVQlPm8Q7vuqe7PUReKj+3A65mR8HyBgQgm6Fpn9NnHUmdYEagfY9znfWTxBZtoA==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89787276/edit_form?textarea_id=issuecomment-89787276-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg4ODA5"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg4ODA5" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5Nzg4ODA5/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89788809"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="67b9d4d7d9a861b674efd5b77afdcca615dec82adfb7ded436472ad9e2f917e0"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89788809-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-89788809" id="issuecomment-89788809-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T14:56:37Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">The variants are not handled in the case of implicit rendering in the proposed change. It worked previously because the following code snippet always <code class="notranslate">default_renders</code> unless <code class="notranslate">performed?</code>. Because it doesn't check for a template, it will either render correctly (letting the resolver do its thing) or raise the MissingTemplate error.</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content="ret = super default_render unless performed? ret"><pre class="notranslate"><span class="pl-s1">ret</span> <span class="pl-c1">=</span> <span class="pl-smi">super</span> <span class="pl-en">default_render</span> <span class="pl-k">unless</span> <span class="pl-en">performed?</span> <span class="pl-s1">ret</span></pre></div> <p dir="auto">In the proposed change, it only default_renders if the template exists, so the implicit rendering of variant doesn't get handled.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="ELB5NRIxr-hNIfSWOcLycc451K622laWKu_Sx7NEbmXM50nAb6QHT_jYnzx00ZaQVQf3fD9AbWrpyIO0v3ukzg" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5Nzg4ODA5"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89788809-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89788809" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="f+Wp0r94ZqrF2At8FtEWCfaAkoCa6yis/kGrP7b7RcXoZdjpRsFDIicpuwBg3lG+ezro4HEsnrGjkavKEoc/pQ==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89788809/edit_form?textarea_id=issuecomment-89788809-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg5NTE0"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDg5Nzg5NTE0" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDg5Nzg5NTE0/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-89789514"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="8f5ed528c59023fcbb751ebe18d6ae2f46e229161117410a59063dd75b516b63"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-89789514-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-89789514" id="issuecomment-89789514-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T15:09:41Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Ah, I see. Well, I don't like mutating the <code class="notranslate">@_lookup_context</code>, so let's go with the first option.</p> <p dir="auto">Can we change <code class="notranslate">template_exists?</code> to use <code class="notranslate">**options</code> instead of <code class="notranslate">options = {}</code>: </p><div class="Box Box--condensed my-2"> <div class="Box-header f6"> <p class="mb-0 text-bold"> <a href="https://github.com/rails/rails/blob/ecb1981bfd3ffaca3a3efd110fc85380ece8191d/actionview/lib/action_view/lookup_context.rb#L129">rails/actionview/lib/action_view/lookup_context.rb</a> </p> <p class="mb-0 color-fg-muted"> Line 129 in <a data-pjax="true" class="commit-tease-sha Link--inTextBlock" href="/rails/rails/commit/ecb1981bfd3ffaca3a3efd110fc85380ece8191d">ecb1981</a> </p> </div> <div itemprop="text" class="Box-body p-0 blob-wrapper blob-wrapper-embedded data"> <table class="highlight tab-size mb-0 js-file-line-container" data-tab-size="8" data-paste-markdown-skip=""> <tbody><tr class="border-0"> <td id="L129" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="129"></td> <td id="LC129" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-k">def</span> <span class="pl-en">exists?</span><span class="pl-kos">(</span><span class="pl-s1">name</span><span class="pl-kos">,</span> <span class="pl-s1">prefixes</span> <span class="pl-c1">=</span> <span class="pl-kos">[</span><span class="pl-kos">]</span><span class="pl-kos">,</span> <span class="pl-s1">partial</span> <span class="pl-c1">=</span> <span class="pl-c1">false</span><span class="pl-kos">,</span> <span class="pl-s1">keys</span> <span class="pl-c1">=</span> <span class="pl-kos">[</span><span class="pl-kos">]</span><span class="pl-kos">,</span> <span class="pl-s1">options</span> <span class="pl-c1">=</span> <span class="pl-kos">{</span><span class="pl-kos">}</span><span class="pl-kos">)</span> </td> </tr> </tbody></table> </div> </div> .<p></p> <p dir="auto">This way we should be able to call it like:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content="template_exists?(method, _prefixes, variants: @_request.variant)"><pre class="notranslate"><span class="pl-en">template_exists?</span><span class="pl-kos">(</span><span class="pl-en">method</span><span class="pl-kos">,</span> <span class="pl-en">_prefixes</span><span class="pl-kos">,</span> <span class="pl-pds">variants</span>: <span class="pl-c1">@_request</span><span class="pl-kos">.</span><span class="pl-en">variant</span><span class="pl-kos">)</span></pre></div> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="E2aBfR_Zq5GIjwwfOUK1MY6MscJBA5g62vrIqNGYbGDPMbGIYkwDNj12Z7V0UdHQFbKSEMiZo8YZ3Znb3aemyw" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDg5Nzg5NTE0"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-89789514-edit-form" data-turbo="false" action="/rails/rails/issue_comments/89789514" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="AzaQGTfKYLD/MYJ4rUzqPw1KfPFNOpDs/rPCcX3iSajb1iae6VEu4ygIr8DGch1tiTgRndDTAfRVYdEckBcQfg==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/89789514/edit_form?textarea_id=issuecomment-89789514-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjA3NTQyNjg6djI="> <div id="diff-for-comment-27777993" class="js-comment"> <div data-view-component="true" class="TimelineItem"> <img src="https://avatars.githubusercontent.com/u/350807?s=60&v=4" alt="kaspth" size="40" height="40" width="40" data-view-component="true" class="TimelineItem-avatar avatar circle" /> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-eye"> <path d="M8 2c1.981 0 3.671.992 4.933 2.078 1.27 1.091 2.187 2.345 2.637 3.023a1.62 1.62 0 0 1 0 1.798c-.45.678-1.367 1.932-2.637 3.023C11.67 13.008 9.981 14 8 14c-1.981 0-3.671-.992-4.933-2.078C1.797 10.83.88 9.576.43 8.898a1.62 1.62 0 0 1 0-1.798c.45-.677 1.367-1.931 2.637-3.022C4.33 2.992 6.019 2 8 2ZM1.679 7.932a.12.12 0 0 0 0 .136c.411.622 1.241 1.75 2.366 2.717C5.176 11.758 6.527 12.5 8 12.5c1.473 0 2.825-.742 3.955-1.715 1.124-.967 1.954-2.096 2.366-2.717a.12.12 0 0 0 0-.136c-.412-.621-1.242-1.75-2.366-2.717C10.824 4.242 9.473 3.5 8 3.5c-1.473 0-2.825.742-3.955 1.715-1.124.967-1.954 2.096-2.366 2.717ZM8 10a2 2 0 1 1-.001-3.999A2 2 0 0 1 8 10Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> reviewed <a href="#discussion-diff-27777993" class="Link--secondary Link--inTextBlock"> <relative-time datetime="2015-04-05T15:14:45Z" class="no-wrap">Apr 5, 2015</relative-time> </a> <div class="float-right"> <a href="/rails/rails/pull/19377/files/1ffad20ec815ca8c6c82e7d62543dfb3820f4784#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" data-view-component="true" class="btn-sm btn"> View reviewed changes </a> </div> </div> </div> <div data-view-component="true" class="TimelineItem pt-0"> <div data-view-component="true" class="TimelineItem-body ml-4 mt-0"> <turbo-frame id="review-thread-or-comment-id-20754268" target="_top"> <details open="open" data-resolved="false" data-view-component="true" class="review-thread-component js-comment-container js-resolvable-timeline-thread-container Details-element details-reset mb-3 border rounded-2"> <summary role="button" data-view-component="true" class="py-2 px-3 rounded-2 color-bg-subtle"> <div class="d-flex flex-items-center"> <span class="flex-auto mr-3 d-flex flex-items-center"> <a href="/rails/rails/pull/19377/files#diff-9bc12324f5bba32a0b0206f457dd2e734fb360df9b742d40dc8a61b844957fd6" class="text-mono text-small Link--primary wb-break-all mr-2">actionpack/lib/action_controller/metal/implicit_render.rb</a> </span> </div> </summary> <div data-view-component="true"> <div class="blob-wrapper border-bottom js-check-bidi"> <deferred-diff-lines class="awaiting-highlight" data-url="/rails/rails/pull/19377/review_thread_syntax_highlighted_diff_lines"> <input type="hidden" name="pull_request_review_thread_id" value="20754268" data-targets="deferred-diff-lines.inputs" autocomplete="off" /> <table class="diff-table tab-size js-diff-table" data-tab-size="8" data-paste-markdown-skip> <tr> <td data-line-number="7" class="blob-num blob-num-context"></td> <td data-line-number="14" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> end</span> </td> </tr> <tr> <td data-line-number="8" class="blob-num blob-num-context"></td> <td data-line-number="15" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"><br></span> </td> </tr> <tr> <td data-line-number="9" class="blob-num blob-num-context"></td> <td data-line-number="16" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> def default_render(*args)</span> </td> </tr> <tr> <td data-line-number="10" class="blob-num blob-num-context"></td> <td data-line-number="17" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> render(*args)</span> </td> </tr> <tr> <td data-line-number="11" class="blob-num blob-num-context"></td> <td data-line-number="18" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"> end</span> </td> </tr> <tr> <td data-line-number="12" class="blob-num blob-num-context"></td> <td data-line-number="19" class="blob-num blob-num-context"></td> <td class="blob-code blob-code-context"> <span class="blob-code-inner blob-code-marker-context"><br></span> </td> </tr> <tr> <td class="blob-num blob-num-addition empty-cell"></td> <td data-line-number="20" class="blob-num blob-num-addition"></td> <td class="blob-code blob-code-addition"> <span class="blob-code-inner blob-code-marker-addition"> def default_head(*)</span> </td> </tr> </table> </deferred-diff-lines></div> <div class="js-inline-comments-container"> <div class="js-line-comments js-suggested-changes-container js-suggested-changes-contents js-quote-selection-container" data-quote-markdown=".js-comment-body"> <div class="js-comments-holder" > <div id="discussion_r27777993" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27777993-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/350807?s=48&v=4" alt="@kaspth" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> <a href="#discussion_r27777993" id="discussion_r27777993-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T15:14:45Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777993/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="3EUAkukgNXkvSMJa21eJ8jv8kyzAAq0ZbEGhqc3KYN5PrBe2za9b5Iidg-BqAOS65r7eq4Zwmgc26o1AQPF3Cw" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">We should extend <code class="notranslate">method_for_action</code> to use this too, right? Otherwise we should just put this back in the else clause above.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27777993" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="cGbGgETvSzfD6Km39Lq-4daUDIakB-ZDMZSx8h2PoZ1RLiPXN82E4PZsO01glcwL_QZ9qZrr7q-jPSi0HGejHg" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27777993/edit_form?textarea_id=discussion_r27777993-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="vWthLuSxSM05GFI5UOmGQmd8gLlG6aKAAUY539yn3i5hPFHbmSTgaozhOZMd-uKj_EKja89zmXzCYWis0JgUhQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc3OTkz"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> <div id="discussion_r27778000" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27778000-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/1231659?s=48&v=4" alt="@sb8244" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> <a href="#discussion_r27778000" id="discussion_r27778000-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T15:15:46Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27778000/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="e7iKFHfPiF4fRXajlXxnzwDZ-CgTL1jkgZNSCMNgwnVSKS_sNbLhUZxehGKD79CcvE3GJ7SLp0dXMrpfxhpw2A" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">I made a comment about that on the original comment you did. I think we should not change method_for_action because it isn't in the use case and could very easily lead to silent confusion in certain cases. I'll pull it back into the <code class="notranslate">send_action</code> method.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27778000" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="OVbFQbu7SKI3g0LJ4fOhmVsQjxVkGtMvSS_HvnyeVw0BT-KAt27l56USgHl44e3BrET8ppucErOIj4Nq0QHMpg" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27778000/edit_form?textarea_id=discussion_r27778000-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="u0YDDAdTX2oTjhUx34atHEJLYE_MUocmAuTsxFPuRJtnETP5esb3zaZ3fpuSlcn92XVDnUXIvNrBw723X9GOMA" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc4MDAw"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> <div id="discussion_r27778010" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment review-comment js-minimize-container unminimized-comment"> <div class="ml-n1 flex-items-center flex-row-reverse clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="discussion_r27778010-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <img src="https://avatars.githubusercontent.com/u/350807?s=48&v=4" alt="@kaspth" size="24" height="24" width="24" data-view-component="true" class="avatar circle d-inline-block mr-2" /> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> <a href="#discussion_r27778010" id="discussion_r27778010-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-05T15:18:19Z" class="no-wrap">Apr 5, 2015</relative-time></a> </div> </h3> </div> <div class="ml-5"> <div class="edit-comment-hide"> <div class="js-minimize-comment d-none"> <div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <p>There was a problem hiding this comment.</p> </div> <div data-view-component="true" class="js-comment-hide-on-error flash flash-warn flash-full"> <button class="flash-close js-comment-hide-minimize-form" type="button"> <svg aria-label="Cancel hiding comment" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <h3 class="f4">Choose a reason for hiding this comment</h3> <p class="mb-3"> The reason will be displayed to describe this comment to others. <a class="Link--inTextBlock" href="https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment" aria-label="Learn more about hiding disruptive comments">Learn more</a>. </p> </option></form><form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27778010/minimize" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="lW_XlToxP_BGd4l6XCJBkxg6l7vumug2M-UBzhRcqb5xBQ1U0VDEgaT-rxta4QlXVvHs2QhDKwdUz88Ivij_Qw" autocomplete="off" /> <select name="classifier" class="form-select mr-2" aria-label="Reason" required> <option value> Choose a reason </option> <option value="SPAM">Spam</option> <option value="ABUSE">Abuse</option> <option value="OFF_TOPIC">Off Topic</option> <option value="OUTDATED">Outdated</option> <option value="DUPLICATE">Duplicate</option> <option value="RESOLVED">Resolved</option> </select> <button type="submit" data-view-component="true" class="Button--secondary Button--medium Button d-inline-block"> <span class="Button-content"> <span class="Button-label">Hide <span class="d-md-inline-block d-none">comment</span></span> </span> </button> </form> </div></div> <task-lists disabled sortable> <div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block"> <p dir="auto">Yeah, I thought about this some more and you're right, 👍.</p> </div> </task-lists> </div> </div> </option></form><form class="mt-2 js-comment-update" data-type="json" data-turbo="false" action="/rails/rails/pull/19377/review_comment/27778010" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="eGvqiOWih8EbAKuCACbWWVCVTf5ePXP2O-NXjG2yGddw4k3C_MTpMt9hP3C7PvRofE8acrfVEgZ3O3odSxoYEg" autocomplete="off" /> <include-fragment loading="lazy" src="/rails/rails/pull/19377/review_comment/27778010/edit_form?textarea_id=discussion_r27778010-body&comment_context=discussion" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> <div class="ml-5 edit-comment-hide"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-flex"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="kYDIx_RUrAA0VA6Y3HZnZcfhEkyGAzhkfLbZKn9EukVN1_gyicEEp4GtZTKRZQOEXN8xng-ZA5i_kYhZc3tw7g" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc4MDEw"> <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </div> </div> </div> </details></turbo-frame> </div> </div></div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIzOkhlYWRSZWZGb3JjZVB1c2hlZEV2ZW50MjczNjMzMDcx"> <div id="event-273633071" data-view-component="true" class="TimelineItem js-targetable-element"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-push"> <path d="M1 2.5A2.5 2.5 0 0 1 3.5 0h8.75a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0V1.5h-8a1 1 0 0 0-1 1v6.708A2.493 2.493 0 0 1 3.5 9h3.25a.75.75 0 0 1 0 1.5H3.5a1 1 0 0 0 0 2h5.75a.75.75 0 0 1 0 1.5H3.5A2.5 2.5 0 0 1 1 11.5Zm13.23 7.79h-.001l-1.224-1.224v6.184a.75.75 0 0 1-1.5 0V9.066L10.28 10.29a.75.75 0 0 1-1.06-1.061l2.505-2.504a.75.75 0 0 1 1.06 0L15.29 9.23a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=40&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="20" height="20" alt="@sb8244" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> <a data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":31341031,"repository_id":8514,"event_id":273633071,"originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="8c3c41c0f822e6d5f0c054ec9808c7938e7f440a15bbd00c3c52764bc19c8f03" href="/rails/rails/compare/5000c3526f96551596a99441d357d7af09261fdc..305e4ca1409feee755c91c28c3828612c78ddd09" data-view-component="true" class="Link--inTextBlock Link--secondary Link">force-pushed</a> the <span class="commit-ref user-select-contain"> <span > <span class=" css-truncate-target">issue-19036</span> </span> </span> branch from <a href="/rails/rails/commit/5000c3526f96551596a99441d357d7af09261fdc" data-view-component="true" class="Link--primary Link text-bold"> <code>5000c35</code> </a> to <a href="/rails/rails/commit/305e4ca1409feee755c91c28c3828612c78ddd09" data-view-component="true" class="Link--primary Link text-bold"> <code>305e4ca</code> </a> <a href="/rails/rails/compare/5000c3526f96551596a99441d357d7af09261fdc..305e4ca1409feee755c91c28c3828612c78ddd09" data-hydro-click="{"event_type":"force_push_timeline_diff.click","payload":{"pull_request_id":31341031,"repository_id":8514,"event_id":273633071,"originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="8c3c41c0f822e6d5f0c054ec9808c7938e7f440a15bbd00c3c52764bc19c8f03" data-view-component="true" class="Button--invisible Button--small Button Button--invisible-noVisuals float-right ml-2"> <span class="Button-content"> <span class="Button-label">Compare</span> </span> </a> <a href="#event-273633071" data-view-component="true" class="css-truncate css-truncate-target Link--secondary Link"> <relative-time tense="past" datetime="2015-04-05T15:29:40Z" data-view-component="true">April 5, 2015 15:29</relative-time> </a> </div> </div> </div> <div id="js-progressive-timeline-item-container"> </option></form><form class="ajax-pagination-form js-ajax-pagination pagination-loader-container mt-4 mb-4 ml-0 text-center" data-turbo="false" action="/rails/rails/pull/19377/timeline_more_items?after_cursor=Y3Vyc29yOnYyOpPPAAABTIozmqABqTI3MzYzMzA3MQ%3D%3D&before_cursor=Y3Vyc29yOnYyOpPPAAABTI5Qy9ABqTI3NDAzMDU2NA%3D%3D" accept-charset="UTF-8" method="get"> <div class="discussion-item-header pt-0"> <div class="Box d-inline-flex flex-column"> <button type="submit" class="color-fg-muted ajax-pagination-btn no-underline pb-0 pt-2 px-4 mt-0 mb-1 color-bg-default border-0"> 20 hidden items </button> <button type="submit" class="ajax-pagination-btn no-underline pb-1 pt-0 px-4 mt-0 mb-1 color-bg-default border-0" data-disable-with="Loading…"> Load more… </button> </div> </div> </div> </form> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDE1OlJlZmVyZW5jZWRFdmVudDI3NDAzMDU2NA=="> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-ca4417d"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh">dhh</a> added a commit that referenced this pull request <a href="#ref-commit-ca4417d" class="Link--secondary"> <relative-time datetime="2015-04-06T10:40:02Z" class="no-wrap">Apr 6, 2015</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4NTE0OmNvbW1pdDpjYTQ0MTdkMzMzMjkyYjVkMzQ1Y2M2NGQzZTRiYmZmMWI0OTFlOGUzIiwidCI6MTczMjczNDkzMn0=--f63f524d2e63a2984bdc489458aad1acf2b70f70a65a8c5e80923f9193f4bb19" data-url="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/2741?s=40&u=ce0dd0173c534e7e8b72e1cb393fed76e904a91c&v=4" width="20" height="20" alt="@dhh" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Merge pull request #19377 from sb8244/issue-19036 when a template is missing for the default render, do head no_content instead" data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3">Merge pull request</a> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a> <a title="Merge pull request #19377 from sb8244/issue-19036 when a template is missing for the default render, do head no_content instead" data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3">from sb8244/issue-19036</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> <a href="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3#comments" aria-label="View comments on this commit" class="Link--secondary"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </a> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0ODUxNDpjYTQ0MTdkMzMzMjkyYjVkMzQ1Y2M2NGQzZTRiYmZmMWI0OTFlOGUz" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3" class="Link--secondary">ca4417d</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">when a template is missing for the default render, do head no_content instead</pre> </div> </div> </div> </div> </div> <div class="TimelineItem js-details-container Details" id="event-274030565" > <div class="TimelineItem-badge color-fg-on-emphasis color-bg-done-emphasis"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-merge"> <path d="M5.45 5.154A4.25 4.25 0 0 0 9.25 7.5h1.378a2.251 2.251 0 1 1 0 1.5H9.25A5.734 5.734 0 0 1 5 7.123v3.505a2.25 2.25 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.95-.218ZM4.25 13.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm8.5-4.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5ZM5 3.25a.75.75 0 1 0 0 .005V3.25Z"></path> </svg> </div> <div class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/2741?s=40&u=ce0dd0173c534e7e8b72e1cb393fed76e904a91c&v=4" width="20" height="20" alt="@dhh" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh">dhh</a> merged commit <a href="/rails/rails/commit/ca4417d333292b5d345cc64d3e4bbff1b491e8e3"><code class="Link--primary text-bold">ca4417d</code></a> into <span class="commit-ref user-select-contain"> <span class="base-ref"> <span class="css-truncate-target user">rails</span>:<span class="css-truncate-target">master</span> </span> </span> <a href="https://github.com/rails/rails/pull/19377#event-274030565" class="Link--secondary"><relative-time datetime="2015-04-06T10:40:02Z" class="no-wrap">Apr 6, 2015</relative-time></a> </div> </div> <div class="TimelineItem-break"></div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDkwMDI0NTc2"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDkwMDI0NTc2" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDkwMDI0NTc2/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-90024576"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="76bd164b351d227203a79eaf0a6dd402cd85851693fd3dbdf3e5bd9ee5e405e8"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-90024576-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-90024576" id="issuecomment-90024576-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-06T11:35:18Z" class="no-wrap">Apr 6, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Woot first Rails commit! See yall at Rails conf.</p> <p dir="auto">On Monday, April 6, 2015, David Heinemeier Hansson <a href="mailto:notifications@github.com">notifications@github.com</a><br> wrote:</p> <blockquote> <p dir="auto">Merged <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a>.</p> <p dir="auto">—<br> Reply to this email directly or view it on GitHub<br> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377#event-274030567">#19377 (comment)</a>.</p> </blockquote> <h2 dir="auto"></h2> <p dir="auto">Steve Bussey •SalesLoft</p> <p dir="auto">•Software Engineer</p> <p dir="auto">e <a href="mailto:steve.bussey@salesloft.com">steve.bussey@salesloft.com</a> w salesloft.com<br> <a href="http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue" rel="nofollow">http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue</a></p> <p dir="auto">a 3423 Piedmont Rd NE, Atlanta, GA 30305</p> <p dir="auto">[image: Facebook] <a href="https://www.facebook.com/SalesLoft" rel="nofollow">https://www.facebook.com/SalesLoft</a> [image: Twitter]<br> <a href="https://twitter.com/SalesLoft" rel="nofollow">https://twitter.com/SalesLoft</a> [image: Linkedin]<br> <a href="https://www.linkedin.com/company/salesloft" rel="nofollow">https://www.linkedin.com/company/salesloft</a> [image: wordpress]<br> <a href="http://blog.salesloft.com/blog/" rel="nofollow">http://blog.salesloft.com/blog/</a> [image:<br> http://salesloft.com/prospector/#video]<br> <a href="http://salesloft.com/prospector/#video" rel="nofollow">http://salesloft.com/prospector/#video</a> [image: Software Engineer Logo]<br> <a href="http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue" rel="nofollow">http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue</a></p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="aNRCkalpP01uc4zNAlyRZJCZMpCsG7FXKsG6vYmGD960g3Jk1PyX6tuK52dPT_WFC6cRQiWBiqvp5uvOhbnFdQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDkwMDI0NTc2"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-90024576-edit-form" data-turbo="false" action="/rails/rails/issue_comments/90024576" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="DhEbVyfKrUb65aJ+0w4I1DDv+8rZGd/LafET9PKJXmSDA++6d9TMtAxNpNj1Oho5N+OL1VIlbYpNbiU+3NHrug==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/90024576/edit_form?textarea_id=issuecomment-90024576-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDE1OlJlZmVyZW5jZWRFdmVudDI3NDExMjE2Mw=="> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-188934c"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/eileencodes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/eileencodes">eileencodes</a> added a commit that referenced this pull request <a href="#ref-commit-188934c" class="Link--secondary"> <relative-time datetime="2015-04-06T13:07:24Z" class="no-wrap">Apr 6, 2015</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4NTE0OmNvbW1pdDoxODg5MzRjZGFjNDI0OTFkZmZhNjM2MTljYzBmOWE1YjI1ZTAxODFmIiwidCI6MTczMjczNDkzMn0=--17b77e3507b044da41bf663d7519bd4f066ce5523447b919943557b76d4faab0" data-url="/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/eileencodes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/eileencodes"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/1080678?s=40&u=b6e211b7766e6aa01e794067f67dd65d419c0150&v=4" width="20" height="20" alt="@eileencodes" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Fix ActionPack tests after changes to missing template logger After merging #19377 ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge." data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f">Fix ActionPack tests after changes to missing template logger</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> <a href="/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f#comments" aria-label="View comments on this commit" class="Link--secondary"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </a> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0ODUxNDoxODg5MzRjZGFjNDI0OTFkZmZhNjM2MTljYzBmOWE1YjI1ZTAxODFm" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f" class="Link--secondary">188934c</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">After merging <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a> ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge.</pre> </div> </div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDkwMDU2MjEx"> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDkwMDU2MjEx" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDkwMDU2MjEx/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/eileencodes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/eileencodes"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1080678?s=80&u=b6e211b7766e6aa01e794067f67dd65d419c0150&v=4" width="40" height="40" alt="@eileencodes" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-90056211"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="e76a3c8c633d7f0925eda0373ceab1ebf2122f0a9247a8b54a3bb38e38adba26"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-90056211-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user is a member of the rails organization." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Member</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/eileencodes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/eileencodes">eileencodes</a> </strong> commented <a href="#issuecomment-90056211" id="issuecomment-90056211-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2015-04-06T13:09:11Z" class="no-wrap">Apr 6, 2015</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Congrats on your first merged Rails commit <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sb8244">@sb8244</a>! 😄</p> <p dir="auto">This caused a minor bug in ActionPack (don't feel bad we've all caused bugs 🐛). actionpack/test/controller/mime/respond_to_test.rb tests only run after merge so CI didn't catch it earlier. Fixed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f/hovercard" href="https://github.com/rails/rails/commit/188934cdac42491dffa63619cc0f9a5b25e0181f"><tt>188934c</tt></a>.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="MKtrhRCf4LVM-HwGNM1hq7S1nebhPjh65G0x0cDZf4Ts_FtwbQpIEvkBF6x53gVKL4u-NGikA4YnSmCizOa1Lw" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDkwMDU2MjEx"> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-90056211-edit-form" data-turbo="false" action="/rails/rails/issue_comments/90056211" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="Qp/xSRufUVPP/l/e/0+aQgx/1Vs88rFSmHjaYFeGRS1i/7Lppg9Us3KRIAEd54X/+mbZbPMk2tmxL+W4tQN3WQ==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/90056211/edit_form?textarea_id=issuecomment-90056211-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDIwOkNyb3NzUmVmZXJlbmNlZEV2ZW50NzAzOTgwMzg="> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode">chancancode</a> mentioned this pull request <a class="Link--secondary" href="#ref-issue-90188429" > <relative-time datetime="2015-06-22T21:40:49Z" class="no-wrap">Jun 22, 2015</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-issue-90188429" > <a href="/rails/rails/issues/20666" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/20666/hovercard"> ActionController::UnknownFormat should return HTTP 406 <span class="color-fg-muted text-normal" >#20666</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Closed" data-view-component="true" class="State State--merged State--small d-flex flex-items-center"> <svg aria-hidden="true" height="12" viewBox="0 0 16 16" version="1.1" width="12" data-view-component="true" class="octicon octicon-issue-closed flex-items-center mr-1"> <path d="M11.28 6.78a.75.75 0 0 0-1.06-1.06L7.25 8.69 5.78 7.22a.75.75 0 0 0-1.06 1.06l2 2a.75.75 0 0 0 1.06 0l3.5-3.5Z"></path><path d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0Zm-1.5 0a6.5 6.5 0 1 0-13 0 6.5 6.5 0 0 0 13 0Z"></path> </svg> Closed </span> </div> </div> </div> </div> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/thebadmonkeydev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thebadmonkeydev"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/6217672?s=40&v=4" width="20" height="20" alt="@thebadmonkeydev" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/thebadmonkeydev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thebadmonkeydev">thebadmonkeydev</a> mentioned this pull request <a class="Link--secondary" href="#ref-issue-121188813" > <relative-time datetime="2015-12-09T08:50:00Z" class="no-wrap">Dec 9, 2015</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-issue-121188813" > <a href="/heartcombo/responders/issues/144" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="issue" data-hovercard-url="/heartcombo/responders/issues/144/hovercard"> Responder is broken on Rails 5 <span class="color-fg-muted text-normal" >heartcombo/responders#144</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Closed" data-view-component="true" class="State State--merged State--small d-flex flex-items-center"> <svg aria-hidden="true" height="12" viewBox="0 0 16 16" version="1.1" width="12" data-view-component="true" class="octicon octicon-issue-closed flex-items-center mr-1"> <path d="M11.28 6.78a.75.75 0 0 0-1.06-1.06L7.25 8.69 5.78 7.22a.75.75 0 0 0-1.06 1.06l2 2a.75.75 0 0 0 1.06 0l3.5-3.5Z"></path><path d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0Zm-1.5 0a6.5 6.5 0 1 0-13 0 6.5 6.5 0 0 0 13 0Z"></path> </svg> Closed </span> </div> </div> </div> </div> <div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-502947577"> <div class="TimelineItem-badge "> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-milestone color-fg-inherit"> <path d="M7.75 0a.75.75 0 0 1 .75.75V3h3.634c.414 0 .814.147 1.13.414l2.07 1.75a1.75 1.75 0 0 1 0 2.672l-2.07 1.75a1.75 1.75 0 0 1-1.13.414H8.5v5.25a.75.75 0 0 1-1.5 0V10H2.75A1.75 1.75 0 0 1 1 8.25v-3.5C1 3.784 1.784 3 2.75 3H7V.75A.75.75 0 0 1 7.75 0Zm4.384 8.5a.25.25 0 0 0 .161-.06l2.07-1.75a.248.248 0 0 0 0-.38l-2.07-1.75a.25.25 0 0 0-.161-.06H2.75a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h9.384Z"></path> </svg> </div> <div class="TimelineItem-body"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/47848?s=40&u=41ccf0d1865a17f47d140f73a3293f1f3559fc0f&v=4" width="20" height="20" alt="@rafaelfranca" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca">rafaelfranca</a> modified the milestones: <span class="tooltipped tooltipped-n text-bold color-fg-default" aria-label="This milestone has been deleted.">5.0.0 [temp]</span>, <a href="/rails/rails/milestone/47" class="Link--primary text-bold">5.0.0</a> <a href="#event-502947577" class="Link--secondary"><relative-time datetime="2015-12-30T17:51:41Z" class="no-wrap">Dec 30, 2015</relative-time></a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MDkwMjk2OQ=="> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MDkwMjk2OQ==" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDE4MDkwMjk2OQ==/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/clarkware"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/4831?s=80&v=4" width="40" height="40" alt="@clarkware" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-180902969"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="a15722cea4ec57509fecf6af0529c12e81d37f1464a0d257ca2a9b50cb9d6684"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-180902969-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/clarkware">clarkware</a> </strong> commented <a href="#issuecomment-180902969" id="issuecomment-180902969-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2016-02-07T00:55:58Z" class="no-wrap">Feb 7, 2016</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">I'd love to find a way to bring back the "Missing template" exception for a regular browser request to fix <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126975822" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23077" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/23077/hovercard" href="https://github.com/rails/rails/issues/23077">#23077</a>. As a start, I spent some time looking through this merge and how it compares to the behavior in Rails 4. The primary difference is that <code class="notranslate">default_render</code> now checks <code class="notranslate">template_exists?</code>. This short-circuits the template existence checks that are already part of the <code class="notranslate">render</code> method in <code class="notranslate">ActionView::TemplateRenderer</code>, including raising <code class="notranslate">ActionView::MissingTemplate</code> if the template isn't found.</p> <p dir="auto">For browser requests, it would be ideal to just call <code class="notranslate">render</code> straight away and let <code class="notranslate">ActionView::TemplateRenderer</code> do the checking. If the template for the default render isn't found, then <code class="notranslate">ActionView::MissingTemplate</code> gets raised and the error shows up in the browser just as before. Here's a quick hack that demonstrates the idea:</p> <div class="highlight highlight-source-ruby notranslate position-relative overflow-auto" dir="auto" data-snippet-clipboard-copy-content="def default_render(*args) if request.format == Mime[:html] render(*args) end # current implementation for all other formats # which returns a 204 if the template is missing end"><pre class="notranslate"><span class="pl-k">def</span> <span class="pl-en">default_render</span><span class="pl-kos">(</span>*<span class="pl-s1">args</span><span class="pl-kos">)</span> <span class="pl-k">if</span> <span class="pl-en">request</span><span class="pl-kos">.</span><span class="pl-en">format</span> == <span class="pl-v">Mime</span><span class="pl-kos">[</span><span class="pl-pds">:html</span><span class="pl-kos">]</span> <span class="pl-en">render</span><span class="pl-kos">(</span>*<span class="pl-s1">args</span><span class="pl-kos">)</span> <span class="pl-k">end</span> <span class="pl-c"># current implementation for all other formats</span> <span class="pl-c"># which returns a 204 if the template is missing</span> <span class="pl-k">end</span></pre></div> <p dir="auto">I realize I'm really late to this party and may be missing subtleties that were addressed in the original discussion. Is there general interest in a pull request along these lines that raises a <code class="notranslate">MissingTemplate</code> exception for browser requests (the default behavior pre-Rails 5) rather than returning a 204?</p> <p dir="auto">Any help or guidance is appreciated.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="LJkqZUlHqg-Xhv_HK8YUOMbNMPgpYRDDhILvWM2MNVTwzhqQNNICqCJ_lG1m1XDZXfMTKqD7Kz9Hpb4rwbP__w" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDE4MDkwMjk2OQ=="> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-180902969-edit-form" data-turbo="false" action="/rails/rails/issue_comments/180902969" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="VYSeVUTmQAU6dT1QB7+HpcWZJTS7/m10yMCmquKoudEIEelh7Mu1v5xYxu3iuKZRxPQ8P+zbtIaxdxsvrlCf6Q==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/180902969/edit_form?textarea_id=issuecomment-180902969-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDE5OkhlYWRSZWZEZWxldGVkRXZlbnQ1NDE5NTU3MzU="> <div id="event-541955735" data-view-component="true" class="TimelineItem js-targetable-element"> <div data-view-component="true" class="TimelineItem-badge"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-branch"> <path d="M9.5 3.25a2.25 2.25 0 1 1 3 2.122V6A2.5 2.5 0 0 1 10 8.5H6a1 1 0 0 0-1 1v1.128a2.251 2.251 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.5 0v1.836A2.493 2.493 0 0 1 6 7h4a1 1 0 0 0 1-1v-.628A2.25 2.25 0 0 1 9.5 3.25Zm-6 0a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Zm8.25-.75a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5ZM4.25 12a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body"> <a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=40&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="20" height="20" alt="@sb8244" /></a> <a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> deleted the <span class="commit-ref user-select-contain width-fit"> <span data-view-component="true" class="css-truncate css-truncate-target width-fit"> issue-19036 </span> </span> branch <a href="#event-541955735" data-view-component="true" class="css-truncate css-truncate-target Link--secondary Link"> <relative-time tense="past" datetime="2016-02-07T00:58:14Z" data-view-component="true">February 7, 2016 00:58</relative-time> </a> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA1NjIxMg=="> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA1NjIxMg==" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDE4MTA1NjIxMg==/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=80&u=c29e57c79f04491e06e9e849cb599ed72dbce218&v=4" width="40" height="40" alt="@kaspth" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-181056212"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="20f1162b03470d610809f0f92232233e1bcc5c8606306c02f72206e6644cd70d"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-181056212-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> </strong> commented <a href="#issuecomment-181056212" id="issuecomment-181056212-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2016-02-07T17:26:29Z" class="no-wrap">Feb 7, 2016</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/clarkware">@clarkware</a> yeah, do open a pull request. ❤️</p> <p dir="auto">Your suggestion also comports with <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/matthewd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/matthewd">@matthewd</a>'s here: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard?comment_id=171103997&comment_type=issue_comment" href="https://github.com/rails/rails/issues/19036#issuecomment-171103997">#19036 (comment)</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard?comment_id=171111678&comment_type=issue_comment" href="https://github.com/rails/rails/issues/19036#issuecomment-171111678">#19036 (comment)</a></p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="9ZTUOiXmY0UTiILzwek4JKq3NMkWV8z1CwriwrfclPYpw-TPWHPL4qZx6VmM-lzFMYkXG5_N9wnILbOxu-NeXQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDE4MTA1NjIxMg=="> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-181056212-edit-form" data-turbo="false" action="/rails/rails/issue_comments/181056212" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="jrCkobBQivAmyQ9JxV+bqHe3cNVUh9ZC06kX+hcfe64WhxqZTPW0cgIvcTtk10pf03tyKLcII8Gg+5PhndnsRA==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/181056212/edit_form?textarea_id=issuecomment-181056212-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA3OTkyMA=="> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA3OTkyMA==" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDE4MTA3OTkyMA==/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/matthewd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/matthewd"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1034?s=80&v=4" width="40" height="40" alt="@matthewd" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-181079920"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="ffc189e5a289eb6ee7eba985af56c985f59f5e05c51b70821fc7145c75d4f005"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-181079920-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user is a member of the rails organization." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Member</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/matthewd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/matthewd">matthewd</a> </strong> commented <a href="#issuecomment-181079920" id="issuecomment-181079920-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2016-02-07T18:52:14Z" class="no-wrap">Feb 7, 2016</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Yeah, I think the only potential challenge will be in finding the right way of defining an <code class="notranslate">interactive_browser_request?</code>. Maybe 'html && !xhr' is sufficient? It feels like something we should have prior art on, but nothing specific is coming to mind.</p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="C2BFR4A4Sj-ug5gw_J6dvejiWN7YB3Tg_lPZMPH366bXN3Wy_a3imBt685qxjflcc9x7DFGdTxw9dIhD_cghDQ" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDE4MTA3OTkyMA=="> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-181079920-edit-form" data-turbo="false" action="/rails/rails/issue_comments/181079920" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="M8j+srmaVPpCRzSwmZDbRQUxRXhYdn/Utld2dzbkKU3vikMQUzWznNSB7sKvHDcMTZh0uluS+3Y5MJH2CIF2ZQ==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/181079920/edit_form?textarea_id=issuecomment-181079920-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA4MjAxMQ=="> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTA4MjAxMQ==" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDE4MTA4MjAxMQ==/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=80&u=3044396996580f3ce65ec2ff022cb1b210806f65&v=4" width="40" height="40" alt="@sb8244" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-181082011"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="7fa3fa2f27b99ed91a9b9becd26bd1344c8dab3615ad37002daa68797a232693"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-181082011-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> <span aria-label="This user has previously committed to the rails repository." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Contributor</span> </span> <span aria-label="This user is the author of this pull request." data-view-component="true" class="tooltipped tooltipped-n"> <span data-view-component="true" class="Label ml-1">Author</span> </span> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244">sb8244</a> </strong> commented <a href="#issuecomment-181082011" id="issuecomment-181082011-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2016-02-07T18:56:50Z" class="no-wrap">Feb 7, 2016</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">That is my concern as well. For instance, a potentially interesting side<br> effect of the 204 is that you can GET request without the browser changing<br> pages. This could allow graceful fallback for scriptless support. Maybe<br> that isn't a use case, but it made me pause and consider what<br> an interactive request definition might have to overcome.</p> <h2 dir="auto"></h2> <p dir="auto">Steve Bussey • SalesLoft</p> <p dir="auto">• Software Engineer</p> <p dir="auto">e <a href="mailto:steve.bussey@salesloft.com">steve.bussey@salesloft.com</a> w salesloft.com<br> <a href="http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue" rel="nofollow">http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue</a></p> <p dir="auto">a 3423 Piedmont Rd NE, Atlanta, GA 30305</p> <p dir="auto">[image: Facebook] <a href="https://www.facebook.com/SalesLoft" rel="nofollow">https://www.facebook.com/SalesLoft</a> [image: Twitter]<br> <a href="https://twitter.com/SalesLoft" rel="nofollow">https://twitter.com/SalesLoft</a> [image: Linkedin]<br> <a href="https://www.linkedin.com/company/salesloft" rel="nofollow">https://www.linkedin.com/company/salesloft</a> [image: wordpress]<br> <a href="http://blog.salesloft.com/blog/" rel="nofollow">http://blog.salesloft.com/blog/</a> [image:<br> http://salesloft.com/prospector/#video]<br> <a href="http://salesloft.com/prospector/#video" rel="nofollow">http://salesloft.com/prospector/#video</a> [image: Software Engineer Logo]<br> <a href="http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue" rel="nofollow">http://salesloft.com/?v=1&utm_expid=76406993-1.E5ncJhwyTAW9uGaR1WdBTA.1?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue</a></p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="BG1fP2ilCgmrhZbFpXtcZ7h7hqzBrr2URvk-oJHXX3XYOm_KFTCirh58_W_oaDiGI0Wlfkg0hmiF3m_TneiV3g" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDE4MTA4MjAxMQ=="> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-181082011-edit-form" data-turbo="false" action="/rails/rails/issue_comments/181082011" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="JK4Vy8ni3mZNd0VrNPQZsp2hjxkJgvurbwwokNKTTsxk1tMekj4unm1CUwFue+TL83V5y20AJJ4cLvWiGT3IbQ==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/181082011/edit_form?textarea_id=issuecomment-181082011-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTU0MTkwMw=="> <div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDE4MTU0MTkwMw==" data-url="/rails/rails/comments/MDEyOklzc3VlQ29tbWVudDE4MTU0MTkwMw==/partials/timeline_issue_comment" > <div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/clarkware"><img class="avatar rounded-2 avatar-user" src="https://avatars.githubusercontent.com/u/4831?s=80&v=4" width="40" height="40" alt="@clarkware" /></a> </div> <div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-181541903"> <div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="7a38b9282bcb204050c191181160d57edc1d266207e74641ad88007a501deb14"> <div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false"> <div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center"> <details class="details-overlay details-reset position-relative d-inline-block"> <summary data-view-component="true" class="timeline-comment-action Link--secondary Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label"><svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></span> </span> </summary> <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > <span data-view-component="true"> <clipboard-copy aria-label="Copy link" for="issuecomment-181541903-permalink" role="menuitem" data-view-component="true" class="dropdown-item btn-link"> Copy link </clipboard-copy> <div aria-live="polite" aria-atomic="true" class="sr-only" data-clipboard-copy-feedback></div> </span> </details-menu> </details> </div> <div class="d-none d-sm-flex"> </div> <h3 class="f5 text-normal" style="flex: 1 1 auto"> <div> <strong> <a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/clarkware">clarkware</a> </strong> commented <a href="#issuecomment-181541903" id="issuecomment-181541903-permalink" class="Link--secondary js-timestamp"><relative-time datetime="2016-02-08T20:00:56Z" class="no-wrap">Feb 8, 2016</relative-time></a> </div> </h3> </div> <div class="edit-comment-hide"> <task-lists disabled sortable> <table class="d-block user-select-contain" data-paste-markdown-skip> <tbody class="d-block"> <tr class="d-block"> <td class="d-block comment-body markdown-body js-comment-body"> <p dir="auto">Thanks for the input! Here's a first cut at a pull request: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="132241509" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23564" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23564/hovercard" href="https://github.com/rails/rails/pull/23564">#23564</a></p> </td> </tr> </tbody> </table> </task-lists> <div class="d-flex"> <div class="pr-review-reactions"> <div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none"> </option></form><form class="js-pick-reaction" data-turbo="false" action="/rails/rails/reactions" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" name="authenticity_token" value="2Ddemqk3F7RHg6FmiDuWoPHlbndt93QW3Hs_QagR3FEEYG5v1KK_E_J6yszFKPJBattNpeRtT-ofXG4ypC4W-g" autocomplete="off" /> <input type="hidden" name="input[subjectId]" value="MDEyOklzc3VlQ29tbWVudDE4MTU0MTkwMw=="> <input type="hidden" name="input[context]" value="" > <div class="js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <div class="js-reactions-container"> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </form></div> </div> </div> </div> </option></form><form class="js-comment-update" id="issuecomment-181541903-edit-form" data-turbo="false" action="/rails/rails/issue_comments/181541903" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="E6J7lVw+JqD4sq4vUi+EcuIS6YPzc+a05CAHuKifv0Zv/g7I/2Vp7c3J6fU0aKpDqzYjeiAbdbdMcJZ4VQewfw==" /> <include-fragment loading="lazy" src="/rails/rails/issue_comments/181541903/edit_form?textarea_id=issuecomment-181541903-body&comment_context=" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment" > <p class="text-center mt-3" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </p> <p class="ml-1 mb-2 mt-2" data-show-on-error hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> Sorry, something went wrong. </p> </include-fragment> </form> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDE1OlJlZmVyZW5jZWRFdmVudDU2MjA0MjM4NQ=="> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-ec49054"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode">chancancode</a> added a commit that referenced this pull request <a href="#ref-commit-ec49054" class="Link--secondary"> <relative-time datetime="2016-02-23T17:45:40Z" class="no-wrap">Feb 23, 2016</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4NTE0OmNvbW1pdDplYzQ5MDU0MGU3MmI2MWYxM2YyYWQ3NzFjMjhlMGM0MGI4ZjAwYjBjIiwidCI6MTczMjczNDkzMn0=--fab0ca0d126c070034fe2ac4af73da8401499df424f7930429f12f9783ed7aa5" data-url="/rails/rails/commit/ec490540e72b61f13f2ad771c28e0c40b8f00b0c/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Lock down new `ImplicitRender` behavior for 5.0 RC 1. Conceptually revert #20276 The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see plataformatec/responders#131). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in #19036 and #19377. 4. To avoid confusion when interacting in the browser, these actions will raise a `TemplateMissing` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) Closes #20666, #22854, #23062, #23077, #23564 [Godfrey Chan, Jon Moss, Mike Clark, Matthew Draper]" data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/ec490540e72b61f13f2ad771c28e0c40b8f00b0c">Lock down new <code>ImplicitRender</code> behavior for 5.0 RC</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0ODUxNDplYzQ5MDU0MGU3MmI2MWYxM2YyYWQ3NzFjMjhlMGM0MGI4ZjAwYjBj" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/rails/rails/commit/ec490540e72b61f13f2ad771c28e0c40b8f00b0c" class="Link--secondary">ec49054</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">1. Conceptually revert <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="79853674" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20276" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/20276/hovercard" href="https://github.com/rails/rails/pull/20276">#20276</a> The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="95665809" data-permission-text="Title is private" data-url="https://github.com/heartcombo/responders/issues/131" data-hovercard-type="pull_request" data-hovercard-url="/heartcombo/responders/pull/131/hovercard" href="https://github.com/heartcombo/responders/pull/131">heartcombo/responders#131</a>). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" href="https://github.com/rails/rails/issues/19036">#19036</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a>. 4. To avoid confusion when interacting in the browser, these actions will raise a `TemplateMissing` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #20666.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="90188429" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20666" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/20666/hovercard" href="https://github.com/rails/rails/issues/20666">#20666</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="124387384" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/22854" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/22854/hovercard" href="https://github.com/rails/rails/pull/22854">#22854</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126764451" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23062" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23062/hovercard" href="https://github.com/rails/rails/pull/23062">#23062</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126975822" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23077" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/23077/hovercard" href="https://github.com/rails/rails/issues/23077">#23077</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="132241509" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23564" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23564/hovercard" href="https://github.com/rails/rails/pull/23564">#23564</a> [Godfrey Chan, Jon Moss, Mike Clark, Matthew Draper]</pre> </div> </div> </div> </div> </div> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode">chancancode</a> mentioned this pull request <a class="Link--secondary" href="#ref-pullrequest-135810850" > <relative-time datetime="2016-02-23T17:47:12Z" class="no-wrap">Feb 23, 2016</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-pullrequest-135810850" > <a href="/rails/rails/pull/23827" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23827/hovercard"> Lock down new <code>ImplicitRender</code> behavior for 5.0 RC <span class="color-fg-muted text-normal" >#23827</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Merged" data-view-component="true" class="State State--merged State--small"> <svg height="14" class="octicon octicon-git-merge" viewBox="0 0 16 16" version="1.1" width="14" aria-hidden="true"><path d="M5.45 5.154A4.25 4.25 0 0 0 9.25 7.5h1.378a2.251 2.251 0 1 1 0 1.5H9.25A5.734 5.734 0 0 1 5 7.123v3.505a2.25 2.25 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.95-.218ZM4.25 13.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm8.5-4.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5ZM5 3.25a.75.75 0 1 0 0 .005V3.25Z"></path></svg> Merged </span> </div> </div> <tracked-issues-progress data-total="2" data-completed="0" data-type="other"> <div class="d-inline-flex flex-row flex-items-center text-small"> <span data-target="tracked-issues-progress.checklist" style="display: inline"> <svg style="display: inline" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-checklist"> <path d="M2.5 1.75v11.5c0 .138.112.25.25.25h3.17a.75.75 0 0 1 0 1.5H2.75A1.75 1.75 0 0 1 1 13.25V1.75C1 .784 1.784 0 2.75 0h8.5C12.216 0 13 .784 13 1.75v7.736a.75.75 0 0 1-1.5 0V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13.274 9.537v-.001l-4.557 4.45a.75.75 0 0 1-1.055-.008l-1.943-1.95a.75.75 0 0 1 1.062-1.058l1.419 1.425 4.026-3.932a.75.75 0 1 1 1.048 1.074ZM4.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM4 7.75A.75.75 0 0 1 4.75 7h2a.75.75 0 0 1 0 1.5h-2A.75.75 0 0 1 4 7.75Z"></path> </svg> </span> <span style="transform:rotate(-90deg); width:12px; height:12px; display: none"> <svg width="12" height="12" data-target="tracked-issues-progress.progress" data-circumference="31" > <circle stroke="var(--borderColor-accent-muted, var(--color-accent-subtle))" stroke-width="2" fill="transparent" cx="50%" cy="50%" r="5" /> <circle data-target="tracked-issues-progress.stroke" style="transition: stroke-dashoffset 0.35s; transform: rotate(5.806451612903226deg); transform-origin: center" stroke="var(--fgColor-accent, var(--color-accent-fg))" stroke-width="2" stroke-dasharray="31" stroke-dashoffset="32.0" stroke-linecap="round" fill="transparent" cx="50%" cy="50%" r="5" /> </svg> </span> <span class="text-normal no-wrap mr-1 ml-1" data-target="tracked-issues-progress.label">2 tasks</span> </div> </tracked-issues-progress> </div> </div> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-868127c"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth">kaspth</a> pushed a commit to kaspth/rails that referenced this pull request <a href="#ref-commit-868127c" class="Link--secondary"> <relative-time datetime="2016-02-23T21:44:29Z" class="no-wrap">Feb 23, 2016</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoxMDU4MTY3Mjpjb21taXQ6ODY4MTI3Y2ZmZDE1ZmEwZTk5NjgyMmJjOGE0NmNhMTcyODZhMDg3OCIsInQiOjE3MzI3MzQ5MzJ9--69a1493a39f8c38cfc1c3ee84f7f953e9719d1946f4a950140c467e3aeb12a6b" data-url="/kaspth/rails/commit/868127cffd15fa0e996822bc8a46ca17286a0878/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start AvatarStack--two " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" class=" avatar-user" /> </a> <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/350807?s=40&v=4" width="20" height="20" alt="@kaspth" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Lock down new `ImplicitRender` behavior for 5.0 RC 1. Conceptually revert #20276 The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see plataformatec/responders#131). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in #19036 and #19377. 4. To avoid confusion when interacting in the browser, these actions will raise a `TemplateMissing` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) Closes #20666, #22854, #23062, #23077, #23564 [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]" data-pjax="true" class="Link--secondary markdown-title" href="/kaspth/rails/commit/868127cffd15fa0e996822bc8a46ca17286a0878">Lock down new <code>ImplicitRender</code> behavior for 5.0 RC</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0MTA1ODE2NzI6ODY4MTI3Y2ZmZDE1ZmEwZTk5NjgyMmJjOGE0NmNhMTcyODZhMDg3OA==" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/kaspth/rails/commit/868127cffd15fa0e996822bc8a46ca17286a0878" class="Link--secondary">868127c</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">1. Conceptually revert <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="79853674" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20276" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/20276/hovercard" href="https://github.com/rails/rails/pull/20276">rails#20276</a> The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="95665809" data-permission-text="Title is private" data-url="https://github.com/heartcombo/responders/issues/131" data-hovercard-type="pull_request" data-hovercard-url="/heartcombo/responders/pull/131/hovercard" href="https://github.com/heartcombo/responders/pull/131">heartcombo/responders#131</a>). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" href="https://github.com/rails/rails/issues/19036">rails#19036</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">rails#19377</a>. 4. To avoid confusion when interacting in the browser, these actions will raise a `TemplateMissing` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #20666.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="90188429" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20666" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/20666/hovercard" href="https://github.com/rails/rails/issues/20666">rails#20666</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="124387384" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/22854" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/22854/hovercard" href="https://github.com/rails/rails/pull/22854">rails#22854</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126764451" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23062" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23062/hovercard" href="https://github.com/rails/rails/pull/23062">rails#23062</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126975822" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23077" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/23077/hovercard" href="https://github.com/rails/rails/issues/23077">rails#23077</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="132241509" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23564" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23564/hovercard" href="https://github.com/rails/rails/pull/23564">rails#23564</a> [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]</pre> </div> </div> </div> </div> </div> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-a30b7a9"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode">chancancode</a> added a commit that referenced this pull request <a href="#ref-commit-a30b7a9" class="Link--secondary"> <relative-time datetime="2016-02-24T17:46:52Z" class="no-wrap">Feb 24, 2016</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4NTE0OmNvbW1pdDphMzBiN2E5YmE4Y2VhM2M0YTNmZTM0NjczZTlhZGJjNTg2MjE4ODdiIiwidCI6MTczMjczNDkzMn0=--6b1a11d4257c6a9d8d8eb2a9c88fcc305d7034e42b48ace900172071c385fc55" data-url="/rails/rails/commit/a30b7a9ba8cea3c4a3fe34673e9adbc58621887b/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Lock down new `ImplicitRender` behavior for 5.0 RC 1. Conceptually revert #20276 The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see plataformatec/responders#131). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in #19036 and #19377. 4. To avoid confusion when interacting in the browser, these actions will raise an `UnknownFormat` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) Closes #20666, #22854, #23062, #23077, #23564 [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]" data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/a30b7a9ba8cea3c4a3fe34673e9adbc58621887b">Lock down new <code>ImplicitRender</code> behavior for 5.0 RC</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0ODUxNDphMzBiN2E5YmE4Y2VhM2M0YTNmZTM0NjczZTlhZGJjNTg2MjE4ODdi" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/rails/rails/commit/a30b7a9ba8cea3c4a3fe34673e9adbc58621887b" class="Link--secondary">a30b7a9</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">1. Conceptually revert <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="79853674" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20276" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/20276/hovercard" href="https://github.com/rails/rails/pull/20276">#20276</a> The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="95665809" data-permission-text="Title is private" data-url="https://github.com/heartcombo/responders/issues/131" data-hovercard-type="pull_request" data-hovercard-url="/heartcombo/responders/pull/131/hovercard" href="https://github.com/heartcombo/responders/pull/131">heartcombo/responders#131</a>). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" href="https://github.com/rails/rails/issues/19036">#19036</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a>. 4. To avoid confusion when interacting in the browser, these actions will raise an `UnknownFormat` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #20666.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="90188429" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20666" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/20666/hovercard" href="https://github.com/rails/rails/issues/20666">#20666</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="124387384" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/22854" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/22854/hovercard" href="https://github.com/rails/rails/pull/22854">#22854</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126764451" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23062" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23062/hovercard" href="https://github.com/rails/rails/pull/23062">#23062</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126975822" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23077" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/23077/hovercard" href="https://github.com/rails/rails/issues/23077">#23077</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="132241509" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23564" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23564/hovercard" href="https://github.com/rails/rails/pull/23564">#23564</a> [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]</pre> </div> </div> </div> </div> </div> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-73b1efc"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode">chancancode</a> added a commit that referenced this pull request <a href="#ref-commit-73b1efc" class="Link--secondary"> <relative-time datetime="2016-02-25T09:19:57Z" class="no-wrap">Feb 25, 2016</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4NTE0OmNvbW1pdDo3M2IxZWZjNThmNGUwNGI0YWY3ZWQ5MzY4NTM1MmViZTkxMDhjZDdlIiwidCI6MTczMjczNDkzMn0=--5bc5bd5a7f2f846b89e55ffd6bd0d27278f89ed1584cdcbb1f84df3b4b955890" data-url="/rails/rails/commit/73b1efc58f4e04b4af7ed93685352ebe9108cd7e/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/chancancode/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/chancancode"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/55829?s=40&u=ffc0d45f6f409208b3edc122e950d69bb2c81bc5&v=4" width="20" height="20" alt="@chancancode" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Lock down new `ImplicitRender` behavior for 5.0 RC 1. Conceptually revert #20276 The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see plataformatec/responders#131). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in #19036 and #19377. 4. To avoid confusion when interacting in the browser, these actions will raise an `UnknownFormat` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) Closes #20666, #23062, #23077, #23564 [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]" data-pjax="true" class="Link--secondary markdown-title" href="/rails/rails/commit/73b1efc58f4e04b4af7ed93685352ebe9108cd7e">Lock down new <code>ImplicitRender</code> behavior for 5.0 RC</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0ODUxNDo3M2IxZWZjNThmNGUwNGI0YWY3ZWQ5MzY4NTM1MmViZTkxMDhjZDdl" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/rails/rails/commit/73b1efc58f4e04b4af7ed93685352ebe9108cd7e" class="Link--secondary">73b1efc</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">1. Conceptually revert <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="79853674" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20276" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/20276/hovercard" href="https://github.com/rails/rails/pull/20276">#20276</a> The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="95665809" data-permission-text="Title is private" data-url="https://github.com/heartcombo/responders/issues/131" data-hovercard-type="pull_request" data-hovercard-url="/heartcombo/responders/pull/131/hovercard" href="https://github.com/heartcombo/responders/pull/131">heartcombo/responders#131</a>). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="58527495" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19036" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" href="https://github.com/rails/rails/issues/19036">#19036</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">#19377</a>. 4. To avoid confusion when interacting in the browser, these actions will raise an `UnknownFormat` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) <span class="issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #20666.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="90188429" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/20666" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/20666/hovercard" href="https://github.com/rails/rails/issues/20666">#20666</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126764451" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23062" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23062/hovercard" href="https://github.com/rails/rails/pull/23062">#23062</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="126975822" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23077" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/23077/hovercard" href="https://github.com/rails/rails/issues/23077">#23077</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="132241509" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/23564" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/23564/hovercard" href="https://github.com/rails/rails/pull/23564">#23564</a> [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]</pre> </div> </div> </div> </div> </div> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/prathamesh-sonpatki/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prathamesh-sonpatki"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/621238?s=40&v=4" width="20" height="20" alt="@prathamesh-sonpatki" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/prathamesh-sonpatki/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prathamesh-sonpatki">prathamesh-sonpatki</a> mentioned this pull request <a class="Link--secondary" href="#ref-issue-168673664" > <relative-time datetime="2016-08-01T16:33:37Z" class="no-wrap">Aug 1, 2016</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-issue-168673664" > <a href="/rails/jbuilder/issues/346" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="issue" data-hovercard-url="/rails/jbuilder/issues/346/hovercard"> Jbuilder renders blank body with rails 5.0 <span class="color-fg-muted text-normal" >rails/jbuilder#346</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Open" data-view-component="true" class="State State--open State--small d-flex flex-items-center"> <svg aria-hidden="true" height="12" viewBox="0 0 16 16" version="1.1" width="12" data-view-component="true" class="octicon octicon-issue-opened flex-items-center mr-1"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> Open </span> </div> </div> </div> </div> <div class="TimelineItem"> <div class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </div> <div class="TimelineItem-body" > <div > <a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/kevindew/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kevindew"><img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/282717?s=40&v=4" width="20" height="20" alt="@kevindew" /></a> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/kevindew/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kevindew">kevindew</a> mentioned this pull request <a class="Link--secondary" href="#ref-pullrequest-517240734" > <relative-time datetime="2019-11-05T17:04:34Z" class="no-wrap">Nov 5, 2019</relative-time> </a> </div> <div class="mt-2 d-flex flex-items-start flex-column flex-md-row"> <div class="flex-auto wb-break-word" id="ref-pullrequest-517240734" > <a href="/alphagov/whitehall/pull/5107" class="Link--primary f4 text-bold markdown-title" data-hovercard-type="pull_request" data-hovercard-url="/alphagov/whitehall/pull/5107/hovercard"> Add endpoints to lock and unlock a document <span class="color-fg-muted text-normal" >alphagov/whitehall#5107</span> </a> </div> <div class="flex-shrink-0 my-1 my-md-0 ml-md-3"> <span title="Status: Merged" data-view-component="true" class="State State--merged State--small"> <svg height="14" class="octicon octicon-git-merge" viewBox="0 0 16 16" version="1.1" width="14" aria-hidden="true"><path d="M5.45 5.154A4.25 4.25 0 0 0 9.25 7.5h1.378a2.251 2.251 0 1 1 0 1.5H9.25A5.734 5.734 0 0 1 5 7.123v3.505a2.25 2.25 0 1 1-1.5 0V5.372a2.25 2.25 0 1 1 1.95-.218ZM4.25 13.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm8.5-4.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5ZM5 3.25a.75.75 0 1 0 0 .005V3.25Z"></path></svg> Merged </span> </div> </div> </div> </div> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-b7ef898"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/leenagupte/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/leenagupte">leenagupte</a> added a commit to alphagov/whitehall that referenced this pull request <a href="#ref-commit-b7ef898" class="Link--secondary"> <relative-time datetime="2019-11-05T17:48:36Z" class="no-wrap">Nov 5, 2019</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNDE2MDY0OmNvbW1pdDpiN2VmODk4NjU2MzkzY2E2YmQ0OTViM2I3M2IxZTIwN2Q0ZTAzMmI0IiwidCI6MTczMjczNDkzMn0=--cdb052f69e222d5b3b0b165f70e004b6d2c81dbe5d4516020aaaef6ce7bfbb70" data-url="/alphagov/whitehall/commit/b7ef898656393ca6bd495b3b73b1e207d4e032b4/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/leenagupte/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/leenagupte"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/5793815?s=40&u=0347e8238d5c8018cf6cef7fa2e247834dbd35f4&v=4" width="20" height="20" alt="@leenagupte" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Lock document when lock endpoint is called A 204 No Content is returned if the lock request is successful. [Rails 5](https://github.com/rails/rails/pull/19377) does this by default by automatically adding `:no_content` to the header if it can't find a template to respond with." data-pjax="true" class="Link--secondary markdown-title" href="/alphagov/whitehall/commit/b7ef898656393ca6bd495b3b73b1e207d4e032b4">Lock document when lock endpoint is called</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0MjQxNjA2NDpiN2VmODk4NjU2MzkzY2E2YmQ0OTViM2I3M2IxZTIwN2Q0ZTAzMmI0" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/alphagov/whitehall/commit/b7ef898656393ca6bd495b3b73b1e207d4e032b4" class="Link--secondary">b7ef898</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">A 204 No Content is returned if the lock request is successful. [Rails 5](<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">rails/rails#19377</a>) does this by default by automatically adding `:no_content` to the header if it can't find a template to respond with.</pre> </div> </div> </div> </div> </div> <div class="TimelineItem" > <span class="TimelineItem-badge"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <div class="TimelineItem-body" id="ref-commit-89153ad"> <a class="author Link--primary text-bold" data-hovercard-type="user" data-hovercard-url="/users/leenagupte/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/leenagupte">leenagupte</a> added a commit to alphagov/whitehall that referenced this pull request <a href="#ref-commit-89153ad" class="Link--secondary"> <relative-time datetime="2019-11-05T17:48:36Z" class="no-wrap">Nov 5, 2019</relative-time> </a> <div class="mt-3"> <div class="js-details-container Details js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNDE2MDY0OmNvbW1pdDo4OTE1M2FkODY2ZjNlODAyMTM2NmFlN2Y4ZDE3YjcwYTU0NDQ3M2EzIiwidCI6MTczMjczNDkzMn0=--26a08b35fd1b471df764d4cf26521e275d38ac70a5104bfb6eee42b50a9929b3" data-url="/alphagov/whitehall/commit/89153ad866f3e8021366ae7f8d17b70a544473a3/show_partial?partial=commit%2Fcondensed_details"> <div class="d-flex flex-md-row flex-column"> <div class="d-flex flex-auto"> <div class="AvatarStack flex-self-start " > <div class="AvatarStack-body" > <a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/leenagupte/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/leenagupte"> <img data-test-selector="commits-avatar-stack-avatar-image" src="https://avatars.githubusercontent.com/u/5793815?s=40&u=0347e8238d5c8018cf6cef7fa2e247834dbd35f4&v=4" width="20" height="20" alt="@leenagupte" class=" avatar-user" /> </a> </div> </div> <div class="pr-1 flex-auto min-width-0" > <code> <a title="Unlock document when the unlock endpoint is called A 204 No Content is returned if the unlock request is successful. [Rails 5](https://github.com/rails/rails/pull/19377) does this by default by automatically adding `:no_content` to the header if it can't find a template to respond with." data-pjax="true" class="Link--secondary markdown-title" href="/alphagov/whitehall/commit/89153ad866f3e8021366ae7f8d17b70a544473a3">Unlock document when the unlock endpoint is called</a> </code> <span class="hidden-text-expander inline"> <button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…</button> </span> </div> <div class="pr-1 d-md-inline-block d-none"> <batch-deferred-content class="d-inline-block" data-url="/commits/badges"> <input type="hidden" name="id" value="MDY6Q29tbWl0MjQxNjA2NDo4OTE1M2FkODY2ZjNlODAyMTM2NmFlN2Y4ZDE3YjcwYTU0NDQ3M2Ez" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="badge_size" value="small" data-targets="batch-deferred-content.inputs" autocomplete="off" /> <input type="hidden" name="dropdown_direction" value="w" data-targets="batch-deferred-content.inputs" autocomplete="off" /> </batch-deferred-content> </div> <div class="pr-1 flex-shrink-0" style="width: 16px;"> </div>  <div class="text-right ml-1"> <code> <a href="/alphagov/whitehall/commit/89153ad866f3e8021366ae7f8d17b70a544473a3" class="Link--secondary">89153ad</a> </code> </div> </div> </div> <div class="Details-content--hidden mt-2"> <pre class="color-fg-muted ws-pre-wrap">A 204 No Content is returned if the unlock request is successful. [Rails 5](<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62416392" data-permission-text="Title is private" data-url="https://github.com/rails/rails/issues/19377" data-hovercard-type="pull_request" data-hovercard-url="/rails/rails/pull/19377/hovercard" href="https://github.com/rails/rails/pull/19377">rails/rails#19377</a>) does this by default by automatically adding `:no_content` to the header if it can't find a template to respond with.</pre> </div> </div> </div> </div> </div> </div>  <div id="partial-timeline" class="js-timeline-marker js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMn0=--26f47c793c66d66a0604131e28f2c2ed9437c60cb49f3b9c3b8120080599f8b3" data-url="/rails/rails/pull/19377/partials/unread_timeline?since=2019-11-05T09%3A48%3A36.000000000-08%3A00" data-channel-event-name="timeline_updated" data-last-modified="2019-11-05T09:48:36.000000000-08:00" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE="> </option></form><form class="d-none js-timeline-marker-form" data-turbo="false" action="/_graphql/MarkNotificationSubjectAsRead" accept-charset="UTF-8" data-remote="true" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="5Q9zO9iNzMZcO1/M26lcZstJdIv9V3zbOALtPGzISMyn4clkiVYI7Hc5jwoabxV6ABJUIwUHoORcPJQieQbp3A==" /> <input type="hidden" name="variables[subjectId]" value="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE="> </form> </div> </div> <div class="discussion-timeline-actions"> <div id="issue-comment-box"> <div data-view-component="true" class="flash flash-warn mt-3"> <a rel="nofollow" class="btn btn-primary" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":8514,"auth_type":"SIGN_UP","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="7ccb15fa09758b14336219724a060164a3ef6fa639255449edbd11a80a341707" href="/join?source=comment-repo">Sign up for free</a> <strong>to join this conversation on GitHub</strong>. Already have an account? <a rel="nofollow" class="Link--inTextBlock" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":8514,"auth_type":"LOG_IN","originating_url":"https://github.com/rails/rails/pull/19377","user_id":null}}" data-hydro-click-hmac="bffbc4f0376cb2d947cff7cf476513db10a746331c06fd0bf44fb94f07ffe82e" data-test-selector="comments-sign-in-link" href="/login?return_to=https%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F19377">Sign in to comment</a> </div> </div> </div> </div> </div> <div data-view-component="true" class="Layout-sidebar"> <div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-channel-event-name="sidebar_updated" data-url="/rails/rails/issues/19377/show_partial?partial=issues%2Fsidebar" data-project-hovercards-enabled> <div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item position-relative js-socket-channel js-updatable-content" data-team-hovercards-enabled data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/issues/19377/show_partial?partial=pull_requests%2Fsidebar%2Fshow%2Freviewers" data-channel-event-name="reviewers_updated" > </option></form><form class="js-issue-sidebar-form" aria-label="Select reviewers" data-reviewers-team-size-check-url="/rails/rails/pull/19377/review-requests/team-size-check" data-turbo="false" action="/rails/rails/pull/19377/review-requests" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="fG4VXd5LdpVs1WIUJc4F+SZ4Jh1PaPxMXFPs6OIJXfqQCN3AkyiUzZphdowtSu5e+eWawliELkUD7MOM6yOs4g==" /> <input type="hidden" name="partial_last_updated" id="partial_last_updated" value="1732734930" autocomplete="off" class="form-control" /> <div class="js-large-teams-check-warning-container"></div> <div class="discussion-sidebar-heading text-bold"> Reviewers </div> <span class="css-truncate"> No reviews </span> </form></div> <div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/issues/19377/show_partial?partial=issues%2Fsidebar%2Fshow%2Fassignees" data-channel-event-name="assignees_updated" > </option></form><form class="js-issue-sidebar-form" aria-label="Select assignees" data-turbo="false" action="/rails/rails/issues/19377/assignees" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="F4wjA3/sVjjyTiPXJ1IsOuTx0gJjruqMM69MXtFizX1WswW8GjLLvFDCAERP/0tTa0ivuFsbgZzcN7EYUrFmyQ==" /> <div class="discussion-sidebar-heading text-bold"> Assignees </div> <span class="css-truncate js-issue-assignees"> No one assigned </span> </form></div> <div class="discussion-sidebar-item js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/issues/19377/show_partial?partial=issues%2Fsidebar%2Fshow%2Flabels" data-channel-event-name="labels_updated" > <div class="discussion-sidebar-heading text-bold"> Labels </div> <div class="js-issue-labels d-flex flex-wrap"> <a id="label-2215bd" href="/rails/rails/labels/actionpack" data-name="actionpack" style="--label-r:255;--label-g:247;--label-b:0;--label-h:58;--label-s:100;--label-l:50;" data-view-component="true" class="IssueLabel hx_IssueLabel width-fit mb-1 mr-1"> <span class="css-truncate css-truncate-target width-fit">actionpack</span> </a> </div> </div> <div class="discussion-sidebar-item js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/issues/19377/show_partial?partial=issues%2Fsidebar%2Fshow%2Fprojects" data-channel-event-name="projects_updated" > </option></form><form class="js-issue-sidebar-form" aria-label="Select projects" data-turbo="false" action="/rails/rails/projects/issues/19377" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="2kuqdJWf+xo1tlJvlNX/s2udJkOWLXBTLV6n4EaaaiLZoL4Pi0oxojBO43TRyJ7EHC343EJQfKbEFGIx+TaIOg==" /> <div class="discussion-sidebar-heading text-bold"> Projects </div> <div aria-live="polite"> </div> <span class="css-truncate sidebar-progress-bar"> None yet </span> </form> </div> <div class="discussion-sidebar-item sidebar-progress-bar js-discussion-sidebar-item js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjMxMzQxMDMxIiwidCI6MTczMjczNDkzMH0=--80140390637eb9240e0be7b445a83d1375a5f44041bfc3288acbb7b39ccbc5d6" data-gid="MDExOlB1bGxSZXF1ZXN0MzEzNDEwMzE=" data-url="/rails/rails/issues/19377/show_partial?partial=issues%2Fsidebar%2Fshow%2Fmilestone" data-channel-event-name="milestone_updated" > </option></form><form class="js-issue-sidebar-form" aria-label="Select milestones" data-turbo="false" action="/rails/rails/issues/19377/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="ENOUFPgAPmuwoKSbepkGOmp3YpdZmjVYSbYQChQ6Ke5d7wcXz/y9kt9zqjbX8mFunniYeYxFFnnsPOeQ/iN61g==" /> <div class="discussion-sidebar-heading text-bold"> Milestone </div> <span data-view-component="true" class="Progress mt-1 mb-2"> <span style="width: 100.0%;" data-view-component="true" class="Progress-item color-bg-success-emphasis"></span> </span> <a title="5.0.0" href="/rails/rails/milestone/47" class="Link--secondary mt-1 d-block text-bold css-truncate"> <strong class="css-truncate-target width-fit">5.0.0</strong> </a> </form></div> <create-branch data-default-repo="rails/rails" data-selected-nwo="rails/rails" data-default-source-branch="main" data-sidebar-url="/rails/rails/issues/closing_references/partials/sidebar?source_id=62416392&source_type=ISSUE" class="discussion-sidebar-item d-block"> <div class="js-discussion-sidebar-item" data-target="create-branch.sidebarContainer"> <div data-issue-and-pr-hovercards-enabled > <development-menu> </option></form><form data-target="create-branch.developmentForm" data-turbo="false" class="js-issue-sidebar-form" aria-label="Link issues" action="/rails/rails/issues/closing_references?source_id=31341031&source_type=PULL_REQUEST" accept-charset="UTF-8" method="post"><input type="hidden" name="_method" value="put" autocomplete="off" /><input type="hidden" data-csrf="true" name="authenticity_token" value="uKQqVfAFzQ2iZX873Rih2l0hyMsavvxHbcgA+6wiKvd0jQ2deY3f3P2a3mz2QYq0BDkC2WTTtvxTYdXWwARHOw==" /> <div class="discussion-sidebar-heading text-bold"> Development </div> <p>Successfully merging this pull request may close these issues.</p> <span data-view-component="true" class="Truncate truncate-with-responsive-width my-1"> <a href="https://github.com/rails/rails/issues/19036" data-hydro-click="{"event_type":"issue_cross_references.click","payload":{"reference_location":"PULL_REQUEST_SIDEBAR","user_id":null,"issue_id":58527495,"pull_request_id":31341031,"originating_url":"https://github.com/rails/rails/pull/19377"}}" data-hydro-click-hmac="976f4890507a77784ff06a7ab15f10fb5d57315752d1a63dc46eb595a3bea678" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/19036/hovercard" data-view-component="true" class="Truncate-text Link--primary markdown-title text-bold"> <svg class="octicon octicon-issue-closed closed" title="Closed" aria-label="Closed issue" viewBox="0 0 16 16" version="1.1" width="16" height="16" role="img"><path d="M11.28 6.78a.75.75 0 0 0-1.06-1.06L7.25 8.69 5.78 7.22a.75.75 0 0 0-1.06 1.06l2 2a.75.75 0 0 0 1.06 0l3.5-3.5Z"></path><path d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0Zm-1.5 0a6.5 6.5 0 1 0-13 0 6.5 6.5 0 0 0 13 0Z"></path></svg> Controller actions should default to head :ok if no template exists </a> </span> <include-fragment src="/rails/rails/pull/19377/partials/links?has_github_issues=true"></include-fragment> </form> </development-menu> </div> </div> </create-branch> <div id="partial-users-participants" class="discussion-sidebar-item"> <div class="participation"> <div class="discussion-sidebar-heading text-bold"> 8 participants </div> <div class="participation-avatars d-flex flex-wrap"> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/sb8244/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sb8244"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1231659?s=52&v=4" width="26" height="26" alt="@sb8244" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/rafaelfranca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rafaelfranca"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/47848?s=52&v=4" width="26" height="26" alt="@rafaelfranca" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/kaspth/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kaspth"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/350807?s=52&v=4" width="26" height="26" alt="@kaspth" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/dhh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhh"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/2741?s=52&v=4" width="26" height="26" alt="@dhh" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/eileencodes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/eileencodes"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1080678?s=52&v=4" width="26" height="26" alt="@eileencodes" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/clarkware/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/clarkware"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/4831?s=52&v=4" width="26" height="26" alt="@clarkware" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/matthewd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/matthewd"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/1034?s=52&v=4" width="26" height="26" alt="@matthewd" /> </a> <a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/georgeclaghorn/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/georgeclaghorn"> <img class="avatar avatar-user" src="https://avatars.githubusercontent.com/u/94129?s=52&v=4" width="26" height="26" alt="@georgeclaghorn" /> </a> </div> </div> </div> </div> </div> </div> </div> </div> <div hidden> <span class="js-add-to-batch-enabled">Add this suggestion to a batch that can be applied as a single commit.</span> <span class="js-unchanged-suggestion">This suggestion is invalid because no changes were made to the code.</span> <span class="js-closed-pull">Suggestions cannot be applied while the pull request is closed.</span> <span class="js-viewing-subset-changes">Suggestions cannot be applied while viewing a subset of changes.</span> <span class="js-one-suggestion-per-line">Only one suggestion per line can be applied in a batch.</span> <span class="js-reenable-add-to-batch">Add this suggestion to a batch that can be applied as a single commit.</span> <span class="js-validation-on-left-blob">Applying suggestions on deleted lines is not supported.</span> <span class="js-validation-on-right-blob">You must change the existing code in this line in order to create a valid suggestion.</span> <span class="js-outdated-comment">Outdated suggestions cannot be applied.</span> <span class="js-resolved-thread">This suggestion has been applied or marked resolved.</span> <span class="js-pending-review">Suggestions cannot be applied from pending reviews.</span> <span class="js-is-multiline">Suggestions cannot be applied on multi-line comments.</span> <span class="js-in-merge-queue">Suggestions cannot be applied while the pull request is queued to merge.</span> <span class="js-head-oid-not-loaded">Suggestion cannot be applied right now. Please check back later.</span> <div class="form-group errored m-0 error js-suggested-changes-inline-validation-template d-flex" style="cursor: default;"> <span class="js-suggested-changes-inline-error-message position-relative error m-0" style="max-width: inherit;"></span> </div> </div> </div> </div> </turbo-frame> </main> </div> </div> <footer class="footer pt-8 pb-6 f6 color-fg-muted p-responsive" role="contentinfo" > <h2 class='sr-only'>Footer</h2> <div class="d-flex flex-justify-center flex-items-center flex-column-reverse flex-lg-row flex-wrap flex-lg-nowrap"> <div class="d-flex flex-items-center flex-shrink-0 mx-2"> <a aria-label="Homepage" title="GitHub" class="footer-octicon mr-2" href="https://github.com"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <span> © 2024 GitHub, Inc. </span> </div> <nav aria-label="Footer"> <h3 class="sr-only" id="sr-footer-heading">Footer navigation</h3> <ul class="list-style-none d-flex flex-justify-center flex-wrap mb-2 mb-lg-0" aria-labelledby="sr-footer-heading"> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to Terms","label":"text:terms"}" href="https://docs.github.com/site-policy/github-terms/github-terms-of-service" data-view-component="true" class="Link--secondary Link">Terms</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to privacy","label":"text:privacy"}" href="https://docs.github.com/site-policy/privacy-policies/github-privacy-statement" data-view-component="true" class="Link--secondary Link">Privacy</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to security","label":"text:security"}" href="https://github.com/security" data-view-component="true" class="Link--secondary Link">Security</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to status","label":"text:status"}" href="https://www.githubstatus.com/" data-view-component="true" class="Link--secondary Link">Status</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to docs","label":"text:docs"}" href="https://docs.github.com/" data-view-component="true" class="Link--secondary Link">Docs</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to contact","label":"text:contact"}" href="https://support.github.com?tags=dotcom-footer" data-view-component="true" class="Link--secondary Link">Contact</a> </li> <li class="mx-2" > <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"cookies","context":"subfooter","tag":"link","label":"cookies_link_subfooter_footer"}" > Manage cookies </button> </cookie-consent-link> </li> <li class="mx-2"> <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"dont_share_info","context":"subfooter","tag":"link","label":"dont_share_info_link_subfooter_footer"}" > Do not share my personal information </button> </cookie-consent-link> </li> </ul> </nav> </div> </footer> <ghcc-consent id="ghcc" class="position-fixed bottom-0 left-0" style="z-index: 999999" data-initial-cookie-consent-allowed="" data-cookie-consent-required="false"></ghcc-consent> <div id="ajax-error-message" class="ajax-error-message flash flash-error" hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <button type="button" class="flash-close js-ajax-error-dismiss" aria-label="Dismiss error"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> You can’t perform that action at this time. </div> <template id="site-details-dialog"> <details class="details-reset details-overlay details-overlay-dark lh-default color-fg-default hx_rsm" open> <summary role="button" aria-label="Close dialog"></summary> <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast hx_rsm-dialog hx_rsm-modal"> <button class="Box-btn-octicon m-0 btn-octicon position-absolute right-0 top-0" type="button" aria-label="Close dialog" data-close-dialog> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div class="octocat-spinner my-6 js-details-dialog-spinner"></div> </details-dialog> </details> </template> <div class="Popover js-hovercard-content position-absolute" style="display: none; outline: none;"> <div class="Popover-message Popover-message--bottom-left Popover-message--large Box color-shadow-large" style="width:360px;"> </div> </div> <template id="snippet-clipboard-copy-button"> <div class="zeroclipboard-container position-absolute right-0 top-0"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn js-clipboard-copy m-2 p-0" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon m-2"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none m-2"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> <template id="snippet-clipboard-copy-button-unpositioned"> <div class="zeroclipboard-container"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn btn-invisible js-clipboard-copy m-2 p-0 d-flex flex-justify-center flex-items-center" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> </div> <div id="js-global-screen-reader-notice" class="sr-only mt-n1" aria-live="polite" aria-atomic="true" ></div> <div id="js-global-screen-reader-notice-assertive" class="sr-only mt-n1" aria-live="assertive" aria-atomic="true"></div> </body> </html>