CINXE.COM
php.internals: Changes to Git commit workflow
<!doctype html> <html lang="en"> <head> <meta charset="utf-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>php.internals: Changes to Git commit workflow</title> <link href="//fonts.googleapis.com/css?family=Fira+Sans|Source+Sans+Pro:300,400,600,400italic,600italic|Source+Code+Pro&subset=latin,latin-ext" rel="stylesheet"> <link rel="stylesheet" href="/style.css" type="text/css" /> <link rel="shortcut icon" href="//php.net/favicon.ico"> </head> <body> <header class="header"> <nav class="header-inner"> <a href="/" class="header-brand"> <img src="//php.net/images/logos/php-logo.svg" class="header-brand-img" alt="PHP" height="24" width="48"> <span class="header-brand-text">lists</span> </a> <ul class="header-menu"> <li class="header-menu-item"> <a class="header-menu-item-link" href="https://php.net/downloads.php">Downloads</a> </li> <li class="header-menu-item"> <a class="header-menu-item-link" href="https://php.net/docs.php">Documentation</a> </li> <li class="header-menu-item"> <a class="header-menu-item-link" href="https://php.net/get-involved.php">Get Involved</a> </li> <li class="header-menu-item mod-active"> <a class="header-menu-item-link" href="https://php.net/support.php">Help</a> </li> </ul> <form class="search-form" action="https://php.net/search.php"> <input class="search-input" value="" name="pattern" placeholder="Search"> </form> <div class="menu-icon" onclick="document.querySelector('.menu-mobile').classList.toggle('hide')">☰ MENU</div> <ul class="menu-mobile hide"> <li class="menu-mobile-item"> <a class="menu-mobile-item-link" href="https://php.net/downloads.php">Downloads</a> </li> <li class="menu-mobile-item"> <a class="menu-mobile-item-link" href="https://php.net/docs.php">Documentation</a> </li> <li class="menu-mobile-item"> <a class="menu-mobile-item-link" href="https://php.net/get-involved.php">Get Involved</a> </li> <li class="menu-mobile-item mod-active"> <a class="menu-mobile-item-link" href="https://php.net/support.php">Help</a> </li> </ul> </nav> </header> <nav class="secondary-nav"> <ul class="breadcrumbs"> <li class="breadcrumbs-item"><a class="breadcrumbs-item-link" href="/">PHP Mailing Lists</a></li> <li class="breadcrumbs-item"><a class="breadcrumbs-item-link" href="/php.internals">php.internals</a></li> <li class="breadcrumbs-item"><a class="breadcrumbs-item-link" href="/php.internals/113838">Changes to Git commit workflow</a></li> </ul></nav><section class="content"><h1>Changes to Git commit workflow</h1> <blockquote> <table class="standard"> <tr class="vcard"> <td class="headerlabel">From:</td> <td class="headervalue"><a href="mailto:nikita+dot+ppv+at+gmail+dot+com" class="email fn n">Nikita Popov</a></td> <td class="headerlabel">Date:</td> <td class="headervalue">Sun, 28 Mar 2021 22:52:24 +0000</td> </tr> <tr> <td class="headerlabel">Subject:</td> <td class="headervalue" colspan="3">Changes to Git commit workflow</td> </tr> <tr> <td class="headerlabel">Groups:</td> <td class="headervalue" colspan="3"><a href="/php.doc">php.doc</a> <a href="/php.internals">php.internals</a> </td> </tr> <tr> <td class="headerlabel">Request:</td> <td class="headervalue" colspan="3">Send a blank email to <a href="mailto:internals+get-113838@lists.php.net">internals+get-113838@lists.php.net</a> to get a copy of this message</td> </tr> <tr> </table> </blockquote> <blockquote> <pre> Hi everyone, Yesterday (2021-03-28) two malicious commits were pushed to the php-src repo [1] from the names of Rasmus Lerdorf and myself. We don't yet know how exactly this happened, but everything points towards a compromise of the git.php.net server (rather than a compromise of an individual git account). While investigation is still underway, we have decided that maintaining our own git infrastructure is an unnecessary security risk, and that we will discontinue the git.php.net server. Instead, the repositories on GitHub, which were previously only mirrors, will become canonical. This means that changes should be pushed directly to GitHub rather than to git.php.net. While previously write access to repositories was handled through our home-grown karma system, you will now need to be part of the php organization on GitHub. If you are not part of the organization yet, or don't have access to a repository you should have access to, contact me at nikic@php.net with your php.net and GitHub account names, as well as the permissions you're currently missing. Membership in the organization requires 2FA to be enabled. This change also means that it is now possible to merge pull requests directly from the GitHub web interface. We're reviewing the repositories for any corruption beyond the two referenced commits. Please contact security@php.net if you notice anything. Regards, Nikita [1]: <a href="https://github.com/php/php-src/commit/c730aa26bd52829a49f2ad284b181b7e82a68d7d">https://github.com/php/php-src/commit/c730aa26bd52829a49f2ad284b181b7e82a68d7d</a> and <a href="https://github.com/php/php-src/commit/2b0f239b211c7544ebc7a4cd2c977a5b7a11ed8a">https://github.com/php/php-src/commit/2b0f239b211c7544ebc7a4cd2c977a5b7a11ed8a</a><br><br> </pre> </blockquote> <blockquote> <h2> Thread (1 message) </h2> <div class="responsive-table"> <table class="standard"> <thead> <tr> <th>#</th> <th>Subject</th> <th>Author</th> <th>Date</th> </tr> </thead> <tbody> <tr> <td align="center"><a href="/php.internals/113838">113838</a></td> <td><a href="/php.internals/113838">Changes to Git commit workflow</a></td> <td class="vcard"><a href="mailto:nikita+dot+ppv+at+gmail+dot+com" class="email fn n">Nikita Popov</a></td> <td class="align-center"><span class='monospace mod-small'>Sun, 28 Mar 2021 22:52:24 +0000</span></td> </tr> </tbody> </table> </div> </blockquote> <table class="standard"> <tr> <th class="nav"> <a href="/php.internals/113837"><b>« <span>previous</span></b></a> </th> <th class="align-center">php.internals (#113838)</th> <th class="nav align-right"> <a href="/php.internals/113839"><b><span>next</span> »</b></a> </th> </tr> </table> </section> <footer class="footer"> <ul class="footer-nav"> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/copyright.php"> Copyright ©2001-2025 The PHP Group </a> </li> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/my.php">My PHP.net</a> </li> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/contact.php">Contact</a> </li> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/sites.php">Other PHP.net sites</a> </li> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/mirrors.php">Mirror sites</a> </li> <li class="footer-nav-item"> <a class="footer-nav-item-link" href="https://php.net/privacy.php">Privacy policy</a> </li> </ul> </footer> </body> </html>