CINXE.COM
LKML: Greg KH: [PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Greg KH: [PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Greg KH" href="/groupie.php?aid=45" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/1"> [1]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/1/308" onclick="this.href='/lkml/headers'+'/2005/4/1/308';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/1/308">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/4/1/275">First message in thread</a></li><li><a href="/lkml/2005/4/1/291">Greg KH</a><ul><li><a href="/lkml/2005/4/1/306">Greg KH</a><ul><li class="origin"><a href="/lkml/2005/4/1/279">Greg KH</a><ul><li><a href="/lkml/2005/4/1/279">Greg KH</a><ul><li><a href="/lkml/2005/4/1/282">Greg KH</a></li></ul></li></ul></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/1/308/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Subject</td><td class="rp" itemprop="name">[PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 1 Apr 2005 15:47:52 -0800</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Greg KH <></td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">ChangeSet 1.2181.16.16, 2005/03/17 14:50:04-08:00, akpm@osdl.org<br /><br />[PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro<br /><br />From: Domen Puncer <domen@coderock.org><br /><br />As requested by Christoph Hellwig I created a new macro called<br />for_each_pci_dev. It is a wrapper for this common use of<br />pci_get/find_device:<br /><br />(while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL))<br /><br />This macro will return the pci_dev *for all pci devices. Here is the first<br />patch I used to test this macro with. Compiled and booted on my T23.<br />There will be 53 more patches using this new macro.<br /><br />Signed-off-by: Hanna Linder <hannal@us.ibm.com><br />Signed-off-by: Maximilian Attems <janitor@sternwelten.at><br />Signed-off-by: Domen Puncer <domen@coderock.org><br />Signed-off-by: Andrew Morton <akpm@osdl.org><br />Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de><br /><br /><br /> arch/i386/pci/i386.c | 4 ++--<br /> 1 files changed, 2 insertions(+), 2 deletions(-)<br /><br /><br />diff -Nru a/arch/i386/pci/i386.c b/arch/i386/pci/i386.c<br />--- a/arch/i386/pci/i386.c 2005-04-01 15:34:37 -08:00<br />+++ b/arch/i386/pci/i386.c 2005-04-01 15:34:37 -08:00<br />@@ -124,7 +124,7 @@<br /> u16 command;<br /> struct resource *r, *pr;<br /> <br />- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {<br />+ for_each_pci_dev(dev) {<br /> pci_read_config_word(dev, PCI_COMMAND, &command);<br /> for(idx = 0; idx < 6; idx++) {<br /> r = &dev->resource[idx];<br />@@ -168,7 +168,7 @@<br /> int idx;<br /> struct resource *r;<br /> <br />- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {<br />+ for_each_pci_dev(dev) {<br /> int class = dev->class >> 8;<br /> <br /> /* Don't touch classless devices and host bridges */<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-06 13:31 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>