32575 – gather_print_notices.pl sends attachment as body of email or poorly named txt file

<!DOCTYPE html> <html lang="en"> <head><meta property="og:type" content="website"> <meta property="og:title" content="32575 – gather_print_notices.pl sends attachment as body of email or poorly named txt file"> <meta property="og:url" content="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32575"> <meta property="og:description" content="normal, P5 - low, assigned to dcook, Pushed to oldstable, in Notices, Koha , in version(s) 24.11.00,24.05.06,23.11.11 "> <title>32575 – gather_print_notices.pl sends attachment as body of email or poorly named txt file</title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1"> <link href="data/assets/7639320ab60877a84a229ebf974149a6.css" rel="stylesheet" type="text/css"> <script type="text/javascript" src="data/assets/a7c2f3a028f17a9aa60f56dc9d6e732d.js"></script> <script type="text/javascript">  </script> <script type="text/javascript" src="data/assets/daf5e0fb6826e6a35280e622913f0c4a.js"></script> <link rel="search" type="application/opensearchdescription+xml" title="Bugzilla" href="./search_plugin.cgi"> <link rel="shortcut icon" href="images/favicon.ico"><meta name="robots" content="noarchive"> </head> <body class="bugs-koha-community-org-bugzilla3 bz_bug bz_status_Pushed_to_oldstable bz_product_Koha bz_component_Notices bz_bug_32575 yui-skin-sam"> <div id="header"><div id="banner"> </div> <div id="titles"> <span id="title">Bugzilla – Bug 32575</span> <span id="subtitle" class="subheader">gather_print_notices.pl sends attachment as body of email or poorly named txt file</span> <span id="information" class="header_addl_info">Last modified: 2024-12-03 03:44:55 UTC</span> </div> <div id="common_links"><ul class="links"> <li><a href="./">Home</a></li> <li><span class="separator">| </span><a href="enter_bug.cgi">New</a></li> <li><span class="separator">| </span><a href="describecomponents.cgi">Browse</a></li> <li><span class="separator">| </span><a href="query.cgi">Search</a></li> <li class="form"> <span class="separator">| </span> <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') { alert('Please enter one or more search terms first.'); return false; } return true;"> <input type="hidden" id="no_redirect_top" name="no_redirect" value="0"> <script type="text/javascript"> if (history && history.replaceState) { var no_redirect = document.getElementById("no_redirect_top"); no_redirect.value = 1; } </script> <input class="txt" type="text" id="quicksearch_top" name="quicksearch" aria-labelledby="find_top" title="Quick Search" value=""> <input class="btn" type="submit" value="Search" id="find_top"></form> <a href="page.cgi?id=quicksearch.html" title="Quicksearch Help">[?]</a></li> <li><span class="separator">| </span><a href="report.cgi">Reports</a></li> <li></li> <li> <span class="separator">| </span> <a href="https://bugzilla.readthedocs.org/en/5.2/using/understanding.html" target="_blank">Help</a> </li> <li id="new_account_container_top"> <span class="separator">| </span> <a href="createaccount.cgi">New Account</a> </li> <li id="mini_login_container_top"> <span class="separator">| </span> <a id="login_link_top" href="show_bug.cgi?id=32575&GoAheadAndLogIn=1" onclick="return show_mini_login_form('_top')">Log In</a> <form action="show_bug.cgi?id=32575" method="POST" class="mini_login bz_default_hidden" id="mini_login_top"> <input id="Bugzilla_login_top" required name="Bugzilla_login" class="bz_login" type="email" placeholder="Email Address"> <input class="bz_password" name="Bugzilla_password" type="password" id="Bugzilla_password_top" required placeholder="Password"> <input type="hidden" name="Bugzilla_login_token" value=""> <input type="submit" name="GoAheadAndLogIn" value="Log in" id="log_in_top"> <a href="#" onclick="return hide_mini_login_form('_top')">[x]</a> </form> </li> <li id="forgot_container_top"> <span class="separator">| </span> <a id="forgot_link_top" href="show_bug.cgi?id=32575&GoAheadAndLogIn=1#forgot" onclick="return show_forgot_form('_top')">Forgot Password</a> <form action="token.cgi" method="post" id="forgot_form_top" class="mini_forgot bz_default_hidden"> <label for="login_top">Login:</label> <input name="loginname" size="20" id="login_top" required type="email" placeholder="Your Email Address"> <input id="forgot_button_top" value="Reset Password" type="submit"> <input type="hidden" name="a" value="reqpw"> <input type="hidden" id="token_top" name="token" value="1740154459-POoeqsgbrays8hYIq2bc88UeO-OIruwDGzQqX81I2zw"> <a href="#" onclick="return hide_forgot_form('_top')">[x]</a> </form> </li> </ul> </div> </div> <div id="bugzilla-body"> <script type="text/javascript">  </script> <form name="changeform" id="changeform" method="post" action="process_bug.cgi"> <input type="hidden" name="delta_ts" value="2024-12-03 03:44:55"> <input type="hidden" name="id" value="32575"> <input type="hidden" name="token" value="1740154459-jNRiccx_lZHP3xwEk6Dw1GzVCIRaK6RC7iaybuZjLQo"> <div class="bz_short_desc_container edit_form"> <a href="show_bug.cgi?id=32575"><b>Bug 32575</b></a> <span id="summary_container" class="bz_default_hidden"> - <span id="short_desc_nonedit_display">gather_print_notices.pl sends attachment as body of email or poorly named txt file</span> </span> <div id="summary_input"><span class="field_label " id="field_label_short_desc"> <a title="The bug summary is a short sentence which succinctly describes what the bug is about." class="field_help_link" href="page.cgi?id=fields.html#short_desc" >Summary:</a> </span><span title="gather_print_notices.pl sends attachment as body of email or poorly named txt file">gather_print_notices.pl sends attachment as body of email or poorly named txt... </span> </div> </div> <script type="text/javascript"> hideEditableField('summary_container', 'summary_input', 'summary_edit_action', 'short_desc', 'gather_print_notices.pl sends attachment as body of email or poorly named txt file' ); </script> <table class="edit_form"> <tr> <td id="bz_show_bug_column_1" class="bz_show_bug_column"> <table> <tr> <th class="field_label"> <a href="page.cgi?id=fields.html#bug_status">Status</a>: </th> <td id="bz_field_status"> <span id="static_bug_status">Pushed to oldstable </span> </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_alias"> <a title="A short, unique name assigned to a bug in order to assist with looking it up and referring to it in other places in Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#alias" >Alias:</a> </th> <td> None </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_product"> <a title="Bugs are categorised into Products and Components." class="field_help_link" href="describecomponents.cgi" >Product:</a> </th> <td class="field_value " id="field_container_product" >Koha </td> </tr> <tr class="bz_default_hidden"><th class="field_label " id="field_label_classification"> <a title="Bugs are categorised into Classifications, Products and Components. classifications is the top-level categorisation." class="field_help_link" href="page.cgi?id=fields.html#classification" >Classification:</a> </th> <td class="field_value " id="field_container_classification" >Unclassified </td> </tr> <tr><th class="field_label " id="field_label_component"> <a title="Components are second-level categories; each belongs to a particular Product. Select a Product to narrow down this list." class="field_help_link" href="describecomponents.cgi?product=Koha" >Component:</a> </th> <td class="field_value " id="field_container_component" >Notices (<a href="buglist.cgi?component=Notices&product=Koha&bug_status=__open__" target="_blank">show other bugs</a>) </td> </tr> <tr><th class="field_label " id="field_label_version"> <a title="The version field defines the version of the software the bug was found in." class="field_help_link" href="page.cgi?id=fields.html#version" >Version:</a> </th> <td>Main </td> </tr> <tr><th class="field_label " id="field_label_rep_platform"> <a title="The hardware platform the bug was observed on. Note: When searching, selecting the option "All" only finds bugs whose value for this field is literally the word "All"." class="field_help_link" href="page.cgi?id=fields.html#rep_platform" >Hardware:</a> </th> <td class="field_value">All All </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr> <th class="field_label"> <label accesskey="i"> <a href="page.cgi?id=fields.html#importance"><u>I</u>mportance</a></label>: </th> <td>P5 - low normal </td> </tr> <tr><th class="field_label " id="field_label_assigned_to"> <a title="The person in charge of resolving the bug." class="field_help_link" href="page.cgi?id=fields.html#assigned_to" >Assignee:</a> </th> <td><span class="vcard"><span class="fn">David Cook</span> </span> </td> </tr> <tr><th class="field_label " id="field_label_qa_contact"> <a title="The person responsible for confirming this bug if it is unconfirmed, and for verifying the fix once the bug has been resolved." class="field_help_link" href="page.cgi?id=fields.html#qa_contact" >QA Contact:</a> </th> <td><span class="vcard"><span class="fn">Marcel de Rooy</span> </span> </td> </tr> <script type="text/javascript"> assignToDefaultOnChange(['product', 'component'], 'koha-bugs\x40lists.koha-community.org', 'testopia\x40bugs.koha-community.org'); </script> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_bug_file_loc"> <a title="Bugs can have a URL associated with them - for example, a pointer to a web site where the problem is seen." class="field_help_link" href="page.cgi?id=fields.html#bug_file_loc" >URL:</a> </th> <td> <span id="bz_url_input_area"> </span> </td> </tr> <tr><th class="field_label " id="field_label_keywords"> <a title="You can add keywords from a defined list to bugs, in order to easily identify and group them." class="field_help_link" href="describekeywords.cgi" >Keywords:</a> </th> <td class="field_value " id="field_container_keywords" > </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_dependson"> <a title="The bugs listed here must be resolved before this bug can be resolved." class="field_help_link" href="page.cgi?id=fields.html#dependson" >Depends on:</a> </th> <td> <span id="dependson_input_area"> </span> </td> </tr> <tr><th class="field_label " id="field_label_blocked"> <a title="This bug must be resolved before the bugs listed in this field can be resolved." class="field_help_link" href="page.cgi?id=fields.html#blocked" >Blocks:</a> </th> <td> <span id="blocked_input_area"> </span> </td> </tr> </table> </td> <td> <div class="bz_column_spacer"> </div> </td> <td id="bz_show_bug_column_2" class="bz_show_bug_column"> <table> <tr> <th class="field_label"> Reported: </th> <td>2023-01-06 10:40 UTC by <span class="vcard"><span class="fn">Magnus Enger</span> </span> </td> </tr> <tr> <th class="field_label"> Modified: </th> <td>2024-12-03 03:44 UTC (<a href="show_activity.cgi?id=32575">History</a>) </td> </tr> <tr> <th class="field_label"> <label accesskey="a"> CC List: </label> </th> <td>5 users <span id="cc_edit_area_showhide_container" class="bz_default_hidden"> (<a href="#" id="cc_edit_area_showhide">show</a>) </span> <div id="cc_edit_area"> <br> <select id="cc" multiple="multiple" size="5" > <option value="david">david</option> <option value="dcook">dcook</option> <option value="fridolin.somers">fridolin.somers</option> <option value="lucas">lucas</option> <option value="m.de.rooy">m.de.rooy</option> </select> </div> <script type="text/javascript"> hideEditableField( 'cc_edit_area_showhide_container', 'cc_edit_area', 'cc_edit_area_showhide', '', ''); </script> </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_see_also"> <a title="This allows you to refer to bugs in other installations. You can enter a URL to a bug in the 'Add Bug URLs' field to note that that bug is related to this one. You can enter multiple URLs at once by separating them with whitespace. You should normally use this field to refer to bugs in other installations. For bugs in this installation, it is better to use the Depends on and Blocks fields." class="field_help_link" href="page.cgi?id=fields.html#see_also" >See Also:</a> </th> <td class="field_value " id="field_container_see_also" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_sponsorship"> <a title="A custom Drop Down field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_sponsorship" >Change sponsored?:</a> </th> <td class="field_value " id="field_container_cf_sponsorship" >--- </td> </tr> <tr> <th class="field_label " id="field_label_cf_patch_complexity"> <a title="A custom Drop Down field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_patch_complexity" >Patch complexity:</a> </th> <td class="field_value " id="field_container_cf_patch_complexity" >Small patch </td> </tr> <tr> <th class="field_label " id="field_label_cf_docs_contact"> <a title="The person taking responsibility for documenting the change introduced in this bug." class="field_help_link" href="page.cgi?id=fields.html#cf_docs_contact" >Documentation contact:</a> </th> <td class="field_value " id="field_container_cf_docs_contact" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_manual"> <a title="gitlab merge request url for this documentation submission" class="field_help_link" href="page.cgi?id=fields.html#cf_manual" >Documentation submission:</a> </th> <td class="field_value " id="field_container_cf_manual" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_release_notes"> <a title="A custom Large Text Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_release_notes" >Text to go in the release notes:</a> </th> <td class="field_value " id="field_container_cf_release_notes" > <div class="uneditable_textarea">This fixes emails generated by the misc/cronjobs/gather_print_notices.pl script. It adds empty text to the body of the email, so that the HTML file with the print notices is correctly attached to the email, and can be correctly printed. Because of the way the notices were being sent, and the way that different email clients handle different types of attachments, the notices were sometimes inserted into the body of the email or attached as poorly named text files.</div> </td> </tr> <tr> <th class="field_label " id="field_label_cf_release_version"> <a title="A custom Large Text Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_release_version" >Version(s) released in:</a> </th> <td class="field_value " id="field_container_cf_release_version" > <div class="uneditable_textarea">24.11.00,24.05.06,23.11.11</div> </td> </tr> <tr> <th class="field_label bz_hidden_field" id="field_label_cf_circulation_subcomponent"> <a title="A custom Multiple-Selection Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_circulation_subcomponent" >Circulation function:</a> </th> <td class="field_value bz_hidden_field" id="field_container_cf_circulation_subcomponent" > </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> </table> </td> </tr> <tr> <td colspan="3"> <hr id="bz_top_half_spacer"> </td> </tr> </table> <table id="bz_big_form_parts"> <tr> <td> <script type="text/javascript">  </script> <br> <table id="attachment_table"> <tr id="a0"> <th colspan="2" class="left"> Attachments </th> </tr> <tr id="a1" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=167779" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 32575: Tidy patch</span></b></a> <span class="bz_attach_extra_info"> (912 bytes, patch) <br> <a href="#attach_167779" title="Go to the comment associated with the attachment">2024-06-17 02:27 UTC</a>, <span class="vcard"><span class="fn">David Cook</span> </span> </span> </td> <td> <a href="attachment.cgi?id=167779&action=edit">Details</a> | <a href="attachment.cgi?id=167779&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=167779"> Splinter Review</a> </td> </tr> <tr id="a2" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=167780" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 32575: Add an empty text body to fix multipart/mixed handling</span></b></a> <span class="bz_attach_extra_info"> (1.15 KB, patch) <br> <a href="#attach_167780" title="Go to the comment associated with the attachment">2024-06-17 02:28 UTC</a>, <span class="vcard"><span class="fn">David Cook</span> </span> </span> </td> <td> <a href="attachment.cgi?id=167780&action=edit">Details</a> | <a href="attachment.cgi?id=167780&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=167780"> Splinter Review</a> </td> </tr> <tr id="a3" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=167781" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 32575: Tidy patch</span></b></a> <span class="bz_attach_extra_info"> (912 bytes, patch) <br> <a href="#attach_167781" title="Go to the comment associated with the attachment">2024-06-17 02:28 UTC</a>, <span class="vcard"><span class="fn">David Cook</span> </span> </span> </td> <td> <a href="attachment.cgi?id=167781&action=edit">Details</a> | <a href="attachment.cgi?id=167781&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=167781"> Splinter Review</a> </td> </tr> <tr id="a4" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=167820" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 32575: Add an empty text body to fix multipart/mixed handling</span></b></a> <span class="bz_attach_extra_info"> (1.26 KB, patch) <br> <a href="#attach_167820" title="Go to the comment associated with the attachment">2024-06-18 09:05 UTC</a>, <span class="vcard"><span class="fn">Magnus Enger</span> </span> </span> </td> <td> <a href="attachment.cgi?id=167820&action=edit">Details</a> | <a href="attachment.cgi?id=167820&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=167820"> Splinter Review</a> </td> </tr> <tr id="a5" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=167821" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 32575: Tidy patch</span></b></a> <span class="bz_attach_extra_info"> (963 bytes, patch) <br> <a href="#attach_167821" title="Go to the comment associated with the attachment">2024-06-18 09:05 UTC</a>, <span class="vcard"><span class="fn">Magnus Enger</span> </span> </span> </td> <td> <a href="attachment.cgi?id=167821&action=edit">Details</a> | <a href="attachment.cgi?id=167821&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=167821"> Splinter Review</a> </td> </tr> <tr id="a6" class="bz_contenttype_text_plain bz_patch"> <td> <a href="attachment.cgi?id=168225" title="View the content of the attachment"> <b>Bug 32575: Add an empty text body to fix multipart/mixed handling</b></a> <span class="bz_attach_extra_info"> (1.63 KB, patch) <br> <a href="#attach_168225" title="Go to the comment associated with the attachment">2024-06-28 07:33 UTC</a>, <span class="vcard"><span class="fn">Marcel de Rooy</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168225&action=edit">Details</a> | <a href="attachment.cgi?id=168225&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32575&attachment=168225"> Splinter Review</a> </td> </tr> <tr class="bz_attach_footer"> <td colspan="2"> <span class="bz_attach_view_hide"> <a href="#a0" onclick="return toggle_display(this);">Show Obsolete</a> (5) <a id="view_all" href="attachment.cgi?bugid=32575&action=viewall&hide_obsolete=1">View All</a> </span> <a href="attachment.cgi?bugid=32575&action=enter">Add an attachment</a> (proposed patch, testcase, etc.) </td> </tr> </table> <br> <div id="add_comment" class="bz_section_additional_comments"> <table> <tr> <td> <fieldset> <legend>Note</legend> You need to <a href="show_bug.cgi?id=32575&GoAheadAndLogIn=1">log in</a> before you can comment on or make changes to this bug. </fieldset> </td> </tr> </table> </div> </td> <td> </td> </tr></table> <div id="comments"><script src="js/comments.js" type="text/javascript"> </script> <script type="text/javascript">  </script>  <table class="bz_comment_table"> <tr> <td> <div id="c0" class="bz_comment bz_first_comment"> <div class="bz_first_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c0">Description</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Magnus Enger</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2023-01-06 10:40:50 UTC </span> </div> <pre class="bz_comment_text">gather_print_notices.pl can send print notices to the library, as an HTML file attached to an email. At least some libraries report that the HTML does not come as an attached file, but as the body of the email. This breaks printing the notices properly. I am not sure if this is a problem with the emails generated by gather_print_notices.pl or with the email clients (or other software) used by the libraries that have this problem. A quick solution has been to add some body text to the emails generated by gather_print_notices.pl: 299 my $email = Koha::Email->create( 300 { 301 from => $from, 302 to => $to, 303 subject => 'Print notices for ' . $today_syspref, 304 text_body => 'See attached file.', # <==== Added this 305 } 306 ); This seems to force the attachment to be seen as an attachment, and not as the body of the email. In the headers of the emails sent by the standard gather_print_notices.pl I have seen this: Content-Transfer-Encoding: base64 Content-Type: text/html; charset=iso-8859-1 PCFET0NU... [lots of base64] When I have added some body text it looks more like this: Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="16633311691.0Ab5.3555417" --16633311691.0Ab5.3555417 Date: Fri, 16 Sep 2022 14:26:09 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable See attached file. --16633311691.0Ab5.3555417 Date: Fri, 16 Sep 2022 14:26:09 +0200 MIME-Version: 1.0 Content-Type: text/html; name="notices_all-2022-09-16-KOHA.html" Content-Disposition: attachment; filename="notices_all-2022-09-16-KOHA.html" Content-Transfer-Encoding: base64 PCFET0... [lots of base64] So unless something is changed on the way from Koha to the mail client, it looks like gather_print_notices.pl sends the HTML from the document as the body of the email. Not sure if this is a problem in Koha::Email->create that should be fixed there, or if it makes sense to just add some default text to the email, to fix the problem in the least obtrusive way?</pre> </div> <div id="c1" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c1">Comment 1</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 01:53:00 UTC </span> </div> <pre class="bz_comment_text">Most of my clients don't use this script, but I have bumped into this issue with those that do. I'm also able to reproduce it using koha-testing-docker, a quick Perl script, and an external SMTP server. -- If you look at Email::Stuffer::email() and Email::MIME::parts_set(), it becomes clear that if Email::Stuffer only has 1 part (e.g. an attachment), it will always be sent out as a single part email (ie direct attachment) and not a multipart. It seems that different email clients handle single part emails differently. As Magnus has observed, sometimes the HTML is in the body of an email. I see CSVs get added as attachments with the subject line of the email as the filename plus ".txt" at the end. I think the best practice is to use "multipart/mixed" even when there is only a single part as it has the best email client compatibility. But that's not how Email::MIME seems to work. -- In the past, I've solved this the same way Magnus has by adding a "text_body" value. Even if it's just " ", it would work. However, it appears that an alternative is just to set the "Content-Type" header at the email level.</pre> </div> <div id="c2" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c2">Comment 2</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 01:56:14 UTC </span> </div> <pre class="bz_comment_text">Here's a little test program for using in koha-testing-docker: #!/usr/bin/perl use Modern::Perl; use C4::Context; use Koha::Email; use Koha::SMTP::Servers; my $transport = Koha::SMTP::Servers->get_default->transport; my $email = Koha::Email->create( { from => C4::Context->preference('KohaAdminEmailAddress'), to => '<a href="mailto:your@email.address">your@email.address</a>', subject => 'My test email', } ); $email->header('Content-Type' => 'multipart/mixed'); my $filepath = '/tmp/notices_ODUE3-2024-06-17.csv'; my $filename = 'notices_ODUE3-2024-06-17.csv'; my $mimetype = 'text/csv'; $email->attach_file( $filepath, content_type => $mimetype, charset => 'UTF-8', name => $filename, disposition => 'attachment', ); $email->send_or_die( { transport => $transport } ); -- Some steps: 1. Set up the SMTP server config in koha-conf.xml for a server that works 2. Set up a valid email sender in KohaAdminEmailAddress 3. Create a little CSV file at /tmp/notices_ODUE3-2024-06-17.csv 4. Run the program</pre> </div> <div id="c3" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c3">Comment 3</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 02:20:19 UTC </span> </div> <pre class="bz_comment_text">One disadvantage of explicitly setting the Content-Type at the email level in lieu of a text body (empty or otherwise) is that it appears SMTP injected footers don't get added. So I'm actually inclined to go with an empty text body, so that SMTP servers can still add their footers. I'm hesitant to put in a text body of "See attached file" just because it would be hard-coded to English, and I think creating a whole notice template for gather_print_notices.pl is a bit overkill at this point.</pre> </div> <div id="c4" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c4">Comment 4</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 02:27:08 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=167779&action=diff" name="attach_167779" title="Bug 32575: Tidy patch">attachment 167779</a> <a href="attachment.cgi?id=167779&action=edit" title="Bug 32575: Tidy patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=167779'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch</pre> </div> <div id="c5" class="bz_comment bz_default_collapsed"> <div class="bz_comment_head"> <span class="bz_comment_actions"> <script type="text/javascript"> addCollapseLink(5, 1, 'Toggle comment display'); </script> </span> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c5">Comment 5</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 02:28:00 UTC </span> <span id="cr5" class="bz_comment_collapse_reason" title="David Cook [2024-06-17 02:28:00 UTC]"> Comment hidden (obsolete) </span> </div> <pre class="bz_comment_text collapsed" id="comment_text_5">Created <span class="bz_obsolete"><a href="attachment.cgi?id=167780&action=diff" name="attach_167780" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">attachment 167780</a> <a href="attachment.cgi?id=167780&action=edit" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=167780'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Add an empty text body to fix multipart/mixed handling By adding an empty text body, we force Email::Stuffer/Email::MIME to use multipart/mixed handling for the attachment instead of forcing a single part (ie direct attachment) email, which is not consistently handled by different email clients. An empty text body is language-neutral (ie not imposing English), and it allows SMTP servers to inject organisational footers into the email (e.g. confidentiality notices).</pre> </div> <div id="c6" class="bz_comment bz_default_collapsed"> <div class="bz_comment_head"> <span class="bz_comment_actions"> <script type="text/javascript"> addCollapseLink(6, 1, 'Toggle comment display'); </script> </span> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c6">Comment 6</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 02:28:03 UTC </span> <span id="cr6" class="bz_comment_collapse_reason" title="David Cook [2024-06-17 02:28:03 UTC]"> Comment hidden (obsolete) </span> </div> <pre class="bz_comment_text collapsed" id="comment_text_6">Created <span class="bz_obsolete"><a href="attachment.cgi?id=167781&action=diff" name="attach_167781" title="Bug 32575: Tidy patch">attachment 167781</a> <a href="attachment.cgi?id=167781&action=edit" title="Bug 32575: Tidy patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=167781'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch</pre> </div> <div id="c7" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c7">Comment 7</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 02:30:36 UTC </span> </div> <pre class="bz_comment_text">This is a tough one to test on koha-testing-docker, as you need an available SMTP server. To test the script itself, you'd need to generate notices as well. It's a pretty simple change overall, and the program I added in the comments earlier can prove the concept for anyone who has a SMTP server available for their ktd...</pre> </div> <div id="c8" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c8">Comment 8</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 04:48:08 UTC </span> </div> <pre class="bz_comment_text">Of course, I notice that the subject is hard coded to English with: "Print notices for " . $today_syspref. Maybe it's not a drama to have the body text in English? Or have some default text that is overridden using a CLI option?</pre> </div> <div id="c9" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c9">Comment 9</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 18:46:16 UTC </span> </div> <pre class="bz_comment_text">Could we maybe clarify the description of the bug a bit?</pre> </div> <div id="c10" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c10">Comment 10</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-17 23:05:02 UTC </span> </div> <pre class="bz_comment_text">(In reply to Katrin Fischer from <a href="show_bug.cgi?id=32575#c9">comment #9</a>) <span class="quote">> Could we maybe clarify the description of the bug a bit?</span > When no text/html body is added to the email (which is always with this email), attachments aren't attached correctly.</pre> </div> <div id="c11" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c11">Comment 11</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Magnus Enger</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-18 09:05:04 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=167820&action=diff" name="attach_167820" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">attachment 167820</a> <a href="attachment.cgi?id=167820&action=edit" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=167820'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Add an empty text body to fix multipart/mixed handling By adding an empty text body, we force Email::Stuffer/Email::MIME to use multipart/mixed handling for the attachment instead of forcing a single part (ie direct attachment) email, which is not consistently handled by different email clients. An empty text body is language-neutral (ie not imposing English), and it allows SMTP servers to inject organisational footers into the email (e.g. confidentiality notices). Signed-off-by: Magnus Enger <<a href="mailto:magnus@libriotech.no">magnus@libriotech.no</a>> I have tested this solution in production, and it works for me.</pre> </div> <div id="c12" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c12">Comment 12</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Magnus Enger</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-18 09:05:06 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=167821&action=diff" name="attach_167821" title="Bug 32575: Tidy patch">attachment 167821</a> <a href="attachment.cgi?id=167821&action=edit" title="Bug 32575: Tidy patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=167821'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch Signed-off-by: Magnus Enger <<a href="mailto:magnus@libriotech.no">magnus@libriotech.no</a>></pre> </div> <div id="c13" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c13">Comment 13</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Marcel de Rooy</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 07:33:33 UTC </span> </div> <pre class="bz_comment_text">Created <span class=""><a href="attachment.cgi?id=168225&action=diff" name="attach_168225" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">attachment 168225</a> <a href="attachment.cgi?id=168225&action=edit" title="Bug 32575: Add an empty text body to fix multipart/mixed handling">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=32575&attachment=168225'>[review]</a> <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Add an empty text body to fix multipart/mixed handling By adding an empty text body, we force Email::Stuffer/Email::MIME to use multipart/mixed handling for the attachment instead of forcing a single part (ie direct attachment) email, which is not consistently handled by different email clients. An empty text body is language-neutral (ie not imposing English), and it allows SMTP servers to inject organisational footers into the email (e.g. confidentiality notices). Signed-off-by: Magnus Enger <<a href="mailto:magnus@libriotech.no">magnus@libriotech.no</a>> I have tested this solution in production, and it works for me. <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch Signed-off-by: Magnus Enger <<a href="mailto:magnus@libriotech.no">magnus@libriotech.no</a>> Signed-off-by: Marcel de Rooy <<a href="mailto:m.de.rooy@rijksmuseum.nl">m.de.rooy@rijksmuseum.nl</a>></pre> </div> <div id="c14" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c14">Comment 14</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 11:24:30 UTC </span> </div> <pre class="bz_comment_text">Hm, bit odd since the patches were just re-attached this morning: Apply? [(y)es, (n)o, (i)nteractive] y Applying: <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch error: sha1 information is lacking or useless (misc/cronjobs/gather_print_notices.pl). error: could not build fake ancestor Patch failed at 0001 <a class="bz_bug_link bz_status_Pushed_to_oldstable " title="Pushed to oldstable - gather_print_notices.pl sends attachment as body of email or poorly named txt file" href="show_bug.cgi?id=32575">Bug 32575</a>: Tidy patch hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32575-Tidy-patch-ghgaof9i.patch</pre> </div> <div id="c15" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c15">Comment 15</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 11:24:56 UTC </span> </div> <pre class="bz_comment_text">Ah, wrong sequence.</pre> </div> <div id="c16" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c16">Comment 16</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 11:26:54 UTC </span> </div> <pre class="bz_comment_text">Looks like the Tidy patch was squashed with the other patch in this case. Obsoleted the tidy patch, QA tools pass, patch applies that way.</pre> </div> <div id="c17" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c17">Comment 17</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Cook</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-30 23:16:18 UTC </span> </div> <pre class="bz_comment_text">(In reply to Katrin Fischer from <a href="show_bug.cgi?id=32575#c16">comment #16</a>) <span class="quote">> Looks like the Tidy patch was squashed with the other patch in this case. > Obsoleted the tidy patch, QA tools pass, patch applies that way.</span > I noticed the status is "Patch doesn't apply". Is that still the case or should it be changed?</pre> </div> <div id="c18" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c18">Comment 18</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-07-01 07:29:02 UTC </span> </div> <pre class="bz_comment_text">No, it's actually pushed, but the script didn't pick it up for the wrong status.</pre> </div> <div id="c19" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c19">Comment 19</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-07-01 07:29:30 UTC </span> </div> <pre class="bz_comment_text">Pushed to main for 24.11, thanks all!</pre> </div> <div id="c20" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c20">Comment 20</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Lucas Gass (lukeg)</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-11-18 17:11:11 UTC </span> </div> <pre class="bz_comment_text">Backported to 24.05.x for upcoming 24.05.06</pre> </div> <div id="c21" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=32575#c21">Comment 21</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Fridolin Somers</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-12-02 10:20:25 UTC </span> </div> <pre class="bz_comment_text">Pushed to 23.11.x for 23.11.11</pre> </div> </td> <td> </td> </tr></table> </div> </form> <hr> <ul class="related_actions"> <li><a href="show_bug.cgi?format=multiple&id=32575">Format For Printing</a></li> <li> - <a href="show_bug.cgi?ctype=xml&id=32575">XML</a></li> <li> - <a href="enter_bug.cgi?cloned_bug_id=32575">Clone This Bug</a></li> <li> - <a href="#">Top of page </a></li> </ul> <br> </div> <div id="footer"> <div class="intro"></div> <ul id="useful-links"> <li id="links-actions"><ul class="links"> <li><a href="./">Home</a></li> <li><span class="separator">| </span><a href="enter_bug.cgi">New</a></li> <li><span class="separator">| </span><a href="describecomponents.cgi">Browse</a></li> <li><span class="separator">| </span><a href="query.cgi">Search</a></li> <li class="form"> <span class="separator">| </span> <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') { alert('Please enter one or more search terms first.'); return false; } return true;"> <input type="hidden" id="no_redirect_bottom" name="no_redirect" value="0"> <script type="text/javascript"> if (history && history.replaceState) { var no_redirect = document.getElementById("no_redirect_bottom"); no_redirect.value = 1; } </script> <input class="txt" type="text" id="quicksearch_bottom" name="quicksearch" aria-labelledby="find_bottom" title="Quick Search" value=""> <input class="btn" type="submit" value="Search" id="find_bottom"></form> <a href="page.cgi?id=quicksearch.html" title="Quicksearch Help">[?]</a></li> <li><span class="separator">| </span><a href="report.cgi">Reports</a></li> <li></li> <li> <span class="separator">| </span> <a href="https://bugzilla.readthedocs.org/en/5.2/using/understanding.html" target="_blank">Help</a> </li> <li id="new_account_container_bottom"> <span class="separator">| </span> <a href="createaccount.cgi">New Account</a> </li> <li id="mini_login_container_bottom"> <span class="separator">| </span> <a id="login_link_bottom" href="show_bug.cgi?id=32575&GoAheadAndLogIn=1" onclick="return show_mini_login_form('_bottom')">Log In</a> <form action="show_bug.cgi?id=32575" method="POST" class="mini_login bz_default_hidden" id="mini_login_bottom"> <input id="Bugzilla_login_bottom" required name="Bugzilla_login" class="bz_login" type="email" placeholder="Email Address"> <input class="bz_password" name="Bugzilla_password" type="password" id="Bugzilla_password_bottom" required placeholder="Password"> <input type="hidden" name="Bugzilla_login_token" value=""> <input type="submit" name="GoAheadAndLogIn" value="Log in" id="log_in_bottom"> <a href="#" onclick="return hide_mini_login_form('_bottom')">[x]</a> </form> </li> <li id="forgot_container_bottom"> <span class="separator">| </span> <a id="forgot_link_bottom" href="show_bug.cgi?id=32575&GoAheadAndLogIn=1#forgot" onclick="return show_forgot_form('_bottom')">Forgot Password</a> <form action="token.cgi" method="post" id="forgot_form_bottom" class="mini_forgot bz_default_hidden"> <label for="login_bottom">Login:</label> <input name="loginname" size="20" id="login_bottom" required type="email" placeholder="Your Email Address"> <input id="forgot_button_bottom" value="Reset Password" type="submit"> <input type="hidden" name="a" value="reqpw"> <input type="hidden" id="token_bottom" name="token" value="1740154459-POoeqsgbrays8hYIq2bc88UeO-OIruwDGzQqX81I2zw"> <a href="#" onclick="return hide_forgot_form('_bottom')">[x]</a> </form> </li> </ul> </li> </ul> <div class="outro"></div> </div> </body> </html>

CINXE.COM

32575 – gather_print_notices.pl sends attachment as body of email or poorly named txt file