CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Christoph Lameter: Re: [PATCH] swap migration: Fix lru drain</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Christoph Lameter" href="/groupie.php?aid=843" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/7"> [7]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/7/412" onclick="this.href='/lkml/headers'+'/2005/12/7/412';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/7/412">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/7/327">First message in thread</a></li><li><a href="/lkml/2005/12/7/402">Christoph Lameter</a><ul><li><a href="/lkml/2005/12/7/406">Andrew Morton</a><ul><li class="origin"><a href="/lkml/2005/12/8/2">Christoph Lameter</a><ul><li><a href="/lkml/2005/12/8/2">KAMEZAWA Hiroyuki</a></li><li><a href="/lkml/2005/12/8/36">KAMEZAWA Hiroyuki</a><ul><li><a href="/lkml/2005/12/8/38">KAMEZAWA Hiroyuki</a></li></ul></li></ul></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/12/7/412/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 7 Dec 2005 17:14:34 -0800 (PST)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Christoph Lameter <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH] swap migration: Fix lru drain</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Wed, 7 Dec 2005, Andrew Morton wrote:<br /><br />> I'll change this to return 0 on success, or -ENOMEM. Bit more<br />> conventional, no?<br /><br />Ok. That also allows the addition of other error conditions in the future.<br />Need to revise isolate_lru_page to reflect that.<br /><br />Index: linux-2.6.15-rc5-mm1/mm/vmscan.c<br />===================================================================<br />--- linux-2.6.15-rc5-mm1.orig/mm/vmscan.c 2005-12-06 18:03:24.000000000 -0800<br />+++ linux-2.6.15-rc5-mm1/mm/vmscan.c 2005-12-07 17:11:58.000000000 -0800<br />@@ -1038,8 +1038,8 @@ redo:<br /> * Maybe this page is still waiting for a cpu to drain it<br /> * from one of the lru lists?<br /> */<br />- schedule_on_each_cpu(lru_add_drain_per_cpu, NULL);<br />- if (PageLRU(page))<br />+ rc = schedule_on_each_cpu(lru_add_drain_per_cpu, NULL);<br />+ if (rc == 0 && PageLRU(page))<br /> goto redo;<br /> }<br /> return rc;<br />Index: linux-2.6.15-rc5-mm1/kernel/workqueue.c<br />===================================================================<br />--- linux-2.6.15-rc5-mm1.orig/kernel/workqueue.c 2005-12-07 16:38:54.000000000 -0800<br />+++ linux-2.6.15-rc5-mm1/kernel/workqueue.c 2005-12-07 17:13:04.000000000 -0800<br />@@ -432,7 +432,7 @@ int schedule_on_each_cpu(void (*func) (v<br /> work = kmalloc(NR_CPUS * sizeof(struct work_struct), GFP_KERNEL);<br /> <br /> if (!work)<br />- return 0;<br />+ return -ENOMEM;<br /> for_each_online_cpu(cpu) {<br /> INIT_WORK(work + cpu, func, info);<br /> __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu),<br />@@ -440,7 +440,7 @@ int schedule_on_each_cpu(void (*func) (v<br /> }<br /> flush_workqueue(keventd_wq);<br /> kfree(work);<br />- return 1;<br />+ return 0;<br /> }<br /> <br /> void flush_scheduled_work(void)<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-08 02:18 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>