CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Andi Kleen: Re: [discuss] [patch 1/3] x86_64: Node local pda take 2 -- early cpu_to_node</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Andi Kleen" href="/groupie.php?aid=22" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/15"> [15]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/15/100" onclick="this.href='/lkml/headers'+'/2005/12/15/100';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/15/100">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/14/427">First message in thread</a></li><li><a href="/lkml/2005/12/14/427">Ravikiran G Thirumalai</a><ul><li><a href="/lkml/2005/12/14/428">Ravikiran G Thirumalai</a></li><li><a href="/lkml/2005/12/14/431">Ravikiran G Thirumalai</a><ul><li><a href="/lkml/2005/12/15/44">Eric Dumazet</a><ul><li><a href="/lkml/2005/12/15/98">Andi Kleen</a></li></ul></li><li><a href="/lkml/2005/12/15/99">Andi Kleen</a><ul><li><a href="/lkml/2005/12/15/259">Ravikiran G Thirumalai</a><ul><li><a href="/lkml/2005/12/15/384">Andi Kleen</a></li></ul></li></ul></li></ul></li><li class="origin"><a href="/lkml/2005/12/15/267">Andi Kleen</a><ul><li><a href="/lkml/2005/12/15/267">Ravikiran G Thirumalai</a><ul><li><a href="/lkml/2005/12/15/383">Andi Kleen</a><ul><li><a href="/lkml/2005/12/16/28">Ravikiran G Thirumalai</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Thu, 15 Dec 2005 10:44:37 +0100</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Andi Kleen <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [discuss] [patch 1/3] x86_64: Node local pda take 2 -- early cpu_to_node</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Wed, Dec 14, 2005 at 06:33:45PM -0800, Ravikiran G Thirumalai wrote:<br />> Here is take 2 on x86_64 node local pda allocation.<br />> <br />> This patchset does away with the extra memory reference for non CONFIG_NUMA<br />> case. The early cpu_to_node helps AMD and EM64T systems which work well<br />> with CONFIG_ACPI_NUMA. cpu_to_node is not inited early for AMD systems<br />> which work only with old style K8_NUMA. (Tested on EM64 NUMA and Tyan K8<br />> dual core 4 cpu boxes)<br /><br />Thanks for now testing on AMD too - that makes me more confident in your<br />patches.<br /><br />> Andi, I could not eliminate the need for a initial static pda array, since<br />> sched_init needs the static per-cpu offset array for NR_CPUS early. Hope<br />> this is OK.<br /><br />See my comment.<br /><br />> + * Setup cpu_to_node using the SRAT lapcis & ACPI MADT table<br />> + * info.<br />> + */<br />> +void __init init_cpu_to_node(void)<br />> +{<br />> + int i; <br />> + for (i = 0; i < NR_CPUS; i++)<br />> + cpu_to_node[i] = apicid_to_node[x86_cpu_to_apicid[i]];<br />> +}<br /><br />I would prefer it if you moved that to numa.c and run always <br />(even for the k8topology case). Otherwise k8topology will behave<br />differently whether CONFIG_ACPI_NUMA is set or not, and I don't like<br />that.<br /><br />-Andi<br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-15 10:47 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>