CINXE.COM
LKML: Daniel Barkalow: [PATCH] Don't use commit-id in building
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Daniel Barkalow: [PATCH] Don't use commit-id in building</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Daniel Barkalow" href="/groupie.php?aid=28379" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/26"> [26]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/26/33" onclick="this.href='/lkml/headers'+'/2005/4/26/33';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/26/33">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/4/25/289">First message in thread</a></li><li><a href="/lkml/2005/4/26/21">Daniel Barkalow</a><ul><li><a href="/lkml/2005/4/26/27">Al Viro</a><ul><li class="origin"><a href="">Daniel Barkalow</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/26/33/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Tue, 26 Apr 2005 02:03:23 -0400 (EDT)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Daniel Barkalow <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">[PATCH] Don't use commit-id in building</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Tue, 26 Apr 2005, Al Viro wrote:<br /><br />> > > So, it still complains about commit-id<br />> > <br />> > In this case, it would complain about .git/HEAD even if it found<br />> > commit-id. The right solution is probably to suppress that part if there's<br />> > no .git/HEAD.<br />> <br />> The right thing is to stop assuming that everyone has . in their $PATH,<br />> to start with...<br /><br />Does anyone have . in their $PATH? I've only used the commit-id that I<br />installed previously. Since the tarball doesn't have a .git directory, the<br />only way you end up building cogito from a directory with a repository is<br />by using an earlier cogito or something of the sort, in which case, you<br />probably have the program.<br /><br />In any case, commit-id isn't actually necessary for this operation.<br /><br />-<br />We don't necessarily have commit-id available when building. Furthermore,<br />we don't necessarily have a repository. Just put in .git/HEAD if it<br />exists; otherwise, it's a base distribution.<br /><br />Signed-Off-By: Daniel Barkalow <barkalow@iabervon.org><br /><br />Index: Makefile<br />===================================================================<br />--- f262000f302b749e485f5eb971e6aabefbb85680/Makefile (mode:100644 sha1:4f01bbbbb3fd0e53e9ce968f167b6dae68fcfa92)<br />+++ uncommitted/Makefile (mode:100644)<br />@@ -87,11 +87,13 @@<br /> http-pull: LIBS += -lcurl<br /> <br /> <br />-cg-version: $(VERSION)<br />+cg-version: $(VERSION) .git/HEAD<br /> @echo Generating cg-version...<br /> @rm -f $@<br /> @echo "#!/bin/sh" > $@<br />- @PATH=.:$(PATH) echo "echo \"$(shell cat $(VERSION)) ($(shell commit-id))\"" >> $@<br />+ @echo -n "echo \"$(shell cat $(VERSION))" >> $@<br />+ @if [ -r .git/HEAD ]; then echo -n " ($(shell cat .git/HEAD))" >> $@; fi<br />+ @echo "\"" >> $@<br /> @chmod +x $@<br /> <br /> install: $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT)<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-26 08:07 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>