CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Wakko Warner: Re: [PATCH] pcmcia/ds: handle any error code</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Wakko Warner" href="/groupie.php?aid=139" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/5"> [May]</a> 聽 <a class="nb" href="/lkml/2005/5/13"> [13]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/5/13/63" onclick="this.href='/lkml/headers'+'/2005/5/13/63';">[headers]</a>聽 <a href="/lkml/bounce/2005/5/13/63">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/5/11/235">First message in thread</a></li><li><a href="/lkml/2005/5/12/206">Wakko Warner</a><ul><li><a href="/lkml/2005/5/13/6">randy_dunlap</a><ul><li class="origin"><a href="">Wakko Warner</a></li><li><a href="/lkml/2005/5/13/211">Wakko Warner</a><ul><li><a href="/lkml/2005/5/14/93">randy_dunlap</a><ul><li><a href="/lkml/2005/5/14/95">Wakko Warner</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 13 May 2005 06:50:00 -0400</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Wakko Warner <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH] pcmcia/ds: handle any error code</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">randy_dunlap wrote:<br />> | Wakko Warner wrote:<br />> | > 3) I put together a boot kernel/initrd using 2.6.12-rc2 (also tested<br />> | > 2.6.12-rc4) which seems to work, except that pcmcia does not function<br />> | > properly. When pcmcia.ko gets loaded, it is unable to register it's char<br />> | > dev. I'm not sure why this is. 2.6.11.8 worked fine with no modifications<br />> | <br />> | I tested this again today with a few changes. It appears that if pcmcia.ko<br />> | (or rather the .c files that make it up) are compiled with -Os, it will fail<br />> | to register a character device. Being that one of my goals for this was to<br />> | fit everything on a floppy, I had to use -Os when building the kernel. <br />> | (pcmcia was not one of the modules that belongs on the floppy, however I<br />> | did not want to have to compile the kernel and then again for the modules<br />> | w/o -Os)<br />> | <br />> | I believe that pcmcia.ko is the only module I am using that uses a dynamic<br />> | major.<br />> <br />> There is some small difference in locking in fs/char_dev.c between<br />> 2.6.12-rc4 and 2.6.11.8, but I don't yet see why it would cause a<br />> failure in register_chrdev().<br />> <br />> Oh, there's a big difference in drivers/pcmcia/ds.c, lots of probe<br />> changes. This is where to look further (but not tonight).<br />> The question then becomes is this a real regression?<br />> <br />> Do you suspect a problem with -Os code generation?<br /><br />Definately. Here's what I did. The laptop I was testing has 2.6.12-rc2<br />installed (it's a multi boot). This kernel was compiled specifically for<br />the laptop since it's one that I use for work. The kernel I compiled with<br />-Os is a generic and this laptop was the only one I had to test this with. <br />So basically, you could say this laptop currently has 2 linux installations<br />on it. The generic one I'm trying to get partially on a floppy and it's<br />normal one.<br /><br />I was first booting from floppy to test. The kernel on the floppy is<br />compield with -Os and the kernel itself is compressed with upx-ucl-beta to<br />make it smaller. Then it has a gzipped initrd with busybox and some<br />modules. I call this stage1. stage2 which has the pcmcia module comes from<br />either a cdrom or a usb stick (I have stage 1 on the laptop hdd, but stage 2<br />still comes from usb). Figuring there might have been a problem with upx, I<br />decided to through the stage1 on my laptop's hdd (since it can't boot from<br />usb). This time, I recompiled the kernel (make clean, remove optimize for<br />size, make bzImage modules, install modules to the usb stick and select ones<br />for the initrd). Once I did this, pcmcia worked. The configuration was the<br />same, all that changed was not using -Os.<br /><br />> Looks to me like ds.c needs at least this small fix...<br /><br />I'll forward this diff to myself at work and test it. Thanks. I'll let you<br />know what happens.<br /><br />-- <br /> Lab tests show that use of micro$oft causes cancer in lab animals<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-05-13 12:56 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>