CINXE.COM
LKML: Thomas Gleixner: Re: [patch V3a 17/18] posix-timers: Provide a mechanism to allocate a given timer ID
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Thomas Gleixner: Re: [patch V3a 17/18] posix-timers: Provide a mechanism to allocate a given timer ID</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Thomas Gleixner" href="/groupie.php?aid=" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2025"> [2025]</a> 聽 <a class="nb" href="/lkml/2025/3"> [Mar]</a> 聽 <a class="nb" href="/lkml/2025/3/12"> [12]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2025/3/12/521" onclick="this.href='/lkml/headers'+'/2025/3/12/521';">[headers]</a>聽 <a href="/lkml/bounce/2025/3/12/521">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2025/3/8/426">First message in thread</a></li><li><a href="/lkml/2025/3/12/252">Cyrill Gorcunov</a><ul><li><a href="/lkml/2025/3/12/500">Thomas Gleixner</a><ul><li class="origin"><a href="">Thomas Gleixner</a></li><li><a href="/lkml/2025/3/12/621">Cyrill Gorcunov</a><ul><li><a href="/lkml/2025/3/12/1117">Thomas Gleixner</a></li></ul></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2025/3/12/521/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">From</td><td class="rp" itemprop="author">Thomas Gleixner <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [patch V3a 17/18] posix-timers: Provide a mechanism to allocate a given timer ID</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 12 Mar 2025 12:31:23 +0100</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Wed, Mar 12 2025 at 12:24, Thomas Gleixner wrote:<br />> On Wed, Mar 12 2025 at 10:56, Cyrill Gorcunov wrote:<br />>> an interface to _read_ this property, don't we? Thus criu will restore such<br />>> application which already has this bit set incorrectly.<br />><br />> Delta patch below.<br /><br />That want's a fixup for the selftest too.<br /><br />---<br />diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c<br />index 158138211f51..f0eceb0faf34 100644<br />--- a/tools/testing/selftests/timers/posix_timers.c<br />+++ b/tools/testing/selftests/timers/posix_timers.c<br />@@ -616,6 +616,7 @@ static int do_timer_delete(int id)<br /> # define PR_TIMER_CREATE_RESTORE_IDS 77<br /> # define PR_TIMER_CREATE_RESTORE_IDS_OFF 0<br /> # define PR_TIMER_CREATE_RESTORE_IDS_ON 1<br />+# define PR_TIMER_CREATE_RESTORE_IDS_GET 2<br /> #endif<br /> <br /> static void check_timer_create_exact(void)<br />@@ -633,6 +634,9 @@ static void check_timer_create_exact(void)<br /> }<br /> }<br /> <br />+ if (prctl(PR_TIMER_CREATE_RESTORE_IDS, PR_TIMER_CREATE_RESTORE_IDS_GET, 0, 0, 0) != 1)<br />+ fatal_error(NULL, "prctl(GET) failed\n");<br />+<br /> id = 8;<br /> if (do_timer_create(&id) < 0)<br /> fatal_error(NULL, "timer_create()");<br />@@ -641,7 +645,10 @@ static void check_timer_create_exact(void)<br /> fatal_error(NULL, "timer_delete()");<br /> <br /> if (prctl(PR_TIMER_CREATE_RESTORE_IDS, PR_TIMER_CREATE_RESTORE_IDS_OFF, 0, 0, 0))<br />- fatal_error(NULL, "prctl()");<br />+ fatal_error(NULL, "prctl(OFF)");<br />+<br />+ if (prctl(PR_TIMER_CREATE_RESTORE_IDS, PR_TIMER_CREATE_RESTORE_IDS_GET, 0, 0, 0) != 0)<br />+ fatal_error(NULL, "prctl(GET) failed\n");<br /> <br /> if (id != 8) {<br /> ksft_test_result_fail("check timer create exact %d != 8\n", id);<br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2025-03-12 12:31 聽聽 [W:0.673 / U:0.496 seconds]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>