CINXE.COM

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" /><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" /><meta http-equiv="Content-Style-Type" content="text/css" /><meta name="generator" content="pandoc" /><title>The OpenJDK Developers' Guide – OpenJDK Developers’ Guide</title><link rel="shortcut icon" href="../images/nanoduke.ico" /><link rel="stylesheet" type="text/css" href="../page.css" /><script type="text/javascript" src="../page.js"><noscript></noscript></script><script src="https://cdn.usefathom.com/script.js" data-site="KCYJJPZX" defer="yes"></script><style type="text/css"> /**/ code{white-space: pre-wrap;} span.smallcaps{font-variant: small-caps;} span.underline{text-decoration: underline;} div.column{display: inline-block; vertical-align: top; width: 50%;} div.hanging-indent{margin-left: 1.5em; text-indent: -1.5em;} ul.task-list{list-style: none;} pre > code.sourceCode { white-space: pre; position: relative; } pre > code.sourceCode > span { display: inline-block; line-height: 1.25; } pre > code.sourceCode > span:empty { height: 1.2em; } .sourceCode { overflow: visible; } code.sourceCode > span { color: inherit; text-decoration: inherit; } div.sourceCode { margin: 1em 0; } pre.sourceCode { margin: 0; } @media screen { div.sourceCode { overflow: auto; } } @media print { pre > code.sourceCode { white-space: pre-wrap; } pre > code.sourceCode > span { text-indent: -5em; padding-left: 5em; } } pre.numberSource code { counter-reset: source-line 0; } pre.numberSource code > span { position: relative; left: -4em; counter-increment: source-line; } pre.numberSource code > span > a:first-child::before { content: counter(source-line); position: relative; left: -1em; text-align: right; vertical-align: baseline; border: none; display: inline-block; -webkit-touch-callout: none; -webkit-user-select: none; -khtml-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none; padding: 0 4px; width: 4em; color: #aaaaaa; } pre.numberSource { margin-left: 3em; border-left: 1px solid #aaaaaa; padding-left: 4px; } div.sourceCode { } @media screen { pre > code.sourceCode > span > a:first-child::before { text-decoration: underline; } } code span.al { color: #ff0000; font-weight: bold; } /* Alert */ code span.an { color: #60a0b0; font-weight: bold; font-style: italic; } /* Annotation */ code span.at { color: #7d9029; } /* Attribute */ code span.bn { color: #40a070; } /* BaseN */ code span.bu { } /* BuiltIn */ code span.cf { color: #007020; font-weight: bold; } /* ControlFlow */ code span.ch { color: #4070a0; } /* Char */ code span.cn { color: #880000; } /* Constant */ code span.co { color: #60a0b0; font-style: italic; } /* Comment */ code span.cv { color: #60a0b0; font-weight: bold; font-style: italic; } /* CommentVar */ code span.do { color: #ba2121; font-style: italic; } /* Documentation */ code span.dt { color: #902000; } /* DataType */ code span.dv { color: #40a070; } /* DecVal */ code span.er { color: #ff0000; font-weight: bold; } /* Error */ code span.ex { } /* Extension */ code span.fl { color: #40a070; } /* Float */ code span.fu { color: #06287e; } /* Function */ code span.im { } /* Import */ code span.in { color: #60a0b0; font-weight: bold; font-style: italic; } /* Information */ code span.kw { color: #007020; font-weight: bold; } /* Keyword */ code span.op { color: #666666; } /* Operator */ code span.ot { color: #007020; } /* Other */ code span.pp { color: #bc7a00; } /* Preprocessor */ code span.sc { color: #4070a0; } /* SpecialChar */ code span.ss { color: #bb6688; } /* SpecialString */ code span.st { color: #4070a0; } /* String */ code span.va { color: #19177c; } /* Variable */ code span.vs { color: #4070a0; } /* VerbatimString */ code span.wa { color: #60a0b0; font-weight: bold; font-style: italic; } /* Warning */ .display.math{display: block; text-align: center; margin: 0.5rem auto;} /**/ </style><link rel="stylesheet" href="guidestyle.css" type="text/css" /></head><body><div id="main"> <div id="header"> <h1 class="title">OpenJDK Developers’ Guide</h1> </div> <div id="TOC"> <ul> <li><a href="#introduction">Introduction</a> <ul> <li><a href="#openjdk">OpenJDK</a></li> <li><a href="#author-committer-reviewer">Author, Committer, Reviewer</a> <ul> <li><a href="#becoming-an-author">Becoming an Author</a></li> <li><a href="#becoming-a-committer">Becoming a Committer</a></li> <li><a href="#becoming-a-reviewer">Becoming a Reviewer</a></li> <li><a href="#non-trivialsignificant-changes">Non-trivial/Significant changes</a></li> </ul> </li> </ul> </li> <li><a href="#contributing-to-an-openjdk-project">Contributing to an OpenJDK Project</a> <ul> <li><a href="#things-to-consider-before-proposing-changes-to-openjdk-code">Things to consider before proposing changes to OpenJDK code</a></li> <li><a href="#i-have-a-patch-what-do-i-do">I have a patch, what do I do?</a> <ul> <li><a href="#sign-the-oca">1. Sign the OCA</a></li> <li><a href="#socialize-your-change">2. Socialize your change</a></li> <li><a href="#find-a-sponsor">3. Find a Sponsor</a></li> <li><a href="#create-a-tracking-issue-in-jbs">4. Create a tracking issue in JBS</a></li> <li><a href="#get-acquainted-with-local-process">5. Get acquainted with local process</a></li> </ul> </li> <li><a href="#why-is-my-change-rejected">Why is my change rejected?</a></li> </ul> </li> <li><a href="#mailing-lists">Mailing Lists</a> <ul> <li><a href="#changing-your-email-address">Changing your email address</a></li> </ul> </li> <li><a href="#code-conventions">Code Conventions</a></li> <li><a href="#jbs---jdk-bug-system">JBS - JDK Bug System</a> <ul> <li><a href="#filing-an-issue">Filing an issue</a> <ul> <li><a href="#types-of-issues">Types of issues</a></li> <li><a href="#indicating-what-releases-an-issue-is-applicable-to">Indicating what releases an issue is applicable to</a></li> <li><a href="#things-to-keep-in-mind-when-requesting-an-improvement">Things to keep in mind when requesting an improvement</a></li> <li><a href="#implementing-a-large-change">Implementing a large change</a></li> <li><a href="#implementing-a-jep">Implementing a JEP</a></li> </ul> </li> <li><a href="#issue-states">Issue states</a></li> <li><a href="#triaging-an-issue">Triaging an issue</a> <ul> <li><a href="#sensitive-information-e.g.-hs_err.log">Sensitive information (e.g. hs_err.log)</a></li> </ul> </li> <li><a href="#updating-an-issue-while-fixing">Updating an issue while fixing</a> <ul> <li><a href="#linking-issues">Linking Issues</a></li> </ul> </li> <li><a href="#resolving-or-closing-an-issue">Resolving or Closing an issue</a> <ul> <li><a href="#closing-issues-as-duplicates">Closing issues as duplicates</a></li> <li><a href="#closing-issues-without-knowing-what-fixed-it">Closing issues without knowing what fixed it</a></li> <li><a href="#closing-incomplete-issues">Closing incomplete issues</a></li> </ul> </li> <li><a href="#verifying-an-issue">Verifying an issue</a></li> <li><a href="#removing-an-issue">Removing an issue</a></li> <li><a href="#jbs-labels">JBS labels</a></li> <li><a href="#jbs-label-dictionary">JBS label dictionary</a></li> </ul> </li> <li><a href="#cloning-the-jdk">Cloning the JDK</a> <ul> <li><a href="#working-with-git-branches">Working with git branches</a></li> <li><a href="#generating-an-ssh-key">Generating an SSH key</a></li> </ul> </li> <li><a href="#making-a-change">Making a Change</a> <ul> <li><a href="#working-with-the-csr">Working with the CSR</a></li> <li><a href="#copyright-headers">Copyright Headers</a></li> </ul> </li> <li><a href="#building-the-jdk">Building the JDK</a> <ul> <li><a href="#configuration-options">Configuration options</a> <ul> <li><a href="#working-with-multiple-configurations">Working with multiple configurations</a></li> </ul> </li> <li><a href="#make-targets">Make targets</a></li> </ul> </li> <li><a href="#testing-the-jdk">Testing the JDK</a> <ul> <li><a href="#jtreg">jtreg</a> <ul> <li><a href="#running-openjdk-jtreg-tests">Running OpenJDK jtreg tests</a></li> </ul> </li> <li><a href="#gtest">GTest</a> <ul> <li><a href="#running-openjdk-gtests">Running OpenJDK GTests</a></li> </ul> </li> <li><a href="#github-actions">GitHub actions</a></li> <li><a href="#excluding-a-test">Excluding a test</a> <ul> <li><a href="#problemlisting-jtreg-tests">ProblemListing jtreg tests</a></li> <li><a href="#exclude-jtreg-tests-using-ignore">Exclude jtreg tests using <code>@ignore</code></a></li> <li><a href="#dealing-with-jbs-bugs-for-test-exclusion">Dealing with JBS bugs for test exclusion</a></li> </ul> </li> <li><a href="#backing-out-a-change">Backing out a change</a> <ul> <li><a href="#how-to-work-with-jbs-when-a-change-is-backed-out">How to work with JBS when a change is backed out</a></li> <li><a href="#how-to-work-with-git-when-a-change-is-backed-out">How to work with git when a change is backed out</a></li> </ul> </li> <li><a href="#backing-out-a-backport">Backing out a backport</a> <ul> <li><a href="#rationale-for-using-this-model">Rationale for using this model</a></li> </ul> </li> </ul> </li> <li><a href="#working-with-pull-requests">Working With Pull Requests</a> <ul> <li><a href="#think-once-more">Think once more</a></li> <li><a href="#rebase-before-creating-the-pr">Rebase before creating the PR</a></li> <li><a href="#final-check-before-creating-the-pr">Final check before creating the PR</a></li> <li><a href="#life-of-a-pr">Life of a PR</a></li> <li><a href="#webrevs">Webrevs</a></li> <li><a href="#file-storage-for-openjdk-artifacts---cr.openjdk.org">File storage for OpenJDK artifacts - <code>cr.openjdk.org</code></a> <ul> <li><a href="#get-your-ssh-key-installed">Get your SSH key installed</a></li> </ul> </li> </ul> </li> <li><a href="#reviewing-and-sponsoring-a-change">Reviewing and Sponsoring a Change</a> <ul> <li><a href="#responsibilities-of-a-reviewer">Responsibilities of a Reviewer</a></li> <li><a href="#reviewing-a-change-on-github">Reviewing a change on GitHub</a> <ul> <li><a href="#conversation">Conversation</a></li> <li><a href="#files-changed">Files changed</a></li> <li><a href="#trivial-changes">Trivial changes</a></li> </ul> </li> <li><a href="#volunteering-to-sponsor-a-contribution">Volunteering to sponsor a contribution</a></li> <li><a href="#responsibilities-of-a-sponsor">Responsibilities of a sponsor</a></li> </ul> </li> <li><a href="#backporting">Backporting</a> <ul> <li><a href="#backporting-to-a-feature-release-stabilization-branch">Backporting to a feature release stabilization branch</a></li> <li><a href="#backporting-multiple-related-changes">Backporting multiple related changes</a></li> <li><a href="#working-with-backports-in-jbs">Working with backports in JBS</a></li> <li><a href="#requesting-approvals-for-backports">Requesting approvals for backports</a></li> <li><a href="#using-the-skara-tooling-to-help-with-backports">Using the Skara tooling to help with backports</a></li> <li><a href="#how-to-fix-an-incorrect-backport-creation-in-jbs">How to fix an incorrect backport creation in JBS</a></li> </ul> </li> <li><a href="#release-notes">Release Notes</a> <ul> <li><a href="#writing-a-release-note">Writing a release note</a></li> <li><a href="#general-conventions-for-release-notes">General conventions for release notes</a></li> <li><a href="#advanced-options">Advanced options</a></li> <li><a href="#rn-labels">RN-labels</a></li> <li><a href="#querying-the-release-notes">Querying the release notes</a></li> </ul> </li> <li><a href="#the-jdk-release-process">The JDK Release Process</a> <ul> <li><a href="#release-cycle">Release cycle</a></li> <li><a href="#milestones-and-phases">Milestones and phases</a> <ul> <li><a href="#push-or-defer-during-ramp-down">Push or defer during ramp down</a></li> <li><a href="#deferring-p1-and-p2-bugs">Deferring P1 and P2 bugs</a></li> </ul> </li> </ul> </li> <li><a href="#project-maintenance">Project Maintenance</a> <ul> <li><a href="#merging-jdk-mainline-into-a-project-repository">Merging JDK mainline into a Project repository</a> <ul> <li><a href="#init---done-once">Init - done once</a></li> <li><a href="#performing-the-merge">Performing the merge</a></li> <li><a href="#test-before-integration">Test before integration</a></li> <li><a href="#the-commit-push-and-pr">The commit, push, and PR</a></li> <li><a href="#sharing-the-work">Sharing the work</a></li> </ul> </li> </ul> </li> <li><a href="#hotspot-development">HotSpot Development</a> <ul> <li><a href="#logging">Logging</a> <ul> <li><a href="#enabling-logging">Enabling logging</a></li> </ul> </li> </ul> </li> <li><a href="#code-owners">Code Owners</a> <ul> <li><a href="#area-mailing-lists">Area mailing lists</a></li> <li><a href="#directory-to-area-mapping">Directory to area mapping</a> <ul> <li><a href="#directories-removed">Directories removed</a></li> </ul> </li> </ul> </li> <li><a href="#about-this-guide">About This Guide</a></li> </ul> </div> <h1 id="introduction">Introduction</h1> Welcome to the OpenJDK Developers’ Guide! The OpenJDK Community is the place to collaborate on open-source implementations of the Java Platform, Standard Edition, and related <a href="https://openjdk.org/bylaws#project">Projects</a>. It was created in November 2006, when initial portions of the JDK source code were published under the GPLv2 license. In order to work together efficiently, clear directions are sometimes needed to avoid misconceptions and to align developers’ views of terminology and process. The OpenJDK Community is a fairly pragmatic place. “Do the right thing” is most often the right course of action. Still, if people do things in the same right way then everyone’s work becomes more transparent and easier for others to follow. For this reason most parts of the development process have standard flows that are the recommended ways to do things. The goal of this guide is to answer questions that developers of the JDK might have around development process, tooling, standards, and so forth. The formal rules and processes are described in other documents, such as <a href="https://openjdk.org/jeps/1">JEP 1</a> for the JDK Enhancement-Proposal & Roadmap Process, and <a href="https://openjdk.org/jeps/3">JEP 3</a> for the JDK Release Process. This guide is meant to be a complement to such documents, with tutorials and examples for how to follow these rules and how to work together with the rest of the OpenJDK Community. There are many common use cases that aren’t detailed in the formal process. This guide suggests how to work in such cases. <h2 id="openjdk">OpenJDK</h2> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/bylaws#group">OpenJDK Groups</a></li> <li><a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a></li> <li><a href="https://openjdk.org/bylaws#general-roles">OpenJDK General Roles (Participant, Contributor, Member)</a></li> <li><a href="https://openjdk.org/bylaws#project-roles">OpenJDK Project Roles (Author, Committer, Reviewer)</a></li> </ul> </div> OpenJDK consists of a number of <a href="https://openjdk.org/bylaws#group">Groups</a>. Members of a <a href="https://openjdk.org/bylaws#group">Group</a> collaborate on an area of mutual interest. The right hand side bar on the <a href="https://openjdk.org/">OpenJDK website</a> has a list of all <a href="https://openjdk.org/bylaws#group">Groups</a> in OpenJDK. If you’re interested in a specific area, this is where you would start your OpenJDK experience. Look at the <a href="https://openjdk.org/bylaws#group">Group’s</a> information and wiki pages, and see what <a href="https://openjdk.org/bylaws#project">Projects</a> they sponsor on the <a href="https://openjdk.org/census">Census page</a>. The <a href="https://openjdk.org/census">Census</a> shows the structure of the OpenJDK Community. <a href="https://openjdk.org/bylaws#project">Projects</a> are where the coding and much of the other work is done in OpenJDK. There are many different <a href="https://openjdk.org/bylaws#project">Projects</a>, some produce shippable artifacts, like the <a href="https://openjdk.org/projects/jdk/">JDK Project</a>, some produce tools to be used by developers of these artifacts, like the <a href="https://openjdk.org/projects/code-tools/">Code Tools Project</a> or <a href="https://openjdk.org/projects/skara/">Project Skara</a>, and some produce documentation, like the <a href="https://openjdk.org/projects/guide/">Developers’ Guide Project</a>. Many <a href="https://openjdk.org/bylaws#project">Projects</a> designs and develops new features for the Java language or the JVM, but there are also less code centric ones like the <a href="https://openjdk.org/projects/duke/">Duke Project</a> which collects images of the Java mascot, Duke. <h2 id="author-committer-reviewer">Author, Committer, Reviewer</h2> OpenJDK has a few different roles that determine who has the right to do what in the different <a href="https://openjdk.org/bylaws#project">Projects</a>. These roles are defined in the <a href="https://openjdk.org/bylaws#project-roles">OpenJDK Bylaws</a>. The roles are earned based on experience and knowledge within each <a href="https://openjdk.org/bylaws#project">Project</a>. A <a href="https://openjdk.org/bylaws#contributor">Contributor</a> can have different roles in different <a href="https://openjdk.org/bylaws#project">Projects</a>. When you’re new to a <a href="https://openjdk.org/bylaws#project">Project</a> you don’t yet have a formal role in that specific <a href="https://openjdk.org/bylaws#project">Project</a>, even though you might have earned roles in other <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> or have been recognized as a <a href="https://openjdk.org/bylaws#contributor">Contributor</a> or a <a href="https://openjdk.org/bylaws#openjdk-member">Member</a> of OpenJDK. By contributing high-quality content you’ll soon be eligible for <a href="https://openjdk.org/bylaws#project-roles">OpenJDK roles</a> in the <a href="https://openjdk.org/bylaws#project">Project</a>. First <a href="https://openjdk.org/bylaws#author">Author</a>, then <a href="https://openjdk.org/bylaws#committer">Committer</a>, and finally <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> if you stay active and earn the trust of the community. Trust is an important part of earning these roles. There’s a <a href="https://openjdk.org/projects/">rough guideline</a> saying that to become a <a href="https://openjdk.org/bylaws#committer">Committer</a> you should have contributed 8 significant changes, and to become a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> you should have contributed 32 significant changes. In reality it’s not as easy as “just” contributing code. You need to build a track record of good decisions and sound judgment and show that you know what differentiates a good change from a not so good one. It’s not only correctness of the code that matters, it’s also the appropriateness. In the end the trust you’ve earned is put to the test through a vote. Note that when a new <a href="https://openjdk.org/bylaws#project">Project</a> is created an initial set of members can be brought in at different levels without a vote. <h3 id="becoming-an-author">Becoming an Author</h3> Becoming an <a href="https://openjdk.org/bylaws#author">Author</a> is the first step. To achieve this you need to contribute two changes to the <a href="https://openjdk.org/bylaws#project">Project</a> in which you wish to become an <a href="https://openjdk.org/bylaws#author">Author</a>. Once your changes are integrated into the code base and has been vetted enough to determine that the changes were indeed good changes you can go ahead and send an email to the Project lead of that particular <a href="https://openjdk.org/bylaws#project">Project</a> and ask to be added as an <a href="https://openjdk.org/bylaws#author">Author</a>. Note that “the <a href="https://openjdk.org/bylaws#project">Project</a>” is not OpenJDK, but rather the specific <a href="https://openjdk.org/bylaws#project">development Project</a> where you did your contributions (e.g. “JDK”, “JDK Updates”, “Amber”, etc). The <a href="https://openjdk.org/projects/#project-author">OpenJDK Project description</a> has a template for such an email. In short the email should contain your name, the Project name, your email address, and GitHub links to your changes. In response to your email you will get a time-limited invite which you should fill out. To see who the Project lead is for your <a href="https://openjdk.org/bylaws#project">Project</a>, see the <a href="https://openjdk.org/census">OpenJDK Census</a>. The <a href="https://openjdk.org/census">Census</a> unfortunately doesn’t provide email addresses for people, but assuming you have been active on the Project mailing list (since you are applying for <a href="https://openjdk.org/bylaws#author">Author</a> after all), you should be able to find the lead’s email address in your local email archive, or ask your <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a>. As an <a href="https://openjdk.org/bylaws#author">Author</a> you will get your OpenJDK user name. Once you have gotten the user name, this should be associated with your GitHub account in order for the bots to be able to identify you on <a href="http://www.github.com">GitHub</a>. See the <a href="https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername"> Skara documentation</a> for more details on that. Once that’s done you can create PRs and get them reviewed, but you’ll still need a <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> to integrate changes. You’ll also get write access to <a href="#jbs---jdk-bug-system">JBS</a> and the <a href="https://wiki.openjdk.org">OpenJDK wiki</a> related to the <a href="https://openjdk.org/bylaws#project">Project</a> in question, and to <a href="https://cr.openjdk.org">cr.openjdk.org</a> via an SSH key provided at the time you accept your invitation. The rules of any particular <a href="https://openjdk.org/bylaws#project">Project</a> may have different guidelines regarding requirements for Authorship at the discretion of the Lead. <h3 id="becoming-a-committer">Becoming a Committer</h3> To become a <a href="https://openjdk.org/bylaws#committer">Committer</a> you should show that you intend to actively contribute to the <a href="https://openjdk.org/bylaws#project">Project</a> and that you can produce non-trivial changes that are accepted for inclusion into the Project code base. The number eight has been seen as a formal lower limit on the number of changes, but since the changes must be non-trivial, or “significant” as the <a href="https://openjdk.org/projects/">OpenJDK Project description</a> says, and the definition of significant is subjective, the general recommendation is to wait with a <a href="https://openjdk.org/bylaws#committer">Committer</a> nomination until there’s at least 10-12 changes integrated to have some margin for different interpretations of “significant”. In practice though, we have seen several examples where the number of significant changes hasn’t been the dominating factor in a <a href="https://openjdk.org/bylaws#committer">Committer</a> vote. A <a href="https://openjdk.org/bylaws#contributor">Contributor’s</a> work in another <a href="https://openjdk.org/bylaws#project">OpenJDK Project</a> may also be relevant for the vote. What the vote should ultimately test is the <a href="https://openjdk.org/bylaws#contributor">Contributor’s</a> commitment to the <a href="https://openjdk.org/bylaws#project">OpenJDK Project</a> for which the vote applies - is it believed that the person is dedicated and willing to spend time and effort on the <a href="https://openjdk.org/bylaws#project">Project</a>? Is the person believed to be a good citizen of the <a href="https://openjdk.org/bylaws#project">Project</a>? It’s always a good idea to seek the advice of a <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> who can guide you through the process to becoming a <a href="https://openjdk.org/bylaws#committer">Committer</a> - you will need one to run the Committer vote anyway. They will probably also have a better idea of what constitutes a “significant” change. Once you have the required changes, a <a href="https://openjdk.org/bylaws#committer">Committer</a> in the <a href="https://openjdk.org/bylaws#project">Project</a> can start a vote by sending an email proposing that you should become a <a href="https://openjdk.org/bylaws#committer">Committer</a>. The email should follow the template found in the <a href="https://openjdk.org/projects/#project-committer">OpenJDK Project description</a>. A <a href="https://openjdk.org/bylaws#committer">Committer</a> is allowed to integrate changes without the aid of a <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a>. A <a href="https://openjdk.org/bylaws#committer">Committer</a> is also allowed to nominate other non-Committers to become <a href="https://openjdk.org/bylaws#committer">Committers</a> in the <a href="https://openjdk.org/bylaws#project">Project</a>. <h3 id="becoming-a-reviewer">Becoming a Reviewer</h3> To become a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> you must show a track record of sound and correct judgment calls as mentioned above. Being a good <a href="https://openjdk.org/bylaws#committer">Committer</a> doesn’t necessarily make you a good <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a>. As a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> you have the power to approve changes for inclusion into the Project source code. This means that a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> needs to be able to judge the quality and appropriateness of any proposed change, not just the mechanics of the code. The assumption is that after having produced 32 significant changes one should have become familiar with the process around reviews and the requirements around getting a change approved. This should really be seen as a minimum requirement though. A more practical consideration would be to look at whether the non-trivial commits of a potential <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> are accepted largely intact or whether they are always being refined by the review process. There may be cases where it will take significantly more than 32 changes for a <a href="https://openjdk.org/bylaws#committer">Committer</a> to be ready to become a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a>. Once you are deemed ready, a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> in the <a href="https://openjdk.org/bylaws#project">Project</a> can start a vote by sending an email proposing that you should become a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a>. The email should follow the template found in the <a href="https://openjdk.org/projects/#project-reviewer">OpenJDK Project description</a>. <h3 id="non-trivialsignificant-changes">Non-trivial/Significant changes</h3> One key definition when advancing through the OpenJDK roles is the significant change. What exactly does it take for a change to be significant? Instead of describing the significant change (because that’s quite difficult to define) provided here is a few examples of changes that wouldn’t be considered significant or for other reasons wouldn’t count as significant contributions. <ul> <li>Purely aesthetic changes like renaming or fixing indentation</li> <li>Repeated follow-up bugfixes from earlier changes</li> <li>Larger changes where only a non-significant portion of the work was done by the <a href="https://openjdk.org/bylaws#contributor">Contributor</a> under vote</li> <li>Trivial backports of someone else’s changes</li> </ul> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="contributing-to-an-openjdk-project">Contributing to an OpenJDK Project</h1> Contributing to OpenJDK can take many forms. Writing code and providing patches is just one of them. A big part of developing a feature or a bugfix is testing and code review. Anything you can do to help out in these areas will be recognized as a contribution. Join the <a href="#mailing-lists">mailing lists</a> to engage in design discussions and reviews, and download the latest EA builds or Project repositories to try out new features and give feedback. If you see some misbehavior, or if you see somebody mention some misbehavior on some internet forum, try to track it down. Good bug reports with reproducible test cases are extremely valuable and make excellent contributions. Anything you can do to spread the word about Java, new features, and your experiences using the JDK will be helpful for the community and to the OpenJDK developers. Trying out a new feature and reporting your experiences is also a contribution. Whether you find that the new feature improves your application, or if you find some area that needs to be improved, your feedback is valuable to the developers of that feature. If you have a success story where Java solved your problem, or if you successfully upgraded to a more recent version of the JDK and noticed some improvements, spreading this story through a blog, news article, or some other channel is also a contribution. If you’re in a position to choose what programming language to use in a project, in a tutorial, or in a class, you have the power to enlarge the Java community in a very direct way, and your colleagues or students will get an opportunity to learn one of the most used programming languages in the world. <h2 id="things-to-consider-before-proposing-changes-to-openjdk-code"> Things to consider before proposing changes to OpenJDK code</h2> Every change to JDK code carries a risk of changes in behavior which may adversely affect applications. Generally we’re looking to improve the functionality and capability and sometimes performance of the platform without that negative consequence. So we need to ask ourselves whether each change is worthwhile - and some may not be no matter how well intentioned. One question to ask yourself is: What problem are you trying to solve? The important thing here is to understand the problem itself, independent of any solution (and independently of the solution that currently happens to be in your change). A number of other questions and lines of thought emanate from thinking about the problem. For example: is this the right problem to solve? Does solving this problem create worse problems elsewhere; that is, is there a net benefit? Does this problem need to be solved in the JDK, or can and should it be solved elsewhere (e.g., in tooling)? The next question you need to answer before making any change is: What is the main intention of your change? Depending on your answer to that question you will need to consider one or more of the following paragraphs. <ul> <li> Correctness – If your change improves program correctness, that’s important. And to broaden this, fixing of all kinds of bugs that really make things better for applications in ways they can detect is important. </li> <li> Robustness – Updating code to use a newer platform API can be a good change. Moving away from APIs that are being deprecated or that are no longer maintained is likely desired. Do note though that supposedly equivalent APIs may not be the drop in replacement you think they are. You’ll need to prove that the code has the same behavior after the change through extensive testing. </li> <li> Security – If you intend to increase the overall security of the platform, changes following secure coding practices and using appropriate platform APIs for that are usually welcome. The exception might be if it’s a potentially destabilizing change in code where there’s only a theoretical problem. Please note: If you think you found a real security bug that might compromise the platform you should follow the process <a href="https://openjdk.org/groups/vulnerability/report">here</a>. </li> <li> Refactoring / Cleanup – Making code easier to understand or reducing code size may be a good change in areas that are under active development. Stable code however isn’t a good candidate for refactoring regardless of what the code looks like. The OpenJDK has evolved over many years and some parts have been stable for decades. If there’s no immediate need to work on the code for other reasons, then what will a cleanup actually achieve? One specific area where refactoring and cleanups are explicitly discouraged is in third-party code. </li> <li> Performance – Can you demonstrate a user perceptible change? If you can’t measure the change, or a user can’t notice the change, or the change only improves code that is used infrequently, then maybe it isn’t worth it. Do you have benchmarks to back up your claims? Do you understand the results? Performance testing is complex and often there are many factors unrelated to your change that affects the numbers. What’s the tradeoff? The performance improvements that just make everything better do exist, but they are extremely rare. Most often the code gets more complex, or you speed up one case but slow down another. Are you making the right tradeoff? </li> <li> Modernizing – Changing code purely for the sake of using a new language feature isn’t usually a good change. Be a subject matter expert, not just a language expert. Writing code in “a better way” is not guaranteed to be safe. A change of behavior is always possible and unless you understand the code you are changing at more than the core language/API level, and have looked into appropriate tests and can speak to the risks, then you should first find a subject matter expert to discuss it with. Keep in mind that the OpenJDK code is developed by a large community. If a new language feature is introduced, all developers working in that code must learn this new feature and understand the implications of using it. </li> </ul> <h2 id="i-have-a-patch-what-do-i-do">I have a patch, what do I do?</h2> <div class="box"> Quick Links <ul> <li><a href="https://www.oracle.com/technical-resources/oracle-contributor-agreement.html"> Oracle Contributor Agreement (OCA)</a></li> <li><a href="https://oca.opensource.oracle.com/?ojr=contrib-list">OCA Signatories List</a></li> <li><a href="https://openjdk.org/legal/">OpenJDK Legal Documents</a></li> <li><a href="https://bugs.openjdk.org/">JDK Bug System (JBS)</a></li> <li><a href="https://openjdk.org/bylaws#project-roles">OpenJDK Project Roles</a></li> </ul> </div> In many GitHub projects the standard way to propose a change is to create a pull request (PR) and discuss the patch in the PR. For <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> the situation is somewhat different. The JDK is used for mission critical applications and by millions of developers, the bar to contributing changes is high. Please follow the steps outlined below to make sure your change passes above the bar before creating a PR. <h3 id="sign-the-oca">1. Sign the OCA</h3> Like many other open-source communities, the OpenJDK Community requires Contributors to jointly assign their copyright on contributed code. <a href="https://www.oracle.com">Oracle</a> is the steward of OpenJDK and if you haven’t yet signed the <a href="https://oca.opensource.oracle.com/">Oracle Contributor Agreement</a> (OCA), and are not covered by a company-level agreement, then please do so. This is required in order to make your patch available for review. The OCA gives <a href="https://www.oracle.com">Oracle</a> and you as a Contributor joint copyright interests in the code. You will retain your copyright while also granting those rights to <a href="https://www.oracle.com">Oracle</a>. If you don’t know if your organization has signed the OCA you can check the <a href="https://oca.opensource.oracle.com/?ojr=contrib-list">OCA Signatories List</a>, or ask your legal advisor. When you sign the OCA, please make sure that you specify your GitHub user name in the <code>Username</code> field of the OCA. If you try to create a PR before you have signed the OCA, or if you didn’t specify your GitHub user name, you’ll get instructions telling you to do so, and the PR won’t be published until this is done. OCA registration is a manual process. Please allow for up to several days to have your OCA application processed, even though it’s normally processed swiftly. An alphabetical list of all of the assigned OpenJDK usernames can be found on the <a href="https://db.openjdk.org/people">OpenJDK people</a> list. You only need to sign the OCA once in order to cover all changes that you might contribute to any Oracle-sponsored open-source community. If you’ve already signed the OCA or the former SCA (Sun Contributor Agreement) for any Oracle-sponsored open-source community, then you do not need to sign it again in order to contribute to OpenJDK. Please note that you don’t need to sign an OCA if you work at Oracle or a company which has negotiated an equivalent agreement. <h3 id="socialize-your-change">2. Socialize your change</h3> Once the OCA is signed, please restrain your urge to create a PR just a little while longer. In order to prepare the community for your patch, please socialize your idea on the relevant <a href="#mailing-lists">mailing lists</a>. Almost all changes, and in particular any API changes, must go this route and have a broad agreement in place before there is any point in presenting code. To understand the criteria by which your patch is going to be judged, please read <a href="#why-is-my-change-rejected">Why is My Change Rejected?</a> below. In short, hidden constraints and assumptions, stability and quality, maintainability, compatibility, and conformance to specifications must be considered before your PR is ready to be submitted. If you don’t understand the constraints for acceptance, you might be surprised when your PR is rejected. <h3 id="find-a-sponsor">3. Find a Sponsor</h3> Socializing your change on the mailing lists also prevents the surprise that would otherwise make the community choke on their morning coffee when they see a huge patch in a new, unknown PR. As a new developer in the community you’ll need to make a few friends that agree with your change. There are many good reasons to make friends, but the one relevant here is that for your first changes you’ll need a <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> to facilitate the integration of your work. The <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> will perform any number of administrative tasks like JBS updates, additional testing, etc. It’s usual for a <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> to also be a reviewer of a change and thus familiar with it, but it’s not a requirement. <h3 id="create-a-tracking-issue-in-jbs">4. Create a tracking issue in JBS</h3> Many <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> require a tracking issue to be filed in the <a href="https://bugs.openjdk.org/">JDK Bug System (JBS)</a> before a change can be integrated. This is the case for instance for the JDK and the JDK Updates Projects. In order to obtain write access to JBS you need to be an <a href="https://openjdk.org/bylaws#author">Author</a> in an <a href="https://openjdk.org/bylaws#project">OpenJDK Project</a> (see <a href="#becoming-an-author">Becoming an Author</a>). For your first changes, ask your <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> to help you create the issue or file the bug through the <a href="https://bugreport.java.com/">Bug Report Tool</a>. <h3 id="get-acquainted-with-local-process">5. Get acquainted with local process</h3> Even though we strive to unify how things are done within OpenJDK, different areas and <a href="https://openjdk.org/bylaws#project">Projects</a> in OpenJDK may have slight variations in how they work. Some of these differences are highlighted throughout this guide, some aren’t. If you’re new to an area, make sure you understand local differences before you proceed. Ask your <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> who should be your main point of contact through your first developer experience in OpenJDK. <h2 id="why-is-my-change-rejected">Why is my change rejected?</h2> <div class="box"> Quick Links <ul> <li><a href="https://docs.oracle.com/javase/specs/">Java Language and Virtual Machine Specifications</a></li> <li><a href="https://docs.oracle.com/en/java/javase/15/docs/api/index.html">Java API Specification</a></li> <li><a href="https://wiki.openjdk.org/display/csr/Main">CSR Process</a></li> </ul> </div> Just about every Java developer out there has an idea or two for how to enhance something. And believe it or not, not every idea is a good idea. Even though many ideas are indeed good, we must be quite restrictive on what we actually include into the JDK. The goal is not to take in the maximum number of contributions possible, but rather to accept only the highest-quality contributions. The JDK is used daily by millions of people and thousands of businesses, often in mission-critical applications, and so every change must be scrutinized in detail. There are many reasons for this. <ul> <li> Hidden constraints and assumptions – Many sections of code have constraints and assumptions that aren’t necessarily visible at first glance. This might preclude certain changes, even those that might seem obvious. </li> <li> Stability and quality – The JDK is used by millions of developers and as a widely deployed commercial product, it’s held to a high standard of quality. Changes should include tests where practical, and core tests should pass at all times. The value of the change should outweigh the risk of introducing a bug or performance regression. </li> <li> Maintainability – Any new feature or code change will need to be maintained in the JDK essentially forever, thus imposing a maintenance burden on future maintainers. The code might still be in use long after you and the people who reviewed it have moved on. New maintainers must be able to understand how to fix bugs in this code. </li> <li> Complexity – Each new feature interacts with all the existing features, which can result in geometric growth of the interactions among features if features are added unchecked. Sometimes we avoid adding a new feature, even if it seems like an obvious thing to add, if that feature would make it difficult to add a more important feature in the future. </li> <li> Adherence to specifications – Much of the JDK is governed by a series of specifications, in particular the <a href="https://docs.oracle.com/javase/specs/">Java Language Specification</a>, the <a href="https://docs.oracle.com/javase/specs/">Java Virtual Machine Specification</a>, and the <a href="https://docs.oracle.com/en/java/javase/15/docs/api/index.html">Java API Specification</a> (“javadocs”). All changes must be checked and tested carefully to ensure that they don’t violate these specifications. </li> <li> Javadoc comments are specifications – The Java API Specification is authored in the form of javadoc comments, so even apparently innocuous changes to comments can be quite significant. It’s not always easy to tell what comments are part of the specification and what parts are merely code comments. Briefly, documentation comments on public packages, classes, and class members of exported modules are specifications. </li> <li> Specification changes – It’s possible to change the API specifications, and this is done regularly. However, these changes require even more scrutiny than code changes. This extra review is handled by the <a href="https://wiki.openjdk.org/display/csr/Main">CSR Process</a>. Specifications are written in stylized, somewhat formal language, and they don’t simply describe what the code does. Writing specifications is a separate skill from coding. </li> <li> Compatibility – Changes should also adhere to high standards of binary, source, and behavioral compatibility. The compatibility impact of apparently innocuous changes is sometimes startling. </li> </ul> For reasons like these it’s quite possible that your change, even though it adds value to you, isn’t deemed to add enough value to the larger community. If you’re relatively new to the Java platform then we recommend that you gain more experience writing Java applications before you attempt to work on the JDK itself. The purpose of the sponsored-contribution process is to bring developers who already have the skills required to work on the JDK into the existing development community. The members of this community have neither the time nor the patience required to teach basic Java programming skills or platform implementation techniques. The feature releases currently under development are in the JDK Project. Most development work is focused on the newest release, so generally you should be working against the latest JDK sources rather than the JDK Updates sources. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="mailing-lists">Mailing Lists</h1> <div class="box"> Quick Links <ul> <li><a href="https://mail.openjdk.org/mailman/listinfo">OpenJDK Mailing Lists Manager</a></li> </ul> </div> The mailing lists are the key communications mechanism for all OpenJDK work. All participation in an <a href="https://openjdk.org/bylaws#project">OpenJDK Project</a> starts with joining the relevant mailing list. A subscriber to an OpenJDK mailing list is referred to as a <a href="https://openjdk.org/bylaws#participant">Participant</a> in the <a href="https://openjdk.org/bylaws">Bylaws</a>. As a general recommendation we suggest to subscribe to <a href="https://mail.openjdk.org/mailman/listinfo/announce">announce</a>, <a href="https://mail.openjdk.org/mailman/listinfo/discuss">discuss</a>, and the <code>-dev</code> lists covering your explicit area of interest. All OpenJDK mailing lists are found here: <blockquote> <a href="https://mail.openjdk.org/mailman/listinfo"><code>mail.openjdk.org</code></a> </blockquote> <div class="note"> Please note that OpenJDK mailing lists typically are for discussions about the development of the JDK, not its usage. This is not a place to ask support questions. If you think you found an issue in or with the JDK, see <a href="#jbs---jdk-bug-system">JBS - JDK Bug System</a> for instructions on reporting it. </div> The OpenJDK Community is a friendly place. To keep it that way it’s important to keep a professional tone in emails and be aware that the community is global. Many different people with different backgrounds collaborate in these lists. Even though English is the required language for all lists, many Participants speak other languages as their native language. A high tolerance for non-perfect English is expected from anyone joining these lists. You’re also strongly encouraged to use your real name on the mailing lists. This adds to the professional tone of your email. Postings from anonymized mailboxes risk being seen as spam. If you do work in OpenJDK on behalf of your employer, please also list this affiliation. If your GitHub username differs from your real name it’s also a good idea to include that to identify yourself and your actions on <a href="https://github.com">GitHub</a>. You must be a member of a list to be able to post to that list. Some lists are moderated to keep the content on topic. Each list has its own archive where you can browse older conversations on the list. There are a few different types of lists. The list name has two parts to explain what the list is intended for, <code><name>-<suffix></code>. The name often refers to the <a href="https://openjdk.org/bylaws#project">Project</a> that owns the list or a specific area of interest that the list focuses on. The suffix is explained below. Not all <a href="https://openjdk.org/bylaws#project">Projects</a> or areas have all types of lists described here. <blockquote> <dl> <dt><code>-dev</code></dt> <dd>Technical discussions around the implementation of the Project artifacts. This is also where code reviews happen.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-use</code></dt> <dd>Technical discussions around the usage of the Project artifacts.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-discuss</code></dt> <dd>General discussions around the <a href="https://openjdk.org/bylaws#project">Project</a>. The special case <code>discuss@openjdk.org</code> is used for general discussions around OpenJDK. Discussions around new Project proposals usually happen here.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-changes</code></dt> <dd>Changeset notifications from the source code repositories maintained by the <a href="https://openjdk.org/bylaws#project">Project</a>.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-announce</code></dt> <dd>General Project announcements. These lists are tightly moderated and are expected to be low traffic. The special case <code>announce@openjdk.org</code> is used for announcements for OpenJDK.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-experts</code></dt> <dd>Expert group discussions. The list is restricted; only members of the expert group can subscribe.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-observers</code></dt> <dd>Open for anyone to subscribe to see what the experts are discussing and potentially to have some dialog with other non-experts. There is no guarantee that an expert is subscribed to the <code>-observers</code> list or will see any responses on that list.</dd> </dl> </blockquote> <blockquote> <dl> <dt><code>-comments</code></dt> <dd>Used by observers to directly provide feedback/comments to the experts (typically a lead will process the comments list and forward things on to the experts list).</dd> </dl> </blockquote> <h2 id="changing-your-email-address">Changing your email address</h2> If you need to change your registered email address, or if you have any other problems with the mailing lists, please contact <a href="mailto:mailman@openjdk.org">mailman@openjdk.org</a>. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="code-conventions">Code Conventions</h1> <div class="box"> Quick Links <ul> <li><a href="https://www.oracle.com/technetwork/java/codeconvtoc-136057.html">Java Code Conventions</a></li> <li><a href="https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md">HotSpot C++ Code Conventions</a></li> </ul> </div> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="jbs---jdk-bug-system">JBS - JDK Bug System</h1> <div class="box"> Quick Links <ul> <li><a href="https://bugreport.java.com/">Bug Report Tool</a></li> <li><a href="https://bugs.openjdk.org/">JDK Bug System (JBS)</a></li> </ul> </div> <a href="https://bugs.openjdk.org/">JBS</a> is a public issue tracker used by many <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> and is open for anyone to read and search. To get write access you need to be registered in the <a href="https://openjdk.org/census">OpenJDK Census</a> by becoming, for instance, an <a href="https://openjdk.org/bylaws#author">Author</a> in an <a href="https://openjdk.org/bylaws#project">OpenJDK Project</a>. <h2 id="filing-an-issue">Filing an issue</h2> When a new failure is found, or an improvement identified, an issue should be filed to describe and track its resolution. Depending on your role in OpenJDK you can either use the <a href="https://bugreport.java.com/">Bug Report Tool</a> or, if you are registered in the <a href="https://openjdk.org/census">OpenJDK Census</a>, you can report the issue directly in <a href="https://bugs.openjdk.org/">JBS</a>. When filing an issue, try to make the report as complete as possible in order to make it easier to triage, investigate and resolve the issue. Bug descriptions and comments should be written in a professional manner. <div class="note"> If you suspect that the issue is a vulnerability, don’t file a JBS issue! Instead send your report to <a href="mailto:vuln-report@openjdk.org">vuln-report@openjdk.org</a>. Also use this alias if you find an existing report which may cover a vulnerability - please do not report or discuss potential vulnerabilities on any open lists or other public channels - see <a href="https://openjdk.org/groups/vulnerability/report">OpenJDK Vulnerabilities</a> for more information. </div> A few things to keep in mind when filing an issue: <ul> <li>Before filing, verify that there isn’t an open issue already filed. <ul> <li>Search <a href="https://bugs.openjdk.org/">JBS</a> for things like the name of the failing test, assert messages, the name of the source code file where a crash occurred etc.</li> <li>If you find a similar issue that was closed as Cannot Reproduce then it may be appropriate to re-open that one - if you don’t have direct access to JBS you can file a bug using the <a href="https://bugreport.java.com/">Bug Report Tool</a> requesting that it be reopened.</li> </ul> </li> <li>Make a reasonable attempt to narrow down which build or release the failure first appeared in.</li> <li>Set Affects Version/s to the earliest JDK version where the failure was seen. <ul> <li>If the failure is found in an update train of the JDK (e.g. 11.0.x), please see (if possible) if it’s also present in <a href="https://github.com/openjdk/jdk">mainline</a>. See <a href="#indicating-what-releases-an-issue-is-applicable-to">Indicating what releases an issue is applicable to</a> for more details.</li> <li>All issues of type Bug must have the Affects Version/s set. It’s not a bug if it doesn’t affect some version.</li> <li>For enhancements the Affects Version/s should be left empty, unless it is only relevant to a specific release family.</li> </ul> </li> <li>Add relevant Labels like <a href="#intermittent">intermittent</a>, <a href="#regression">regression</a>, <a href="#noreg-self">noreg-self</a>, <a href="#tier">tier1</a> etc. <ul> <li>For more information see the <a href="#jbs-label-dictionary">JBS Label Dictionary</a>.</li> </ul> </li> <li>Set the priority. <ul> <li>It’s not the reporter’s responsibility to set a correct priority, this will be done later in <a href="#triaging-an-issue">triage</a>, but a qualified guess is always better than the default. In JBS the range of priorities go from P1 (High/Important) to P5 (Very Low/Not Important), with the default being P4.</li> <li>If you have a sense that the issue is critical, or not critical at all, then adjusting the priority higher or lower makes sense, otherwise you can leave it as the default.</li> <li>When setting the priority, consider things like how the bug impacts the product and our testing, how likely is it that the bug is triggered, how difficult is it to work around, and whether it’s a regression, since that may break existing applications. Regressions are often higher priority than long-standing bugs and may block a release if not fixed. An example of a P1 would be an issue that is blocking a build or a release, whereas a P5 would be a minor typo in a code comment.</li> </ul> </li> <li>In the Description, always include (if possible): <ul> <li>error messages</li> <li>assert messages</li> <li>stack trace</li> <li>command line information</li> <li>relevant information from the logs</li> <li>full name of any failing tests</li> </ul> </li> <li>Avoid including in the report: <ul> <li>personal information</li> <li>passwords, logins, machine names</li> <li>logs which may include sensitive data</li> <li>large amount of text or data - large logfiles are better provided as attachments</li> </ul> </li> <li>If the failure isn’t reproducible with an existing OpenJDK test, attach a reproducer if possible, having a test case will decrease the time required to resolve the issue.</li> <li>In general the CPU and/or OS fields should not be set. ONLY use them if you know that the issue is only relevant to a particular platform or set of platforms.</li> <li>Provide the output of <code>java -version</code> whenever possible - this version information is particularly critical for hangs, JVM bugs, and network issues.</li> <li>Always file separate bugs for different issues. <ul> <li>If two crashes look related, but not similar enough to be sure they are the same, it’s easier to later close a bug as a duplicate than it is to separate out one bug into two.</li> </ul> </li> </ul> <h3 id="types-of-issues">Types of issues</h3> The most common issue types are: <table> <colgroup> <col width="15%" /> <col width="84%" /></colgroup> <thead> <tr class="header"> <th align="left">Issue Type</th> <th align="left">Covers</th> </tr> </thead> <tbody> <tr class="odd"> <td align="left">Bug</td> <td align="left">A Bug should relate to functional correctness - a deviation from behavior that can be tied back to a specification. Anything else, including performance concerns, is generally not a bug, but an enhancement. Though it’s not clear-cut as a significant performance regression may be classified as a Bug, for example.</td> </tr> <tr class="even"> <td align="left">Enhancement</td> <td align="left">An Enhancement is a small to medium improvement to existing functionality.</td> </tr> <tr class="odd"> <td align="left">JEP</td> <td align="left">The JEP issue type is used for a proposal of a significant change or new feature which will take four or more weeks of work - see <a href="https://openjdk.org/jeps/1">JEP-1</a>.</td> </tr> <tr class="even"> <td align="left">Sub-task</td> <td align="left">Sub-tasks can be used to break up the work for an issue, such as the changes to the docs, tests etc. This is not recommended as a way to break up a large amount of code change associated with a new feature - see <a href="#implementing-a-jep">Implementing a JEP</a> or <a href="#implementing-a-large-change">Implementing a large change</a> below.</td> </tr> <tr class="odd"> <td align="left">Task</td> <td align="left">Tasks are used to track work that isn’t expected to result in a change in any code repository. They are used for related activities such as a new JBS version number, a build request, an update to a document etc.</td> </tr> <tr class="even"> <td align="left">New Feature</td> <td align="left">Not recommended for use.</td> </tr> </tbody> </table> <div class="note"> A Bug or Enhancement should only be used if the work is expected to result in a change in a code repository. A Bug or Enhancement with resolution Fixed is required to have a corresponding changeset in one of the OpenJDK repositories. </div> <h3 id="indicating-what-releases-an-issue-is-applicable-to"> Indicating what releases an issue is applicable to</h3> Knowing when an issue was introduced is important to determine the impact of the issue and where it needs to be resolved. While in some cases it may be clear, it is likely that on submission and during triage this won’t be known, instead we will have one or two data points from which we can begin to understand the range of releases which the issue impacts. The Affects Version/s field is used to indicate which releases an issue is applicable to, and to avoid having to set it to an exhaustive list of impacted releases the following assumptions are used to give that range: <ol style="list-style-type: decimal"> <li>If an issue is applicable to a feature release N, it is assumed to be applicable to all (more recent) releases unless indicated otherwise (see <a href="#usage-of-the-rel-na-label">(Rel)-na</a> below). <ul> <li>Note that if it’s reported against an update release then all we can say is that it’s applicable to all the following update releases, not necessarily the next feature release as it may have been introduced in an update. Given this, it is always important to try and reproduce the issue in the corresponding feature release as well as mainline.</li> </ul> </li> <li>If an issue is applicable to release N, then it can’t be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it’s relevant to earlier LTS releases.</li> </ol> Another aspect of an issue is when the feature it’s a part of was added or removed from the JDK, which in either case limits the range of releases the issue impacts. Knowing that a feature was removed before the oldest currently maintained release means it can be resolved as Won’t Fix. <h4 id="setting-the-affects-versions-field">Setting the Affects Version/s field</h4> <div class="note"> Note that the Affects Version/s field is mainly used for bugs and bug-like tasks/sub-tasks etc. In general enhancements and enhancement-like tasks/sub-tasks should not have an Affects Version/s. </div> Set the Affects Version/s field to the lowest release where the bug has been seen. <ul> <li>The Affects Version/s isn’t meant to be an exhaustive list of releases the issue is relevant to - it should initially be set to the release the issue was reproduced or identified on, and by implication it will be relevant to all releases past that point (see <a href="#usage-of-rel-na-label">Usage of the (Rel)-na Label</a>). If it’s later found to be applicable to an earlier release family then adding that earlier release is encouraged if the issue needs to be fixed in that release.</li> <li>Don’t add additional release values to Affects Version/s for the same release family. For example, if there is the value 11.0.2, don’t add 11.0.5, 11.0.7 etc. Adding an additional value for a separate release family where it’s still reproducible, e.g. JDK 21, is encouraged if there isn’t currently a feature release value set, or, it has been a few releases since it was last reproduced/reviewed. For example, if the Affects Version/s is JDK 8, but it is still relevant to the latest mainline release.</li> </ul> <h4 id="usage-of-the-rel-na-label">Usage of the (Rel)-na Label</h4> Labels of the form (Rel)-na (eg. 17-na) should be used when a bug is not applicable to a more recent release family. For example: Affects Version/s: 7u111, 8u131 add the label 9-na if the issue is not relevant to JDK 9 and above. Reasons why this would be the case include the fact that the source has been removed from a later release or rewritten such that the issue is no longer relevant. Don’t: <ul> <li> use the label to indicate that a bug is not relevant to an earlier release, for example Affects Version/s: 11.0.20, 17 the label 8-na would not be needed - as it doesn’t have a JDK 8 release, or earlier, value in the Affects Version/s, it is not relevant to JDK 8. Also see <a href="#usage-of-rel-wnf-label">Usage of the (Rel)-wnf Label</a> </li> <li> add multiple -na labels: you only need one, for example don’t add both 9-na and 11-na — 9-na implies all following releases therefore 11-na, or 17-na etc. are not needed. </li> <li> It’s not recommended to specify update releases like 17u4 or 21u in the label. Labels like 17-na and 21-na are in general enough. </li> </ul> <h4 id="usage-of-the-rel-wnf-label">Usage of the (Rel)-wnf Label</h4> Labels of the form (Rel)-wnf (e.g. 11-wnf) should be used to indicate that a bug is not going to be fixed in a release that it’s applicable to, or any earlier releases. For example, 11-wnf states it won’t be fixed in JDK 11 and implicitly indicates it won’t be fixed in JDK 8 either. Add a comment when adding a (Rel)-wnf label so that it’s clear for those looking at the issue, why it won’t be fixed in that release. <h4 id="examples">Examples</h4> <div class="figure"><img src="affects_versions.png" alt="" /> Guidelines for setting Affects Version/s </div> <ol style="list-style-type: decimal"> <li>Issue relevant to JDK 8 and all future releases.</li> <li>No need to add additional releases as they are implied.</li> <li>Adding the occasional LTS release value is ok.</li> <li>Use N-na to indicate that the issue is no longer relevant from that release, which could be due to the feature or platform being removed or the code being rewritten.</li> <li>Use N-wnf to indicate that a fix will not be backported to that release, or earlier.</li> </ol> <h3 id="things-to-keep-in-mind-when-requesting-an-improvement"> Things to keep in mind when requesting an improvement</h3> Unlike reporting a problem, when it comes to improvements, what constitutes a reasonable request can take discussion, and in general it’s encouraged that the <a href="#mailing-lists">mailing list</a> for the area is used to suggest an improvement before filing. Enhancements to the Java Language Specification and the JVM Specification are managed through the <a href="http://jcp.org/">Java Community Process</a>. To find out which component to use for different bugs, consult the <a href="#directory-to-area-mapping">directory to area mapping</a>. <h3 id="implementing-a-large-change">Implementing a large change</h3> When managing the work for a large change, especially when the work involves multiple engineers, it’s recommended that the work is distributed across one or more “implementation” issues which should be linked to the main enhancement with a “blocks” link along with any relevant CSRs. The enhancement shouldn’t be considered done until all the blocking elements are completed. The use of sub-tasks for enhancements is not recommended unless all the sub-tasks are relevant to the fix, if it were to be backported, for example <a href="https://bugs.openjdk.org/browse/JDK-8231641">JDK-8231641</a> or <a href="https://bugs.openjdk.org/browse/JDK-8171407">JDK-8171407</a>. <h3 id="implementing-a-jep">Implementing a JEP</h3> It’s recommended for JEPs that the implementation is spread across one or more Enhancements as described above. <h2 id="issue-states">Issue states</h2> JBS only has a few states in which a Bug or Enhancement can be: <table> <colgroup> <col width="15%" /> <col width="84%" /></colgroup> <thead> <tr class="header"> <th align="left">Type</th> <th align="left">Covers</th> </tr> </thead> <tbody> <tr class="odd"> <td align="left">New</td> <td align="left">Initial state after an issue is filed. Bugs in the JDK Project must be taken out of the New state (“Triaged” - see below) in a timely manner. In general, triaging is recommended to be done for all issue types and projects as a sign that the issue is correctly filed, and will be seen by the right developers - this is especially important towards the end of a release.</td> </tr> <tr class="even"> <td align="left">Open</td> <td align="left">Once the issue has been triaged it will be in the Open state and will stay here until an assignee decides to work on it, at which point it’s encouraged that the “Start Work” option be selected to move it to In Progress.</td> </tr> <tr class="odd"> <td align="left">In Progress</td> <td align="left">The In Progress state is used to show that the assignee is actively working on the issue. It has the optional sub-states (Understanding): Cause Known, Fix Understood, In Review.</td> </tr> <tr class="even"> <td align="left">Resolved</td> <td align="left">When the issue has been fixed it is Resolved using the Resolve action in JBS.</td> </tr> <tr class="odd"> <td align="left">Closed</td> <td align="left">To finally close an issue it also needs to be verified using the issue’s regression test.</td> </tr> </tbody> </table> <div style="text-align:center;"> <div class="figure"><img src="data:image/svg+xml;base64,<svg id="mermaid-1738190653612" width="100%" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="721" style="max-width: 536.492px; background-color: white;" viewBox="0 0 536.4921875 721"><style>#mermaid-1738190653612 {font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;fill:#000000;}#mermaid-1738190653612 .error-icon{fill:#552222;}#mermaid-1738190653612 .error-text{fill:#552222;stroke:#552222;}#mermaid-1738190653612 .edge-thickness-normal{stroke-width:2px;}#mermaid-1738190653612 .edge-thickness-thick{stroke-width:3.5px;}#mermaid-1738190653612 .edge-pattern-solid{stroke-dasharray:0;}#mermaid-1738190653612 .edge-pattern-dashed{stroke-dasharray:3;}#mermaid-1738190653612 .edge-pattern-dotted{stroke-dasharray:2;}#mermaid-1738190653612 .marker{fill:#666;stroke:#666;}#mermaid-1738190653612 .marker.cross{stroke:#666;}#mermaid-1738190653612 svg{font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;}#mermaid-1738190653612 .label{font-family:"trebuchet ms",verdana,arial,sans-serif;color:#000000;}#mermaid-1738190653612 .cluster-label text{fill:#333;}#mermaid-1738190653612 .cluster-label span{color:#333;}#mermaid-1738190653612 .label text,#mermaid-1738190653612 span{fill:#000000;color:#000000;}#mermaid-1738190653612 .node rect,#mermaid-1738190653612 .node circle,#mermaid-1738190653612 .node ellipse,#mermaid-1738190653612 .node polygon,#mermaid-1738190653612 .node path{fill:#eee;stroke:#999;stroke-width:1px;}#mermaid-1738190653612 .node .label{text-align:center;}#mermaid-1738190653612 .node.clickable{cursor:pointer;}#mermaid-1738190653612 .arrowheadPath{fill:#333333;}#mermaid-1738190653612 .edgePath .path{stroke:#666;stroke-width:2.0px;}#mermaid-1738190653612 .flowchart-link{stroke:#666;fill:none;}#mermaid-1738190653612 .edgeLabel{background-color:white;text-align:center;}#mermaid-1738190653612 .edgeLabel rect{opacity:0.5;background-color:white;fill:white;}#mermaid-1738190653612 .cluster rect{fill:hsl(0, 0%, 98.9215686275%);stroke:#707070;stroke-width:1px;}#mermaid-1738190653612 .cluster text{fill:#333;}#mermaid-1738190653612 .cluster span{color:#333;}#mermaid-1738190653612 div.mermaidTooltip{position:absolute;text-align:center;max-width:200px;padding:2px;font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:12px;background:hsl(-160, 0%, 93.3333333333%);border:1px solid #707070;border-radius:2px;pointer-events:none;z-index:100;}#mermaid-1738190653612 :root{--mermaid-font-family:"trebuchet ms",verdana,arial,sans-serif;}</style><g transform="translate(0, 0)"><marker id="flowchart-pointEnd" class="marker flowchart" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="userSpaceOnUse" markerWidth="12" markerHeight="12" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-pointStart" class="marker flowchart" viewBox="0 0 10 10" refX="0" refY="5" markerUnits="userSpaceOnUse" markerWidth="12" markerHeight="12" orient="auto"><path d="M 0 5 L 10 10 L 10 0 z" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-circleEnd" class="marker flowchart" viewBox="0 0 10 10" refX="11" refY="5" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><circle cx="5" cy="5" r="5" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></circle></marker><marker id="flowchart-circleStart" class="marker flowchart" viewBox="0 0 10 10" refX="-1" refY="5" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><circle cx="5" cy="5" r="5" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></circle></marker><marker id="flowchart-crossEnd" class="marker cross flowchart" viewBox="0 0 11 11" refX="12" refY="5.2" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><path d="M 1,1 l 9,9 M 10,1 l -9,9" class="arrowMarkerPath" style="stroke-width: 2; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-crossStart" class="marker cross flowchart" viewBox="0 0 11 11" refX="-1" refY="5.2" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><path d="M 1,1 l 9,9 M 10,1 l -9,9" class="arrowMarkerPath" style="stroke-width: 2; stroke-dasharray: 1, 0;"></path></marker><g class="root"><g class="clusters"></g><g class="edgePaths"></g><g class="edgeLabels"></g><g class="nodes"><g class="root" transform="translate(0.5, 0)"><g class="clusters"><g class="cluster default" id="top"><rect style="fill:white;" rx="0" ry="0" x="8" y="8" width="520.4921875" height="705"></rect><g class="cluster-label" transform="translate(268.24609375, 13)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"></span></div></foreignObject></g></g></g><g class="edgePaths"><path d="M312.6484375,57.00333495548622L293.8567708333333,62.75277912957185C275.0651041666667,68.50222330365749,237.48177083333334,80.00111165182874,218.69010416666666,89.91722249258105C199.8984375,99.83333333333333,199.8984375,108.16666666666667,199.8984375,112.33333333333333L199.8984375,116.5" id="L-New-triage-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-New LE-triage" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M380.5456112132353,218.5L383.2502489276961,212.79166666666666C385.9548866421569,207.08333333333334,391.36416207107845,195.66666666666666,394.06879978553917,181.45833333333334C396.7734375,167.25,396.7734375,150.25,396.7734375,134.79166666666666C396.7734375,119.33333333333333,396.7734375,105.41666666666667,390.6549479166667,94.23033716945754C384.5364583333333,83.04400767224844,372.2994791666667,74.5880153444969,366.1809895833333,70.36001918062111L360.0625,66.13202301674534" id="L-Open-New-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-Open LE-New" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M171.61677581188727,150L161.97849807240604,155.70833333333334C152.34022033292484,161.41666666666666,133.06366485396242,172.83333333333334,130.23704299428104,184.25C127.41042113459967,195.66666666666666,141.03373289419935,207.08333333333334,147.84538877399916,212.79166666666666L154.657044653799,218.5" id="L-triage-ResolvedIncomplete-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-triage LE-ResolvedIncomplete" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M194.632017846201,218.5L201.44367372600084,212.79166666666666C208.25532960580065,207.08333333333334,221.87864136540034,195.66666666666666,224.70526322508172,184.25C227.53188508476308,172.83333333333334,219.56181704452615,161.41666666666666,215.57678302440772,155.70833333333334L211.59174900428923,150" id="L-ResolvedIncomplete-triage-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-ResolvedIncomplete LE-triage" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M174.64453125,252L174.64453125,257.7083333333333C174.64453125,263.4166666666667,174.64453125,274.8333333333333,174.64453125,286.25C174.64453125,297.6666666666667,174.64453125,309.0833333333333,174.64453125,314.7916666666667L174.64453125,320.5" id="L-ResolvedIncomplete-ClosedIncomplete-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-ResolvedIncomplete LE-ClosedIncomplete" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M174.64453125,354L174.64453125,358.1666666666667C174.64453125,362.3333333333333,174.64453125,370.6666666666667,174.64453125,381.7916666666667C174.64453125,392.9166666666667,174.64453125,406.8333333333333,174.64453125,420.75C174.64453125,434.6666666666667,174.64453125,448.5833333333333,174.64453125,462.5C174.64453125,476.4166666666667,174.64453125,490.3333333333333,174.64453125,504.25C174.64453125,518.1666666666666,174.64453125,532.0833333333334,174.64453125,546C174.64453125,559.9166666666666,174.64453125,573.8333333333334,174.64453125,587.75C174.64453125,601.6666666666666,174.64453125,615.5833333333334,184.86881510416666,626.983014624696C195.09309895833334,638.3826959160588,215.54166666666666,647.2653918321174,225.76595052083334,651.7067397901468L235.990234375,656.1480877481762" id="L-ClosedIncomplete-Closed-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-ClosedIncomplete LE-Closed" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M228.2750363817402,150L237.94566833895018,155.70833333333334C247.61630029616012,161.41666666666666,266.9575642105801,172.83333333333334,286.5562560636234,184.40805348751255C306.1549479166667,195.98277364169175,326.0110677083333,207.71554728338347,335.9391276041667,213.58193410422936L345.8671875,219.44832092507525" id="L-triage-Open-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-triage LE-Open" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M354.4622587316176,252L348.2777937346814,257.7083333333333C342.093328737745,263.4166666666667,329.72439874387254,274.8333333333333,323.53993374693624,289.0416666666667C317.35546875,303.25,317.35546875,320.25,317.35546875,335.7083333333333C317.35546875,351.1666666666667,317.35546875,365.0833333333333,322.8698306511976,376.2083333333333C328.38419255239523,387.3333333333333,339.4129163547904,395.6666666666667,344.927278255988,399.8333333333333L350.44164015718565,404" id="L-Open-states-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-Open LE-states" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M383.6259382659314,252L387.38033917994284,257.7083333333333C391.13474009395424,263.4166666666667,398.64354192197715,274.8333333333333,402.39794283598854,286.25C406.15234375,297.6666666666667,406.15234375,309.0833333333333,406.15234375,314.7916666666667L406.15234375,320.5" id="L-Open-InProgress-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-Open LE-InProgress" style="fill:none;" marker-start="url(#flowchart-pointStart)" marker-end="url(#flowchart-pointEnd)"></path><path d="M406.15234375,354L406.15234375,358.1666666666667C406.15234375,362.3333333333333,406.15234375,370.6666666666667,402.8047420783433,379C399.4571404066866,387.3333333333333,392.7619370633732,395.6666666666667,389.4143353917166,399.8333333333333L386.06673372005986,404" id="L-InProgress-states-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-InProgress LE-states" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M331.80397408308386,437.5L321.6533768400699,441.6666666666667C311.5027795970559,445.8333333333333,291.20158511102795,454.1666666666667,281.050987868014,465.2916666666667C270.900390625,476.4166666666667,270.900390625,490.3333333333333,270.900390625,504.25C270.900390625,518.1666666666666,270.900390625,532.0833333333334,270.900390625,546C270.900390625,559.9166666666666,270.900390625,573.8333333333334,270.900390625,587.75C270.900390625,601.6666666666666,270.900390625,615.5833333333334,270.8859663485529,626.7083333333334C270.8715420721058,637.8333333333334,270.8426935192116,646.1666666666666,270.8282692427645,650.3333333333334L270.8138449663174,654.5" id="L-states-Closed-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-states LE-Closed" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M388.3305225486527,437.5L392.24125576971056,441.6666666666667C396.1519889907684,445.8333333333333,403.97345543288424,454.1666666666667,407.88418865394215,462.5C411.794921875,470.8333333333333,411.794921875,479.1666666666667,411.794921875,483.3333333333333L411.794921875,487.5" id="L-states-Resolved-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-states LE-Resolved" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M411.794921875,521L411.794921875,525.1666666666666C411.794921875,529.3333333333334,411.794921875,537.6666666666666,411.794921875,546C411.794921875,554.3333333333334,411.794921875,562.6666666666666,411.794921875,566.8333333333334L411.794921875,571" id="L-Resolved-Verify-0" class=" edge-thickness-normal edge-pattern-dotted flowchart-link LS-Resolved LE-Verify" style="fill:none;stroke-width:2px;stroke-dasharray:3;" marker-end="url(#flowchart-pointEnd)"></path><path d="M411.794921875,604.5L411.794921875,608.6666666666666C411.794921875,612.8333333333334,411.794921875,621.1666666666666,394.0826822916667,630.5764623608264C376.3704427083333,639.9862580549863,340.9459635416667,650.4725161099725,323.2337239583333,655.7156451374657L305.521484375,660.9587741649588" id="L-Verify-Closed-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-Verify LE-Closed" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path></g><g class="edgeLabels"><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(396.7734375, 133.25)"><g class="label" transform="translate(-87.5546875, -9.25)"><foreignObject width="175.109375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">Move to new component</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(113.787109375, 184.25)"><g class="label" transform="translate(-70.91796875, -9.25)"><foreignObject width="141.8359375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">sync with submitter</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(235.501953125, 184.25)"><g class="label" transform="translate(-30.796875, -9.25)"><foreignObject width="61.59375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">Clarified</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(174.64453125, 286.25)"><g class="label" transform="translate(-45.77734375, -9.25)"><foreignObject width="91.5546875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">Not Clarified</span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g><g class="edgeLabel"><g class="label" transform="translate(0, 0)"><foreignObject width="0" height="0"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel"></span></div></foreignObject></g></g></g><g class="nodes"><g class="node default default" id="flowchart-New-48" transform="translate(336.35546875, 49.75)"><rect class="basic label-container" style="fill:lightgrey;" rx="5" ry="5" x="-23.70703125" y="-16.75" width="47.4140625" height="33.5"></rect><g class="label" style="" transform="translate(-16.20703125, -9.25)"><foreignObject width="32.4140625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">NEW</span></div></foreignObject></g></g><g class="node default default" id="flowchart-triage-49" transform="translate(199.8984375, 133.25)"><rect class="basic label-container" style="fill:white;" rx="0" ry="0" x="-28.64453125" y="-16.75" width="57.2890625" height="33.5"></rect><g class="label" style="" transform="translate(-21.14453125, -9.25)"><foreignObject width="42.2890625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">triage</span></div></foreignObject></g></g><g class="node default default" id="flowchart-Open-52" transform="translate(372.609375, 235.25)"><rect class="basic label-container" style="fill:lightgrey;" rx="5" ry="5" x="-26.7421875" y="-16.75" width="53.484375" height="33.5"></rect><g class="label" style="" transform="translate(-19.2421875, -9.25)"><foreignObject width="38.484375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">OPEN</span></div></foreignObject></g></g><g class="node default default" id="flowchart-ResolvedIncomplete-50" transform="translate(174.64453125, 235.25)"><rect class="basic label-container" style="fill:green;" rx="5" ry="5" x="-85.65625" y="-16.75" width="171.3125" height="33.5"></rect><g class="label" style="" transform="translate(-78.15625, -9.25)"><foreignObject width="156.3125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"><font color="white">RESOLVED:Incomplete</font></span></div></foreignObject></g></g><g class="node default default" id="flowchart-ClosedIncomplete-51" transform="translate(174.64453125, 337.25)"><rect class="basic label-container" style="fill:lightgreen;" rx="5" ry="5" x="-77.91015625" y="-16.75" width="155.8203125" height="33.5"></rect><g class="label" style="" transform="translate(-70.41015625, -9.25)"><foreignObject width="140.8203125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"><font color="green">CLOSED:Incomplete</font></span></div></foreignObject></g></g><g class="node default default" id="flowchart-Closed-57" transform="translate(270.755859375, 671.25)"><rect class="basic label-container" style="fill:lightgreen;" rx="5" ry="5" x="-34.765625" y="-16.75" width="69.53125" height="33.5"></rect><g class="label" style="" transform="translate(-27.265625, -9.25)"><foreignObject width="54.53125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"><font color="green">CLOSED</font></span></div></foreignObject></g></g><g class="node default default" id="flowchart-states-54" transform="translate(372.609375, 420.75)"><rect class="basic label-container" style="fill:white;" rx="0" ry="0" x="-120.8828125" y="-16.75" width="241.765625" height="33.5"></rect><g class="label" style="" transform="translate(-113.3828125, -9.25)"><foreignObject width="226.765625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Fixed, Won't Fix, Duplicate etc.</span></div></foreignObject></g></g><g class="node default default" id="flowchart-InProgress-53" transform="translate(406.15234375, 337.25)"><rect class="basic label-container" style="" rx="5" ry="5" x="-53.796875" y="-16.75" width="107.59375" height="33.5"></rect><g class="label" style="" transform="translate(-46.296875, -9.25)"><foreignObject width="92.59375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"><font color="blue">IN PROGRESS</font></span></div></foreignObject></g></g><g class="node default default" id="flowchart-Resolved-55" transform="translate(411.794921875, 504.25)"><rect class="basic label-container" style="fill:green;" rx="5" ry="5" x="-42.51171875" y="-16.75" width="85.0234375" height="33.5"></rect><g class="label" style="" transform="translate(-35.01171875, -9.25)"><foreignObject width="70.0234375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel"><font color="white">RESOLVED</font></span></div></foreignObject></g></g><g class="node default default" id="flowchart-Verify-56" transform="translate(411.794921875, 587.75)"><rect class="basic label-container" style="fill:white;" rx="0" ry="0" x="-28.33984375" y="-16.75" width="56.6796875" height="33.5"></rect><g class="label" style="" transform="translate(-20.83984375, -9.25)"><foreignObject width="41.6796875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Verify</span></div></foreignObject></g></g></g></g></g></g></g></svg>" alt="" /> JBS Issue Flow </div> </div> <h2 id="triaging-an-issue">Triaging an issue</h2> For most JDK areas, triage is performed on a regular basis (at least weekly) by triage teams. Each triage team consists of <a href="https://openjdk.org/bylaws#contributor">Contributors</a> who are area experts for a specific area or feature. If you haven’t been selected to be part of a triage team for a specific area you shouldn’t be triaging bugs in that area. When triaging an issue, first give it a general review. <ol style="list-style-type: decimal"> <li>If the issue is a duplicate, close it as such.</li> <li>If the issue belongs to a different area (it was filed in libraries, but it’s an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains New.</li> <li>If the issue is incomplete, add a comment noting what is needed and resolve the bug as Resolved - Incomplete. This is the JBS way of saying “need more information”. If no more information is obtained within reasonable time, the issue should be closed (Closed - Incomplete).</li> </ol> Now that the issue is in the right component and has the basic information, the analysis continues to get a more detailed understanding of the issue, and what should be done: <ol style="list-style-type: decimal"> <li>Ensure the priority is correct. <ul> <li>An approach that has been used for getting a consistent view of priority is to consider three aspects of the issue: Impact of the issue; Likelihood of it occurring; and, whether there is a Workaround. The higher the impact and likelihood the higher the priority; then, having a workaround reduces that priority - but mostly where the impact and likelihood aren’t that severe.</li> </ul> </li> <li>Ensure the Affects Version/s field is correct (within reason). <ul> <li>This may involve reproducing the bug, if doing so is fast and easy.</li> <li>In addition to the version where the bug was found, take special care to also investigate if the bug affects mainline. <ul> <li>See <a href="#indicating-what-releases-an-issue-is-applicable-to">Indicating what releases an issue is applicable to</a> for more details.</li> </ul> </li> <li>For enhancements the Affects Version/s should be empty unless you feel that the enhancement is only relevant to a particular release family, and shouldn’t go into a future mainline release.</li> <li>Affects Version/s should never use any of the “special” values available in JBS like tbd, na, unknown, (Rel)-pool or similar. Only actual JDK release numbers should be used. If you want to reflect that an issue is relevant to an older release, use a family release value or an exact release if you know where the issue was introduced: 8, 17, 21u4.</li> </ul> </li> <li>Set the Fix Version/s. <ul> <li>A bug should be fixed first in the most recent version where it exists. If you don’t know what version the fix will go into set the Fix Version/s to tbd or the appropriate (Rel)-pool if the fix is for a specific release family. If there is a (Rel)-pool in the fix version Skara tooling will use that issue/backport when you integrate the fix for that release family.</li> <li>If the bug also exists in older versions it may require <a href="#backporting">backporting</a>. <ul> <li>The decision to backport to a release should be made inline with the guidelines of the lead for that release.</li> <li>There are two options for creating backport issues to track the backport: one is to create it manually once it’s agreed that the bug should be backported; the second, is to let the bots create the backport issue once you integrate the fix to the repository (see <a href="#working-with-backports-in-jbs">Working with backports in JBS</a>). In most cases, letting the bots create the backport issue is preferred.</li> </ul> </li> <li>For Project internal changes intended to be integrated to a Project repository rather than the JDK or JDK Updates repositories, the Fix Version/s should be set to internal, or if the <a href="https://openjdk.org/bylaws#project">Project</a> is large enough to have its own repo-* fix version, use that.</li> <li>Only one Fix Version/s should ever be set. If the issue is to be fixed in additional releases then separate backport issues must be created (see <a href="#working-with-backports-in-jbs">Working with backports in JBS</a>). There are exceptions to this rule for CSRs and Release Notes.</li> </ul> </li> <li>Make sure the bug has all the required labels – see <a href="#jbs-label-dictionary">JBS Label Dictionary</a>. <ul> <li>Changes that don’t affect product code, but are only against the regression test, or problem-listing: <a href="#noreg-self">noreg-self</a></li> <li>Changes that don’t affect product code, but are only against documentation: <a href="#noreg-doc">noreg-doc</a></li> <li>Well contained issues that seem to be easy to fix: <a href="#starter">starter</a></li> <li>Enhancements that are pure cleanups: <a href="#cleanup">cleanup</a></li> <li>Project specific issues usually have their own labels as well</li> </ul> </li> <li>Managing regressions - for a bug (B) where behavior has incorrectly changed from a previous fix (A) ensure that the label <a href="#regression">regression</a> is added. Once it is known what fix caused the regression a caused by link should be added to ‘B’ or a causes link to ‘A’. A causes link would also be added to A if the fix causes a change of behavior (intentional or otherwise) or it is found after integration, that additional work needs to be done. In addition to adding a caused by link, set the Introduced in Version and Introduced in Build fields of ‘B’, based on which release ‘A’ was fixed in. Do not add a caused by link if there was no specific product fix which caused it, for example, the addition of a test which finds an underlying problem should not be linked.</li> </ol> At this point move the issue into the Open state. <h3 id="sensitive-information-e.g.-hs_err.log">Sensitive information (e.g. hs_err.log)</h3> It may sound obvious, but avoid placing sensitive information in bug reports. Things like usernames, IP addresses, host names, and exact version information of third party libraries etc. may be crucial to be able to debug in some cases, but could also help an attacker gain information about your system. JBS is a public database that anyone can search, so be mindful of what you place there. In particular when attaching log files like the hs_err.log you should make sure that you are comfortable sharing the details exposed in it. Sometimes it may be better to leave a comment saying that these details can be obtained on request. If you file a bug through the <a href="https://bugreport.java.com/">Bug Report Tool</a> there’s a specific field that should be used to place sensitive information like this. Information placed there will not be part of the public bug report. <h2 id="updating-an-issue-while-fixing">Updating an issue while fixing</h2> Once you are made, or you make yourself, the assignee of an issue you take on the responsibility of moving the issue through to resolution - providing the current status, and ultimately leaving a record for others in the future to understand what happened. There are no set rules for how you manage the bug while you are assigned to it, as it depends on the type and importance of an issue. A simple update to the doc needs little to be done, fix the problem and close the issue; an intricate timing issue or crash should be handled differently - documenting your progress in identifying the problem (e.g. <a href="https://bugs.openjdk.org/browse/JDK-8212207">JDK-8212207</a>, <a href="https://bugs.openjdk.org/browse/JDK-6984895">JDK-6984895</a>, <a href="https://bugs.openjdk.org/browse/JDK-8287982">JDK-8287982</a>), this is especially helpful if you ultimately move the issue to a different area as you have found that the problem lies elsewhere, or is closed as Won’t Fix. Your updates then provide a resource to others to better understand what has been done or the code itself. See <a href="https://stuartmarks.wordpress.com/2023/02/22/the-importance-of-writing-stuff-down"> The Importance of Writing Stuff Down</a> for a good explanation as to why it’s important. Some additional fields should be filled out or updated as you get a better understanding of the issue: <ul> <li>The Description usually explains what went wrong and how the failure was found, then there’s some investigation and eventually the root cause is found. At this point the Summary should be updated to correctly describe the bug. The Description however should remain a description of how the failure was found.</li> <li>The Affects Version/s should be updated if you in your investigation finds that the issue is older than what is indicated by the current Affects Version/s.</li> </ul> <h3 id="linking-issues">Linking Issues</h3> An important aspect of any issue is making clear how it is connected/related to other issues. This can occur at any stage of the issue’s lifecycle. For example, as information becomes available that might suggest a cause, or similar issue (relates to). There are the following link types: duplicate of - Normally set automatically - see <a href="#closing-issues-as-duplicates">Closing issues as duplicates</a> for more information backported by - Normally set automatically when creating a backport with the “More -> Create Backport” option, or by the Skara tooling CSR for - When creating a CSR with the “More -> Create CSR” option, a link is automatically created between the main issue and the new CSR blocks - For when other issues are dependent on the current issue being resolved/fixed before they can be. For example, when a fix is broken down into a number of parts the blocks link should be used to ensure they are all fixed before the main issue is considered resolved - see [implementing large changes](#implementing-large-changes] relates to - To avoid lots of relates to links, the links should have some significance in relation to the cause and/or fix, for the current issue. In addition, relates links should not duplicate an existing duplicated by, backported by, csr for or blocked by link. In particular, it may be necessary to manually remove a relates to link if it is later added as a duplicated by or caused by link causes/caused by - the causes link implies a stronger relationship than relates to. If an issue ‘B’ can be traced back to the fix for issue ‘A’ then ‘A causes B’ (or ‘B is caused by A’) <div class="note"> Note: If during your investigation of the bug you determine that the issue is in the wrong component, make sure to move it back to the New state before moving it to the new component, so that it will be picked up by the component’s triage team. Make sure there is a comment outlining the reason for the move, as explained above. </div> <h2 id="resolving-or-closing-an-issue">Resolving or Closing an issue</h2> Once the work on an issue has been completed the issue’s Status should be in a “completed” state. There are two “completed” states: Resolved and Closed. These are accompanied by a Resolution and a Fix Version/s. Which combination of Status, Resolution, and Fix Version/s you should use depends on how the issue is completed. Most resolutions are used to close an issue so that it ends up being Closed directly, but resolutions that indicates that a change has been integrated into a Project repository must go through the Resolved state. An issue in Resolved state needs to go through <a href="#verifying-an-issue">verification</a> to end up as Closed. For the JDK Project in almost all cases the bots will transition the issue to Resolved/Fixed when the changeset is integrated to the repository. The Fix Version/s field should indicate when an issue was fixed. The most common value for this field is a JDK version number. There are some special values available for this field in JBS, these should only be used for special cases as outlined in this Guide. <div class="note"> Note: An issue should never be closed if it has open sub-tasks. </div> <table> <colgroup> <col width="14%" /> <col width="85%" /></colgroup> <thead> <tr class="header"> <th align="left">Status Resolution</th> <th align="left">Covers</th> </tr> </thead> <tbody> <tr class="odd"> <td align="left">Resolved/Closed Fixed</td> <td align="left">The resolution Fixed should be used only if a change has been integrated in a Project repository to address the issue, and the Fix Version/s must always correspond to the version where the change was integrated, or be one of the repo-* fix versions or internal. If there isn’t a fix in the repository (and so no associated changeset) then the issue should not be marked as Fixed.</td> </tr> <tr class="even"> <td align="left">Closed Won’t Fix</td> <td align="left">Used when the issue is describing behavior which, while maybe problematic or not ideal, isn’t going to be changed - for compatibility reasons for example.</td> </tr> <tr class="odd"> <td align="left">Closed Duplicate</td> <td align="left">Used to indicate that the same issue is described in another JBS issue. See <a href="#closing-issues-as-duplicates">Closing issues as duplicates</a> for more information.</td> </tr> <tr class="even"> <td align="left">Resolved/Closed Incomplete</td> <td align="left">Used to indicate that the JBS issue doesn’t contain enough information to work on the issue. See <a href="#closing-incomplete-issues">Closing incomplete issues</a> for more information.</td> </tr> <tr class="odd"> <td align="left">Closed Cannot Reproduce</td> <td align="left">Use when a reproducer is provided (or clear steps) but it’s not possible to see the faulty behavior. When you can’t reproduce an issue, where feasible try on the release the issue was reported against as a way of confirming that it’s indeed addressed on the latest release, rather than you not having the right environment in which to reproduce the issue.</td> </tr> <tr class="even"> <td align="left">Closed Other</td> <td align="left">Used in rare cases where none of the other statuses fit the situation.</td> </tr> <tr class="odd"> <td align="left">Closed External</td> <td align="left">Use where the issue is due to a problem in a Java library (not part of the OpenJDK code base), an IDE or other external tool etc. Where known, it’s good to provide a link to the site where the issue should be reported.</td> </tr> <tr class="even"> <td align="left">Closed Not an Issue</td> <td align="left">Use when the behavior is expected and valid (cf. Won’t Fix) and the reporter perhaps has misunderstood what the behavior should be.</td> </tr> <tr class="odd"> <td align="left">Closed Migrated</td> <td align="left">Used rarely, but can be seen when issues are transferred into another project by opening up a separate issue in that project, with the issue in the original project being Closed.</td> </tr> <tr class="even"> <td align="left">Resolved/Closed Delivered</td> <td align="left">Used to close out issues where a change to the code isn’t required, common examples are Tasks, Release Notes, and umbrella issues for larger changes. Note that the verification step is always needed to move an issue from Resolved to Closed. If your issue doesn’t need verification (e.g. it’s an umbrella where each sub-task is verified as a separate fix) then please move the issue directly to Closed without going through Resolved.</td> </tr> <tr class="odd"> <td align="left">Closed Withdrawn</td> <td align="left">Withdrawn is essentially the partner state to Delivered for issues that would not have resulted in a fix to the repo, and also part of the <a href="https://wiki.openjdk.org/display/csr/Main">CSR</a> and <a href="#release-notes">Release Note</a> process.</td> </tr> <tr class="even"> <td align="left">Closed Approved</td> <td align="left">Used as part of the <a href="https://wiki.openjdk.org/display/csr/Main">CSR process</a>.</td> </tr> <tr class="odd"> <td align="left">Challenge States</td> <td align="left">Exclude [Challenge], Alternative Tests [Challenge], and Reject [Challenge] are only relevant within the context of the JCK Project.</td> </tr> <tr class="even"> <td align="left">Future Project</td> <td align="left">This status is not recommended for use.</td> </tr> <tr class="odd"> <td align="left">Rejected</td> <td align="left">This status should not be used.</td> </tr> </tbody> </table> <div class="note"> When an issue is closed as Won’t Fix, do not remove the Fix Version/s. It’s valuable information to know what version it was decided not to fix an issue in. The same goes for resolutions such as Duplicate, Cannot Reproduce and Not an Issue. </div> <div class="note"> The fix version na should only be used on backport issues that is created by mistake. See <a href="#how-to-fix-an-incorrect-backport-creation-in-jbs">How to fix an incorrect backport creation in JBS</a>. </div> <h3 id="closing-issues-as-duplicates">Closing issues as duplicates</h3> If the same issue is described in another JBS issue then close one against the other as Closed/Duplicate. In general the newer issue is closed as a Duplicate of the older one, but where the newer issue has a clearer description, or more useful, up-to-date comments then doing it the other way round is ok as long as none of them has been Fixed already. If one of the issues has been Fixed the other one should be closed as a Duplicate of the Fixed issue. There may be other reasons to choose to close one or the other issue as the Duplicate. As always - use your best judgement to make the end result as good as possible. <div class="note"> Any issue closed as a Duplicate must have a “Duplicates” link to the duplicating issue. </div> <div class="note"> Be mindful of labels on issues closed as Duplicate. Some labels need to be copied over to the duplicating issue, see for instance the <a href="#tck-red-rel">tck-red-(Rel)</a> label. </div> <h3 id="closing-issues-without-knowing-what-fixed-it">Closing issues without knowing what fixed it</h3> If it’s determined that an issue has been fixed, but it’s unknown what change that fixed it, closing as Fixed is not an option as this requires a changeset in a project repository. Duplicate is also not an option since this requires a duplicate-link to the issue that fixed it. A common way to handle such cases is to close the issue as Delivered with the Fix version/s set to unknown. Closing an issue as Cannot Reproduce has also been common practice but is no longer recommended if it’s known that the issue has actually been fixed. <h3 id="closing-incomplete-issues">Closing incomplete issues</h3> As mentioned above, issues that lack the information needed to investigate the problem are placed in status Resolved - Incomplete. Triage teams should monitor incomplete issues in their area and if needed ping the relevant person. If the required information hasn’t been obtained within reasonable time (3-4 weeks) the bug should be closed as Incomplete. <h2 id="verifying-an-issue">Verifying an issue</h2> Once an issue is marked as resolved there is now the option of someone, other than the person that fixed it, of marking it as Verified to confirm that the issue is fixed after testing; marking it as Fix Failed if it didn’t solve the issue; or, Not Verified to indicate that it wasn’t explicitly tested. Note that the JBS UI doesn’t highlight when Fix Failed has been set, you need to look for the Verification field at the bottom of the left-hand column in the Details section. <h2 id="removing-an-issue">Removing an issue</h2> Removing a JBS issue is a rare extreme case that shouldn’t be part of the normal workflow. For this reason, removing issues is restricted to admins only. If you for some reason need to remove an issue, send an email to <a href="mailto:ops@openjdk.org">ops@openjdk.org</a>. You need to provide the bug id and a well considered reason the issue should be removed. Note that JBS issues are not removed just because something was a bad idea, or a reported issue turned out to be an embarrassing user mistake. Such issues are simply closed. <h2 id="jbs-labels">JBS labels</h2> JBS labels are used to tag and group related issues. JBS labels are an open namespace, which means that anyone can create new labels at any time. In order to avoid confusion, however, it’s best to reuse existing labels where possible. Most areas have their commonly used labels to identify issues in their respective area. Make an effort to find and use these labels. This can be done by editing the Labels field of a bug and entering the first few characters of the label you want to add. JIRA will pop up an autocomplete window with existing labels that match that prefix. Then choose one of the existing labels. Using the autocomplete window is preferable to typing the whole label name (even if you’re a good typist) because it’s easy for minor spelling errors to creep in, which can inadvertently introduce multiple labels with spurious spelling variations. JBS labels should not be used to write documentation - don’t try to write sentences using labels. Adding a number of random labels is unlikely to be helpful to anyone. <div class="note"> Labels are case sensitive When using labels in Jira gadgets (like pie charts, heat maps, and statistics tables) Jira will be case-sensitive and treat e.g. OpenJDK and openjdk as two different labels. Searching however is case-insensitive. This means that if you group a set of issues in a gadget based on a label, and then click one of the groups to see the list of issues, that list will contain more results than the gadget if there are usages of the label with different casing. This can be very confusing and for this reason the recommendation is to stick with the commonly used case for all labels, regardless of your personal taste for upper or lower case letters. Most labels are lower case only, but there are examples where upper case letters are used in the most common version of a label. Use of the autocomplete popup window (described above) when adding labels will avoid inadvertent introduction of labels with differing case. </div> <h2 id="jbs-label-dictionary">JBS label dictionary</h2> This table contains some frequently used JBS labels and their meaning. Please help keeping this dictionary up to date by adding your favorite labels. This table doesn’t dictate how to use labels, but rather document how they are used. That said, obviously it will help everyone if we try to follow a common standard and use similar labels in the same way across all entities that use JBS. <table class="dictionary" summary="JBS Label Dictionary"> <tr style="text-align:left;"> <th>Label</th> <th>Description</th> </tr> <tr> <td class="dictionary">(Area)-interest</td> <td class="dictionary">Used to indicate that an area (usually a team or <a href="https://openjdk.org/bylaws#project">Project</a>) is interested in the issue. This label doesn’t indicate ownership of the issue. E.g., redhat-interest, azul-interest, coin-interest</td> </tr> <tr> <td class="dictionary">(Area)-related</td> <td class="dictionary">Used to indicate that an issue is related to a specific area (usually a feature or <a href="https://openjdk.org/bylaws#project">Project</a>). This label doesn’t indicate ownership of the issue. E.g., graal-related, testcolo-related, doc-related</td> </tr> <tr> <td class="dictionary">(Rel)-bp</td> <td class="dictionary">Used to indicate that a bug would be suitable for backport to a release (Rel). This isn’t a decision to backport, just a suggestion / recommendation. E.g., 11-bp</td> </tr> <tr> <td class="dictionary">(Rel)-critical-request (Rel)-critical-approved (Rel)-critical-watch</td> <td class="dictionary"> Used in the ramp down phases of specific releases to request approval of changes that requires Project lead approval (or similar) to be included. (Rel) is the release in question. E.g., jdk11-critical-request (Rel)-critical-approved is used to signal that the change has been approved for inclusion. E.g., jdk11-critical-approved (Rel)-critical-watch is used for issues that must get into a specific release but risk running late. The label is used while the issue is still in progress and is replaced with (Rel)-critical-request once the issue is resolved. E.g., jdk11-critical-watch These labels are always placed on the main JBS issue, never on backports or subtasks.</td> </tr> <tr> <td class="dictionary">(Rel)-defer-request (Rel)-defer-yes (Rel)-defer-no</td> <td class="dictionary"> Used to request deferral of changes that requires Project lead approval (or similar) to defer. (Rel) is the release in question. E.g., jdk12-defer-request (Rel)-defer-yes and (Rel)-defer-no are used to indicate wether the deferral has been approved or not. E.g., jdk12-defer-yes These labels are always placed on the main JBS issue, never on backports or subtasks. Further details are found in the <a href="https://openjdk.org/jeps/3#Bug-Deferral-Process">JDK Release Process</a>.</td> </tr> <tr> <td class="dictionary">(Rel)-enhancement-request (Rel)-enhancement-yes (Rel)-enhancement-no</td> <td class="dictionary"> Used in the ramp down phases to request the late inclusion of an enhancement. (Rel) is the release in question. E.g., jdk10-enhancement-request (Rel)-enhancement-yes and (Rel)-enhancement-no are used to indicate the response on the request. E.g., jdk10-enhancement-yes, jdk10-enhancement-no These labels are always placed on the main JBS issue, never on backports or subtasks. Further details are found in the <a href="https://openjdk.org/jeps/3#Late-Enhancement-Request-Process">JDK Release Process</a>.</td> </tr> <tr> <td class="dictionary">(Rel)-fix-request (Rel)-fix-SQE-ok (Rel)-fix-yes (Rel)-fix-no</td> <td class="dictionary"> Used in ramp down phase 2 to indicate that an issue would be of interest to get integrated into release (Rel). E.g., jdk12u-fix-request (Rel)-fix-SQE-ok is used to indicate that the issue will be covered by the test plan for (Rel). E.g., jdk12u-fix-SQE-ok (Rel)-fix-yes and (Rel)-fix-no are used to indicate wether an issue has been approved for backport to (Rel). E.g., jdk12u-fix-yes These labels are always placed on the main JBS issue, never on backports or subtasks. Further details are found in the <a href="https://openjdk.org/jeps/3#Fix-Request-Process">JDK Release Process</a>.</td> </tr> <tr> <td class="dictionary">(Rel)-na</td> <td class="dictionary"> Labels of the form 11-na or 21-na should be used when a bug is not applicable to a more recent release family. See <a href="#usage-of-the-rel-na-label">Usage of the (Rel)-na Label</a>. (Rel) can also refer to more general release atrifacts like oraclejdk-na, openjdk-na, and sap-aix-na to indicate that the issue doesn’t affect code included in that specific atrifact.</td> </tr> <tr> <td class="dictionary">(Rel)-wnf</td> <td class="dictionary"> Labels of the form 11-wnf or 21-wnf should be used to indicate that a bug is not going to be fixed in a release where it’s present. Note that there should only be one (Rel)-wnf label on any JBS issue. It is implied that earlier versions will not be fixed either. Also see <a href="#usage-of-the-rel-wnf-label">Usage of the (Rel)-wnf Label</a>.</td> </tr> <tr> <td class="dictionary">(Team)-triage-(Rel)</td> <td class="dictionary"> Used to indicate that (Team) has triaged this issue for release (Rel). It’s encouraged that all open bugs are triaged on a regular basis so that old bugs aren’t forgotten. It’s therefore common to see several triage labels on the same issue which helps keeping track of which bugs have been triaged for each release. E.g., oracle-triage-13 There are many label variants that include the word triage in some form. The form described above is the only one recommended. Please refrain from using other forms.</td> </tr> <tr> <td class="dictionary">aot</td> <td class="dictionary">Used to identify issues in the JVM feature Ahead of Time Compilation.</td> </tr> <tr> <td class="dictionary"><del>appcds</del></td> <td class="dictionary">Deprecated. Was used to identify issues in Application Class-Data Sharing. The cds label is now used instead.</td> </tr> <tr> <td class="dictionary">c1</td> <td class="dictionary">Used to identify issues in the JVM JIT compiler C1.</td> </tr> <tr> <td class="dictionary">c2 c2-<code>.*</code></td> <td class="dictionary"> Used to identify issues in the JVM JIT compiler C2. c2-<code>.*</code> labels are used to identify different C2 features. E.g., c2-intrinsic, c2-loopopts</td> </tr> <tr> <td class="dictionary">cds</td> <td class="dictionary">Used to identify issues in the JVM feature Class Data Sharing.</td> </tr> <tr> <td class="dictionary">cleanup</td> <td class="dictionary">The cleanup label is used to indicate enhancements which has no semantic changes, whose only purpose is to make the code more maintainable or better looking.</td> </tr> <tr> <td class="dictionary">compilercontrol</td> <td class="dictionary">Used to identify issues in the JVM Compiler Control feature.</td> </tr> <tr> <td class="dictionary">conformance</td> <td class="dictionary">Used to identify all TCK related conformance issues.</td> </tr> <tr> <td class="dictionary">docker</td> <td class="dictionary">Used to identify issues in docker support.</td> </tr> <tr> <td class="dictionary">footprint</td> <td class="dictionary">Used to identify issues affecting Java SE footprint. Issues with this label should also have a performance label.</td> </tr> <tr> <td class="dictionary">gc-<code>.*</code></td> <td class="dictionary"> Used to identify issues in specific garbage collectors in the JVM. E.g., gc-g1, gc-shenandoah, gc-serial, gc-epsilon There are also labels in use to identify different GC features or areas rather than GC algorithms. E.g., gc-g1-fullgc, gc-largeheap, gc-performance Note that ZGC breaks this pattern and use the label zgc.</td> </tr> <tr> <td class="dictionary">graal</td> <td class="dictionary">Used to indicate that this is a Graal issue. (Something that needs to be fixed in Graal rather than in the JDK.)</td> </tr> <tr> <td class="dictionary">graal-integration</td> <td class="dictionary">Reserved for Graal integration umbrella bugs. The automated integration script will break if this label is used for other bugs.</td> </tr> <tr> <td class="dictionary">hgupdate-sync</td> <td class="dictionary">Used to identify backport issues created as part of automatic syncing between releases.</td> </tr> <tr> <td class="dictionary"><del>hs-nightly</del></td> <td class="dictionary">Deprecated. Was used to tag bugs found in the HotSpot nightly testing. Since we are now running tiered testing there is no more nightly HotSpot testing. See tier<code>[1-8]</code>.</td> </tr> <tr> <td class="dictionary">hs-sbr</td> <td class="dictionary">Used to identify issues that are found in the “same binary runs”, a stress testing method used to find intermittent failures.</td> </tr> <tr> <td class="dictionary"><del>hs-tier<code>[1-8]</code></del></td> <td class="dictionary">Deprecated. Was used to identify which HotSpot tier a test failure was seen in. We don’t separate HotSpot tiers from the JDK tiers anymore. See tier<code>[1-8]</code>.</td> </tr> <tr> <td class="dictionary">i18n</td> <td class="dictionary">Used to identify issues in internationalization. i18n is short for internationalization meaning “i 18 letters and an n”. Used for bugs whose impact varies depending on a user’s writing system, language, or locale, but aren’t just a matter of locale data. The label isn’t needed for classes_text, classes_util_i18n, classes_awt_im, classes_fontprop, or char_encodings.</td> </tr> <tr> <td class="dictionary">integration-blocker</td> <td class="dictionary">Used to indicate that a bug is present in a downstream repository but not present in the upstream repository and is therefore blocking integration of downstream changes into upstream.</td> </tr> <tr> <td class="dictionary">intermittent intermittent-environment intermittent-hardware</td> <td class="dictionary"> An intermittent issue is one that fails sometimes but not always. The exact reason for the intermittent failure is per definition unknown. Once the reason has been identified the issue is no more considered intermittent. An issue isn’t intermittent if some characteristics has been found that triggers the failure consistently, even if the actual cause for the failure hasn’t been found. For instance if a test fails every time it’s executed on a specific host but not on other hosts it wouldn’t be considered intermittent as it fails consistently on that specific host. In other cases it may be that we know that a test sometimes is unlucky in some respect and fails due to this. This test could still be considered intermittent even though we know what the reason is if the reason itself appears intermittently. Some issues may seem intermittent when looking at test results, even though the reason for failing is actually known. One example is where a test fails consistently on a specific host, or due to specific conditions in the environment. These failures shouldn’t be considered intermittent but it may still be valuable to tag these in JBS with one of the labels intermittent-hardware or intermittent-environment. This will help to faster identify that the cause of the failure is known without having to read through the entire bug. A test that should be platform agnostic but is consistently failing on a specific OS would for instance be labeled with intermittent-environment, while a test that fails every time it’s run on some specific hardware would be labeled with intermittent-hardware.</td> </tr> <tr> <td class="dictionary">jep-superseded</td> <td class="dictionary">Used to tag JEPs that have been superseded by a newer version of the JEP.</td> </tr> <tr> <td class="dictionary">jvmci</td> <td class="dictionary">Used to identify issues in the JVM Compiler Interface.</td> </tr> <tr> <td class="dictionary">maintainer-pain</td> <td class="dictionary"> Used to tag bugs that for some reason is wasting time or in other ways are causing pain for the OpenJDK maintainers. Examples of issues that could be considered a pain: <ul> <li> A bug that occurs frequently in testing, maybe on a specific platform, maybe specific to one vendor’s test infrastructure, and requires that many maintainers investigate the failure in different test runs just to realize it’s the same issue as has been seen and reported before, or worse, don’t realize it’s a known issue and file a duplicate bug in JBS. </li> <li> Bugs that cause tests to fail without a proper explanation causing several maintainers to investigate the failures just to realize there is no information to be found. </li> <li> An underlying bug that causes several tests to fail intermittently. </li> <li> A bug that causes a test failure in a faraway place and the failure isn’t acted on quickly. </li> </ul> There are other cases as well and there is some flexibility in the definition. If you see a problem that is causing pain for a large number of maintainers, add an explanation in the JBS issue to why you think the issue is a pain and add the label. If you have a maintainer-pain bug assigned to you please consider fixing it asap. If you chose not to work on the issue, you should at least be aware that you are choosing to waste others’ time and people will be affected by this choice. As with any issue the best way to deal with a maintainer-pain issue is to fix it. Another way to reduce the noise is to <a href="#excluding-a-test">exclude the failing test</a>. This is a viable option if there is a limited set of tests that are failing and the bug is actively investigated. When excluding a maintainer-pain issue, remember to move the maintainer-pain label to the JBS issue used to exclude. Leaving the label on the closed exclude-issue is helpful for tracking purposes.</td> </tr> <tr> <td class="dictionary">noreg-<code>.*</code> nounit-<code>.*</code></td> <td class="dictionary"> The noreg-<code>.*</code> and nounit-<code>.*</code> labels are used to explain why a bugfix doesn’t need/have a regression test or a unit test. The suffix of the label is described below. Please note that the noreg- namespace is closed, meaning that no new noreg- labels should be added unless properly motivated, discussed, and agreed upon. <dl> <dt>-sqe</dt> <dd>Change can be verified by running an existing SQE test suite; the bug should identify the suite and the specific test case(s).</dd> <dt>-jck</dt> <dd>Change can be verified by running the JCK; the bug should identify the specific test case(s).</dd> <dt>-external</dt> <dd>Change can be verified by running an existing external test suite; the bug should identify the suite and the specific test case(s).</dd> <dt>-doc</dt> <dd>Change only affects documentation.</dd> <dt>-demo</dt> <dd>Change only affects demo code.</dd> <dt>-build</dt> <dd>Change only affects build infrastructure (makefiles, copyrights, scripts, etc.).</dd> <dt>-self</dt> <dd>Change is a fix to a regression or unit test itself.</dd> <dt>-perf</dt> <dd>Change is for a performance bug for which writing a regression test is infeasible; the bug should describe how to verify the fix.</dd> <dt>-hard</dt> <dd>It’s too hard to write a regression or unit test for this bug (e.g., theoretical race condition, complex setup, reboot required, editing of installed files required, specific graphics card required); the bug should explain why.</dd> <dt>-long</dt> <dd>Testing requires a very long running-time (e.g., more than a few minutes).</dd> <dt>-big</dt> <dd>Testing requires an unreasonable quantity of resources (e.g., tens of gigabytes of filesystem space).</dd> <dt>-trivial</dt> <dd>Change is so trivial that nothing could possibly go wrong with it.</dd> <dt>-cleanup</dt> <dd>Change is a cleanup or refactoring of existing code that is covered by existing tests.</dd> <dt>-l10n</dt> <dd>Change only affects localized text.</dd> <dt>-undo</dt> <dd>Change is a reversion of a previous faulty change.</dd> <dt>-other</dt> <dd>Regression or unit test is unnecessary or infeasible for some other reason; the bug report should explain why.</dd> </dl> Examples: If a bug fix only corrects a change in the build system, then add the noreg-build label to the corresponding bug. If the change improves loop optimizations in HotSpot, then add nounit-perf to the corresponding bug.</td> </tr> <tr> <td class="dictionary">performance</td> <td class="dictionary">Used to identify an issue with noticeable performance impact. Either positive or negative.</td> </tr> <tr> <td class="dictionary"><del>pit</del></td> <td class="dictionary">Deprecated. Was used to indicate that a failure happened in product integration testing (PIT). Since we are now running tiered testing there is no more PIT. See tier<code>[1-8]</code>.</td> </tr> <tr> <td class="dictionary">problemlist</td> <td class="dictionary">One or more tests has been problem-listed due to this bug.</td> </tr> <tr> <td class="dictionary">regression</td> <td class="dictionary">Used to identify regressions. A regression is where behavior has incorrectly changed from a previous build or release. Ideally all regressions are identified and fixed before they are released, if not they must be fixed at latest in the following release after they are identified. All regressions must have the Affects Version/s set.</td> </tr> <tr> <td class="dictionary">regression_(ID)</td> <td class="dictionary">Used to identify the fix that caused the regression, where known.</td> </tr> <tr> <td class="dictionary">release-note</td> <td class="dictionary">Used to indicate that the issue is a release note. See <a href="#release-notes">Release Notes</a>.</td> </tr> <tr> <td class="dictionary">release-note=yes release-note=no <del>release-note=done</del></td> <td class="dictionary"> Used to indicate whether a change requires a release note or not. The labels are always placed on the main JBS issue, never on the actual release note issue. See <a href="#release-notes">Release Notes</a>. release-note=done is deprecated and should no longer be used.</td> </tr> <tr> <td class="dictionary">RN-<code>.*</code></td> <td class="dictionary">Used to indicate what kind of change the release note is for. See <a href="#release-notes">Release Notes</a>.</td> </tr> <tr> <td class="dictionary">starter</td> <td class="dictionary">A starter bug is a well contained, small issue that is suitable for someone new to the codebase.</td> </tr> <tr> <td class="dictionary">startup</td> <td class="dictionary">Used to identify an issue as affecting Java SE startup performance. Issues with this label should also have a performance label.</td> </tr> <tr> <td class="dictionary">tck-red-(Rel) <del>tck-red</del></td> <td class="dictionary"> Used to identify TCK conformance stoppers (e.g. failure of a valid TCK test that exists in a shipped TCK). The release number indicates which release of the TCK that failed. E.g., tck-red-11 If an issue with a tck-red-(Rel) label is closed as a Duplicate, the label must be added to the duplicating issue as well. There are tck-red labels without the release number out there as well. This usage is deprecated.</td> </tr> <tr> <td class="dictionary"><del>test</del> <del>test-only</del> <del>testbug</del></td> <td class="dictionary">The labels test, test-only, and testbug are deprecated and should no longer be used. Use <a href="#noreg">noreg-self</a> to indicate that an issue is a bug in test code.</td> </tr> <tr> <td class="dictionary">tier<code>[1-8]</code></td> <td class="dictionary"> Used to indicate which tier in the <code>jdk/jdk</code> CI pipeline a test failure has been seen in. Lower tiers would in general mean higher urgency to fix the issue. E.g., tier1, tier2 Please note that these labels are reserved for bugs seen in the <code>jdk/jdk</code> CI pipeline. Use (Rel)-tier<code>[1-8]</code> for other CI pipelines, where (Rel) is the name of the pipeline. E.g. 8u-tier1</td> </tr> <tr> <td class="dictionary">webbug</td> <td class="dictionary">Used to identify a bug as submitted on <a href="https://bugs.java.com/bugdatabase/">bugs.java.com</a>.</td> </tr> <tr> <td class="dictionary">zgc</td> <td class="dictionary">Used to identify an issue in ZGC.</td> </tr> </table> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="cloning-the-jdk">Cloning the JDK</h1> <div class="box"> Quick Links <ul> <li><a href="https://github.com/openjdk/jdk">OpenJDK Mainline GitHub project</a></li> <li><a href="https://wiki.openjdk.org/display/SKARA">Skara Documentation</a></li> </ul> </div> After the initial release of the JDK source code into OpenJDK in 2007 the OpenJDK project moved from TeamWare to using Mercurial. Starting in 2019 the source revision control has been moved to Git. The complete source code for the JDK is today hosted at <a href="https://github.com">GitHub</a>. You can browse the code directly in the <a href="https://github.com/openjdk/jdk">openjdk/jdk repository</a>, or download the code for offline browsing, editing, and building using <code>git clone</code>. <pre><code>$ git clone https://github.com/openjdk/jdk.git</code></pre> <code>openjdk/jdk</code> is the mainline JDK development repository where the next major release of the JDK is being developed. Other <a href="https://openjdk.org/bylaws#project">Projects</a> have their own repositories on <a href="https://github.com/openjdk">GitHub</a>. <div class="note"> Note that source may be available from other locations, for example <code>src.zip</code> from a full JDK distribution. However, OpenJDK contributions must use source from the appropriate <a href="https://github.com/openjdk">OpenJDK GitHub repository</a> since other source distributions may contain older code or code which differs due to licensing. Consult the Project’s documentation or <a href="#mailing-lists">mailing lists</a> to determine the appropriate repository, development conventions, and helpful tools. </div> If you intend to contribute patches, you should first fork the repository on <a href="https://github.com">GitHub</a> and clone your own personal fork as shown below. To fork a <a href="https://openjdk.org/bylaws#project">Project</a> on <a href="https://github.com">GitHub</a>, go to the GitHub Project page and click the ‘Fork’ button in the upper right corner, then follow the on screen instructions. This is the typical development model: <div style="text-align:center;"> <div class="figure"><img src="data:image/svg+xml;base64,<svg id="mermaid-1738190654914" width="100%" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="318.5" style="max-width: 209.758px; background-color: white;" viewBox="0 0 209.7578125 318.5"><style>#mermaid-1738190654914 {font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;fill:#000000;}#mermaid-1738190654914 .error-icon{fill:#552222;}#mermaid-1738190654914 .error-text{fill:#552222;stroke:#552222;}#mermaid-1738190654914 .edge-thickness-normal{stroke-width:2px;}#mermaid-1738190654914 .edge-thickness-thick{stroke-width:3.5px;}#mermaid-1738190654914 .edge-pattern-solid{stroke-dasharray:0;}#mermaid-1738190654914 .edge-pattern-dashed{stroke-dasharray:3;}#mermaid-1738190654914 .edge-pattern-dotted{stroke-dasharray:2;}#mermaid-1738190654914 .marker{fill:#666;stroke:#666;}#mermaid-1738190654914 .marker.cross{stroke:#666;}#mermaid-1738190654914 svg{font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;}#mermaid-1738190654914 .label{font-family:"trebuchet ms",verdana,arial,sans-serif;color:#000000;}#mermaid-1738190654914 .cluster-label text{fill:#333;}#mermaid-1738190654914 .cluster-label span{color:#333;}#mermaid-1738190654914 .label text,#mermaid-1738190654914 span{fill:#000000;color:#000000;}#mermaid-1738190654914 .node rect,#mermaid-1738190654914 .node circle,#mermaid-1738190654914 .node ellipse,#mermaid-1738190654914 .node polygon,#mermaid-1738190654914 .node path{fill:#eee;stroke:#999;stroke-width:1px;}#mermaid-1738190654914 .node .label{text-align:center;}#mermaid-1738190654914 .node.clickable{cursor:pointer;}#mermaid-1738190654914 .arrowheadPath{fill:#333333;}#mermaid-1738190654914 .edgePath .path{stroke:#666;stroke-width:2.0px;}#mermaid-1738190654914 .flowchart-link{stroke:#666;fill:none;}#mermaid-1738190654914 .edgeLabel{background-color:white;text-align:center;}#mermaid-1738190654914 .edgeLabel rect{opacity:0.5;background-color:white;fill:white;}#mermaid-1738190654914 .cluster rect{fill:hsl(0, 0%, 98.9215686275%);stroke:#707070;stroke-width:1px;}#mermaid-1738190654914 .cluster text{fill:#333;}#mermaid-1738190654914 .cluster span{color:#333;}#mermaid-1738190654914 div.mermaidTooltip{position:absolute;text-align:center;max-width:200px;padding:2px;font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:12px;background:hsl(-160, 0%, 93.3333333333%);border:1px solid #707070;border-radius:2px;pointer-events:none;z-index:100;}#mermaid-1738190654914 :root{--mermaid-font-family:"trebuchet ms",verdana,arial,sans-serif;}</style><g><g class="output"><g class="clusters"><g class="cluster" id="flowchart-GitHub-20" transform="translate(104.87890625,105.75)" style="opacity: 1;"><rect width="193.7578125" height="195.5" x="-96.87890625" y="-97.75"></rect><g class="label" transform="translate(0, -83.75)" id="mermaid-1738190654914Text"><g transform="translate(-24.92578125,-9.25)"><foreignObject width="49.8515625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">GitHub</div></foreignObject></g></g></g></g><g class="edgePaths"><g class="edgePath LS-upstream LE-fork" id="L-upstream-fork" style="opacity: 1;"><path class="path" d="M93.63755841121495,71.5L90.30408513434581,77.20833333333333C86.97061185747664,82.91666666666667,80.30366530373833,94.33333333333333,80.30366530373833,105.75C80.30366530373833,117.16666666666667,86.97061185747664,128.58333333333334,90.30408513434578,134.29166666666666L93.63755841121495,140" marker-end="url(#arrowhead38)" style="fill:none"></path><defs><marker id="arrowhead38" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g><g class="edgePath LS-fork LE-local" id="L-fork-local" style="opacity: 1;"><path class="path" d="M92.50694076624293,178.5L89.8290261593691,182.66666666666666C87.1511115524953,186.83333333333334,81.79528233874764,195.16666666666666,79.11736773187381,205.04166666666666C76.439453125,214.91666666666666,76.439453125,226.33333333333334,79.47388075593848,237.75C82.50830838687695,249.16666666666666,88.57716364875391,260.5833333333333,91.61159127969238,266.2916666666667L94.64601891063084,272" marker-end="url(#arrowhead39)" style="fill:none"></path><defs><marker id="arrowhead39" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g><g class="edgePath LS-local LE-fork" id="L-local-fork" style="opacity: 1;"><path class="path" d="M118.70992443049066,272L122.81133025457554,266.2916666666667C126.91273607866044,260.5833333333333,135.11554772683021,249.16666666666666,139.21695355091512,237.75C143.318359375,226.33333333333334,143.318359375,214.91666666666666,139.6988251824388,205.04166666666666C136.0792909898776,195.16666666666666,128.84022260475518,186.83333333333334,125.22068841219398,182.66666666666666L121.60115421963278,178.5" marker-end="url(#arrowhead40)" style="fill:none"></path><defs><marker id="arrowhead40" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g><g class="edgePath LS-fork LE-upstream" id="L-fork-upstream" style="opacity: 1;"><path class="path" d="M117.06968275408879,140L120.68469656590732,134.29166666666666C124.29971037772584,128.58333333333334,131.52973800136292,117.16666666666667,131.52973800136294,105.75C131.52973800136292,94.33333333333333,124.29971037772584,82.91666666666667,120.68469656590732,77.20833333333333L117.06968275408879,71.5" marker-end="url(#arrowhead41)" style="fill:none"></path><defs><marker id="arrowhead41" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g></g><g class="edgeLabels"><g class="edgeLabel" transform="translate(73.63671875,105.75)" style="opacity: 1;"><g transform="translate(-14.39453125,-9.25)" class="label"><rect rx="0" ry="0" width="28.7890625" height="18.5"></rect><foreignObject width="28.7890625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-upstream-fork" class="edgeLabel L-LS-upstream' L-LE-fork">fork</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(76.439453125,237.75)" style="opacity: 1;"><g transform="translate(-19.34765625,-9.25)" class="label"><rect rx="0" ry="0" width="38.6953125" height="18.5"></rect><foreignObject width="38.6953125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-fork-local" class="edgeLabel L-LS-fork' L-LE-local">clone</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(143.318359375,237.75)" style="opacity: 1;"><g transform="translate(-16.4375,-9.25)" class="label"><rect rx="0" ry="0" width="32.875" height="18.5"></rect><foreignObject width="32.875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-local-fork" class="edgeLabel L-LS-local' L-LE-fork">push</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(138.759765625,105.75)" style="opacity: 1;"><g transform="translate(-9.1171875,-9.25)" class="label"><rect rx="0" ry="0" width="18.234375" height="18.5"></rect><foreignObject width="18.234375" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-fork-upstream" class="edgeLabel L-LS-fork' L-LE-upstream">PR</span></div></foreignObject></g></g></g><g class="nodes"><g class="node default" id="flowchart-upstream-10" transform="translate(104.87890625,52.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-54.53125" y="-19.25" width="109.0625" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-44.53125,-9.25)"><foreignObject width="89.0625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">openjdk/jdk</div></foreignObject></g></g></g><g class="node default" id="flowchart-fork-11" transform="translate(104.87890625,159.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-61.87890625" y="-19.25" width="123.7578125" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-51.87890625,-9.25)"><foreignObject width="103.7578125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">OpenDuke/jdk</div></foreignObject></g></g></g><g class="node default" id="flowchart-local-15" transform="translate(104.87890625,291.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-27.17578125" y="-19.25" width="54.3515625" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-17.17578125,-9.25)"><foreignObject width="34.3515625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">local</div></foreignObject></g></g></g></g></g></g></svg>" alt="" /> Diagram of upstream repos and user's clone </div> </div> Pushes to your personal fork can be made either using HTTPS or SSH. These examples assume you have an SSH key installed on <a href="https://github.com">GitHub</a>. If this is the first time you clone your personal fork of an OpenJDK repository you may want to create an SSH key to use with it. See <a href="#generating-an-ssh-key">Generating an SSH key</a> below. Once you have your personal fork and an SSH key to go with it, go ahead and clone. <pre><code>$ git clone git@github.com:OpenDuke/jdk.git $ cd jdk $ git remote add upstream https://github.com/openjdk/jdk.git</code></pre> In the example above Duke cloned his personal fork of the JDK mainline repository using SSH. You should of course use your own <a href="https://github.com">GitHub</a> username instead. Then, by adding a new remote named ‘upstream’, the clone is associated with <a href="https://github.com/openjdk/jdk">openjdk/jdk</a>. Doing this will allow the tooling to automatically create a PR on <a href="https://github.com/openjdk/jdk">openjdk/jdk</a> whenever a change is pushed to the personal fork. The way that works is that once the change has been pushed to the personal fork, and you navigate to the <a href="https://github.com/openjdk/jdk">openjdk/jdk</a> repository on <a href="https://github.com">GitHub</a>, there will be a message saying that you just pushed a change and asking if you want to create a PR. <h2 id="working-with-git-branches">Working with git branches</h2> It is strongly recommended to always create a new branch for any change you intend to implement. If your PR gets accepted, it will be squashed and pushed by the OpenJDK bots. This means that if you make changes to your <code>master</code> branch, it will diverge from the upstream <code>master</code> branch. This in turn means that your repo will forever be out of sync with the upstream repo, which will cause merge conflicts every single time you want to update your repo from upstream. Having a separate branch for each change also means that you can easily work on many different changes in parallel in the same code repository. Unless you know what you are doing, the recommendation is also to always base your new branch on the <code>master</code> branch. <pre><code>$ git switch -c JDK-8272373 master</code></pre> Here we create a new branch called <code>JDK-8272373</code> based on the <code>master</code> branch and set the repository up to work in that new branch. If you intend to work on a backport to a feature release stabilization branch, your new local branch should of course be based on the stabilization branch instead of <code>master</code>. <pre><code>$ git switch -c JDK-8272373 jdk23</code></pre> <code>git switch</code> was introduced in Git version 2.23. For earlier versions of Git <code>git checkout</code> can be used instead. However it is always recommended to use the latest versions of all your tools when possible. <div class="note"> More information about how to work with git and the dedicated tooling that is available for OpenJDK can be found in the <a href="https://wiki.openjdk.org/display/SKARA">Project Skara Documentation</a>. If you’re new to git you can also read more about how to work with it in one of the many fine git tutorials available on the Internet. For instance the <a href="https://git-scm.com/book/en/v2">Pro Git book</a>. This guide doesn’t aspire to become another git guide. </div> <h2 id="generating-an-ssh-key">Generating an SSH key</h2> For security reasons you should always create new keys and use different keys with each repository you clone. The <code>ssh-keygen</code> command generates an SSH key. The <code>-t</code> option determines which type of key to create. <code>ed25519</code> is recommended. <code>-C</code> is used to add a comment in the key file, to help you remember which key it is. While it’s possible to use SSH without a passphrase, this is strongly discouraged. Empty or insecure passphrases may be reset using <code>ssh-keygen -p</code>; this doesn’t change the keys. <pre><code>$ ssh-keygen -t ed25519 -C openjdk-jdk -f ~/.ssh/openjdk-jdk Generating public/private ed25519 key pair. Enter passphrase (empty for no passphrase): Enter same passphrase again: Your identification has been saved in /Users/duke/.ssh/openjdk-jdk. Your public key has been saved in /Users/duke/.ssh/openjdk-jdk.pub. The key fingerprint is: SHA256:WS4jCQMtat75ZEue+so+Lgj7V/sdMtj1FTNkfNsCfHA openjdk-jdk The key's randomart image is: +--[ED25519 256]--+ | .. ..oE | | ... o+o .| | . .o . o+.o| |.. o . + .=.| |o . . o S o .. | |.. o +.+ + . . | |o. *.+.+ . . | |o....=. + . | | .=B=. .. . | +----[SHA256]-----+</code></pre> <code>~/.ssh/openjdk-jdk</code> is a text file containing your private ssh key. There’s a corresponding public key in <code>~/.ssh/openjdk-jdk.pub</code> (as detailed in the example above). You should never share your private key. The public key on the other hand should be uploaded to <a href="https://github.com">GitHub</a>. Follow the steps below to do that. <ul> <li>Go to the GitHub settings for your account by choosing “Settings” in the menu by your avatar in the upper right corner</li> <li>Go to “SSH and GPG keys”</li> <li>Click “New SSH key”</li> <li>Title “OpenJDK” (or something else appropriate)</li> <li>Paste the content of <code>~/.ssh/openjdk-jdk.pub</code> into the text field <ul> <li>To get the content of the file you can for instance use <code>cat ~/.ssh/openjdk-jdk.pub</code></li> <li>It will look something like this: <code>ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIO8+egiIgWV+tE7LVVJmlR7WS2Lr3Fj7dXVo9HiasD6T openjdk-jdk</code></li> </ul> </li> <li>Click “Add SSH key”</li> </ul> Now you are ready to clone your <a href="https://github.com/openjdk/jdk">openjdk/jdk</a> fork using SSH. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="making-a-change">Making a Change</h1> <div class="box"> Quick Links <ul> <li><a href="https://wiki.openjdk.org/display/csr/Main">CSR Wiki</a></li> </ul> </div> In case you jumped directly here and skipped reading the earlier sections of this guide, please keep in mind that there’s a lot more to it than just making a change in the code and submit a PR to GitHub. The list below shows the bare minimum required before a change can be accepted into OpenJDK. <ol> <li>Discuss the intended change – See <a href="#contributing-to-an-openjdk-project">Contributing to an OpenJDK Project</a></li> <li>Make sure an issue id exists for the work – See <a href="#filing-an-issue">Filing an issue</a></li> <li>Initiate a CSR request if your change have a compatibility impact – See <a href="#working-with-the-csr">Working with the CSR</a></li> <li>Fix the issue – See <a href="#cloning-the-jdk">Cloning the JDK</a>, <a href="#working-with-git-branches">Working with git branches</a>, and <a href="#building-the-jdk">Building the JDK</a></li> <li>Write regression tests and run relevant regression and unit tests on all relevant platforms – See <a href="#testing-the-jdk">Testing the JDK</a></li> <li>Create a changeset – See <a href="#working-with-pull-requests">Working With Pull Requests</a></li> <li>Update the bug content – See <a href="#updating-an-issue-while-fixing">Updating an issue while fixing</a></li> <li>Request a review of the changes – See <a href="#life-of-a-pr">Life of a PR</a></li> <li>Merge with the latest upstream changes and test again</li> <li>Integrate the changeset – See <a href="#working-with-pull-requests">Working With Pull Requests</a></li> <li>Write a release note if appropriate – See <a href="#release-notes">Release Notes</a></li> </ol> <h2 id="working-with-the-csr">Working with the CSR</h2> Changes that have a compatibility impact will require a separate approval besides the code review. This is handled through a <a href="https://wiki.openjdk.org/display/csr/Main">Compatibility and Specification Review</a>, a.k.a. CSR. Compatibility impact can be things like requiring a specification change, directly affect an external interface, changing command line options, or otherwise alter the behavior of the JDK in ways that could cause issues for users when upgrading to the next JDK version. See the <a href="https://wiki.openjdk.org/display/csr/Main">CSR wiki</a> for information on how to work through the CSR process. The CSR must be approved before the change is allowed to be integrated to a feature release or update release repository. Feature design and implementation work may begin concurrently with the CSR review, but may need to be modified in response to CSR feedback. <h2 id="copyright-headers">Copyright Headers</h2> All source code files in OpenJDK has a header with copyright statements and a license. Since this is legal documentation it shall not be updated or modified without seeking guidance from your legal representative. For that reason this guide can’t really give detailed information on what you can or should do. There are however a few generic things that can be clarified. This is an example copyright/license header: <pre><code>/* * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2018, 2020 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */</code></pre> This header has two copyright notices at the top (Oracle and SAP SE) and below them the license text. As stated in the header, don’t make changes to the copyright notices or the license text below them. If your affiliation has a copyright notice at the top of the header, consult your legal representative on how to update it. If your affiliation doesn’t have a copyright notice, again consult your legal representative to see if you should add one. Do not update a copyright notice if you don’t belong to that affiliation unless explicitly asked by the affiliation in question. If you create a new file, copy the license text from a nearby file. Do not add copyright notices for affiliations to which you don’t belong. If you move code from an existing file to a new file, bring the entire copyright + license header over to the new file. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="building-the-jdk">Building the JDK</h1> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/groups/build/doc/building.html">Official build instructions</a></li> <li><a href="https://github.com/openjdk/jdk">openjdk/jdk GitHub project</a></li> <li><a href="https://jdk.java.net/16/">JDK 16 General-Availability Release</a></li> </ul> </div> The JDK build system is a fairly complex machine that has the ability to build anything from a single module to a complete shippable JDK bundle with various levels of debug capabilities, run tests, install your newly built JDK on your system, or cross-compile for some other system. The build uses <code>make</code> and a few other tools that you will have to install on your system before starting. The JDK supports incremental builds. This means that if you have a complete build and make changes in just a single part of the JDK (e.g. a module or part of the JVM), only that particular part needs to be rebuilt. So subsequent builds will be faster and you can always use a make target that results in a complete JDK image without having to worry about actually building the entire JDK every time. Please note that the incremental build do have limits in its understanding of what you change. For instance, if you change behaviors or conventions in one module there may be other parts of the JDK that implicitly depends on these without make’s knowledge. For this reason you may have to rebuild several modules, or do a clean build if you change things that may have a wider impact. The examples below show the steps taken to build the JDK source code. Please see <a href="#cloning-the-jdk">Cloning the JDK</a> for information on how to download it. These examples were written in the JDK 17 development time frame which is why the boot JDK used here is JDK 16. Note that the download links used here point to JDK 16 bundles. To build JDK N, use JDK N-1 as the boot JDK. The configure script will tell you what additional packages you need. In this first example several packages were needed since this build was performed on a clean Ubuntu installation. The configure script was run several times to get all the dependencies, but only the commands actually needed to get the JDK built are included in the log. This is just an example log, don’t copy the <code>apt-get install</code> line. Instead run <code>sh ./configure</code> to see what packages you actually need on your system. <pre><code>$ wget https://download.java.net/java/GA/jdk16/7863447f0ab643c585b9bdebf67c69db/36/GPL/openjdk-16_linux-x64_bin.tar.gz $ tar xzf openjdk-16_linux-x64_bin.tar.gz $ sudo apt-get install autoconf zip make gcc g++ libx11-dev libxext-dev libxrender-dev libxrandr-dev libxtst-dev libxt-dev libcups2-dev libfontconfig1-dev libasound2-dev $ cd jdk $ sh ./configure --with-boot-jdk=$HOME/jdk-16/ $ make images</code></pre> The built JDK can be found in <code>build/linux-x86_64-server-release/jdk</code>. The exact path depends on your build platform and selected configuration. The second example is from a clean (newly installed) Mac running MacOS Big Sur. Please note that in this case there are some steps taken outside of the terminal. First XCode and the XCode command line tools must be installed. It could be that the most recent version of XCode that you get from App Store is too new to have been properly tested with the JDK build. See <a href="https://github.com/openjdk/jdk/blob/master/doc/building.md#apple-xcode"> the JDK build instructions</a> for supported versions and more details in case you need to install an older version of XCode. In this example <a href="https://www.macports.org">Mac Ports</a> is used to install <code>autoconf</code>. <code>autoconf</code> can also be installed using <a href="https://brew.sh">Homebrew</a> and surely through other sources as well. <pre><code>$ curl https://download.java.net/java/GA/jdk16.0.1/7147401fd7354114ac51ef3e1328291f/9/GPL/openjdk-16.0.1_osx-x64_bin.tar.gz --output openjdk-16.0.1_osx-x64_bin.tar.gz $ tar xzf openjdk-16.0.1_osx-x64_bin.tar.gz $ sudo port install autoconf $ sh ./configure --with-boot-jdk=$HOME/jdk-16.0.1.jdk/Contents/Home $ make images</code></pre> In this case the built JDK can be found in <code>build/macosx-x86_64-server-release/jdk</code>. <h2 id="configuration-options">Configuration options</h2> The JDK build is extremely configurable. This list only contains the most basic configure options needed to get you started. Use <code>configure --help</code> to see a complete list of options. <table> <colgroup> <col width="50%" /> <col width="50%" /></colgroup> <thead> <tr class="header"> <th align="left">Option</th> <th align="left">What it does</th> </tr> </thead> <tbody> <tr class="odd"> <td align="left"><code>--with-boot-jdk</code></td> <td align="left">Tell configure what boot JDK to use to build the Java libraries.</td> </tr> <tr class="even"> <td align="left"><code>--with-debug-level</code></td> <td align="left">Set the debug level. Available levels are <code>release</code>, <code>fastdebug</code>, <code>slowdebug</code>, <code>optimized</code>.</td> </tr> </tbody> </table> <h3 id="working-with-multiple-configurations">Working with multiple configurations</h3> Through the configure flags you will select what configuration of the JDK to build. The name of the output directory for the build depends on this configuration. In the example above the JDK ended up in <code>linux-x86_64-server-release</code>. This means that we made a release build of a 64 bit linux x86 version of the server JDK. If we change some of these options the output directory will be affected accordingly. <code>--with-debug-level</code> is one example of a configure option that will change the output directory name. Sometimes it makes sense to have several different configurations in parallel. For example while debugging some code you might want to have both a debug build and a release build to be able to test it properly. The directory naming scheme makes this very easy. Simply configure and build the JDKs you need and they will end up next to each other in the build directory. In the example above we built a <code>release</code> image. To build a debug image as well we can configure with <code>--with-debug-level=slowdebug</code>. This will give us a JDK where for instance asserts in the JDK source code are enabled. To select which JDK to work with in later calls to <code>make</code> add <code>CONF=<configuration></code>. <pre><code>$ sh ./configure --with-boot-jdk=$HOME/jdk-16/ --with-debug-level=slowdebug $ make CONF=slowdebug images $ ls build/ linux-x86_64-server-release linux-x86_64-server-slowdebug</code></pre> <h2 id="make-targets">Make targets</h2> <code>make images</code>, as used in the example above, will build a JDK image which is very close to what you’d get from any JDK provider. There are several other make targets you can use depending on what you’re looking for. The table below contains some commonly used make targets. <table> <colgroup> <col width="36%" /> <col width="63%" /></colgroup> <thead> <tr class="header"> <th align="left">Target</th> <th align="left">What it does</th> </tr> </thead> <tbody> <tr class="odd"> <td align="left"><code>exploded-image</code></td> <td align="left">This is the default make target that you’ll get if you simply invoke <code>make</code>.</td> </tr> <tr class="even"> <td align="left"><code>image</code></td> <td align="left">Builds a complete JDK image. A good target to use if you want to build a JDK for general usage or if you want to test something closer to the shipping product. This can also be a good target to use if doing something which might have a build aspect to it.</td> </tr> <tr class="odd"> <td align="left"><code><name>-image</code></td> <td align="left">Build just the image for any of jdk, test, docs, symbols, etc.</td> </tr> <tr class="even"> <td align="left"><code>reconfigure</code></td> <td align="left">Re-runs the configure script with the same arguments as given the last time.</td> </tr> <tr class="odd"> <td align="left"><code>demos</code></td> <td align="left">Builds the demos which for instance make it easy to test something UI related.</td> </tr> <tr class="even"> <td align="left"><code>docs</code></td> <td align="left">Builds the javadoc. Note that a number of classes in the javadoc API are generated during the build, so <code>make docs</code> might do more than simply invoke <code>javadoc</code>, depending on the state of your build.</td> </tr> <tr class="odd"> <td align="left"><code>java.base</code></td> <td align="left">Builds the base module. You can (re)build any module with <code>make <module></code>.</td> </tr> <tr class="even"> <td align="left"><code>hotspot</code></td> <td align="left">Builds the JVM. Note that the JVM depends on several other parts of the JDK, so <code>make hotspot</code> might build more than just the JVM, depending on the state of your build.</td> </tr> <tr class="odd"> <td align="left"><code>clean</code></td> <td align="left">Removes all files generated by make, but not those generated by configure. Useful when doing significant renaming or refactoring which may confuse the incremental build. To clean out a specific module only use <code>make clean-<module></code>.</td> </tr> <tr class="even"> <td align="left"><code>dist-clean</code></td> <td align="left">Removes all files, including configuration.</td> </tr> </tbody> </table> There are many other targets available as well. Use <code>make help</code> to find out more. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="testing-the-jdk">Testing the JDK</h1> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/groups/build/doc/testing.html">Using the run-test Framework</a></li> <li><a href="https://openjdk.org/jtreg/">jtreg Harness Documentation</a></li> <li><a href="https://github.com/google/googletest/blob/main/docs/index.md">Google Test Documentation</a></li> </ul> </div> In addition to your own Java applications, OpenJDK has support for two test frameworks to test the JDK, jtreg and GTest. jtreg is a Java regression test framework that is used for most of the tests that are included in the OpenJDK source repository. The Google Test (GTest) framework is intended for unit testing of the C++ native code. Currently only JVM testing is supported by the GTest framework. Other areas use jtreg for unit testing of C++ code. This section provides a brief summary of how to get started with testing in OpenJDK. For more information on configuration and how to use the OpenJDK test framework, a.k.a. “run-test framework”, see <a href="https://github.com/openjdk/jdk/blob/master/doc/testing.md"><code>doc/testing.md</code></a>. Please note that what’s mentioned later in this section, like <a href="#github-actions">GHA</a> and tier 1 testing, will only run a set of smoke-tests to ensure your change compiles and runs on a variety of platforms. They won’t do any targeted testing on the particular code you have changed. You must always make sure your change works as expected before integrating, using targeted testing. In general all changes should come with a regression test, so if you’re writing product code you should also be writing test code. Including the new tests (in the right places) in your change will ensure your tests will be run as part of your testing on all platforms and in the future. A few key items to think about when writing a regression test: <ul> <li>A regression test should execute fast - a few seconds at most</li> <li>The test should only test the desired functionality - if you have several features to test, write more tests</li> <li>The test should pass reliably on all supported platforms - watch out for platform-specific differences such as path separators</li> <li>Binary files shouldn’t be checked in, if your test needs to use one, the test should create it in some fashion</li> <li>Avoid shell scripts and relying on external commands as much as possible</li> </ul> The jtreg documentation has a section on <a href="https://openjdk.org/jtreg/writetests.html">how to write good jtreg tests</a>. There are a few examples where it doesn’t make sense to write an explicit regression test. These should be tagged in JBS with one of the <a href="#noreg">noreg-labels</a>. <h2 id="jtreg">jtreg</h2> In-depth documentation about the jtreg framework is found here: <a href="https://openjdk.org/jtreg/">jtreg harness</a>. jtreg itself is available in the <a href="https://openjdk.org/projects/code-tools/">Code Tools Project</a>. Below is a small example of a jtreg test. It’s a clean Java class with a main method that is called from the test harness. If the test fails we throw a RuntimeException. This is picked up by the harness and is reported as a test failure. Try to always write a meaningful message in the exception. One that actually helps with understanding what went wrong once the test fails. <div class="sourceCode" id="cb10"> <pre class="sourceCode java"><code class="sourceCode java"><a href="#cb10-1" aria-hidden="true" tabindex="-1"></a>/* <a href="#cb10-2" aria-hidden="true" tabindex="-1"></a> * @test <a href="#cb10-3" aria-hidden="true" tabindex="-1"></a> * @summary Make sure feature X handles Y correctly <a href="#cb10-4" aria-hidden="true" tabindex="-1"></a> * @run main TestXY <a href="#cb10-5" aria-hidden="true" tabindex="-1"></a> */ <a href="#cb10-6" aria-hidden="true" tabindex="-1"></a>public class TestXY { <a href="#cb10-7" aria-hidden="true" tabindex="-1"></a> public static void main(String[] args) throws Exception { <a href="#cb10-8" aria-hidden="true" tabindex="-1"></a> var result = X.y(); <a href="#cb10-9" aria-hidden="true" tabindex="-1"></a> if (result != expected_result) { <a href="#cb10-10" aria-hidden="true" tabindex="-1"></a> throw new RuntimeException("X.y() gave " + result + ", expected " + expected_result); <a href="#cb10-11" aria-hidden="true" tabindex="-1"></a> } <a href="#cb10-12" aria-hidden="true" tabindex="-1"></a> } <a href="#cb10-13" aria-hidden="true" tabindex="-1"></a>}</code></pre></div> This example only utilizes three jtreg specific tags, <code>@test</code>, <code>@summary</code>, and <code>@run</code>. <code>@test</code> simply tells jtreg that this class is a test, and <code>@summary</code> provides a description of the test. <code>@run</code> tells jtreg how to execute the test. In this case we simply tell jtreg to execute the main method of the class <code>TestXY</code>. <code>@run</code> isn’t strictly necessary for jtreg to execute the test, an implicit <code>@run</code> tag will be added if none exists. However, for clarity and in order to avoid bugs it’s recommended to always explicitly use the <code>@run</code> tag. There are several other tags that can be used in jtreg tests. You can for instance associate the test with a specific bug that this test is a regression test for. The bug id is written without the <code>JDK-</code> prefix. <pre><code>@bug 8272373</code></pre> You can add several bug ids in the same <code>@bug</code> tag, separated by a single space. These bug ids refer to product bugs for which a fix is verified by this test. JBS issues that track changes to the test itself are not listed here. You can also specify a number of requirements that must be fulfilled for jtreg to execute the test. <pre><code>@requires docker.support @requires os.family != "windows" @requires os.maxMemory > 3G @requires os.arch=="x86_64" | os.arch=="amd64"</code></pre> And you can specify if the test requires specific modules, or command line flags to run the test in several different ways. <pre><code>@modules java.base/jdk.internal.misc @run main/othervm -Xmx128m TestXY</code></pre> Note that you can have several <code>@run</code> tags in the same test with different command line options. jtreg also have support for labeling tests with keys using the <code>@key</code> tag. These keywords can then be used to filter the test selection. For instance if you have a UI test which needs to display a window you’ll want to make sure the test harness doesn’t try to run this test on a system which doesn’t support headful tests. You do this by specifying <pre><code>@key headful</code></pre> Another example is <code>@key randomness</code> that should be used to indicate that a test is using randomness - i.e. is intentionally non-deterministic. There are many other keywords in use and their usage may differ between areas in the JDK. Make sure you understand the conventions for the particular area you are testing since these are just examples. The <a href="https://openjdk.org/jtreg/">jtreg documentation</a> provides information on many more tags like these. The <a href="https://openjdk.org/groups/compiler/">compiler group</a> has a section in their wiki with <a href="https://openjdk.org/groups/compiler/tests.html">Guidelines for “langtools” tests</a>. <h3 id="running-openjdk-jtreg-tests">Running OpenJDK jtreg tests</h3> When configuring the OpenJDK build you can tell it where your jtreg installation is located. When providing this information you can later run <code>make run-test</code> to execute jtreg tests. <pre><code>sh ./configure --with-jtreg=/path/to/jtreg make run-test TEST=tier1</code></pre> In the OpenJDK source tree you can find a directory called <code>test</code>. There are a large number of tests in this directory that are written to be used with jtreg. <pre><code>make run-test TEST=test/jdk/java/lang/String/</code></pre> You can also run jtreg without invoking make. In this case you’ll need to tell jtreg which JDK to test. <pre><code>jtreg -jdk:/path/to/jdk /path/to/test</code></pre> <h2 id="gtest">GTest</h2> As mentioned the Google test framework is mainly used for C++ unit tests. There are several of these in the <code>test/hotspot</code> directory. Currently, only the C++ code in the JVM area is supported by the OpenJDK GTest framework. The tests can be run without starting the JVM, which enables testing of JVM data structures that would be fragile to play with in a running JVM. <div class="sourceCode" id="cb18"> <pre class="sourceCode java"><code class="sourceCode java"><a href="#cb18-1" aria-hidden="true" tabindex="-1"></a>static int demo_comparator(int a, int b) { <a href="#cb18-2" aria-hidden="true" tabindex="-1"></a> if (a == b) { <a href="#cb18-3" aria-hidden="true" tabindex="-1"></a> return 0; <a href="#cb18-4" aria-hidden="true" tabindex="-1"></a> } <a href="#cb18-5" aria-hidden="true" tabindex="-1"></a> if (a < b) { <a href="#cb18-6" aria-hidden="true" tabindex="-1"></a> return -1; <a href="#cb18-7" aria-hidden="true" tabindex="-1"></a> } <a href="#cb18-8" aria-hidden="true" tabindex="-1"></a> return 1; <a href="#cb18-9" aria-hidden="true" tabindex="-1"></a>} <a href="#cb18-10" aria-hidden="true" tabindex="-1"></a> <a href="#cb18-11" aria-hidden="true" tabindex="-1"></a>TEST(Demo, quicksort) { <a href="#cb18-12" aria-hidden="true" tabindex="-1"></a> int test_array[] = {7,1,5,3,6,9,8,2,4,0}; <a href="#cb18-13" aria-hidden="true" tabindex="-1"></a> int expected_array[] = {0,1,2,3,4,5,6,7,8,9}; <a href="#cb18-14" aria-hidden="true" tabindex="-1"></a> <a href="#cb18-15" aria-hidden="true" tabindex="-1"></a> QuickSort::sort(test_array, 10, demo_comparator, false); <a href="#cb18-16" aria-hidden="true" tabindex="-1"></a> for (int i = 0; i < 10; i++) { <a href="#cb18-17" aria-hidden="true" tabindex="-1"></a> ASSERT_EQ(expected_array[i], test_array[i]); <a href="#cb18-18" aria-hidden="true" tabindex="-1"></a> } <a href="#cb18-19" aria-hidden="true" tabindex="-1"></a>}</code></pre></div> <code>ASSERT_EQ</code> is one example of an assertion that can be used in the test. Below are a few other examples. A full list is found in the <a href="https://github.com/google/googletest/blob/main/docs/index.md">Google Test Documentation</a>. <div class="sourceCode" id="cb19"> <pre class="sourceCode java"><code class="sourceCode java"><a href="#cb19-1" aria-hidden="true" tabindex="-1"></a>ASSERT_TRUE(condition); <a href="#cb19-2" aria-hidden="true" tabindex="-1"></a>ASSERT_FALSE(condition); <a href="#cb19-3" aria-hidden="true" tabindex="-1"></a>EXPECT_EQ(expected, actual); <a href="#cb19-4" aria-hidden="true" tabindex="-1"></a>EXPECT_LT(val1, val2); <a href="#cb19-5" aria-hidden="true" tabindex="-1"></a>EXPECT_STREQ(expected_str, actual_str);</code></pre></div> <code>ASSERT</code> is a fatal assertion and will interrupt execution of the current sub-routine. <code>EXPECT</code> is a nonfatal assertion and will report the error but continues to run the test. All assertions have both an <code>ASSERT</code> and an <code>EXPECT</code> variant. For more information on how to write good GTests in HotSpot, see <a href="https://github.com/openjdk/jdk/blob/master/doc/hotspot-unit-tests.md"> <code>doc/hotspot-unit-tests.md</code></a>. <h3 id="running-openjdk-gtests">Running OpenJDK GTests</h3> When configuring the OpenJDK build you can tell it where your GTest installation is located. Once configured, use make to run GTests. <pre><code>sh ./configure --with-gtest=/path/to/gtest make test TEST=gtest</code></pre> You can also use a regular expression to filter which tests to run: <pre><code>make test TEST=gtest:code.*:os.* make test TEST=gtest:$X/$variant</code></pre> The second example above runs tests which match the regexp <code>$X.*</code> on a specific variant of the JVM. The variant is one of client, server, etc. <h2 id="github-actions">GitHub actions</h2> <a href="https://github.com">GitHub</a> has a feature called GitHub actions (GHA) that can be used to automate testing. The GHA is executed whenever a push is made to a branch in your repository. The bots will show the results of the GHA in your PR when you create or update it. The GHA in the JDK Project is configured to run a set of tests that is commonly known as tier 1. This is a relatively fast, small set of tests that tries to verify that your change didn’t break the JDK completely. In tier 1 the JDK is built on a small set of platforms including (but not necessarily limited to) Linux, Windows, and MacOS, and a few tests are executed using these builds. There’s also a set of other platforms for which GHA does cross-complilation builds. In addition to the testing you run manually before publishing your changes, it’s recommended that you take advantage of this automated testing that the GHA offers. This will for instance allow you to run tests on platforms that you may not otherwise have access to. To enable this on your personal fork of the JDK on <a href="https://github.com">GitHub</a> go to the “Actions” tab and click the big green button saying “I understand my workflows, go ahead and enable them”. If you don’t understand these workflows there’s a link to the actual file that describes them right below the green button. In case of failures in the GHA it’s always a good start to try to reproduce the failure locally on a machine where you have better control and easier access to a debug environment. There have been cases where the GHA has failed due to issues unrelated to the change being tested, e.g. because the GHA environment was updated and changes were needed to the JDK GHA configuration. The configuration is in general updated fairly quickly, so in cases were you can’t reproduce the failure locally, consider re-running the GHA later. Please keep in mind that the tier 1 tests run by the GHA should only be seen as a smoke test that finds the most critical breakages, like build errors or if the JDK is DOA. These tests can never replace the targeted testing that you always must do on your changes. There are several areas of the JDK that aren’t part of tier 1 at all. To see exactly what tier 1 includes, please see the various TEST.groups files that you will find in the subdirectories of <a href="https://github.com/openjdk/jdk/tree/master/test"><code>jdk/test/</code></a>. <div class="note"> In the past there used to be a sandbox repository that could be used for testing purposes. With the move to Git this has been replaced by GitHub Actions. </div> <h2 id="excluding-a-test">Excluding a test</h2> Sometimes tests break. It could be e.g. due to bugs in the test itself, due to changed functionality in the code that the test is testing, or changes in the environment where the test is executed. While working on a fix, it can be useful to stop the test from being executed in everyone else’s testing to reduce noise, especially if the test is expected to fail for more than a day. There are two ways to stop a test from being run in standard test runs: ProblemListing and using the <code>@ignore</code> keyword. Removing tests isn’t the standard way to remove a failure. A failing test is often a regression and should ideally be handled with high urgency. Remember to remove the JBS id from the ProblemList or the test when the bug is closed. This is especially easy to forget if a bug is closed as Duplicate or Won’t Fix. jcheck will report an error and prohibit an integration if a PR is created for an issue that is found in a ProblemList if the fix doesn’t remove the bug ID from the ProblemList. <h3 id="problemlisting-jtreg-tests">ProblemListing jtreg tests</h3> ProblemListing should be used for a short term exclusion while a test is being fixed, and for the exclusion of intermittently failing tests that cause too much noise, but can still be useful to run on an ad-hoc basis. ProblemListing is done in the file <code>ProblemList.txt</code>. For more details about the <code>ProblemList.txt</code> file see the <a href="https://openjdk.org/jtreg/faq.html#what-is-a-problemlist.txt-file"> jtreg FAQ</a>. There are actually several ProblemList files to choose from in the JDK. Their location and name hint about what area or feature each file belongs to. Each file has sections for different components. All ProblemList files complement each other to build the total set of tests to exclude in jtreg runs. <pre><code>test/hotspot/jtreg/ProblemList.txt test/hotspot/jtreg/ProblemList-aot.txt test/hotspot/jtreg/ProblemList-graal.txt test/hotspot/jtreg/ProblemList-non-cds-mode.txt test/hotspot/jtreg/ProblemList-Xcomp.txt test/hotspot/jtreg/ProblemList-zgc.txt test/jaxp/ProblemList.txt test/jdk/ProblemList.txt test/jdk/ProblemList-aot.txt test/jdk/ProblemList-graal.txt test/jdk/ProblemList-Xcomp.txt test/langtools/ProblemList.txt test/langtools/ProblemList-graal.txt test/lib-test/ProblemList.txt</code></pre> Use the suitable ProblemList and add a line like this in the proper section: <pre><code>foo/bar/MyTest.java 4711 windows-all</code></pre> In this example, <code>MyTest.java</code> is ProblemListed on windows, tracked by bug <code>JDK-4711</code>. Currently there’s <a href="https://bugs.openjdk.org/browse/CODETOOLS-7902481">no support for multiple lines for the same test</a>. For this reason it’s important to always make sure there’s no existing entry for the test before adding a new one, as multiple entries might lead to unexpected results, e.g. <pre><code>foo/bar/MyTest.java 4710 generic-all ... foo/bar/MyTest.java 4711 windows-all</code></pre> This would lead to <code>sun.tools.jcmd.MyTest.java</code> being ProblemListed only on <code>windows-all</code>. The proper way to write this is: <pre><code>foo/bar/MyTest.java 4710,4711 generic-all,windows-all</code></pre> Although <code>windows-all</code> isn’t strictly required in this example, it’s preferable to specify platforms for each bugid (unless they are all <code>generic-all</code>), this makes it easier to remove one of the bugs from the list. A common way to handle the JBS issue used to problemlist a test is to create a Sub-task of the bug that needs to be fixed to be able to remove the test from the problem list again. Remember to always add a problemlist label in the JBS issue referenced in the ProblemList entry. <h4 id="problemlisting-some-but-not-all-test-cases-in-a-file"> ProblemListing some, but not all, test cases in a file</h4> Some tests contain several test cases and there may be a need to ProblemList only a few of them. To do this use the full test name, i.e. <code><filename> + # + <test case id></code>, where test case id can be specified in the test header. If no id is specified each test case can be referenced with <code>id</code> + ordinary number of the test case in the test file. Let’s assume we have four test cases in <code>foo/bar/MyTest.java</code>: <pre><code>/* @test */ /* @test id=fancy_name */ /* @test */ /* @test */</code></pre> A ProblemList entry that excludes the first, second, and third test case would look like this: <pre><code>foo/bar/MyTest.java#id0 4720 generic-all foo/bar/MyTest.java#fancy_name 4721 generic-all foo/bar/MyTest.java#id2 4722 generic-all</code></pre> Due to an issue described in <a href="https://bugs.openjdk.org/browse/CODETOOLS-7902712">CODETOOLS-7902712</a> tests that contains more than one <code>@test</code> must actually use this way to specify all test cases if all of them should be ProblemListed. Specifying just the test name will not work. <h4 id="running-problemlisted-tests">Running ProblemListed tests</h4> To run ad-hoc runs of ProblemListed tests use <code>RUN_PROBLEM_LISTS=true</code>. <pre><code>make test TEST=... JTREG=RUN_PROBLEM_LISTS=true</code></pre> <h3 id="exclude-jtreg-tests-using-ignore">Exclude jtreg tests using <code>@ignore</code></h3> The <code>@ignore</code> keyword is used in the test source code. This is mainly used for tests that are so broken that they may be harmful or useless, and is less common than ProblemListing. Examples can be tests that don’t compile because something changed in the platform; or a test which might remove your <code>/etc/shadow</code>. Use <code>@ignore</code> with a bug reference in the test case to prevent the test from being run. <div class="sourceCode" id="cb29"> <pre class="sourceCode java"><code class="sourceCode java"><a href="#cb29-1" aria-hidden="true" tabindex="-1"></a>/** <a href="#cb29-2" aria-hidden="true" tabindex="-1"></a> * @test <a href="#cb29-3" aria-hidden="true" tabindex="-1"></a> * @ignore 4711 <a href="#cb29-4" aria-hidden="true" tabindex="-1"></a> */</code></pre></div> In this example, <code>MyTest.java</code> is excluded, tracked by bug <code>JDK-4711</code>. <code>@ignore</code> should generally be placed directly before the first “action” tag (e.g. <code>@compile</code>, <code>@run</code>) if any in the test. <h3 id="dealing-with-jbs-bugs-for-test-exclusion">Dealing with JBS bugs for test exclusion</h3> ProblemListing and <code>@ignore</code>-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible. <ul> <li>Code review: ProblemListing a test is considered a <a href="#trivial">trivial</a> change.</li> <li>JBS issue: A JBS issue is obviously created for the bug that caused the failure, we call this the main issue. To exclude the test, create a subtask to the main issue. Also add the label <a href="#problemlist">problemlist</a> to the main issue.</li> </ul> The fix for the main issue should remove the test from the ProblemList or remove the <code>@ignore</code> keyword from the test. <h4 id="triage-excluded-issues">Triage excluded issues</h4> After a failure is handled by excluding a test, the main JBS issue should be re-triaged and possibly given a new priority. This should be handled by the standard triage process. A test exclusion results in an outage in our testing. This outage should be taken into consideration when triaging, in addition to the impact of the bug itself. <h2 id="backing-out-a-change">Backing out a change</h2> If a change causes a regression that can’t be fixed within reasonable time, the best way to handle the regression can be to back out the change. Backing out means that the inverse (anti-delta) of the change is integrated to effectively undo the change in the repository. Whether to back out a change or not will always be a judgement call. How noisy and frequent are the failures caused by the broken change? How soon can the fix be expected? If you want to avoid having your change backed out, you should make sure to let the relevant developers know that you are working on the fix and give an estimated ETA of the fix. It will happen of course when the build is broken or the JDK is DOA and similar situations that a change is immediately backed out without further investigation. Backing out a change is however seldom the first course of action if the change has been done in accordance with the guidance in <a href="#working-with-pull-requests">Working With Pull Requests</a>. If, when investigated, it is found that a change didn’t go through relevant testing or there are other issues that should have been caught before integration if proper procedure had been followed, it’s quite possible that a change is backed out even if the author is desperately working on a fix. The JDK source code is deliberately menat to have a high bar for acceptance of changes. If something crawls in underneath that bar it should most likely be backed out. The backout is a regular change and will have to go through the standard code review process, but is considered a <a href="#trivial">trivial</a> change. The rationale is that a backout is usually urgent in nature and the change itself is automatically generated. In areas where two reviewers are normally required, only one <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> is required for a backout since the person who is performing the backout also should review the change. There are two parts to this task, how to do the bookkeeping in JBS, and how to do the actual backout in git. <h3 id="how-to-work-with-jbs-when-a-change-is-backed-out">How to work with JBS when a change is backed out</h3> <ol> <li>Close the original (failed) JBS issue (O). <ul> <li>“Verify” the issue and choose “Fix Failed”.</li> </ul> </li> <li>If the intention is to fix the change and submit it again, create a redo-issue (R) to track that the work still needs to be done. <ul> <li>Clone (O) and add the prefix <code>[REDO]</code> on the summary - the clone becomes the redo-issue (R).</li> <li>Make sure relevant information is brought to (R).</li> <li>Remember that comments aren’t automatically brought over when cloning.</li> </ul> </li> <li>Create a backout-issue (B): <ul> <li>Alternative 1 - the regression is identified directly. <ul> <li>Create a sub-task to (R) with the same summary prefixed with <code>[BACKOUT]</code>.</li> </ul> </li> <li>Alternative 2 - an investigation issue was created (I), and during the investigation backing out the change is identified as the best solution. <ul> <li>Use the investigation issue (I) for the backout.</li> <li>Change summary of (I) to the same as (O) and prefix with <code>[BACKOUT]</code>.</li> <li>Move and change type of (I) to become a sub-task of (R).</li> </ul> </li> <li>Alternative 3 - no redo issue was created. <ul> <li>Create a backout-issue (B) with the same summary as (O), prefix with <code>[BACKOUT]</code>.</li> <li>Add a relates to link between (B) and (O).</li> </ul> </li> </ul> </li> </ol> ProblemList entries and <code>@ignore</code> keywords will continue to point to the original bug (unless updated at back out). This is accepted since there is a clone link to follow. <h3 id="how-to-work-with-git-when-a-change-is-backed-out">How to work with git when a change is backed out</h3> To backout a change with git, use <code>git revert</code>. This will apply (commit) the anti-delta of the change. <div class="sourceCode" id="cb30"> <pre class="sourceCode diff"><code class="sourceCode diff"><a href="#cb30-1" aria-hidden="true" tabindex="-1"></a>$ git show aa371b4f02c2f809eb9cd3e52aa12b639bed1ef5 <a href="#cb30-2" aria-hidden="true" tabindex="-1"></a>commit aa371b4f02c2f809eb9cd3e52aa12b639bed1ef5 (HEAD -> master) <a href="#cb30-3" aria-hidden="true" tabindex="-1"></a>Author: Jesper Wilhelmsson <jesper.wilhelmsson@oracle.com> <a href="#cb30-4" aria-hidden="true" tabindex="-1"></a>Date: Wed Jun 23 20:31:32 2021 +0200 <a href="#cb30-5" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-6" aria-hidden="true" tabindex="-1"></a> 8272373: Make the JDK mine <a href="#cb30-7" aria-hidden="true" tabindex="-1"></a> Reviewed-by: duke <a href="#cb30-8" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-9" aria-hidden="true" tabindex="-1"></a>diff --git a/README.md b/README.md <a href="#cb30-10" aria-hidden="true" tabindex="-1"></a>index 399e7cc311f..4961acb2126 100644 <a href="#cb30-11" aria-hidden="true" tabindex="-1"></a>--- a/README.md <a href="#cb30-12" aria-hidden="true" tabindex="-1"></a>+++ b/README.md <a href="#cb30-13" aria-hidden="true" tabindex="-1"></a>@@ -1,4 +1,4 @@ <a href="#cb30-14" aria-hidden="true" tabindex="-1"></a>-# Welcome to the JDK! <a href="#cb30-15" aria-hidden="true" tabindex="-1"></a>+# Welcome to my modified JDK! <a href="#cb30-16" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-17" aria-hidden="true" tabindex="-1"></a> For build instructions please see the <a href="#cb30-18" aria-hidden="true" tabindex="-1"></a> [online documentation](https://openjdk.org/groups/build/doc/building.html), <a href="#cb30-19" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-20" aria-hidden="true" tabindex="-1"></a>$ git revert aa371b4f02c2f809eb9cd3e52aa12b639bed1ef5 <a href="#cb30-21" aria-hidden="true" tabindex="-1"></a>[master d454489052d] 8280996: [BACKOUT] Make the JDK mine Reviewed-by: duke <a href="#cb30-22" aria-hidden="true" tabindex="-1"></a> 1 file changed, 1 insertion(+), 1 deletion(-) <a href="#cb30-23" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-24" aria-hidden="true" tabindex="-1"></a>$ git show d454489052dc6ff69a21ad9c8f56b67fdeb435ee <a href="#cb30-25" aria-hidden="true" tabindex="-1"></a>commit d454489052dc6ff69a21ad9c8f56b67fdeb435ee (HEAD -> master) <a href="#cb30-26" aria-hidden="true" tabindex="-1"></a>Author: Jesper Wilhelmsson <jesper.wilhelmsson@oracle.com> <a href="#cb30-27" aria-hidden="true" tabindex="-1"></a>Date: Wed Jun 23 20:32:08 2021 +0200 <a href="#cb30-28" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-29" aria-hidden="true" tabindex="-1"></a> 8280996: [BACKOUT] Make the JDK mine <a href="#cb30-30" aria-hidden="true" tabindex="-1"></a> Reviewed-by: duke <a href="#cb30-31" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-32" aria-hidden="true" tabindex="-1"></a>diff --git a/README.md b/README.md <a href="#cb30-33" aria-hidden="true" tabindex="-1"></a>index 4961acb2126..399e7cc311f 100644 <a href="#cb30-34" aria-hidden="true" tabindex="-1"></a>--- a/README.md <a href="#cb30-35" aria-hidden="true" tabindex="-1"></a>+++ b/README.md <a href="#cb30-36" aria-hidden="true" tabindex="-1"></a>@@ -1,4 +1,4 @@ <a href="#cb30-37" aria-hidden="true" tabindex="-1"></a>-# Welcome to my modified JDK! <a href="#cb30-38" aria-hidden="true" tabindex="-1"></a>+# Welcome to the JDK! <a href="#cb30-39" aria-hidden="true" tabindex="-1"></a> <a href="#cb30-40" aria-hidden="true" tabindex="-1"></a> For build instructions please see the <a href="#cb30-41" aria-hidden="true" tabindex="-1"></a> [online documentation](https://openjdk.org/groups/build/doc/building.html),</code></pre></div> <h2 id="backing-out-a-backport">Backing out a backport</h2> In rare cases it may be necessary to back out a backport from an update release without backing out the original fix in mainline. This will require a somewhat different procedure and will result in a small mess in JBS. It’s extremely important to add comments in all relevant issues explaining exactly what’s happened. The steps to take in order to do this are described below. (M) used below refers to the main bug entry - the first fix that was later backported. <ol> <li>Close the original (failed) JBS backport issue (O). <ul> <li>“Verify” the issue and choose “Fix Failed”.</li> </ul> </li> <li>If the intention is to fix the backport and submit it again, create a redo-issue (R) to track that the work still needs to be done. <ul> <li>Clone (M) and add the prefix <code>[REDO BACKPORT]</code> on the summary - the clone becomes the redo-issue (R).</li> <li>Add a relates to link between (R) and (O).</li> <li>Set Fix Version of (R) to the target release for the backport - either the exact release if known, or <code><N>-pool</code> if it’s not critical which release the fixed backport goes into.</li> </ul> </li> <li>Create a backout-issue (B): <ul> <li>Alternative 1 - the broken backport is identified directly. <ul> <li>Create a sub-task to (R) with the same summary, but prefixed with <code>[BACKOUT BACKPORT]</code>.</li> </ul> </li> <li>Alternative 2 - an investigation issue was created (I), and during the investigation backing out the backport is identified as the best solution. <ul> <li>Use the investigation issue (I) for the backout.</li> <li>Change summary of (I) to the same as (M) and prefix with <code>[BACKOUT BACKPORT]</code>.</li> <li>Move and change type of (I) to become a sub-task of (R).</li> </ul> </li> <li>Alternative 3 - no redo issue was created. <ul> <li>Create a backout-issue (B) with the same summary as (M) and prefix with <code>[BACKOUT BACKPORT]</code>.</li> <li>Add a relates to link between (B) and (M).</li> </ul> </li> </ul> </li> <li>Add comments to (M), (R) and (O) explaining the situation.</li> </ol> The end result in JBS should look like this: <div style="text-align:center;"> <div class="figure"><img src="data:image/svg+xml;base64,<svg id="mermaid-1738190656011" width="100%" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="596" style="max-width: 434.904px; background-color: white;" viewBox="0 0 434.904296875 596"><style>#mermaid-1738190656011 {font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;fill:#000000;}#mermaid-1738190656011 .error-icon{fill:#552222;}#mermaid-1738190656011 .error-text{fill:#552222;stroke:#552222;}#mermaid-1738190656011 .edge-thickness-normal{stroke-width:2px;}#mermaid-1738190656011 .edge-thickness-thick{stroke-width:3.5px;}#mermaid-1738190656011 .edge-pattern-solid{stroke-dasharray:0;}#mermaid-1738190656011 .edge-pattern-dashed{stroke-dasharray:3;}#mermaid-1738190656011 .edge-pattern-dotted{stroke-dasharray:2;}#mermaid-1738190656011 .marker{fill:#666;stroke:#666;}#mermaid-1738190656011 .marker.cross{stroke:#666;}#mermaid-1738190656011 svg{font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;}#mermaid-1738190656011 .label{font-family:"trebuchet ms",verdana,arial,sans-serif;color:#000000;}#mermaid-1738190656011 .cluster-label text{fill:#333;}#mermaid-1738190656011 .cluster-label span{color:#333;}#mermaid-1738190656011 .label text,#mermaid-1738190656011 span{fill:#000000;color:#000000;}#mermaid-1738190656011 .node rect,#mermaid-1738190656011 .node circle,#mermaid-1738190656011 .node ellipse,#mermaid-1738190656011 .node polygon,#mermaid-1738190656011 .node path{fill:#eee;stroke:#999;stroke-width:1px;}#mermaid-1738190656011 .node .label{text-align:center;}#mermaid-1738190656011 .node.clickable{cursor:pointer;}#mermaid-1738190656011 .arrowheadPath{fill:#333333;}#mermaid-1738190656011 .edgePath .path{stroke:#666;stroke-width:2.0px;}#mermaid-1738190656011 .flowchart-link{stroke:#666;fill:none;}#mermaid-1738190656011 .edgeLabel{background-color:white;text-align:center;}#mermaid-1738190656011 .edgeLabel rect{opacity:0.5;background-color:white;fill:white;}#mermaid-1738190656011 .cluster rect{fill:hsl(0, 0%, 98.9215686275%);stroke:#707070;stroke-width:1px;}#mermaid-1738190656011 .cluster text{fill:#333;}#mermaid-1738190656011 .cluster span{color:#333;}#mermaid-1738190656011 div.mermaidTooltip{position:absolute;text-align:center;max-width:200px;padding:2px;font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:12px;background:hsl(-160, 0%, 93.3333333333%);border:1px solid #707070;border-radius:2px;pointer-events:none;z-index:100;}#mermaid-1738190656011 :root{--mermaid-font-family:"trebuchet ms",verdana,arial,sans-serif;}</style><g transform="translate(0, 0)"><marker id="flowchart-pointEnd" class="marker flowchart" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="userSpaceOnUse" markerWidth="12" markerHeight="12" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-pointStart" class="marker flowchart" viewBox="0 0 10 10" refX="0" refY="5" markerUnits="userSpaceOnUse" markerWidth="12" markerHeight="12" orient="auto"><path d="M 0 5 L 10 10 L 10 0 z" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-circleEnd" class="marker flowchart" viewBox="0 0 10 10" refX="11" refY="5" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><circle cx="5" cy="5" r="5" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></circle></marker><marker id="flowchart-circleStart" class="marker flowchart" viewBox="0 0 10 10" refX="-1" refY="5" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><circle cx="5" cy="5" r="5" class="arrowMarkerPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></circle></marker><marker id="flowchart-crossEnd" class="marker cross flowchart" viewBox="0 0 11 11" refX="12" refY="5.2" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><path d="M 1,1 l 9,9 M 10,1 l -9,9" class="arrowMarkerPath" style="stroke-width: 2; stroke-dasharray: 1, 0;"></path></marker><marker id="flowchart-crossStart" class="marker cross flowchart" viewBox="0 0 11 11" refX="-1" refY="5.2" markerUnits="userSpaceOnUse" markerWidth="11" markerHeight="11" orient="auto"><path d="M 1,1 l 9,9 M 10,1 l -9,9" class="arrowMarkerPath" style="stroke-width: 2; stroke-dasharray: 1, 0;"></path></marker><g class="root"><g class="clusters"></g><g class="edgePaths"><path d="M170.5603732638889,97L164.00669126157408,102.70833333333333C157.45300925925926,108.41666666666667,144.34564525462963,119.83333333333333,137.79196325231482,131.25C131.23828125,142.66666666666666,131.23828125,154.08333333333334,131.23828125,159.79166666666666L131.23828125,165.5" id="L-main-backport-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-main LE-backport" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M272.7404079861111,341.5L279.2940899884259,335.7916666666667C285.84777199074074,330.0833333333333,298.95513599537037,318.6666666666667,305.5088179976852,298.2916666666667C312.0625,277.9166666666667,312.0625,248.58333333333334,312.0625,219.25C312.0625,189.91666666666666,312.0625,160.58333333333334,305.5088179976852,140.20833333333334C298.95513599537037,119.83333333333333,285.84777199074074,108.41666666666667,279.2940899884259,102.70833333333333L272.7404079861111,97" id="L-redo-main-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-redo LE-main" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path><path d="M131.23828125,273L131.23828125,278.7083333333333C131.23828125,284.4166666666667,131.23828125,295.8333333333333,137.79196325231482,307.25C144.34564525462963,318.6666666666667,157.45300925925926,330.0833333333333,164.00669126157408,335.7916666666667L170.5603732638889,341.5" id="L-backport-redo-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-backport LE-redo" style="fill:none;" marker-start="url(#flowchart-pointStart)" marker-end="url(#flowchart-pointEnd)"></path><path d="M221.650390625,430.5L221.650390625,436.2083333333333C221.650390625,441.9166666666667,221.650390625,453.3333333333333,221.650390625,464.75C221.650390625,476.1666666666667,221.650390625,487.5833333333333,221.650390625,493.2916666666667L221.650390625,499" id="L-redo-backout-0" class=" edge-thickness-normal edge-pattern-solid flowchart-link LS-redo LE-backout" style="fill:none;" marker-end="url(#flowchart-pointEnd)"></path></g><g class="edgeLabels"><g class="edgeLabel" transform="translate(131.23828125, 131.25)"><g class="label" transform="translate(-51.3203125, -9.25)"><foreignObject width="102.640625" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">backported by</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(312.0625, 219.25)"><g class="label" transform="translate(-22.5859375, -9.25)"><foreignObject width="45.171875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">clones</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(131.23828125, 307.25)"><g class="label" transform="translate(-34.68359375, -9.25)"><foreignObject width="69.3671875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">relates to</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(221.650390625, 464.75)"><g class="label" transform="translate(-29.65234375, -9.25)"><foreignObject width="59.3046875" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="edgeLabel">sub-task</span></div></foreignObject></g></g></g><g class="nodes"><g class="node default default" id="flowchart-main-12" transform="translate(221.650390625, 52.5)"><rect class="basic label-container" style="" rx="5" ry="5" x="-123.23828125" y="-44.5" width="246.4765625" height="89"></rect><g class="label" style="" transform="translate(-115.73828125, -37)"><foreignObject width="231.4765625" height="74"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Main issue <b>(M)</b><br/>JDK-8272373: Example JBS Issue<br/>Issue type: Bug<br/>Fix version: 18</span></div></foreignObject></g></g><g class="node default default" id="flowchart-backport-13" transform="translate(131.23828125, 219.25)"><rect class="basic label-container" style="" rx="5" ry="5" x="-123.23828125" y="-53.75" width="246.4765625" height="107.5"></rect><g class="label" style="" transform="translate(-115.73828125, -46.25)"><foreignObject width="231.4765625" height="92.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Initial backport <b>(O)</b><br/>JDK-8280986: Example JBS Issue<br/>Issue type: Backport<br/>Fix version: 15.0.2<br/>Verification: Fix failed</span></div></foreignObject></g></g><g class="node default default" id="flowchart-backout-14" transform="translate(221.650390625, 543.5)"><rect class="basic label-container" style="" rx="5" ry="5" x="-205.25390625" y="-44.5" width="410.5078125" height="89"></rect><g class="label" style="" transform="translate(-197.75390625, -37)"><foreignObject width="395.5078125" height="74"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Backout of JDK-8280986 <b>(B)</b><br/>JDK-8280996: [BACKOUT BACKPORT] Example JBS Issue<br/>Issue type: Sub-task<br/>Fix version: 15.0.2</span></div></foreignObject></g></g><g class="node default default" id="flowchart-redo-15" transform="translate(221.650390625, 386)"><rect class="basic label-container" style="" rx="5" ry="5" x="-190.6328125" y="-44.5" width="381.265625" height="89"></rect><g class="label" style="" transform="translate(-183.1328125, -37)"><foreignObject width="366.265625" height="74"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span class="nodeLabel">Redo of backport <b>(R)</b><br/>JDK-8280989: [REDO BACKPORT] Example JBS Issue<br/>Issue type: Bug<br/>Fix version: 15.0.2</span></div></foreignObject></g></g></g></g></g></svg>" alt="" /> JBS structure after backout and redo of a backport </div> </div> For this example in JBS see the 15.0.2 backport of <a href="https://bugs.openjdk.org/browse/JDK-8272373">JDK-8272373</a>. <h3 id="rationale-for-using-this-model">Rationale for using this model</h3> The approach described here has both advantages and disadvantages. The key invariants that lead to this model are: <ul> <li>A backported by link should only refer to issues of type Backport</li> <li>A bug id should never be reused for different patches in the same repository</li> </ul> Disadvantages of this model are that the list of backports in JBS will still list the old (failed) backport as the 15.0.2 backport, and the new backport will not be linked to using a backported by link. It is assumed that the advantages above outweighs the disadvantages and that the capital letter prefixes for the backout and the redo will be visible enough in JBS to alert that something fishy is going on. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="working-with-pull-requests">Working With Pull Requests</h1> <div class="box"> Quick Links <ul> <li><a href="https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands">Skara documentation on PR commands</a></li> </ul> </div> Once you have made a change that you want to integrate into an OpenJDK code base you need to create a Pull Request (PR) on <a href="https://github.com">GitHub</a>. This section assumes that you have previous experience from using git and <a href="https://github.com">GitHub</a>, and won’t go into details of how those work. Still, the aim is of course to provide a useful guide, so <a href="#about-this-guide">send an email</a> if more details are needed. This section also assumes that you have already read <a href="#i-have-a-patch-what-do-i-do">I have a patch, what do I do?</a> and followed all the steps there. <div class="note"> Please note that the description of a change should always be in the JBS issue. The <a href="https://github.com">GitHub</a> PR can be a good place to discuss technical implementation details regarding your change, but it’s not the right place to describe the problem. Make sure you have a proper problem description in your JBS issue before publishing a PR. </div> <h2 id="think-once-more">Think once more</h2> All code reviews in OpenJDK are done in public. Once you open your PR for public review the internet can see it and comment on it. Make sure your code is ready for it. Look through your comments, make sure that temporary code is gone, and make sure you have sanitized your method and variable names. Also, make sure you understand your code. Why is it working? What are the potential pitfalls? What are the edge-cases? If you haven’t already answered all these questions in the mail conversation that preceded this PR, it’s likely that you will need to answer them during the review. It’s also worth taking the extra time to see if the change can be split into a few different separate changes. A large change will take more effort and thus attract fewer <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a>. Smaller changes will get reviewed faster and get better quality reviews. You can compare proposing a single large change to proposing ten individual small unrelated changes. What happens in practice when all these ten changes are presented as one PR is that there’s a focus on say 5-6 of these smaller changes and no one really looks hard at the other 4-5. For complexity, even small changes that are hard to understand and test may be risky. The timing of your change will also affect the availability of reviewers. The JDK runs on a <a href="#release-cycle">six-months release cadence</a>. During the months around the start of the ramp down phase most area experts will be busy working on their own changes and reviewing major features that are planned for the release. If you propose a change during this period (basically May-June, or November-December) it may take a long time before you get the required reviews. <h2 id="rebase-before-creating-the-pr">Rebase before creating the PR</h2> It’s likely that other people have integrated changes to the code base since you created your branch. Make sure to pull the latest changes and rebase your fix on top of that before creating your PR. This is a courtesy issue. Your reviewers shouldn’t have to read your patch on top of old code that has since changed. This is hopefully obvious in cases where the upstream code has gone through cleanups or refactorings, and your patch may need similar cleanups in order to even compile. But even in cases where only smaller changes have been done, the reviewers shouldn’t have to react to issues like “that line of code was moved last week, why is it back there?”. Most changes are made to the <code>master</code> branch of the mainline repository. In these cases, rebase using: <pre><code>git rebase master</code></pre> Note that if you are working on a backport to a stabilization branch you should replace <code>master</code> above with the name of the branch you are targeting. This would be the same name as when you cloned the branch. After the PR has been published, rebasing, force-pushing, and similar actions are strongly discouraged. Such actions will disrupt the workflow for reviewers who fetch the PR branch. Pushing new changes is fine (and even merging if necessary) for a PR under review. Incremental diffs and other tools will help your reviewers see what you have changed. In the end, all commits will be squashed into a single commit automatically, so there’re actually no drawbacks whatsoever to making commits to a PR branch during review. <h2 id="final-check-before-creating-the-pr">Final check before creating the PR</h2> Creating the PR is essentially the same as asking a large group of people to start reviewing your change. Before doing that, you want to make sure your change is done in every detail you have the power to control. These are a few of the things you should think about in order to avoid wasting people’s time on an unfinished change. (You may think that some of these are too obvious to even mention, but all of them are things that in the past have caused actual failures that broke the JDK for all developers out there.) <ul> <li> Is the copyright statement at the top of each modified source file correct? </li> <li> Did you run a full build and all relevant tests on the final version of the change? It’s important to do this on the truly final version, as even an apparently trivial change in a comment can break the build. </li> <li> Did you <code>git add</code> all new files? </li> <li> Did you add regression tests for your change? </li> <li> Did you run those new regression tests? </li> </ul> If you are unsure of any of these things but still want to go ahead and create the PR, don’t! If you have an actual reason to create a PR before the change is all done, make sure to create it in <code>DRAFT</code> mode. The bot won’t add the <code>rfr</code> label or send emails to labeled <a href="https://openjdk.org/bylaws#group">Groups</a> as long as the PR is in <code>DRAFT</code> mode. <h2 id="life-of-a-pr">Life of a PR</h2> <ol> <li> Make sure the PR is reviewable There are changes that span across several areas, for example wide spread cleanups or the introduction of a new language feature. Accordingly, the number of lines of code touched can be quite large, which makes it harder to review the entire PR. In such cases, it may make sense to split the change into several PRs, most commonly by grouping them by module or area. </li> <li> Make sure you target the correct branch Many project repositories have several branches. Make sure your PR targets the correct one. This is of course especially important when not targeting the default branch. At the top of your PR, right below the title, it will say “NNN wants to merge X commit(s) into [branch]”. Typical red flags to watch out for are if your PR seems to include commits or changed files that shouldn’t be part of your integration. E.g. Seeing the “Start of release updates for JDK N” when backporting something to JDK N-1 is a bad sign. </li> <li> Set a correctly formatted title The title of the PR should be of the form “<code>nnnnnnn: Title of JBS issue</code>” where <code>nnnnnnn</code> is the JBS issue id of the main JBS issue that is being fixed, and the <code>Title of JBS issue</code> is the exact title of the issue as written in JBS. In fact, the title can be set to only the JBS issue id (<code>nnnnnnn</code>) in which case the bot will fetch the title from JBS automatically. If you are creating a backport PR, see <a href="#using-the-skara-tooling-to-help-with-backports">Using the Skara tooling to help with backports</a> for more details on the title requirements. </li> <li> Write a useful description The description of the PR should state what problem is being solved and shortly describe how it’s solved. <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a> and other interested readers are referred to the text in the JBS issue for details, but the description should be enough to give an overview. This assumes there’s useful information in the JBS issue, like an evaluation etc. If not, add it. Remember that the description is included in many emails sent to lists with many receivers, so a too long description can cause a lot of noise, while of course a too short description won’t give the reader enough information to perform the review. If you have a lot of information you wish to add to your PR, like performance evaluations, you can put that in a separate comment in the PR. </li> <li> Finish the change before publishing it Each update to a published PR will result in emails being sent to all relevant lists. This is per design and it’s how we want it to be, but it also mean that if you publish a PR before you have gone through the final check mentioned above, and later find that a few more updates are necessary, a lot of people will get a lot of emails. </li> <li> Make sure all relevant <a href="https://openjdk.org/bylaws#group">Groups</a> are included The bot will make an attempt to include the <a href="https://openjdk.org/bylaws#group">Groups</a> that need to review your change based on the location of the source code you have changed. There may be aspects of your change that are relevant to other <a href="https://openjdk.org/bylaws#group">Groups</a> as well, and the mapping from source to <a href="https://openjdk.org/bylaws#group">Groups</a> isn’t always perfect, so make sure all relevant <a href="https://openjdk.org/bylaws#group">Groups</a> have been included, and add new labels using <a href="https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/label"> <code>/label</code></a> if needed. Consult the <a href="#code-owners">Code Owners</a> section if you are unsure of who owns the code you are changing. </li> <li> Allow enough time for review In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. It may actually happen that even 24 hours isn’t enough. Take into account weekends, holidays, and vacation times throughout the world and you’ll realize that a change that requires more than just a trivial review may have to be open for a while. In some areas [trivial] changes are allowed to be integrated without the 24 hour delay. Ask your reviewers if you think this applies to your change. </li> <li> Get the required reviews At least one <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> knowledgeable in each area being changed must approve every change. A change may therefore require multiple <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a> because it affects multiple areas. Some areas (e.g. Client and HotSpot) require two reviewers in most cases, so be sure to read the relevant <a href="https://openjdk.org/bylaws#group">OpenJDK Group</a> pages for advice or ask your <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a>. Be open to comments and polite in replies. Remember that the reviewer wants to improve the world just as much as you do, only in a slightly different way. If you don’t understand some comment, ask the reviewer to clarify. Accept authority when applicable. If you’re making changes in an area where you’re not the area expert, acknowledge that your reviewers may be. Take their advice seriously, even if it is to not make the change. There are many reasons <a href="#why-is-my-change-rejected">why a change may get rejected</a>. And you did read the section [Things to consider before changing OpenJDK code], right? </li> <li> Updating the PR You may need to change the code in response to review comments. To do this, simply commit new changes and push them onto the PR branch. The PR will be updated automatically. Multiple commits to the branch will be squashed into a single commit when the PR is eventually integrated. If the set of files in the PR has changed, this may affect the <a href="https://openjdk.org/bylaws#group">Groups</a> that need to review the PR. Make sure to adjust the PR labels accordingly. If you want to update the title of the PR, remember that the one and only truth is the JBS issue, so the title must first be changed there. </li> <li> Merge the latest changes If your PR is out for review for a longer time it’s a good habit to pull from the target repository regularly to keep the change up to date. This will make it easier to review the change and it will help you find issues caused by other changes sooner. Typically this involves fetching changes from the <code>master</code> branch of the main JDK repo, merging them into your local branch, resolving conflicts if necessary, and then pushing these changes to the PR branch. Pushing additional commits and merges into the PR branch is fine; they will be squashed into a single commit when the PR is integrated. Avoid rebasing changes, and prefer merging instead. If your PR is targeting some other branch than <code>master</code>, make sure to merge the correct upstream branch (the target branch). Verify that your PR doesn’t include changes from some other branch (e.g. <code>master</code>) that aren’t supposed to be there. If there are upstream changes that might affect your change, it’s likely a good idea to rerun relevant testing as well. The <a href="#github-actions">GHA testing</a> that’s done automatically by <a href="https://github.com">GitHub</a> should only be seen as a smoke test that finds the most severe problems with your change. It’s highly unlikely that it will test your actual change in any greater detail - or even at all execute the code that you have changed in most cases. </li> <li> Integrate your change When you have the required reviews and have made sure all relevant areas have had a chance to look at your change, integrate by entering the command <a href="https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate"> <code>/integrate</code></a> in a comment on the PR. If you are not yet a <a href="https://openjdk.org/bylaws#committer">Committer</a> in the <a href="https://openjdk.org/bylaws#project">Project</a>, ask your <a href="https://openjdk.org/bylaws#sponsor">Sponsor</a> to enter the command <a href="https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/sponsor"> <code>/sponsor</code></a> in the PR as well in order for your change to be allowed to be integrated. </li> <li> After integration After you have integrated your change you are expected to stay around in case there are any issues with it. As mentioned above, you are expected to have run all relevant testing on your change before integrating your PR, but regardless of how thorough you test it, things might slip through. After your change has been integrated an automatic pipeline of tests is triggered and your change will be tested on a variety of platforms and in a variety of different modes that the JDK can be executed in. A change that causes failures in this testing may be backed out if a fix can’t be provided fast enough, or if the developer isn’t responsive when noticed about the failure. Note that this directive should be interpreted as “it’s a really bad idea to integrate a change the last thing you do before bedtime, or the day before going on vacation”. </li> </ol> <h2 id="webrevs">Webrevs</h2> <div class="box"> Quick Links <ul> <li><a href="https://github.com/openjdk/webrev">Webrev Source Repository</a></li> <li><a href="https://mail.openjdk.org/pipermail/webrev-dev/">Webrev Mailing List</a></li> </ul> </div> As all <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> are hosted on <a href="https://github.com">GitHub</a>, most code reviews takes place there. When you publish a PR to an OpenJDK repository the corresponding JBS issue will get a link to the code review in the PR, making this the natural place to go for review. OpenJDK do however provide other tools and infrastructure for code reviews as well: The webrevs. Webrev refers to both the tool used to create them and its output. The script, <a href="https://github.com/openjdk/webrev/blob/master/webrev.ksh"><code>webrev.ksh</code></a>, is maintained in the <a href="../projects/code-tools">Code Tools Project</a>. Please note that this version of webrev is for use with mercurial and won’t work with the git based repositories. You don’t actually need tools like this anymore unless you want to host code reviews in other locations than <a href="https://github.com">GitHub</a>. On the GitHub reviews you will find links to webrevs. These are automatically generated by the bot and are provided as a complement for those who prefer this style of code review. Many OpenJDK developers are used to the webrevs as this was the default way to provide code for review before OpenJDK moved to <a href="https://github.com">GitHub</a>. Though webrevs are mainly deprecated today, they used to be a central part of OpenJDK development and you may still see people use the word as a synonym for code review, so they do deserve to be mentioned here as well. <h2 id="file-storage-for-openjdk-artifacts---cr.openjdk.org">File storage for OpenJDK artifacts - <code>cr.openjdk.org</code></h2> The <code>cr.openjdk.org</code> server provides storage and display of code review materials such as webrevs and other artifacts related to the OpenJDK Community. This area can also be used to store design documents and other documentation related OpenJDK but not related to any specific <a href="https://openjdk.org/bylaws#project">Project</a> that have an OpenJDK wiki space for such purposes. Any OpenJDK <a href="https://openjdk.org/bylaws#author">Author</a> can publish materials on the <code>cr.openjdk.org</code> server. Users can upload files to temporary storage using secure methods (<code>rsync</code>, <code>scp</code>, and <code>sftp</code>). This site is for open source materials related to the OpenJDK Community only. Users uploading inappropriate materials will lose access and the material will be deleted. Please review the <a href="https://openjdk.org/legal/terms.html">Terms of Use</a> before using this server. <h3 id="get-your-ssh-key-installed">Get your SSH key installed</h3> To use <code>cr.openjdk.org</code> you’ll need to get an SSH key installed. See <a href="#generating-an-ssh-key">Generating an SSH key</a> for guidance on how to generate a key. Your public key (<code>~/.ssh/id_rsa.pub</code>) should be mailed as an attachment along with your JDK username to <a href="mailto:keys@openjdk.org">keys@openjdk.org</a>. An administrator will install your key on the server and notify you on completion. This process may take a couple of days. <div class="note"> Users behind a SOCKS firewall can add a directive to the <code>~/.ssh/config</code> file to connect to the OpenJDK server: <pre><code>Host *.openjdk.org ProxyCommand /usr/lib/ssh/ssh-socks5-proxy-connect -h [socks_proxy_address] %h %p</code></pre> See the <code>ssh-socks5-proxy-connect</code> man page and <code>ssh-config</code> man page for more information. Other systems may require proxy access via other programs. Some Linux distributions provide the <code>corkscrew</code> package which provides ssh access through HTTP proxies. It’s recommended that all users check with their network administrators before installing any kind of TCP forwarding tool on their network. Many corporations and institutions have strict security policies in this area. </div> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="reviewing-and-sponsoring-a-change">Reviewing and Sponsoring a Change</h1> <div class="box"> Quick Links <ul> <li><a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews"> GitHub Docs on pull requests reviews</a></li> </ul> </div> Two of the most important contributions you can make in the OpenJDK community are to review and sponsor changes for other developers. All changes needs to be reviewed. Many changes even need to be reviewed by more than one person. This means that in order to enable a fast-pased development experience, all developers need to review more changes then they produce themself. If you are new to an area, reviewing changes is also a great way to learn the code and see what general styles and types of changes are relevant in the area. Be mindful though, if you don’t know the area well you should state this in your review comments. New developers in the OpenJDK community don’t have the permissions needed to integrate changes to the repositories. This is a feature that ensures that all developers get familiar with the code, processes, and community before being allowed to actually make changes. To get their first changes in, the new Contributor needs the help of a Sponsor. The Sponsor’s role is to offer constructive advice and eventually integrate the sponsored contribution into the repository. Sponsoring new contributions is an important activity - it’s how the engineering culture of a project gets passed on from the core group to new Contributors, from one generation to the next. Take pride in the value you provide to Contributors. Their success reflects well on you. There are many different reasons to sponsor a change and depending on the situation the exact steps involved may differ significantly. An experienced developer hired into a larger team of OpenJDK developers is likely to get much of the required information by osmosis and will likely need less help from a sponsor than the enthusiast sitting at home with no prior experience of large scale software development. This text aims to highlight the steps involved in sponsoring a change but can’t cover all possible scenarios. As always, common sense takes precedence where the assumptions made here doesn’t apply to your use case. <h2 id="responsibilities-of-a-reviewer">Responsibilities of a Reviewer</h2> As a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> you have a responsibility to make sure changes are sound and align with the general direction of the area. If you, as a <a href="https://openjdk.org/bylaws#reviewer">Reviever</a>, review a change in an area that you don’t know well you probably shouldn’t be the one to approve the change. <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a> should be aware that they take full responsibility for the appropriateness and correctness of any changes in their area of expertise. If something goes wrong (e.g., the build breaks) and the change’s author is unavailable, they may be asked to deal with the problem. Potential <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a> are encouraged to refuse to review code for which they aren’t qualified. <a href="https://openjdk.org/bylaws#reviewer">Reviewers</a> should examine not only the code being added or changed but also the relevant unit or regression tests. If no tests are being added for a change that isn’t already covered by existing tests and have the appropriate noreg- label, the <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> should question this. As a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a>, Contributors will look up to you for guidance to get their contributions into the project - your actions will determine whether Contributors will feel welcome and want to engage further with the project beyond their initial attempt, or not. Let’s not lose enthusiastic, engaged and technically competent Contributors due to a lack of communication. If you see a request in your area of expertise and you can’t address it, at least acknowledge receipt of the request and provide an estimate for when you’ll be able to give it your attention. A frank explanation of your time constraints or commitments will be appreciated and respected. <h2 id="reviewing-a-change-on-github">Reviewing a change on GitHub</h2> Code reviews in OpenJDK happens on <a href="https://github.com/openjdk">GitHub</a>. This guide will hint at the most common steps to perform a review but it’s not a complete documentation of all features. For official documentation see the <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews"> GitHub Docs</a>. When you arrive at a pull request there are a few different sections that you can browse through, Conversation, Commits, Checks, and Files changed. We will look at the first and the last of these. <h3 id="conversation">Conversation</h3> The Conversation section is where all discussion around the PR happens. Note that this section is intended for technical discussion around the actual implementation of a change. This is in general not the place to discuss the appropriateness of the change or have overarching design discussions, that should happen on the appropriate <a href="#mailing-lists">mailing lists</a>. Yes, PR comments will be sent to the mailing lists as well, but it’s unlikely that all the right people will see it. PR mails sent to the mailing lists will have a subject indicating that it’s about the specific implementation in the PR. If the discussion is larger than just about the specific implementation, for instance around the design or future of the feature, then a much larger audience needs to be made aware of the discussion. A separate email thread with a proper subject is preferred in such cases. You can either reply to existing comments by using the text field beneath each comment, or add a new comment by scrolling to the bottom of the page and use the larger text field where it says “Leave a comment”. Reviews take time for everyone involved. Your opinions are much appreciated as long as they are on-topic and of a constructive nature. A comment of the form “I don’t like this” won’t help anyone to improve the change. Instead express what it is that you don’t like and give examples of how to do it differently. Always be polite and make sure you read through all previous comments before adding your own, the answer you are looking for may already have been given. <div class="note"> Note that GitHub will collapse comments if there are many of them, and if an issue is marked as resolved. This means that you have to be observant and may have to dig around a bit to find all comments in the PR. </div> Never ask the author of a change to fix unrelated issues in the code that you find during your review. Such issues should be handled through a separate JBS issue and PR. <h3 id="files-changed">Files changed</h3> The Files changed-section is where the actual change is presented. On the left hand side there’s a list of all files changed. This is useful to get a quick overview and to see if the change touches an area that you need to review. The diff view is pretty straight forward, red stuff has been removed, green stuff has been added. You can configure (among other things) if you want a unified diff or a split view, if you want to hide whitespace changes, what types of files you want to show, and if you want to show the entire change or just what’s happened since your last review. When you hover the text in the change a blue square with a plus sign pops up to the left of the line. Click it to add a comment about the change on the corresponding line. When you create your first comment you have the option to simply add a single comment or to start a review. In general you want to start a review so that all your comments are gathered in the same context when emails are sent out etc. You can also attach a comment to a file rather than to a specific line in the file by using the speech bubble icon at the top right. When a complete file has been reviewed there’s a “viewed” checkbox at the top right that can be used to hide the files that you are done with. This is useful for changes that involve many files. Once you have looked through all the changes and added all your comments, the green button at the top right of the screen “Review changes” is used to finish your review. You can add a final comment to sum up your findings and then choose whether you just want to provide your comments, if you want to approve the changes, or request that changes are done before the change can be approved. Finally click “Submit review” to publish your thoughts. <h3 id="trivial-changes">Trivial changes</h3> A change that is small, well contained, and that makes no semantic changes can be called trivial. Typical examples are fixing obvious typos or renaming a local identifier. A trivial change can also be integrating an already-reviewed change that was missed in an earlier integration (e.g., forgot to add a file) or generated changes like a <a href="#backing-out-a-change"><code>git revert</code></a>. It’s up to the author of a change to claim that the change is trivial in the RFR, and it’s up to the <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> whether to approve such a claim. A change is trivial only if the <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a> agrees that it is. A trivial change doesn’t need to wait 24 hours before being pushed, and it only needs one <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a>, even in areas where stricter rules for integration normally apply. <h2 id="volunteering-to-sponsor-a-contribution">Volunteering to sponsor a contribution</h2> In an ideal situation opportunities to sponsor contributions occur in the OpenJDK mail lists. Since Contributors are encouraged to discuss their intended changes before they submit a patch, the ideal time to declare your sponsorship is during that initial conversation. As a Sponsor you should offer advice and collaborate with the Contributor as necessary to produce a high-quality patch. In addition to sponsoring changes to code you regularly maintain, there may be other areas where you can serve as a Sponsor. After publicly committing to sponsoring a contribution, you need to “claim the sponsorship request” in <a href="#jbs---jdk-bug-system">JBS</a> unless the Contributor already has a JBS account and can assign the bug to themself. To do that you need to perform three steps: <ul> <li>Assign the bug to yourself.</li> <li>Add a comment providing the name of the Contributor and a summary of the approach to solving the problem.</li> <li>Set the bug’s Status to In Progress.</li> </ul> If the contribution doesn’t already have an associated OpenJDK bug then create one in <a href="#jbs---jdk-bug-system">JBS</a>. It should be noted that claiming the sponsorship can take many other forms. In cases where a change has been discussed, or a starter bug has been picked up and fixed even though a sponsor hasn’t been identified yet it may be as simple as just showing up at the PR and sponsor the change once it’s been reviewed. <h2 id="responsibilities-of-a-sponsor">Responsibilities of a sponsor</h2> As a sponsor, you aren’t technically required to review the change, other Reviewers may already have looked at it or signed up to review. But it will be your name on the commit so you should do whatever you feel is needed to be comfortable with that. You may need to work with the Contributor to make any necessary changes, until you and the Contributor are satisfied with the result, and you are satisfied that the proposed contribution will pass any relevant review and testing. That may take more than one iteration in the worst case. You may also need to help out with any process or practical questions around the OCA, GitHub PRs, and specific requirements in the area or project. To integrate the change the Contributor should use the command <code>/integrate</code> on the PR as prompted by the bots. Once that is done, you as a sponsor enter the command <code>/sponsor</code> in a comment on the PR. Once the change has been integrated you may need to keep an eye out for any reported test failures and be prepared to investigate if such failures stem from the change you sponsored, and if so, work with the Contributor to resolve the issue. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="backporting">Backporting</h1> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/projects/jdk-updates/approval.html">Push approval for JDK updates</a></li> <li><a href="https://wiki.openjdk.org/display/SKARA/Backports">Skara documentation on backports</a></li> </ul> </div> Development of the latest version of the JDK often results in bug fixes that might be interesting to include in some of the JDK Update releases still being maintained or in a feature release stabilization branch. Moving a fix from a more recent release train (e.g. JDK 21) to an older release train (e.g. JDK 17) is called backporting. The guideline for what to backport into a specific release will vary over the lifetime of that release. Initially more fixes are expected to be backported as new features and large changes introduced in a mainline release stabilize. Over time the focus will shift from stabilization to keeping it stable - the release will go into maintenance mode. This means that bug fixes that require larger disruptive changes are more likely to be made in mainline and backported to more recent release trains only, and not to older release trains. Over time it’s likely that the code base will diverge between mainline and any given update release, and the cost of backporting will increase. The cost in this case is not only the effort needed to perform the actual backport, but also the cost inferred by bugs introduced by the backport. This should be taken into consideration when deciding if a change should be backported or not. For more details on how to reason around what to backport, <a href="https://mail.openjdk.org/pipermail/jdk8u-dev/2020-June/012002.html"> this email from JDK 8 Updates Project lead Andrew Haley</a> has some guidelines for JDK 8u. The reasoning in this mail is specific to JDK 8u, but will in general apply to any JDK release in maintenance mode. Any change that originally required a CSR will require a new CSR to be backported unless the backport was covered by the initial CSR. Changes to Java SE specifications cannot be made in an update release without a Java SE Maintenance Release. CSR-related issues affect interfaces and behavior and must be very carefully scrutinized. <h2 id="backporting-to-a-feature-release-stabilization-branch"> Backporting to a feature release stabilization branch</h2> During ramp down of a feature release there are two branches of the mainline repository in play, the release stabilization branch for the outgoing release, and the <code>master</code> branch where the next release is being developed. Any change going into the release stabilization branch is likely to be desired in <code>master</code> as well. When making a change intended for both the stabilization branch and <code>master</code>, you should always create your pull request targeting <code>master</code> first, and then, once the pull request is integrated, backport the resulting commit to the release stabilization branch. For bug fixes that are only applicable to the release stabilization branch, regular pull requests targeting the stabilization branch should be created. Please note that special rules applies during ramp down regarding what can and can’t be included into the stabilization branch. See the <a href="#the-jdk-release-process">The JDK Release Process</a> for more information. <h2 id="backporting-multiple-related-changes">Backporting multiple related changes</h2> Ideally fixes should not be backported until there has been enough time for any regressions or follow-on issues to have been identified. Then, when looking to backport a fix the developer should look for both blocked by and causes links in order to understand the complete set of fixes that should be backported. When backporting a number of changes that are dependent on each other, like a change with a tail of bug fixes, it can sometimes seem attractive to merge all those commits into a single change to avoid backporting a broken change. Please don’t. The general recommendation is to backport each commit individually. There are several reasons for this recommendation. If, for instance, there are other changes between the original one and the followup fix(es) there may be a dependency on other changes that are unrelated to the issue itself. By merging the original change, the fix(es), and the unrelated changes to meet the dependency, a single very different change is created. It’s unlikely that this change will match the description in the single JBS issue used for the merged backport. Backporting each commit individually will preserve the git history and make it easy to figure out what has actually been backported. Testing each individual change is more likely to find issues than just testing the single merged change. It’s also easier and less error prone to use the <code>/backport</code> command on each commit instead of manually cherrypick and deal with the merges etc. And finally, if backporting each commit individually, the JBS records will clearly indicate that the followup changes have been backported as well. This is important as there is tooling that verifies that everything is done in the right way. That tooling will be confused if it can’t deduct from JBS what has happened. <h2 id="working-with-backports-in-jbs">Working with backports in JBS</h2> <div class="box"> Terminology Main issue - The top issue in a backport hierarchy. Eg. <a href="https://bugs.openjdk.org/browse/JDK-8272373">JDK-8272373</a> is a main issue, while <a href="https://bugs.openjdk.org/browse/JDK-8277498">JDK-8277498</a> and <a href="https://bugs.openjdk.org/browse/JDK-8277499">JDK-8277499</a> are backport issues of this main issue. </div> <div style="text-align:center;"> <div class="figure"><img src="data:image/svg+xml;base64,<svg id="mermaid-1738190657102" width="100%" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="161.5" style="max-width: 313.453px; background-color: white;" viewBox="0 0 313.453125 161.5"><style>#mermaid-1738190657102 {font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;fill:#000000;}#mermaid-1738190657102 .error-icon{fill:#552222;}#mermaid-1738190657102 .error-text{fill:#552222;stroke:#552222;}#mermaid-1738190657102 .edge-thickness-normal{stroke-width:2px;}#mermaid-1738190657102 .edge-thickness-thick{stroke-width:3.5px;}#mermaid-1738190657102 .edge-pattern-solid{stroke-dasharray:0;}#mermaid-1738190657102 .edge-pattern-dashed{stroke-dasharray:3;}#mermaid-1738190657102 .edge-pattern-dotted{stroke-dasharray:2;}#mermaid-1738190657102 .marker{fill:#666;stroke:#666;}#mermaid-1738190657102 .marker.cross{stroke:#666;}#mermaid-1738190657102 svg{font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:16px;}#mermaid-1738190657102 .label{font-family:"trebuchet ms",verdana,arial,sans-serif;color:#000000;}#mermaid-1738190657102 .cluster-label text{fill:#333;}#mermaid-1738190657102 .cluster-label span{color:#333;}#mermaid-1738190657102 .label text,#mermaid-1738190657102 span{fill:#000000;color:#000000;}#mermaid-1738190657102 .node rect,#mermaid-1738190657102 .node circle,#mermaid-1738190657102 .node ellipse,#mermaid-1738190657102 .node polygon,#mermaid-1738190657102 .node path{fill:#eee;stroke:#999;stroke-width:1px;}#mermaid-1738190657102 .node .label{text-align:center;}#mermaid-1738190657102 .node.clickable{cursor:pointer;}#mermaid-1738190657102 .arrowheadPath{fill:#333333;}#mermaid-1738190657102 .edgePath .path{stroke:#666;stroke-width:2.0px;}#mermaid-1738190657102 .flowchart-link{stroke:#666;fill:none;}#mermaid-1738190657102 .edgeLabel{background-color:white;text-align:center;}#mermaid-1738190657102 .edgeLabel rect{opacity:0.5;background-color:white;fill:white;}#mermaid-1738190657102 .cluster rect{fill:hsl(0, 0%, 98.9215686275%);stroke:#707070;stroke-width:1px;}#mermaid-1738190657102 .cluster text{fill:#333;}#mermaid-1738190657102 .cluster span{color:#333;}#mermaid-1738190657102 div.mermaidTooltip{position:absolute;text-align:center;max-width:200px;padding:2px;font-family:"trebuchet ms",verdana,arial,sans-serif;font-size:12px;background:hsl(-160, 0%, 93.3333333333%);border:1px solid #707070;border-radius:2px;pointer-events:none;z-index:100;}#mermaid-1738190657102 :root{--mermaid-font-family:"trebuchet ms",verdana,arial,sans-serif;}</style><g><g class="output"><g class="clusters"></g><g class="edgePaths"><g class="edgePath LS-main LE-backport1" id="L-main-backport1" style="opacity: 1;"><path class="path" d="M127.71522707359813,46.5L119.11229860299845,52.208333333333336C110.50937013239876,57.916666666666664,93.30351319119939,69.33333333333333,84.7005847205997,80.75C76.09765625,92.16666666666667,76.09765625,103.58333333333333,76.09765625,109.29166666666667L76.09765625,115" marker-end="url(#arrowhead10)" style="fill:none"></path><defs><marker id="arrowhead10" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g><g class="edgePath LS-main LE-backport2" id="L-main-backport2" style="opacity: 1;"><path class="path" d="M185.73789792640187,46.5L194.34082639700156,52.208333333333336C202.94375486760123,57.916666666666664,220.1496118088006,69.33333333333333,228.75254027940034,80.75C237.35546875,92.16666666666667,237.35546875,103.58333333333333,237.35546875,109.29166666666667L237.35546875,115" marker-end="url(#arrowhead11)" style="fill:none"></path><defs><marker id="arrowhead11" viewBox="0 0 10 10" refX="9" refY="5" markerUnits="strokeWidth" markerWidth="8" markerHeight="6" orient="auto"><path d="M 0 0 L 10 5 L 0 10 z" class="arrowheadPath" style="stroke-width: 1; stroke-dasharray: 1, 0;"></path></marker></defs></g></g><g class="edgeLabels"><g class="edgeLabel" transform="translate(76.09765625,80.75)" style="opacity: 1;"><g transform="translate(-68.09765625,-9.25)" class="label"><rect rx="0" ry="0" width="136.1953125" height="18.5"></rect><foreignObject width="136.1953125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-main-backport1" class="edgeLabel L-LS-main' L-LE-backport1">backport to JDK 17</span></div></foreignObject></g></g><g class="edgeLabel" transform="translate(237.35546875,80.75)" style="opacity: 1;"><g transform="translate(-68.09765625,-9.25)" class="label"><rect rx="0" ry="0" width="136.1953125" height="18.5"></rect><foreignObject width="136.1953125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;"><span id="L-L-main-backport2" class="edgeLabel L-LS-main' L-LE-backport2">backport to JDK 11</span></div></foreignObject></g></g></g><g class="nodes"><g class="node default" id="flowchart-main-7" transform="translate(156.7265625,27.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-55.62890625" y="-19.25" width="111.2578125" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-45.62890625,-9.25)"><foreignObject width="91.2578125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">JDK-8272373</div></foreignObject></g></g></g><g class="node default" id="flowchart-backport1-8" transform="translate(76.09765625,134.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-55.62890625" y="-19.25" width="111.2578125" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-45.62890625,-9.25)"><foreignObject width="91.2578125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">JDK-8277498</div></foreignObject></g></g></g><g class="node default" id="flowchart-backport2-9" transform="translate(237.35546875,134.25)" style="opacity: 1;"><rect rx="5" ry="5" x="-55.62890625" y="-19.25" width="111.2578125" height="38.5" class="label-container"></rect><g class="label" transform="translate(0,0)"><g transform="translate(-45.62890625,-9.25)"><foreignObject width="91.2578125" height="18.5"><div xmlns="http://www.w3.org/1999/xhtml" style="display: inline-block; white-space: nowrap;">JDK-8277499</div></foreignObject></g></g></g></g></g></g></svg>" alt="" /> Example of backport hierarchy </div> </div> In general there’s no need to create backport issues in JBS manually. All work that’s done in JBS in preparation for a backport (requesting approvals etc) is done in the main issue. The backport issue will be created automatically by the bots when you integrate the change to the source code repository. There can be cases where it’s desirable to create a backport issue before the fix is done, e.g. if a CSR needs to be filed. In these cases set the Fix Version/s of the backport to <code>N</code> or <code>N-pool</code>, where <code>N</code> is the release train the backport is targeting. E.g. <code>17-pool</code>. Please note that even if a backport issue is created ahead of time, all work done in JBS for approvals and similar is still done in the main issue. Obviously it’s possible to set the Fix Version/s to the exact release the backport is targeting, but in general this isn’t recommended unless you are targeting a feature release in ramp down. When a change is integrated to an update release repository, the bots will look at the main issue as indicated in the PR title, and look for backports with the current <code>N.0.x</code> release version as Fix Version/s, if no such backport is found they will look for <code>N-pool</code>, and if that isn’t found either, a new backport issue will be created. This means that if the backport has an exact Fix Version/s set, but is delayed and misses the release indicated by this Fix Version/s, a new, superfluous backport issue is created with a small mess as the result. (See <a href="#how-to-fix-an-incorrect-backport-creation-in-jbs">How to fix an incorrect backport creation in JBS</a>.) Setting the Fix Version/s of a backport targeted to an update release to <code>N</code> is always wrong. JDK <code>N</code> has already been released (or it wouldn’t be an update release) and can’t get any more fixes. <h2 id="requesting-approvals-for-backports">Requesting approvals for backports</h2> In order to be allowed to integrate a change to one of the OpenJDK update development repositories (e.g. <a href="https://github.com/openjdk/jdk17u-dev"><code>jdk17u-dev</code></a>), an approval is required. The <a href="https://openjdk.org/projects/jdk-updates/approval.html">official process for how to request push approval for a backport</a> describes in detail how to work with JBS when requesting approvals. In short, there’s a label jdk<release>u-fix-request that should be added to the main JBS issue. Also put a motivation as to why the issue needs to be backported as a comment in the main issue. Once the label and motivation has been added, wait for the maintainers of the release to approve your request. The approval will be indicated with a label, jdk<release>u-fix-yes, added to the main issue. If the update release is in ramp down, changes are integrated to the release repository (e.g. <a href="https://github.com/openjdk/jdk17u"><code>jdk17u</code></a>). During ramp down the bar to get changes in is significantly higher and fixes need to be approved with jdk<release>u-critical-request / jdk<release>u-critical-yes. If your request to backport a change is denied, but you for some reason already created the backport issue in JBS (why?!), the backport issue should be closed as Won’t Fix. <h2 id="using-the-skara-tooling-to-help-with-backports">Using the Skara tooling to help with backports</h2> The Skara tooling includes support for backports. <a href="https://wiki.openjdk.org/display/SKARA/Backports">The official Skara documentation</a> describes in detail how to work with the tooling to create backport PRs on <a href="https://github.com">GitHub</a> or using the CLI tools. As described in the documentation, the <a href="https://wiki.openjdk.org/display/SKARA/Commit+Commands#CommitCommands-/backport"> <code>/backport</code></a> command can be used on a commit or a PR to create the backport PR: <pre><code>/backport jdk21u-dev /backport jdk jdk23 /backport :jdk23</code></pre> In the first example we backport the change to the JDK 21 update release. To backport to other update releases, replace <code>jdk21u</code> with the corresponding name for the target update repository. The second and third example above will backport the change to a stabilization branch, in this case JDK 23. As before <code>jdk</code> is the name of the target repository, and <code>jdk23</code> is the name of the stabilization branch. Using the <code>/backport</code> command is the recommended way to perform backports as the tooling will automatically handle all the necessary steps in the background. If a backport PR is manually created, set the PR title to <code>Backport <original commit hash></code>. This ensures that the bots will recognize it as a backport as opposed to a main fix specifically targeting an older release. One can tell whether or not the bots recognized a PR as a backport by the backport label being added if it’s recognized. <h2 id="how-to-fix-an-incorrect-backport-creation-in-jbs">How to fix an incorrect backport creation in JBS</h2> If an issue is targeted to a release and a fix referring to that issue is integrated to a different release repository, then a backport issue is automatically created in JBS. Usually this is a “good thing”, e.g., when you are backporting a fix to an earlier release, but not always… If the main issue is targeted to a later release (due to schedule planning) but someone finds the time to fix that issue in the current release, or if the main issue is targeted to a feature release in ramp down and the fix is integrated to the master branch, then the issue should be retargeted to the correct release before integrating the fix. However, sometimes we forget. Here’s how to fix that: <div class="note"> In this example a fix was integrated to JDK N+1 (the mainline master branch) while the JBS bug was targeted to JDK N (a feature release in ramp down). The same procedure can be used in the opposite situation, when a fix has been integrated to JDK N when the JBS bug was targeted to JDK N+1, by switching N and N+1 below. Remember, to keep the record clean for the future, what matters the most is that the bug id used in the commit comment is the main bug, and that the “backports” (regardless of if they are to earlier or later releases) are Backport type issues of that main issue. Also make sure there are never more than one Backport issue of the same main issue targeted to any given release. </div> <ol> <li> Reopen the backport issue that was created automatically <ul> <li>Use a comment like the following (in the reopen dialog):</li> </ul> <pre><code>This change was integrated while the main issue was targeted to 'N'. The main issue has been reset to fixed in 'N+1', this backport issue has been reset to fix in 'na' and closed as Not An Issue to avoid confusion.</code></pre> <ul> <li>Change the Fix Version/s from ‘N+1’ to ‘na’.</li> <li>Close the backport issue as Not an Issue. Note: Closed, not Resolved</li> </ul> Even if you intend to backport the issue from ‘N+1’ to ‘N’ you shouldn’t reuse this backport issue. The existing (bad) push notification comment and the later to be added correct push notification comment will look very similar and it’s just a disaster waiting to happen to deliberately add these to the same issue. </li> <li> Clean up the main issue <ul> <li>Copy the push notification comment from the backport issue to the main issue, e.g.:</li> </ul> <pre><code>Changeset: 12345678 Author: Duke <duke@openjdk.org> Date: 2020-10-23 15:37:46 +0000 URL: https://git.openjdk.org/jdk/commit/12345678</code></pre> <ul> <li>Add a comment like the following to the main issue:</li> </ul> <pre><code>This change was integrated to 'N+1' while this main issue was targeted to 'N'. This issue has been reset to fixed in 'N+1' and the Robo Duke entry was copied here.</code></pre> <ul> <li>Reset the main issue Fix Version/s from ‘N’ to ‘N+1’.</li> <li>Resolve the main issue as Fixed in build “team” or in build “master” depending on where the fix was integrated - or to an actual build number if the change has already made it to a promoted build (look in the backport issue if you are unsure). Integrations to ‘openjdk/jdk’ are fixed in build “master” and integrations to other Project repositories are fixed in build “team”.</li> </ul> </li> </ol> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="release-notes">Release Notes</h1> <div class="box"> Quick Links <ul> <li><a href="https://www.oracle.com/java/technologies/javase/jdk-relnotes-index.html"> JDK Release Notes</a></li> <li><a href="#release-note">release-note label description</a></li> <li><a href="https://spec.commonmark.org/current/">CommonMark Spec</a></li> <li><a href="https://spec.commonmark.org/dingus/">dingus</a></li> </ul> </div> Release notes for a product such as the JDK are part of the release deliverables providing a way to highlight information about a fix, such as when it may have changed behavior, or when it’s decided not to fix something. While what should go into a release note isn’t something that can be precisely defined, it should describe changes that are important for a user to take into account when they are upgrading to the specific version. While release notes should not duplicate information in other documents, they can serve to highlight that a change has been made. Release notes are associated with a JBS issue that has been fixed (or in some cases not been fixed) in a release and are generated with each build of a release. Any note should be considered as an integral part of the fix process, rather than waiting until the end of the release to determine what to write. In OpenJDK, release notes are currently being generated for the JDK and JDK Updates Projects. <h2 id="writing-a-release-note">Writing a release note</h2> Writing the release note is the responsibility of the engineer who owns the issue. The note should be generated before the fix is reviewed, or in the case of known issues, when it’s determined that a fix won’t be possible in the release the issue was found in. When writing a release note, be prepared for rather picky review comments about grammar, typos, and wording. This is for the sake of the Java community as a whole, as the language of the release note sets the tone for many blogs and news articles. For a widely used product like the JDK, the release notes are often copied verbatim (including typos) and published to highlight news in the release. This means that we need to take extra care to make sure the text in the release note is correct and follows a similar style. The release note itself is written in a <a href="#jbs---jdk-bug-system">JBS</a> sub-task of the issue that is used to integrate the change. There are a few steps to follow for the release note to find its way from JBS to the actual release note document. <ol> <li> Create a sub-task (More → Create Sub-Task) for the issue that requires a release note - the main issue, that is, the JBS issue that is used to integrate the original change, not for backports or the CSR (if there is one). </li> <li> For the newly created sub-task, follow these steps: <ul> <li>While the Priority of the sub-task is set by default to be the same as the priority of the issue itself, it can be changed to adjust in what order the release note is listed compared to other release notes in the same build or release note section.</li> <li>Set the Assignee to the same person who owns the main issue.</li> <li>The Summary should be a one sentence synopsis that is informative (and concise) enough to attract the attention of users, developers, and maintainers who might be impacted by the change. It should succinctly describe what has actually changed, not be the original bug title, nor describe the problem that was being solved. It should read well as a sub-section heading in a document.</li> <li>Prefix the Summary with “Release Note:”.</li> <li>Enter the text of the release note in the Description field using markdown formatting, following the <a href="https://spec.commonmark.org/current/">CommonMark specification</a>. While the markdown won’t be rendered in JBS, you can use <a href="https://spec.commonmark.org/dingus/">dingus</a> to see what the release note will look like. Note that <a href="https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-tables"> Github style ascii table formatting</a> is supported but will not display correctly in the dingus page. For more information see <a href="#general-conventions-for-release-notes">General Conventions for Release Notes</a> below.</li> <li>Set Component/s and Subcomponent to the same values as the original bug.</li> <li>Set Affects Version/s to the release versions for which the release note should be published.</li> <li>Add the release-note label. This is required for the release note to be included in the release notes.</li> <li>Add the proper RN-label if applicable to indicate what section of the release notes it should be included in (see <a href="#rn-labels">RN-labels</a> below).</li> <li>Set the Fix Version/s to the same value that the main issue - in almost all cases this will be the version of mainline.</li> </ul> </li> <li> Have the release note ready to be reviewed at the same time as the code is reviewed. If it’s later determined that a release note is necessary, then go back to the same engineers who reviewed the fix to review the release note. Special care should be taken when writing a release note that will cover changes related to a vulnerability fix in order to avoid describing technical details of how it could have been exploited. </li> <li> When you are done, Resolve the release note sub-task as <code>Delivered</code>. Only release notes where the sub-task has been resolved as <code>Delivered</code> is considered to be part of the EA/GA release notes. To avoid mixing up the release notes with the code fixes that have gone into a particular release or build, we don’t use <code>Resolved/Fixed</code>. </li> </ol> If you see an issue you feel should have a release note but you are not the assignee of the bug, then add the label release-note=yes to the main bug (not on a backport nor a sub-task). This acts as a flag to make sure that the release note is considered. This can be done even with fixes that have been shipped already if it’s noticed that there is confusion around the change. If, after discussion, it’s decided that a release note isn’t required either remove the label, or change it to release-note=no if it makes sense to have a clear indication that a release note isn’t required for the fix. The label release-note=yes can be removed once the release note sub-task has been created. For examples of well written release note issues in JBS, see <a href="https://bugs.openjdk.org/browse/JDK-8276929">JDK-8276929</a> or <a href="https://bugs.openjdk.org/browse/JDK-8278458">JDK-8278458</a>. <h2 id="general-conventions-for-release-notes">General conventions for release notes</h2> The following are general practices that should be followed when creating release notes. <ul> <li> Release notes should be no longer than 2-3 paragraphs. </li> <li> Don’t repeat information that will be included in updates to the docs, keep it to a high level summary or key changes. </li> <li> Note that where the changes are more fully documented in the JDK documentation, then refer to that document for details. When covering a change in behavior provide some idea to what can be done if a developer or user encounters problems from the change. </li> <li> Don’t include graphics etc. Refer to the main docs if there are more details that need explaining. </li> <li> Don’t include your name or affiliation, make sure however, you are the assignee of the release note sub-task. </li> <li> If you have a < in the Summary then use <code>&lt;</code>. For <’s in the Description surround them by back-ticks. </li> <li> Avoid using Latin and abbreviations in the release note. <ul> <li>Use “also known as” instead of “aka”</li> <li>Use “that is” or “to be specific” instead of “i.e.”</li> <li>Use “for example” instead of “e.g.”</li> </ul> </li> <li> The Summary should be in title case instead of sentence case. <ul> <li>Example: Decode Error with Tomcat Version 7.x</li> </ul> </li> <li> The Description should be standardized to follow this pattern: <ul> <li>Sentence stating the change that was made</li> <li>Background info/context</li> <li>Example: A new system property, <code>jdk.disableLastUsageTracking</code>, has been introduced to disable JRE last usage tracking for a running VM.</li> </ul> </li> </ul> <h2 id="advanced-options">Advanced options</h2> <ul> <li>JEP release notes <ul> <li>Summary - If the change is an actual JEP, use the JEP title.</li> <li>Description - the JEP Summary text have already been heavily reviewed and also approved by the Project lead. It should be the first sentence in the release note description. That would be analogous to the “change that was made” sentence in other release note descriptions. The remaining text would be composed of the background info from the JEP.</li> <li>Description - The JEP release note description should contain the link to the JEP.</li> </ul> </li> <li>Single release note for multiple changes <ul> <li>A link to the parent issue that the note is a sub-task of, will be placed alongside the summary in the release notes. If note relates to additional changes, then add them as Relates links to the note and add the label RN-MultipleLinks - see <a href="https://bugs.openjdk.org/browse/JDK-8284975">JDK-8284975</a> as an example.</li> </ul> </li> <li>Multiple release notes for the same change <ul> <li>If more than one release note is required for the same set of fixes, then open additional sub-tasks with the same Affects Version - see <a href="https://bugs.openjdk.org/browse/JDK-8073861">JDK-8073861</a> as an example.</li> </ul> </li> <li>Release notes across backports <ul> <li>If an issue is backported to earlier releases the same note will be used - just add the new release version in the Affects Version field of the release note.</li> <li>Where a different release note is required, then create a separate note with the Affects Version for the new release - see <a href="https://bugs.openjdk.org/browse/JDK-8308194">JDK-8308194</a> and <a href="https://bugs.openjdk.org/browse/JDK-8322473">JDK-8322473</a> for an example.</li> </ul> </li> </ul> <h2 id="rn-labels">RN-labels</h2> Unless labeled otherwise it will be assumed that the release note documents a change in behavior (will have likely required a CSR) or other item which should be included in the release notes. If the note covers a more specific type of change, then one of the following labels can be included (notes of a similar type will be listed together). <dl> <dt>RN-NewFeature</dt> <dd>A new feature or enhancement in the release. The Summary must be the item/API or new functionality. The Description must contain the name of the new feature, its intended function, and how a user can utilize it. Example: <a href="https://bugs.openjdk.org/browse/JDK-8315443">JDK-8315443</a></dd> <dt>RN-IssueFixed</dt> <dd>A significant issue which has been fixed. This would normally be a regression or an issue which was unknowingly released in a new feature. The Summary must be a summary of the error that was fixed. The Description must contain a statement about what was fixed, how the fix effects the user, and any special conditions that a user should be aware of regarding the fix. Example: <a href="https://bugs.openjdk.org/browse/JDK-8184172">JDK-8184172</a></dd> <dt>RN-KnownIssue</dt> <dd>An issue that wasn’t possible to fix by the time the release was GA’d. The Summary must be a summary of the error that the user sees. The Description must contain details about the error, how it effects the user, and workarounds if any exist. Example: <a href="https://bugs.openjdk.org/browse/JDK-8191040">JDK-8191040</a></dd> <dt>RN-Removed</dt> <dd>Only for major releases. The release note covers an API, feature, tool etc. which has been removed from the JDK. The Summary must be of the form “Removal of” Item/API. The Description must contain the list or name of the removed items/API with (optional) the reason for its removal. Include any special conditions that a user should be aware of regarding the removal. Example: <a href="https://bugs.openjdk.org/browse/JDK-8185066">JDK-8185066</a></dd> <dt>RN-Deprecated</dt> <dd>Only for major releases. The release notes cover an API, feature, tool etc. that has been marked as deprecated in the release. The Summary must be of the form “Deprecated” Item/API. The Description must contain the name of the item that has been deprecated, the reason for its deprecation, and (optional) any special conditions that a user should be aware of regarding the possible future removal. Example: <a href="https://bugs.openjdk.org/browse/JDK-8179909">JDK-8179909</a></dd> <dt>RN-Important</dt> <dd>Used to indicate that the release note should be highlighted in some fashion, such as listing it at the beginning of the release notes.</dd> <dt>RN-(distro)</dt> <dd>Used to indicate that the release note is only relevant for a specific JDK distribution. E.g. RN-Oracle</dd> <dt>RN-MultipleLinks</dt> <dd>Used to indicate that the release note should refer to multiple changes - see <a href="#advanced-options">Advanced options</a> section.</dd> <dt><del>RN-Change</del></dt> <dd>Deprecated. This is the default and no label is needed to indicate this.</dd> </dl> <h2 id="querying-the-release-notes">Querying the release notes</h2> The Release Notes for a particular release can be found using the JBS query <pre><code>affectedversion = <version> and type = sub-task and labels = release-note</code></pre> where <code><version></code> is the appropriate release value, e.g. 17. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="the-jdk-release-process">The JDK Release Process</h1> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/jeps/3">JEP 3: JDK Release Process</a></li> </ul> </div> The JDK Project has a well defined release process. <a href="https://openjdk.org/jeps/3">JEP 3</a> describes this process in detail. This section intends to clarify some topics that often cause questions. <h2 id="release-cycle">Release cycle</h2> The release cycle starts when development of a new release begins, and ends when that release is delivered to the public. The current release cadence is six months. This means that every six months we start development of a new release, and every six months a new release is delivered. However, this doesn’t mean that each release cycle is six months. As described below, the total development time for a release (the release cycle) is actually nine months. Obviously this in turn doesn’t mean that all features are developed in nine months. Most features are developed for a much longer time than that, and goes through long time development in other Project repositories, and through a series of preview and experimental stages. But any feature that is to be included in a specific release has a specific window of nine months to integrate the code into mainline and fix all the remaining bugs. It may be tempting to integrate a new feature near the end of a release cycle, to get more time to fix all those last bugs before integration. Please don’t. If you are getting close to the end of a release and you still just have one more bug to fix, please defer your feature to the next release. It’s only six months out. Not only will this vouch for your new feature to be more stable on release, you will also help keeping the JDK as a whole more stable by allowing others to find and fix bugs in their new code that might come as a result of your changes. Integrating early in a release is preferable, but all new features can’t be integrated at the same time. If many large changes enters the repository at the same time it will be more difficult to determine which change that caused all the new bugs. If you’re about to integrate a larger change you must therefore communicate this on the relevant <a href="#mailing-lists">mailing lists</a> to synchronize with other Projects that may also be planning to integrate something soon. <h2 id="milestones-and-phases">Milestones and phases</h2> Throughout the release there are a number of milestones and phases that define where in the release cycle we are. <dl> <dt>The start of a release</dt> <dd>Since development is always ongoing in the master branch of the mainline repository (<a href="https://github.com/openjdk/jdk">openjdk/jdk</a>), the start of a new release can be said to be when the former release is branched for stabilization. After the start of the release follows six months of development to implement and integrate all the cool stuff that will go into the next release. After these six months ramp down begins.</dd> <dt>Ramp Down Phase 1 (RDP1)</dt> <dd>The ramp down of a release starts with a new branch being created (the stabilization branch) from the master branch in the mainline repository. During the ramp down of a release we focus on bug fixing and stabilization in order to get the JDK ready for release. In RDP1 you may continue to fix P1-P3 product bugs (and some other issues) in the stabilization branch. For detailed information on what can be fixed when, see <a href="#push-or-defer-during-ramp-down">Push or defer during ramp down</a> below. The start of RDP1 is essentially the deadline for integrating JEPs and enhancements into a particular release.</dd> <dt>All Tests Run (ATR)</dt> <dd>ATR is not a milestone described in JEP 3, but it’s still a concept that might be mentioned in discussions on this topic and is therefore good to know about. ATR (a.k.a. ATR Start) is the start of an approximately six week long test period where all tests in the test plan for the given release is ran. ATR usually starts at the same time as RDP1.</dd> <dt>Ramp Down Phase 2 (RPD2)</dt> <dd>In RDP2 the bar is higher to get changes into the release. For product bugs, only P1:s and P2:s are supposed to be fixed here, and to do so an approval is needed. See the <a href="https://openjdk.org/jeps/3#Fix-Request-Process">Fix-Request Process</a> for details on how to obtain one. All other product bugs should be deferred. See <a href="#push-or-defer-during-ramp-down">Push or defer during ramp down</a> below for more details.</dd> <dt>Release Candidate (RC)</dt> <dd>Towards the end of the release cycle, when there are no more open product bugs targeted to the release, a stable build is selected to be the release candidate. This build will go through additional testing and if no more issues are found it will be the build released. If new bugs are found these are investigated and hopefully fixed, and a new build becomes the release candidate. The RC phase has a few milestones with a deadline for finding a candidate build, and another for making sure the build is ready to go live.</dd> <dt>General Availability (GA)</dt> <dd>This is the end of the release cycle. The last release candidate build is made available to the public.</dd> </dl> <h3 id="push-or-defer-during-ramp-down">Push or defer during ramp down</h3> <a href="https://openjdk.org/jeps/3">JEP 3</a> contains the exact definitions for what can be done when. This is a visualization of those definitions that may or may not clarify things. <div class="figure"><img src="push-defer.png" alt="" /> Push and defer guidelines during ramp down </div> <h3 id="deferring-p1-and-p2-bugs">Deferring P1 and P2 bugs</h3> Even though there’s nothing explicitly written in the process about deferring P1 and P2 bugs during the initial development phase, the assumption is that these aren’t deferred unless time runs out at the end of the release cycle. Please note that the priority of a bug doesn’t change just because you want to get your fix in late in the release, or if you want to be able to defer it. The priority is based on the severity of the bug and if it was deemed to be a P2 before, you better have a really good explanation to why that conveniently has changed by the end of the release. Being hard to fix is not a reason to lower the priority of a bug. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="project-maintenance">Project Maintenance</h1> Many <a href="https://openjdk.org/bylaws#project">OpenJDK Projects</a> build on top of the JDK source code for instance to produce new language features, like Projects <a href="https://openjdk.org/projects/amber/">Amber</a> and <a href="https://openjdk.org/projects/valhalla/">Valhalla</a>. When doing this there are a number of common workflows that are dealt with by most Project maintainers. For instance, updating the codebase (merging) to bring in the latest changes from the upstream JDK Project. <h2 id="merging-jdk-mainline-into-a-project-repository">Merging JDK mainline into a Project repository</h2> Merging changes from one git repository to another is basically the same thing as getting your own changes merged into the Project repository, with the slight twist that you don’t write all the changes yourself, you just pull them from somewhere else. In this example we’ll use a separate clone of the Project repository to perform the merge in. This can be done using branches as well, but let’s keep it simple for now. <h3 id="init---done-once">Init - done once</h3> First set up your personal fork of the Project repository, in this example called <code>my-project</code>. If you already are a <a href="https://openjdk.org/bylaws#contributor">Contributor</a> to the <a href="https://openjdk.org/bylaws#project">Project</a> you most likely have this set up. If not, see <a href="#cloning-the-jdk">Cloning the JDK</a> for details on how to do that. <pre class="shell"><code>git clone git@github.com:OpenDuke/my-project.git project-merge cd project-merge git remote add upstream git@github.com:openjdk/my-project.git git remote add mainline git@github.com:openjdk/jdk.git</code></pre> We clone the personal fork (in this case we clone OpenDuke’s personal fork) into a local directory, here called <code>project-merge</code>. We then set up two remotes, <code>upstream</code> and <code>mainline</code>. <h3 id="performing-the-merge">Performing the merge</h3> The clone we set up above is used each time you want to bring changes from mainline in to your <a href="https://openjdk.org/bylaws#project">Project</a>. This is done by first pulling the changes from mainline and then pushing to your personal fork. A regular PR will then be created which you can integrate into your main Project repository. It sounds easy, and it is, but there are a few details below to keep in mind. <pre class="shell"><code>cd project-merge git pull upstream master git push git switch -c Merge_mainline git fetch mainline</code></pre> We start by updating the local fork with the latest changes from the main Project repository. Note that we then create a new branch “<code>Merge_mainline</code>” in which the merge will happen. Finally we fetch all new changes from mainline. Merging from what ever is latest isn’t usually a good idea, mainline code is not “clean” for any given commit. Merging JDK tags ensures you have a known quality, those tagged commits are known to compile and pass tests. Therefore, next we check which tags have not been merged yet. <pre class="shell"><code>git tag -l "jdk-*" --no-merged</code></pre> Or if you just want to see the latest tag you haven’t merged, <pre class="shell"><code>git tag -l "jdk-*" --no-merged | tail --lines 1</code></pre> Before merging, you may want to check what’s incoming, to get an idea of the size of the merge and look for any incoming changes that you suspect may cause issues. <pre class="shell"><code>git log --topo-order --pretty=oneline --reverse ..$TAG</code></pre> And finally we initiate the actual merge. <pre class="shell"><code>git merge $TAG</code></pre> The commands above will likely run without a hitch up until the final <code>git merge</code>. This is where you need to combine the changes that were made in mainline with the changes that have been made in your Project repository. If there are no conflicts you’re in luck, then the merge will be completely automated and you will end up with a committed merge. If there are conflicts however you’ll need to manually go through the files where the conflicts are and make sure you select the correct version for each change. Using <code>git status</code> you can see what files that need to be merged. Depending on how much code your <a href="https://openjdk.org/bylaws#project">Project</a> has touched, this can be quite a bit of work. For complicated merges, see <a href="#sharing-the-work">Sharing the work</a> below. <h3 id="test-before-integration">Test before integration</h3> Regardless of if you encountered conflicts or not, you should always build and test your merge before integrating it to your Project repository. Testing needs to be done even when there are no textual conflicts as changes like for instance a rename can result in a compile or test error without any conflict. One could argue that <code>git merge --no-commit</code> could be used and have logical errors fixed in the merge commit. However, a subsequent “Fix logical merge errors” commit, is in fact more useful, as it clearly shows the Project specific adjustments needed for incoming changes. It’s always okay to have further commits to clean up after a merge. Hiding a large amount of reworking Project code to fit with upstream changes in a single merge commit will make it hard for further errors post integration to be identified. <h3 id="the-commit-push-and-pr">The commit, push, and PR</h3> Once you have a working version of your merged code you’re ready to create the merge commit and push. Please note that <code>git commit</code> is only needed if there were conflicts. If the changes were successfully merged by <code>git merge</code>, you already have a committed merge. <pre><code>git commit -m "Merge" git push --set-upstream origin Merge_mainline</code></pre> Now it’s time to create the PR on <a href="https://github.com">GitHub</a>. Just opening the PR page in your browser will most often be enough to see a message about new code that was pushed to your personal fork. Click the button to create the PR. Make sure the PR title starts with “Merge”. You may have noticed that when you integrate a “normal” PR into an OpenJDK repository, all commits that have been done in that PR will be squashed into a single commit. For normal changes this is a good thing as each PR normally corresponds to a single JBS issue, but for a merge it would be highly undesirable to squash all the different commits that you pull in from mainline. A PR with a title that starts with “Merge” won’t be squashed. That means that all the changes that you brought over will remain separate changes. It’s always a good idea to also include what was merged in the title of the PR. If you for instance is pulling in JDK mainline into your Project repository it’s likely (because it’s in general a good idea) that you choose some stable EA tag in mainline to merge. Your PR title could then be something like “Merge jdk-21+2”. Whether a merge requires a review or not is up to your Project lead to decide. Many <a href="https://openjdk.org/bylaws#project">Projects</a> don’t require this so the GitHub bots will allow you to integrate the merge as soon as the <a href="#github-actions">GHA</a>s are done. (They actually allow you to integrate even before the GHAs are done, but that’s in general not a good idea.) Once the PR has been integrated, you can clean up your fork and its clone in preparation for the next merge. <pre><code>git switch master git branch -d Merge_mainline git push -d origin Merge_mainline</code></pre> These commands will remove the temporary branch that we created to perform the merge. There’s a button in the GitHub GUI to delete the branch after you have integrated the PR. This can be used instead of the last of the three commands above (<code>git push -d...</code>). <h3 id="sharing-the-work">Sharing the work</h3> When conflicts take place in areas requiring specialized knowledge you may need help from other <a href="https://openjdk.org/bylaws#contributor">Contributors</a>. Backing up the original conflicts will help if you find yourself “in too deep”, and need assistance from other <a href="https://openjdk.org/bylaws#contributor">Contributors</a>. You can add and later remove these backups, along with a readme describing the merge status, to the actual merge branch to aid communication (i.e. you may not be able to compile certain components). Something like the following shell one-liner can be used to perform the backup. <pre class="shell"><code>git status | grep "both modified:" | while read B M FILE; do cp -v $FILE $DEST ; done</code></pre> Below are two different methods of collaborating on a merge described. Please note that extra commits are fine. The merge PR itself will describe any special actions that were taken in case further failures turn up after merge integration. Ultimately these commits will be squashed when integrating the project back into mainline. <h4 id="parking-a-merge-with-conflicts-in-place">1. Parking a merge with conflicts in place</h4> “Park” the conflicts, unresolved, in a personal fork, and let others do the further work (by sending you a patch, or opening your personal fork up to push from other <a href="https://openjdk.org/bylaws#contributor">Contributors</a>). Do this by keeping a list of unresolved conflicts (perhaps checking in said list to describe the merge state), and then marking them as resolved in git, committing, and pushing them to your personal fork. E.g. <code>git add $UNRESOLVED_FILES; git commit; git push</code> Pros: All unresolved conflicts are stated and can be worked on by multiple parties, all at once. Cons: Broken branch in terms of compile and test, may require temporary workaround patches to be passed around to complete work on specific unresolved components. <h4 id="incremental-merging">2. Incremental merging</h4> An alternative to parking a merge with conflicts in place, is to incrementally merge up to the troublesome point. For example: <ul> <li>Perform the initial merge: <code>git merge $TAG</code></li> <li>Find yourself in trouble, identify which change is causing the issue.</li> <li>Abort: <code>git merge --abort</code></li> <li>Find the troublesome change: <code>git log --topo-order --pretty=oneline --reverse $(current_branch)..$TAG</code></li> <li>Merge up to the previous change, commit and integrate.</li> <li>Ask others to continue the merge from the troubled change forward, how far forward is up you of course, either just that troublesome change, or the rest of the merge up to the $TAG.</li> <li>Rinse and repeat: There may appear further conflicts requiring other <a href="https://openjdk.org/bylaws#contributor">Contributors’</a> help.</li> </ul> Pros: All commits in the merge branch compile and test, you always have a working branch. Cons: There is an unknown extra amount of merge work, multiple iterations create more work. For instance you may find yourself resolving the same files multiple times (e.g. back-out commits). <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="hotspot-development">HotSpot Development</h1> See <a href="#working-with-pull-requests">Working With Pull Requests</a> for generic guidance and requirements around integrating changes. For the HotSpot codebase there are a few additional requirements: <ul> <li>Your change must have been approved by two reviewers out of which at least one is also a <a href="https://openjdk.org/bylaws#reviewer">Reviewer</a></li> <li>Your change must have passed through HotSpot tier 1 testing with zero failures (See tier1 definition in <code>test/hotspot/jtreg/TEST.groups</code>.)</li> </ul> <h2 id="logging">Logging</h2> <div class="box"> Quick Links <ul> <li><a href="https://openjdk.org/jeps/158">JEP 158: Unified JVM Logging</a></li> </ul> </div> While developing your fix, you might want your code to output some diagnostic information. You might even want to leave some logging in the code you check in, to facilitate future diagnostics. The appropriate way to print logging output from HotSpot is through the <a href="https://openjdk.org/jeps/158">Unified Logging Framework (JEP 158)</a>. It gives you a lot of nice features and enables common command-line options for all logging. A basic log message can be output like this: <div class="sourceCode" id="cb47"> <pre class="sourceCode cpp"><code class="sourceCode cpp"><a href="#cb47-1" aria-hidden="true" tabindex="-1"></a>log_info(gc, marking)("Mark Stack Usage: " SIZE_FORMAT "M", _mark_stack_usage / M);</code></pre></div> Where ‘gc’ and ‘marking’ are tags, and ‘info’ is the log level. Tags associate log messages with certain subsystems or features and the log level determines the importance and verbosity of the message. The most verbose output is trace, and the least is error. The full list of tags and levels are available via <code>-Xlog:help</code>. The basic log API looks as follows: <div class="sourceCode" id="cb48"> <pre class="sourceCode cpp"><code class="sourceCode cpp"><a href="#cb48-1" aria-hidden="true" tabindex="-1"></a>log_<level>(Tag1[,...])(fmtstr, ...)</code></pre></div> Sometimes single line printf-style logging isn’t enough. For example, it can be useful to group several log lines together or to use HotSpot’s outputstream API. UL supports both of these use cases using <code>LogMessage</code> and <code>LogStream</code>, respectively. <div class="sourceCode" id="cb49"> <pre class="sourceCode cpp"><code class="sourceCode cpp"><a href="#cb49-1" aria-hidden="true" tabindex="-1"></a>LogMessage(gc, marking) lm; <a href="#cb49-2" aria-hidden="true" tabindex="-1"></a>if (lm.is_info()) { <a href="#cb49-3" aria-hidden="true" tabindex="-1"></a> lm.info("We are guaranteed to be"); <a href="#cb49-4" aria-hidden="true" tabindex="-1"></a> lm.info(" grouped together"); <a href="#cb49-5" aria-hidden="true" tabindex="-1"></a>}</code></pre></div> <code>LogMessage</code> will submit its output when it goes out of scope. <code>LogStream</code> is typically used when a single printf-style format string becomes unwieldy. <div class="sourceCode" id="cb50"> <pre class="sourceCode cpp"><code class="sourceCode cpp"><a href="#cb50-1" aria-hidden="true" tabindex="-1"></a>LogStream st(Log(gc, marking)::info()); <a href="#cb50-2" aria-hidden="true" tabindex="-1"></a>if (st.is_enabled()) { <a href="#cb50-3" aria-hidden="true" tabindex="-1"></a> // Print without newline <a href="#cb50-4" aria-hidden="true" tabindex="-1"></a> st.print("I'm printing a lot of %s ", "arguments"); <a href="#cb50-5" aria-hidden="true" tabindex="-1"></a> st.print("With a lot of extra info %d ", 3); <a href="#cb50-6" aria-hidden="true" tabindex="-1"></a> // Print with newline (cr stands for carriage return) <a href="#cb50-7" aria-hidden="true" tabindex="-1"></a> st.print_cr("and so it's useful to use a stream"); <a href="#cb50-8" aria-hidden="true" tabindex="-1"></a>}</code></pre></div> If you need to print multiple lines grouped together with complex formatting requirements then <code>NonInterleavingLogStream</code> is probably what you want. <div class="sourceCode" id="cb51"> <pre class="sourceCode cpp"><code class="sourceCode cpp"><a href="#cb51-1" aria-hidden="true" tabindex="-1"></a>LogMessage(gc) lm; <a href="#cb51-2" aria-hidden="true" tabindex="-1"></a>NonInterleavingLogStream st{LogLevelType::Info, lm}; <a href="#cb51-3" aria-hidden="true" tabindex="-1"></a>if (st.is_enabled()) { <a href="#cb51-4" aria-hidden="true" tabindex="-1"></a> st.print_cr("Line one: %d %d %d ", 1, 2, 3); <a href="#cb51-5" aria-hidden="true" tabindex="-1"></a> st.print("Line two: %d %d %d", 4, 5, 6); <a href="#cb51-6" aria-hidden="true" tabindex="-1"></a> st.print_cr(" still line two: %d %d %d", 7, 8, 9); <a href="#cb51-7" aria-hidden="true" tabindex="-1"></a>}</code></pre></div> <h3 id="enabling-logging">Enabling logging</h3> You enable logging in the JVM by using the <code>-Xlog</code> command line option specified. For example, the messages from the examples would be visible if the JVM were run with any of the following options: <pre><code>-Xlog:gc+marking=info -Xlog:gc+marking -Xlog:gc*</code></pre> You can have multiple <code>-Xlog</code> options, these are applied in an additive manner. Consider this example: <pre><code>-Xlog:gc+marking=info:stdout -Xlog:alloc=warning:stderr -Xlog:breakpoint=error:breakpoint.txt:level</code></pre> This specifies that: <ol style="list-style-type: decimal"> <li>Log messages with info level and up, with tags gc and marking, to stdout.</li> <li>Log messages with warning level and up, with tag alloc, to stderr.</li> <li>Log messages with error level and up, with tag breakpoint, to file breakpoint.txt, with the decorator level.</li> </ol> UL automatically applies a default argument of <code>-Xlog:all=warning:stdout:uptime,level,tags</code> when logging is enabled. This can be disabled by prepending <code>-Xlog:disable</code> to your arguments. <pre><code>-Xlog:disable -Xlog:gc+marking=info -Xlog:alloc=warning</code></pre> Starting the JVM with the option <code>-Xlog:help</code> outputs more information and more examples. A full description of the syntax of <code>-Xlog</code> is available in <a href="https://openjdk.org/jeps/158">JEP 158</a>. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="code-owners">Code Owners</h1> This list is intended to make it easier to identify which email list to include in code reviews when making changes in different areas. The list may also help when assigning bugs based on which code they are found in. Please note that some directories may have been created or removed between releases. The intention here is to include directories that exists in mainline, LTS releases and other releases (post JDK 9) commonly being updated. <h2 id="area-mailing-lists">Area mailing lists</h2> <ul> <li>Generic JDK Development: <a href="https://mail.openjdk.org/mailman/listinfo/jdk-dev"><code>jdk-dev</code></a></li> <li>Build: <a href="https://mail.openjdk.org/mailman/listinfo/build-dev"><code>build-dev</code></a></li> <li>Client Libs: <a href="https://mail.openjdk.org/mailman/listinfo/client-libs-dev"><code>client-libs-dev</code></a></li> <li>Core Libs: <a href="https://mail.openjdk.org/mailman/listinfo/core-libs-dev"><code>core-libs-dev</code></a> <ul> <li>Net: <a href="https://mail.openjdk.org/mailman/listinfo/net-dev"><code>net-dev</code></a></li> <li>NIO: <a href="https://mail.openjdk.org/mailman/listinfo/nio-dev"><code>nio-dev</code></a></li> <li>I18n: <a href="https://mail.openjdk.org/mailman/listinfo/i18n-dev"><code>i18n-dev</code></a></li> </ul> </li> <li>HotSpot: <a href="https://mail.openjdk.org/mailman/listinfo/hotspot-dev"><code>hotspot-dev</code></a> <ul> <li>Compiler: <a href="https://mail.openjdk.org/mailman/listinfo/hotspot-compiler-dev"><code> hotspot-compiler-dev</code></a></li> <li>GC: <a href="https://mail.openjdk.org/mailman/listinfo/hotspot-gc-dev"><code>hotspot-gc-dev</code></a></li> <li>Runtime: <a href="https://mail.openjdk.org/mailman/listinfo/hotspot-runtime-dev"><code> hotspot-runtime-dev</code></a></li> <li>JFR: <a href="https://mail.openjdk.org/mailman/listinfo/hotspot-jfr-dev"><code>hotspot-jfr-dev</code></a></li> <li>Serviceability: <a href="https://mail.openjdk.org/mailman/listinfo/serviceability-dev"><code> serviceability-dev</code></a></li> </ul> </li> <li>Java Language (javac): <a href="https://mail.openjdk.org/mailman/listinfo/compiler-dev"><code>compiler-dev</code></a></li> <li>Security: <a href="https://mail.openjdk.org/mailman/listinfo/security-dev"><code>security-dev</code></a></li> <li>Tools <ul> <li>Javadoc: <a href="https://mail.openjdk.org/mailman/listinfo/javadoc-dev"><code>javadoc-dev</code></a></li> <li>JShell: <a href="https://mail.openjdk.org/mailman/listinfo/kulla-dev"><code>kulla-dev</code></a></li> <li>Nashorn: <a href="https://mail.openjdk.org/mailman/listinfo/nashorn-dev"><code>nashorn-dev</code></a></li> </ul> </li> </ul> <h2 id="directory-to-area-mapping">Directory to area mapping</h2> <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/.jcheck">.jcheck</a> - Build</li> <li><a href="https://github.com/openjdk/jdk/tree/master/bin">bin</a> - Build</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/demo">demo</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/doc">doc</a></li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot">hotspot</a> <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/cpu">cpu</a> - Compiler, Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/os">os</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/os_cpu">os_cpu</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share">share</a> <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/adlc"> adlc</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/asm">asm</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/c1">c1</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/cds">cds</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/ci">ci</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/classfile"> classfile</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/code"> code</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/compiler"> compiler</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/gc">gc</a> - GC</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/include"> include</a> - HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/interpreter"> interpreter</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/jfr">jfr</a> - JFR</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/jvmci"> jvmci</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/libadt"> libadt</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/logging"> logging</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/memory"> memory</a> - GC, Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/metaprogramming"> metaprogramming</a> - HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/nmt">nmt</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/oops"> oops</a> - GC, Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/opto"> opto</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/precompiled"> precompiled</a> - HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/prims"> prims</a> - Runtime, Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/runtime"> runtime</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/sanitizers"> sanitizers</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/services"> services</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/hotspot/share/utilities"> utilities</a> - GC, Runtime</li> </ul> </li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base">java.base</a> <ul> <li>Core Libs should almost always be included but Java Language, HotSpot, Security and/or I18n may also be involved.</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/classes">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/classes"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes"> windows</a>]/classes <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/com/sun/crypto"> com/sun/crypto</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/com/sun/security"> com/sun/security</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/javax/crypto"> crypto</a> - Security</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/classes/jdk/internal">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/classes/jdk/internal"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/jdk/internal"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/jdk/internal"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/jdk/internal"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/jdk/internal"> windows</a>]/internal <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/access"> access</a> - Core Libs, Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/event"> event</a> - JFR</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/foreign"> foreign</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/icu"> icu</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/io"> io</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/javac"> javac</a> - Java Language (javac)</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jimage"> jimage</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jmod"> jmod</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jrtfs"> jrtfs</a> - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/classes/jdk/internal/loader">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/jdk/internal/loader"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/jdk/internal/loader"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/jdk/internal/loader"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/jdk/internal/loader"> windows</a>]/loader - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/logger"> logger</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/math"> math</a> - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/jdk/internal/misc">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/jdk/internal/misc"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/jdk/internal/misc"> windows</a>]/misc - Core Libs, HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/module"> module</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/org/objectweb"> org/objectweb</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/org/xml"> org/xml</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/perf"> perf</a> - Runtime</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/classes/jdk/internal/platform">linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/jdk/internal/platform"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/jdk/internal/platform"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/jdk/internal/platform"> windows</a>]/platform - HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/ref"> ref</a> - Core Libs, GC</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/reflect"> reflect</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/util/random"> util/random</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/util/regex"> util/regex</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/util/xml"> util/xml</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/vm"> vm</a> - HotSpot</li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/sun/invoke"> invoke</a> - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/io">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/sun/io"> sun</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/java/io"> unix</a>]/io - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/java">macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/java"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/java"> windows</a>]/java <ul> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/lang">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/java/lang"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/java/lang"> windows</a>]/lang - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/java/math"> math</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/java/time"> time</a> - Core Libs</li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/sun/launcher"> launcher</a> - Tools, Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/META-INF/services"> META-INF/services</a> - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/javax/net">javax</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/java/net"> macosx</a>]/net - Net</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/classes/sun/nio">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/nio"> java</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/classes/sun/nio"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/sun/nio"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/sun/nio"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/sun/nio"> windows</a>]/nio - NIO</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/sun/reflect"> reflect</a> - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/apple/security">apple</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/security"> java</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/javax/security"> javax</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/apple/security"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/sun/security"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/sun/security"> windows</a>]/security - Security</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/text">java</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/sun/text"> sun</a>]/text - I18n</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/util">java</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/classes/sun/util"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/sun/util"> windows</a>]/util - I18n, Core Libs</li> </ul> </li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/conf">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/conf">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/conf">unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/conf"> windows</a>]/conf <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/unix/conf/sdp"> sdp</a> - Net</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/conf/security"> security</a> - Security</li> </ul> </li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/legal">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/legal"> windows</a>]/legal</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/lib/security">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/lib/security"> windows</a>]/lib/security - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/man"> man</a> <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/src/java.base/share/man/java.1"> java.1</a> - Tools, HotSpot</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/src/java.base/share/man/keytool.1"> keytool.1</a> - Security</li> </ul> </li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/native">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/native"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/native"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native">unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native"> windows</a>]/native <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/windows/native/common"> common</a></li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/include">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/include"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/include"> windows</a>]/include - Runtime, Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/unix/native/jspawnhelper"> jspawnhelper</a> - Tools</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/launcher">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/launcher"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/launcher"> windows</a>]/launcher - Tools</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libjava">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/native/libjava"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libjava"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjava"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjava"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjava"> windows</a>]/libjava - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjimage">share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjimage"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjimage"> windows</a>]/libjimage - Core Libs</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libjli">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libjli"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjli"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjli"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjli"> windows</a>]/libjli - Tools, Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/unix/native/libjsig"> libjsig</a> - HotSpot</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libnet">macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libnet"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libnet"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libnet"> windows</a>]/libnet - Net</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libnio">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/linux/native/libnio"> linux</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libnio"> macosx</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libnio"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libnio"> unix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libnio"> windows</a>]/libnio - NIO</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/macosx/native/libosxsecurity"> libosxsecurity</a> - Security</li> <li>[<a href="https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libsyslookup">aix</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/share/native/libsyslookup"> share</a>, <a href="https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libsyslookup"> windows</a>]/libsyslookup - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/native/libverify"> libverify</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/native/libzip"> libzip</a> - Core Libs</li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data"> share/data</a> <ul> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/blockedcertsconverter"> blockedcertsconverter</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/cacerts"> cacerts</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/currency"> currency</a> - I18n</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/lsrdata"> lsrdata</a> - I18n</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/publicsuffixlist"> publicsuffixlist</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/tzdata"> tzdata</a> - I18n</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.base/share/data/unicodedata"> unicodedata</a> - I18n</li> </ul> </li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.compiler">java.compiler</a> - Java Language (javac)</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.datatransfer">java.datatransfer</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.desktop">java.desktop</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.instrument">java.instrument</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.logging">java.logging</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.management">java.management</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.management.rmi"> java.management.rmi</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.naming">java.naming</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.net.http">java.net.http</a> - Net</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.prefs">java.prefs</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.rmi">java.rmi</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.scripting">java.scripting</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.se">java.se</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.security.jgss"> java.security.jgss</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.security.sasl"> java.security.sasl</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.smartcardio">java.smartcardio</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.sql">java.sql</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.sql.rowset">java.sql.rowset</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.transaction.xa"> java.transaction.xa</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.xml">java.xml</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/java.xml.crypto">java.xml.crypto</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.accessibility">jdk.accessibility</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.attach">jdk.attach</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.charsets">jdk.charsets</a> - I18n, Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.compiler">jdk.compiler</a> - Java Language (javac)</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.crypto.cryptoki"> jdk.crypto.cryptoki</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.crypto.ec">jdk.crypto.ec</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.crypto.mscapi">jdk.crypto.mscapi</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.dynalink">jdk.dynalink</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.editpad">jdk.editpad</a> - JShell</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.graal.compiler"> jdk.graal.compiler</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.graal.compiler.management"> jdk.graal.compiler.management</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.hotspot.agent">jdk.hotspot.agent</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.httpserver">jdk.httpserver</a> - Net</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.incubator.vector"> jdk.incubator.vector</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.internal.ed">jdk.internal.ed</a> - JShell</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.internal.jvmstat"> jdk.internal.jvmstat</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.internal.le">jdk.internal.le</a> - JShell</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.internal.opt">jdk.internal.opt</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.internal.vm.ci"> jdk.internal.vm.ci</a> - Compiler</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jartool">jdk.jartool</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.javadoc">jdk.javadoc</a> - Javadoc</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jcmd">jdk.jcmd</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jconsole">jdk.jconsole</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jdeps">jdk.jdeps</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jdi">jdk.jdi</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jdwp.agent">jdk.jdwp.agent</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jfr">jdk.jfr</a> - JFR</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jlink">jdk.jlink</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jpackage">jdk.jpackage</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jshell">jdk.jshell</a> - JShell</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jsobject">jdk.jsobject</a> - Tools</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.jstatd">jdk.jstatd</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.localedata">jdk.localedata</a> - I18n</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.management">jdk.management</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.management.agent"> jdk.management.agent</a> - Serviceability</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.management.jfr"> jdk.management.jfr</a> - Runtime</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.naming.dns">jdk.naming.dns</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.naming.rmi">jdk.naming.rmi</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.net">jdk.net</a> - Net</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.nio.mapmode">jdk.nio.mapmode</a> - NIO</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.sctp">jdk.sctp</a> - Net</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.security.auth">jdk.security.auth</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.security.jgss">jdk.security.jgss</a> - Security</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.unsupported">jdk.unsupported</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.unsupported.desktop"> jdk.unsupported.desktop</a> - Client Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.xml.dom">jdk.xml.dom</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/jdk.zipfs">jdk.zipfs</a> - Core Libs</li> <li><a href="https://github.com/openjdk/jdk/tree/master/make">make</a> - Build</li> <li><a href="https://github.com/openjdk/jdk/tree/master/test">test</a> <ul> <li>The test directories follow to a large part the same structure as the source code in <code>src</code>. The owners are the same for directories with the same names.</li> </ul> </li> <li><a href="https://github.com/openjdk/jdk/tree/master/src/utils">utils</a></li> </ul> <h3 id="directories-removed">Directories removed</h3> <ul> <li>hotspot <ul> <li><code>*.jdk</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8187443">10</a>)</li> <li>share <ul> <li><code>aot</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8263327">17</a>)</li> <li><code>shark</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8171853">10</a>)</li> <li><code>trace</code> – Runtime (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8199712">11</a>)</li> </ul> </li> </ul> </li> <li>java.base <ul> <li>man <ul> <li><code>jfr.1</code> – Runtime (Removed in <a href="https://bugs.openjdk.org/browse/JBS-8252113">16</a>)</li> </ul> </li> </ul> </li> <li><code>jdk.aot</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8263327">17</a>)</li> <li><code>jdk.crypto.ucrypto</code> – Security (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8241787">12</a>) <ul> <li>only available on Solaris</li> </ul> </li> <li><code>jdk.incubator.concurrent</code> – Core Libs (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8306647">21</a>)</li> <li><code>jdk.internal.vm.compiler</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8318027">22</a>)</li> <li><code>jdk.internal.vm.compiler.management</code> – Compiler (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8318027">22</a>)</li> <li><code>jdk.pack</code> – Tools (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8234596">14</a>)</li> <li><code>jdk.random</code> – Core Libs (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8330005">23</a>)</li> <li><code>jdk.rmic</code> – Core Libs (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8225319">15</a>)</li> <li><code>jdk.scripting.nashorn</code> – Tools (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8236933">15</a>)</li> <li><code>jdk.scripting.nashorn.shell</code> – Tools (Removed in <a href="https://bugs.openjdk.org/browse/JDK-8236933">15</a>)</li> </ul> <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <h1 id="about-this-guide">About This Guide</h1> This guide is being maintained through the <a href="https://openjdk.org/census#guide">OpenJDK Developers’ Guide Project</a>. The source repository is available at <a href="https://github.com/openjdk/guide">GitHub</a>. The revision hash at the bottom of this page refers to the last published commit. Comments and questions may be sent to <a href="mailto:guide-dev@openjdk.org">guide-dev@openjdk.org</a>. Please let us know if there’s anything in the guide that isn’t clear. <div class="box"> <a href="#" class="boxheader">To the top</a> </div> <div class="version">File change revision: ef416dd - <a href="https://github.com/openjdk/guide/commits/master/src/guide">Revision history</a></div> </div><div id="sidebar"><div id="openjdk-sidebar-logo"><a href="/"><img alt="OpenJDK logo" src="../images/openjdk-small.png" /></a></div><div class="links"><div class="link"><a href="/install/">Installing</a></div><div class="link"><a href="/guide/#contributing-to-an-openjdk-project">Contributing</a></div><div class="link"><a href="/guide/#reviewing-and-sponsoring-a-change">Sponsoring</a></div><div class="link"><a href="/guide/">Developers' Guide</a></div><div class="link"><a href="/groups/vulnerability/report">Vulnerabilities</a></div><div class="link"><a href="https://jdk.java.net">JDK GA/EA Builds</a></div></div><div class="links"><div class="links"><a href="https://mail.openjdk.org">Mailing lists</a></div><div class="link"><a href="https://wiki.openjdk.org">Wiki</a> · <a href="/irc">IRC</a></div><div class="link"><a href="https://mastodon.social/@openjdk" rel="me">Mastodon</a></div><div class="link"><a href="https://bsky.app/profile/openjdk.org">Bluesky</a></div></div><div class="links"><div class="links"><a href="/bylaws">Bylaws</a> · <a href="/census">Census</a></div><div class="link"><a href="/legal/">Legal</a></div></div><div class="links"><div class="links"><a href="/workshop">Workshop</a></div></div><div class="links"><div class="links"><a href="/jeps/0">JEP Process</a></div></div><div class="links"><div class="about">Source code</div><div class="link"><a href="https://github.com/openjdk/">GitHub</a></div><div class="link"><a href="https://hg.openjdk.org">Mercurial</a></div></div><div class="links"><div class="about">Tools</div><div class="link"><a href="http://git-scm.org/">Git</a></div><div class="link"><a href="/jtreg/">jtreg harness</a></div></div><div class="links"><div class="about">Groups</div><div class="link"><a href="/groups/">(overview)</a></div><div class="link"><a href="/groups/adoption">Adoption</a></div><div class="link"><a href="/groups/build">Build</a></div><div class="link"><a href="/groups/client-libs">Client Libraries</a></div><div class="link"><a href="/groups/csr">Compatibility & Specification Review</a></div><div class="link"><a href="/groups/compiler">Compiler</a></div><div class="link"><a href="/groups/conformance">Conformance</a></div><div class="link"><a href="/groups/core-libs">Core Libraries</a></div><div class="link"><a href="/groups/gb">Governing Board</a></div><div class="link"><a href="/groups/hotspot">HotSpot</a></div><div class="link"><a href="/groups/ide-support">IDE Tooling & Support</a></div><div class="link"><a href="/groups/i18n">Internationalization</a></div><div class="link"><a href="/groups/jmx">JMX</a></div><div class="link"><a href="/groups/members">Members</a></div><div class="link"><a href="/groups/net">Networking</a></div><div class="link"><a href="/groups/porters">Porters</a></div><div class="link"><a href="/groups/quality">Quality</a></div><div class="link"><a href="/groups/security">Security</a></div><div class="link"><a href="/groups/serviceability">Serviceability</a></div><div class="link"><a href="/groups/vulnerability">Vulnerability</a></div><div class="link"><a href="/groups/web">Web</a></div></div><div class="links"><div class="about">Projects</div><div class="link">(<a href="/projects/">overview</a>, <a href="/projects/archive">archive</a>)</div><div class="link"><a href="/projects/amber">Amber</a></div><div class="link"><a href="/projects/babylon">Babylon</a></div><div class="link"><a href="/projects/crac">CRaC</a></div><div class="link"><a href="/projects/code-tools">Code Tools</a></div><div class="link"><a href="/projects/coin">Coin</a></div><div class="link"><a href="/projects/cvmi">Common VM Interface</a></div><div class="link"><a href="/projects/guide">Developers' Guide</a></div><div class="link"><a href="/projects/dio">Device I/O</a></div><div class="link"><a href="/projects/duke">Duke</a></div><div class="link"><a href="/projects/galahad">Galahad</a></div><div class="link"><a href="/projects/graal">Graal</a></div><div class="link"><a href="/projects/icedtea">IcedTea</a></div><div class="link"><a href="/projects/jdk7">JDK 7</a></div><div class="link"><a href="/projects/jdk8">JDK 8</a></div><div class="link"><a href="/projects/jdk8u">JDK 8 Updates</a></div><div class="link"><a href="/projects/jdk9">JDK 9</a></div><div class="link"><a href="/projects/jdk">JDK</a> (…, <a href="/projects/jdk/23">23</a>, <a href="/projects/jdk/24">24</a>, <a href="/projects/jdk/25">25</a>)</div><div class="link"><a href="/projects/jdk-updates">JDK Updates</a></div><div class="link"><a href="/projects/jigsaw">Jigsaw</a></div><div class="link"><a href="/projects/kona">Kona</a></div><div class="link"><a href="/projects/kulla">Kulla</a></div><div class="link"><a href="/projects/lanai">Lanai</a></div><div class="link"><a href="/projects/leyden">Leyden</a></div><div class="link"><a href="/projects/lilliput">Lilliput</a></div><div class="link"><a href="/projects/locale-enhancement">Locale Enhancement</a></div><div class="link"><a href="/projects/loom">Loom</a></div><div class="link"><a href="/projects/jmm">Memory Model Update</a></div><div class="link"><a href="/projects/metropolis">Metropolis</a></div><div class="link"><a href="/projects/jmc">Mission Control</a></div><div class="link"><a href="/projects/mlvm">Multi-Language VM</a></div><div class="link"><a href="/projects/nashorn">Nashorn</a></div><div class="link"><a href="/projects/nio">New I/O</a></div><div class="link"><a href="/projects/openjfx">OpenJFX</a></div><div class="link"><a href="/projects/panama">Panama</a></div><div class="link"><a href="/projects/penrose">Penrose</a></div><div class="link"><a href="/projects/aarch32-port">Port: AArch32</a></div><div class="link"><a href="/projects/aarch64-port">Port: AArch64</a></div><div class="link"><a href="/projects/bsd-port">Port: BSD</a></div><div class="link"><a href="/projects/haiku-port">Port: Haiku</a></div><div class="link"><a href="/projects/macosx-port">Port: Mac OS X</a></div><div class="link"><a href="/projects/mips-port">Port: MIPS</a></div><div class="link"><a href="/projects/mobile">Port: Mobile</a></div><div class="link"><a href="/projects/ppc-aix-port">Port: PowerPC/AIX</a></div><div class="link"><a href="/projects/riscv-port">Port: RISC-V</a></div><div class="link"><a href="/projects/s390x-port">Port: s390x</a></div><div class="link"><a href="/projects/sctp">SCTP</a></div><div class="link"><a href="/projects/shenandoah">Shenandoah</a></div><div class="link"><a href="/projects/skara">Skara</a></div><div class="link"><a href="/projects/sumatra">Sumatra</a></div><div class="link"><a href="/projects/tsan">Tsan</a></div><div class="link"><a href="/projects/valhalla">Valhalla</a></div><div class="link"><a href="/projects/verona">Verona</a></div><div class="link"><a href="/projects/visualvm">VisualVM</a></div><div class="link"><a href="/projects/wakefield">Wakefield</a></div><div class="link"><a href="/projects/zero">Zero</a></div><div class="link"><a href="/projects/zgc">ZGC</a></div></div><div class="buttons"><a href="https://oracle.com"><img alt="Oracle logo" src="../images/oracle.png" /></a></div></div><div id="footer"> © 2025 Oracle Corporation and/or its affiliates <a href="/legal/tou/">Terms of Use</a> · License: <a href="/legal/gplv2+ce.html">GPLv2</a> · <a href="https://www.oracle.com/us/legal/privacy/">Privacy</a> · <a href="https://openjdk.org/legal/openjdk-trademark-notice.html">Trademarks</a></div><script type="text/javascript" src="/NzNeGH/Vw/i6/NOu5/EwFb8mKAtw/Q3a1kkr6kYStt1/PW02AQ/Fl/cBc2srDW8B"></script></body></html>