CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Alan Stern: Re: klists and struct device semaphores</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Alan Stern" href="/groupie.php?aid=5792" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/3"> [Mar]</a> 聽 <a class="nb" href="/lkml/2005/3/31"> [31]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/3/31/186" onclick="this.href='/lkml/headers'+'/2005/3/31/186';">[headers]</a>聽 <a href="/lkml/bounce/2005/3/31/186">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/3/26/78">First message in thread</a></li><li><a href="/lkml/2005/3/29/172">Alan Stern</a><ul><li><a href="/lkml/2005/3/29/175">Dmitry Torokhov</a></li><li><a href="/lkml/2005/3/30/310">Patrick Mochel</a><ul><li><a href="/lkml/2005/3/30/318">Dmitry Torokhov</a><ul><li><a href="/lkml/2005/3/31/4">Patrick Mochel</a></li></ul></li><li class="origin"><a href="/lkml/2005/3/31/204">Alan Stern</a><ul><li><a href="/lkml/2005/3/31/204">Patrick Mochel</a><ul><li><a href="/lkml/2005/3/31/229">Alan Stern</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Thu, 31 Mar 2005 11:24:17 -0500 (EST)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Alan Stern <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: klists and struct device semaphores</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Wed, 30 Mar 2005, Patrick Mochel wrote:<br /><br />> > Having thought it through, I believe all we need for USB support is this:<br />> ><br />> > Whenever usb_register() in the USB core calls driver_register()<br />> > and the call filters down to driver_attach(), that routine<br />> > should lock dev->parent->sem before calling driver_probe_device()<br />> > (and unlock it afterward, of course).<br />> ><br />> > (For the corresponding remove pathway, where usb_deregister()<br />> > calls driver_unregister(), it would be nice if __remove_driver()<br />> > locked dev->parent->sem before calling device_release_driver().<br />> > This is not really needed, however, since USB drivers aren't<br />> > supposed to touch the device in their disconnect() method.)<br />> <br />> <br />> Why can't you just lock it in ->probe() and ->remove() yourself?<br /><br />Aha! There you go... This explains why you need explicit locking rules.<br /><br />When probe() and remove() are called, the driver-model core already owns<br />the device's lock. If the driver then tried to lock the parent, it would<br />mean acquiring locks in the wrong order. This could easily lead to<br />deadlock.<br /><br />Furthermore, it will often happen during probe() and remove() that the<br />parent's lock is already owned by the USB core. So the driver _mustn't_<br />try to lock it.<br /><br />Alan Stern<br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-06 13:31 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>