#23120 (There should be indication that widget settings have been saved)

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><script type="text/javascript" src="/_static/js/bundle-playback.js?v=HxkREWBo" charset="utf-8"></script> <script type="text/javascript" src="/_static/js/wombat.js?v=txqj7nKC" charset="utf-8"></script> <script>window.RufflePlayer=window.RufflePlayer||{};window.RufflePlayer.config={"autoplay":"on","unmuteOverlay":"hidden"};</script> <script type="text/javascript" src="/_static/js/ruffle/ruffle.js"></script> <script type="text/javascript"> __wm.init("https://web.archive.org/web"); __wm.wombat("http://core.trac.wordpress.org/ticket/23120","20130114235743","https://web.archive.org/","web","/_static/", "1358207863"); </script> <link rel="stylesheet" type="text/css" href="/_static/css/banner-styles.css?v=S1zqJCYt" /> <link rel="stylesheet" type="text/css" href="/_static/css/iconochive.css?v=3PDvdIFv" />  <title> #23120 (There should be indication that widget settings have been saved) – WordPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>  <link rel="search" href="/web/20130114235743/http://core.trac.wordpress.org/search"/> <link rel="prev" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23119" title="Ticket #23119"/> <link rel="last" href="/ticket/23200" title="Ticket #23200"/> <link rel="help" href="/wiki/TracGuide"/> <link rel="alternate" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=csv" type="text/csv" class="csv" title="Comma-delimited Text"/><link rel="alternate" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text"/><link rel="alternate" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=rss" type="application/rss+xml" class="rss" title="RSS Feed"/> <link rel="next" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23121" title="Ticket #23121"/> <link rel="start" href="/wiki"/> <link rel="stylesheet" href="/web/20130114235743cs_/http://core.trac.wordpress.org/chrome/common/css/trac.css" type="text/css"/><link rel="stylesheet" href="/web/20130114235743cs_/http://core.trac.wordpress.org/chrome/common/css/ticket.css" type="text/css"/> <link rel="first" href="/ticket/1" title="Ticket #1"/> <link rel="shortcut icon" href="/web/20130114235743im_/http://core.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link rel="icon" href="/web/20130114235743im_/http://core.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link type="application/opensearchdescription+xml" rel="search" href="/web/20130114235743/http://core.trac.wordpress.org/search/opensearch" title="Search WordPress Trac"/> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="55fd9b788999e4115d0c51c1"; </script> <script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/jquery.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/babel.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/trac.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/search.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/folding.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/wikitoolbar.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/resizer.js"></script><script type="text/javascript" src="/web/20130114235743js_/http://core.trac.wordpress.org/chrome/common/js/auto_preview.js"></script>  <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); var args = {realm: "ticket", id: 23120, escape_newlines: 0} $("#comment").autoPreview("/wiki_render", args, function(textarea, text, rendered) { $("#ticketchange div.comment").html(rendered); if (rendered) $("#ticketchange").show(); else if ($("#ticketchange ul.changes").length == 0) $("#ticketchange").hide(); }); $("#trac-comment-editor textarea").autoPreview("/wiki_render", args, function(textarea, text, rendered) { var comment = $("#trac-comment-editor").next("div.comment"); comment.html(rendered); if (rendered) comment.show(); else comment.hide(); }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); /* only enable control elements for the currently selected action */ var actions = $("#action input[name='action']"); function updateActionFields() { actions.each(function () { $(this).siblings().find("*[id]").enable($(this).checked()); $(this).siblings().filter("*[id]").enable($(this).checked()); }); } actions.click(updateActionFields); updateActionFields(); }); </script> <meta name="viewport" content="width=device-width"/> <link rel="stylesheet" type="text/css" href="//web.archive.org/web/20130114235743cs_/http://wordpress.org/style/trac/wp-trac.css?2"/> <script src="//web.archive.org/web/20130114235743js_/http://openatd.svn.wordpress.org/atd-jquery/scripts/jquery.atd.textarea.js"></script> <script src="//web.archive.org/web/20130114235743js_/http://openatd.svn.wordpress.org/atd-jquery/scripts/csshttprequest.js"></script> <link rel="stylesheet" type="text/css" href="//web.archive.org/web/20130114235743cs_/http://openatd.svn.wordpress.org/atd-jquery/css/atd.css" media="screen"/> </head> <body class="core"> <div id="siteheader"> </div> <div id="banner"> <div id="header"> <a id="logo" href="https://web.archive.org/web/20130114235743/http://wordpress.org/"><img src="/web/20130114235743im_/http://core.trac.wordpress.org/chrome/site/trac-logo.png" alt="WordPress.org" height="80" width="345"/></a> </div> <form id="search" action="/web/20130114235743/http://core.trac.wordpress.org/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value=""/> <input type="submit" value="Search"/> </div> </form> <div id="metanav" class="nav"> <ul> <li class="first"><a href="/web/20130114235743/http://core.trac.wordpress.org/login">Login</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/prefs">Preferences</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/wiki/TracGuide">Help/Guide</a></li><li class="last"><a href="/web/20130114235743/http://core.trac.wordpress.org/about">About Trac</a></li> </ul> </div> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/web/20130114235743/http://core.trac.wordpress.org/wiki">Wiki</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/timeline">Timeline</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/roadmap">Roadmap</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/browser">Browse Source</a></li><li class="active"><a href="/web/20130114235743/http://core.trac.wordpress.org/report">View Tickets</a></li><li><a href="/web/20130114235743/http://core.trac.wordpress.org/search">Search</a></li><li class="last"><a href="/web/20130114235743/http://core.trac.wordpress.org/ticketgraph">Ticket Graph</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23119" title="Ticket #23119">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23121" title="Ticket #23121">Next Ticket</a> →</span></li> </ul> <hr/> </div> <div id="content" class="ticket"> <h1 id="trac-ticket-title"> <a href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120">Ticket #23120</a> <span class="status">(new enhancement)</span> </h1> <div id="ticket"> <div class="date"> <p>Opened <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T16%3A28%3A05Z&precision=second" title="2013-01-04T16:28:05Z in Timeline">10 days</a> ago</p> <p>Last modified <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-09T01%3A44%3A17Z&precision=second" title="2013-01-09T01:44:17Z in Timeline">6 days</a> ago</p> </div> <h2 class="summary searchable">There should be indication that widget settings have been saved</h2> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/jacopo.vip"> <img class="avatar" src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=jacopo.vip" height="24" width="24"/> </a> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&reporter=jacopo.vip">jacopo.vip</a> </td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> </td> </tr> <tr> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&priority=normal">normal</a> </td> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="milestone" href="/web/20130114235743/http://core.trac.wordpress.org/milestone/3.6">3.6</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&component=Widgets">Widgets</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&version=3.5">3.5</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&severity=normal">normal</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&keywords=~ui-focus">ui-focus</a> <a href="/web/20130114235743/http://core.trac.wordpress.org/query?status=!closed&keywords=~has-patch">has-patch</a> </td> </tr><tr> <th id="h_cc"> Cc: </th> <td headers="h_cc" class="searchable"> jacopo.tarantino@…, ADAMSILVERSTEIN@…, mdhansen@… </td> <th> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p> There's currently no confirmation that adding a widget or changes to a widget have been saved. In some cases(fast hosting and a solid internet connection) the changes are saved so quickly the spinner is barely on the screen at all. I think a best course of action would be to have the word "Saved" appear briefly after the spinner goes away. Or perhaps a check mark as that doesn't need to be translated. Related post on make.wordpress.org: <a class="ext-link" href="https://web.archive.org/web/20130114235743/http://make.wordpress.org/ui/2013/01/02/this-morning-i-ran-2-users-through-some/"><span class="icon"></span>http://make.wordpress.org/ui/2013/01/02/this-morning-i-ran-2-users-through-some/</a> </p> </div> </div> </div> <div id="attachments"> <h2 class="foldable">Attachments</h2> <div> <dl class="attachments"> <dt> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.search-widget-settings-ru_RU.png" title="View attachment">23120.search-widget-settings-ru_RU.png</a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.search-widget-settings-ru_RU.png" class="trac-rawlink" title="Download"></a> (<span title="5465 bytes">5.3 KB</span>) - added by <em>SergeyBiryukov</em> <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T19%3A12%3A54Z&precision=second" title="2013-01-04T19:12:54Z in Timeline">10 days</a> ago. </dt> <dt> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/widgetpatch.diff" title="View attachment">widgetpatch.diff</a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/widgetpatch.diff" class="trac-rawlink" title="Download"></a> (<span title="1216 bytes">1.2 KB</span>) - added by <em>adamsilverstein</em> <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A49%3A33Z&precision=second" title="2013-01-04T21:49:33Z in Timeline">10 days</a> ago. </dt> <dd> adds a checkmark after spinner on widget save & reorder </dd> <dt> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.patch" title="View attachment">23120.patch</a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.patch" class="trac-rawlink" title="Download"></a> (<span title="1711 bytes">1.7 KB</span>) - added by <em>SergeyBiryukov</em> <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-05T04%3A01%3A34Z&precision=second" title="2013-01-05T04:01:34Z in Timeline">10 days</a> ago. </dt> </dl> </div> </div> <div> <h2 class="foldable">Change History</h2> <div id="changelog"> <div class="change"> <div class="change"> <h3 class="change"> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T19%3A12%3A54Z&precision=second" title="2013-01-04T19:12:54Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Attachment</strong> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.search-widget-settings-ru_RU.png"><em>23120.search-widget-settings-ru_RU.png</em></a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.search-widget-settings-ru_RU.png" title="Download" class="trac-rawlink"></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-1"> <div class="change"> <h3 class="change" id="comment:1"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">comment:1</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T19%3A14%3A18Z&precision=second" title="2013-01-04T19:14:18Z in Timeline">10 days</a> ago </span> </h3> </div> <div class="comment searchable"> <blockquote class="citation"> <p> I think a best course of action would be to have the word "Saved" appear briefly after the spinner goes away. Or perhaps a check mark as that doesn't need to be translated. </p> </blockquote> <p> A check mark seems better to me. </p> <p> In ru_RU, there's no place for the string: <a class="attachment" href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.search-widget-settings-ru_RU.png" title="Attachment '23120.search-widget-settings-ru_RU.png' in Ticket #23120">23120.search-widget-settings-ru_RU.png</a><a class="trac-rawlink" href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.search-widget-settings-ru_RU.png" title="Download"></a>, so it would have the same problem as in <a class="new ticket" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/21890" title="defect (bug): Customizer spinner breaks button alignment with longer strings (new)">#21890</a>. </p> </div> </div> <div class="change" id="trac-change-2"> <div class="change"> <h3 class="change" id="comment:2"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">comment:2</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T19%3A16%3A42Z&precision=second" title="2013-01-04T19:16:42Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>ui-focus</em> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-3"> <div class="change"> <h3 class="change" id="comment:3"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">comment:3</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T20%3A26%3A23Z&precision=second" title="2013-01-04T20:26:23Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Cc</strong> <em>ADAMSILVERSTEIN@…</em> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-4"> <div class="change"> <h3 class="change" id="comment:4"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">comment:4</a> </span> follow-up: <a href="#comment:6">↓ 6</a> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A41%3A26Z&precision=second" title="2013-01-04T21:41:26Z in Timeline">10 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> i have attached a patch that i believe addresses this issue </p> <p> i added a class to wp-admin.css to show the yes.png checkmark bundled in /wp-admin/images </p> <p> i changed the hide() action in widgets.js when the save is complete, instead i add the new class and initiate a 1 second delay() with a half second fade at the end bringing opacity to 0. finally, a callback resets the opacity to 1 and completes the hide() in the original code. </p> <p> note! you can't just call delay(1500).hide() or the element gets hidden immediately (hide is not added to jquery's fx queue). the callback is required to have the hide actually happen after the delay. although the fade is not required i kinda think it looks nice. </p> <p> also, i changed the spinner for dragging and resorting the widgets - it now also shows the checkmark briefly. </p> <p> tested on mac chrome and firefox </p> </div> <div class="trac-lastedit "> Last edited <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A54%3A06Z&precision=second" title="2013-01-04T21:54:06Z in Timeline">10 days</a> ago by adamsilverstein (<a href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?cversion=0&cnum_hist=4#comment:4">previous</a>) (<a href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?action=comment-diff&cnum=4&version=1">diff</a>) </div> </div> <div class="change"> <div class="change"> <h3 class="change"> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A49%3A33Z&precision=second" title="2013-01-04T21:49:33Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Attachment</strong> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/widgetpatch.diff"><em>widgetpatch.diff</em></a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/widgetpatch.diff" title="Download" class="trac-rawlink"></a> added </li> </ul> <div class="comment searchable"> <p> adds a checkmark after spinner on widget save & reorder </p> </div> </div> <div class="change" id="trac-change-5"> <div class="change"> <h3 class="change" id="comment:5"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">comment:5</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A50%3A15Z&precision=second" title="2013-01-04T21:50:15Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>has-patch</em> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-6"> <div class="change"> <h3 class="change" id="comment:6"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">comment:6</a> </span> in reply to: <a href="#comment:4">↑ 4</a> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/jacopo.vip"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=jacopo.vip" height="24" width="24"/> jacopo.vip</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T21%3A57%3A13Z&precision=second" title="2013-01-04T21:57:13Z in Timeline">10 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> Replying to <a href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120#comment:4" title="Comment 4 for Ticket #23120">adamsilverstein</a>: </p> <blockquote class="citation"> <p> i have attached a patch that i believe addresses this issue </p> <p> i added a class to wp-admin.css to show the yes.png checkmark bundled in /wp-admin/images </p> <p> i changed the hide() action in widgets.js when the save is complete, instead i add the new class and initiate a 1 second delay() with a half second fade at the end bringing opacity to 0. finally, a callback resets the opacity to 1 and completes the hide() in the original code. </p> <p> note! you can't just call delay(1500).hide() or the element gets hidden immediately (hide is not added to jquery's fx queue). the callback is required to have the hide actually happen after the delay. although the fade is not required i kinda think it looks nice. </p> <p> also, i changed the spinner for dragging and resorting the widgets - it now also shows the checkmark briefly. </p> <p> tested on mac chrome and firefox </p> </blockquote> <p> I think that's a perfect solution. Good work :) </p> </div> </div> <div class="change" id="trac-change-7"> <div class="change"> <h3 class="change" id="comment:7"> <span class="threading"> <span id="comment:7" class="cnum"> <a href="#comment:7">comment:7</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T22%3A29%3A25Z&precision=second" title="2013-01-04T22:29:25Z in Timeline">10 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> great, glad you like what i came up with! i'm new to contributing patches here, so thanks... </p> <p> seems like there might be other places it could be used in the interface, but i haven't hunted. running locally sure makes the issue easy to spot :) </p> </div> </div> <div class="change" id="trac-change-8"> <div class="change"> <h3 class="change" id="comment:8"> <span class="threading"> <span id="comment:8" class="cnum"> <a href="#comment:8">comment:8</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/MikeHansenMe"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=MikeHansenMe" height="24" width="24"/> MikeHansenMe</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-04T23%3A16%3A54Z&precision=second" title="2013-01-04T23:16:54Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Cc</strong> <em>mdhansen@…</em> added </li> </ul> <div class="comment searchable"> <p> Tested and works as described. I think it is a good solution, no text or translation needed. </p> </div> </div> <div class="change"> <div class="change"> <h3 class="change"> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-05T04%3A01%3A34Z&precision=second" title="2013-01-05T04:01:34Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Attachment</strong> <a href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.patch"><em>23120.patch</em></a><a href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.patch" title="Download" class="trac-rawlink"></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-9"> <div class="change"> <h3 class="change" id="comment:9"> <span class="threading"> <span id="comment:9" class="cnum"> <a href="#comment:9">comment:9</a> </span> follow-up: <a href="#comment:11">↓ 11</a> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-05T04%3A38%3A36Z&precision=second" title="2013-01-05T04:38:36Z in Timeline">10 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> <a class="attachment" href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.patch" title="Attachment '23120.patch' in Ticket #23120">23120.patch</a><a class="trac-rawlink" href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.patch" title="Download"></a>: </p> <ul><li>Removes the class after hiding the element, otherwise the spinner image no longer appears on next click. </li><li>When saving the order after dragging widgets, only displays the spinner in sidebar header (as it is now), not in each widget. </li><li>Adds the widget object as a context to the selector, in order to only animate the spinner in the current widget. </li></ul> </div> </div> <div class="change" id="trac-change-10"> <div class="change"> <h3 class="change" id="comment:10"> <span class="threading"> <span id="comment:10" class="cnum"> <a href="#comment:10">comment:10</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-05T04%3A38%3A48Z&precision=second" title="2013-01-05T04:38:48Z in Timeline">10 days</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Milestone</strong> changed from <em>Awaiting Review</em> to <em>3.6</em> </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-11"> <div class="change"> <h3 class="change" id="comment:11"> <span class="threading"> <span id="comment:11" class="cnum"> <a href="#comment:11">comment:11</a> </span> in reply to: <a href="#comment:9">↑ 9</a> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/adamsilverstein"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=adamsilverstein" height="24" width="24"/> adamsilverstein</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-05T15%3A56%3A53Z&precision=second" title="2013-01-05T15:56:53Z in Timeline">9 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> Replying to <a href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120#comment:9" title="Comment 9 for Ticket #23120">SergeyBiryukov</a>: </p> <blockquote class="citation"> <p> <a class="attachment" href="/web/20130114235743/http://core.trac.wordpress.org/attachment/ticket/23120/23120.patch" title="Attachment '23120.patch' in Ticket #23120">23120.patch</a><a class="trac-rawlink" href="/web/20130114235743/http://core.trac.wordpress.org/raw-attachment/ticket/23120/23120.patch" title="Download"></a>: </p> <ul><li>Removes the class after hiding the element, otherwise the spinner image no longer appears on next click. </li><li>When saving the order after dragging widgets, only displays the spinner in sidebar header (as it is now), not in each widget. </li><li>Adds the widget object as a context to the selector, in order to only animate the spinner in the current widget. </li></ul></blockquote> <p> looks good. i had added the class removal on my end, but you beat me to it. plus your patch adds the widget context to the selection which makes sense, thanks. </p> </div> </div> <div class="change" id="trac-change-12"> <div class="change"> <h3 class="change" id="comment:12"> <span class="threading"> <span id="comment:12" class="cnum"> <a href="#comment:12">comment:12</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130114235743/http://profiles.wordpress.org/SergeyBiryukov"> <img src="//web.archive.org/web/20130114235743im_/http://wordpress.org/grav-redirect.php?user=SergeyBiryukov" height="24" width="24"/> SergeyBiryukov</a> — <a class="timeline" href="/web/20130114235743/http://core.trac.wordpress.org/timeline?from=2013-01-09T01%3A44%3A17Z&precision=second" title="2013-01-09T01:44:17Z in Timeline">6 days</a> ago </span> </h3> </div> <div class="comment searchable"> <p> Related: <a class="new ticket" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/22839" title="defect (bug): Toggle spinners by adding/removing a class instead of show()/hide() (new)">#22839</a> </p> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/web/20130114235743/http://core.trac.wordpress.org/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/web/20130114235743/http://core.trac.wordpress.org/ticket/23120?format=rss" class="rss">RSS Feed</a> </li> </ul> </div> </div> <div id="footer" lang="en" xml:lang="en"><hr/> <a id="tracpowered" href="https://web.archive.org/web/20130114235743/http://trac.edgewall.org/"><img src="/web/20130114235743im_/http://core.trac.wordpress.org/chrome/common/trac_logo_mini.png" height="30" width="107" alt="Trac Powered"/></a> <p class="left">Powered by <a href="/web/20130114235743/http://core.trac.wordpress.org/about"><strong>Trac 0.12.4</strong></a><br/> By <a href="https://web.archive.org/web/20130114235743/http://www.edgewall.org/">Edgewall Software</a>.</p> <p class="right">A <a href="https://web.archive.org/web/20130114235743/http://wordpress.org/">WordPress</a> Project</p> </div> <div id="sitefooter"> </div> <script src="//web.archive.org/web/20130114235743js_/http://wordpress.org/js/trac/wp-trac.js?1"></script> <script type="text/javascript"> var gaJsHost = (("https:" == document.location.protocol) ? "https://web.archive.org/web/20130114235743/https://ssl." : "https://web.archive.org/web/20130114235743/http://www."); document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E")); </script> <script type="text/javascript"> try { var pageTracker = _gat._getTracker("UA-52447-27"); pageTracker._trackPageview(); } catch(err) {}</script> </body> </html>

CINXE.COM

#23120 (There should be indication that widget settings have been saved) – WordPress Trac