CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: "Jason Dravet": RFC: add udev support to parport_pc</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by "Jason Dravet"" href="/groupie.php?aid=30714" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/31"> [31]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/31/105" onclick="this.href='/lkml/headers'+'/2005/12/31/105';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/31/105">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/31/105">First message in thread</a></li><li class="origin"><a href="/lkml/2005/12/31/109">"Jason Dravet"</a><ul><li><a href="/lkml/2005/12/31/109">Jan Engelhardt</a><ul><li><a href="/lkml/2005/12/31/113">"Jason Dravet"</a><ul><li><a href="/lkml/2005/12/31/133">Jan Engelhardt</a></li></ul></li><li><a href="/lkml/2005/12/31/125">"Jason Dravet"</a></li></ul></li><li><a href="/lkml/2005/12/31/112">Jiri Slaby</a><ul><li><a href="/lkml/2005/12/31/114">"Jason Dravet"</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/12/31/105/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">From</td><td class="rp" itemprop="author">"Jason Dravet" <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">RFC: add udev support to parport_pc</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Sat, 31 Dec 2005 11:20:00 -0600</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Here is a patch to parport_pc.c that adds udev support. Without it sysfs <br />does not have enough information to give to udev so the lp and parport nodes <br />can be created. The only problem I have is the kernel_oops when I do the <br />following: insmod parport, insmod parport_pc, rmmod parport_pc, rmmod <br />parport, insmod parport, insmod parport_pc, rmmod parport_pc, kernel oops. <br />From the part of the traceback I can read the problem is in parport_pc_exit. <br /> Any help in tracking down the problem would be appreciated. If this is <br />acceptable how can I get this added to the mainline? This is my first patch <br />so please be gentle.<br /><br />Thanks,<br />Jason Dravet<br /><br />Signed-off-by: Jason Dravet <dravet@hotmail.com><br />--- /usr/src/linux-2.6.14/drivers/parport/parport_pc.c.orig 2005-12-30 <br />13:52:48.000000000 -0600<br />+++ /usr/src/linux-2.6.14/drivers/parport/parport_pc.c 2005-12-30 <br />19:56:20.000000000 -0600<br />@@ -55,6 +55,7 @@<br />#include <linux/pci.h><br />#include <linux/pnp.h><br />#include <linux/sysctl.h><br />+#include <linux/sysfs.h><br /><br />#include <asm/io.h><br />#include <asm/dma.h><br />@@ -99,6 +100,8 @@ static struct superio_struct { /* For Su<br /> int dma;<br />} superios[NR_SUPERIOS] __devinitdata = { {0,},};<br /><br />+static struct class *parallel_class;<br />+<br />static int user_specified;<br />#if defined(CONFIG_PARPORT_PC_SUPERIO) || \<br /> (defined(CONFIG_PARPORT_1284) && defined(CONFIG_PARPORT_PC_FIFO))<br />@@ -2232,6 +2235,25 @@ struct parport *parport_pc_probe_port (u<br /> is mandatory (see above) */<br /> p->dma = PARPORT_DMA_NONE;<br /><br />+ parallel_class = class_create(THIS_MODULE, "lp");<br />+ if (p->base == 888) /* 888 is dec for 378h */<br />+ {<br />+ class_device_create(parallel_class, NULL, MKDEV(6, 0), NULL, "lp0");<br />+ class_device_create(parallel_class, NULL, MKDEV(99, 0), NULL, <br />"parport0");<br />+ }<br />+<br />+ if (p->base == 632) /* 632 is dec for 278h */<br />+ {<br />+ class_device_create(parallel_class, NULL, MKDEV(6, 1), NULL, "lp1");<br />+ class_device_create(parallel_class, NULL, MKDEV(99, 1), NULL, <br />"parport1");<br />+ }<br />+<br />+ if (p->base == 956) /* 956 is dec for 3BCh */<br />+ {<br />+ class_device_create(parallel_class, NULL, MKDEV(6, 2), NULL, "lp2");<br />+ class_device_create(parallel_class, NULL, MKDEV(99, 2), NULL, <br />"parport2");<br />+ }<br />+<br />#ifdef CONFIG_PARPORT_PC_FIFO<br /> if (parport_ECP_supported(p) &&<br /> p->dma != PARPORT_DMA_NOFIFO &&<br />@@ -3406,6 +3428,13 @@ static void __exit parport_pc_exit(void)<br /> if (pnp_registered_parport)<br /> pnp_unregister_driver (&parport_pc_pnp_driver);<br /><br />+ class_device_destroy(parallel_class, MKDEV(99, 2));<br />+ class_device_destroy(parallel_class, MKDEV(6, 2));<br />+ class_device_destroy(parallel_class, MKDEV(99, 1));<br />+ class_device_destroy(parallel_class, MKDEV(6, 1));<br />+ class_device_destroy(parallel_class, MKDEV(99, 0));<br />+ class_device_destroy(parallel_class, MKDEV(6, 0));<br />+<br /> spin_lock(&ports_lock);<br /> while (!list_empty(&ports_list)) {<br /> struct parport_pc_private *priv;<br /><br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-31 18:22 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>