CINXE.COM

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US" lang="en-US"> <head> <link rel="icon" href="/static/f9b6f94339cb/hgicon.png" type="image/png" /> <meta name="robots" content="index, nofollow"/> <link rel="stylesheet" href="/static/f9b6f94339cb/style-gitweb.css" type="text/css" /> <style type="text/css"> div.feed { float: right; } a img { border-width: 0px; } div.log_link { width: 80px; background-color: white; } div.log_body { padding-left: 96px; } </style> <script type="text/javascript" src="/static/f9b6f94339cb/mercurial.js"></script> <meta property="og:image" content="/static/f9b6f94339cb/moz-logo-bw-rgb.svg"/> <meta property="og:type" content="website"/> <title>mozilla-central: changeset 506470:cdf525897bffc445c4c860225ecb42eda5925a86</title> <link rel="alternate" type="application/atom+xml" href="/mozilla-central/atom-log" title="Atom feed for mozilla-central"/> <link rel="alternate" type="application/rss+xml" href="/mozilla-central/rss-log" title="RSS feed for mozilla-central"/> <meta property="og:title" content="mozilla-central @ cdf525897bff" /> <meta property="og:url" content="/mozilla-central/rev/cdf525897bff" /> <meta property="og:description" content="Bug 1507180 - Make copy of list before iterating over it r=dom-workers-and-storage-reviewers,sg" /> </head> <body> <div class="page_header"> <div class="logo"> <a href="https://firefox-source-docs.mozilla.org/contributing/vcs/mercurial.html"> <img src="/static/f9b6f94339cb/moz-logo-bw-rgb.svg" alt="mercurial" /> </a> </div> <a href="/">Mercurial</a> > <a href="/mozilla-central">mozilla-central</a> / changeset / cdf525897bffc445c4c860225ecb42eda5925a86 </div> <div class="page_nav"> <div> <a href="/mozilla-central/summary">summary</a> | <a href="/mozilla-central/shortlog/cdf525897bff">shortlog</a> | <a href="/mozilla-central/log/cdf525897bff">changelog</a> | <a href="/mozilla-central/pushloghtml">pushlog</a> | <a href="/mozilla-central/graph/cdf525897bff">graph</a> | <a href="/mozilla-central/tags">tags</a> | <a href="/mozilla-central/bookmarks">bookmarks</a> | <a href="/mozilla-central/branches">branches</a> | <a href="/mozilla-central/file/cdf525897bff">files</a> | changeset | <a href="/mozilla-central/raw-rev/cdf525897bff">raw</a> | <a href="/mozilla-central/archive/cdf525897bff.zip">zip</a> | <a href="/mozilla-central/help">help</a> </div> <div class="search"> <form id="searchform" action="/mozilla-central/log"> <input name="rev" type="text" value="" size="40" /> <div id="hint">Find changesets by keywords (author, files, the commit message), revision number or hash, or <a href="/mozilla-central/help/revsets">revset expression</a>.</div> </form> </div> </div> <div class="title"> <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1507180">Bug 1507180</a> - Make copy of list before iterating over it r=dom-workers-and-storage-reviewers,sg <span class="logtags"></span> </div> <div class="title_text"> <table cellspacing="0"> <tr><td>author</td><td>Yaron Tausky <ytausky@mozilla.com></td></tr> <tr><td></td><td class="date age">Wed, 04 Dec 2019 10:47:30 +0000</td></tr> <tr> <td>changeset 506470</td> <td style="font-family:monospace"><a class="list" href="/mozilla-central/rev/cdf525897bffc445c4c860225ecb42eda5925a86">cdf525897bffc445c4c860225ecb42eda5925a86</a></td> </tr> <tr> <td>parent 506469</td> <td style="font-family:monospace"> <a class="list" href="/mozilla-central/rev/99abe5757ee597f98475e89bb1bd730708ecc67f">99abe5757ee597f98475e89bb1bd730708ecc67f</a> </td> </tr> <tr> <td>child 506471</td> <td style="font-family:monospace"> <a class="list" href="/mozilla-central/rev/a336ad33f55374536c61865e1a04ae022e0ef8b2">a336ad33f55374536c61865e1a04ae022e0ef8b2</a> </td> </tr> <tr><td>push id</td><td><a href="/mozilla-central/pushloghtml?changeset=cdf525897bffc445c4c860225ecb42eda5925a86">36904</a></td></tr> <tr><td>push user</td><td>ncsoregi@mozilla.com</td></tr> <tr><td>push date</td><td class="date age">Wed, 11 Dec 2019 17:42:45 +0000</td></tr> <tr><td>treeherder</td><td>mozilla-central@b823b005f00e [<a href="https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=b823b005f00e2b9ea65145289bea41db07ad8a2e">default view</a>] [<a href="https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=b823b005f00e2b9ea65145289bea41db07ad8a2e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception">failures only]</td></tr> <tr><td>perfherder</td><td>[<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=b823b005f00e2b9ea65145289bea41db07ad8a2e&newProject=mozilla-central&newRevision=8c086b8b46df392416b80553fa804a1503fc6b9c&framework=1" target="_blank">talos</a>] [<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=b823b005f00e2b9ea65145289bea41db07ad8a2e&newProject=mozilla-central&newRevision=8c086b8b46df392416b80553fa804a1503fc6b9c&framework=2" target="_blank">build metrics</a>] [<a href="https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=b823b005f00e2b9ea65145289bea41db07ad8a2e&newProject=mozilla-central&newRevision=8c086b8b46df392416b80553fa804a1503fc6b9c&framework=6" target="_blank">platform microbench</a>] (compared to previous push)</td></tr> <tr><td>reviewers</td><td><a href="/mozilla-central/log?rev=reviewer%28dom-workers-and-storage-reviewers%29&revcount=50">dom-workers-and-storage-reviewers</a>, <a href="/mozilla-central/log?rev=reviewer%28sg%29&revcount=50">sg</a></td></tr> <tr><td>bugs</td><td><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1507180">1507180</a></td></tr> <tr><td>milestone</td><td>73.0a1</td></tr> <tr><td>first release with</td><td><div><div class="firefoxreleasecsetentry"> <div>nightly linux32</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/d74eec46c4ea1c3d7f287c359b51404425894ec5">d74eec46c4ea</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#d74eec46c4eanightlylinux3220191211214629">20191211214629</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-21-46-29-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly linux64</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/d74eec46c4ea1c3d7f287c359b51404425894ec5">d74eec46c4ea</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#d74eec46c4eanightlylinux6420191211214629">20191211214629</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-21-46-29-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly mac</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/d74eec46c4ea1c3d7f287c359b51404425894ec5">d74eec46c4ea</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#d74eec46c4eanightlymac20191211214629">20191211214629</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-21-46-29-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win32</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/d74eec46c4ea1c3d7f287c359b51404425894ec5">d74eec46c4ea</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#d74eec46c4eanightlywin3220191211214629">20191211214629</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-21-46-29-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win64</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/d74eec46c4ea1c3d7f287c359b51404425894ec5">d74eec46c4ea</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#d74eec46c4eanightlywin6420191211214629">20191211214629</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-21-46-29-mozilla-central/">files</a> </div></div></div></td></tr> <tr><td>last release without</td><td><div><div class="firefoxreleasecsetentry"> <div>nightly linux32</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/f83f2771414cf5938a46f44e1b11cdcd5181ea0f">f83f2771414c</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#f83f2771414cnightlylinux3220191211094640">20191211094640</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-09-46-40-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly linux64</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/f83f2771414cf5938a46f44e1b11cdcd5181ea0f">f83f2771414c</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#f83f2771414cnightlylinux6420191211094640">20191211094640</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-09-46-40-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly mac</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/f83f2771414cf5938a46f44e1b11cdcd5181ea0f">f83f2771414c</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#f83f2771414cnightlymac20191211094640">20191211094640</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-09-46-40-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win32</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/f83f2771414cf5938a46f44e1b11cdcd5181ea0f">f83f2771414c</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#f83f2771414cnightlywin3220191211094640">20191211094640</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-09-46-40-mozilla-central/">files</a> </div></div><div class="firefoxreleasecsetentry"> <div>nightly win64</div> <div class="firefoxreleasecsetdetails"> <a href="/mozilla-central/rev/f83f2771414cf5938a46f44e1b11cdcd5181ea0f">f83f2771414c</a> / 73.0a1 / <a href="/mozilla-central/firefoxreleases#f83f2771414cnightlywin6420191211094640">20191211094640</a> / <a href="https://archive.mozilla.org/pub/firefox/nightly/2019/12/2019-12-11-09-46-40-mozilla-central/">files</a> </div></div></div></td></tr> </table></div> <div class="page_body description"><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1507180">Bug 1507180</a> - Make copy of list before iterating over it r=dom-workers-and-storage-reviewers,sg Differential Revision: <a href="https://phabricator.services.mozilla.com/D55286">https://phabricator.services.mozilla.com/D55286</a></div> <div class="list_head"></div> <div class="title_text"> <table cellspacing="0"> <tr class="parity0"> <td><a class="list" href="/mozilla-central/diff/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">dom/cache/StreamControl.cpp</a></td> <td></td> <td class="link"> <a href="/mozilla-central/file/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">file</a> | <a href="/mozilla-central/annotate/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">annotate</a> | <a href="/mozilla-central/diff/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">diff</a> | <a href="/mozilla-central/comparison/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">comparison</a> | <a href="/mozilla-central/log/cdf525897bffc445c4c860225ecb42eda5925a86/dom/cache/StreamControl.cpp">revisions</a> </td> </tr> </table></div> <div class="page_body diffblocks"><div class="diffblock"><pre class="sourcelines"> <a href="#l1.1"></a><span id="l1.1" class="difflineminus">--- a/dom/cache/StreamControl.cpp</span> <a href="#l1.2"></a><span id="l1.2" class="difflineplus">+++ b/dom/cache/StreamControl.cpp</span> <a href="#l1.3"></a><span id="l1.3" class="difflineat">@@ -52,17 +52,18 @@ void StreamControl::CloseReadStreams(con</span> <a href="#l1.4"></a><span id="l1.4"> }</span> <a href="#l1.5"></a><span id="l1.5"> </span> <a href="#l1.6"></a><span id="l1.6"> MOZ_DIAGNOSTIC_ASSERT(closedCount > 0);</span> <a href="#l1.7"></a><span id="l1.7"> }</span> <a href="#l1.8"></a><span id="l1.8"> </span> <a href="#l1.9"></a><span id="l1.9"> void StreamControl::CloseAllReadStreams() {</span> <a href="#l1.10"></a><span id="l1.10"> AssertOwningThread();</span> <a href="#l1.11"></a><span id="l1.11"> </span> <a href="#l1.12"></a><span id="l1.12" class="difflineminus">- ReadStreamList::ForwardIterator iter(mReadStreamList);</span> <a href="#l1.13"></a><span id="l1.13" class="difflineplus">+ auto readStreamList = mReadStreamList;</span> <a href="#l1.14"></a><span id="l1.14" class="difflineplus">+ ReadStreamList::ForwardIterator iter(readStreamList);</span> <a href="#l1.15"></a><span id="l1.15"> while (iter.HasMore()) {</span> <a href="#l1.16"></a><span id="l1.16"> iter.GetNext()->CloseStream();</span> <a href="#l1.17"></a><span id="l1.17"> }</span> <a href="#l1.18"></a><span id="l1.18"> }</span> <a href="#l1.19"></a><span id="l1.19"> </span> <a href="#l1.20"></a><span id="l1.20"> void StreamControl::CloseAllReadStreamsWithoutReporting() {</span> <a href="#l1.21"></a><span id="l1.21"> AssertOwningThread();</span> <a href="#l1.22"></a><span id="l1.22"> </span></pre></div></div> <div class="page_footer"> <div class="page_footer_text">mozilla-central</div> <div class="page_footer_text" style="padding-left: 10px">Deployed from <a href="https://hg.mozilla.org/hgcustom/version-control-tools/rev/f9b6f94339cb">f9b6f94339cb</a> at 2025-02-03T13:09:28Z.</div> <div class="rss_logo"> <a href="/mozilla-central/rss-log">RSS</a> <a href="/mozilla-central/atom-log">Atom</a> </div> <br /> </div> </body> </html>