CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: john stultz: Re: [PATCH 8/11] Time: i386 Conversion - part 4: ACPI PM variable renaming and config change.</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by john stultz" href="/groupie.php?aid=1263" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2006"> [2006]</a> 聽 <a class="nb" href="/lkml/2006/1"> [Jan]</a> 聽 <a class="nb" href="/lkml/2006/1/4"> [4]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2006/1/4/72" onclick="this.href='/lkml/headers'+'/2006/1/4/72';">[headers]</a>聽 <a href="/lkml/bounce/2006/1/4/72">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/15/405">First message in thread</a></li><li><a href="/lkml/2005/12/15/407">john stultz</a><ul><li><a href="/lkml/2006/1/3/509">Andrew Morton</a><ul><li class="origin"><a href="/lkml/2006/1/4/76">john stultz</a><ul><li><a href="/lkml/2006/1/4/76">Andrew Morton</a></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 8/11] Time: i386 Conversion - part 4: ACPI PM variable renaming and config change.</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">john stultz <></td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 04 Jan 2006 02:33:14 -0800</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Tue, 2006-01-03 at 16:35 -0800, Andrew Morton wrote:<br />> john stultz <johnstul@us.ibm.com> wrote:<br />> ><br />> > Andrew, All,<br />> > The conversion of i386 to use the generic timeofday subsystem <br />> > has been split into 6 parts. This patch, the fourth of six, renames <br />> > some ACPI PM variables and removes the CONFIG_X86_PM_TIMER option. <br />> > <br />> > It applies on top of my timeofday-arch-i386-part3 patch. This patch is <br />> > part the timeofday-arch-i386 patchset, so without the following parts <br />> > it is not expected to compile.<br />> > <br />> > Andrew, please consider for inclusion into your tree.<br />> <br />> Problems:<br />> <br />> - The changelogs aren't terribly good.<br />> <br />> When preparing changelogs, please think of how they will look in the<br />> final git record. This means that metainfo concerning preceding patch<br />> dependencies, the number of patches in the series, etc is irrelevant. <br />> The sequence numbering in the Subject: (which you have done correctly) is<br />> sufficient.<br />> <br />> Text such as "please apply", while nice, just has to be removed by<br />> myself. I'm not offended if it doesn't get sent ;)<br />> <br />> Alert readers will note that I also strip out text such as "this patch<br />> does X" from the changelogs. Because such text is redundant once the<br />> patch is merged up. We _know_ it's a patch - otherwise it wouldn't be in<br />> the git tree.<br />> <br />> And once we strip out the above irrelevencies, your changelogs are<br />> awfully spartan for such a substantial piece of work. Isn't there more<br />> to be said?<br /><br />Good point. I'll fix this in the next release. <br /><br />> - The fact that the kernel won't compile without the succeeding patches<br />> in the series is unfortunate. If someone is trying to locate an<br />> unrelated regression via `git bisect' and the bisection process happens<br />> to land them at one of your it-wont-compile points then they have a big<br />> problem. It can pretty much screw up the whole bisection process.<br />> <br />> So please try to ensure that the kernel will compile and probably run<br />> at all points of a patch series. If that's too hard then just fold the<br />> separate patches into one larger patch (with appropriately expanded<br />> changelog) to achieve the desired result.<br /><br />Ok, I'll try to re-arrange the patches so they compile at each step.<br /><br /><br />> Anyway, I'll tenatively merge these patches into next -mm so they can get a<br />> bit of testing. Which causes a problem, because you don't then have a tree<br />> against which to raise a new patch series.<br /><br />I greatly appreciate the inclusion! I'm hoping a bit of time in -mm will<br />shake out any remaining bugs. <br /><br />Although I'm not sure I understand what you mean about me not having a<br />tree? Do you mean a public git tree? <br /><br /><br />> So perhaps it would be best if you were to<br />> <br />> a) Tell me which patches to fold into which other patches to generate a<br />> series which compiles at every stage and<br />> <br />> b) Send me a new set of changelogs for the resulting patch series.<br /><br />I've got a set of chained git trees that store each patch, so its very<br />easy to re-generate the changelog + patches after I've re-arranged them<br />as you suggested.<br /><br />Would a new patch-set to replace the current patchset be preferred here<br />or do you just want the above? <br /><br />Similarly, if we do run into bugs, would you prefer incremental fixup<br />patches or cumulative replacement patches when a new release of the<br />patchset is generated?<br /><br />I'm just getting back from vacation tonight, so I'll send whatever you<br />prefer sometime tomorrow.<br /><br />Sorry for the stumbling here, I really appreciate the feedback! <br /><br />thanks again,<br />-john<br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2006-01-04 11:31 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>