LKML: "Philippe De Muyter": Re: [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: "Philippe De Muyter": Re: [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by "Philippe De Muyter"" href="/groupie.php?aid=7791" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/14"> [14]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/14/188" onclick="this.href='/lkml/headers'+'/2005/12/14/188';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/14/188">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/8/211">First message in thread</a></li><li><a href="/lkml/2005/12/8/211">"Philippe De Muyter"</a><ul><li><a href="/lkml/2005/12/12/52">Mauro Carvalho Chehab</a><ul><li class="origin"><a href="">"Philippe De Muyter"</a></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 14 Dec 2005 17:42:56 +0100 (CET)</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">"Philippe De Muyter" <></td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Mauro Carvalho Chehab wrote :<br />> Em Qui, 2005-12-08 脿s 22:05 +0100, Philippe De Muyter escreveu:<br />> > This patch adds the current process name in the media/video/bttv ioctl debug.<br />> <br />> Philippe, <br />> <br />> I'm in doubt about the relevance of this patch. Why do you think it is<br />> important to have process name at ioctl debug?<br /><br />I needed to add that when testing my v4l2-compat patches with xawtv. It took<br />me a long time to discover that some ioctls were issued by xawtv itself,<br />others by v4l-conf and others yet by the xvideo/v4l module of my Xserver.<br />With the process name in the ioctl debugging, I think that my tests and<br />development would have been much faster.<br /><br />Philippe<br /><br />> <br />> PS.: Please address these patches to V4L Mailing List.<br />> > <br />> > Signed-off-by: Philippe De Muyter <phdm@macqel.be><br />> > <br />> > ---<br />> > <br />> > --- linux/drivers/media/video/bttv-driver.c.orig 2005-08-29 01:41:01.000000000 +0200<br />> > +++ linux/drivers/media/video/bttv-driver.c 2005-12-08 20:59:45.000000000 +0100<br />> > @@ -2181,19 +2182,19 @@ static int bttv_do_ioctl(struct inode *i<br />> > int retval = 0;<br />> > <br />> > if (bttv_debug > 1) {<br />> > + printk("bttv%d: %s: ioctl 0x%x ", btv->c.nr, current->comm,<br />> > + cmd);<br />> > switch (_IOC_TYPE(cmd)) {<br />> > case 'v':<br />> > - printk("bttv%d: ioctl 0x%x (v4l1, VIDIOC%s)\n",<br />> > - btv->c.nr, cmd, (_IOC_NR(cmd) < V4L1_IOCTLS) ?<br />> > + printk("(v4l1, VIDIOC%s)\n",<br />> > + (_IOC_NR(cmd) < V4L1_IOCTLS) ?<br />> > v4l1_ioctls[_IOC_NR(cmd)] : "???");<br />> > break;<br />> > case 'V':<br />> > - printk("bttv%d: ioctl 0x%x (v4l2, %s)\n",<br />> > - btv->c.nr, cmd, v4l2_ioctl_names[_IOC_NR(cmd)]);<br />> > + printk("(v4l2, %s)\n", v4l2_ioctl_names[_IOC_NR(cmd)]);<br />> > break;<br />> > default:<br />> > - printk("bttv%d: ioctl 0x%x (???)\n",<br />> > - btv->c.nr, cmd);<br />> > + printk("(???)\n");<br />> > }<br />> > }<br />> > if (btv->errors)<br />> > -<br />> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />> > the body of a message to majordomo@vger.kernel.org<br />> > More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />> > Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br />> <br /><br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-14 17:45 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: "Philippe De Muyter": Re: [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug