#177 (Translaton set sort order)

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><script type="text/javascript" src="/_static/js/bundle-playback.js?v=HxkREWBo" charset="utf-8"></script> <script type="text/javascript" src="/_static/js/wombat.js?v=txqj7nKC" charset="utf-8"></script> <script>window.RufflePlayer=window.RufflePlayer||{};window.RufflePlayer.config={"autoplay":"on","unmuteOverlay":"hidden"};</script> <script type="text/javascript" src="/_static/js/ruffle/ruffle.js"></script> <script type="text/javascript"> __wm.init("https://web.archive.org/web"); __wm.wombat("http://glotpress.trac.wordpress.org/ticket/177","20130119080148","https://web.archive.org/","web","/_static/", "1358582508"); </script> <link rel="stylesheet" type="text/css" href="/_static/css/banner-styles.css?v=S1zqJCYt" /> <link rel="stylesheet" type="text/css" href="/_static/css/iconochive.css?v=3PDvdIFv" />  <title> #177 (Translaton set sort order) – GlotPress </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>  <link rel="search" href="/web/20130119080148/http://glotpress.trac.wordpress.org/search"/> <link rel="prev" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/176" title="Ticket #176"/> <link rel="last" href="/ticket/228" title="Ticket #228"/> <link rel="help" href="/wiki/TracGuide"/> <link rel="alternate" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=csv" type="text/csv" class="csv" title="Comma-delimited Text"/><link rel="alternate" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text"/><link rel="alternate" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=rss" type="application/rss+xml" class="rss" title="RSS Feed"/> <link rel="next" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/178" title="Ticket #178"/> <link rel="start" href="/wiki"/> <link rel="stylesheet" href="/web/20130119080148cs_/http://glotpress.trac.wordpress.org/chrome/common/css/trac.css" type="text/css"/><link rel="stylesheet" href="/web/20130119080148cs_/http://glotpress.trac.wordpress.org/chrome/common/css/ticket.css" type="text/css"/> <link rel="first" href="/ticket/1" title="Ticket #1"/> <link rel="shortcut icon" href="/web/20130119080148im_/http://glotpress.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link rel="icon" href="/web/20130119080148im_/http://glotpress.trac.wordpress.org/chrome/common/trac.ico" type="image/x-icon"/> <link type="application/opensearchdescription+xml" rel="search" href="/web/20130119080148/http://glotpress.trac.wordpress.org/search/opensearch" title="Search GlotPress"/> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="83e82eeb78f5a886aef66c9b"; </script> <script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/jquery.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/babel.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/trac.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/search.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/folding.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/wikitoolbar.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/resizer.js"></script><script type="text/javascript" src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/common/js/auto_preview.js"></script>  <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); var args = {realm: "ticket", id: 177, escape_newlines: 1} $("#comment").autoPreview("/wiki_render", args, function(textarea, text, rendered) { $("#ticketchange div.comment").html(rendered); if (rendered) $("#ticketchange").show(); else if ($("#ticketchange ul.changes").length == 0) $("#ticketchange").hide(); }); $("#trac-comment-editor textarea").autoPreview("/wiki_render", args, function(textarea, text, rendered) { var comment = $("#trac-comment-editor").next("div.comment"); comment.html(rendered); if (rendered) comment.show(); else comment.hide(); }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); /* only enable control elements for the currently selected action */ var actions = $("#action input[name='action']"); function updateActionFields() { actions.each(function () { $(this).siblings().find("*[id]").enable($(this).checked()); $(this).siblings().filter("*[id]").enable($(this).checked()); }); } actions.click(updateActionFields); updateActionFields(); }); </script> <script src="//web.archive.org/web/20130119080148js_/http://openatd.svn.wordpress.org/atd-jquery/scripts/jquery.atd.textarea.js"></script> <script src="//web.archive.org/web/20130119080148js_/http://openatd.svn.wordpress.org/atd-jquery/scripts/csshttprequest.js"></script> <link rel="stylesheet" type="text/css" media="screen" href="//web.archive.org/web/20130119080148cs_/http://openatd.svn.wordpress.org/atd-jquery/css/atd.css"/> <style type="text/css"> #content.ticket { margin-left: 20px; } #altlinks { width: 58em; margin-left: 20px; } span.avatar img { float: left; margin: 0 8px 0 -4px } img.avatar { float: left; margin: 0 6px 0 -30px } .wp-notice, .wp-caution { padding: 0 1.2em; margin: 1em 0 } .wp-notice { background: #eff6f9; border: 2px solid #21759b } .wp-caution { border: 2px solid #999; background: #ffb; } .wp-notice li, .wp-caution li { margin-bottom: 0.5em } .wikitoolbar { width: 258px } .AtD_proofread_button, .AtD_edit_button { float: left; width: 22px; height: 16px; border: 1px solid #fff; border-left-color: #d7d7d7; background-repeat: no-repeat; background-position: center center } .AtD_proofread_button:hover, .AtD_edit_button:hover { border-color: #fb2; } .tickets tbody td.summary, .reports tbody td.summary { white-space: normal; } #ticket table.properties :link, #ticket table.properties :visited { color: #000 } #ticket table.properties td, #ticket table.properties th { font-size: 81%; line-height: 1.4 } td[headers=h_keywords] a { margin-right: 10px; white-space: nowrap } dl.attachments dt { padding-bottom: 4px } #attachments dd { margin-left: 10px } #properties .fullrow input { width: 97.5%; } #properties .col1 input { width: 87.5%; } #properties .col2 input { width: 92.5%; } :link, :visited, dt em, .milestone .info h2 em, #content.build h2.config :link, #content.build h2.config :visited { color: #21759b; } </style> <link rel="stylesheet" href="/web/20130119080148cs_/http://glotpress.trac.wordpress.org/chrome/site/keywords.css"/> </head> <body> <div id="siteheader"> </div> <div id="banner"> <div id="header"> <a id="logo" href="https://web.archive.org/web/20130119080148/http://glotpress.trac.wordpress.org/"><img src="https://web.archive.org/web/20130119080148im_/http://wordpress.org/images/glotpress-logo.png" alt="GlotPress" height="76"/></a> </div> <form id="search" action="/web/20130119080148/http://glotpress.trac.wordpress.org/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value=""/> <input type="submit" value="Search"/> </div> </form> <div id="metanav" class="nav"> <ul> <li class="first"><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/login">Login</a></li><li><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/prefs">Preferences</a></li><li><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/wiki/TracGuide">Help/Guide</a></li><li class="last"><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/about">About Trac</a></li> </ul> </div> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/wiki">Wiki</a></li><li><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline">Timeline</a></li><li><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/roadmap">Roadmap</a></li><li><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/browser">Browse Source</a></li><li class="active"><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/report">View Tickets</a></li><li class="last"><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/search">Search</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/176" title="Ticket #176">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/178" title="Ticket #178">Next Ticket</a> →</span></li> </ul> <hr/> </div> <div id="content" class="ticket"> <h1 id="trac-ticket-title"> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177">Ticket #177</a> <span class="status">(reopened enhancement)</span> </h1> <div id="ticket"> <div class="date"> <p>Opened <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-01-22T02%3A45%3A39Z&precision=second" title="2012-01-22T02:45:39Z in Timeline">12 months</a> ago</p> <p>Last modified <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T12%3A00%3A08Z&precision=second" title="2012-11-02T12:00:08Z in Timeline">3 months</a> ago</p> </div> <h2 class="summary searchable">Translaton set sort order</h2> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/usermrpapa"> <img class="avatar" src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=usermrpapa" height="24" width="24"/> </a> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/query?status=!closed&reporter=usermrpapa">usermrpapa</a> </td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> </td> </tr> <tr> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/query?status=!closed&priority=normal">normal</a> </td> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="missing milestone"></a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/query?status=!closed&component=interface">interface</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/query?status=!closed&version=0.1">0.1</a> </td> </tr><tr> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/query?status=!closed&keywords=~2nd-opinion">2nd-opinion</a> </td> <th id="h_cc"> Cc: </th> <td headers="h_cc" class="searchable"> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p> It would be nice to be able to change the sort order of translations for project instead of it always being by current count. it seems to confuse a lot of users.<br/> </p> <p> a simple filter allows users to customize the sort to their liking.<br/> </p> <p> patch attached.<br/> </p> </div> </div> </div> <div id="attachments"> <h2 class="foldable">Attachments</h2> <div> <dl class="attachments"> <dt> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/attachment/ticket/177/sorting.patch" title="View attachment">sorting.patch</a><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/raw-attachment/ticket/177/sorting.patch" class="trac-rawlink" title="Download"></a> (<span title="740 bytes">740 bytes</span>) - added by <em>usermrpapa</em> <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-01-22T02%3A45%3A53Z&precision=second" title="2012-01-22T02:45:53Z in Timeline">12 months</a> ago. </dt> </dl> </div> </div> <div> <h2 class="foldable">Change History</h2> <div id="changelog"> <div class="change"> <div class="change"> <h3 class="change"> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/usermrpapa"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=usermrpapa" height="24" width="24"/> usermrpapa</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-01-22T02%3A45%3A53Z&precision=second" title="2012-01-22T02:45:53Z in Timeline">12 months</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Attachment</strong> <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/attachment/ticket/177/sorting.patch"><em>sorting.patch</em></a><a href="/web/20130119080148/http://glotpress.trac.wordpress.org/raw-attachment/ticket/177/sorting.patch" title="Download" class="trac-rawlink"></a> added </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-1"> <div class="change"> <h3 class="change" id="comment:1"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">comment:1</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/scribu"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=scribu" height="24" width="24"/> scribu</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-10-31T01%3A14%3A31Z&precision=second" title="2012-10-31T01:14:31Z in Timeline">3 months</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>needs-patch</em> added; <em>has-patch</em> removed </li><li> <strong>Status</strong> changed from <em>new</em> to <em>closed</em> </li><li> <strong>Resolution</strong> set to <em>duplicate</em> </li><li> <strong>Milestone</strong> <em>1.0</em> deleted </li> </ul> <div class="comment searchable"> <p> The patch doesn't work because the filter is outside the lambda. You'd need to:<br/> </p> <p> a) convert it to a proper function first and then add the filter inside it<br/> b) apply the filter to the callback, so outside the lambda<br/> </p> <p> I also think that just having two options, alphabetical and translation count, would be enough.<br/> </p> <p> In general, I think <a class="new ticket" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/181" title="enhancement: Make translation-set table sortable (new)">#181</a> has a better approach, so marking as duplicate.<br/> </p> </div> </div> <div class="change" id="trac-change-2"> <div class="change"> <h3 class="change" id="comment:2"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">comment:2</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/usermrpapa"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=usermrpapa" height="24" width="24"/> usermrpapa</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T01%3A20%3A13Z&precision=second" title="2012-11-02T01:20:13Z in Timeline">3 months</a> ago </span> </h3> </div> <div class="comment searchable"> <p> not sure why you think it wont work... running on our site and working perfectly... users love it much better... "outside the lambda"???<br/> </p> <p> no issue though if the other ticket gets incorporated, but alas not yet...<br/> </p> </div> <div class="trac-lastedit "> Last edited <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T01%3A21%3A39Z&precision=second" title="2012-11-02T01:21:39Z in Timeline">3 months</a> ago by usermrpapa (<a href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?cversion=0&cnum_hist=2#comment:2">previous</a>) (<a href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?action=comment-diff&cnum=2&version=1">diff</a>) </div> </div> <div class="change" id="trac-change-3"> <div class="change"> <h3 class="change" id="comment:3"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">comment:3</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/usermrpapa"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=usermrpapa" height="24" width="24"/> usermrpapa</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T01%3A21%3A51Z&precision=second" title="2012-11-02T01:21:51Z in Timeline">3 months</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>has-patch</em> <em>2nd-opinion</em> added </li><li> <strong>Status</strong> changed from <em>closed</em> to <em>reopened</em> </li><li> <strong>Resolution</strong> <em>duplicate</em> deleted </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-4"> <div class="change"> <h3 class="change" id="comment:4"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">comment:4</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/usermrpapa"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=usermrpapa" height="24" width="24"/> usermrpapa</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T01%3A26%3A43Z&precision=second" title="2012-11-02T01:26:43Z in Timeline">3 months</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>needs-patch</em> removed </li> </ul> <div class="comment searchable"> </div> </div> <div class="change" id="trac-change-5"> <div class="change"> <h3 class="change" id="comment:5"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">comment:5</a> </span> </span> <span class="avatar"> <a href="https://web.archive.org/web/20130119080148/http://profiles.wordpress.org/scribu"> <img src="//web.archive.org/web/20130119080148im_/http://wordpress.org/grav-redirect.php?user=scribu" height="24" width="24"/> scribu</a> — <a class="timeline" href="/web/20130119080148/http://glotpress.trac.wordpress.org/timeline?from=2012-11-02T12%3A00%3A08Z&precision=second" title="2012-11-02T12:00:08Z in Timeline">3 months</a> ago </span> </h3> </div> <ul class="changes"> <li> <strong>Keywords</strong> <em>has-patch</em> removed </li> </ul> <div class="comment searchable"> <p> Yeah, I guess it does work, but you're essentially manipulating PHP code as a string, which is BAD.<br/> </p> <p> So, yes, it does need a new patch.<br/> </p> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/web/20130119080148/http://glotpress.trac.wordpress.org/ticket/177?format=rss" class="rss">RSS Feed</a> </li> </ul> </div> </div> <div id="footer" lang="en" xml:lang="en"><hr/> <a id="tracpowered" href="https://web.archive.org/web/20130119080148/http://trac.edgewall.org/"><img src="/web/20130119080148im_/http://glotpress.trac.wordpress.org/chrome/common/trac_logo_mini.png" height="30" width="107" alt="Trac Powered"/></a> <p class="left">Powered by <a href="/web/20130119080148/http://glotpress.trac.wordpress.org/about"><strong>Trac 0.12.4</strong></a><br/> By <a href="https://web.archive.org/web/20130119080148/http://www.edgewall.org/">Edgewall Software</a>.</p> <p class="right">A <a href="https://web.archive.org/web/20130119080148/http://wordpress.org/">WordPress</a> Project</p> </div> <div id="sitefooter"> </div> <script> jQuery(function($) { $('textarea').addProofreader(); $(document).ready(function(){ $('.AtD_proofread_button').each(function() { $(this).parent().appendTo( $(this).parents('fieldset').find('.wikitoolbar') ); }); $("#modify").parent().removeClass('collapsed'); if ( $('#wp-security-notice').length ) { $('#field-component').change( function() { $('#wp-security-notice').toggle( 'Security' === $(this).val() ); }); } }); }); </script> <script> wpKeywordsHide = [ 'commit', 'early', 'i18n-change' ]; </script> <script src="/web/20130119080148js_/http://glotpress.trac.wordpress.org/chrome/site/keywords.js"></script> </body> </html>

CINXE.COM

#177 (Translaton set sort order) – GlotPress