CINXE.COM
LKML: "Rafael J. Wysocki": Re: [PATCH][mm] swsusp: limit image size
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: "Rafael J. Wysocki": Re: [PATCH][mm] swsusp: limit image size</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by "Rafael J. Wysocki"" href="/groupie.php?aid=22829" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/9"> [9]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/9/226" onclick="this.href='/lkml/headers'+'/2005/12/9/226';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/9/226">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/7/319">First message in thread</a></li><li><a href="/lkml/2005/12/9/171">Stefan Seyfried</a><ul><li><a href="/lkml/2005/12/9/182">Pavel Machek</a><ul><li class="origin"><a href="/lkml/2005/12/10/62">"Rafael J. Wysocki"</a><ul><li><a href="/lkml/2005/12/10/62">"Rafael J. Wysocki"</a><ul><li><a href="/lkml/2005/12/10/73">Pavel Machek</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">From</td><td class="rp" itemprop="author">"Rafael J. Wysocki" <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH][mm] swsusp: limit image size</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 9 Dec 2005 23:08:19 +0100</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Hi,<br /><br />On Friday, 9 December 2005 20:17, Pavel Machek wrote:<br />> > >> What happens if IMAGE_SIZE is bigger than free swap? Do we "try harder"<br />> > >> or do we fail?<br />> > > <br />> > > First, with swsusp the image can't be bigger than 1/2 of lowmem (1/2 of RAM<br />> > > on x86-64) and the too great values of IMAGE_SIZE have no effect. Still, if<br />> > > the amount of free swap is smaller than 1/2 of RAM and the image happens<br />> > > to be bigger, we will fail.<br />> > <br />> > ok. This is not nice since we might fail without any _real_ need.<br /><br />That depends a good deal on how you define "real". :-)<br /><br />> > Can we make this parameter userspace-tweakable, so that my userspace app<br />> > can do something like (pseudocode):<br />> > <br />> > echo 500 > /sys/power/swsusp/imagesize<br />> > echo disk > /sys/power/state<br />> > R=$?<br />> > if [ $R -eq $ENOMEM ]; then<br />> > echo 100 > /sys/power/swsusp/imagesize # try again<br />> <br />> You can do 'echo 0' -- as small as possible.<br />> <br />> > echo disk > /sys/power/state<br />> > R=$?<br />> > fi<br />> > if [ $R -ne 0 ]; then<br />> > pop_up_some_loud_beeping_window "suspend failed!"<br />> > fi<br />> > <br />> > This would at least give us a chance for a second try. I know that Pavel<br />> > dislikes userspace tunables, but i dislike failing suspends ;-)<br />> <br />> Can we do that when we start seeing failed suspends? I think it will<br />> not happen. If we have reasonably-sized swap partition, it should be<br />> ok.<br /><br />Yes. Moreover, we can do something like that without a userspace<br />tunable, if we check for the free swap before we try to shrink memory.<br />This would take some time to implement, though, and I'd rather<br />like to do the userland interface first.<br /><br />The tunable may be useful to people who'd like to achieve the<br />maximum efficiency of suspend/resume and it would be a nice<br />feature to have, I think, but let's say we'll try to implement it<br />in the future, if still needed/wanted.<br /><br />Greetings,<br />Rafael<br /><br /><br />-- <br />Beer is proof that God loves us and wants us to be happy - Benjamin Franklin<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-09 23:09 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>