37213 – Improve breadcrumbs in rotating collections

<!DOCTYPE html> <html lang="en"> <head><meta property="og:type" content="website"> <meta property="og:title" content="37213 – Improve breadcrumbs in rotating collections"> <meta property="og:url" content="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213"> <meta property="og:description" content="minor, P5 - low, assigned to cubingguy714, Needs documenting, in Staff interface, Koha , in version(s) 24.11.00,24.05.06 "> <title>37213 – Improve breadcrumbs in rotating collections</title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1"> <link href="data/assets/7639320ab60877a84a229ebf974149a6.css" rel="stylesheet" type="text/css"> <script type="text/javascript" src="data/assets/a7c2f3a028f17a9aa60f56dc9d6e732d.js"></script> <script type="text/javascript">  </script> <script type="text/javascript" src="data/assets/daf5e0fb6826e6a35280e622913f0c4a.js"></script> <link rel="search" type="application/opensearchdescription+xml" title="Bugzilla" href="./search_plugin.cgi"> <link rel="shortcut icon" href="images/favicon.ico"><meta name="robots" content="noarchive"> </head> <body class="bugs-koha-community-org-bugzilla3 bz_bug bz_status_Needs_documenting bz_product_Koha bz_component_Staff_interface bz_bug_37213 yui-skin-sam"> <div id="header"><div id="banner"> </div> <div id="titles"> <span id="title">Bugzilla – Bug 37213</span> <span id="subtitle" class="subheader">Improve breadcrumbs in rotating collections</span> <span id="information" class="header_addl_info">Last modified: 2024-12-03 03:12:59 UTC</span> </div> <div id="common_links"><ul class="links"> <li><a href="./">Home</a></li> <li><span class="separator">| </span><a href="enter_bug.cgi">New</a></li> <li><span class="separator">| </span><a href="describecomponents.cgi">Browse</a></li> <li><span class="separator">| </span><a href="query.cgi">Search</a></li> <li class="form"> <span class="separator">| </span> <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') { alert('Please enter one or more search terms first.'); return false; } return true;"> <input type="hidden" id="no_redirect_top" name="no_redirect" value="0"> <script type="text/javascript"> if (history && history.replaceState) { var no_redirect = document.getElementById("no_redirect_top"); no_redirect.value = 1; } </script> <input class="txt" type="text" id="quicksearch_top" name="quicksearch" aria-labelledby="find_top" title="Quick Search" value=""> <input class="btn" type="submit" value="Search" id="find_top"></form> <a href="page.cgi?id=quicksearch.html" title="Quicksearch Help">[?]</a></li> <li><span class="separator">| </span><a href="report.cgi">Reports</a></li> <li></li> <li> <span class="separator">| </span> <a href="https://bugzilla.readthedocs.org/en/5.2/using/understanding.html" target="_blank">Help</a> </li> <li id="new_account_container_top"> <span class="separator">| </span> <a href="createaccount.cgi">New Account</a> </li> <li id="mini_login_container_top"> <span class="separator">| </span> <a id="login_link_top" href="show_bug.cgi?id=37213&GoAheadAndLogIn=1" onclick="return show_mini_login_form('_top')">Log In</a> <form action="show_bug.cgi?id=37213" method="POST" class="mini_login bz_default_hidden" id="mini_login_top"> <input id="Bugzilla_login_top" required name="Bugzilla_login" class="bz_login" type="email" placeholder="Email Address"> <input class="bz_password" name="Bugzilla_password" type="password" id="Bugzilla_password_top" required placeholder="Password"> <input type="hidden" name="Bugzilla_login_token" value=""> <input type="submit" name="GoAheadAndLogIn" value="Log in" id="log_in_top"> <a href="#" onclick="return hide_mini_login_form('_top')">[x]</a> </form> </li> <li id="forgot_container_top"> <span class="separator">| </span> <a id="forgot_link_top" href="show_bug.cgi?id=37213&GoAheadAndLogIn=1#forgot" onclick="return show_forgot_form('_top')">Forgot Password</a> <form action="token.cgi" method="post" id="forgot_form_top" class="mini_forgot bz_default_hidden"> <label for="login_top">Login:</label> <input name="loginname" size="20" id="login_top" required type="email" placeholder="Your Email Address"> <input id="forgot_button_top" value="Reset Password" type="submit"> <input type="hidden" name="a" value="reqpw"> <input type="hidden" id="token_top" name="token" value="1740153888-_nE4gg9cUsW0lt7ymc1kXIkygfU-l4RWlBS_UfYxugk"> <a href="#" onclick="return hide_forgot_form('_top')">[x]</a> </form> </li> </ul> </div> </div> <div id="bugzilla-body"> <script type="text/javascript">  </script> <form name="changeform" id="changeform" method="post" action="process_bug.cgi"> <input type="hidden" name="delta_ts" value="2024-12-03 03:12:59"> <input type="hidden" name="id" value="37213"> <input type="hidden" name="token" value="1740153888-ywW7lUgCgQ2DsR1Yte7pXFa9aZUWUM7kXVvB01vV_Ac"> <div class="bz_short_desc_container edit_form"> <a href="show_bug.cgi?id=37213"><b>Bug 37213</b></a> <span id="summary_container" class="bz_default_hidden"> - <span id="short_desc_nonedit_display">Improve breadcrumbs in rotating collections</span> </span> <div id="summary_input"><span class="field_label " id="field_label_short_desc"> <a title="The bug summary is a short sentence which succinctly describes what the bug is about." class="field_help_link" href="page.cgi?id=fields.html#short_desc" >Summary:</a> </span>Improve breadcrumbs in rotating collections </div> </div> <script type="text/javascript"> hideEditableField('summary_container', 'summary_input', 'summary_edit_action', 'short_desc', 'Improve breadcrumbs in rotating collections' ); </script> <table class="edit_form"> <tr> <td id="bz_show_bug_column_1" class="bz_show_bug_column"> <table> <tr> <th class="field_label"> <a href="page.cgi?id=fields.html#bug_status">Status</a>: </th> <td id="bz_field_status"> <span id="static_bug_status">Needs documenting </span> </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_alias"> <a title="A short, unique name assigned to a bug in order to assist with looking it up and referring to it in other places in Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#alias" >Alias:</a> </th> <td> None </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_product"> <a title="Bugs are categorised into Products and Components." class="field_help_link" href="describecomponents.cgi" >Product:</a> </th> <td class="field_value " id="field_container_product" >Koha </td> </tr> <tr class="bz_default_hidden"><th class="field_label " id="field_label_classification"> <a title="Bugs are categorised into Classifications, Products and Components. classifications is the top-level categorisation." class="field_help_link" href="page.cgi?id=fields.html#classification" >Classification:</a> </th> <td class="field_value " id="field_container_classification" >Unclassified </td> </tr> <tr><th class="field_label " id="field_label_component"> <a title="Components are second-level categories; each belongs to a particular Product. Select a Product to narrow down this list." class="field_help_link" href="describecomponents.cgi?product=Koha" >Component:</a> </th> <td class="field_value " id="field_container_component" >Staff interface (<a href="buglist.cgi?component=Staff%20interface&product=Koha&bug_status=__open__" target="_blank">show other bugs</a>) </td> </tr> <tr><th class="field_label " id="field_label_version"> <a title="The version field defines the version of the software the bug was found in." class="field_help_link" href="page.cgi?id=fields.html#version" >Version:</a> </th> <td>Main </td> </tr> <tr><th class="field_label " id="field_label_rep_platform"> <a title="The hardware platform the bug was observed on. Note: When searching, selecting the option "All" only finds bugs whose value for this field is literally the word "All"." class="field_help_link" href="page.cgi?id=fields.html#rep_platform" >Hardware:</a> </th> <td class="field_value">All All </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr> <th class="field_label"> <label accesskey="i"> <a href="page.cgi?id=fields.html#importance"><u>I</u>mportance</a></label>: </th> <td>P5 - low minor </td> </tr> <tr><th class="field_label " id="field_label_assigned_to"> <a title="The person in charge of resolving the bug." class="field_help_link" href="page.cgi?id=fields.html#assigned_to" >Assignee:</a> </th> <td><span class="vcard"><span class="fn">Eric Garcia</span> </span> </td> </tr> <tr><th class="field_label " id="field_label_qa_contact"> <a title="The person responsible for confirming this bug if it is unconfirmed, and for verifying the fix once the bug has been resolved." class="field_help_link" href="page.cgi?id=fields.html#qa_contact" >QA Contact:</a> </th> <td><span class="vcard"><span class="fn">Paul Derscheid</span> </span> </td> </tr> <script type="text/javascript"> assignToDefaultOnChange(['product', 'component'], 'koha-bugs\x40lists.koha-community.org', 'testopia\x40bugs.koha-community.org'); </script> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_bug_file_loc"> <a title="Bugs can have a URL associated with them - for example, a pointer to a web site where the problem is seen." class="field_help_link" href="page.cgi?id=fields.html#bug_file_loc" >URL:</a> </th> <td> <span id="bz_url_input_area"> </span> </td> </tr> <tr><th class="field_label " id="field_label_keywords"> <a title="You can add keywords from a defined list to bugs, in order to easily identify and group them." class="field_help_link" href="describekeywords.cgi" >Keywords:</a> </th> <td class="field_value " id="field_container_keywords" > </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_dependson"> <a title="The bugs listed here must be resolved before this bug can be resolved." class="field_help_link" href="page.cgi?id=fields.html#dependson" >Depends on:</a> </th> <td> <span id="dependson_input_area"> </span> </td> </tr> <tr><th class="field_label " id="field_label_blocked"> <a title="This bug must be resolved before the bugs listed in this field can be resolved." class="field_help_link" href="page.cgi?id=fields.html#blocked" >Blocks:</a> </th> <td> <span id="blocked_input_area"> </span> </td> </tr> </table> </td> <td> <div class="bz_column_spacer"> </div> </td> <td id="bz_show_bug_column_2" class="bz_show_bug_column"> <table> <tr> <th class="field_label"> Reported: </th> <td>2024-06-27 14:59 UTC by <span class="vcard"><span class="fn">Lucas Gass (lukeg)</span> </span> </td> </tr> <tr> <th class="field_label"> Modified: </th> <td>2024-12-03 03:12 UTC (<a href="show_activity.cgi?id=37213">History</a>) </td> </tr> <tr> <th class="field_label"> <label accesskey="a"> CC List: </label> </th> <td>5 users <span id="cc_edit_area_showhide_container" class="bz_default_hidden"> (<a href="#" id="cc_edit_area_showhide">show</a>) </span> <div id="cc_edit_area"> <br> <select id="cc" multiple="multiple" size="5" > <option value="david">david</option> <option value="fridolin.somers">fridolin.somers</option> <option value="gmcharlt">gmcharlt</option> <option value="m.de.rooy">m.de.rooy</option> <option value="paul.derscheid">paul.derscheid</option> </select> </div> <script type="text/javascript"> hideEditableField( 'cc_edit_area_showhide_container', 'cc_edit_area', 'cc_edit_area_showhide', '', ''); </script> </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> <tr><th class="field_label " id="field_label_see_also"> <a title="This allows you to refer to bugs in other installations. You can enter a URL to a bug in the 'Add Bug URLs' field to note that that bug is related to this one. You can enter multiple URLs at once by separating them with whitespace. You should normally use this field to refer to bugs in other installations. For bugs in this installation, it is better to use the Depends on and Blocks fields." class="field_help_link" href="page.cgi?id=fields.html#see_also" >See Also:</a> </th> <td class="field_value " id="field_container_see_also" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_sponsorship"> <a title="A custom Drop Down field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_sponsorship" >Change sponsored?:</a> </th> <td class="field_value " id="field_container_cf_sponsorship" >--- </td> </tr> <tr> <th class="field_label " id="field_label_cf_patch_complexity"> <a title="A custom Drop Down field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_patch_complexity" >Patch complexity:</a> </th> <td class="field_value " id="field_container_cf_patch_complexity" >Trivial patch </td> </tr> <tr> <th class="field_label " id="field_label_cf_docs_contact"> <a title="The person taking responsibility for documenting the change introduced in this bug." class="field_help_link" href="page.cgi?id=fields.html#cf_docs_contact" >Documentation contact:</a> </th> <td class="field_value " id="field_container_cf_docs_contact" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_manual"> <a title="gitlab merge request url for this documentation submission" class="field_help_link" href="page.cgi?id=fields.html#cf_manual" >Documentation submission:</a> </th> <td class="field_value " id="field_container_cf_manual" > </td> </tr> <tr> <th class="field_label " id="field_label_cf_release_notes"> <a title="A custom Large Text Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_release_notes" >Text to go in the release notes:</a> </th> <td class="field_value " id="field_container_cf_release_notes" > <div class="uneditable_textarea">This fixes the breadcrumbs for rotating collections and makes them more consistent with other breadcrumbs (Tools > Rotating collections > New collection).</div> </td> </tr> <tr> <th class="field_label " id="field_label_cf_release_version"> <a title="A custom Large Text Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_release_version" >Version(s) released in:</a> </th> <td class="field_value " id="field_container_cf_release_version" > <div class="uneditable_textarea">24.11.00,24.05.06</div> </td> </tr> <tr> <th class="field_label bz_hidden_field" id="field_label_cf_circulation_subcomponent"> <a title="A custom Multiple-Selection Box field in this installation of Bugzilla." class="field_help_link" href="page.cgi?id=fields.html#cf_circulation_subcomponent" >Circulation function:</a> </th> <td class="field_value bz_hidden_field" id="field_container_cf_circulation_subcomponent" > </td> </tr> <tr> <td colspan="2" class="bz_section_spacer"></td> </tr> </table> </td> </tr> <tr> <td colspan="3"> <hr id="bz_top_half_spacer"> </td> </tr> </table> <table id="bz_big_form_parts"> <tr> <td> <script type="text/javascript">  </script> <br> <table id="attachment_table"> <tr id="a0"> <th colspan="2" class="left"> Attachments </th> </tr> <tr id="a1" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=168214" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 37213: Improved breadcrumbs in rotating collections</span></b></a> <span class="bz_attach_extra_info"> (1.80 KB, patch) <br> <a href="#attach_168214" title="Go to the comment associated with the attachment">2024-06-27 19:35 UTC</a>, <span class="vcard"><span class="fn">Eric Garcia</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168214&action=edit">Details</a> | <a href="attachment.cgi?id=168214&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=168214"> Splinter Review</a> </td> </tr> <tr id="a2" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=168216" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 37213: Improved breadcrumbs in rotating collections</span></b></a> <span class="bz_attach_extra_info"> (1.84 KB, patch) <br> <a href="#attach_168216" title="Go to the comment associated with the attachment">2024-06-27 19:46 UTC</a>, <span class="vcard"><span class="fn">Sam Lau</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168216&action=edit">Details</a> | <a href="attachment.cgi?id=168216&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=168216"> Splinter Review</a> </td> </tr> <tr id="a3" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=168232" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs</span></b></a> <span class="bz_attach_extra_info"> (2.47 KB, patch) <br> <a href="#attach_168232" title="Go to the comment associated with the attachment">2024-06-28 11:23 UTC</a>, <span class="vcard"><span class="fn">Owen Leonard</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168232&action=edit">Details</a> | <a href="attachment.cgi?id=168232&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=168232"> Splinter Review</a> </td> </tr> <tr id="a4" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=168575" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 37213: Improved breadcrumbs in rotating collections</span></b></a> <span class="bz_attach_extra_info"> (1.89 KB, patch) <br> <a href="#attach_168575" title="Go to the comment associated with the attachment">2024-07-07 04:36 UTC</a>, <span class="vcard"><span class="fn">David Nind</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168575&action=edit">Details</a> | <a href="attachment.cgi?id=168575&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=168575"> Splinter Review</a> </td> </tr> <tr id="a5" class="bz_contenttype_text_plain bz_patch bz_tr_obsolete bz_default_hidden"> <td> <a href="attachment.cgi?id=168576" title="View the content of the attachment"> <b><span class="bz_obsolete">Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs</span></b></a> <span class="bz_attach_extra_info"> (2.51 KB, patch) <br> <a href="#attach_168576" title="Go to the comment associated with the attachment">2024-07-07 04:36 UTC</a>, <span class="vcard"><span class="fn">David Nind</span> </span> </span> </td> <td> <a href="attachment.cgi?id=168576&action=edit">Details</a> | <a href="attachment.cgi?id=168576&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=168576"> Splinter Review</a> </td> </tr> <tr id="a6" class="bz_contenttype_text_plain bz_patch"> <td> <a href="attachment.cgi?id=171269" title="View the content of the attachment"> <b>Bug 37213: Improved breadcrumbs in rotating collections</b></a> <span class="bz_attach_extra_info"> (1.95 KB, patch) <br> <a href="#attach_171269" title="Go to the comment associated with the attachment">2024-09-10 16:38 UTC</a>, <span class="vcard"><span class="fn">Paul Derscheid</span> </span> </span> </td> <td> <a href="attachment.cgi?id=171269&action=edit">Details</a> | <a href="attachment.cgi?id=171269&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=171269"> Splinter Review</a> </td> </tr> <tr id="a7" class="bz_contenttype_text_plain bz_patch"> <td> <a href="attachment.cgi?id=171270" title="View the content of the attachment"> <b>Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs</b></a> <span class="bz_attach_extra_info"> (2.57 KB, patch) <br> <a href="#attach_171270" title="Go to the comment associated with the attachment">2024-09-10 16:38 UTC</a>, <span class="vcard"><span class="fn">Paul Derscheid</span> </span> </span> </td> <td> <a href="attachment.cgi?id=171270&action=edit">Details</a> | <a href="attachment.cgi?id=171270&action=diff">Diff</a>  | <a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37213&attachment=171270"> Splinter Review</a> </td> </tr> <tr id="a8" class="bz_contenttype_image_png"> <td> <a href="attachment.cgi?id=175066" title="View the content of the attachment"> <b>Screenshot after patch - rotating collection breadcrumbs when editing still incorrect</b></a> <span class="bz_attach_extra_info"> (30.48 KB, image/png) <br> <a href="#attach_175066" title="Go to the comment associated with the attachment">2024-12-03 03:12 UTC</a>, <span class="vcard"><span class="fn">David Nind</span> </span> </span> </td> <td> <a href="attachment.cgi?id=175066&action=edit">Details</a> </td> </tr> <tr class="bz_attach_footer"> <td colspan="2"> <span class="bz_attach_view_hide"> <a href="#a0" onclick="return toggle_display(this);">Show Obsolete</a> (5) <a id="view_all" href="attachment.cgi?bugid=37213&action=viewall&hide_obsolete=1">View All</a> </span> <a href="attachment.cgi?bugid=37213&action=enter">Add an attachment</a> (proposed patch, testcase, etc.) </td> </tr> </table> <br> <div id="add_comment" class="bz_section_additional_comments"> <table> <tr> <td> <fieldset> <legend>Note</legend> You need to <a href="show_bug.cgi?id=37213&GoAheadAndLogIn=1">log in</a> before you can comment on or make changes to this bug. </fieldset> </td> </tr> </table> </div> </td> <td> </td> </tr></table> <div id="comments"><script src="js/comments.js" type="text/javascript"> </script> <script type="text/javascript">  </script>  <table class="bz_comment_table"> <tr> <td> <div id="c0" class="bz_comment bz_first_comment"> <div class="bz_first_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c0">Description</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Lucas Gass (lukeg)</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-27 14:59:50 UTC </span> </div> <pre class="bz_comment_text">1. Tools > Rotating collections > New collection 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right: Tools > Rotating collections > Collection " > Edit collection</pre> </div> <div id="c1" class="bz_comment bz_default_collapsed"> <div class="bz_comment_head"> <span class="bz_comment_actions"> <script type="text/javascript"> addCollapseLink(1, 1, 'Toggle comment display'); </script> </span> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c1">Comment 1</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Eric Garcia</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-27 19:35:36 UTC </span> <span id="cr1" class="bz_comment_collapse_reason" title="Eric Garcia [2024-06-27 19:35:36 UTC]"> Comment hidden (obsolete) </span> </div> <pre class="bz_comment_text collapsed" id="comment_text_1">Created <span class="bz_obsolete"><a href="attachment.cgi?id=168214&action=diff" name="attach_168214" title="Bug 37213: Improved breadcrumbs in rotating collections">attachment 168214</a> <a href="attachment.cgi?id=168214&action=edit" title="Bug 37213: Improved breadcrumbs in rotating collections">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=168214'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved.</pre> </div> <div id="c2" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c2">Comment 2</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Sam Lau</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-27 19:46:53 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=168216&action=diff" name="attach_168216" title="Bug 37213: Improved breadcrumbs in rotating collections">attachment 168216</a> <a href="attachment.cgi?id=168216&action=edit" title="Bug 37213: Improved breadcrumbs in rotating collections">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=168216'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <<a href="mailto:samalau@gmail.com">samalau@gmail.com</a>></pre> </div> <div id="c3" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c3">Comment 3</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Marcel de Rooy</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 09:39:16 UTC </span> </div> <pre class="bz_comment_text">Added Assignee now. Please fill yourself next time :)</pre> </div> <div id="c4" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c4">Comment 4</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Marcel de Rooy</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 09:51:02 UTC </span> </div> <pre class="bz_comment_text">This looks a bit odd. I would not expect created or deleted to pop up in the breadcrumbs. If something failed, we should have a dialog alert somewhere else. Furthermore there seems to be an issue with: [% WRAPPER breadcrumb_item %] <a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% editColId | uri %]">[% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]</em></a> [% END %] The quoted empty string comes from there. Should the script pass a correct op and record id here instead? If you delete a collection, probably the op should change to new. If you added or updated, we need the record id. Note also that I see an </em> without an opening <em> ?</pre> </div> <div id="c5" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c5">Comment 5</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Owen Leonard</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 11:23:18 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=168232&action=diff" name="attach_168232" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">attachment 168232</a> <a href="attachment.cgi?id=168232&action=edit" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=168232'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs</pre> </div> <div id="c6" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c6">Comment 6</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Owen Leonard</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-06-28 11:26:12 UTC </span> </div> <pre class="bz_comment_text">(In reply to Marcel de Rooy from <a href="show_bug.cgi?id=37213#c4">comment #4</a>) <span class="quote">> This looks a bit odd. I would not expect created or deleted to pop up in the > breadcrumbs. If something failed, we should have a dialog alert somewhere > else.</span > We do have a dialog alert. The thing which is inconsistent about this page is that there is a "creation success/failure" stage at all. Usually we would redirect to the list of collections in either case, adding a dialog if there was an error. I think these changes are logical given the unusual workflow of having a "success" page. <span class="quote">> The quoted empty string comes from there. Should the script pass a correct > op and record id here instead? If you delete a collection, probably the op > should change to new. If you added or updated, we need the record id. > > Note also that I see an </em> without an opening <em> ?</span > These issues are all unrelated to the changes in the original patc. I've submitted a follow-up to correct them.</pre> </div> <div id="c7" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c7">Comment 7</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Nind</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-07-07 04:36:20 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=168575&action=diff" name="attach_168575" title="Bug 37213: Improved breadcrumbs in rotating collections">attachment 168575</a> <a href="attachment.cgi?id=168575&action=edit" title="Bug 37213: Improved breadcrumbs in rotating collections">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=168575'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <<a href="mailto:samalau@gmail.com">samalau@gmail.com</a>> Signed-off-by: David Nind <<a href="mailto:david@davidnind.com">david@davidnind.com</a>></pre> </div> <div id="c8" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c8">Comment 8</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Nind</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-07-07 04:36:23 UTC </span> </div> <pre class="bz_comment_text">Created <span class="bz_obsolete"><a href="attachment.cgi?id=168576&action=diff" name="attach_168576" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">attachment 168576</a> <a href="attachment.cgi?id=168576&action=edit" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=168576'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs Signed-off-by: David Nind <<a href="mailto:david@davidnind.com">david@davidnind.com</a>></pre> </div> <div id="c9" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c9">Comment 9</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Nind</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-07-07 04:39:44 UTC </span> </div> <pre class="bz_comment_text">Not related to this bug, but I'm not sure that I understand the difference between Tools > Rotating collections and Cataloging > Automation > Stock rotation (when the StockRotation system preference is enabled). Having similar names is a bit confusing.</pre> </div> <div id="c10" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c10">Comment 10</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Paul Derscheid</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-09-10 16:38:39 UTC </span> </div> <pre class="bz_comment_text">Created <span class=""><a href="attachment.cgi?id=171269&action=diff" name="attach_171269" title="Bug 37213: Improved breadcrumbs in rotating collections">attachment 171269</a> <a href="attachment.cgi?id=171269&action=edit" title="Bug 37213: Improved breadcrumbs in rotating collections">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=171269'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <<a href="mailto:samalau@gmail.com">samalau@gmail.com</a>> Signed-off-by: David Nind <<a href="mailto:david@davidnind.com">david@davidnind.com</a>> Signed-off-by: Paul Derscheid <<a href="mailto:paul.derscheid@lmscloud.de">paul.derscheid@lmscloud.de</a>></pre> </div> <div id="c11" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c11">Comment 11</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Paul Derscheid</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-09-10 16:38:43 UTC </span> </div> <pre class="bz_comment_text">Created <span class=""><a href="attachment.cgi?id=171270&action=diff" name="attach_171270" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">attachment 171270</a> <a href="attachment.cgi?id=171270&action=edit" title="Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=37213&attachment=171270'>[review]</a> <a class="bz_bug_link bz_status_Needs_documenting " title="Needs documenting - Improve breadcrumbs in rotating collections" href="show_bug.cgi?id=37213">Bug 37213</a>: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs Signed-off-by: David Nind <<a href="mailto:david@davidnind.com">david@davidnind.com</a>> Signed-off-by: Paul Derscheid <<a href="mailto:paul.derscheid@lmscloud.de">paul.derscheid@lmscloud.de</a>></pre> </div> <div id="c12" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c12">Comment 12</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Paul Derscheid</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-09-10 16:44:31 UTC </span> </div> <pre class="bz_comment_text">I passed QA on this because the reported bug was fixed. If there's an issue with the unusual pattern I think this should be addressed in a follow-up bug to this one. I hope that's fine.</pre> </div> <div id="c13" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c13">Comment 13</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Katrin Fischer</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-09-13 11:58:25 UTC </span> </div> <pre class="bz_comment_text">Pushed for 24.11! Well done everyone, thank you!</pre> </div> <div id="c14" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c14">Comment 14</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Lucas Gass (lukeg)</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-11-18 16:04:32 UTC </span> </div> <pre class="bz_comment_text">Backported to 24.05.x for upcoming 24.05.06</pre> </div> <div id="c15" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c15">Comment 15</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">Fridolin Somers</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-12-02 09:29:11 UTC </span> </div> <pre class="bz_comment_text">Does not apply easy on 23.11.x This is minor I propose to not backport</pre> </div> <div id="c16" class="bz_comment"> <div class="bz_comment_head"> <span class="bz_comment_number"> <a href="show_bug.cgi?id=37213#c16">Comment 16</a> </span> <span class="bz_comment_user"> <span class="vcard"><span class="fn">David Nind</span> </span> </span> <span class="bz_comment_user_images"> </span> <span class="bz_comment_time"> 2024-12-03 03:12:59 UTC </span> </div> <pre class="bz_comment_text">Created <span class=""><a href="attachment.cgi?id=175066" name="attach_175066" title="Screenshot after patch - rotating collection breadcrumbs when editing still incorrect">attachment 175066</a> <a href="attachment.cgi?id=175066&action=edit" title="Screenshot after patch - rotating collection breadcrumbs when editing still incorrect">[details]</a></span> Screenshot after patch - rotating collection breadcrumbs when editing still incorrect There is still an issue with these breadcrumbs, so another bug is required to fix. For example, if I edit a breadcrumb, I get (see the screenshot attached): Tools > Rotating collections > Collection '' > Edit collection Collection Test 4 updated successfully Return to rotating collections home To replicate on main: 1. Go to Tools > Rotating collections. 2. Add a new collection (+ New collection) . Name: Test 1 . Description: anything you like 3. Results: Breadcrumb: Tools > Rotating collections > Collection created successfully Collection Test 1 added successfully Return to rotating collections home 4. From the list of rotating collections, select Actions > Edit. 5. Change the name to "Test 4". 6. Results: Tools > Rotating collections > Collection '' > Edit collection Collection Test 4 updated successfully Return to rotating collections home</pre> </div> </td> <td> </td> </tr></table> </div> </form> <hr> <ul class="related_actions"> <li><a href="show_bug.cgi?format=multiple&id=37213">Format For Printing</a></li> <li> - <a href="show_bug.cgi?ctype=xml&id=37213">XML</a></li> <li> - <a href="enter_bug.cgi?cloned_bug_id=37213">Clone This Bug</a></li> <li> - <a href="#">Top of page </a></li> </ul> <br> </div> <div id="footer"> <div class="intro"></div> <ul id="useful-links"> <li id="links-actions"><ul class="links"> <li><a href="./">Home</a></li> <li><span class="separator">| </span><a href="enter_bug.cgi">New</a></li> <li><span class="separator">| </span><a href="describecomponents.cgi">Browse</a></li> <li><span class="separator">| </span><a href="query.cgi">Search</a></li> <li class="form"> <span class="separator">| </span> <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') { alert('Please enter one or more search terms first.'); return false; } return true;"> <input type="hidden" id="no_redirect_bottom" name="no_redirect" value="0"> <script type="text/javascript"> if (history && history.replaceState) { var no_redirect = document.getElementById("no_redirect_bottom"); no_redirect.value = 1; } </script> <input class="txt" type="text" id="quicksearch_bottom" name="quicksearch" aria-labelledby="find_bottom" title="Quick Search" value=""> <input class="btn" type="submit" value="Search" id="find_bottom"></form> <a href="page.cgi?id=quicksearch.html" title="Quicksearch Help">[?]</a></li> <li><span class="separator">| </span><a href="report.cgi">Reports</a></li> <li></li> <li> <span class="separator">| </span> <a href="https://bugzilla.readthedocs.org/en/5.2/using/understanding.html" target="_blank">Help</a> </li> <li id="new_account_container_bottom"> <span class="separator">| </span> <a href="createaccount.cgi">New Account</a> </li> <li id="mini_login_container_bottom"> <span class="separator">| </span> <a id="login_link_bottom" href="show_bug.cgi?id=37213&GoAheadAndLogIn=1" onclick="return show_mini_login_form('_bottom')">Log In</a> <form action="show_bug.cgi?id=37213" method="POST" class="mini_login bz_default_hidden" id="mini_login_bottom"> <input id="Bugzilla_login_bottom" required name="Bugzilla_login" class="bz_login" type="email" placeholder="Email Address"> <input class="bz_password" name="Bugzilla_password" type="password" id="Bugzilla_password_bottom" required placeholder="Password"> <input type="hidden" name="Bugzilla_login_token" value=""> <input type="submit" name="GoAheadAndLogIn" value="Log in" id="log_in_bottom"> <a href="#" onclick="return hide_mini_login_form('_bottom')">[x]</a> </form> </li> <li id="forgot_container_bottom"> <span class="separator">| </span> <a id="forgot_link_bottom" href="show_bug.cgi?id=37213&GoAheadAndLogIn=1#forgot" onclick="return show_forgot_form('_bottom')">Forgot Password</a> <form action="token.cgi" method="post" id="forgot_form_bottom" class="mini_forgot bz_default_hidden"> <label for="login_bottom">Login:</label> <input name="loginname" size="20" id="login_bottom" required type="email" placeholder="Your Email Address"> <input id="forgot_button_bottom" value="Reset Password" type="submit"> <input type="hidden" name="a" value="reqpw"> <input type="hidden" id="token_bottom" name="token" value="1740153888-_nE4gg9cUsW0lt7ymc1kXIkygfU-l4RWlBS_UfYxugk"> <a href="#" onclick="return hide_forgot_form('_bottom')">[x]</a> </form> </li> </ul> </li> </ul> <div class="outro"></div> </div> </body> </html>

CINXE.COM

37213 – Improve breadcrumbs in rotating collections