CINXE.COM
LKML: Han Boetes: patch to fix bashism
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Han Boetes: patch to fix bashism</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Han Boetes" href="/groupie.php?aid=8720" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/8"> [8]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/8/265" onclick="this.href='/lkml/headers'+'/2005/4/8/265';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/8/265">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/4/8/265">First message in thread</a></li><li class="origin"><a href="/lkml/2005/4/9/106">Han Boetes</a><ul><li><a href="/lkml/2005/4/9/106">David Weinehall</a></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/4/8/265/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 8 Apr 2005 23:11:38 +0159</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Han Boetes <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">patch to fix bashism</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">Hi,<br /><br />This patch fixes a three bashisms in<br />scripts/gen_initramfs_list.sh;<br /><br />I'm not sure of the intention of the second change (local<br />name=...). So it's very well possible that:<br /><br />+ local name="${location%/$srcdir}"<br /><br />is more appropriate.<br /><br /><br />--- scripts/gen_initramfs_list.sh.orig 2005-03-27 14:53:15.628883408 +0200<br />+++ scripts/gen_initramfs_list.sh 2005-03-27 15:12:20.093898280 +0200<br />@@ -1,4 +1,7 @@<br />-#!/bin/bash<br />+#!/bin/sh<br />+<br />+# script is sourced, the shebang is ignored.<br />+<br /> # Copyright (C) Martin Schlemmer <azarah@nosferatu.za.org><br /> # Released under the terms of the GNU GPL<br /> #<br />@@ -56,9 +59,9 @@<br /> <br /> parse() {<br /> local location="$1"<br />- local name="${location/${srcdir}//}"<br />+ local name="${location#$srcdir/}"<br /> # change '//' into '/'<br />- name="${name//\/\///}"<br />+ name=`echo $name|sed -e 's|//|/|g'`<br /> local mode="$2"<br /> local uid="$3"<br /> local gid="$4"<br />@@ -68,8 +71,8 @@<br /> [ "$gid" -eq "$root_gid" ] && gid=0<br /> local str="${mode} ${uid} ${gid}"<br /> <br />- [ "${ftype}" == "invalid" ] && return 0<br />- [ "${location}" == "${srcdir}" ] && return 0<br />+ [ "${ftype}" = "invalid" ] && return 0<br />+ [ "${location}" = "${srcdir}" ] && return 0<br /> <br /> case "${ftype}" in<br /> "file")<br /><br /><br /># Han<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-08 23:16 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>