LKML: David Heidelberg: Re: [PATCH v4 0/5] iio: light: Modernize al3010 and al3320a codebase

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: David Heidelberg: Re: [PATCH v4 0/5] iio: light: Modernize al3010 and al3320a codebase</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by David Heidelberg" href="/groupie.php?aid=" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2025"> [2025]</a> 聽 <a class="nb" href="/lkml/2025/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2025/4/6"> [6]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2025/4/6/139" onclick="this.href='/lkml/headers'+'/2025/4/6/139';">[headers]</a>聽 <a href="/lkml/bounce/2025/4/6/139">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2025/4/2/1343">First message in thread</a></li><li><a href="/lkml/2025/4/2/1343">David Heidelberg via B4 Relay</a><ul><li><a href="/lkml/2025/4/2/1337">David Heidelberg via B4 Relay</a></li><li><a href="/lkml/2025/4/2/1338">David Heidelberg via B4 Relay</a><ul><li><a href="/lkml/2025/4/5/321">Jonathan Cameron</a></li></ul></li><li><a href="/lkml/2025/4/2/1339">David Heidelberg via B4 Relay</a><ul><li><a href="/lkml/2025/4/3/1233">Christophe JAILLET</a><ul><li><a href="/lkml/2025/4/5/317">Jonathan Cameron</a></li></ul></li></ul></li><li><a href="/lkml/2025/4/2/1340">David Heidelberg via B4 Relay</a><ul><li><a href="/lkml/2025/4/5/319">Jonathan Cameron</a></li></ul></li><li><a href="/lkml/2025/4/2/1342">David Heidelberg via B4 Relay</a></li><li><a href="/lkml/2025/4/5/326">Jonathan Cameron</a><ul><li class="origin"><a href="">David Heidelberg</a></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Sun, 6 Apr 2025 15:01:55 +0200</td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH v4 0/5] iio: light: Modernize al3010 and al3320a codebase</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">David Heidelberg <></td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On 05/04/2025 19:12, Jonathan Cameron wrote:<br />> On Wed, 02 Apr 2025 21:33:23 +0200<br />> David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org> wrote:<br />> <br />>> This series aims to improve code readability and modernize it to align<br />>> with the recently upstreamed AL3000a.<br />>><br />>> Apart from slightly improved error reporting, and error handling<br />>> there should be no functional changes.<br />>><br />>> Module before after<br />>> al3010 72 kB 58 kB<br />>> al3320a 72 kB 58 kB<br />>><br />>> Signed-off-by: David Heidelberg <david@ixit.cz><br />>> ---<br />> Applied, but with tweaks to not add print messages as described in patches 1 and 3.<br />> That meant a bunch of hand application was needed for 4-5. Please check the result<br />> in the testing branch of iio.git.<br /><br />It does look good.<br /><br />Thank you!<br />David<br /><br />> <br />> Thanks,<br />> <br />> Jonathan<br />> <br />>> Changes in v4:<br />>> - Fixed mixed-up rebase changes between commits and added<br />>> regmap_get_device into _init functions to get the device.<br />>> - Link to v3: <a href="https://lore.kernel.org/r/20250402-al3010-iio-regmap-v3-0-cc3da273b5b2@ixit.cz">https://lore.kernel.org/r/20250402-al3010-iio-regmap-v3-0-cc3da273b5b2@ixit.cz</a><br />>><br />>> Changes in v3:<br />>> - Stripped patches merged from second version of patchset.<br />>> - Dropped iio: light: al3010: Move devm_add_action_or_reset back to _probe<br />>> in favor of opposite approach moving devm_add.. to _init for al3xx0a:<br />>> - iio: light: al3000a: Fix an error handling path in al3000a_probe()<br />>> - iio: light: al3320a: Fix an error handling path in al3320a_probe()<br />>> - Link to v2: <a href="https://lore.kernel.org/r/20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz">https://lore.kernel.org/r/20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz</a><br />>><br />>> Changes in v2:<br />>> - Dropped Daniel's email update.<br />>> - Dropped DRV_NAME introduction for al3000a<br />>> - Added DRV_NAME define removal for al3010 and al3320a.<br />>> - Splitted unsigned int conversion into separate patches.<br />>> - Replaced generic value with specific raw and gain variable.<br />>> - Use dev_err_probe() for error handling.<br />>> - Separated devm_add_action_or_reset move from _init back to _probe.<br />>> - Dropped copyright update.<br />>> - Link to v1: <a href="https://lore.kernel.org/r/20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz">https://lore.kernel.org/r/20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz</a><br />>><br />>> ---<br />>> David Heidelberg (5):<br />>> iio: light: al3010: Improve al3010_init error handling with dev_err_probe()<br />>> iio: light: al3000a: Fix an error handling path in al3000a_probe()<br />>> iio: light: al3320a: Fix an error handling path in al3320a_probe()<br />>> iio: light: al3010: Implement regmap support<br />>> iio: light: al3320a: Implement regmap support<br />>><br />>> drivers/iio/light/al3000a.c | 9 +++--<br />>> drivers/iio/light/al3010.c | 85 +++++++++++++++++++++++--------------------<br />>> drivers/iio/light/al3320a.c | 89 +++++++++++++++++++++++++--------------------<br />>> 3 files changed, 100 insertions(+), 83 deletions(-)<br />>> ---<br />>> base-commit: f8ffc92ae9052e6615896052f0c5b808bfc17520<br />>> change-id: 20250308-al3010-iio-regmap-038cea39f85d<br />>><br />>> Best regards,<br />> <br /><br />-- <br />David Heidelberg<br /><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2025-04-06 15:10 聽聽 [W:0.128 / U:0.169 seconds]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: David Heidelberg: Re: [PATCH v4 0/5] iio: light: Modernize al3010 and al3320a codebase