CINXE.COM
LKML: Josh Poimboeuf: Re: [PATCH 06/11] x86/alternative: Simplify callthunk patching
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Josh Poimboeuf: Re: [PATCH 06/11] x86/alternative: Simplify callthunk patching</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Josh Poimboeuf" href="/groupie.php?aid=" /><!--Matomo--><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script><!--End Matomo Code--></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2025"> [2025]</a> 聽 <a class="nb" href="/lkml/2025/2"> [Feb]</a> 聽 <a class="nb" href="/lkml/2025/2/7"> [7]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2025/2/7/1349" onclick="this.href='/lkml/headers'+'/2025/2/7/1349';">[headers]</a>聽 <a href="/lkml/bounce/2025/2/7/1349">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2025/2/7/769">First message in thread</a></li><li><a href="/lkml/2025/2/7/769">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/7/768">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/263">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/770">Peter Zijlstra</a></li><li><a href="/lkml/2025/2/7/771">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/259">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/772">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/14/1306">Kees Cook</a><ul><li><a href="/lkml/2025/2/15/245">Peter Zijlstra</a></li></ul></li></ul></li><li><a href="/lkml/2025/2/7/773">Peter Zijlstra</a></li><li><a href="/lkml/2025/2/7/774">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/261">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/775">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/253">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/776">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/255">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/777">Peter Zijlstra</a><ul><li class="origin"><a href="">Josh Poimboeuf</a></li><li><a href="/lkml/2025/2/15/256">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/778">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/258">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/7/780">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/15/257">"tip-bot2 for Peter Zijlstra"</a></li></ul></li><li><a href="/lkml/2025/2/10/1477">Sami Tolvanen</a><ul><li><a href="/lkml/2025/2/13/601">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/13/731">Peter Zijlstra</a><ul><li><a href="/lkml/2025/2/13/1632">Sami Tolvanen</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Fri, 7 Feb 2025 09:23:57 -0800</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Josh Poimboeuf <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 06/11] x86/alternative: Simplify callthunk patching</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Fri, Feb 07, 2025 at 01:15:35PM +0100, Peter Zijlstra wrote:<br />> +++ b/arch/x86/kernel/alternative.c<br />> @@ -1697,14 +1697,14 @@ void __init alternative_instructions(voi<br />> apply_retpolines(__retpoline_sites, __retpoline_sites_end);<br />> apply_returns(__return_sites, __return_sites_end);<br />> <br />> - apply_alternatives(__alt_instructions, __alt_instructions_end);<br />> -<br />> /*<br />> - * Now all calls are established. Apply the call thunks if<br />> - * required.<br />> + * Adjust all CALL instructions to point to func()-10, including<br />> + * those in .altinstr_replacement.<br /><br />Clarify 10 is hex: "func()-0x10" ?<br /><br />-- <br />Josh<br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2025-02-07 18:24 聽聽 [W:1.188 / U:1.882 seconds]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>