LKML: Lei Wei: Re: [PATCH net-next v2 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Lei Wei: Re: [PATCH net-next v2 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Lei Wei" href="/groupie.php?aid=" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2024"> [2024]</a> 聽 <a class="nb" href="/lkml/2024/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2024/12/7"> [7]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2024/12/7/1" onclick="this.href='/lkml/headers'+'/2024/12/7/1';">[headers]</a>聽 <a href="/lkml/bounce/2024/12/7/1">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2024/12/4/977">First message in thread</a></li><li><a href="/lkml/2024/12/4/978">Lei Wei</a><ul><li><a href="/lkml/2024/12/4/1070">"Russell King (Oracle)"</a><ul><li class="origin"><a href="/lkml/2024/12/6/1065">Lei Wei</a><ul><li><a href="/lkml/2024/12/6/1065">"Russell King (Oracle)"</a><ul><li><a href="/lkml/2024/12/10/990">Lei Wei</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Sat, 7 Dec 2024 00:20:25 +0800</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Lei Wei <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH net-next v2 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody"> On 12/4/2024 11:28 PM, Russell King (Oracle) wrote: > On Wed, Dec 04, 2024 at 10:43:55PM +0800, Lei Wei wrote: >> +static int ipq_pcs_enable(struct phylink_pcs *pcs) >> +{ >> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs); >> + struct ipq_pcs *qpcs = qpcs_mii->qpcs; >> + int index = qpcs_mii->index; >> + int ret; >> + >> + ret = clk_prepare_enable(qpcs_mii->rx_clk); >> + if (ret) { >> + dev_err(qpcs->dev, "Failed to enable MII %d RX clock\n", index); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(qpcs_mii->tx_clk); >> + if (ret) { >> + dev_err(qpcs->dev, "Failed to enable MII %d TX clock\n", index); >> + clk_disable_unprepare(qpcs_mii->rx_clk); >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static void ipq_pcs_disable(struct phylink_pcs *pcs) >> +{ >> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs); >> + >> + if (__clk_is_enabled(qpcs_mii->rx_clk)) >> + clk_disable_unprepare(qpcs_mii->rx_clk); >> + >> + if (__clk_is_enabled(qpcs_mii->tx_clk)) >> + clk_disable_unprepare(qpcs_mii->tx_clk); > > Why do you need the __clk_is_enabled() calls here? Phylink should be > calling pcs_enable() once when the PCS when starting to use the PCS, > and then pcs_disable() when it stops using it - it won't call > pcs_disable() without a preceeding call to pcs_enable(). > > Are you seeing something different? > Yes, understand that phylink won't call pcs_disable() without a preceeding call to pcs_enable(). However, the "clk_prepare_enable" may fail in the pcs_enable() method, so I added the __clk_is_enabled() check in pcs_disable() method. This is because the phylink_major_config() function today does not interpret the return value of phylink_pcs_enable(). >> +static void ipq_pcs_get_state(struct phylink_pcs *pcs, >> + struct phylink_link_state *state) >> +{ >> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs); >> + struct ipq_pcs *qpcs = qpcs_mii->qpcs; >> + int index = qpcs_mii->index; >> + >> + switch (state->interface) { >> + case PHY_INTERFACE_MODE_SGMII: >> + case PHY_INTERFACE_MODE_QSGMII: >> + ipq_pcs_get_state_sgmii(qpcs, index, state); >> + break; >> + default: >> + break; > ... >> +static int ipq_pcs_config(struct phylink_pcs *pcs, >> + unsigned int neg_mode, >> + phy_interface_t interface, >> + const unsigned long *advertising, >> + bool permit) >> +{ >> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs); >> + struct ipq_pcs *qpcs = qpcs_mii->qpcs; >> + int index = qpcs_mii->index; >> + >> + switch (interface) { >> + case PHY_INTERFACE_MODE_SGMII: >> + case PHY_INTERFACE_MODE_QSGMII: >> + return ipq_pcs_config_sgmii(qpcs, index, neg_mode, interface); >> + default: >> + dev_err(qpcs->dev, >> + "Unsupported interface %s\n", phy_modes(interface)); >> + return -EOPNOTSUPP; >> + }; >> +} >> + >> +static void ipq_pcs_link_up(struct phylink_pcs *pcs, >> + unsigned int neg_mode, >> + phy_interface_t interface, >> + int speed, int duplex) >> +{ >> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs); >> + struct ipq_pcs *qpcs = qpcs_mii->qpcs; >> + int index = qpcs_mii->index; >> + int ret; >> + >> + switch (interface) { >> + case PHY_INTERFACE_MODE_SGMII: >> + case PHY_INTERFACE_MODE_QSGMII: >> + ret = ipq_pcs_link_up_config_sgmii(qpcs, index, >> + neg_mode, speed); >> + break; >> + default: >> + dev_err(qpcs->dev, >> + "Unsupported interface %s\n", phy_modes(interface)); >> + return; >> + } > > So you only support SGMII and QSGMII. Rather than checking this in every > method implementation, instead provide a .pcs_validate method that > returns an error for unsupported interfaces please. > Yes, I can add the pcs_validate() method to validate the link configurations. This will catch invalid interface mode during the PCS initialization time, earlier than the pcs_config and pcs_link_up contexts. But after of the PCS init, if at a later point the PHY interface mode changes, it seems phylink today is not calling the pcs_validate() op to validate the changed new interface mode at the time of "phylink_resolve". (Hope my understanding is correct). So, In the pcs ops methods, I will keep the switch case to check and handle the unsupported interface modes. > Thanks. > </pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2024-12-06 17:23 聽聽 [from the cache] 漏2003-2020 <a href="http://blog.jasper.es/">Jasper Spaans</a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: Lei Wei: Re: [PATCH net-next v2 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations