CINXE.COM

<!DOCTYPE html> <html class="writer-html5" lang="en" data-content_root="../../../../"> <head> <meta charset="utf-8" /><meta name="viewport" content="width=device-width, initial-scale=1" /> <meta name="viewport" content="width=device-width, initial-scale=1.0" /> <title>Mozilla Central Contributor Guide — Firefox Source Docs documentation</title> <link rel="stylesheet" type="text/css" href="../../../../_static/pygments.css?v=fa44fd50" /> <link rel="stylesheet" type="text/css" href="../../../../_static/css/theme.css?v=19f00094" /> <link rel="stylesheet" type="text/css" href="../../../../_static/graphviz.css?v=fd3f3429" /> <link rel="stylesheet" type="text/css" href="../../../../_static/copybutton.css?v=76b2166b" /> <link rel="stylesheet" type="text/css" href="../../../../_static/custom_theme.css?v=a7d3e023" /> <link rel="stylesheet" type="text/css" href="../../../../_static/design-style.1e8bd061cd6da7fc9cf755528e8ffc24.min.css?v=0a3b3ea7" /> <link rel="shortcut icon" href="../../../../_static/firefox.ico"/>  <script src="../../../../_static/jquery.js?v=5d32c60e"></script> <script src="../../../../_static/_sphinx_javascript_frameworks_compat.js?v=2cd50e6c"></script> <script src="../../../../_static/documentation_options.js?v=5929fcd5"></script> <script src="../../../../_static/doctools.js?v=9a2dae69"></script> <script src="../../../../_static/sphinx_highlight.js?v=dc90522c"></script> <script src="../../../../_static/clipboard.min.js?v=a7894cd8"></script> <script src="../../../../_static/copybutton.js?v=30646c52"></script> <script src="../../../../_static/design-tabs.js?v=36754332"></script> <script src="../../../../_static/js/theme.js"></script> <link rel="index" title="Index" href="../../../../genindex.html" /> <link rel="search" title="Search" href="../../../../search.html" /> <link rel="next" title="GeckoView For Gecko Engineers" href="for-gecko-engineers.html" /> <link rel="prev" title="apilint release process" href="apilint.html" /> </head> <body class="wy-body-for-nav"> <div class="wy-grid-for-nav"> <nav data-toggle="wy-nav-shift" class="wy-nav-side"> <div class="wy-side-scroll"> <div class="wy-side-nav-search" > <a href="../../../../index.html" class="icon icon-home"> Firefox Source Docs <img src="../../../../_static/firefox-wordmark.svg" class="logo" alt="Logo"/> </a><! -- This code is governed by the BSD license --> <div> <h3>Quick search</h3> <script> (function () { var cx = "dd12886298f75dbef"; var gcse = document.createElement("script"); gcse.async = true; gcse.src = "https://cse.google.com/cse.js?cx=" + cx; var s = document.getElementsByTagName("script")[0]; s.parentNode.insertBefore(gcse, s); })(); </script> <gcse:search></gcse:search> </div> </div><div class="wy-menu wy-menu-vertical" data-spy="affix" role="navigation" aria-label="Navigation menu"> <p class="caption" role="heading"><span class="caption-text">Overview</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../glossary/index.html">A Glossary of Common Terms</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../overview/index.html">A Quick Guide to Mozilla Applications</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Getting Started</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../setup/index.html">Getting Set Up To Work On The Firefox Codebase</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Working On Firefox</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../contributing/index.html">Working on Firefox</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../bug-mgmt/index.html">Bug Handling</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Firefox User Guide</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../devtools-user/index.html">Firefox DevTools User Docs</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Source Code Documentation</span></p> <ul class="current"> <li class="toctree-l1"><a class="reference internal" href="../../../../mots/index.html">Governance</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../browser/index.html">Firefox Front-end</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../dom/index.html">DOM</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../editor/index.html">Editor</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../layout/index.html">Style system (CSS) & Layout</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../gfx/index.html">Graphics</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../ipc/index.html">Processes, Threads and IPC</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../devtools/index.html">Firefox DevTools Contributor Docs</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../toolkit/index.html">Toolkit</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../js/index.html">SpiderMonkey</a></li> <li class="toctree-l1 current"><a class="reference internal" href="../index.html">GeckoView</a><ul class="current"> <li class="toctree-l2 current"><a class="reference internal" href="../index.html#documentation">Documentation</a><ul class="current"> <li class="toctree-l3"><a class="reference internal" href="../consumer/index.html">Using GeckoView</a></li> <li class="toctree-l3 current"><a class="reference internal" href="index.html">Contributing to GeckoView</a><ul class="current"> <li class="toctree-l4"><a class="reference internal" href="apilint.html">apilint release process</a></li> <li class="toctree-l4 current"><a class="current reference internal" href="#">Mozilla Central Contributor Guide</a></li> <li class="toctree-l4"><a class="reference internal" href="for-gecko-engineers.html">GeckoView For Gecko Engineers</a></li> <li class="toctree-l4"><a class="reference internal" href="geckoview-architecture.html">Architecture overview</a></li> <li class="toctree-l4"><a class="reference internal" href="geckoview-quick-start.html">Contributor Guide</a></li> <li class="toctree-l4"><a class="reference internal" href="junit.html">Junit Test Framework</a></li> <li class="toctree-l4"><a class="reference internal" href="native-debugging.html">Debugging Native Code</a></li> </ul> </li> <li class="toctree-l3"><a class="reference internal" href="../design/index.html">Design docs</a></li> <li class="toctree-l3"><a class="reference external" href="https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/doc-files/CHANGELOG">Changelog</a></li> <li class="toctree-l3"><a class="reference external" href="https://mozilla.github.io/geckoview/javadoc/mozilla-central/index.html">API Javadoc</a></li> </ul> </li> <li class="toctree-l2"><a class="reference internal" href="../index.html#more-information">More information</a></li> </ul> </li> <li class="toctree-l1"><a class="reference internal" href="../../fenix/index.html">Fenix</a></li> <li class="toctree-l1"><a class="reference internal" href="../../focus-android/index.html">Focus for Android</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../dom/bindings/webidl/index.html">WebIDL</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../modules/libpref/index.html">libpref</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../networking/index.html">Networking</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../remote/index.html">Remote Protocols</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../services/index.html">Services</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../uriloader/index.html">File Handling</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../widget/cocoa/index.html">Firefox on macOS</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../widget/windows/index.html">Firefox on Windows</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../toolkit/components/ml/index.html">Firefox AI Platform</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../accessible/index.html">Accessibility</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../code-quality/index.html">Code quality</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../writing-rust-code/index.html">Writing Rust Code</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../rust-components/index.html">Rust Components</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/profiler/index.html">Gecko Profiler</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../performance/index.html">Performance</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../storage/index.html">Database bindings (SQLite, KV, …)</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../xpcom/index.html">XPCOM</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../nspr/index.html">NSPR</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../security/nss/index.html">Network Security Services (NSS)</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../content-security/index.html">Web Security Checks in Gecko</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">The Firefox Build System</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../mach/index.html">Mach</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/try/index.html">Pushing to Try</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../build/buildsystem/index.html">Build System</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../taskcluster/index.html">Firefox CI and Taskgraph</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/moztreedocs/index.html">Managing Documentation</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../mozbuild/vendor/index.html">Vendoring Third Party Components</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Testing & Test Infrastructure</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/automated-testing/index.html">Automated Testing</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/treeherder-try/index.html">Understanding Treeherder Results</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/sheriffed-intermittents/index.html">Sheriffed intermittent failures</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/tests-for-new-config/index.html">Turning on Firefox tests for a new configuration</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/intermittent/index.html">Avoiding intermittent tests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/testing-policy/index.html">Testing Policy</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/ci-configs/index.html">Configuration Changes</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/browser-chrome/index.html">Browser chrome mochitests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/chrome-tests/index.html">Chrome Tests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/marionette/index.html">Marionette</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/geckodriver/index.html">geckodriver</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/test-verification/index.html">Test Verification</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/webrender/index.html">WebRender Tests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/mochitest-plain/index.html">Mochitest</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/xpcshell/index.html">XPCShell tests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/tps/index.html">TPS</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../web-platform/index.html">web-platform-tests</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../gtest/index.html">GTest</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/fuzzing/index.html">Fuzzing</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/sanitizer/index.html">Sanitizer</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing/perfdocs/index.html">Performance Testing</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../tools/code-coverage/index.html">Code coverage</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../testing-rust-code/index.html">Testing & Debugging Rust Code</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Releases & Updates</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../update-infrastructure/index.html">Mozilla Update Infrastructure</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../update-infrastructure/index.html#watershed-updates">Watershed Updates</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../update-infrastructure/index.html#desupport-updates">Desupport Updates</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Localization & Internationalization</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../intl/index.html">Internationalization</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../l10n/index.html">Localization</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Firefox and Python</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../mozbase/index.html">mozbase</a></li> <li class="toctree-l1"><a class="reference internal" href="../../../../python/index.html">Using third-party Python packages</a></li> </ul> <p class="caption" role="heading"><span class="caption-text">Metrics Collected in Firefox</span></p> <ul> <li class="toctree-l1"><a class="reference internal" href="../../../../metrics/index.html">Metrics</a></li> </ul> </div> </div> </nav> <section data-toggle="wy-nav-shift" class="wy-nav-content-wrap"><nav class="wy-nav-top" aria-label="Mobile navigation menu" > <i data-toggle="wy-nav-top" class="fa fa-bars"></i> <a href="../../../../index.html">Firefox Source Docs</a> </nav> <div class="wy-nav-content"> <div class="rst-content"> <div role="navigation" aria-label="Page navigation"> <ul class="wy-breadcrumbs"> <li><a href="../../../../index.html" class="icon icon-home" aria-label="Home"></a></li> <li class="breadcrumb-item"><a href="../index.html">GeckoView</a></li> <li class="breadcrumb-item"><a href="index.html">Contributing to GeckoView</a></li> <li class="breadcrumb-item active">Mozilla Central Contributor Guide</li> <li class="wy-breadcrumbs-aside"> <a href="https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer+Infrastructure&component=Firefox+Source+Docs%3A+Content&short_desc=Documentation+issue+on+mobile/android/geckoview/contributor/contributing-to-mc&comment=URL+=+https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/contributing-to-mc.html&bug_file_loc=https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/contributing-to-mc.html" rel="nofollow" >Report an issue</a > / <a href="../../../../_sources/mobile/android/geckoview/contributor/contributing-to-mc.rst.txt" rel="nofollow"> View page source</a > </li> </ul> <hr/> </div> <div role="main" class="document" itemscope="itemscope" itemtype="http://schema.org/Article"> <div itemprop="articleBody"> <section id="mozilla-central-contributor-guide"> <h1>Mozilla Central Contributor Guide<a class="headerlink" href="#mozilla-central-contributor-guide" title="Link to this heading">¶</a></h1> <section id="table-of-contents"> <h2>Table of contents<a class="headerlink" href="#table-of-contents" title="Link to this heading">¶</a></h2> </section> <section id="submitting-a-patch-to-firefox-using-git"> <h2>Submitting a patch to Firefox using Git.<a class="headerlink" href="#submitting-a-patch-to-firefox-using-git" title="Link to this heading">¶</a></h2> <p id="contribute-with-git">This guide will take you through submitting and updating a patch to <code class="docutils literal notranslate"><span class="pre">mozilla-central</span></code> as a git user. You need to already be <a class="reference external" href="/setup/index.html">set up to use git to contribute to mozilla-central</a>.</p> <section id="performing-a-bug-fix"> <h3>Performing a bug fix<a class="headerlink" href="#performing-a-bug-fix" title="Link to this heading">¶</a></h3> <p>All of the open bugs for issues in Firefox can be found in <a class="reference external" href="https://bugzilla.mozilla.org">Bugzilla</a>. If you know the component that you wish to contribute to you can use Bugzilla to search for issues in that project. If you are unsure which component you are interested in, you can search the <a class="reference external" href="https://bugzilla.mozilla.org/buglist.cgi?quicksearch=good-first-bug">Good First Bugs</a> list to find something you want to work on.</p> <ul class="simple"> <li><p>Once you have your bug, assign it to yourself in Bugzilla.</p></li> <li><p>Update your local copy of the firefox codebase to match the current version on the servers to ensure you are working with the most up to date code.</p></li> </ul> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>git<span class="w"> </span>remote<span class="w"> </span>update </pre></div> </div> <ul class="simple"> <li><p>Create a new feature branch tracking either Central or Inbound.</p></li> </ul> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>git<span class="w"> </span>checkout<span class="w"> </span>-b<span class="w"> </span>bugxxxxxxx<span class="w"> </span><span class="o">[</span>inbound<span class="p">|</span>central<span class="o">]</span>/default </pre></div> </div> <ul class="simple"> <li><p>Work on your bug, checking into git according to your preferred workflow. <em>Try to ensure that each individual commit compiles and passes all of the tests for your component. This will make it easier to land if you use ``moz-phab`` to submit (details later in this post).</em></p></li> </ul> <p>It may be helpful to have Mozilla commit access, at least level 1. There are three levels of commit access that give increasing levels of access to the repositories.</p> <p>Level 1: Try/User access. You will need this level of access commit to the try server.</p> <p>Level 2: General access. This will give you full commit access to any mercurial or SVN repository not requiring level 3 access.</p> <p>Level 3: Core access. You will need this level to commit directly to any of the core repositories (Firefox/Thunderbird/Fennec).</p> <p>If you wish to apply for commit access, please follow the guide found in the <a class="reference external" href="https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/">Mozilla Commit Access Policy</a>.</p> <section id="submitting-a-patch-that-touches-c-c"> <h4>Submitting a patch that touches C/C++<a class="headerlink" href="#submitting-a-patch-that-touches-c-c" title="Link to this heading">¶</a></h4> <p>If your patch makes changes to any C or C++ code and your editor does not have <code class="docutils literal notranslate"><span class="pre">clang-format</span></code> support, you should run the clang-format linter before submitting your patch to ensure that your code is properly formatted.</p> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>mach<span class="w"> </span>clang-format<span class="w"> </span>-p<span class="w"> </span>path/to/file.cpp </pre></div> </div> <p>Note that <code class="docutils literal notranslate"><span class="pre">./mach</span> <span class="pre">bootstrap</span></code> will offer to set up a commit hook that will automatically do this for you.</p> </section> <section id="submitting-to-try-with-level-1-commit-access"> <h4>Submitting to <code class="docutils literal notranslate"><span class="pre">try</span></code> with Level 1 commit access.<a class="headerlink" href="#submitting-to-try-with-level-1-commit-access" title="Link to this heading">¶</a></h4> <p>If you only have Level 1 access, you will still need to submit your patch through phabricator, but you can test it on the try server first.</p> <ul class="simple"> <li><p>Use <code class="docutils literal notranslate"><span class="pre">./mach</span> <span class="pre">try</span> <span class="pre">fuzzy</span></code> to select jobs to run and push to try.</p></li> </ul> </section> <section id="submitting-a-patch-via-phabricator"> <h4>Submitting a patch via Phabricator.<a class="headerlink" href="#submitting-a-patch-via-phabricator" title="Link to this heading">¶</a></h4> <p>To commit anything to the repository, you will need to set up moz-phab and Phabricator. If you are using <code class="docutils literal notranslate"><span class="pre">git-cinnabar</span></code> then you will need to use git enabled versions of these tools.</p> <section id="set-up-phabricator"> <h5>Set up Phabricator<a class="headerlink" href="#set-up-phabricator" title="Link to this heading">¶</a></h5> <ul> <li><p>In a browser, visit Mozilla’s Phabricator instance at <a class="reference external" href="https://phabricator.services.mozilla.com/">https://phabricator.services.mozilla.com/</a>.</p></li> <li><p>Click “Log In” at the top of the page</p> <figure class="align-default" id="id1"> <img alt="Log in to Phabricator" src="../../../../_images/LogInPhab.png" /> <figcaption> <p><span class="caption-text">alt text</span><a class="headerlink" href="#id1" title="Link to this image">¶</a></p> </figcaption> </figure> </li> <li><p>Click the “Log In or Register” button on the next page. This will take you to Bugzilla to log in or register a new account.</p> <figure class="align-default" id="id2"> <img alt="Log in or register a Phabiricator account" src="../../../../_images/LogInOrRegister.png" /> <figcaption> <p><span class="caption-text">alt text</span><a class="headerlink" href="#id2" title="Link to this image">¶</a></p> </figcaption> </figure> </li> <li><p>Sign in with your Bugzilla credentials, or create a new account.</p> <figure class="align-default" id="id3"> <img alt="Log in with Bugzilla" src="../../../../_images/LogInBugzilla.png" /> <figcaption> <p><span class="caption-text">alt text</span><a class="headerlink" href="#id3" title="Link to this image">¶</a></p> </figcaption> </figure> </li> <li><p>You will be redirected back to Phabricator, where you will have to create a new Phabricator account.</p> <Screenshot Needed></li> <li><p>Fill in/amend any fields on the form and click “Register Account”.</p> <Screenshot Needed></li> <li><p>You now have a Phabricator account and can submit and review patches.</p></li> </ul> </section> <section id="installing-moz-phab"> <h5>Installing <code class="docutils literal notranslate"><span class="pre">moz-phab</span></code><a class="headerlink" href="#installing-moz-phab" title="Link to this heading">¶</a></h5> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>pip<span class="w"> </span>install<span class="w"> </span>MozPhab<span class="w"> </span><span class="o">[</span>--user<span class="o">]</span> </pre></div> </div> </section> <section id="submitting-a-patch-using-moz-phab"> <h5>Submitting a patch using <code class="docutils literal notranslate"><span class="pre">moz-phab</span></code>.<a class="headerlink" href="#submitting-a-patch-using-moz-phab" title="Link to this heading">¶</a></h5> <ul class="simple"> <li><p>Ensure you are on the branch where you have commits that you want to submit.</p></li> </ul> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>git<span class="w"> </span>checkout<span class="w"> </span>your-branch </pre></div> </div> <ul class="simple"> <li><p>Check the revision numbers for the commits you want to submit</p></li> </ul> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>git<span class="w"> </span>log </pre></div> </div> <ul class="simple"> <li><p>Run <code class="docutils literal notranslate"><span class="pre">moz-phab</span></code>. Specifying a start commit will submit all commits from that commit. Specifying an end commit will submit all commits up to that commit. If no positional arguments are provided, the range is determined to be starting with the first non-public, non-obsolete changeset (for Mercurial) and ending with the currently checked-out changeset.</p></li> </ul> <div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>moz-phab<span class="w"> </span>submit<span class="w"> </span><span class="o">[</span>start_rev<span class="o">]</span><span class="w"> </span><span class="o">[</span>end_rev<span class="o">]</span> </pre></div> </div> <ul class="simple"> <li><p>You will receive a Phabricator link for each commit in the set.</p></li> </ul> </section> </section> <section id="updating-a-patch"> <h4>Updating a patch<a class="headerlink" href="#updating-a-patch" title="Link to this heading">¶</a></h4> <ul class="simple"> <li><p>Often you will need to make amendments to a patch after it has been submitted to address review comments. To do this, add your commits to the base branch of your fix as normal.</p></li> </ul> <p>For <code class="docutils literal notranslate"><span class="pre">moz-phab</span></code> run in the same way as the initial submission with the same arguments, that is, specifying the full original range of commits. Note that, while inserting and amending commits should work fine, reordering commits is not yet supported, and deleting commits will leave the associated revisions open, which should be abandoned manually</p> </section> </section> </section> </section> </div> </div> <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer"> <a href="apilint.html" class="btn btn-neutral float-left" title="apilint release process" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a> <a href="for-gecko-engineers.html" class="btn btn-neutral float-right" title="GeckoView For Gecko Engineers" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a> </div> <hr/> <div role="contentinfo"> <p></p> </div> Built with <a href="https://www.sphinx-doc.org/">Sphinx</a> using a <a href="https://github.com/readthedocs/sphinx_rtd_theme">theme</a> provided by <a href="https://readthedocs.org">Read the Docs</a>. </footer> </div> </div> </section> </div> <script> jQuery(function () { SphinxRtdTheme.Navigation.enable(true); }); </script> </body> </html>