CINXE.COM

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: Greg KH: Re: [PATCH] PCI: Add pci shutdown ability</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by Greg KH" href="/groupie.php?aid=45" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/4"> [Apr]</a> 聽 <a class="nb" href="/lkml/2005/4/25"> [25]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/4/25/204" onclick="this.href='/lkml/headers'+'/2005/4/25/204';">[headers]</a>聽 <a href="/lkml/bounce/2005/4/25/204">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/4/25/154">First message in thread</a></li><li><a href="/lkml/2005/4/25/154">Greg KH</a><ul><li><a href="/lkml/2005/4/25/163">Jeff Garzik</a><ul><li><a href="/lkml/2005/4/25/178">Greg KH</a></li><li><a href="/lkml/2005/4/25/184">Adam Belay</a></li></ul></li><li><a href="/lkml/2005/4/25/172">Alexander Nyberg</a><ul><li><a href="/lkml/2005/4/25/181">Alan Stern</a><ul><li><a href="/lkml/2005/4/25/199">Alexander Nyberg</a><ul><li><a href="/lkml/2005/4/25/207">Alan Stern</a></li></ul></li><li><a href="/lkml/2005/4/25/225">Andrew Morton</a><ul><li><a href="/lkml/2005/4/25/228">Dave Jones</a></li><li><a href="/lkml/2005/4/25/297">Benjamin Herrenschmidt</a></li><li><a href="/lkml/2005/4/26/175">Alan Stern</a></li></ul></li><li><a href="/lkml/2005/4/26/187">Grant Grundler</a><ul><li><a href="/lkml/2005/4/26/204">"Richard B. Johnson"</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/25/182">Greg KH</a><ul><li><a href="/lkml/2005/4/26/1">Benjamin Herrenschmidt</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/25/179">Adam Belay</a><ul><li><a href="/lkml/2005/4/25/187">Greg KH</a><ul><li><a href="/lkml/2005/4/25/191">Adam Belay</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/25/196">Pavel Machek</a><ul><li><a href="/lkml/2005/4/25/201">Adam Belay</a><ul><li><a href="/lkml/2005/4/25/208">Pavel Machek</a><ul><li><a href="/lkml/2005/4/26/13">Benjamin Herrenschmidt</a></li><li><a href="/lkml/2005/4/26/148">David Brownell</a></li></ul></li></ul></li><li class="origin"><a href="/lkml/2005/4/25/217">Greg KH</a><ul><li><a href="/lkml/2005/4/25/217">Pavel Machek</a></li><li><a href="/lkml/2005/4/25/295">Benjamin Herrenschmidt</a><ul><li><a href="/lkml/2005/4/26/106">Pavel Machek</a></li></ul></li></ul></li><li><a href="/lkml/2005/4/25/210">David Brownell</a></li><li><a href="/lkml/2005/4/25/294">Benjamin Herrenschmidt</a><ul><li><a href="/lkml/2005/4/26/42">Adam Belay</a><ul><li><a href="/lkml/2005/4/26/45">Greg KH</a></li></ul></li></ul></li></ul></li></ul></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Mon, 25 Apr 2005 14:00:14 -0700</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">Greg KH <></td></tr><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH] PCI: Add pci shutdown ability</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody">On Mon, Apr 25, 2005 at 10:42:07PM +0200, Pavel Machek wrote:<br />> Hi!<br />> <br />> > Well it seems that people are starting to want to hook the reboot<br />> > notifier, or the device shutdown facility in order to properly shutdown<br />> > pci drivers to make kexec work nicer.<br />> > <br />> > So here's a patch for the PCI core that allows pci drivers to now just<br />> > add a "shutdown" notifier function that will be called when the system<br />> > is being shutdown. It happens just after the reboot notifier happens,<br />> > and it should happen in the proper device tree order, so everyone should<br />> > be happy.<br />> > <br />> > Any objections to this patch?<br />> <br />> Yes.<br />> <br />> I believe it should just do suspend(PMSG_SUSPEND) before system<br />> shutdown. If you think distintion between shutdown and suspend is<br />> important (I am not 100% convinced it is), we can just add flag<br />> saying "this is system shutdown".<br /><br />Then why even have the device_shutdown() call and notifier in the struct<br />device_driver?<br /><br />> Actually this patch should be in the queue somewhere... We had it in<br />> suse trees for a long time, and IMO it can solve problem easily.<br />> <br />> Pavel<br />> <br />> --- clean-git/kernel/sys.c 2005-04-23 23:21:55.000000000 +0200<br />> +++ linux/kernel/sys.c 2005-04-24 00:20:47.000000000 +0200<br />> @@ -404,6 +404,7 @@<br />> case LINUX_REBOOT_CMD_HALT:<br />> notifier_call_chain(&reboot_notifier_list, SYS_HALT, NULL);<br />> system_state = SYSTEM_HALT;<br />> + device_suspend(PMSG_SUSPEND);<br />> device_shutdown();<br /><br />Again, why keep device_shutdown() around at all then?<br /><br />thanks,<br /><br />greg k-h<br />-<br />To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html">http://vger.kernel.org/majordomo-info.html</a><br />Please read the FAQ at <a href="http://www.tux.org/lkml/">http://www.tux.org/lkml/</a><br /><br /></pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-04-25 23:10 聽聽 [from the cache]<br />漏2003-2020 <a href="http://blog.jasper.es/"><span itemprop="editor">Jasper Spaans</span></a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>