LKML: (Michal =?iso-8859-2?q?Maru=B9ka?=): Re: [PATCH 2.6.15-rc7] clocks: export symbol do_posix_clock_monotonic_gettime + input: monotonic timestamps for evdev

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><title>LKML: (Michal =?iso-8859-2?q?Maru=B9ka?=): Re: [PATCH 2.6.15-rc7] clocks: export symbol do_posix_clock_monotonic_gettime + input: monotonic timestamps for evdev</title><link href="/css/message.css" rel="stylesheet" type="text/css" /><link href="/css/wrap.css" rel="alternate stylesheet" type="text/css" title="wrap" /><link href="/css/nowrap.css" rel="stylesheet" type="text/css" title="nowrap" /><link href="/favicon.ico" rel="shortcut icon" /><script src="/js/simple-calendar.js" type="text/javascript"></script><script src="/js/styleswitcher.js" type="text/javascript"></script><link rel="alternate" type="application/rss+xml" title="lkml.org : last 100 messages" href="/rss.php" /><link rel="alternate" type="application/rss+xml" title="lkml.org : last messages by (Michal =?iso-8859-2?q?Maru=B9ka?=)" href="/groupie.php?aid=7437" /><script> var _paq = window._paq = window._paq || []; /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ _paq.push(["setDoNotTrack", true]); _paq.push(["disableCookies"]); _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u="//m.lkml.org/"; _paq.push(['setTrackerUrl', u+'matomo.php']); _paq.push(['setSiteId', '1']); var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s); })(); </script></head><body onload="es.jasper.simpleCalendar.init();" itemscope="itemscope" itemtype="http://schema.org/BlogPosting"><table border="0" cellpadding="0" cellspacing="0"><tr><td width="180" align="center"><a href="/"><img style="border:0;width:135px;height:32px" src="/images/toprowlk.gif" alt="lkml.org" /></a></td><td width="32">聽</td><td class="nb"><div><a class="nb" href="/lkml"> [lkml]</a> 聽 <a class="nb" href="/lkml/2005"> [2005]</a> 聽 <a class="nb" href="/lkml/2005/12"> [Dec]</a> 聽 <a class="nb" href="/lkml/2005/12/27"> [27]</a> 聽 <a class="nb" href="/lkml/last100"> [last100]</a> 聽 <a href="/rss.php"><img src="/images/rss-or.gif" border="0" alt="RSS Feed" /></a></div><div>Views: <a href="#" class="nowrap" onclick="setActiveStyleSheet('wrap');return false;">[wrap]</a><a href="#" class="wrap" onclick="setActiveStyleSheet('nowrap');return false;">[no wrap]</a> 聽 <a class="nb" href="/lkml/mheaders/2005/12/27/141" onclick="this.href='/lkml/headers'+'/2005/12/27/141';">[headers]</a>聽 <a href="/lkml/bounce/2005/12/27/141">[forward]</a>聽 </div></td><td width="32">聽</td></tr><tr><td valign="top"><div class="es-jasper-simpleCalendar" baseurl="/lkml/"></div><div class="threadlist">Messages in this thread</div><ul class="threadlist"><li class="root"><a href="/lkml/2005/12/26/106">First message in thread</a></li><li><a href="/lkml/2005/12/26/106">(Michal =?iso-8859-2?q?Maru=B9ka?=)</a><ul><li><a href="/lkml/2005/12/27/25">Arjan van de Ven</a><ul><li class="origin"><a href="">(Michal =?iso-8859-2?q?Maru=B9ka?=)</a></li></ul></li></ul></li></ul><div class="threadlist">Patch in this message</div><ul class="threadlist"><li><a href="/lkml/diff/2005/12/27/141/1">Get diff 1</a></li></ul></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerl.gif" width="32" height="32" alt="/" /></td><td class="c" rowspan="2" valign="top" style="padding-top: 1em"><table><tr><td><table><tr><td class="lp">Subject</td><td class="rp" itemprop="name">Re: [PATCH 2.6.15-rc7] clocks: export symbol do_posix_clock_monotonic_gettime + input: monotonic timestamps for evdev</td></tr><tr><td class="lp">From</td><td class="rp" itemprop="author">(Michal Maru拧ka)</td></tr><tr><td class="lp">Date</td><td class="rp" itemprop="datePublished">Wed, 28 Dec 2005 00:07:49 +0100</td></tr></table></td><td></td></tr></table><pre itemprop="articleBody"> Arjan van de Ven <arjan@infradead.org> writes: > could you also include the patch to add the user (say evdev) in the same > patch please? here is my complete patch updated for -rc7: Summary: - export do_posix_clock_monotonic_gettime - implement an ioctl call for EVDEV to request timestamping of events with monotonic time. For complete explanation see my previous mail <a href="https://lkml.org/lkml/2005/10/6/92">http://lkml.org/lkml/2005/10/6/92</a> Signed-off-by: Michal Maruska <mmc@maruska.dyndns.org> --- linux-2.6.15-rc7/kernel/posix-timers.c 2005-12-26 13:01:54.000000000 +0100 +++ linux-2.6.15-rc7.mmc/kernel/posix-timers.c 2005-12-26 22:59:11.883817855 +0100 @@ -1219,6 +1219,7 @@ int do_posix_clock_monotonic_gettime(str { return do_posix_clock_monotonic_get(CLOCK_MONOTONIC, tp); } +EXPORT_SYMBOL_GPL(do_posix_clock_monotonic_gettime); int do_posix_clock_nosettime(clockid_t clockid, struct timespec *tp) { --- linux-2.6.15-rc7/drivers/input/evdev.c 2005-12-26 13:01:54.000000000 +0100 +++ linux-2.6.15-rc7.mmc/drivers/input/evdev.c 2005-12-27 16:41:06.842396740 +0100 @@ -6,6 +6,11 @@ * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 as published by * the Free Software Foundation. + * + * + * 2005-12-27 Optional timestamping with monotonic time + * by Michal Maruska <mmc@maruska.dyndns.org> + * */ #define EVDEV_MINOR_BASE 64 @@ -37,6 +42,7 @@ struct evdev_list { struct input_event buffer[EVDEV_BUFFER_SIZE]; int head; int tail; + int time_kind; /* which time to use for the timestamps. Monotonic or timeofday. Should I use enum? */ struct fasync_struct *fasync; struct evdev *evdev; struct list_head node; @@ -44,15 +50,37 @@ struct evdev_list { static struct evdev *evdev_table[EVDEV_MINORS]; +static inline +void +mem_copy_time(struct timeval *a, struct timeval* b) +{ + memcpy(a, b, sizeof(struct timeval)); +} + static void evdev_event(struct input_handle *handle, unsigned int type, unsigned int code, int value) { struct evdev *evdev = handle->private; struct evdev_list *list; + struct timeval mtv, dtv; + /* `do_posix_clock_monotonic_gettime' delivers a different struct, + * but i do the conversion immediately, and once. */ + struct timespec mts; + + do_posix_clock_monotonic_gettime(&mts); + mtv.tv_sec = mts.tv_sec; + mtv.tv_usec = mts.tv_nsec / 1000; + + do_gettimeofday(&dtv); /* for backward compatibility: */ + if (evdev->grab) { list = evdev->grab; - do_gettimeofday(&list->buffer[list->head].time); + if (list->time_kind == EV_USE_DAY_TIME) + mem_copy_time(&list->buffer[list->head].time,&dtv); + else + mem_copy_time(&list->buffer[list->head].time,&mtv); + list->buffer[list->head].type = type; list->buffer[list->head].code = code; list->buffer[list->head].value = value; @@ -62,7 +90,11 @@ static void evdev_event(struct input_han } else list_for_each_entry(list, &evdev->list, node) { - do_gettimeofday(&list->buffer[list->head].time); + if (list->time_kind == EV_USE_DAY_TIME) + mem_copy_time(&list->buffer[list->head].time,&dtv); + else + mem_copy_time(&list->buffer[list->head].time,&mtv); + list->buffer[list->head].type = type; list->buffer[list->head].code = code; list->buffer[list->head].value = value; @@ -134,6 +166,7 @@ static int evdev_open(struct inode * ino return -ENOMEM; memset(list, 0, sizeof(struct evdev_list)); + list->time_kind = EV_USE_DAY_TIME; /* for backward compatibility! */ list->evdev = evdev_table[i]; list_add_tail(&list->node, &evdev_table[i]->list); file->private_data = list; @@ -370,6 +403,17 @@ static long evdev_ioctl(struct file *fil evdev->grab = NULL; return 0; } + case EVIOCTIME: + switch (arg) { + case EV_USE_MONOTONIC_TIME: + list->time_kind = EV_USE_MONOTONIC_TIME; + return 0; + case EV_USE_DAY_TIME: + list->time_kind = EV_USE_DAY_TIME; + return 0; + default: + return -EINVAL; + } default: --- linux-2.6.15-rc7/include/linux/input.h 2005-12-26 13:01:54.000000000 +0100 +++ linux-2.6.15-rc7.mmc/include/linux/input.h 2005-12-27 16:48:09.932302548 +0100 @@ -79,6 +79,15 @@ struct input_absinfo { #define EVIOCGRAB _IOW('E', 0x90, int) /* Grab/Release device */ +#define EVIOCTIME _IOW('E', 0x91, int) /* choose what kind of time to use for timestamps */ + +/* + * Time used to timestamp + */ +#define EV_USE_MONOTONIC_TIME 0 +#define EV_USE_DAY_TIME 1 + + /* * Event types */</pre></td><td width="32" rowspan="2" class="c" valign="top"><img src="/images/icornerr.gif" width="32" height="32" alt="\" /></td></tr><tr><td align="right" valign="bottom"> 聽 </td></tr><tr><td align="right" valign="bottom">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerl.gif" width="32" height="32" alt="\" /></td><td class="c">聽</td><td class="c" valign="bottom" style="padding-bottom: 0px"><img src="/images/bcornerr.gif" width="32" height="32" alt="/" /></td></tr><tr><td align="right" valign="top" colspan="2"> 聽 </td><td class="lm">Last update: 2005-12-28 00:10 聽聽 [from the cache] 漏2003-2020 <a href="http://blog.jasper.es/">Jasper Spaans</a>|hosted at <a href="https://www.digitalocean.com/?refcode=9a8e99d24cf9">Digital Ocean</a> and my Meterkast|<a href="http://blog.jasper.es/categories.html#lkml-ref">Read the blog</a></td><td>聽</td></tr></table><script language="javascript" src="/js/styleswitcher.js" type="text/javascript"></script></body></html>

CINXE.COM

LKML: (Michal =?iso-8859-2?q?Maru=B9ka?=): Re: [PATCH 2.6.15-rc7] clocks: export symbol do_posix_clock_monotonic_gettime + input: monotonic timestamps for evdev