Patch Review

<!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <meta property="og:type" content="website"> <meta property="og:title" content="Patch Review"> <meta property="og:url" content="https://bugzilla.mozilla.org/show_bug.cgi?id=419596"> <meta property="og:description" content="RESOLVED (dwitte) in Firefox - Settings UI. Last updated 2020-09-26."> <meta name="twitter:label1" value="Type"> <meta name="twitter:data1" value="defect"> <meta name="twitter:label2" value="Priority"> <meta name="twitter:data2" value="P1"> <meta name="viewport" content="width=1024"> <meta name="color-scheme" content="dark light"> <meta name="generator" content=" 20241119.1"> <meta name="bugzilla-global" content="dummy" id="bugzilla-global" data-bugzilla="{"api_token":"","config":{"basepath":"\/"},"constant":{"COMMENT_COLS":80},"param":{"maxattachmentsize":"10240","maxusermatches":"50","splinter_base":"\/page.cgi?id=splinter.html&ignore=\/","use_markdown":"1"},"string":{"bug":"","bug_type_required":"You must select a Type for this ","component_required":"You must select a Component for this ","description_required":"You must enter a Description for this ","short_desc_required":"You must enter a Summary for this ","version_required":"You must select a Version for this "},"user":{"is_new":true,"login":""}}"> <meta name="google-site-verification" content="JYXIuR9cAlV7fLmglSrc_4UaJS6Wzh5Mdxiorqu5AQc" /> <title>Patch Review</title> <link href="/static/v20241119.1/skins/standard/global.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/extensions/Splinter/web/splinter.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/js/jquery/ui/jquery-ui-min.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/js/jquery/ui/jquery-ui-structure-min.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/js/jquery/ui/jquery-ui-theme-min.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/skins/lib/prism.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/extensions/Review/web/styles/badge.css" rel="stylesheet" type="text/css"><link href="/static/v20241119.1/extensions/Review/web/styles/review.css" rel="stylesheet" type="text/css"> <script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/jquery/jquery-min.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/jquery/ui/jquery-ui-min.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/jquery/plugins/devbridgeAutocomplete/devbridgeAutocomplete-min.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/global.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/util.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/widgets.js"></script> <script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a">BUGZILLA.value_descs = JSON.parse('{\"bug_status\":{},\"resolution\":{\"\":\"---\"}}'); review_suggestions = { _mentors: [ ], 'Settings UI': [ ], _end: 1 }; static_component = 'Settings UI'; </script> <script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/extensions/Splinter/web/splinter.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/field.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/data-table.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/lib/prism.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/extensions/GoogleAnalytics/web/js/analytics.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/js/lib/md5.min.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/extensions/Review/web/js/badge.js"></script><script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a" src="/static/v20241119.1/extensions/Review/web/js/review.js"></script> <link href="/static/v20241119.1/skins/lib/fontawesome.min.css" rel="stylesheet" type="text/css"> <link href="/static/v20241119.1/skins/lib/fontawesome-brands.min.css" rel="stylesheet" type="text/css"> <link href="/static/v20241119.1/skins/lib/fontawesome-solid.min.css" rel="stylesheet" type="text/css"> <link rel="search" type="application/opensearchdescription+xml" title="Bugzilla@Mozilla" href="/search_plugin.cgi"><link rel="shortcut icon" href="/extensions/BMO/web/images/favicon.ico"> <link rel="canonical" href="https://bugzilla.mozilla.org/show_bug.cgi?id=419596"> <link rel="shorturl" href="https://bugzilla.mozilla.org/419596"><meta name="google-analytics" content="UA-36116321-3" data-location="https://bugzilla.mozilla.org/pages/splinter" data-title="Patch Review"> <script async src="https://www.google-analytics.com/analytics.js"></script><meta name="robots" content="noarchive"> </head> <body class="bugzilla-mozilla-org skin-standard"> <div id="wrapper"> <header id="header" role="banner" aria-label="Global Header"> <div class="inner" role="none"> <button type="button" class="iconic ghost" id="open-menu-drawer" aria-label="Open Site Menu"> <span class="icon" aria-hidden="true" data-icon="menu"></span> </button><div id="header-external-links" class="dropdown" role="none"> <button type="button" id="header-external-menu-button" class="dropdown-button minor" aria-label="Show Mozilla Menu" aria-expanded="false" aria-haspopup="true" aria-controls="header-external-menu"> <img src="/static/v20241119.1/extensions/BMO/web/images/moz-fav-one-color-white-rgb.svg" width="32" height="32" alt=""> </button> <ul class="dropdown-content right" id="header-external-menu" role="menu" aria-label="Mozilla Menu" style="display:none;"> <li role="none"> <a href="https://www.mozilla.org/" role="menuitem"> <span class="label" role="none">Mozilla Home</span> </a> </li> <li role="separator"></li> <li role="none"> <a href="https://www.mozilla.org/privacy/websites/" role="menuitem"> <span class="label" role="none">Privacy</span> </a> </li> <li role="none"> <a href="https://www.mozilla.org/privacy/websites/#cookies" role="menuitem"> <span class="label" role="none">Cookies</span> </a> </li> <li role="none"> <a href="https://www.mozilla.org/about/legal/" role="menuitem"> <span class="label" role="none">Legal</span> </a> </li> </ul> </div> <h1 id="header-title" class="title" role="none"> <a class="header-button" href="https://bugzilla.mozilla.org/home" title="Go to home page"> <span aria-label="Go to Bugzilla Home Page">Bugzilla</span> </a> </h1> <form id="header-search" class="quicksearch" action="/buglist.cgi" data-no-csrf role="search" aria-label="Search Bugs"> <button type="button" class="iconic ghost" id="show-searchbox" aria-label="Search Bugs"> <span class="icon" aria-hidden="true" data-icon="search"></span> </button> <div class="searchbox-outer dropdown" role="combobox" aria-label="Quick Search" aria-haspopup="listbox" aria-owns="header-search-dropdown" aria-expanded="false"> <span class="icon" aria-hidden="true" data-icon="search"></span> <input id="quicksearch_top" class="dropdown-button" name="quicksearch" autocomplete="off" value="" accesskey="s" placeholder="Search Bugs" title="Enter a bug number or some search terms" role="searchbox" aria-controls="header-search-dropdown" aria-label="Search Terms"><div id="header-search-dropdown" class="dropdown-content dropdown-panel right" role="listbox" style="display: none;"> <div id="header-search-dropdown-wrapper" role="none"> <section id="header-search-dropdown-help" role="group" aria-label="Help"> <footer role="none"> <a href="/page.cgi?id=quicksearch.html">Quick Search Tips</a> <a href="/query.cgi?format=advanced">Advanced Search</a> </footer> </section> </div> </div> </div> </form> <nav id="header-nav" role="menubar" aria-label="Site Links"> <ul class="links" role="none"><li role="none"> <a class="header-button" href="/describecomponents.cgi" title="Browse bugs by component" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="category"></span> <span class="label" role="none">Browse</span> </a> </li> <li role="none"> <a class="header-button" href="/query.cgi?format=advanced" title="Search bugs using various criteria" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="pageview"></span> <span class="label" role="none">Advanced Search</span> </a> </li> <li role="none"> <a class="header-button" href="/enter_bug.cgi" title="File a new bug" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="add_box"></span> <span class="label" role="none">New Bug</span> </a> </li> </ul> <div class="dropdown" role="none"> <button type="button" id="header-tools-menu-button" class="header-button dropdown-button minor" title="More tools…" role="menuitem" aria-label="Show More Tools Menu" aria-expanded="false" aria-haspopup="true" aria-controls="header-tools-menu"> <span class="icon" aria-hidden="true" data-icon="more_horiz"></span> </button> <ul class="dropdown-content left" id="header-tools-menu" role="menu" aria-label="More Tools Menu" style="display:none;"><li role="none"> <a href="/report.cgi" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="analytics"></span> <span class="label" role="none">Reports</span> </a> </li> <li role="separator"></li> <li role="none"> <a href="https://bmo.readthedocs.io/en/latest/" target="_blank" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="help"></span> <span class="label" role="none">Documentation</span> </a> </li> </ul> </div> </nav> <ul id="header-login" class="links" role="none"><li id="mini_login_container_top" role="none"> <a id="login_link_top" href="/index.cgi?GoAheadAndLogIn=1" class='show_mini_login_form header-button' data-qs-suffix="_top" role="button"> <span class="icon" aria-hidden="true" data-icon="login"></span> <span class="label" role="none">Log In</span> </a> <div id="mini_login_top" class="mini-popup mini_login bz_default_hidden"> <form method="post" action="/github.cgi"> <input type="hidden" name="github_token" value="m0RdyEdwGaHyMGVEfZ0AuEOrzfOQQIe9XhLYpeUTJCyyYUHop1MEOvXzCSAygqVJEHleSyatRjcG6OJy6vPmbdDYm6bcUtfTeqWI0TjAk0rDvLy00QE46sv2WN0oEg9yUTQ2wBzFo7PLDQdtQkpNKr10Mz7wEKb2UrH2cEWPanVamVvpn1I4QPmrDuSZ7sNT4jUUD8mOqs4xHmFtah96LHRuJ8qGLhfkZ75MAM707MsuTQN0L0fiINorU3OlX58W"> <input type="hidden" name="target_uri" value="https://bugzilla.mozilla.org/page.cgi"> <button type="submit"> <i class="fab fa-github"></i> Log In with GitHub </button> </form> <div class="method-separator">or</div> <form action="/page.cgi?id=splinter.html&ignore=&bug=419596&attachment=308509" method="POST" data-qs-suffix="_top"> <input id="Bugzilla_login_top" class="bz_login" name="Bugzilla_login" title="Login" placeholder="Email" aria-label="Email" type="email" required > <input class="bz_password" id="Bugzilla_password_top" name="Bugzilla_password" type="password" title="Password" placeholder="Password" aria-label="Password" required > <input class="bz_password bz_default_hidden bz_mini_login_help" type="text" id="Bugzilla_password_dummy_top" value="password" title="Password" > <span class="remember-outer"> <input type="checkbox" id="Bugzilla_remember_top" name="Bugzilla_remember" value="on" class="bz_remember" checked> <label for="Bugzilla_remember_top">Remember me</label> </span> <input type="hidden" name="Bugzilla_login_token" value="1732382929-GfggU9hc_qKs73XDbPzJzpx_63o12az91Q8ozd1Ab-w"> <input type="submit" name="GoAheadAndLogIn" value="Log In" id="log_in_top" class="check_mini_login_fields" data-qs-suffix="_top"> <a href="#" id="hide_mini_login_top" aria-label="Close" class="close-button hide_mini_login_form" data-qs-suffix="_top"> <span class="icon" aria-hidden="true"></span> </a> </form> <div class="footer"> <a href="/createaccount.cgi">Create an Account</a> · <a id="forgot_link_top" href="/index.cgi?GoAheadAndLogIn=1#forgot" class='show_forgot_form' data-qs-suffix="_top">Forgot Password</a> </div> </div> <div id="forgot_form_top" class="mini-popup mini_forgot bz_default_hidden"> <form action="/token.cgi" method="post"> <input type="email" name="loginname" size="20" placeholder="Email" aria-label="Email" required> <input id="forgot_button_top" value="Reset Password" type="submit"> <input type="hidden" name="a" value="reqpw"> <input type="hidden" id="token_top" name="token" value="1732382929-hCgciunj68fyuQ-17WkpUlG4Z-PEmmYmG1UhDrLe8T4"> <a href="#" class="close-button hide_forgot_form" aria-label="Close" data-qs-suffix="_top"> <span class="icon" aria-hidden="true"></span> </a> </form> </div> </li> </ul> </div> <dialog id="menu-drawer" inert aria-label="Site Menu"> <div class="drawer-inner" role="none"> <div class="header" role="none"> <button type="button" class="iconic ghost" id="close-menu-drawer" aria-label="Close Site Menu"> <span class="icon" aria-hidden="true" data-icon="close"></span> </button> </div> <ul role="menu" aria-label="Site Links"><li role="none"> <a class="header-button" href="/describecomponents.cgi" title="Browse bugs by component" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="category"></span> <span class="label" role="none">Browse</span> </a> </li> <li role="none"> <a class="header-button" href="/query.cgi?format=advanced" title="Search bugs using various criteria" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="pageview"></span> <span class="label" role="none">Advanced Search</span> </a> </li> <li role="none"> <a class="header-button" href="/enter_bug.cgi" title="File a new bug" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="add_box"></span> <span class="label" role="none">New Bug</span> </a> </li><li role="none"> <a href="/report.cgi" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="analytics"></span> <span class="label" role="none">Reports</span> </a> </li> <li role="separator"></li> <li role="none"> <a href="https://bmo.readthedocs.io/en/latest/" target="_blank" role="menuitem"> <span class="icon" aria-hidden="true" data-icon="help"></span> <span class="label" role="none">Documentation</span> </a> </li> </ul> </div> </dialog> </header> <main id="bugzilla-body" tabindex="-1"> <aside id="message-container" role="complementary"> <noscript> <div class="noscript"> <div class="inner"> <p>Please enable JavaScript in your browser to use all the features on this site.</p> </div> </div> </noscript> </aside> <div id="main-inner"> <script nonce="7hoOM05g1h9O3zzC6k5AEiHj6By1gAegYhXAe9edFAYdQy5a"> Splinter.configBase = 'https:\/\/bugzilla.mozilla.org\/page.cgi?id=splinter.html&ignore='; Splinter.configBugUrl = '\/'; Splinter.configHaveExtension = true; Splinter.configHelp = '\/page.cgi?id=splinter/help.html'; Splinter.configNote = ''; Splinter.readOnly = 0 == 0; Splinter.configAttachmentStatuses = [ ]; Splinter.bugId = Splinter.Utils.isDigits('419596') ? parseInt('419596') : NaN; Splinter.attachmentId = Splinter.Utils.isDigits('308509') ? parseInt('308509') : NaN; if (!isNaN(Splinter.bugId)) { var theBug = new Splinter.Bug.Bug(); theBug.id = parseInt('419596'); theBug.token = ''; theBug.shortDesc = Splinter.Utils.strip('add third party cookie blocking option to cookie pref UI'); theBug.creationDate = Splinter.Bug.parseDate('2008-02-26 01:58:33 -0800'); theBug.reporterEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); theBug.reporterName = Splinter.Utils.strip('dwitte\x40gmail.com'); Splinter.attachmentComment = 'updated per discussion with gavin - drop the variable to store \'third party\' checkbox state, and just check it whenever \'accept cookies\' is checked.'; var attachid = parseInt('307678'); var attachment = new Splinter.Bug.Attachment('', attachid); attachment.description = Splinter.Utils.strip('patch v1'); attachment.filename = Splinter.Utils.strip('419596-1.diff'); attachment.contenttypeentry = Splinter.Utils.strip(''); attachment.date = Splinter.Bug.parseDate('2008-03-06 02:50:34 -0800'); attachment.whoName = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.whoEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.isPatch = 1; attachment.isObsolete = 1; attachment.isPrivate = 0; attachment.isCRLF = 0; theBug.attachments.push(attachment); var attachid = parseInt('307680'); var attachment = new Splinter.Bug.Attachment('', attachid); attachment.description = Splinter.Utils.strip('patch v1, string only'); attachment.filename = Splinter.Utils.strip('419596-1-string.diff'); attachment.contenttypeentry = Splinter.Utils.strip(''); attachment.date = Splinter.Bug.parseDate('2008-03-06 02:53:11 -0800'); attachment.whoName = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.whoEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.isPatch = 1; attachment.isObsolete = 1; attachment.isPrivate = 0; attachment.isCRLF = 0; theBug.attachments.push(attachment); var attachid = parseInt('307854'); var attachment = new Splinter.Bug.Attachment('', attachid); attachment.description = Splinter.Utils.strip('patch v2'); attachment.filename = Splinter.Utils.strip('419596-2.diff'); attachment.contenttypeentry = Splinter.Utils.strip(''); attachment.date = Splinter.Bug.parseDate('2008-03-06 17:50:56 -0800'); attachment.whoName = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.whoEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.isPatch = 1; attachment.isObsolete = 1; attachment.isPrivate = 0; attachment.isCRLF = 0; theBug.attachments.push(attachment); var attachid = parseInt('307855'); var attachment = new Splinter.Bug.Attachment('', attachid); attachment.description = Splinter.Utils.strip('patch v2, string change (checked in)'); attachment.filename = Splinter.Utils.strip('419596-2-string.diff'); attachment.contenttypeentry = Splinter.Utils.strip(''); attachment.date = Splinter.Bug.parseDate('2008-03-06 17:52:07 -0800'); attachment.whoName = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.whoEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.isPatch = 1; attachment.isObsolete = 0; attachment.isPrivate = 0; attachment.isCRLF = 0; theBug.attachments.push(attachment); var attachid = parseInt('308509'); var attachment = new Splinter.Bug.Attachment('', attachid); attachment.data = 'Index: browser\/components\/preferences\/privacy.js\n===================================================================\nRCS file: \/cvsroot\/mozilla\/browser\/components\/preferences\/privacy.js,v\nretrieving revision 1.25\ndiff -u -8 -p -r1.25 privacy.js\n--- browser\/components\/preferences\/privacy.js 25 Feb 2008 08:50:16 -0000 1.25\n+++ browser\/components\/preferences\/privacy.js 10 Mar 2008 23:23:32 -0000\n\x40\x40 -156,53 +156,73 \x40\x40 var gPrivacyPane = {\n \/\/ COOKIES\n \n \/*\n * Preferences:\n *\n * network.cookie.cookieBehavior\n * - determines how the browser should handle cookies:\n * 0 means enable all cookies\n- * 1 means allow cookies from the \"originating\" server only; see\n+ * 1 means reject third party cookies; see\n * netwerk\/cookie\/src\/nsCookieService.cpp for a hairier definition\n * 2 means disable all cookies\n * network.cookie.lifetimePolicy\n * - determines how long cookies are stored:\n * 0 means keep cookies until they expire\n * 1 means ask how long to keep each cookie\n * 2 means keep cookies until the browser is closed\n *\/\n \n \/**\n * Reads the network.cookie.cookieBehavior preference value and\n- * enables\/disables the \"Keep until:\" UI accordingly, returning true\n+ * enables\/disables the rest of the cookie UI accordingly, returning true\n * if cookies are enabled.\n *\/\n readAcceptCookies: function ()\n {\n var pref = document.getElementById(\"network.cookie.cookieBehavior\");\n+ var acceptThirdParty = document.getElementById(\"acceptThirdParty\");\n var keepUntil = document.getElementById(\"keepUntil\");\n var menu = document.getElementById(\"keepCookiesUntil\");\n \n- \/\/ anything other than \"disable all cookies\" maps to \"accept cookies\"\n+ \/\/ enable the rest of the UI for anything other than \"disable all cookies\"\n var acceptCookies = (pref.value != 2);\n \n- keepUntil.disabled = menu.disabled = !acceptCookies;\n+ keepUntil.disabled = menu.disabled = acceptThirdParty.disabled = !acceptCookies;\n \n return acceptCookies;\n },\n \n+ readAcceptThirdPartyCookies: function ()\n+ {\n+ var pref = document.getElementById(\"network.cookie.cookieBehavior\");\n+ return pref.value == 0;\n+ },\n+\n \/**\n * Enables\/disables the \"keep until\" label and menulist in response to the\n * \"accept cookies\" checkbox being checked or unchecked.\n *\/\n writeAcceptCookies: function ()\n {\n- var checkbox = document.getElementById(\"acceptCookies\");\n- return checkbox.checked ? 0 : 2;\n+ var accept = document.getElementById(\"acceptCookies\");\n+ var acceptThirdParty = document.getElementById(\"acceptThirdParty\");\n+\n+ \/\/ if we\'re enabling cookies, automatically check \'accept third party\'\n+ if (accept.checked)\n+ acceptThirdParty.checked = true;\n+\n+ return accept.checked ? (acceptThirdParty.checked ? 0 : 1) : 2;\n+ },\n+\n+ writeAcceptThirdPartyCookies: function ()\n+ {\n+ var accept = document.getElementById(\"acceptCookies\");\n+ var acceptThirdParty = document.getElementById(\"acceptThirdParty\");\n+ return accept.checked ? (acceptThirdParty.checked ? 0 : 1) : 2;\n },\n \n \/**\n * Displays fine-grained, per-site preferences for cookies.\n *\/\n showCookieExceptions: function ()\n {\n var bundlePreferences = document.getElementById(\"bundlePreferences\");\nIndex: browser\/components\/preferences\/privacy.xul\n===================================================================\nRCS file: \/cvsroot\/mozilla\/browser\/components\/preferences\/privacy.xul,v\nretrieving revision 1.26\ndiff -u -8 -p -r1.26 privacy.xul\n--- browser\/components\/preferences\/privacy.xul 8 Mar 2008 01:07:48 -0000 1.26\n+++ browser\/components\/preferences\/privacy.xul 10 Mar 2008 23:23:32 -0000\n\x40\x40 -137,16 +137,22 \x40\x40\n preference=\"network.cookie.cookieBehavior\"\n accesskey=\"&acceptCookies.accesskey;\"\n onsyncfrompreference=\"return gPrivacyPane.readAcceptCookies();\"\n onsynctopreference=\"return gPrivacyPane.writeAcceptCookies();\"\/\x3e\n \x3cbutton id=\"cookieExceptions\" oncommand=\"gPrivacyPane.showCookieExceptions();\"\n label=\"&cookieExceptions.label;\" accesskey=\"&cookieExceptions.accesskey;\"\n preference=\"pref.privacy.disable_button.cookie_exceptions\"\/\x3e\n \x3c\/hbox\x3e\n+ \x3ccheckbox id=\"acceptThirdParty\" label=\"&acceptThirdParty.label;\" class=\"indent\"\n+ preference=\"network.cookie.cookieBehavior\"\n+ accesskey=\"&acceptThirdParty.accesskey;\"\n+ onsyncfrompreference=\"return gPrivacyPane.readAcceptThirdPartyCookies();\"\n+ onsynctopreference=\"return gPrivacyPane.writeAcceptThirdPartyCookies();\"\/\x3e\n+\n \x3chbox id=\"keepRow\"\x3e\n \x3chbox id=\"keepBox\" align=\"center\" class=\"indent\"\x3e\n \x3clabel id=\"keepUntil\"\n control=\"keepCookiesUntil\"\n accesskey=\"&keepUntil.accesskey;\"\x3e&keepUntil.label;\x3c\/label\x3e\n \x3cmenulist id=\"keepCookiesUntil\"\n preference=\"network.cookie.lifetimePolicy\"\x3e\n \x3cmenupopup\x3e\n'; attachment.token = '1732382929-mnUp4XzGPoFOkEq8_BgFadyaYmEpIj3TDlm78ywE3Cw'; attachment.description = Splinter.Utils.strip('patch v3'); attachment.filename = Splinter.Utils.strip('419596-3.diff'); attachment.contenttypeentry = Splinter.Utils.strip(''); attachment.date = Splinter.Bug.parseDate('2008-03-10 16:26:31 -0700'); attachment.whoName = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.whoEmail = Splinter.Utils.strip('dwitte\x40gmail.com'); attachment.isPatch = 1; attachment.isObsolete = 0; attachment.isPrivate = 0; attachment.isCRLF = 0; theBug.attachments.push(attachment); Splinter.theBug = theBug; } </script>  <div id="helpful-links"> <a id='helpLink' target='splinterHelp' href="/page.cgi?id=splinter/help.html"> [help]</a> </div> <div id="bugInfo" style="display: none;"> <b>Bug <a id="bugLink"><span id="bugId"></span></a>:</b> <span id="bugShortDesc"></span> - <span id="bugReporter"></span> - <span id="bugCreationDate"></span> </div> <div id="attachInfo" style="display:none;"> <span id="attachWarning"></span> <b>Attachment <a id="attachLink"><span id="attachId"></span></a>:</b> <span id="attachDesc"></span> - <span id="attachCreator"></span> - <span id="attachDate"></span> <a href="/attachment.cgi?id=308509&action=diff" target="_blank">[diff]</a> <a href="/attachment.cgi?id=308509&action=edit" target="_blank">[details]</a> <p> <b>Comment:</b><br> <span id="attachComment"></span> </p> </div> <div id="error" style="display: none;"> </div> <div id="enterBug" style="display: none;">Bug to review: <input id="enterBugInput"> <input id="enterBugGo" type="button" value="Go"> <div id="chooseReview" style="display: none;"> Drafts and published reviews: <div id="chooseReviewTable"></div> </div> </div> <div id="chooseAttachment" style="display: none;"> <div id="chooseAttachmentTable"></div> </div> <div id="quickHelpShow" style="display:none;"> <p> <a href="javascript:Splinter.quickHelpToggle();" title="Show the quick help section" id="quickHelpToggle"> Show Quick Help</a> </p> </div> <div id="quickHelpContent" style="display:none;"> <p> <a href="javascript:Splinter.quickHelpToggle();" title="Hide the quick help section" id="quickHelpToggle">Close Quick Help</a> </p> <ul id="quickHelpList"> <li>From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.</li> <li>To comment on a specific lines in the patch, first select the filename from the file navigation links.</li> <li>Then double click the line you want to review and a comment box will appear below the line.</li> <li>When the review is complete and you publish it, the overview comment and all line specific comments with their context, will be combined together into a single review comment on the bug report.</li> <li>For more detailed instructions, read the Splinter <a id='helpLink' target='splinterHelp' href="/page.cgi?id=splinter/help.html">help page</a>. </li> </ul> </div> <div id="navigationContainer" style="display: none;"> <b>Navigation:</b> <span id="navigation"></span> </div> <div id="overview" style="display: none;"> <div id="patchIntro"></div> <div> <span id="restored" style="display: none;"> (Restored from draft; last edited <span id="restoredLastModified"></span>) </span> </div> <div> You must be logged in to review patches. </div> <div id="oldReviews" style="display: none;"> <div class="review-title"> Previous Reviews </div> </div> </div> <div id="splinter-files" style="display: none;"> <div id="file-collapse-all" style="display:none;"> <a href="javascript:void(0);" onclick="Splinter.toggleCollapsed('', 'none')">Collapse All</a> | <a href="javascript:void(0);" onclick="Splinter.toggleCollapsed('', 'block')">Expand All</a> </div> </div> <div id="credits"> Powered by <a href="http://fishsoup.net/software/splinter">Splinter</a> </div> <div id="saveDraftNotice" style="display: none;"></div> </div> </main> </div> </body> </html>

CINXE.COM

Patch Review