codereview: should the Go project stop importing GitHub PRs? · golang/go · Discussion #61182

<!DOCTYPE html> <html lang="en" data-color-mode="auto" data-light-theme="light" data-dark-theme="dark" data-a11y-animated-images="system" data-a11y-link-underlines="true" > <head> <meta charset="utf-8"> <link rel="dns-prefetch" href="https://github.githubassets.com"> <link rel="dns-prefetch" href="https://avatars.githubusercontent.com"> <link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com"> <link rel="dns-prefetch" href="https://user-images.githubusercontent.com/"> <link rel="preconnect" href="https://github.githubassets.com" crossorigin> <link rel="preconnect" href="https://avatars.githubusercontent.com"> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/light-7aa84bb7e11e.css" /><link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/dark-f65db3e8d171.css" /><link data-color-theme="dark_dimmed" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_dimmed-a8258e3c6dda.css" /><link data-color-theme="dark_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_high_contrast-7e97d834719c.css" /><link data-color-theme="dark_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_colorblind-01d869f460be.css" /><link data-color-theme="light_colorblind" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_colorblind-534f3e971240.css" /><link data-color-theme="light_high_contrast" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_high_contrast-a8cc7d138001.css" /><link data-color-theme="light_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_tritanopia-35e9dfdc4f9f.css" /><link data-color-theme="dark_tritanopia" crossorigin="anonymous" media="all" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_tritanopia-cf4cc5f62dfe.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-primitives-d9abecd14f1e.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-93aded0ee8a1.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/global-8bed0685a4b5.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/github-a954a02d9269.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/repository-4fce88777fa8.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/discussions-dae9ae1a46a6.css" /> <script type="application/json" id="client-env">{"locale":"en","featureFlags":["bypass_copilot_indexing_quota","copilot_immersive_file_preview","copilot_new_references_ui","copilot_bing_skill_ga","copilot_attach_folder_reference","copilot_personal_instructions","copilot_personal_instructions_templates","copilot_chat_repo_custom_instructions_preview","copilot_chat_retry_on_error","copilot_chat_persist_submitted_input","copilot_conversational_ux_history_refs","copilot_chat_shared_chat_input","copilot_chat_shared_topic_indicator","copilot_chat_shared_repo_sso_banner","copilot_editor_upsells","copilot_dotcom_chat_reduce_telemetry","copilot_implicit_context","copilot_no_floating_button","copilot_smell_icebreaker_ux","copilot_read_shared_conversation","dotcom_chat_client_side_skills","copilot_new_markdown_renderer","experimentation_azure_variant_endpoint","failbot_handle_non_errors","geojson_azure_maps","ghost_pilot_confidence_truncation_25","ghost_pilot_confidence_truncation_40","github_models_o3_mini_streaming","hovercard_accessibility","issues_react_remove_placeholders","issues_react_blur_item_picker_on_close","issues_react_include_bots_in_pickers","marketing_pages_search_explore_provider","remove_child_patch","sample_network_conn_type","swp_enterprise_contact_form","site_copilot_vscode_link_update","site_proxima_australia_update","issues_react_create_milestone","issues_react_cache_fix_workaround","lifecycle_label_name_updates"]}</script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/wp-runtime-890f3c3d3caa.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover_js-9da652f58479.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_arianotify-polyfill_ariaNotify-polyfill_js-node_modules_github_mi-3abb8f-d7e6bc799724.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_failbot_failbot_ts-4600dbf2d60a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/environment-f04cb2a9fc8c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_primer_behaviors_dist_esm_index_mjs-0dbb79f97f8f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_selector-observer_dist_index_esm_js-f690fd9ae3d5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_relative-time-element_dist_index_js-f6da4b3fa34c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_auto-complete-element_dist_index_js-node_modules_github_catalyst_-8e9f78-a74b4e0a8a6b.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_text-expander-element_dist_index_js-78748950cb0c.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_filter-input-element_dist_index_js-node_modules_github_remote-inp-b5f1d7-a1760ffda83d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_markdown-toolbar-element_dist_index_js-ceef33f593fa.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co-c44a69-f0c8a795d1fd.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/github-elements-44d18ad044b3.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/element-registry-b7096f9a808d.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_braintree_browser-detection_dist_browser-detection_js-node_modules_githu-2906d7-2a07a295af40.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_lit-html_lit-html_js-be8cb88f481b.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_morphdom_dist_morphdom-e-7c534c-a4a1922eb55f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_turbo_dist_turbo_es2017-esm_js-e3cbe28f1638.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-893f9f-6cf3320416b8.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_color-convert_index_js-e3180fe3bcb3.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_quote-selection_dist_index_js-node_modules_github_session-resume_-947061-205cd97df772.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_updatable-content_updatable-content_ts-a1563f62660e.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_task-list_ts-app_assets_modules_github_sso_ts-ui_packages-900dde-f48a418a99d4.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_sticky-scroll-into-view_ts-8fa27fd7fbb6.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_ajax-error_ts-app_assets_modules_github_behaviors_include-87a4ae-e2caa5390f5a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_commenting_edit_ts-app_assets_modules_github_behaviors_ht-83c235-783fc7e142e5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/behaviors-854fa1987fb5.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_catalyst_lib_index_js-f6223d90c7ba.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-global-e12489347ccf.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_hotkey_dist_index_js-524e40420665.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_github_catalyst_lib_index_-280e4f-f7d6cfa05e86.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_session-resume_di-1969a0-56743397c9a2.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_form-utils_form-utils_ts-ui_packages_input-navigation-behavior_input-navigation-b-a97423-908328ee27af.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/discussions-59b64ff6732f.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/structured-issues-49dbc9dd2101.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/primer-react-8e38c0ecf8b7.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-core-218ef2d63cca.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/react-lib-f1bca44e0926.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/octicons-react-611691cca2f6.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_emotion_is-prop-valid_dist_emotion-is-prop-valid_esm_js-node_modules_emo-62da9f-2df2f32ec596.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_stacktrace-parser_dist_s-e7dcdd-f7cc96ebae76.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover-fn_js-55fea94174bf.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/notifications-subscriptions-menu-eff84ecbf2b6.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.5a0ffaf77c0db0d0dac2.module.css" /> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/notifications-subscriptions-menu.1bcff9205c241e99cff2.module.css" /> <title>codereview: should the Go project stop importing GitHub PRs? · golang/go · Discussion #61182 · GitHub</title> <meta name="route-pattern" content="/_view_fragments/Voltron::DiscussionsFragmentsController/show/:user_id/:repository/:discussion_number/discussion_layout(.:format)" data-turbo-transient> <meta name="route-controller" content="voltron_discussions_fragments" data-turbo-transient> <meta name="route-action" content="discussion_layout" data-turbo-transient> <meta name="current-catalog-service-hash" content="9f0abe34da433c9b6db74bffa2466494a717b579a96b30a5d252e5090baea7be"> <meta name="request-id" content="C0BC:140601:81094:9B415:67B36C11" data-pjax-transient="true"/><meta name="html-safe-nonce" content="0546e7414000b92248a6c4f9aedf221dfed87fee4cdc1321c0186d0659d4851a" data-pjax-transient="true"/><meta name="visitor-payload" content="eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEJDOjE0MDYwMTo4MTA5NDo5QjQxNTo2N0IzNkMxMSIsInZpc2l0b3JfaWQiOiI5MTk3NzEyODk4OTQ1OTM2NDAxIiwicmVnaW9uX2VkZ2UiOiJzb3V0aGVhc3Rhc2lhIiwicmVnaW9uX3JlbmRlciI6InNvdXRoZWFzdGFzaWEifQ==" data-pjax-transient="true"/><meta name="visitor-hmac" content="f4212f9ec1bc2269ae0266e97d4a2f2d79a643e080bf30efa3c7b569c317779b" data-pjax-transient="true"/> <meta name="hovercard-subject-tag" content="discussion:5371795" data-turbo-transient> <meta name="github-keyboard-shortcuts" content="repository,copilot" data-turbo-transient="true" /> <meta name="selected-link" value="repo_discussions" data-turbo-transient> <link rel="assets" href="https://github.githubassets.com/"> <meta name="google-site-verification" content="Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I"> <meta name="octolytics-url" content="https://collector.github.com/github/collect" /> <meta name="analytics-location" content="/<user-name>/<repo-name>/voltron/discussions_fragments/discussion_layout" data-turbo-transient="true" /> <meta name="user-login" content=""> <meta name="viewport" content="width=device-width"> <meta name="description" content="codereview: should the Go project stop importing GitHub PRs?"> <link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub"> <link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub"> <meta property="fb:app_id" content="1401488693436528"> <meta name="apple-itunes-app" content="app-id=1477376905, app-argument=https://github.com/_view_fragments/Voltron::DiscussionsFragmentsController/show/golang/go/61182/discussion_layout" /> <meta name="twitter:image" content="https://opengraph.githubassets.com/69da7e1b4e75f735cabc4e5ed922ab6eded6a4d69e553f018de41c95961af929/golang/go/discussions/61182" /><meta name="twitter:site" content="@github" /><meta name="twitter:card" content="summary_large_image" /><meta name="twitter:title" content="codereview: should the Go project stop importing GitHub PRs? · golang/go · Discussion #61182" /><meta name="twitter:description" content="In #18517 (accepted Jan. 2017), we decided to start importing GitHub pull requests for the Go repositories as Gerrit changes, in addition to our more typical direct-to-Gerrit workflow. In the time ..." /> <meta property="og:image" content="https://opengraph.githubassets.com/69da7e1b4e75f735cabc4e5ed922ab6eded6a4d69e553f018de41c95961af929/golang/go/discussions/61182" /><meta property="og:image:alt" content="In #18517 (accepted Jan. 2017), we decided to start importing GitHub pull requests for the Go repositories as Gerrit changes, in addition to our more typical direct-to-Gerrit workflow. In the time ..." /><meta property="og:image:width" content="1200" /><meta property="og:image:height" content="600" /><meta property="og:site_name" content="GitHub" /><meta property="og:type" content="object" /><meta property="og:title" content="codereview: should the Go project stop importing GitHub PRs? · golang/go · Discussion #61182" /><meta property="og:url" content="https://github.com/golang/go/discussions/61182" /><meta property="og:description" content="In #18517 (accepted Jan. 2017), we decided to start importing GitHub pull requests for the Go repositories as Gerrit changes, in addition to our more typical direct-to-Gerrit workflow. In the time ..." /> <meta name="hostname" content="github.com"> <meta name="expected-hostname" content="github.com"> <meta http-equiv="x-pjax-version" content="0f265ef8396cd1962dba2eda868f105296f51594cc2ff5b653c6553989093b61" data-turbo-track="reload"> <meta http-equiv="x-pjax-csp-version" content="ace39c3b6632770952207593607e6e0be0db363435a8b877b1f96abe6430f345" data-turbo-track="reload"> <meta http-equiv="x-pjax-css-version" content="1c71206221e00a0a8e77d94d48d954f34ddbd711c4a0ced954fd49cd786cfa61" data-turbo-track="reload"> <meta http-equiv="x-pjax-js-version" content="12a8aded86f558a96e1c8427138fa449b829e611fbd8701cad0d49ba051978b0" data-turbo-track="reload"> <meta name="turbo-cache-control" content="no-preview" data-turbo-transient=""> <meta name="voltron-timing" value="1385"> <meta name="go-import" content="github.com/golang/go git https://github.com/golang/go.git"> <meta name="octolytics-dimension-user_id" content="4314092" /><meta name="octolytics-dimension-user_login" content="golang" /><meta name="octolytics-dimension-repository_id" content="23096959" /><meta name="octolytics-dimension-repository_nwo" content="golang/go" /><meta name="octolytics-dimension-repository_public" content="true" /><meta name="octolytics-dimension-repository_is_fork" content="false" /><meta name="octolytics-dimension-repository_network_root_id" content="23096959" /><meta name="octolytics-dimension-repository_network_root_nwo" content="golang/go" /> <link rel="canonical" href="https://github.com/golang/go/discussions/61182" data-turbo-transient> <meta name="turbo-body-classes" content="logged-out env-production page-responsive"> <meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats"> <meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors"> <link rel="mask-icon" href="https://github.githubassets.com/assets/pinned-octocat-093da3e6fa40.svg" color="#000000"> <link rel="alternate icon" class="js-site-favicon" type="image/png" href="https://github.githubassets.com/favicons/favicon.png"> <link rel="icon" class="js-site-favicon" type="image/svg+xml" href="https://github.githubassets.com/favicons/favicon.svg" data-base-href="https://github.githubassets.com/favicons/favicon"> <meta name="theme-color" content="#1e2327"> <meta name="color-scheme" content="light dark" /> <link rel="manifest" href="/manifest.json" crossOrigin="use-credentials"> </head> <body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div data-turbo-body class="logged-out env-production page-responsive" style="word-wrap: break-word;"> <div class="position-relative header-wrapper js-header-wrapper "> <a href="#start-of-content" data-skip-target-assigned="false" class="px-2 py-4 color-bg-accent-emphasis color-fg-on-emphasis show-on-focus js-skip-to-content">Skip to content</a> <span data-view-component="true" class="progress-pjax-loader Progress position-fixed width-full"> <span style="width: 0%;" data-view-component="true" class="Progress-item progress-pjax-loader-bar left-0 top-0 color-bg-accent-emphasis"></span> </span> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/ui_packages_ui-commands_ui-commands_ts-e571874765ef.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/keyboard-shortcuts-dialog-765cf28766da.js"></script> <link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/primer-react.5a0ffaf77c0db0d0dac2.module.css" /> <react-partial partial-name="keyboard-shortcuts-dialog" data-ssr="false" data-attempted-ssr="false" > <script type="application/json" data-target="react-partial.embeddedData">{"props":{"docsUrl":"https://docs.github.com/get-started/accessibility/keyboard-shortcuts"}}</script> <div data-target="react-partial.reactRoot"></div> </react-partial> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-94fd67-73b675cf164a.js"></script> <script crossorigin="anonymous" defer="defer" type="application/javascript" src="https://github.githubassets.com/assets/sessions-2d195d11c56b.js"></script> <header class="HeaderMktg header-logged-out js-details-container js-header Details f4 py-3" role="banner" data-is-top="true" data-color-mode=light data-light-theme=light data-dark-theme=dark> <h2 class="sr-only">Navigation Menu</h2> <button type="button" class="HeaderMktg-backdrop d-lg-none border-0 position-fixed top-0 left-0 width-full height-full js-details-target" aria-label="Toggle navigation"> <span class="d-none">Toggle navigation</span> </button> <div class="d-flex flex-column flex-lg-row flex-items-center px-3 px-md-4 px-lg-5 height-full position-relative z-1"> <div class="d-flex flex-justify-between flex-items-center width-full width-lg-auto"> <div class="flex-1"> <button aria-label="Toggle navigation" aria-expanded="false" type="button" data-view-component="true" class="js-details-target js-nav-padding-recalculate js-header-menu-toggle Button--link Button--medium Button d-lg-none color-fg-inherit p-1"> <span class="Button-content"> <span class="Button-label"><div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div> <div class="HeaderMenu-toggle-bar rounded my-1"></div></span> </span> </button> </div> <a class="mr-lg-3 color-fg-inherit flex-order-2 js-prevent-focus-on-mobile-nav" href="/" aria-label="Homepage" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Logomark;ref_loc:Header"}"> <svg height="32" aria-hidden="true" viewBox="0 0 24 24" version="1.1" width="32" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <div class="flex-1 flex-order-2 text-right"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fdiscussions%2F61182" class="HeaderMenu-link HeaderMenu-button d-inline-flex d-lg-none flex-order-1 f5 no-underline border color-border-default rounded-2 px-2 py-1 color-fg-inherit js-prevent-focus-on-mobile-nav" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4f8da33b33f0869231c1fa09d48918bbb50952e0a8ce459d2c9ca0b459bc76e0" data-analytics-event="{"category":"Marketing nav","action":"click to Sign in","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> </div> <div class="HeaderMenu js-header-menu height-fit position-lg-relative d-lg-flex flex-column flex-auto top-0"> <div class="HeaderMenu-wrapper d-flex flex-column flex-self-start flex-lg-row flex-auto rounded rounded-lg-0"> <nav class="HeaderMenu-nav" aria-label="Global"> <ul class="d-lg-flex list-style-none"> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Product <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"product","tag":"link","label":"github_copilot_link_product_navbar"}" href="https://github.com/features/copilot"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Write better code with AI </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"security","context":"product","tag":"link","label":"security_link_product_navbar"}" href="https://github.com/features/security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Security</div> Find and fix vulnerabilities </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"actions","context":"product","tag":"link","label":"actions_link_product_navbar"}" href="https://github.com/features/actions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-workflow color-fg-subtle mr-3"> <path d="M1 3a2 2 0 0 1 2-2h6.5a2 2 0 0 1 2 2v6.5a2 2 0 0 1-2 2H7v4.063C7 16.355 7.644 17 8.438 17H12.5v-2.5a2 2 0 0 1 2-2H21a2 2 0 0 1 2 2V21a2 2 0 0 1-2 2h-6.5a2 2 0 0 1-2-2v-2.5H8.437A2.939 2.939 0 0 1 5.5 15.562V11.5H3a2 2 0 0 1-2-2Zm2-.5a.5.5 0 0 0-.5.5v6.5a.5.5 0 0 0 .5.5h6.5a.5.5 0 0 0 .5-.5V3a.5.5 0 0 0-.5-.5ZM14.5 14a.5.5 0 0 0-.5.5V21a.5.5 0 0 0 .5.5H21a.5.5 0 0 0 .5-.5v-6.5a.5.5 0 0 0-.5-.5Z"></path> </svg> <div> <div class="color-fg-default h4">Actions</div> Automate any workflow </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"codespaces","context":"product","tag":"link","label":"codespaces_link_product_navbar"}" href="https://github.com/features/codespaces"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-codespaces color-fg-subtle mr-3"> <path d="M3.5 3.75C3.5 2.784 4.284 2 5.25 2h13.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 18.75 13H5.25a1.75 1.75 0 0 1-1.75-1.75Zm-2 12c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v4a1.75 1.75 0 0 1-1.75 1.75H3.25a1.75 1.75 0 0 1-1.75-1.75ZM5.25 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h13.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Zm-2 12a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h17.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25Z"></path><path d="M10 17.75a.75.75 0 0 1 .75-.75h6.5a.75.75 0 0 1 0 1.5h-6.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> <div> <div class="color-fg-default h4">Codespaces</div> Instant dev environments </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"issues","context":"product","tag":"link","label":"issues_link_product_navbar"}" href="https://github.com/features/issues"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-issue-opened color-fg-subtle mr-3"> <path d="M12 1c6.075 0 11 4.925 11 11s-4.925 11-11 11S1 18.075 1 12 5.925 1 12 1ZM2.5 12a9.5 9.5 0 0 0 9.5 9.5 9.5 9.5 0 0 0 9.5-9.5A9.5 9.5 0 0 0 12 2.5 9.5 9.5 0 0 0 2.5 12Zm9.5 2a2 2 0 1 1-.001-3.999A2 2 0 0 1 12 14Z"></path> </svg> <div> <div class="color-fg-default h4">Issues</div> Plan and track work </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"code_review","context":"product","tag":"link","label":"code_review_link_product_navbar"}" href="https://github.com/features/code-review"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-review color-fg-subtle mr-3"> <path d="M10.3 6.74a.75.75 0 0 1-.04 1.06l-2.908 2.7 2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M1.5 4.25c0-.966.784-1.75 1.75-1.75h17.5c.966 0 1.75.784 1.75 1.75v12.5a1.75 1.75 0 0 1-1.75 1.75h-9.69l-3.573 3.573A1.458 1.458 0 0 1 5 21.043V18.5H3.25a1.75 1.75 0 0 1-1.75-1.75ZM3.25 4a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h2.5a.75.75 0 0 1 .75.75v3.19l3.72-3.72a.749.749 0 0 1 .53-.22h10a.25.25 0 0 0 .25-.25V4.25a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Review</div> Manage code changes </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"discussions","context":"product","tag":"link","label":"discussions_link_product_navbar"}" href="https://github.com/features/discussions"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Discussions</div> Collaborate outside of code </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"code_search","context":"product","tag":"link","label":"code_search_link_product_navbar"}" href="https://github.com/features/code-search"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-code-square color-fg-subtle mr-3"> <path d="M10.3 8.24a.75.75 0 0 1-.04 1.06L7.352 12l2.908 2.7a.75.75 0 1 1-1.02 1.1l-3.5-3.25a.75.75 0 0 1 0-1.1l3.5-3.25a.75.75 0 0 1 1.06.04Zm3.44 1.06a.75.75 0 1 1 1.02-1.1l3.5 3.25a.75.75 0 0 1 0 1.1l-3.5 3.25a.75.75 0 1 1-1.02-1.1l2.908-2.7-2.908-2.7Z"></path><path d="M2 3.75C2 2.784 2.784 2 3.75 2h16.5c.966 0 1.75.784 1.75 1.75v16.5A1.75 1.75 0 0 1 20.25 22H3.75A1.75 1.75 0 0 1 2 20.25Zm1.75-.25a.25.25 0 0 0-.25.25v16.5c0 .138.112.25.25.25h16.5a.25.25 0 0 0 .25-.25V3.75a.25.25 0 0 0-.25-.25Z"></path> </svg> <div> <div class="color-fg-default h4">Code Search</div> Find more, search less </div> </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="product-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="product-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"all_features","context":"product","tag":"link","label":"all_features_link_product_navbar"}" href="https://github.com/features"> All features </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"documentation","context":"product","tag":"link","label":"documentation_link_product_navbar"}" href="https://docs.github.com"> Documentation <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"github_skills","context":"product","tag":"link","label":"github_skills_link_product_navbar"}" href="https://skills.github.com"> GitHub Skills <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"blog","context":"product","tag":"link","label":"blog_link_product_navbar"}" href="https://github.blog"> Blog <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Solutions <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 pb-lg-3 mb-3 mb-lg-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-company-size-heading">By company size</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-company-size-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"enterprises","context":"solutions","tag":"link","label":"enterprises_link_solutions_navbar"}" href="https://github.com/enterprise"> Enterprises </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"small_and_medium_teams","context":"solutions","tag":"link","label":"small_and_medium_teams_link_solutions_navbar"}" href="https://github.com/team"> Small and medium teams </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"startups","context":"solutions","tag":"link","label":"startups_link_solutions_navbar"}" href="https://github.com/enterprise/startups"> Startups </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"nonprofits","context":"solutions","tag":"link","label":"nonprofits_link_solutions_navbar"}" href="/solutions/industry/nonprofits"> Nonprofits </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-use-case-heading">By use case</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-use-case-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devsecops","context":"solutions","tag":"link","label":"devsecops_link_solutions_navbar"}" href="/solutions/use-case/devsecops"> DevSecOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"solutions","tag":"link","label":"devops_link_solutions_navbar"}" href="/solutions/use-case/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ci_cd","context":"solutions","tag":"link","label":"ci_cd_link_solutions_navbar"}" href="/solutions/use-case/ci-cd"> CI/CD </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_use_cases","context":"solutions","tag":"link","label":"view_all_use_cases_link_solutions_navbar"}" href="/solutions/use-case"> View all use cases </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="solutions-by-industry-heading">By industry</span> <ul class="list-style-none f5" aria-labelledby="solutions-by-industry-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"healthcare","context":"solutions","tag":"link","label":"healthcare_link_solutions_navbar"}" href="/solutions/industry/healthcare"> Healthcare </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"financial_services","context":"solutions","tag":"link","label":"financial_services_link_solutions_navbar"}" href="/solutions/industry/financial-services"> Financial services </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"manufacturing","context":"solutions","tag":"link","label":"manufacturing_link_solutions_navbar"}" href="/solutions/industry/manufacturing"> Manufacturing </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"government","context":"solutions","tag":"link","label":"government_link_solutions_navbar"}" href="/solutions/industry/government"> Government </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all_industries","context":"solutions","tag":"link","label":"view_all_industries_link_solutions_navbar"}" href="/solutions/industry"> View all industries </a></li> </ul> </div> </div> <div class="HeaderMenu-trailing-link rounded-bottom-2 flex-shrink-0 mt-lg-4 px-lg-4 py-4 py-lg-3 f5 text-semibold"> <a href="/solutions"> View all solutions <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-right HeaderMenu-trailing-link-icon"> <path d="M6.22 3.22a.75.75 0 0 1 1.06 0l4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L9.94 8 6.22 4.28a.75.75 0 0 1 0-1.06Z"></path> </svg> </a> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Resources <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 d-lg-flex flex-wrap dropdown-menu-wide"> <div class="HeaderMenu-column px-lg-4 border-lg-right mb-4 mb-lg-0 pr-lg-7"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-topics-heading">Topics</span> <ul class="list-style-none f5" aria-labelledby="resources-topics-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"ai","context":"resources","tag":"link","label":"ai_link_resources_navbar"}" href="/resources/articles/ai"> AI </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"devops","context":"resources","tag":"link","label":"devops_link_resources_navbar"}" href="/resources/articles/devops"> DevOps </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"security","context":"resources","tag":"link","label":"security_link_resources_navbar"}" href="/resources/articles/security"> Security </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"software_development","context":"resources","tag":"link","label":"software_development_link_resources_navbar"}" href="/resources/articles/software-development"> Software Development </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"view_all","context":"resources","tag":"link","label":"view_all_link_resources_navbar"}" href="/resources/articles"> View all </a></li> </ul> </div> </div> <div class="HeaderMenu-column px-lg-4"> <div class="border-bottom pb-3 pb-lg-0 border-lg-bottom-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="resources-explore-heading">Explore</span> <ul class="list-style-none f5" aria-labelledby="resources-explore-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"learning_pathways","context":"resources","tag":"link","label":"learning_pathways_link_resources_navbar"}" href="https://resources.github.com/learn/pathways"> Learning Pathways <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"white_papers_ebooks_webinars","context":"resources","tag":"link","label":"white_papers_ebooks_webinars_link_resources_navbar"}" href="https://resources.github.com"> White papers, Ebooks, Webinars <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"customer_stories","context":"resources","tag":"link","label":"customer_stories_link_resources_navbar"}" href="https://github.com/customer-stories"> Customer Stories </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary Link--external" target="_blank" data-analytics-event="{"location":"navbar","action":"partners","context":"resources","tag":"link","label":"partners_link_resources_navbar"}" href="https://partner.github.com"> Partners <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link-external HeaderMenu-external-icon color-fg-subtle"> <path d="M3.75 2h3.5a.75.75 0 0 1 0 1.5h-3.5a.25.25 0 0 0-.25.25v8.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-3.5a.75.75 0 0 1 1.5 0v3.5A1.75 1.75 0 0 1 12.25 14h-8.5A1.75 1.75 0 0 1 2 12.25v-8.5C2 2.784 2.784 2 3.75 2Zm6.854-1h4.146a.25.25 0 0 1 .25.25v4.146a.25.25 0 0 1-.427.177L13.03 4.03 9.28 7.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.75-3.75-1.543-1.543A.25.25 0 0 1 10.604 1Z"></path> </svg> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"executive_insights","context":"resources","tag":"link","label":"executive_insights_link_resources_navbar"}" href="https://github.com/solutions/executive-insights"> Executive Insights </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Open Source <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"github_sponsors","context":"open_source","tag":"link","label":"github_sponsors_link_open_source_navbar"}" href="/sponsors"> <div> <div class="color-fg-default h4">GitHub Sponsors</div> Fund open source developers </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"the_readme_project","context":"open_source","tag":"link","label":"the_readme_project_link_open_source_navbar"}" href="https://github.com/readme"> <div> <div class="color-fg-default h4">The ReadME Project</div> GitHub community articles </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="open-source-repositories-heading">Repositories</span> <ul class="list-style-none f5" aria-labelledby="open-source-repositories-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"topics","context":"open_source","tag":"link","label":"topics_link_open_source_navbar"}" href="https://github.com/topics"> Topics </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"trending","context":"open_source","tag":"link","label":"trending_link_open_source_navbar"}" href="https://github.com/trending"> Trending </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary" data-analytics-event="{"location":"navbar","action":"collections","context":"open_source","tag":"link","label":"collections_link_open_source_navbar"}" href="https://github.com/collections"> Collections </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <button type="button" class="HeaderMenu-link border-0 width-full width-lg-auto px-0 px-lg-2 py-lg-2 no-wrap d-flex flex-items-center flex-justify-between js-details-target" aria-expanded="false"> Enterprise <svg opacity="0.5" aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-chevron-down HeaderMenu-icon ml-1"> <path d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"></path> </svg> </button> <div class="HeaderMenu-dropdown dropdown-menu rounded m-0 p-0 pt-2 pt-lg-4 position-relative position-lg-absolute left-0 left-lg-n3 pb-2 pb-lg-4 px-lg-4"> <div class="HeaderMenu-column"> <div class="border-bottom pb-3 pb-lg-0 pb-lg-3 mb-3 mb-lg-0 mb-lg-3"> <ul class="list-style-none f5" > <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"enterprise_platform","context":"enterprise","tag":"link","label":"enterprise_platform_link_enterprise_navbar"}" href="/enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-stack color-fg-subtle mr-3"> <path d="M11.063 1.456a1.749 1.749 0 0 1 1.874 0l8.383 5.316a1.751 1.751 0 0 1 0 2.956l-8.383 5.316a1.749 1.749 0 0 1-1.874 0L2.68 9.728a1.751 1.751 0 0 1 0-2.956Zm1.071 1.267a.25.25 0 0 0-.268 0L3.483 8.039a.25.25 0 0 0 0 .422l8.383 5.316a.25.25 0 0 0 .268 0l8.383-5.316a.25.25 0 0 0 0-.422Z"></path><path d="M1.867 12.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path><path d="M1.867 16.324a.75.75 0 0 1 1.035-.232l8.964 5.685a.25.25 0 0 0 .268 0l8.964-5.685a.75.75 0 0 1 .804 1.267l-8.965 5.685a1.749 1.749 0 0 1-1.874 0l-8.965-5.685a.75.75 0 0 1-.231-1.035Z"></path> </svg> <div> <div class="color-fg-default h4">Enterprise platform</div> AI-powered developer platform </div> </a></li> </ul> </div> <div class="border-bottom pb-3 pb-lg-0 border-bottom-0"> <span class="d-block h4 color-fg-default my-1" id="enterprise-available-add-ons-heading">Available add-ons</span> <ul class="list-style-none f5" aria-labelledby="enterprise-available-add-ons-heading"> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"advanced_security","context":"enterprise","tag":"link","label":"advanced_security_link_enterprise_navbar"}" href="https://github.com/enterprise/advanced-security"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-shield-check color-fg-subtle mr-3"> <path d="M16.53 9.78a.75.75 0 0 0-1.06-1.06L11 13.19l-1.97-1.97a.75.75 0 0 0-1.06 1.06l2.5 2.5a.75.75 0 0 0 1.06 0l5-5Z"></path><path d="m12.54.637 8.25 2.675A1.75 1.75 0 0 1 22 4.976V10c0 6.19-3.771 10.704-9.401 12.83a1.704 1.704 0 0 1-1.198 0C5.77 20.705 2 16.19 2 10V4.976c0-.758.489-1.43 1.21-1.664L11.46.637a1.748 1.748 0 0 1 1.08 0Zm-.617 1.426-8.25 2.676a.249.249 0 0 0-.173.237V10c0 5.46 3.28 9.483 8.43 11.426a.199.199 0 0 0 .14 0C17.22 19.483 20.5 15.461 20.5 10V4.976a.25.25 0 0 0-.173-.237l-8.25-2.676a.253.253 0 0 0-.154 0Z"></path> </svg> <div> <div class="color-fg-default h4">Advanced Security</div> Enterprise-grade security features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description pb-lg-3" data-analytics-event="{"location":"navbar","action":"github_copilot","context":"enterprise","tag":"link","label":"github_copilot_link_enterprise_navbar"}" href="/features/copilot#enterprise"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-copilot color-fg-subtle mr-3"> <path d="M23.922 16.992c-.861 1.495-5.859 5.023-11.922 5.023-6.063 0-11.061-3.528-11.922-5.023A.641.641 0 0 1 0 16.736v-2.869a.841.841 0 0 1 .053-.22c.372-.935 1.347-2.292 2.605-2.656.167-.429.414-1.055.644-1.517a10.195 10.195 0 0 1-.052-1.086c0-1.331.282-2.499 1.132-3.368.397-.406.89-.717 1.474-.952 1.399-1.136 3.392-2.093 6.122-2.093 2.731 0 4.767.957 6.166 2.093.584.235 1.077.546 1.474.952.85.869 1.132 2.037 1.132 3.368 0 .368-.014.733-.052 1.086.23.462.477 1.088.644 1.517 1.258.364 2.233 1.721 2.605 2.656a.832.832 0 0 1 .053.22v2.869a.641.641 0 0 1-.078.256ZM12.172 11h-.344a4.323 4.323 0 0 1-.355.508C10.703 12.455 9.555 13 7.965 13c-1.725 0-2.989-.359-3.782-1.259a2.005 2.005 0 0 1-.085-.104L4 11.741v6.585c1.435.779 4.514 2.179 8 2.179 3.486 0 6.565-1.4 8-2.179v-6.585l-.098-.104s-.033.045-.085.104c-.793.9-2.057 1.259-3.782 1.259-1.59 0-2.738-.545-3.508-1.492a4.323 4.323 0 0 1-.355-.508h-.016.016Zm.641-2.935c.136 1.057.403 1.913.878 2.497.442.544 1.134.938 2.344.938 1.573 0 2.292-.337 2.657-.751.384-.435.558-1.15.558-2.361 0-1.14-.243-1.847-.705-2.319-.477-.488-1.319-.862-2.824-1.025-1.487-.161-2.192.138-2.533.529-.269.307-.437.808-.438 1.578v.021c0 .265.021.562.063.893Zm-1.626 0c.042-.331.063-.628.063-.894v-.02c-.001-.77-.169-1.271-.438-1.578-.341-.391-1.046-.69-2.533-.529-1.505.163-2.347.537-2.824 1.025-.462.472-.705 1.179-.705 2.319 0 1.211.175 1.926.558 2.361.365.414 1.084.751 2.657.751 1.21 0 1.902-.394 2.344-.938.475-.584.742-1.44.878-2.497Z"></path><path d="M14.5 14.25a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Zm-5 0a1 1 0 0 1 1 1v2a1 1 0 0 1-2 0v-2a1 1 0 0 1 1-1Z"></path> </svg> <div> <div class="color-fg-default h4">GitHub Copilot</div> Enterprise-grade AI features </div> </a></li> <li> <a class="HeaderMenu-dropdown-link d-block no-underline position-relative py-2 Link--secondary d-flex flex-items-center Link--has-description" data-analytics-event="{"location":"navbar","action":"premium_support","context":"enterprise","tag":"link","label":"premium_support_link_enterprise_navbar"}" href="/premium-support"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-comment-discussion color-fg-subtle mr-3"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 14.25 14H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 15.543V14H1.75A1.75 1.75 0 0 1 0 12.25v-9.5C0 1.784.784 1 1.75 1ZM1.5 2.75v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Z"></path><path d="M22.5 8.75a.25.25 0 0 0-.25-.25h-3.5a.75.75 0 0 1 0-1.5h3.5c.966 0 1.75.784 1.75 1.75v9.5A1.75 1.75 0 0 1 22.25 20H21v1.543a1.457 1.457 0 0 1-2.487 1.03L15.939 20H10.75A1.75 1.75 0 0 1 9 18.25v-1.465a.75.75 0 0 1 1.5 0v1.465c0 .138.112.25.25.25h5.5a.75.75 0 0 1 .53.22l2.72 2.72v-2.19a.75.75 0 0 1 .75-.75h2a.25.25 0 0 0 .25-.25v-9.5Z"></path> </svg> <div> <div class="color-fg-default h4">Premium Support</div> Enterprise-grade 24/7 support </div> </a></li> </ul> </div> </div> </div> </li> <li class="HeaderMenu-item position-relative flex-wrap flex-justify-between flex-items-center d-block d-lg-flex flex-lg-nowrap flex-lg-items-center js-details-container js-header-menu-item"> <a class="HeaderMenu-link no-underline px-0 px-lg-2 py-3 py-lg-2 d-block d-lg-inline-block" data-analytics-event="{"location":"navbar","action":"pricing","context":"global","tag":"link","label":"pricing_link_global_navbar"}" href="https://github.com/pricing">Pricing</a> </li> </ul> </nav> <div class="d-flex flex-column flex-lg-row width-full flex-justify-end flex-lg-items-center text-center mt-3 mt-lg-0 text-lg-left ml-lg-3"> <qbsearch-input class="search-input" data-scope="repo:golang/go" data-custom-scopes-path="/search/custom_scopes" data-delete-custom-scopes-csrf="_6W0UkVyL_blkaWYViBVMwvSQ8oEa8lZXKwyIllJkLSpHfDMIIbf9Hac7aBW4joz-63110y5LKQDv0kAe3MOsA" data-max-custom-scopes="10" data-header-redesign-enabled="false" data-initial-value="" data-blackbird-suggestions-path="/search/suggestions" data-jump-to-suggestions-path="/_graphql/GetSuggestedNavigationDestinations" data-current-repository="golang/go" data-current-org="golang" data-current-owner="" data-logged-in="false" data-copilot-chat-enabled="false" data-nl-search-enabled="false" data-retain-scroll-position="true"> <div class="search-input-container search-with-dialog position-relative d-flex flex-row flex-items-center mr-4 rounded" data-action="click:qbsearch-input#searchInputContainerClicked" > <button type="button" class="header-search-button placeholder input-button form-control d-flex flex-1 flex-self-stretch flex-items-center no-wrap width-full py-0 pl-2 pr-0 text-left border-0 box-shadow-none" data-target="qbsearch-input.inputButton" aria-label="Search or jump to…" aria-haspopup="dialog" placeholder="Search or jump to..." data-hotkey=s,/ autocapitalize="off" data-analytics-event="{"location":"navbar","action":"searchbar","context":"global","tag":"input","label":"searchbar_input_global_navbar"}" data-action="click:qbsearch-input#handleExpand" > <div class="mr-2 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </div> <span class="flex-1" data-target="qbsearch-input.inputButtonText">Search or jump to...</span> <div class="d-flex" data-target="qbsearch-input.hotkeyIndicator"> <svg xmlns="http://www.w3.org/2000/svg" width="22" height="20" aria-hidden="true" class="mr-1"><path fill="none" stroke="#979A9C" opacity=".4" d="M3.5.5h12c1.7 0 3 1.3 3 3v13c0 1.7-1.3 3-3 3h-12c-1.7 0-3-1.3-3-3v-13c0-1.7 1.3-3 3-3z"></path><path fill="#979A9C" d="M11.8 6L8 15.1h-.9L10.8 6h1z"></path></svg> </div> </button> <input type="hidden" name="type" class="js-site-search-type-field"> <div class="Overlay--hidden " data-modal-dialog-overlay> <modal-dialog data-action="close:qbsearch-input#handleClose cancel:qbsearch-input#handleClose" data-target="qbsearch-input.searchSuggestionsDialog" role="dialog" id="search-suggestions-dialog" aria-modal="true" aria-labelledby="search-suggestions-dialog-header" data-view-component="true" class="Overlay Overlay--width-large Overlay--height-auto"> <h1 id="search-suggestions-dialog-header" class="sr-only">Search code, repositories, users, issues, pull requests...</h1> <div class="Overlay-body Overlay-body--paddingNone"> <div data-view-component="true"> <div class="search-suggestions position-fixed width-full color-shadow-large border color-fg-default color-bg-default overflow-hidden d-flex flex-column query-builder-container" style="border-radius: 12px;" data-target="qbsearch-input.queryBuilderContainer" hidden > </option></form><form id="query-builder-test-form" action="" accept-charset="UTF-8" method="get"> <query-builder data-target="qbsearch-input.queryBuilder" id="query-builder-query-builder-test" data-filter-key=":" data-view-component="true" class="QueryBuilder search-query-builder"> <div class="FormControl FormControl--fullWidth"> <label id="query-builder-test-label" for="query-builder-test" class="FormControl-label sr-only"> Search </label> <div class="QueryBuilder-StyledInput width-fit " data-target="query-builder.styledInput" > <span id="query-builder-test-leadingvisual-wrap" class="FormControl-input-leadingVisualWrap QueryBuilder-leadingVisualWrap"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search FormControl-input-leadingVisual"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </span> <div data-target="query-builder.styledInputContainer" class="QueryBuilder-StyledInputContainer"> <div aria-hidden="true" class="QueryBuilder-StyledInputContent" data-target="query-builder.styledInputContent" ></div> <div class="QueryBuilder-InputWrapper"> <div aria-hidden="true" class="QueryBuilder-Sizer" data-target="query-builder.sizer"></div> <input id="query-builder-test" name="query-builder-test" value="" autocomplete="off" type="text" role="combobox" spellcheck="false" aria-expanded="false" aria-describedby="validation-7fa89931-0697-49dc-a0e1-b32996a8ce97" data-target="query-builder.input" data-action=" input:query-builder#inputChange blur:query-builder#inputBlur keydown:query-builder#inputKeydown focus:query-builder#inputFocus " data-view-component="true" class="FormControl-input QueryBuilder-Input FormControl-medium" /> </div> </div> <span class="sr-only" id="query-builder-test-clear">Clear</span> <button role="button" id="query-builder-test-clear-button" aria-labelledby="query-builder-test-clear query-builder-test-label" data-target="query-builder.clearButton" data-action=" click:query-builder#clear focus:query-builder#clearButtonFocus blur:query-builder#clearButtonBlur " variant="small" hidden="hidden" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium mr-1 px-2 py-0 d-flex flex-items-center rounded-1 color-fg-muted"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x-circle-fill Button-visual"> <path d="M2.343 13.657A8 8 0 1 1 13.658 2.343 8 8 0 0 1 2.343 13.657ZM6.03 4.97a.751.751 0 0 0-1.042.018.751.751 0 0 0-.018 1.042L6.94 8 4.97 9.97a.749.749 0 0 0 .326 1.275.749.749 0 0 0 .734-.215L8 9.06l1.97 1.97a.749.749 0 0 0 1.275-.326.749.749 0 0 0-.215-.734L9.06 8l1.97-1.97a.749.749 0 0 0-.326-1.275.749.749 0 0 0-.734.215L8 6.94Z"></path> </svg> </button> </div> <template id="search-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search"> <path d="M10.68 11.74a6 6 0 0 1-7.922-8.982 6 6 0 0 1 8.982 7.922l3.04 3.04a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215ZM11.5 7a4.499 4.499 0 1 0-8.997 0A4.499 4.499 0 0 0 11.5 7Z"></path> </svg> </template> <template id="code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="file-code-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-file-code"> <path d="M4 1.75C4 .784 4.784 0 5.75 0h5.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v8.586A1.75 1.75 0 0 1 14.25 15h-9a.75.75 0 0 1 0-1.5h9a.25.25 0 0 0 .25-.25V6h-2.75A1.75 1.75 0 0 1 10 4.25V1.5H5.75a.25.25 0 0 0-.25.25v2.5a.75.75 0 0 1-1.5 0Zm1.72 4.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l1.47-1.47-1.47-1.47a.75.75 0 0 1 0-1.06ZM3.28 7.78 1.81 9.25l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Zm8.22-6.218V4.25c0 .138.112.25.25.25h2.688l-.011-.013-2.914-2.914-.013-.011Z"></path> </svg> </template> <template id="history-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-history"> <path d="m.427 1.927 1.215 1.215a8.002 8.002 0 1 1-1.6 5.685.75.75 0 1 1 1.493-.154 6.5 6.5 0 1 0 1.18-4.458l1.358 1.358A.25.25 0 0 1 3.896 6H.25A.25.25 0 0 1 0 5.75V2.104a.25.25 0 0 1 .427-.177ZM7.75 4a.75.75 0 0 1 .75.75v2.992l2.028.812a.75.75 0 0 1-.557 1.392l-2.5-1A.751.751 0 0 1 7 8.25v-3.5A.75.75 0 0 1 7.75 4Z"></path> </svg> </template> <template id="repo-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> </template> <template id="bookmark-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bookmark"> <path d="M3 2.75C3 1.784 3.784 1 4.75 1h6.5c.966 0 1.75.784 1.75 1.75v11.5a.75.75 0 0 1-1.227.579L8 11.722l-3.773 3.107A.751.751 0 0 1 3 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v9.91l3.023-2.489a.75.75 0 0 1 .954 0l3.023 2.49V2.75a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="plus-circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-plus-circle"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm7.25-3.25v2.5h2.5a.75.75 0 0 1 0 1.5h-2.5v2.5a.75.75 0 0 1-1.5 0v-2.5h-2.5a.75.75 0 0 1 0-1.5h2.5v-2.5a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="circle-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-dot-fill"> <path d="M8 4a4 4 0 1 1 0 8 4 4 0 0 1 0-8Z"></path> </svg> </template> <template id="trash-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-trash"> <path d="M11 1.75V3h2.25a.75.75 0 0 1 0 1.5H2.75a.75.75 0 0 1 0-1.5H5V1.75C5 .784 5.784 0 6.75 0h2.5C10.216 0 11 .784 11 1.75ZM4.496 6.675l.66 6.6a.25.25 0 0 0 .249.225h5.19a.25.25 0 0 0 .249-.225l.66-6.6a.75.75 0 0 1 1.492.149l-.66 6.6A1.748 1.748 0 0 1 10.595 15h-5.19a1.75 1.75 0 0 1-1.741-1.575l-.66-6.6a.75.75 0 1 1 1.492-.15ZM6.5 1.75V3h3V1.75a.25.25 0 0 0-.25-.25h-2.5a.25.25 0 0 0-.25.25Z"></path> </svg> </template> <template id="team-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-people"> <path d="M2 5.5a3.5 3.5 0 1 1 5.898 2.549 5.508 5.508 0 0 1 3.034 4.084.75.75 0 1 1-1.482.235 4 4 0 0 0-7.9 0 .75.75 0 0 1-1.482-.236A5.507 5.507 0 0 1 3.102 8.05 3.493 3.493 0 0 1 2 5.5ZM11 4a3.001 3.001 0 0 1 2.22 5.018 5.01 5.01 0 0 1 2.56 3.012.749.749 0 0 1-.885.954.752.752 0 0 1-.549-.514 3.507 3.507 0 0 0-2.522-2.372.75.75 0 0 1-.574-.73v-.352a.75.75 0 0 1 .416-.672A1.5 1.5 0 0 0 11 5.5.75.75 0 0 1 11 4Zm-5.5-.5a2 2 0 1 0-.001 3.999A2 2 0 0 0 5.5 3.5Z"></path> </svg> </template> <template id="project-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-project"> <path d="M1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0ZM1.5 1.75v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25ZM11.75 3a.75.75 0 0 1 .75.75v7.5a.75.75 0 0 1-1.5 0v-7.5a.75.75 0 0 1 .75-.75Zm-8.25.75a.75.75 0 0 1 1.5 0v5.5a.75.75 0 0 1-1.5 0ZM8 3a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0v-3.5A.75.75 0 0 1 8 3Z"></path> </svg> </template> <template id="pencil-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-pencil"> <path d="M11.013 1.427a1.75 1.75 0 0 1 2.474 0l1.086 1.086a1.75 1.75 0 0 1 0 2.474l-8.61 8.61c-.21.21-.47.364-.756.445l-3.251.93a.75.75 0 0 1-.927-.928l.929-3.25c.081-.286.235-.547.445-.758l8.61-8.61Zm.176 4.823L9.75 4.81l-6.286 6.287a.253.253 0 0 0-.064.108l-.558 1.953 1.953-.558a.253.253 0 0 0 .108-.064Zm1.238-3.763a.25.25 0 0 0-.354 0L10.811 3.75l1.439 1.44 1.263-1.263a.25.25 0 0 0 0-.354Z"></path> </svg> </template> <template id="copilot-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot"> <path d="M7.998 15.035c-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.201-.508-.254-1.084-.254-1.656 0-.87.128-1.769.693-2.484.579-.733 1.494-1.124 2.724-1.261 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095v1.872c0 .766-3.351 3.795-8.002 3.795Zm0-1.485c2.28 0 4.584-1.11 5.002-1.433V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-1.146 0-2.059-.327-2.71-.991A3.222 3.222 0 0 1 8 6.303a3.24 3.24 0 0 1-.544.743c-.65.664-1.563.991-2.71.991-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433ZM6.762 2.83c-.193-.206-.637-.413-1.682-.297-1.019.113-1.479.404-1.713.7-.247.312-.369.789-.369 1.554 0 .793.129 1.171.308 1.371.162.181.519.379 1.442.379.853 0 1.339-.235 1.638-.54.315-.322.527-.827.617-1.553.117-.935-.037-1.395-.241-1.614Zm4.155-.297c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Z"></path><path d="M6.25 9.037a.75.75 0 0 1 .75.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 .75-.75Zm4.25.75v1.501a.75.75 0 0 1-1.5 0V9.787a.75.75 0 0 1 1.5 0Z"></path> </svg> </template> <template id="copilot-error-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copilot-error"> <path d="M16 11.24c0 .112-.072.274-.21.467L13 9.688V7.862l-.023-.116c-.49.21-1.075.291-1.727.291-.198 0-.388-.009-.571-.029L6.833 5.226a4.01 4.01 0 0 0 .17-.782c.117-.935-.037-1.395-.241-1.614-.193-.206-.637-.413-1.682-.297-.683.076-1.115.231-1.395.415l-1.257-.91c.579-.564 1.413-.877 2.485-.996 1.206-.134 2.262.034 2.944.765.05.053.096.108.139.165.044-.057.094-.112.143-.165.682-.731 1.738-.899 2.944-.765 1.23.137 2.145.528 2.724 1.261.566.715.693 1.614.693 2.484 0 .572-.053 1.148-.254 1.656.066.228.098.429.126.612.012.076.024.148.037.218.924.385 1.522 1.471 1.591 2.095Zm-5.083-8.707c-1.044-.116-1.488.091-1.681.297-.204.219-.359.679-.242 1.614.091.726.303 1.231.618 1.553.299.305.784.54 1.638.54.922 0 1.28-.198 1.442-.379.179-.2.308-.578.308-1.371 0-.765-.123-1.242-.37-1.554-.233-.296-.693-.587-1.713-.7Zm2.511 11.074c-1.393.776-3.272 1.428-5.43 1.428-4.562 0-7.873-2.914-7.998-3.749V9.338c.085-.628.677-1.686 1.588-2.065.013-.07.024-.143.036-.218.029-.183.06-.384.126-.612-.18-.455-.241-.963-.252-1.475L.31 4.107A.747.747 0 0 1 0 3.509V3.49a.748.748 0 0 1 .625-.73c.156-.026.306.047.435.139l14.667 10.578a.592.592 0 0 1 .227.264.752.752 0 0 1 .046.249v.022a.75.75 0 0 1-1.19.596Zm-1.367-.991L5.635 7.964a5.128 5.128 0 0 1-.889.073c-.652 0-1.236-.081-1.727-.291l-.023.116v4.255c.419.323 2.722 1.433 5.002 1.433 1.539 0 3.089-.505 4.063-.934Z"></path> </svg> </template> <template id="workflow-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-workflow"> <path d="M0 1.75C0 .784.784 0 1.75 0h3.5C6.216 0 7 .784 7 1.75v3.5A1.75 1.75 0 0 1 5.25 7H4v4a1 1 0 0 0 1 1h4v-1.25C9 9.784 9.784 9 10.75 9h3.5c.966 0 1.75.784 1.75 1.75v3.5A1.75 1.75 0 0 1 14.25 16h-3.5A1.75 1.75 0 0 1 9 14.25v-.75H5A2.5 2.5 0 0 1 2.5 11V7h-.75A1.75 1.75 0 0 1 0 5.25Zm1.75-.25a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Zm9 9a.25.25 0 0 0-.25.25v3.5c0 .138.112.25.25.25h3.5a.25.25 0 0 0 .25-.25v-3.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="book-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> </template> <template id="code-review-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-review"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 13H8.061l-2.574 2.573A1.458 1.458 0 0 1 3 14.543V13H1.75A1.75 1.75 0 0 1 0 11.25v-8.5C0 1.784.784 1 1.75 1ZM1.5 2.75v8.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-8.5a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm5.28 1.72a.75.75 0 0 1 0 1.06L5.31 7l1.47 1.47a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018l-2-2a.75.75 0 0 1 0-1.06l2-2a.75.75 0 0 1 1.06 0Zm2.44 0a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L10.69 7 9.22 5.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </template> <template id="codespaces-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-codespaces"> <path d="M0 11.25c0-.966.784-1.75 1.75-1.75h12.5c.966 0 1.75.784 1.75 1.75v3A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm2-9.5C2 .784 2.784 0 3.75 0h8.5C13.216 0 14 .784 14 1.75v5a1.75 1.75 0 0 1-1.75 1.75h-8.5A1.75 1.75 0 0 1 2 6.75Zm1.75-.25a.25.25 0 0 0-.25.25v5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25v-5a.25.25 0 0 0-.25-.25Zm-2 9.5a.25.25 0 0 0-.25.25v3c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-3a.25.25 0 0 0-.25-.25Z"></path><path d="M7 12.75a.75.75 0 0 1 .75-.75h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1-.75-.75Zm-4 0a.75.75 0 0 1 .75-.75h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1-.75-.75Z"></path> </svg> </template> <template id="comment-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment"> <path d="M1 2.75C1 1.784 1.784 1 2.75 1h10.5c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 13.25 12H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 13.543V12H2.75A1.75 1.75 0 0 1 1 10.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> </template> <template id="comment-discussion-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </template> <template id="organization-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-organization"> <path d="M1.75 16A1.75 1.75 0 0 1 0 14.25V1.75C0 .784.784 0 1.75 0h8.5C11.216 0 12 .784 12 1.75v12.5c0 .085-.006.168-.018.25h2.268a.25.25 0 0 0 .25-.25V8.285a.25.25 0 0 0-.111-.208l-1.055-.703a.749.749 0 1 1 .832-1.248l1.055.703c.487.325.779.871.779 1.456v5.965A1.75 1.75 0 0 1 14.25 16h-3.5a.766.766 0 0 1-.197-.026c-.099.017-.2.026-.303.026h-3a.75.75 0 0 1-.75-.75V14h-1v1.25a.75.75 0 0 1-.75.75Zm-.25-1.75c0 .138.112.25.25.25H4v-1.25a.75.75 0 0 1 .75-.75h2.5a.75.75 0 0 1 .75.75v1.25h2.25a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM3.75 6h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 3.75A.75.75 0 0 1 3.75 3h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 3.75Zm4 3A.75.75 0 0 1 7.75 6h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 7 6.75ZM7.75 3h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5ZM3 9.75A.75.75 0 0 1 3.75 9h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 9.75ZM7.75 9h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="rocket-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-rocket"> <path d="M14.064 0h.186C15.216 0 16 .784 16 1.75v.186a8.752 8.752 0 0 1-2.564 6.186l-.458.459c-.314.314-.641.616-.979.904v3.207c0 .608-.315 1.172-.833 1.49l-2.774 1.707a.749.749 0 0 1-1.11-.418l-.954-3.102a1.214 1.214 0 0 1-.145-.125L3.754 9.816a1.218 1.218 0 0 1-.124-.145L.528 8.717a.749.749 0 0 1-.418-1.11l1.71-2.774A1.748 1.748 0 0 1 3.31 4h3.204c.288-.338.59-.665.904-.979l.459-.458A8.749 8.749 0 0 1 14.064 0ZM8.938 3.623h-.002l-.458.458c-.76.76-1.437 1.598-2.02 2.5l-1.5 2.317 2.143 2.143 2.317-1.5c.902-.583 1.74-1.26 2.499-2.02l.459-.458a7.25 7.25 0 0 0 2.123-5.127V1.75a.25.25 0 0 0-.25-.25h-.186a7.249 7.249 0 0 0-5.125 2.123ZM3.56 14.56c-.732.732-2.334 1.045-3.005 1.148a.234.234 0 0 1-.201-.064.234.234 0 0 1-.064-.201c.103-.671.416-2.273 1.15-3.003a1.502 1.502 0 1 1 2.12 2.12Zm6.94-3.935c-.088.06-.177.118-.266.175l-2.35 1.521.548 1.783 1.949-1.2a.25.25 0 0 0 .119-.213ZM3.678 8.116 5.2 5.766c.058-.09.117-.178.176-.266H3.309a.25.25 0 0 0-.213.119l-1.2 1.95ZM12 5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </template> <template id="shield-check-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield-check"> <path d="m8.533.133 5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667l5.25-1.68a1.748 1.748 0 0 1 1.066 0Zm-.61 1.429.001.001-5.25 1.68a.251.251 0 0 0-.174.237V7c0 1.36.275 2.666 1.057 3.859.784 1.194 2.121 2.342 4.366 3.298a.196.196 0 0 0 .154 0c2.245-.957 3.582-2.103 4.366-3.297C13.225 9.666 13.5 8.358 13.5 7V3.48a.25.25 0 0 0-.174-.238l-5.25-1.68a.25.25 0 0 0-.153 0ZM11.28 6.28l-3.5 3.5a.75.75 0 0 1-1.06 0l-1.5-1.5a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l.97.97 2.97-2.97a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="heart-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-heart"> <path d="m8 14.25.345.666a.75.75 0 0 1-.69 0l-.008-.004-.018-.01a7.152 7.152 0 0 1-.31-.17 22.055 22.055 0 0 1-3.434-2.414C2.045 10.731 0 8.35 0 5.5 0 2.836 2.086 1 4.25 1 5.797 1 7.153 1.802 8 3.02 8.847 1.802 10.203 1 11.75 1 13.914 1 16 2.836 16 5.5c0 2.85-2.045 5.231-3.885 6.818a22.066 22.066 0 0 1-3.744 2.584l-.018.01-.006.003h-.002ZM4.25 2.5c-1.336 0-2.75 1.164-2.75 3 0 2.15 1.58 4.144 3.365 5.682A20.58 20.58 0 0 0 8 13.393a20.58 20.58 0 0 0 3.135-2.211C12.92 9.644 14.5 7.65 14.5 5.5c0-1.836-1.414-3-2.75-3-1.373 0-2.609.986-3.029 2.456a.749.749 0 0 1-1.442 0C6.859 3.486 5.623 2.5 4.25 2.5Z"></path> </svg> </template> <template id="server-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-server"> <path d="M1.75 1h12.5c.966 0 1.75.784 1.75 1.75v4c0 .372-.116.717-.314 1 .198.283.314.628.314 1v4a1.75 1.75 0 0 1-1.75 1.75H1.75A1.75 1.75 0 0 1 0 12.75v-4c0-.358.109-.707.314-1a1.739 1.739 0 0 1-.314-1v-4C0 1.784.784 1 1.75 1ZM1.5 2.75v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25Zm.25 5.75a.25.25 0 0 0-.25.25v4c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-4a.25.25 0 0 0-.25-.25ZM7 4.75A.75.75 0 0 1 7.75 4h4.5a.75.75 0 0 1 0 1.5h-4.5A.75.75 0 0 1 7 4.75ZM7.75 10h4.5a.75.75 0 0 1 0 1.5h-4.5a.75.75 0 0 1 0-1.5ZM3 4.75A.75.75 0 0 1 3.75 4h.5a.75.75 0 0 1 0 1.5h-.5A.75.75 0 0 1 3 4.75ZM3.75 10h.5a.75.75 0 0 1 0 1.5h-.5a.75.75 0 0 1 0-1.5Z"></path> </svg> </template> <template id="globe-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-globe"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM5.78 8.75a9.64 9.64 0 0 0 1.363 4.177c.255.426.542.832.857 1.215.245-.296.551-.705.857-1.215A9.64 9.64 0 0 0 10.22 8.75Zm4.44-1.5a9.64 9.64 0 0 0-1.363-4.177c-.307-.51-.612-.919-.857-1.215a9.927 9.927 0 0 0-.857 1.215A9.64 9.64 0 0 0 5.78 7.25Zm-5.944 1.5H1.543a6.507 6.507 0 0 0 4.666 5.5c-.123-.181-.24-.365-.352-.552-.715-1.192-1.437-2.874-1.581-4.948Zm-2.733-1.5h2.733c.144-2.074.866-3.756 1.58-4.948.12-.197.237-.381.353-.552a6.507 6.507 0 0 0-4.666 5.5Zm10.181 1.5c-.144 2.074-.866 3.756-1.58 4.948-.12.197-.237.381-.353.552a6.507 6.507 0 0 0 4.666-5.5Zm2.733-1.5a6.507 6.507 0 0 0-4.666-5.5c.123.181.24.365.353.552.714 1.192 1.436 2.874 1.58 4.948Z"></path> </svg> </template> <template id="issue-opened-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </template> <template id="device-mobile-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-mobile"> <path d="M3.75 0h8.5C13.216 0 14 .784 14 1.75v12.5A1.75 1.75 0 0 1 12.25 16h-8.5A1.75 1.75 0 0 1 2 14.25V1.75C2 .784 2.784 0 3.75 0ZM3.5 1.75v12.5c0 .138.112.25.25.25h8.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25ZM8 13a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path> </svg> </template> <template id="package-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-package"> <path d="m8.878.392 5.25 3.045c.54.314.872.89.872 1.514v6.098a1.75 1.75 0 0 1-.872 1.514l-5.25 3.045a1.75 1.75 0 0 1-1.756 0l-5.25-3.045A1.75 1.75 0 0 1 1 11.049V4.951c0-.624.332-1.201.872-1.514L7.122.392a1.75 1.75 0 0 1 1.756 0ZM7.875 1.69l-4.63 2.685L8 7.133l4.755-2.758-4.63-2.685a.248.248 0 0 0-.25 0ZM2.5 5.677v5.372c0 .09.047.171.125.216l4.625 2.683V8.432Zm6.25 8.271 4.625-2.683a.25.25 0 0 0 .125-.216V5.677L8.75 8.432Z"></path> </svg> </template> <template id="credit-card-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-credit-card"> <path d="M10.75 9a.75.75 0 0 0 0 1.5h1.5a.75.75 0 0 0 0-1.5h-1.5Z"></path><path d="M0 3.75C0 2.784.784 2 1.75 2h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0 1 14.25 14H1.75A1.75 1.75 0 0 1 0 12.25ZM14.5 6.5h-13v5.75c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25Zm0-2.75a.25.25 0 0 0-.25-.25H1.75a.25.25 0 0 0-.25.25V5h13Z"></path> </svg> </template> <template id="play-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </template> <template id="gift-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-gift"> <path d="M2 2.75A2.75 2.75 0 0 1 4.75 0c.983 0 1.873.42 2.57 1.232.268.318.497.668.68 1.042.183-.375.411-.725.68-1.044C9.376.42 10.266 0 11.25 0a2.75 2.75 0 0 1 2.45 4h.55c.966 0 1.75.784 1.75 1.75v2c0 .698-.409 1.301-1 1.582v4.918A1.75 1.75 0 0 1 13.25 16H2.75A1.75 1.75 0 0 1 1 14.25V9.332C.409 9.05 0 8.448 0 7.75v-2C0 4.784.784 4 1.75 4h.55c-.192-.375-.3-.8-.3-1.25ZM7.25 9.5H2.5v4.75c0 .138.112.25.25.25h4.5Zm1.5 0v5h4.5a.25.25 0 0 0 .25-.25V9.5Zm0-4V8h5.5a.25.25 0 0 0 .25-.25v-2a.25.25 0 0 0-.25-.25Zm-7 0a.25.25 0 0 0-.25.25v2c0 .138.112.25.25.25h5.5V5.5h-5.5Zm3-4a1.25 1.25 0 0 0 0 2.5h2.309c-.233-.818-.542-1.401-.878-1.793-.43-.502-.915-.707-1.431-.707ZM8.941 4h2.309a1.25 1.25 0 0 0 0-2.5c-.516 0-1 .205-1.43.707-.337.392-.646.975-.879 1.793Z"></path> </svg> </template> <template id="code-square-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code-square"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25Zm1.75-.25a.25.25 0 0 0-.25.25v12.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25V1.75a.25.25 0 0 0-.25-.25Zm7.47 3.97a.75.75 0 0 1 1.06 0l2 2a.75.75 0 0 1 0 1.06l-2 2a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L10.69 8 9.22 6.53a.75.75 0 0 1 0-1.06ZM6.78 6.53 5.31 8l1.47 1.47a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215l-2-2a.75.75 0 0 1 0-1.06l2-2a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </template> <template id="device-desktop-icon"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-device-desktop"> <path d="M14.25 1c.966 0 1.75.784 1.75 1.75v7.5A1.75 1.75 0 0 1 14.25 12h-3.727c.099 1.041.52 1.872 1.292 2.757A.752.752 0 0 1 11.25 16h-6.5a.75.75 0 0 1-.565-1.243c.772-.885 1.192-1.716 1.292-2.757H1.75A1.75 1.75 0 0 1 0 10.25v-7.5C0 1.784.784 1 1.75 1ZM1.75 2.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h12.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25ZM9.018 12H6.982a5.72 5.72 0 0 1-.765 2.5h3.566a5.72 5.72 0 0 1-.765-2.5Z"></path> </svg> </template> <div class="position-relative"> <ul role="listbox" class="ActionListWrap QueryBuilder-ListWrap" aria-label="Suggestions" data-action=" combobox-commit:query-builder#comboboxCommit mousedown:query-builder#resultsMousedown " data-target="query-builder.resultsList" data-persist-list=false id="query-builder-test-results" ></ul> </div> <div class="FormControl-inlineValidation" id="validation-7fa89931-0697-49dc-a0e1-b32996a8ce97" hidden="hidden"> <span class="FormControl-inlineValidation--visual"> <svg aria-hidden="true" height="12" viewBox="0 0 12 12" version="1.1" width="12" data-view-component="true" class="octicon octicon-alert-fill"> <path d="M4.855.708c.5-.896 1.79-.896 2.29 0l4.675 8.351a1.312 1.312 0 0 1-1.146 1.954H1.33A1.313 1.313 0 0 1 .183 9.058ZM7 7V3H5v4Zm-1 3a1 1 0 1 0 0-2 1 1 0 0 0 0 2Z"></path> </svg> </span> <span></span> </div> </div> <div data-target="query-builder.screenReaderFeedback" aria-live="polite" aria-atomic="true" class="sr-only"></div> </query-builder></form> <div class="d-flex flex-row color-fg-muted px-3 text-small color-bg-default search-feedback-prompt"> <a target="_blank" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax" data-view-component="true" class="Link color-fg-accent text-normal ml-2">Search syntax tips</a> <div class="d-flex flex-1"></div> </div> </div> </div> </div> </modal-dialog></div> </div> <div data-action="click:qbsearch-input#retract" class="dark-backdrop position-fixed" hidden data-target="qbsearch-input.darkBackdrop"></div> <div class="color-fg-default"> <dialog-helper> <dialog data-target="qbsearch-input.feedbackDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="feedback-dialog" aria-modal="true" aria-labelledby="feedback-dialog-title" aria-describedby="feedback-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="feedback-dialog-title"> Provide feedback </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="feedback-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="feedback-dialog-title"> <div data-view-component="true" class="Overlay-body"> </option></form><form id="code-search-feedback-form" data-turbo="false" action="/search/feedback" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="s6Mr8m/xLYHpOz7LpGy4IAT9adX3ThVx6hSzVpvDTNS5l858F7peyXwBW5qidiqaL/coUhmmUru0kzuej6u7fg==" /> <p>We read every piece of feedback, and take your input very seriously.</p> <textarea name="feedback" class="form-control width-full mb-2" style="height: 120px" id="feedback"></textarea> <input name="include_email" id="include_email" aria-label="Include my email address so I can be contacted" class="form-control mr-2" type="checkbox"> <label for="include_email" style="font-weight: normal">Include my email address so I can be contacted</label> </form></div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd"> <button data-close-dialog-id="feedback-dialog" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="code-search-feedback-form" data-action="click:qbsearch-input#submitFeedback" type="submit" data-view-component="true" class="btn-primary btn"> Submit feedback </button> </div> </dialog></dialog-helper> <custom-scopes data-target="qbsearch-input.customScopesManager"> <dialog-helper> <dialog data-target="custom-scopes.customScopesModalDialog" data-action="close:qbsearch-input#handleDialogClose cancel:qbsearch-input#handleDialogClose" id="custom-scopes-dialog" aria-modal="true" aria-labelledby="custom-scopes-dialog-title" aria-describedby="custom-scopes-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header Overlay-header--divided"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="custom-scopes-dialog-title"> Saved searches </h1> <h2 id="custom-scopes-dialog-description" class="Overlay-description">Use saved searches to filter your results more quickly</h2> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="custom-scopes-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="custom-scopes-dialog-title"> <div data-view-component="true" class="Overlay-body"> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <div hidden class="create-custom-scope-form" data-target="custom-scopes.createCustomScopeForm"> </option></form><form id="custom-scopes-dialog-form" data-turbo="false" action="/search/custom_scopes" accept-charset="UTF-8" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="gryf3TzNvgEYnvUMj6oQeX6NtNFXkkJhNMri8L1hB1N3ElLuDmljemqjfXoOfqW7iuB6cVBhT1SvATttC+8w4w==" /> <div data-target="custom-scopes.customScopesModalDialogFlash"></div> <input type="hidden" id="custom_scope_id" name="custom_scope_id" data-target="custom-scopes.customScopesIdField"> <div class="form-group"> <label for="custom_scope_name">Name</label> <auto-check src="/search/custom_scopes/check_name" required only-validate-on-blur="false"> <input type="text" name="custom_scope_name" id="custom_scope_name" data-target="custom-scopes.customScopesNameField" class="form-control" autocomplete="off" placeholder="github-ruby" required maxlength="50"> <input type="hidden" data-csrf="true" value="aCECHdXjhOSHnfigluFakC129hSg9jABR1Qcb0MIiV+Z9n6q1cGCLlfyjp7GZf/YmlmxsYYlWC7sG5HAeChgzw==" /> </auto-check> </div> <div class="form-group"> <label for="custom_scope_query">Query</label> <input type="text" name="custom_scope_query" id="custom_scope_query" data-target="custom-scopes.customScopesQueryField" class="form-control" autocomplete="off" placeholder="(repo:mona/a OR repo:mona/b) AND lang:python" required maxlength="500"> </div> <p class="text-small color-fg-muted"> To see all available qualifiers, see our <a class="Link--inTextBlock" href="https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax">documentation</a>. </p> </form> </div> <div data-target="custom-scopes.manageCustomScopesForm"> <div data-target="custom-scopes.list"></div> </div> </div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd Overlay-footer--divided"> <button data-action="click:custom-scopes#customScopesCancel" type="button" data-view-component="true" class="btn"> Cancel </button> <button form="custom-scopes-dialog-form" data-action="click:custom-scopes#customScopesSubmit" data-target="custom-scopes.customScopesSubmitButton" type="submit" data-view-component="true" class="btn-primary btn"> Create saved search </button> </div> </dialog></dialog-helper> </custom-scopes> </div> </qbsearch-input> <div class="position-relative HeaderMenu-link-wrap d-lg-inline-block"> <a href="/login?return_to=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fdiscussions%2F61182" class="HeaderMenu-link HeaderMenu-link--sign-in HeaderMenu-button flex-shrink-0 no-underline d-none d-lg-inline-flex border border-lg-0 rounded rounded-lg-0 px-2 py-1" style="margin-left: 12px;" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4f8da33b33f0869231c1fa09d48918bbb50952e0a8ce459d2c9ca0b459bc76e0" data-analytics-event="{"category":"Marketing nav","action":"click to go to homepage","label":"ref_page:Marketing;ref_cta:Sign in;ref_loc:Header"}" > Sign in </a> </div> <a href="/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fdiscussions_fragments%2Fdiscussion_layout&source=header-repo&source_repo=golang%2Fgo" class="HeaderMenu-link HeaderMenu-link--sign-up HeaderMenu-button flex-shrink-0 d-flex d-lg-inline-flex no-underline border color-border-default rounded px-2 py-1" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"site header menu","repository_id":null,"auth_type":"SIGN_UP","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4f8da33b33f0869231c1fa09d48918bbb50952e0a8ce459d2c9ca0b459bc76e0" data-analytics-event="{"category":"Sign up","action":"click to sign up for account","label":"ref_page:/<user-name>/<repo-name>/voltron/discussions_fragments/discussion_layout;ref_cta:Sign up;ref_loc:header logged out"}" > Sign up </a> <button type="button" class="sr-only js-header-menu-focus-trap d-block d-lg-none">Reseting focus</button> </div> </div> </div> </div> </header> <div hidden="hidden" data-view-component="true" class="js-stale-session-flash stale-session-flash flash flash-warn flash-full"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span class="js-stale-session-flash-signed-in" hidden>You signed in with another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-signed-out" hidden>You signed out in another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <span class="js-stale-session-flash-switched" hidden>You switched accounts on another tab or window. <a class="Link--inTextBlock" href="">Reload</a> to refresh your session.</span> <button id="icon-button-16b1d77b-d4b8-4731-b5d5-8cf60e9bbd84" aria-labelledby="tooltip-dd308239-4ade-44b1-816f-2509557041b6" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium flash-close js-flash-close"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x Button-visual"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button><tool-tip id="tooltip-dd308239-4ade-44b1-816f-2509557041b6" for="icon-button-16b1d77b-d4b8-4731-b5d5-8cf60e9bbd84" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Dismiss alert</tool-tip> </div> </div> <div id="start-of-content" class="show-on-focus"></div> <div id="js-flash-container" class="flash-container" data-turbo-replace> <template class="js-flash-template"> <div class="flash flash-full {{ className }}"> <div > <button autofocus class="flash-close js-flash-close" type="button" aria-label="Dismiss this message"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div aria-atomic="true" role="alert" class="js-flash-alert"> <div>{{ message }}</div> </div> </div> </div> </template> </div> <div class="application-main " data-commit-hovercards-enabled data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled data-project-hovercards-enabled > <div itemscope itemtype="http://schema.org/SoftwareSourceCode" class=""> <main id="js-repo-pjax-container" > <div id="repository-container-header" class="pt-3 hide-full-screen" style="background-color: var(--page-header-bgColor, var(--color-page-header-bg));" data-turbo-replace> <div class="d-flex flex-nowrap flex-justify-end mb-3 px-3 px-lg-5" style="gap: 1rem;"> <div class="flex-auto min-width-0 width-fit"> <div class=" d-flex flex-wrap flex-items-center wb-break-word f3 text-normal"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo color-fg-muted mr-2"> <path d="M2 2.5A2.5 2.5 0 0 1 4.5 0h8.75a.75.75 0 0 1 .75.75v12.5a.75.75 0 0 1-.75.75h-2.5a.75.75 0 0 1 0-1.5h1.75v-2h-8a1 1 0 0 0-.714 1.7.75.75 0 1 1-1.072 1.05A2.495 2.495 0 0 1 2 11.5Zm10.5-1h-8a1 1 0 0 0-1 1v6.708A2.486 2.486 0 0 1 4.5 9h8ZM5 12.25a.25.25 0 0 1 .25-.25h3.5a.25.25 0 0 1 .25.25v3.25a.25.25 0 0 1-.4.2l-1.45-1.087a.249.249 0 0 0-.3 0L5.4 15.7a.25.25 0 0 1-.4-.2Z"></path> </svg> <span class="author flex-self-stretch" itemprop="author"> <a class="url fn" rel="author" data-hovercard-type="organization" data-hovercard-url="/orgs/golang/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/golang"> golang </a> </span> <span class="mx-1 flex-self-stretch color-fg-muted">/</span> <strong itemprop="name" class="mr-2 flex-self-stretch"> <a data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" href="/golang/go">go</a> </strong> <span></span><span class="Label Label--secondary v-align-middle mr-1">Public</span> </div> </div> <div id="repository-details-container" class="flex-shrink-0" data-turbo-replace style="max-width: 70%;"> <ul class="pagehead-actions flex-shrink-0 d-none d-md-inline" style="padding: 2px 0;"> <li> <a href="/login?return_to=%2Fgolang%2Fgo" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="687b6a65559a44ac4fc435e73e3e1712210c38edc2fd0f95ae8ced5b240b6fce" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bell mr-2"> <path d="M8 16a2 2 0 0 0 1.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 0 0 8 16ZM3 5a5 5 0 0 1 10 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.519 1.519 0 0 1 13.482 13H2.518a1.516 1.516 0 0 1-1.263-2.36l1.703-2.554A.255.255 0 0 0 3 7.947Zm5-3.5A3.5 3.5 0 0 0 4.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.017.017 0 0 0-.003.01l.001.006c0 .002.002.004.004.006l.006.004.007.001h10.964l.007-.001.006-.004.004-.006.001-.007a.017.017 0 0 0-.003-.01l-1.703-2.554a1.745 1.745 0 0 1-.294-.97V5A3.5 3.5 0 0 0 8 1.5Z"></path> </svg>Notifications </a> <tool-tip id="tooltip-de82ddef-7418-4ffe-bb22-084f04311c68" for="repository-details-watch-button" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be signed in to change notification settings</tool-tip> </li> <li> <a icon="repo-forked" id="fork-button" href="/login?return_to=%2Fgolang%2Fgo" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"repo details fork button","repository_id":23096959,"auth_type":"LOG_IN","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="c21c9bc1fa0929deceaa2c663497c2121e55f3c4f6f2f01d54260a3f39a7a1aa" data-view-component="true" class="btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-repo-forked mr-2"> <path d="M5 5.372v.878c0 .414.336.75.75.75h4.5a.75.75 0 0 0 .75-.75v-.878a2.25 2.25 0 1 1 1.5 0v.878a2.25 2.25 0 0 1-2.25 2.25h-1.5v2.128a2.251 2.251 0 1 1-1.5 0V8.5h-1.5A2.25 2.25 0 0 1 3.5 6.25v-.878a2.25 2.25 0 1 1 1.5 0ZM5 3.25a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Zm6.75.75a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5Zm-3 8.75a.75.75 0 1 0-1.5 0 .75.75 0 0 0 1.5 0Z"></path> </svg>Fork <span id="repo-network-counter" data-pjax-replace="true" data-turbo-replace="true" title="17,883" data-view-component="true" class="Counter">17.9k</span> </a> </li> <li> <div data-view-component="true" class="BtnGroup d-flex"> <a href="/login?return_to=%2Fgolang%2Fgo" rel="nofollow" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"star button","repository_id":23096959,"auth_type":"LOG_IN","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="49d1c38af5eb878472952efb26f8c4415282e0ed1beed3b6b561a3bebeb3ba42" aria-label="You must be signed in to star a repository" data-view-component="true" class="tooltipped tooltipped-sw btn-sm btn"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-star v-align-text-bottom d-inline-block mr-2"> <path d="M8 .25a.75.75 0 0 1 .673.418l1.882 3.815 4.21.612a.75.75 0 0 1 .416 1.279l-3.046 2.97.719 4.192a.751.751 0 0 1-1.088.791L8 12.347l-3.766 1.98a.75.75 0 0 1-1.088-.79l.72-4.194L.818 6.374a.75.75 0 0 1 .416-1.28l4.21-.611L7.327.668A.75.75 0 0 1 8 .25Zm0 2.445L6.615 5.5a.75.75 0 0 1-.564.41l-3.097.45 2.24 2.184a.75.75 0 0 1 .216.664l-.528 3.084 2.769-1.456a.75.75 0 0 1 .698 0l2.77 1.456-.53-3.084a.75.75 0 0 1 .216-.664l2.24-2.183-3.096-.45a.75.75 0 0 1-.564-.41L8 2.694Z"></path> </svg><span data-view-component="true" class="d-inline"> Star </span> <span id="repo-stars-counter-star" aria-label="125896 users starred this repository" data-singular-suffix="user starred this repository" data-plural-suffix="users starred this repository" data-turbo-replace="true" title="125,896" data-view-component="true" class="Counter js-social-count">126k</span> </a></div> </li> </ul> </div> </div> <div id="responsive-meta-container" data-turbo-replace> </div> <nav data-pjax="#js-repo-pjax-container" aria-label="Repository" data-view-component="true" class="js-repo-nav js-sidenav-container-pjax js-responsive-underlinenav overflow-hidden UnderlineNav px-3 px-md-4 px-lg-5"> <ul data-view-component="true" class="UnderlineNav-body list-style-none"> <li data-view-component="true" class="d-inline-flex"> <a id="code-tab" href="/golang/go" data-tab-item="i0code-tab" data-selected-links="repo_source repo_downloads repo_commits repo_releases repo_tags repo_branches repo_packages repo_deployments repo_attestations /golang/go" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g c" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Code","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code UnderlineNav-octicon d-none d-sm-inline"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> <span data-content="Code">Code</span> <span id="code-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="issues-tab" href="/golang/go/issues" data-tab-item="i1issues-tab" data-selected-links="repo_issues repo_labels repo_milestones /golang/go/issues" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g i" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Issues","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> <span data-content="Issues">Issues</span> <span id="issues-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="5,000+" data-view-component="true" class="Counter">5k+</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="pull-requests-tab" href="/golang/go/pulls" data-tab-item="i2pull-requests-tab" data-selected-links="repo_pulls checks /golang/go/pulls" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g p" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Pull requests","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> <span data-content="Pull requests">Pull requests</span> <span id="pull-requests-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="343" data-view-component="true" class="Counter">343</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="discussions-tab" href="/golang/go/discussions" data-tab-item="i3discussions-tab" data-selected-links="repo_discussions /golang/go/discussions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g g" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Discussions","target":"UNDERLINE_NAV.TAB"}" aria-current="page" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item selected"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> <span data-content="Discussions">Discussions</span> <span id="discussions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="actions-tab" href="/golang/go/actions" data-tab-item="i4actions-tab" data-selected-links="repo_actions /golang/go/actions" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g a" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Actions","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play UnderlineNav-octicon d-none d-sm-inline"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> <span data-content="Actions">Actions</span> <span id="actions-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="projects-tab" href="/golang/go/projects" data-tab-item="i5projects-tab" data-selected-links="repo_projects new_repo_project repo_project /golang/go/projects" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g b" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Projects","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-table UnderlineNav-octicon d-none d-sm-inline"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25ZM6.5 6.5v8h7.75a.25.25 0 0 0 .25-.25V6.5Zm8-1.5V1.75a.25.25 0 0 0-.25-.25H6.5V5Zm-13 1.5v7.75c0 .138.112.25.25.25H5v-8ZM5 5V1.5H1.75a.25.25 0 0 0-.25.25V5Z"></path> </svg> <span data-content="Projects">Projects</span> <span id="projects-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="4" data-view-component="true" class="Counter">4</span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="wiki-tab" href="/golang/go/wiki" data-tab-item="i6wiki-tab" data-selected-links="repo_wiki /golang/go/wiki" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g w" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Wiki","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book UnderlineNav-octicon d-none d-sm-inline"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> <span data-content="Wiki">Wiki</span> <span id="wiki-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="security-tab" href="/golang/go/security" data-tab-item="i7security-tab" data-selected-links="security overview alerts policy token_scanning code_scanning /golang/go/security" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-hotkey="g s" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Security","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield UnderlineNav-octicon d-none d-sm-inline"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <span data-content="Security">Security</span> <include-fragment src="/golang/go/security/overall-count" accept="text/fragment+html"></include-fragment> </a></li> <li data-view-component="true" class="d-inline-flex"> <a id="insights-tab" href="/golang/go/pulse" data-tab-item="i8insights-tab" data-selected-links="repo_graphs repo_contributors dependency_graph dependabot_updates pulse people community /golang/go/pulse" data-pjax="#repo-content-pjax-container" data-turbo-frame="repo-content-turbo-frame" data-analytics-event="{"category":"Underline navbar","action":"Click tab","label":"Insights","target":"UNDERLINE_NAV.TAB"}" data-view-component="true" class="UnderlineNav-item no-wrap js-responsive-underlinenav-item js-selected-navigation-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph UnderlineNav-octicon d-none d-sm-inline"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> <span data-content="Insights">Insights</span> <span id="insights-repo-tab-count" data-pjax-replace="" data-turbo-replace="" title="Not available" data-view-component="true" class="Counter"></span> </a></li> </ul> <div style="visibility:hidden;" data-view-component="true" class="UnderlineNav-actions js-responsive-underlinenav-overflow position-absolute pr-3 pr-md-4 pr-lg-5 right-0"> <action-menu data-select-variant="none" data-view-component="true"> <focus-group direction="vertical" mnemonics retain> <button id="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-button" popovertarget="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-overlay" aria-controls="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-list" aria-haspopup="true" aria-labelledby="tooltip-06f61cf8-65b0-4a14-ac43-3a0c1a7fb905" type="button" data-view-component="true" class="Button Button--iconOnly Button--secondary Button--medium UnderlineNav-item"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-06f61cf8-65b0-4a14-ac43-3a0c1a7fb905" for="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-button" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Additional navigation options</tool-tip> <anchored-position data-target="action-menu.overlay" id="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-overlay" anchor="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-button" align="start" side="outside-bottom" anchor-offset="normal" popover="auto" data-view-component="true"> <div data-view-component="true" class="Overlay Overlay--size-auto"> <div data-view-component="true" class="Overlay-body Overlay-body--paddingNone"> <action-list> <div data-view-component="true"> <ul aria-labelledby="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-button" id="action-menu-b3db56f0-871a-4c0e-91cf-35f43845082a-list" role="menu" data-view-component="true" class="ActionListWrap--inset ActionListWrap"> <li hidden="hidden" data-menu-item="i0code-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-7d729542-b608-453c-a439-0da300ff18c6" href="/golang/go" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Code </span> </a> </li> <li hidden="hidden" data-menu-item="i1issues-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-19d3f12f-aec7-4bfa-b0e4-e14f39591b02" href="/golang/go/issues" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-issue-opened"> <path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Issues </span> </a> </li> <li hidden="hidden" data-menu-item="i2pull-requests-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-de3aad3f-bf04-40b8-949b-46c6e2feed5d" href="/golang/go/pulls" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-pull-request"> <path d="M1.5 3.25a2.25 2.25 0 1 1 3 2.122v5.256a2.251 2.251 0 1 1-1.5 0V5.372A2.25 2.25 0 0 1 1.5 3.25Zm5.677-.177L9.573.677A.25.25 0 0 1 10 .854V2.5h1A2.5 2.5 0 0 1 13.5 5v5.628a2.251 2.251 0 1 1-1.5 0V5a1 1 0 0 0-1-1h-1v1.646a.25.25 0 0 1-.427.177L7.177 3.427a.25.25 0 0 1 0-.354ZM3.75 2.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm0 9.5a.75.75 0 1 0 0 1.5.75.75 0 0 0 0-1.5Zm8.25.75a.75.75 0 1 0 1.5 0 .75.75 0 0 0-1.5 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Pull requests </span> </a> </li> <li hidden="hidden" data-menu-item="i3discussions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-c84f1ec3-5c73-4438-bd15-8c6c06aa0dbc" href="/golang/go/discussions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-comment-discussion"> <path d="M1.75 1h8.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.458 1.458 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25v-5.5C0 1.784.784 1 1.75 1ZM1.5 2.75v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25h-8.5a.25.25 0 0 0-.25.25Zm13 2a.25.25 0 0 0-.25-.25h-.5a.75.75 0 0 1 0-1.5h.5c.966 0 1.75.784 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.458 1.458 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l2.22 2.22v-2.19a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Discussions </span> </a> </li> <li hidden="hidden" data-menu-item="i4actions-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-6bbaff30-5ccc-4c51-bab1-ee13fdbcdc7a" href="/golang/go/actions" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-play"> <path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Actions </span> </a> </li> <li hidden="hidden" data-menu-item="i5projects-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-47444361-7488-4c28-89cf-5948d3737c8b" href="/golang/go/projects" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-table"> <path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25ZM6.5 6.5v8h7.75a.25.25 0 0 0 .25-.25V6.5Zm8-1.5V1.75a.25.25 0 0 0-.25-.25H6.5V5Zm-13 1.5v7.75c0 .138.112.25.25.25H5v-8ZM5 5V1.5H1.75a.25.25 0 0 0-.25.25V5Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Projects </span> </a> </li> <li hidden="hidden" data-menu-item="i6wiki-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-0fee3ab2-6bfb-4cb8-be4f-39a340137bf8" href="/golang/go/wiki" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-book"> <path d="M0 1.75A.75.75 0 0 1 .75 1h4.253c1.227 0 2.317.59 3 1.501A3.743 3.743 0 0 1 11.006 1h4.245a.75.75 0 0 1 .75.75v10.5a.75.75 0 0 1-.75.75h-4.507a2.25 2.25 0 0 0-1.591.659l-.622.621a.75.75 0 0 1-1.06 0l-.622-.621A2.25 2.25 0 0 0 5.258 13H.75a.75.75 0 0 1-.75-.75Zm7.251 10.324.004-5.073-.002-2.253A2.25 2.25 0 0 0 5.003 2.5H1.5v9h3.757a3.75 3.75 0 0 1 1.994.574ZM8.755 4.75l-.004 7.322a3.752 3.752 0 0 1 1.992-.572H14.5v-9h-3.495a2.25 2.25 0 0 0-2.25 2.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Wiki </span> </a> </li> <li hidden="hidden" data-menu-item="i7security-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-a82783a3-8059-40bc-9e4f-8828e39f6d6d" href="/golang/go/security" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-shield"> <path d="M7.467.133a1.748 1.748 0 0 1 1.066 0l5.25 1.68A1.75 1.75 0 0 1 15 3.48V7c0 1.566-.32 3.182-1.303 4.682-.983 1.498-2.585 2.813-5.032 3.855a1.697 1.697 0 0 1-1.33 0c-2.447-1.042-4.049-2.357-5.032-3.855C1.32 10.182 1 8.566 1 7V3.48a1.75 1.75 0 0 1 1.217-1.667Zm.61 1.429a.25.25 0 0 0-.153 0l-5.25 1.68a.25.25 0 0 0-.174.238V7c0 1.358.275 2.666 1.057 3.86.784 1.194 2.121 2.34 4.366 3.297a.196.196 0 0 0 .154 0c2.245-.956 3.582-2.104 4.366-3.298C13.225 9.666 13.5 8.36 13.5 7V3.48a.251.251 0 0 0-.174-.237l-5.25-1.68ZM8.75 4.75v3a.75.75 0 0 1-1.5 0v-3a.75.75 0 0 1 1.5 0ZM9 10.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Security </span> </a> </li> <li hidden="hidden" data-menu-item="i8insights-tab" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <a tabindex="-1" id="item-424ec5de-5d21-4d1f-8076-ca34bcba730d" href="/golang/go/pulse" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-graph"> <path d="M1.5 1.75V13.5h13.75a.75.75 0 0 1 0 1.5H.75a.75.75 0 0 1-.75-.75V1.75a.75.75 0 0 1 1.5 0Zm14.28 2.53-5.25 5.25a.75.75 0 0 1-1.06 0L7 7.06 4.28 9.78a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042l3.25-3.25a.75.75 0 0 1 1.06 0L10 7.94l4.72-4.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Insights </span> </a> </li> </ul> </div></action-list> </div> </div></anchored-position> </focus-group> </action-menu></div> </nav> </div> <turbo-frame id="repo-content-turbo-frame" target="_top" data-turbo-action="advance" class=""> <div id="repo-content-pjax-container" class="repository-content " > <div class="clearfix new-discussion-timeline js-check-all-container container-xl px-3 px-md-4 px-lg-5 mt-4" data-pjax="" data-turbo-frame=""> <div id="discussion_bucket" class="gutter-condensed gutter-lg flex-column flex-md-row d-flex flex-wrap"> <div class="clearfix flex-shrink-0 js-issues-results col-12 flex-wrap"> <div id="partial-discussion-header" class="gh-header js-details-container Details js-socket-channel js-updatable-content js-discussions-title-container" data-channel="eyJjIjoiZGlzY3Vzc2lvbjo1MzcxNzk1IiwidCI6MTczOTgxMTg1OX0=--8db735676ddb476f7c205f98c1cfb8169e29ee499935a9cdd0cead0c82f83fdc" data-gid="D_kwDOAWBuf84AUfeT" data-url="/golang/go/discussions/61182/title" > <div class="gh-header-show gh-header-no-access"> <div class="d-flex flex-column flex-md-row flex-items-start"> <div class="d-flex width-full flex-order-1 flex-md-order-none"> <div class="d-flex flex-column"> <h1 class="gh-header-title flex-auto wb-break-word f1 mr-0"> <span class="js-issue-title markdown-title" > codereview: should the Go project stop importing GitHub PRs? </span> <span class="gh-header-number f1-light">#61182</span> </h1> <div class="d-flex flex-wrap flex-items-center mb-3 mt-2"> <span title="Status: Closed as resolved" data-view-component="true" class="State State--merged d-flex flex-items-center mr-2"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-discussion-closed flex-items-center mr-1"> <path d="M0 2.75C0 1.783.784 1 1.75 1h8.5c.967 0 1.75.783 1.75 1.75v5.5A1.75 1.75 0 0 1 10.25 10H7.061l-2.574 2.573A1.457 1.457 0 0 1 2 11.543V10h-.25A1.75 1.75 0 0 1 0 8.25Zm1.75-.25a.25.25 0 0 0-.25.25v5.5c0 .138.112.25.25.25h1a.75.75 0 0 1 .75.75v2.189L6.22 8.72a.747.747 0 0 1 .53-.22h3.5a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25Zm12.5 2h-.5a.75.75 0 0 1 0-1.5h.5c.967 0 1.75.783 1.75 1.75v5.5A1.75 1.75 0 0 1 14.25 12H14v1.543a1.457 1.457 0 0 1-2.487 1.03L9.22 12.28a.749.749 0 1 1 1.06-1.06l2.22 2.219V11.25a.75.75 0 0 1 .75-.75h1a.25.25 0 0 0 .25-.25v-5.5a.25.25 0 0 0-.25-.25Zm-5.47.28-3 3a.747.747 0 0 1-1.06 0l-1.5-1.5a.749.749 0 1 1 1.06-1.06l.97.969L7.72 3.72a.749.749 0 1 1 1.06 1.06Z"></path> </svg> Closed </span> <div class="color-fg-muted my-1" > <a href="/bcmills" class="Link--secondary text-bold d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" > <span >bcmills</span> </a> announced in <a class="color-fg-inherit text-bold" href="/golang/go/discussions/categories/discussions">Discussions</a> </div> </div> </div> </div> <div class="gh-header-actions mt-0 mt-md-1 mb-2 mb-md-0 flex-shrink-0 d-flex"> </div> </div> </div> <div class="js-sticky js-sticky-offset-scroll top-0 gh-header-sticky"> <div class="sticky-content"> <div class="d-flex flex-items-center"> <div class="d-flex flex-1 flex-row flex-items-center min-width-0 my-2"> <div class="min-width-0"> <div class="d-flex text-bold f5"> <a class="js-issue-title css-truncate css-truncate-target Link--primary width-fit markdown-title js-smoothscroll-anchor" href="#top"> codereview: should the Go project stop importing GitHub PRs? </a> <span class="gh-header-number color-fg-muted pl-1">#61182</span> </div> <div class="meta color-fg-muted width-fit"> <div class="d-flex flex-row flex-items-center"> <div class="pr-2 d-flex flex-row"> <a href="/bcmills" class="author d-flex flex-items-center Link--primary text-bold" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" data-hovercard-z-index-override="111" > <img class="mr-1 avatar mt-0 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=40&v=4" width="20" height="20" alt="@bcmills" /> <span class="d-none d-md-inline-block mr-1" > bcmills </span> </a> </div> <div > <relative-time datetime="2023-07-05T17:05:22Z" class="no-wrap">Jul 5, 2023</relative-time> <span class="mx-1">·</span> 18 comments <span class="mx-1">·</span> 38 replies </div> </div> </div> </div> </div> <div class="ml-3"> <a href="#top" class="color-fg-muted py-3 ml-2 f6 d-none d-md-inline-block">Return to top</a> </div> </div> </div> </div> <div class="gh-header-shadow color-shadow-small js-notification-shelf-offset-top"></div> </div> </div> <div class="flex-shrink-0 col-12 col-md-9 mb-4 mb-md-0"> <div class="js-quote-selection-container js-discussion-quote-selection" data-quote-markdown=".js-comment-body" data-issue-and-pr-hovercards-enabled data-discussion-hovercards-enabled data-team-hovercards-enabled data-timeline-item-src="/golang/go/discussions/61182/timeline_anchor" id="js-discussions-timeline-anchor-loader" > <div class="discussion js-discussion js-socket-channel js-updatable-content" data-discussion-hovercards-enabled data-repository-hovercards-enabled data-commit-hovercards-enabled data-channel="eyJjIjoiZGlzY3Vzc2lvbjo1MzcxNzk1IiwidCI6MTczOTgxMTg1OX0=--8db735676ddb476f7c205f98c1cfb8169e29ee499935a9cdd0cead0c82f83fdc" > <div class="TimelineItem pt-0 js-comment-container discussion-timeline-item ml-0" data-gid="D_kwDOAWBuf84AUfeT" data-url="/golang/go/discussions/61182/body" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussion-5371795" data-hpc > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="24b6ff205723cb1ca96b290d4b3412af4624a41fed30d572e8c597ff28db584f" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Discussion-actions-5371795-text" aria-haspopup="true" aria-expanded="false" aria-controls="Discussion-actions-5371795-list" aria-labelledby="tooltip-4d047385-e543-4394-acac-49e92f307455" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-4d047385-e543-4394-acac-49e92f307455" for="Discussion-actions-5371795-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Discussion options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Discussion-actions-5371795-list" role="menu" aria-labelledby="Discussion-actions-5371795-text"> <include-fragment src="/golang/go/discussions/61182/actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-5371795-list" aria-expanded="false" id="discussion-edit-history-5371795-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-5371795-list" role="menu" aria-labelledby="discussion-edit-history-5371795-text"> <include-fragment src="/golang/go/discussions/61182/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h2 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/5200974?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">bcmills</span> </div></a> <a href="#discussion-5371795" id="discussion-5371795-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T17:05:22Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h2> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="5371795" data-target-translation-type="discussion" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">In <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="198822553" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/18517" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/18517/hovercard" href="https://github.com/golang/go/issues/18517">#18517</a> (accepted Jan. 2017), we decided to start importing GitHub pull requests for the Go repositories as Gerrit changes, in addition to our more typical direct-to-Gerrit workflow.</p> <p dir="auto">In the time since then, I have reviewed many contributed changes to the various Go repos, including those posted as GitHub PRs and those posted directly to Gerrit.</p> <p dir="auto">In my experience, the GitHub workflow is not working well.</p> <ul dir="auto"> <li>Since most changes receive at least one comment that needs to be addressed, contributors will almost always need to figure out how to sign in to Gerrit and use it anyway. <ul dir="auto"> <li>A significant fraction of GitHub PRs are abandoned when the author does not respond to Gerrit comments, but the existence of an open PR discourages other contributors from working on the corresponding issue.</li> </ul> </li> <li>Mismatches between the GitHub and Gerrit data models introduce confusion. <ul dir="auto"> <li>Gerrit squashes all commits for the PR into a single Gerrit commit, and as a result forces users to edit commit messages by editing the PR title and comment, which does not seem to be intuitive or discoverable for most users. See: <ul dir="auto"> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="322428297" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/25359" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/25359/hovercard" href="https://github.com/golang/go/issues/25359">x/build/cmd/gerritbot: commit message source confuses a lot of people<span class="issue-shorthand"> #25359</span></a></span></li> <li><span class="reference"><svg class="octicon octicon-skip color-fg-muted mr-1" title="Closed as not planned" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm9.78-2.22-5.5 5.5a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l5.5-5.5a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="416702985" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/30564" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/30564/hovercard" href="https://github.com/golang/go/issues/30564">wiki: Improve GerritBot GitHub PR workflow instructions<span class="issue-shorthand"> #30564</span></a></span></li> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="614825228" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/38957" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/38957/hovercard" href="https://github.com/golang/go/issues/38957">x/build/cmd/gerritbot: should determine author from first commit rather not last<span class="issue-shorthand"> #38957</span></a></span></li> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="682017180" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/40906" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/40906/hovercard" href="https://github.com/golang/go/issues/40906">x/build/cmd/gerritbot: support multiple CL authors (Co-authored-by)<span class="issue-shorthand"> #40906</span></a></span></li> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="313834738" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/24832" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/24832/hovercard" href="https://github.com/golang/go/issues/24832">x/build/cmd/gerritbot: auto-wrap description<span class="issue-shorthand"> #24832</span></a></span></li> </ul> </li> <li>Gerrit comments are not copied back to the GitHub PR (instead the bot leaves a comment with a Gerrit link), so a large fraction of code reviews for GitHub PRs require multiple rounds of comments of the form “please mark comments as resolved in Gerrit if they have been addressed”, and the status of PRs with unresolved Gerrit comments is often unclear. <ul dir="auto"> <li>See <span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="607564066" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/38689" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/38689/hovercard" href="https://github.com/golang/go/issues/38689">x/build/cmd/gerritbot: inline comments not synchronized to GitHub<span class="issue-shorthand"> #38689</span></a></span>.</li> </ul> </li> <li>The Go <code class="notranslate">git-codereview</code> hooks do not apply for GitHub PRs, so simple reminder steps like “make sure your code is <code class="notranslate">gofmt</code>'d” often require extra rounds of review comments. <ul dir="auto"> <li>See <span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="315818169" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/24946" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/24946/hovercard" href="https://github.com/golang/go/issues/24946">x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit<span class="issue-shorthand"> #24946</span></a></span>.</li> </ul> </li> </ul> </li> <li>Once a change has been initiated via a GitHub PR, it isn't possible to switch to the more direct Gerrit workflow, and isn't possible to reopen the GitHub PR once it is closed. See: <ul dir="auto"> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="314814811" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/24887" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/24887/hovercard" href="https://github.com/golang/go/issues/24887">x/build/cmd/gerritbot: Gerrit edits are immediately overwritten by older GitHub commits<span class="issue-shorthand"> #24887</span></a></span></li> <li><span class="reference"><svg class="octicon octicon-issue-opened open mr-1" title="Open" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"></path></svg><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="681260310" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/40874" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/40874/hovercard" href="https://github.com/golang/go/issues/40874">x/build/cmd/gerritbot: support continuing to work with PRs that are closed and re-opened<span class="issue-shorthand"> #40874</span></a></span></li> </ul> </li> <li>Since the Gerrit workflow is so different from the GitHub one, the GitHub import process does not do much in the way of helping new contributors develop familiarity for longer-term contributions on the project.</li> </ul> <p dir="auto">In addition, the bot that implements the import workflow is somewhat buggy and not always reliable<br> (see <a href="https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+gerritbot+in%3Atitle">https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+gerritbot+in%3Atitle</a> for the complete list).</p> <p dir="auto">It may be possible to fix many of the bugs in the GerritBot implementation, at some indeterminate cost. However, I do not believe that it is possible to address the mismatches in the data model in a satisfactory way — especially not without significant additional development work on GerritBot, which I don't foresee becoming a priority for the Go project in the near future.</p> <p dir="auto">In this discussion, I would like to investigate the possibility of no longer accepting GitHub PRs, and reducing GerritBot to simply closing them with a message directing the requester to the Gerrit workflow in the <a href="https://go.dev/doc/contribute#sending_a_change_gerrit" rel="nofollow">Contribution Guide</a>. That would essentially reverse <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="198822553" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/18517" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/18517/hovercard" href="https://github.com/golang/go/issues/18517">#18517</a> in light of several years' experience with the result of that proposal.</p> <hr> <p dir="auto">[edited 2023-08-11] Since this discussion began, a number of these friction points have been addressed. We will continue to import GitHub PRs and see if the friction in that process has been sufficiently reduced. (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="5371795" data-permission-text="Title is private" data-url="https://github.com/golang/go/discussions/61182" data-hovercard-type="discussion" data-hovercard-url="/golang/go/discussions/61182/hovercard?comment_id=6705842" href="https://github.com/golang/go/discussions/61182#discussioncomment-6705842">#61182 (comment)</a>)</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 15" aria-disabled="true" id="discussion-upvote-button-Discussion-5371795" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>15</span> </button> <tool-tip id="tooltip-d66adb3d-d2f3-44d7-b484-5a3ae1ea4140" for="discussion-upvote-button-Discussion-5371795" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-378d48" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>63</span> </button> <button name="input[content]" id="reactions--reaction_button_component-3eaca9" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>54</span> </button> <button name="input[content]" id="reactions--reaction_button_component-77d882" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-eee784" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-ae326b" value="ROCKET react" data-button-index-position="6" data-reaction-label="Rocket" data-reaction-content="rocket" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="rocket" fallback-src="https://github.githubassets.com/assets/1f680-d0ef47fdb515.png" class="social-button-emoji">🚀</g-emoji> <span>9</span> </button> <button name="input[content]" id="reactions--reaction_button_component-785d97" value="EYES react" data-button-index-position="7" data-reaction-label="Eyes" data-reaction-content="eyes" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="eyes" fallback-src="https://github.githubassets.com/assets/1f440-ee44e91e92a7.png" class="social-button-emoji">👀</g-emoji> <span>2</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>63</span> </li> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>54</span> </li> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="rocket"> <g-emoji alias="rocket" fallback-src="https://github.githubassets.com/assets/1f680-d0ef47fdb515.png" class="social-button-emoji">🚀</g-emoji> <span>9</span> </li> <li class="dropdown-item" aria-label="eyes"> <g-emoji alias="eyes" fallback-src="https://github.githubassets.com/assets/1f440-ee44e91e92a7.png" class="social-button-emoji">👀</g-emoji> <span>2</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="js-timeline-marker"> <div class="d-flex flex-items-center flex-wrap"> <div class="js-socket-channel js-updatable-content d-flex flex-auto" data-channel="eyJjIjoiZGlzY3Vzc2lvbjo1MzcxNzk1IiwidCI6MTczOTgxMTg1OX0=--8db735676ddb476f7c205f98c1cfb8169e29ee499935a9cdd0cead0c82f83fdc" data-url="/golang/go/discussions/61182/comment_count" data-gid="D_kwDOAWBuf84AUfeT" > <h2 id="discussion-comment-count" data-view-component="true" class="f4 my-2"> <span class="sr-only">Replies: </span> <span > 18 comments </span> <span aria-hidden="true">·</span> <span class="text-normal" > 38 replies </span> </h2></div> <nav aria-label="Sort comments" id="discussion-comment-header"> <segmented-control> <ul aria-labelledby="discussion-comment-header" role="list" data-view-component="true" class="SegmentedControl--medium SegmentedControl"> <li class="SegmentedControl-item SegmentedControl-item--selected" role="listitem" data-targets="segmented-control.items"> <a href="/golang/go/discussions/61182?sort=old" data-hydro-click="{"event_type":"discussions.comment_sort_click","payload":{"repository_id":23096959,"discussion_id":5371795,"sort":"old","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="1429b3d81ea198b6d48f9a16769047d1fa65013bb1a270cba23c536b72001ecb" aria-current="true" data-view-component="true" class="Button--invisible Button--medium Button Button--invisible-noVisuals"> <span class="Button-content"> <span class="Button-label">Oldest</span> </span> </a> </li> <li class="SegmentedControl-item" role="listitem" data-targets="segmented-control.items"> <a href="/golang/go/discussions/61182?sort=new" data-hydro-click="{"event_type":"discussions.comment_sort_click","payload":{"repository_id":23096959,"discussion_id":5371795,"sort":"new","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="5c474b8376d88249bab155f08af9a0deed25bacd522c8c3160c2801acc5e9ba5" aria-current="false" data-view-component="true" class="Button--invisible Button--medium Button Button--invisible-noVisuals"> <span class="Button-content"> <span class="Button-label">Newest</span> </span> </a> </li> <li class="SegmentedControl-item" role="listitem" data-targets="segmented-control.items"> <a href="/golang/go/discussions/61182?sort=top" data-hydro-click="{"event_type":"discussions.comment_sort_click","payload":{"repository_id":23096959,"discussion_id":5371795,"sort":"top","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="96498ab4dbf0112f03cdc2d300472c02171e8a624917dc051657f57c23cc76c6" aria-current="false" data-view-component="true" class="Button--invisible Button--medium Button Button--invisible-noVisuals"> <span class="Button-content"> <span class="Button-label">Top</span> </span> </a> </li> </ul></segmented-control> </nav> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYSJ7" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6365819" data-gid="DC_kwDOAWBuf84AYSJ7" data-url="/golang/go/discussions/61182/comments/6365819" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="be523fd428296d63e5807017d4d26dcff2d01f5e3e97cda02676156fa59e2c95" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6365819-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6365819-list" aria-labelledby="tooltip-9a121d6b-56c3-420b-94d8-0bb9e562a682" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-9a121d6b-56c3-420b-94d8-0bb9e562a682" for="Comment-actions-6365819-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6365819-list" role="menu" aria-labelledby="Comment-actions-6365819-text"> <include-fragment src="/golang/go/discussions/61182/comments/6365819/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6365819" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6365819,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="fbf36ded7cd0b42b8211cfec40994bc5f5a61af19fe14aa487f4110ab82a18b6" data-hovercard-type="user" data-hovercard-url="/users/achille-roussel/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/achille-roussel" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/865510?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">achille-roussel</span> </div></a> <a href="#discussioncomment-6365819" id="discussioncomment-6365819-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T17:44:26Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6365819/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6365819" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I started contributing to Go a few months ago and used the Github workflow on my first submission. The especially difficult part was getting formatting conventions right on the commit message: sending updates that rendered differently on Github to match the required format for Gerrit took most of the time.</p> <p dir="auto">In hindsight, learning the Gerrit workflow from the start would have been much simpler.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 5" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6365819" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>5</span> </button> <tool-tip id="tooltip-f8aa9dae-67d9-4611-8a60-60c53d2b0a0f" for="discussion-upvote-button-DiscussionComment-6365819" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-fa0d6d" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>8</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>8</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6365819"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368142,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="74d346de805c04ad00b041eb25d8c814288dcc78e1d6ac6275bf487e01b141c2" data-hovercard-type="user" data-hovercard-url="/users/ncruces/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ncruces"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5637550?s=60&v=4" width="30" height="30" alt="@ncruces" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6368142" data-gid="DC_kwDOAWBuf84AYSuO" data-url="/golang/go/discussions/61182/comments/6368142" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="95c313ec5bb5a350074e2a4edd226a8f9818e0ee20642bc999f04d90ad46e709" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6368142-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6368142-list" aria-labelledby="tooltip-bd6470bd-eac8-48b7-9ff9-ee0c9e089c56" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-bd6470bd-eac8-48b7-9ff9-ee0c9e089c56" for="Comment-actions-6368142-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6368142-list" role="menu" aria-labelledby="Comment-actions-6368142-text"> <include-fragment src="/golang/go/discussions/61182/comments/6368142/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6368142" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368142,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="74d346de805c04ad00b041eb25d8c814288dcc78e1d6ac6275bf487e01b141c2" data-hovercard-type="user" data-hovercard-url="/users/ncruces/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ncruces" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ncruces</a> <a href="#discussioncomment-6368142" id="discussioncomment-6368142-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T22:59:30Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6368142/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6368142" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">I agree with this, and having been forced to do Gerrit extensively (professionally), I also wished I went with Gerrit from the get go.<br> Yet, I still think GitHub import lowers the bar.</p> <p dir="auto">If simple reviews of drive-by contributions could be handled GitHub-side, that would be great.<br> Unless those are mostly considered noise.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYScF" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6366981" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="b3ab0b8bbaa99cf381aef8b8de652c1d69cd3f3c4d69789b7a386a25ab36826e" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6366981-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6366981-list" aria-labelledby="tooltip-256a640d-1253-4a8c-9745-a9ce850cc69e" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-256a640d-1253-4a8c-9745-a9ce850cc69e" for="Comment-actions-6366981-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6366981-list" role="menu" aria-labelledby="Comment-actions-6366981-text"> <include-fragment src="/golang/go/discussions/61182/comments/6366981/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6366981" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6366981,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="f80d11294a7442898b47864152fb1aba15206c310f1a6cfb841928be60835ab0" data-hovercard-type="user" data-hovercard-url="/users/SuperSandro2000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/SuperSandro2000" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/7258858?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">SuperSandro2000</span> </div></a> <a href="#discussioncomment-6366981" id="discussioncomment-6366981-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T20:14:42Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6366981/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6366981" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">From my experience contributing to projects hosted on external services is usually cumbersome because it requires extra account registration and small drive by contributions like link fixes are probably not being done anymore.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 21" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6366981" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>21</span> </button> <tool-tip id="tooltip-d7e5aec2-7851-4365-8787-984079e3fb10" for="discussion-upvote-button-DiscussionComment-6366981" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-4a4713" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>9</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>9</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 8 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6366981"> <div data-view-component="true" class="TimelineItem TimelineItem--condensed discussion-nested-comment-paging-form pt-0 ml-0"> <div style="background-color: transparent; left: 30px;" data-view-component="true" class="TimelineItem-badge discussion-nested-comment-paging-badge pb-3 mt-0 pt-4"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body discussion-nested-comment-paging-form-body"> </option></form><form data-replace-remote-form-target="child-comments-discussioncomment-6366981" data-replace-remote-form="true" data-turbo="false" action="/golang/go/discussions/61182/comments/6366981/threads" accept-charset="UTF-8" method="get"> <input type="hidden" name="back_page" value="1"> <input type="hidden" name="forward_page" value="0"> <input type="hidden" name="anchor_id" value="6367377"> <button data-disable-with="Loading more replies..." type="submit" data-view-component="true" class="Button--link Button--medium Button mb-2 pl-2 pt-2"> <span class="Button-content"> <span class="Button-label">Show 3 previous replies</span> </span> </button> </form></div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367377,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="69cc9919337ff8bfbbb9e070515e793d5e23dd38a9148bf6212c868f8ae1e468" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6367377" data-gid="DC_kwDOAWBuf84AYSiR" data-url="/golang/go/discussions/61182/comments/6367377" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="4c9f1381ea0baf3b9e8d4bbc7afbc9fc5e8424af9f453e617af5b169695a2764" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367377-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367377-list" aria-labelledby="tooltip-da8e6fd0-8a27-40ce-8298-1086c45683fa" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-da8e6fd0-8a27-40ce-8298-1086c45683fa" for="Comment-actions-6367377-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367377-list" role="menu" aria-labelledby="Comment-actions-6367377-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367377/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367377" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367377,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="69cc9919337ff8bfbbb9e070515e793d5e23dd38a9148bf6212c868f8ae1e468" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6367377" id="discussioncomment-6367377-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T20:48:36Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367377/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367377" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mooijtech/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mooijtech">@mooijtech</a>, “using GitHub for everything” was considered (and declined) in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="259350017" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/21956" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/21956/hovercard" href="https://github.com/golang/go/issues/21956">#21956</a>.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-11294f" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-a18452" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367902,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6a33f980481a2b9f63f566c32cb6c413c3a83684a15190c61e7ee1fd1d0002f9" data-hovercard-type="user" data-hovercard-url="/users/matys1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/matys1"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/99846054?s=60&v=4" width="30" height="30" alt="@matys1" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6367902" data-gid="DC_kwDOAWBuf84AYSqe" data-url="/golang/go/discussions/61182/comments/6367902" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="2c14d7be4900e8d106dc9b88ded36a1f90752820f71a1604a945befba6442fdf" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367902-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367902-list" aria-labelledby="tooltip-09ad5b29-c67e-4d03-b27e-3058d17b60ed" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-09ad5b29-c67e-4d03-b27e-3058d17b60ed" for="Comment-actions-6367902-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367902-list" role="menu" aria-labelledby="Comment-actions-6367902-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367902/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367902" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367902,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6a33f980481a2b9f63f566c32cb6c413c3a83684a15190c61e7ee1fd1d0002f9" data-hovercard-type="user" data-hovercard-url="/users/matys1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/matys1" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">matys1</a> <a href="#discussioncomment-6367902" id="discussioncomment-6367902-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T22:12:02Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367902/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367902" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/bcmills">@bcmills</a> that proposal had a lot of upvotes. Why was it declined? This is the opposite of that.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-eec904" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368010,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="3968dd706bb32e282dee082b2a8e945fea9bced9a397a97dbcacb35eed09673b" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6368010" data-gid="DC_kwDOAWBuf84AYSsK" data-url="/golang/go/discussions/61182/comments/6368010" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="3d3c39c484e964a13b2e2b1fa39090ddd9cafa4cf7a5c1305ef098b5d1c0c0ac" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6368010-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6368010-list" aria-labelledby="tooltip-482c5ee3-97f9-4bf8-9132-78ee8780f858" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-482c5ee3-97f9-4bf8-9132-78ee8780f858" for="Comment-actions-6368010-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6368010-list" role="menu" aria-labelledby="Comment-actions-6368010-text"> <include-fragment src="/golang/go/discussions/61182/comments/6368010/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6368010" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368010,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="3968dd706bb32e282dee082b2a8e945fea9bced9a397a97dbcacb35eed09673b" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6368010" id="discussioncomment-6368010-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T22:33:57Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6368010/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6368010" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/matys1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/matys1">@matys1</a>, you can read the discussion on that proposal for the details. 😅</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-84719d" value="LAUGH react" data-button-index-position="2" data-reaction-label="Laugh" data-reaction-content="smile" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="smile" fallback-src="https://github.githubassets.com/assets/1f604-7528822fb4c5.png" class="social-button-emoji">😄</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-aaea04" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>3</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="smile"> <g-emoji alias="smile" fallback-src="https://github.githubassets.com/assets/1f604-7528822fb4c5.png" class="social-button-emoji">😄</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>3</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374829,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="67159e4bae3139fbf0d259adcfdd3ef8fb526081f86afec180979d37b39668c5" data-hovercard-type="user" data-hovercard-url="/users/SuperSandro2000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/SuperSandro2000"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/7258858?s=60&v=4" width="30" height="30" alt="@SuperSandro2000" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6374829" data-gid="DC_kwDOAWBuf84AYUWt" data-url="/golang/go/discussions/61182/comments/6374829" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="4e6e37a7a6202ab5cd7e814c61c2ec950d672039c0e5334293c4257ceae0562b" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6374829-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6374829-list" aria-labelledby="tooltip-b405c8af-4eed-44f2-951b-6111124242ca" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-b405c8af-4eed-44f2-951b-6111124242ca" for="Comment-actions-6374829-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6374829-list" role="menu" aria-labelledby="Comment-actions-6374829-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374829/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6374829" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374829,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="67159e4bae3139fbf0d259adcfdd3ef8fb526081f86afec180979d37b39668c5" data-hovercard-type="user" data-hovercard-url="/users/SuperSandro2000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/SuperSandro2000" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">SuperSandro2000</a> <a href="#discussioncomment-6374829" id="discussioncomment-6374829-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T14:14:49Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6374829/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6374829" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <blockquote> <p dir="auto">While that is true, the Go repos are already hosted on external services: <a href="https://go.googlesource.com/" rel="nofollow">go.googlesource.com</a> is the source of truth and all GitHub PRs end up going through Gerrit for review.</p> </blockquote> <p dir="auto">For which you need to have a google account, so for the sake of simplicity I am using my private account for work contributions otherwise I would probably still be in the process to get an account to fix a link.</p> <p dir="auto">Also that the mailing list requires a google account is also a big bummer. I am currently relaying the mails from my private google account otherwise I couldn't receive the security update announcements.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-d7b530" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6375723,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0a664fa106109035f728c562b1d1b5138186ceab97990488bf8895f583f1095e" data-hovercard-type="user" data-hovercard-url="/users/Merovius/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Merovius"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/720787?s=60&v=4" width="30" height="30" alt="@Merovius" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6375723" data-gid="DC_kwDOAWBuf84AYUkr" data-url="/golang/go/discussions/61182/comments/6375723" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="0e8b070ab541a9af18190095cd2f72c4a279bd9344d7cb4c4a87267120e26035" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6375723-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6375723-list" aria-labelledby="tooltip-853124db-09e8-4ba4-bd82-917a3d0a9f6c" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-853124db-09e8-4ba4-bd82-917a3d0a9f6c" for="Comment-actions-6375723-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6375723-list" role="menu" aria-labelledby="Comment-actions-6375723-text"> <include-fragment src="/golang/go/discussions/61182/comments/6375723/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6375723" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6375723-list" aria-expanded="false" id="discussion-edit-history-6375723-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6375723-list" role="menu" aria-labelledby="discussion-edit-history-6375723-text"> <include-fragment src="/golang/go/discussions/61182/comments/6375723/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6375723,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0a664fa106109035f728c562b1d1b5138186ceab97990488bf8895f583f1095e" data-hovercard-type="user" data-hovercard-url="/users/Merovius/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Merovius" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">Merovius</a> <a href="#discussioncomment-6375723" id="discussioncomment-6375723-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T15:42:50Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6375723/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6375723" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/SuperSandro2000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/SuperSandro2000">@SuperSandro2000</a></p> <blockquote> <p dir="auto">Also that the mailing list requires a google account is also a big bummer.</p> </blockquote> <p dir="auto"><del><a href="https://support.google.com/groups/answer/1067205" rel="nofollow">That is not true</a> (last paragraph).</del> Wait, that didn't <em>use</em> to be true. You used to be able to subscribe to groups without a gmail account. I'm surprised.</p> <p dir="auto">FWIW, there are people who feel the same about GitHub. That is, there are people who repeatedly complain about not being able to participate in discussions without a GitHub account.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-32f88f" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYShp" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6367337" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="8d489afde8d46071c5e0e683f55620e4e8cbd632b464063650510b85fad558fe" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367337-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367337-list" aria-labelledby="tooltip-e7f83e0d-e935-4e8a-86ff-ce2dd7d32fcf" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-e7f83e0d-e935-4e8a-86ff-ce2dd7d32fcf" for="Comment-actions-6367337-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367337-list" role="menu" aria-labelledby="Comment-actions-6367337-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367337/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367337" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367337,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="c57ad51d9d6837dd60bb42df11f9eaa1b853b71f2544d8f6955152c44f8e34ac" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/3576549?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">mvdan</span> </div></a> <a href="#discussioncomment-6367337" id="discussioncomment-6367337-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T20:43:56Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a collaborator on this repository." data-view-component="true" class="Label py-0 ml-1"> Collaborator </span> </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367337/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367337" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">One data point from another project: we also use Gerrit in the CUE project, and we also allow GitHub PRs for convenience, but in a slightly different way to what Go does currently. We do the code review and CI on the GitHub side, and manually import to Gerrit only when a PR is approved and ready to be merged.</p> <p dir="auto">This approach is still far from perfect, but we think it works a bit better for PR contributors, since their workflow remains pretty natural. The only difference is that we can't and won't merge the PR directly, since the GitHub repository is simply a mirror from Gerrit.</p> <p dir="auto">On our side it's a little bit more work, since we effectively review code on two platforms, even if Gerrit is the primary one. However, most of us are already used to doing reviews on GitHub, even with its shortcomings. And one could argue that we save work by not having to maintain any form of server or bot to make this all happen; we simply have an <code class="notranslate">importpr</code> command when a PR is ready to be imported and merged.</p> <p dir="auto">It's worth noting that using Gerrit directly is still best in most cases, particularly when someone wants to contribute a big or complex change, or when someone wants to contribute regularly. For those cases, we still kindly ask the person to learn the Gerrit route, and I think that's fine.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 14" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6367337" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>14</span> </button> <tool-tip id="tooltip-4bce4d4e-b84c-46d8-96af-1388a41cbc84" for="discussion-upvote-button-DiscussionComment-6367337" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-d6a7f6" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>20</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>20</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 6 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6367337"> <div data-view-component="true" class="TimelineItem TimelineItem--condensed discussion-nested-comment-paging-form pt-0 ml-0"> <div style="background-color: transparent; left: 30px;" data-view-component="true" class="TimelineItem-badge discussion-nested-comment-paging-badge pb-3 mt-0 pt-4"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg></div> <div data-view-component="true" class="TimelineItem-body discussion-nested-comment-paging-form-body"> </option></form><form data-replace-remote-form-target="child-comments-discussioncomment-6367337" data-replace-remote-form="true" data-turbo="false" action="/golang/go/discussions/61182/comments/6367337/threads" accept-charset="UTF-8" method="get"> <input type="hidden" name="back_page" value="1"> <input type="hidden" name="forward_page" value="0"> <input type="hidden" name="anchor_id" value="6367496"> <button data-disable-with="Loading more replies..." type="submit" data-view-component="true" class="Button--link Button--medium Button mb-2 pl-2 pt-2"> <span class="Button-content"> <span class="Button-label">Show 1 previous reply</span> </span> </button> </form></div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367496,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="02a933323a1403626fe7ae1aecc84f8cb82b4bc997dc494944426bc883979dc4" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3576549?s=60&v=4" width="30" height="30" alt="@mvdan" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6367496" data-gid="DC_kwDOAWBuf84AYSkI" data-url="/golang/go/discussions/61182/comments/6367496" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="0d12ca59bd74db7235aaa12ccbc142f1489e7acca9d1134c7927cb6059e0f063" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367496-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367496-list" aria-labelledby="tooltip-e5fffb13-ce43-4502-85c4-439560cad5f9" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-e5fffb13-ce43-4502-85c4-439560cad5f9" for="Comment-actions-6367496-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367496-list" role="menu" aria-labelledby="Comment-actions-6367496-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367496/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367496" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367496,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="02a933323a1403626fe7ae1aecc84f8cb82b4bc997dc494944426bc883979dc4" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">mvdan</a> <a href="#discussioncomment-6367496" id="discussioncomment-6367496-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T21:03:04Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a collaborator on this repository." data-view-component="true" class="Label py-0 ml-1"> Collaborator </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367496/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367496" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">I should clarify that we don't guarantee to be able to accept any change as a PR. For example, if a PR is opened with changes to the core evaluator, whose maintainer is Marcel, we'll likely have to ask them to reopen on Gerrit instead since he can't really do code reviews on GitHub. At least from the experience we've had in the past couple of years, most of the PRs we do get we are able to review on GitHub, since they tend to be on the small side and most of the reviewers are capable enough with the platform.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-0e4607" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374751,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="5d5d64d3ae62e283df7c58e63438a7a4bebf59d0b2f4b801374b99482412c1f8" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3576549?s=60&v=4" width="30" height="30" alt="@mvdan" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6374751" data-gid="DC_kwDOAWBuf84AYUVf" data-url="/golang/go/discussions/61182/comments/6374751" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="9f3a047d6f4c5ffbd476108bbefb68e01fdbee151c3c9b5b6d6ef12c73b7a4ba" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6374751-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6374751-list" aria-labelledby="tooltip-35fa9782-b4d7-41ec-939b-7a566c3c869e" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-35fa9782-b4d7-41ec-939b-7a566c3c869e" for="Comment-actions-6374751-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6374751-list" role="menu" aria-labelledby="Comment-actions-6374751-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374751/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6374751" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6374751-list" aria-expanded="false" id="discussion-edit-history-6374751-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6374751-list" role="menu" aria-labelledby="discussion-edit-history-6374751-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374751/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374751,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="5d5d64d3ae62e283df7c58e63438a7a4bebf59d0b2f4b801374b99482412c1f8" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">mvdan</a> <a href="#discussioncomment-6374751" id="discussioncomment-6374751-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T14:07:55Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a collaborator on this repository." data-view-component="true" class="Label py-0 ml-1"> Collaborator </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6374751/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6374751" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Having slept on it, I think CUE's approach wouldn't work for Go given how the existing experienced reviewers are not used to GitHub at all, and given how the project needs more maintainers and reviewers than it needs new contributors and drive-by patches.</p> <p dir="auto">I also have no love for the mirror bot for the reasons that Bryan outlined, to be clear. As a middle ground, it often makes neither kind of user (GitHub or Gerrit) happy.</p> <p dir="auto">That said, the project should realize that such a tradeoff (prioritizing existing maintainers over new contributors by only using Gerrit) is not a great situation for the long-term health of the project. As much as Gerrit is in many ways a much nicer and more powerful review tool, the truth is that most developers today are already familiar with GitHub and prefer its native review process. Assuming that we want to lower the barrier for new contributors to come in and eventually become maintainers, this proposal would discourage that.</p> <p dir="auto">Clearly it's less work for the existing maintainers and reviewers to only worry about Gerrit, but it's also less likely that that set of people will grow with the project over time if we insist on a tool that is a barrier for some contributors. Ideally, we would "just" make Gerrit more approachable to new users, but for that I think you might need a UI/UX rethink, or at least some kind of interactive tutorial to learn all the new concepts and web UI buttons :)</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-0cb219" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </button> <button name="input[content]" id="reactions--reaction_button_component-83d671" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>2</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>2</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6376520,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="00f4b6a4203e766604e72bf35c198538bd99e0b1157598eafb639a59fd87423c" data-hovercard-type="user" data-hovercard-url="/users/seankhliao/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/seankhliao"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/11343221?s=60&v=4" width="30" height="30" alt="@seankhliao" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6376520" data-gid="DC_kwDOAWBuf84AYUxI" data-url="/golang/go/discussions/61182/comments/6376520" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="8c20cd783b9afe0bbb4780819229e48f93c3cb73b4732010ee3f53ae2e16301d" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6376520-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6376520-list" aria-labelledby="tooltip-7f9d49e5-388f-4a6f-a06f-7a8e0e788147" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-7f9d49e5-388f-4a6f-a06f-7a8e0e788147" for="Comment-actions-6376520-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6376520-list" role="menu" aria-labelledby="Comment-actions-6376520-text"> <include-fragment src="/golang/go/discussions/61182/comments/6376520/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6376520" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6376520,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="00f4b6a4203e766604e72bf35c198538bd99e0b1157598eafb639a59fd87423c" data-hovercard-type="user" data-hovercard-url="/users/seankhliao/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/seankhliao" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">seankhliao</a> <a href="#discussioncomment-6376520" id="discussioncomment-6376520-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T17:07:39Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a collaborator on this repository." data-view-component="true" class="Label py-0 ml-1"> Collaborator </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6376520/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6376520" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">For long term health, I think the focus on new contributors feels off. Rather, the process for someone to go from writing to reviewing code is unclear, in terms of process, etiquette, and benefits/responsibilities.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-e1105d" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </button> <button name="input[content]" id="reactions--reaction_button_component-5f049b" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6378104,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e92446a8ae0a6d4a02104567028a986d65db86b9e8cd31c87ce4508b69a2b6d2" data-hovercard-type="user" data-hovercard-url="/users/benhoyt/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/benhoyt"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/999033?s=60&v=4" width="30" height="30" alt="@benhoyt" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6378104" data-gid="DC_kwDOAWBuf84AYVJ4" data-url="/golang/go/discussions/61182/comments/6378104" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="c39106b1db7415dba4a3e7ad9116a1e752111792a1fca2848eefe00b03c04a96" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6378104-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6378104-list" aria-labelledby="tooltip-73441a60-48f7-4cc2-b32b-e264950ab62f" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-73441a60-48f7-4cc2-b32b-e264950ab62f" for="Comment-actions-6378104-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6378104-list" role="menu" aria-labelledby="Comment-actions-6378104-text"> <include-fragment src="/golang/go/discussions/61182/comments/6378104/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6378104" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6378104,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e92446a8ae0a6d4a02104567028a986d65db86b9e8cd31c87ce4508b69a2b6d2" data-hovercard-type="user" data-hovercard-url="/users/benhoyt/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/benhoyt" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">benhoyt</a> <a href="#discussioncomment-6378104" id="discussioncomment-6378104-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T20:43:33Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6378104/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6378104" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <blockquote> <p dir="auto">We should have just one, and for a variety of very good reasons, that one is Gerrit.</p> </blockquote> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rsc/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rsc">@rsc</a> Can you list those reasons for the benefit of others reading the thread? Is it because they're at Google and have to use Gerrit anyway? Or because Gerrit is better at handling "stacked changed" (changes that build on other, unmerged changes)? Or something else?</p> <p dir="auto">In any case, I'm an occasional contributor -- I've only used the Gerrit method, because I'm allergic to two-way syncs. Though learning the Gerrit method was slightly annoying, <code class="notranslate">git codereview change</code> and <code class="notranslate">git codereview mail</code> isn't exactly <em>hard</em>. I'd much prefer the Go project optimized for the workflow of the team that's contributing the big changes to Go, day-in, day-out. Just Gerrit is fine with me if it makes the Go team happy!</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6379614,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="2dfa2613e3a42dc3ac9ac8ae1049f46c0287962d26439bae052a385e5531559c" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3194333?s=60&v=4" width="30" height="30" alt="@ianlancetaylor" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6379614" data-gid="DC_kwDOAWBuf84AYVhe" data-url="/golang/go/discussions/61182/comments/6379614" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="c17dd88df94413136a1c0e5b6d343835e51b7ea0b421e93b965efd6262682d51" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6379614-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6379614-list" aria-labelledby="tooltip-176c769d-51b1-406d-9b34-6a0c5e98f6ee" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-176c769d-51b1-406d-9b34-6a0c5e98f6ee" for="Comment-actions-6379614-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6379614-list" role="menu" aria-labelledby="Comment-actions-6379614-text"> <include-fragment src="/golang/go/discussions/61182/comments/6379614/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6379614" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6379614,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="2dfa2613e3a42dc3ac9ac8ae1049f46c0287962d26439bae052a385e5531559c" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ianlancetaylor</a> <a href="#discussioncomment-6379614" id="discussioncomment-6379614-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T02:03:05Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6379614/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6379614" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">A few advantages that come to mind: Gerrit is good at supporting line-by-line code reviews, and tracks for each comment whether it has been addressed or not (our auto-submit bot won't submit a change with unresolved comments). Gerrit maintains an "attention set" for who should look at the change next. Gerrit provides dashboards of changes that need review by different people. It's also true, as you say, that Gerrit does a good job of handling stacked changes.</p> <p dir="auto">We also have a lot of machinery built around Gerrit, like the builders and auto-submit.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-1e51e5" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>5</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>5</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYSlN" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6367565" data-gid="DC_kwDOAWBuf84AYSlN" data-url="/golang/go/discussions/61182/comments/6367565" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="00d88e478f262b6dfdf47ef3b7f7474241fe46f0c9627205dd10133cb8ebafd6" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367565-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367565-list" aria-labelledby="tooltip-c3e08d0c-4fde-4369-a074-2e41763fcbc0" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-c3e08d0c-4fde-4369-a074-2e41763fcbc0" for="Comment-actions-6367565-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367565-list" role="menu" aria-labelledby="Comment-actions-6367565-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367565/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367565" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367565,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4a25563da42945f0348b4e8d94f48adeaab83061eb6db3699805a8cb030b6e5f" data-hovercard-type="user" data-hovercard-url="/users/Jacalz/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Jacalz" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/25466657?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">Jacalz</span> </div></a> <a href="#discussioncomment-6367565" id="discussioncomment-6367565-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T21:14:21Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367565/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367565" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I contributed my first (and currently only) change to the Go project through GitHub a few years back when I was a relatively fresh developer. There were definitely a few quirks with the workflow and I remember having various issues getting titles and commit messages updated but it turned out well in the end.</p> <p dir="auto">In hindsight, I don't think I would have considered contributing if it wasn't already possible though a service like GitHub where I already felt confident in the tooling. Even to this day I feel similarly about various other projects that are not on GitHub or GitLab (especially using mailing lists, phabicator, etc.) because the step up in learning might not be worth it if I don't want (or have the time) to become a regular contributor. That being said, I could consider contributing through Gerrit in the future because I already have some minor knowledge of how it works from last time (and I care about the project enough).</p> <p dir="auto">Removing the support for importing PRs from GitHub would likely result in less new developers contributing to the project. There do however seem to be a vast majority of problems with how it is currently done and I believe that the best solution would be to improve the PR workflow through GitHub, if possible. If not, I would not personally be against removing the support as the current cons seem to outweigh the pros in many ways.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 9" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6367565" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>9</span> </button> <tool-tip id="tooltip-4e8d7004-eff2-471f-95ca-c32a4000785c" for="discussion-upvote-button-DiscussionComment-6367565" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-479daa" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </button> <button name="input[content]" id="reactions--reaction_button_component-98dd62" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>9</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>9</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 0 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker" data-child-comments id="child-comments-discussioncomment-6367565"> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYSlr" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6367595" data-gid="DC_kwDOAWBuf84AYSlr" data-url="/golang/go/discussions/61182/comments/6367595" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="5d94a787372ed9e8646524bc8739fc7f798ad4a8fad677803ba7cd8fdc8a06ba" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367595-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367595-list" aria-labelledby="tooltip-0d8c0a31-ed2b-4772-bb5e-dd122768ac9a" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-0d8c0a31-ed2b-4772-bb5e-dd122768ac9a" for="Comment-actions-6367595-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367595-list" role="menu" aria-labelledby="Comment-actions-6367595-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367595/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367595" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367595,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="1f7287bde5bcc74ebbee0d864320d380c183f0651cd269b9896c4593602b5c82" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/1293187?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">prattmic</span> </div></a> <a href="#discussioncomment-6367595" id="discussioncomment-6367595-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T21:18:26Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367595/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367595" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I think it would be nice to have some measurement of the review friction mentioned above; "a large fraction of code reviews for GitHub PRs require multiple rounds of comments of the form “please mark comments as resolved in Gerrit if they have been addressed”", etc.</p> <p dir="auto">I started such an analysis tool in <a href="https://go.dev/cl/507907" rel="nofollow">https://go.dev/cl/507907</a>, which could be extended to look at how many back-and-forth comments GitHub pull requests have.</p> <p dir="auto">As I put this together quickly, I only looked at the proportion of merged CLs, which is indeed lower with GitHub, even for "new" contributors:</p> <div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="2023/07/05 17:11:26 GitHub: 2023/07/05 17:11:26 Total: 1277 2023/07/05 17:11:26 Merged: 438 (34.299139%) 2023/07/05 17:11:26 Native: 2023/07/05 17:11:26 Total: 8671 2023/07/05 17:11:26 Merged: 6783 (78.226271%) 2023/07/05 17:11:26 GitHub (<20 contributions): 2023/07/05 17:11:26 Total: 1094 2023/07/05 17:11:26 Merged: 333 (30.438757%) 2023/07/05 17:11:26 Native (<20 contributions): 2023/07/05 17:11:26 Total: 1148 2023/07/05 17:11:26 Merged: 658 (57.317073%)"><pre class="notranslate"><code class="notranslate">2023/07/05 17:11:26 GitHub: 2023/07/05 17:11:26 Total: 1277 2023/07/05 17:11:26 Merged: 438 (34.299139%) 2023/07/05 17:11:26 Native: 2023/07/05 17:11:26 Total: 8671 2023/07/05 17:11:26 Merged: 6783 (78.226271%) 2023/07/05 17:11:26 GitHub (<20 contributions): 2023/07/05 17:11:26 Total: 1094 2023/07/05 17:11:26 Merged: 333 (30.438757%) 2023/07/05 17:11:26 Native (<20 contributions): 2023/07/05 17:11:26 Total: 1148 2023/07/05 17:11:26 Merged: 658 (57.317073%) </code></pre></div> <p dir="auto">(This tool suspiciously "finished" fetching at exactly 10000 CLs, so I think I hit a Gerrit limit rather than actually analyzing all CLs).</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 5" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6367595" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>5</span> </button> <tool-tip id="tooltip-1e84778c-44d5-4a26-b632-9582328b797b" for="discussion-upvote-button-DiscussionComment-6367595" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-2cec96" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>2</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>2</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 3 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6367595"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367605,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="56836c0e8a4a0aa33049a2d44c0d8d3f4ecfdfa2679ce3351efe287e291f20cb" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/1293187?s=60&v=4" width="30" height="30" alt="@prattmic" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6367605" data-gid="DC_kwDOAWBuf84AYSl1" data-url="/golang/go/discussions/61182/comments/6367605" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="ac5088cc59bc8ebb0e020beaf7a8d1004260fe6252bdb7d6bb94272736b83201" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367605-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367605-list" aria-labelledby="tooltip-14ab89d6-abdd-4a95-942f-a747b08b3cf8" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-14ab89d6-abdd-4a95-942f-a747b08b3cf8" for="Comment-actions-6367605-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367605-list" role="menu" aria-labelledby="Comment-actions-6367605-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367605/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367605" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367605,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="56836c0e8a4a0aa33049a2d44c0d8d3f4ecfdfa2679ce3351efe287e291f20cb" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">prattmic</a> <a href="#discussioncomment-6367605" id="discussioncomment-6367605-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T21:20:35Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367605/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367605" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">On the other hand, this data shows that nearly 50% of CLs from "new" contributors are coming from GitHub, and ~33% of merged "new" contributor CLs.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-405cc2" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367620,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="faf12cdba1c42333cea923d5fd356e1f112cd58cbd60794f18eb7bb52e62f27f" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6367620" data-gid="DC_kwDOAWBuf84AYSmE" data-url="/golang/go/discussions/61182/comments/6367620" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="8e1fc145202415d2bb9c62345cd1cbde38632b046a8aa522ad436cb39de698ba" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367620-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367620-list" aria-labelledby="tooltip-0752b878-cf2d-4109-9430-cdb5be1c38c8" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-0752b878-cf2d-4109-9430-cdb5be1c38c8" for="Comment-actions-6367620-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367620-list" role="menu" aria-labelledby="Comment-actions-6367620-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367620/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367620" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367620,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="faf12cdba1c42333cea923d5fd356e1f112cd58cbd60794f18eb7bb52e62f27f" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6367620" id="discussioncomment-6367620-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T21:24:21Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367620/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367620" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Yep, but that also doesn't tell us what would have happened without GitHub import — we unfortunately can't measure what fraction of those contributor CLs would have been sent directly through Gerrit vs. not sent at all.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-950485" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6377925,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0a5926c7c78629b79577f66d42d8584b6571e405686c86e80a12f6264eb0d401" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3194333?s=60&v=4" width="30" height="30" alt="@ianlancetaylor" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6377925" data-gid="DC_kwDOAWBuf84AYVHF" data-url="/golang/go/discussions/61182/comments/6377925" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="5907d27e7b743cdaff9decc4de71842350d5f270160497459fef6c0cbda59fac" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6377925-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6377925-list" aria-labelledby="tooltip-9cf472d1-657c-4425-b15c-cc9b658bd9fa" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-9cf472d1-657c-4425-b15c-cc9b658bd9fa" for="Comment-actions-6377925-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6377925-list" role="menu" aria-labelledby="Comment-actions-6377925-text"> <include-fragment src="/golang/go/discussions/61182/comments/6377925/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6377925" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6377925,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0a5926c7c78629b79577f66d42d8584b6571e405686c86e80a12f6264eb0d401" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ianlancetaylor</a> <a href="#discussioncomment-6377925" id="discussioncomment-6377925-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T20:14:32Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6377925/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6377925" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">We can see how many CLs were contributed before the Gerritbot was added compared to after. Of course the community grows over time, but perhaps we can adjust for that.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-5ec0f7" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYSpl" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6367845" data-gid="DC_kwDOAWBuf84AYSpl" data-url="/golang/go/discussions/61182/comments/6367845" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="9a57221642f71c0a0f33fc8eff7908007801b9100f480f81277d4e46bcafb8a4" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6367845-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6367845-list" aria-labelledby="tooltip-46655e2d-2202-4f58-9498-aade31c33d97" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-46655e2d-2202-4f58-9498-aade31c33d97" for="Comment-actions-6367845-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6367845-list" role="menu" aria-labelledby="Comment-actions-6367845-text"> <include-fragment src="/golang/go/discussions/61182/comments/6367845/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6367845" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6367845,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e514cb4f9b913be48d16eb7d491d8e20a6bcb8291cfe2fd0d9bd849465401c2b" data-hovercard-type="user" data-hovercard-url="/users/deefdragon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/deefdragon" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/3053654?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">deefdragon</span> </div></a> <a href="#discussioncomment-6367845" id="discussioncomment-6367845-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T22:00:38Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6367845/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6367845" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">In another thread, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/bcmills">@bcmills</a> referenced <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="259350017" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/21956" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/21956/hovercard" href="https://github.com/golang/go/issues/21956">#21956</a> "Just use github for everything" as declined. The issue however, was closed with</p> <blockquote> <p dir="auto">"This issue is too large and diverse to usefully tackle either of those proposals, so I am going to close this issue. Thanks for everyone's input.".</p> </blockquote> <p dir="auto">Not that it was declined. Just that it was off-track. (this was before the proposal processes)</p> <p dir="auto">Regarding that proposal, I think the amount of discussion that it received, and the number of people who 👍 it means that a large portion of people <em>would prefer using GitHub</em>. I suspect that still rings true today.</p> <p dir="auto">A key thing that was <em>supposed</em> to happen from that issue was the documentation of the key differences (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="260089341" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/22002" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/22002/hovercard" href="https://github.com/golang/go/issues/22002">#22002</a>) between gerrit and github and what the community wanted from its contributing/reviewing experience. That was ultimately closed due to the creation of the very bot of this discussion. I think <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="260089341" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/22002" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/22002/hovercard" href="https://github.com/golang/go/issues/22002">#22002</a> should be re-opened/recreated and done first, and <em>only then</em> a more general decision had regarding how to improve PRs and contributions in general (where using Github vs Gerrit vs both could be discussed). Should the discussion <em>there</em> decide that gerrit is the only solution, the bot can be removed. As it stands, I believe this discussion is suggesting a solution to a premature question.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 9" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6367845" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>9</span> </button> <tool-tip id="tooltip-4e20ce9d-255f-4516-811a-68ecde3573d7" for="discussion-upvote-button-DiscussionComment-6367845" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-ff57c0" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 3 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6367845"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368273,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="342bb4ba3ffcd5c9e33e2bc1effca51878e2f9ee23f36f69f1fe1f75c899867c" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6368273" data-gid="DC_kwDOAWBuf84AYSwR" data-url="/golang/go/discussions/61182/comments/6368273" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="3c1a7203914f49317b4a4079c02cbf76c5eccf67234a5a11057a11de2a7dff00" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6368273-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6368273-list" aria-labelledby="tooltip-08b1e553-f54e-4769-942c-b83c3bcaf64a" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-08b1e553-f54e-4769-942c-b83c3bcaf64a" for="Comment-actions-6368273-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6368273-list" role="menu" aria-labelledby="Comment-actions-6368273-text"> <include-fragment src="/golang/go/discussions/61182/comments/6368273/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6368273" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6368273,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="342bb4ba3ffcd5c9e33e2bc1effca51878e2f9ee23f36f69f1fe1f75c899867c" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6368273" id="discussioncomment-6368273-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-05T23:34:28Z" class="no-wrap">Jul 5, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6368273/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6368273" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Note that <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="260089341" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/22002" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/22002/hovercard" href="https://github.com/golang/go/issues/22002">#22002</a> was filed for the folks arguing for switching entirely to GitHub to assemble a plausible proposal for actually doing so. It was open and labeled <code class="notranslate">help wanted</code> for a little over a year with no apparent progress.</p> <p dir="auto">If you would like to pick up that work, you are welcome to collect the requested information and present a new proposal as described in that issue. However, I would expect that sort of migration to be much more labor-intensive than what is under consideration in this discussion — I don't agree that considering smaller-effort improvements to the status quo is “premature”.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11849572,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e38625e2f22afcc3a6cff483d808ab413961e6069a8ee157bb9490f3adba1ddd" data-hovercard-type="user" data-hovercard-url="/users/apparentlymart/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/apparentlymart"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/20180?s=60&v=4" width="30" height="30" alt="@apparentlymart" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-11849572" data-gid="DC_kwDOAWBuf84AtM9k" data-url="/golang/go/discussions/61182/comments/11849572" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="bba1aa8271b7295c967ce1074e6c4d4cde107123b88744449a2fad48df48115f" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-11849572-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-11849572-list" aria-labelledby="tooltip-06fae945-a423-4ad8-8148-5818a735b2cd" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-06fae945-a423-4ad8-8148-5818a735b2cd" for="Comment-actions-11849572-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-11849572-list" role="menu" aria-labelledby="Comment-actions-11849572-text"> <include-fragment src="/golang/go/discussions/61182/comments/11849572/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F11849572" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11849572,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e38625e2f22afcc3a6cff483d808ab413961e6069a8ee157bb9490f3adba1ddd" data-hovercard-type="user" data-hovercard-url="/users/apparentlymart/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/apparentlymart" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">apparentlymart</a> <a href="#discussioncomment-11849572" id="discussioncomment-11849572-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2025-01-16T02:01:52Z" class="no-wrap">Jan 16, 2025</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/11849572/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="11849572" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">The text of that issue seems unclear as to what exactly was expected to happen and who was expected to do it. At the time I'm writing this, it opens with three bullet points which I'm going to reinterpret as an ordered list just so I can refer to the items by number:</p> <blockquote> <ol dir="auto"> <li>Draft a feature comparison between Gerrit and GitHub with input from golang-dev@ as to what features are keeping the project off of GitHub for Code Review.</li> <li>Present a proposal that addresses the concerns raised by the members of the development team where you explain how these issues will be solved either by presenting a (very) convincing argument that they don’t really matter, or proposing changes to existing tooling. Concrete data also helps you in this case. Rallying for GitHub to implement features is also not out of the question.</li> <li>Outline who will do the work and what the timeline is. If it’s the Go team at Google, explaining why it’s more important than the many other things on our plate is part of the process.</li> </ol> </blockquote> <p dir="auto">I would agree that item 2 is clearly something for a "GitHub for everything" advocate to do. However, item 1 needs to be completed in order to inform item 2, and item 1 requires knowing "what features are keeping the project off of GitHub for Code Review", which I think can be answered only by the folks who already know what Gerrit-exclusive features they are relying on.</p> <p dir="auto">I have a sense that item 1 was intended to mean "<em>someone</em> should start a thread on golang-dev@ to gather this information", and so I suppose it's valid to say that nobody did that, but nonetheless it seems like the main blocker is that only the folks who are currently enjoying Gerrit actually know what they enjoy about it, but that information doesn't seem to be recorded in any useful place. (Another thread in this discussion does have <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="5371795" data-permission-text="Title is private" data-url="https://github.com/golang/go/discussions/61182" data-hovercard-type="discussion" data-hovercard-url="/golang/go/discussions/61182/hovercard?comment_id=6379614" href="https://github.com/golang/go/discussions/61182#discussioncomment-6379614">#61182 (reply in thread)</a>, which contains a few hints.)</p> <p dir="auto">I don't personally have any strong opinion on this subject and so I'm not trying to convince anyone to do anything in particular, but I do think it's possible that this issue went nowhere because it wasn't even clear how to start working on it, rather than that nobody had interest in it. It could potentially be re-awakened if it were clearer that the intention was that <em>someone in the community</em> would do the documentation work for step 1, rather than something the Go team would do. (That's certainly how I read the "we" in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="259350017" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/21956" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/21956/hovercard?comment_id=331714165&comment_type=issue_comment" href="https://github.com/golang/go/issues/21956#issuecomment-331714165">#21956 (comment)</a>, given who wrote it, but I do agree that it's ambiguous in retrospect.)</p> <p dir="auto">Of course, it is still valid to question whether anyone in the community is actually sufficiently motivated to poll the golang-dev@ list for GitHub vs. Gerrit comparisons.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11850579,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="d8d0444b4811077f3d9a42123b8d8c95ad3e3943eea09f429a930d1ed22531f1" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3194333?s=60&v=4" width="30" height="30" alt="@ianlancetaylor" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-11850579" data-gid="DC_kwDOAWBuf84AtNNT" data-url="/golang/go/discussions/61182/comments/11850579" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="feab2b687ca33dbe03a907436d4315255fb52c8d53f205fd4fbee86e6108105c" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-11850579-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-11850579-list" aria-labelledby="tooltip-7d64c672-3ee6-4c2b-b952-bc824ca7d7d1" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-7d64c672-3ee6-4c2b-b952-bc824ca7d7d1" for="Comment-actions-11850579-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-11850579-list" role="menu" aria-labelledby="Comment-actions-11850579-text"> <include-fragment src="/golang/go/discussions/61182/comments/11850579/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F11850579" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11850579,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="d8d0444b4811077f3d9a42123b8d8c95ad3e3943eea09f429a930d1ed22531f1" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ianlancetaylor</a> <a href="#discussioncomment-11850579" id="discussioncomment-11850579-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2025-01-16T04:58:38Z" class="no-wrap">Jan 16, 2025</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/11850579/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="11850579" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Are people dissatisfied with the status quo? It seems to be working OK.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYTEd" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6369565" data-gid="DC_kwDOAWBuf84AYTEd" data-url="/golang/go/discussions/61182/comments/6369565" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="dd21a3bdbec669795f81ee8e9fb9a1a7a8f1eb476075561e409f3b79f4c57c96" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6369565-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6369565-list" aria-labelledby="tooltip-0b4de006-71d5-4683-a56d-93a9211b6c5c" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-0b4de006-71d5-4683-a56d-93a9211b6c5c" for="Comment-actions-6369565-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6369565-list" role="menu" aria-labelledby="Comment-actions-6369565-text"> <include-fragment src="/golang/go/discussions/61182/comments/6369565/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6369565" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6369565,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="c1ec56f9d507a5b1c09f674805f29a611c56930d32a428923fa53e7ade4de92e" data-hovercard-type="user" data-hovercard-url="/users/joeblubaugh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/joeblubaugh" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/1951900?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">joeblubaugh</span> </div></a> <a href="#discussioncomment-6369565" id="discussioncomment-6369565-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T04:07:59Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6369565/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6369565" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I strongly agree with using exactly one review tool. It's unfortunate for the project if the issue tracker is on Github and reviews are on another site, because linking between the two is inconvenient, labeling is harder to keep consistent. But I think the project has a few problems with that with the bidirectional synchronization already.</p> <p dir="auto">As a (rare) contributor, I think that the review comments I get via Gerrit are significantly better than in Github. They can be ordered as the reviewer desires, whereas Github comments are sorted by the order that they're added to the draft. Understanding the scope of the requested changes can be difficult in Github.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 1" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6369565" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>1</span> </button> <tool-tip id="tooltip-59f58c0c-09b1-4aa6-82b1-3fa966f5d477" for="discussion-upvote-button-DiscussionComment-6369565" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-050bf6" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-e2e525" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 0 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker" data-child-comments id="child-comments-discussioncomment-6369565"> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYTIl" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6369829" data-gid="DC_kwDOAWBuf84AYTIl" data-url="/golang/go/discussions/61182/comments/6369829" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="fab9abe9e9c19169b5fb2b192235dd5367c9ac0524c617b312d4c85206a27d1d" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6369829-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6369829-list" aria-labelledby="tooltip-f4c53005-823b-4780-905f-3680662af73c" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-f4c53005-823b-4780-905f-3680662af73c" for="Comment-actions-6369829-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6369829-list" role="menu" aria-labelledby="Comment-actions-6369829-text"> <include-fragment src="/golang/go/discussions/61182/comments/6369829/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6369829" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6369829,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="f5cb633b07188d640bf01d4800878825e2137d106d604d9b704ba3c4dfe785b4" data-hovercard-type="user" data-hovercard-url="/users/stefanmcshane/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/stefanmcshane" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/10238219?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">stefanmcshane</span> </div></a> <a href="#discussioncomment-6369829" id="discussioncomment-6369829-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T05:00:35Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6369829/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6369829" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">Whilst the vast majority of code on the Go ecosystem exists primarily on Github, it seems like the maintainers have a preference for the workflow of Gerrit.<br> Akin to what Ive said above, a lot of the points on Gerrit vs Github vs other potential future sources seem to be based on conjecture with no real data to back either up.</p> <p dir="auto">Instead of suggesting changes to the Gerritbot, workflow engine, or source of truth, would it not make more sense to <strong>poll for familiarity of the both tools, and make proposals based on those going forward?</strong></p> <p dir="auto">We take a similar approach to a lot of other changes to the language and ecosystem. I do not see why we would risk making the language “less approachable for new contributors”, “more difficult to manage for those already familiar with Gerrit”, or “require specific knowledge of GitHub/Gerrit/other tool” without data to baseline the conversation.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 4" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6369829" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>4</span> </button> <tool-tip id="tooltip-dce3e071-4290-442c-a1e3-5c6e05e4fbd6" for="discussion-upvote-button-DiscussionComment-6369829" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-32e5fa" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-190d44" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </button> <button name="input[content]" id="reactions--reaction_button_component-d02be6" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </li> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6369829"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385139,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="31cbb7a170d437ef95f4ef8bdfeba46534d541a52387e579c2fba3319d93e5a9" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6385139" data-gid="DC_kwDOAWBuf84AYW3z" data-url="/golang/go/discussions/61182/comments/6385139" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="1964ad73d98d332a7d271e9f1cc6687a6d203691a1a28449fbdba129e0b9f023" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6385139-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6385139-list" aria-labelledby="tooltip-bd9b06d1-3c62-49a2-a04f-60ee94897341" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-bd9b06d1-3c62-49a2-a04f-60ee94897341" for="Comment-actions-6385139-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6385139-list" role="menu" aria-labelledby="Comment-actions-6385139-text"> <include-fragment src="/golang/go/discussions/61182/comments/6385139/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6385139" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385139,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="31cbb7a170d437ef95f4ef8bdfeba46534d541a52387e579c2fba3319d93e5a9" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6385139" id="discussioncomment-6385139-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T14:14:13Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6385139/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6385139" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Poll whom? Existing contributors are necessarily going to be at least somewhat familiar with Gerrit, and there is no reliable way to identify people who have not yet contributed but would do so in the future.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYTJz" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6369907" data-gid="DC_kwDOAWBuf84AYTJz" data-url="/golang/go/discussions/61182/comments/6369907" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="992d18d65394a339e5d204d79ce101b80a4f1852fb16aaea5e45a97253771a96" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6369907-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6369907-list" aria-labelledby="tooltip-872dcc5f-a065-456f-9bb4-7a55733c236a" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-872dcc5f-a065-456f-9bb4-7a55733c236a" for="Comment-actions-6369907-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6369907-list" role="menu" aria-labelledby="Comment-actions-6369907-text"> <include-fragment src="/golang/go/discussions/61182/comments/6369907/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6369907" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6369907-list" aria-expanded="false" id="discussion-edit-history-6369907-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6369907-list" role="menu" aria-labelledby="discussion-edit-history-6369907-text"> <include-fragment src="/golang/go/discussions/61182/comments/6369907/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6369907,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="ebaa74335d0ef76614ac40e2aa5c6bc415dc274afad181ef64f405b6600373f0" data-hovercard-type="user" data-hovercard-url="/users/trim21/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/trim21" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/13553903?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">trim21</span> </div></a> <a href="#discussioncomment-6369907" id="discussioncomment-6369907-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T05:13:45Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6369907/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6369907" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">Push commit to github pr is still more convenient than <code class="notranslate">go-contrib-init</code> + <code class="notranslate">git codereview change</code> + <code class="notranslate">git codereview mail</code></p> <p dir="auto">to solve the data model mismatch problem, I think there is another solution.</p> <p dir="auto">Not to stop importing github PR totally, but stop 2 way sycning, and limit the usage of github PR.</p> <p dir="auto">Bot will still import code from github PR as replacement of <code class="notranslate">codereview change</code> and <code class="notranslate">codereview mail</code>.</p> <p dir="auto">And don't sync code review back to githuh PR, force contributors to use Gerrit for code review and discussion, only let bot add a comment with its gerrit link, and maybe, lock conversation of PR or just omit them.</p> <p dir="auto">github PR support check, so a bot can detect misused github features, for example, markdown description or not gofmt-ed source code, show a error in github PR check, and don't import them.</p> <p dir="auto">In this way, contributors are familiar with github but not Gerrit will only need to learn how to use gerrit web, which imo is easy. No need to learn go codereview cli, which imo is very hard to use.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 2" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6369907" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>2</span> </button> <tool-tip id="tooltip-98aa1ff2-d14c-4b1d-8043-eb19894df304" for="discussion-upvote-button-DiscussionComment-6369907" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-263acc" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </button> <button name="input[content]" id="reactions--reaction_button_component-90f5d2" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </li> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 4 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6369907"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374889,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="357985b7ed0e7cdde849781c1bf1ea28c504326c21c0cbd1de19a66de67b9231" data-hovercard-type="user" data-hovercard-url="/users/earthboundkid/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/earthboundkid"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/222245?s=60&v=4" width="30" height="30" alt="@earthboundkid" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6374889" data-gid="DC_kwDOAWBuf84AYUXp" data-url="/golang/go/discussions/61182/comments/6374889" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="a0f59d4c2149d65815b42fd942d877d0911c4f8153fbb3c9d9c93831ca594a21" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6374889-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6374889-list" aria-labelledby="tooltip-bb5e2656-452e-44f1-b55d-7543b88bd29e" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-bb5e2656-452e-44f1-b55d-7543b88bd29e" for="Comment-actions-6374889-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6374889-list" role="menu" aria-labelledby="Comment-actions-6374889-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374889/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6374889" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374889,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="357985b7ed0e7cdde849781c1bf1ea28c504326c21c0cbd1de19a66de67b9231" data-hovercard-type="user" data-hovercard-url="/users/earthboundkid/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/earthboundkid" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">earthboundkid</a> <a href="#discussioncomment-6374889" id="discussioncomment-6374889-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T14:21:54Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6374889/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6374889" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Yes. I'm an occasional contributor. I made one or two contributions before the Github bridge, but since then I've been doing it by opening a PR. I find it annoying to have to wait for the bot to sync commits to Gerrit and bounce back and forth, but overall, it's easier for me to open a Github PR than to figure out how to use Gerrit directly (since I'm in Github all day anyway), so I use the Github bridge. It probably wouldn't affect how much I contribute if the bridge went away, but as things stand now I prefer to use it.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-e7ecb9" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385070,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="846c08d4078c1068a192ee722ddb0f5df9105370c4753efe6bc42a2de413014e" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6385070" data-gid="DC_kwDOAWBuf84AYW2u" data-url="/golang/go/discussions/61182/comments/6385070" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="6839e22c642149e067414fab7c08fe44b9a07a54fce5c11b2505083fa977b3e4" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6385070-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6385070-list" aria-labelledby="tooltip-a8214964-a8f7-40a1-8462-7315ae87571d" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-a8214964-a8f7-40a1-8462-7315ae87571d" for="Comment-actions-6385070-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6385070-list" role="menu" aria-labelledby="Comment-actions-6385070-text"> <include-fragment src="/golang/go/discussions/61182/comments/6385070/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6385070" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385070,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="846c08d4078c1068a192ee722ddb0f5df9105370c4753efe6bc42a2de413014e" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6385070" id="discussioncomment-6385070-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T14:08:20Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6385070/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6385070" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <blockquote> <p dir="auto">In this way, contributors are familiar with github but not Gerrit will only need to learn how to use gerrit web, which imo is easy.</p> </blockquote> <p dir="auto">I don't see how this would reduce the need to learn the Gerrit git-codereview CLI. Wouldn't they still need to use it to push edits when they address comments anyway?</p> <p dir="auto">(<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="5371795" data-permission-text="Title is private" data-url="https://github.com/golang/go/discussions/61182" data-hovercard-type="discussion" data-hovercard-url="/golang/go/discussions/61182/hovercard?comment_id=6370289" href="https://github.com/golang/go/discussions/61182#discussioncomment-6370289">#61182 (comment)</a> is a similar thread.)</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6482896,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="53a629ec6501ef0fb5ef82636b2033ef07c6d35c7234ea0de69fcdf6aa21e4d7" data-hovercard-type="user" data-hovercard-url="/users/dolmen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dolmen"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/129536?s=60&v=4" width="30" height="30" alt="@dolmen" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6482896" data-gid="DC_kwDOAWBuf84AYuvQ" data-url="/golang/go/discussions/61182/comments/6482896" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="d9ff3c7573bc56d3ae138378864501f1bcdb5de2b5788cafc34d4abf942c12ec" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6482896-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6482896-list" aria-labelledby="tooltip-9a31e7f7-744d-4291-bd78-c015ffd434d6" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-9a31e7f7-744d-4291-bd78-c015ffd434d6" for="Comment-actions-6482896-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6482896-list" role="menu" aria-labelledby="Comment-actions-6482896-text"> <include-fragment src="/golang/go/discussions/61182/comments/6482896/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6482896" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6482896,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="53a629ec6501ef0fb5ef82636b2033ef07c6d35c7234ea0de69fcdf6aa21e4d7" data-hovercard-type="user" data-hovercard-url="/users/dolmen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dolmen" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">dolmen</a> <a href="#discussioncomment-6482896" id="discussioncomment-6482896-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-18T22:24:05Z" class="no-wrap">Jul 18, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6482896/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6482896" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><code class="notranslate">codereview change</code> adds a Change-Id header in the commit. The contributor would have to fetch the modified commit instead of just pushing more changes to his branch. I think that would be even more painful than starting directly with the <code class="notranslate">codereview</code> tool.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6483065,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e95ee60f01b045b18df46074ea1312a6883d1fbd9a6503037897923d00bb4fc4" data-hovercard-type="user" data-hovercard-url="/users/ncruces/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ncruces"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5637550?s=60&v=4" width="30" height="30" alt="@ncruces" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6483065" data-gid="DC_kwDOAWBuf84AYux5" data-url="/golang/go/discussions/61182/comments/6483065" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="24a604ac08a49eba656ee784c3f807b7f62bb5f17e08ff7a69783fd8dad33b84" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6483065-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6483065-list" aria-labelledby="tooltip-257c033f-9ec8-442d-a7eb-fe323cb0df00" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-257c033f-9ec8-442d-a7eb-fe323cb0df00" for="Comment-actions-6483065-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6483065-list" role="menu" aria-labelledby="Comment-actions-6483065-text"> <include-fragment src="/golang/go/discussions/61182/comments/6483065/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6483065" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6483065-list" aria-expanded="false" id="discussion-edit-history-6483065-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6483065-list" role="menu" aria-labelledby="discussion-edit-history-6483065-text"> <include-fragment src="/golang/go/discussions/61182/comments/6483065/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6483065,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="e95ee60f01b045b18df46074ea1312a6883d1fbd9a6503037897923d00bb4fc4" data-hovercard-type="user" data-hovercard-url="/users/ncruces/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ncruces" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ncruces</a> <a href="#discussioncomment-6483065" id="discussioncomment-6483065-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-18T23:06:54Z" class="no-wrap">Jul 18, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6483065/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6483065" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Not sure I understand this thread.</p> <p dir="auto">My contributions to Go have required back and forth, and I never used the git-codereview CLI. I push additional commits to the PR branch and they're imported into Gerrit. Example <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1659290186" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/59489" data-hovercard-type="pull_request" data-hovercard-url="/golang/go/pull/59489/hovercard" href="https://github.com/golang/go/pull/59489">#59489</a>.</p> <p dir="auto">Comments have mostly happened on Gerrit web, not PRs.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYTPx" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6370289" data-gid="DC_kwDOAWBuf84AYTPx" data-url="/golang/go/discussions/61182/comments/6370289" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="f955b1f89fbf5622386b6d90a27f353107fc1e364c1e0c0dd9a5f26d2c12875f" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6370289-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6370289-list" aria-labelledby="tooltip-14175ed5-a973-4052-9505-c0363202370b" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-14175ed5-a973-4052-9505-c0363202370b" for="Comment-actions-6370289-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6370289-list" role="menu" aria-labelledby="Comment-actions-6370289-text"> <include-fragment src="/golang/go/discussions/61182/comments/6370289/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6370289" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6370289-list" aria-expanded="false" id="discussion-edit-history-6370289-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6370289-list" role="menu" aria-labelledby="discussion-edit-history-6370289-text"> <include-fragment src="/golang/go/discussions/61182/comments/6370289/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6370289,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="f1bc996ef6827885f570aead92e98880bceef7d9c749ea739f3eef8c6c9d1af3" data-hovercard-type="user" data-hovercard-url="/users/hherman1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/hherman1" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/611822?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">hherman1</span> </div></a> <a href="#discussioncomment-6370289" id="discussioncomment-6370289-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T06:20:37Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6370289/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6370289" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I think the right thing to do would be to change the bot which mirrors GitHub PRs to gerrit, to instead immediately close the GitHub pr and share a link to a replacement on gerrit, with an explanation of what happened.</p> <p dir="auto">Fully removing support for GitHub prs is going to dissuade a lot of people from ever even trying to become a contributor, but if you just accept initial commits via GitHub and then force people to gerrit I think it is much less harsh, and i think gets you most of the centralized workflow wins you are interested in. I hope you dont fully shut down github PRs.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 6" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6370289" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>6</span> </button> <tool-tip id="tooltip-407ee712-7628-4756-8f12-eadf36663223" for="discussion-upvote-button-DiscussionComment-6370289" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-bf71c3" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>2</span> </button> <button name="input[content]" id="reactions--reaction_button_component-aad0ec" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>2</span> </li> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 2 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6370289"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374568,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="9eea858af9c146348bc98f00fded2d5377e7efe71356d3adeff636201971ac09" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6374568" data-gid="DC_kwDOAWBuf84AYUSo" data-url="/golang/go/discussions/61182/comments/6374568" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="327636c450b40f5105fef3aefbdd71e12b16ff3b20f61b40d833d8a2f1f0743e" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6374568-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6374568-list" aria-labelledby="tooltip-55a27460-bdfb-4f96-bd85-9e4b0e219071" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-55a27460-bdfb-4f96-bd85-9e4b0e219071" for="Comment-actions-6374568-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6374568-list" role="menu" aria-labelledby="Comment-actions-6374568-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374568/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6374568" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374568,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="9eea858af9c146348bc98f00fded2d5377e7efe71356d3adeff636201971ac09" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6374568" id="discussioncomment-6374568-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T13:51:28Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6374568/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6374568" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">That's an interesting idea — it would address many of the problems around the data model mismatch.</p> <p dir="auto">I still worry that it would lead to a lot CLs abandoned or with unclear status, though. If someone sends the change through Gerrit in the first place, we know they've successfully signed in to Gerrit and they are set up to push edits to it too.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374757,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="bdac1ce8fc2f8eaffc733c4b2a3cdb26592409d9c0585cc556b2d2daa325bffa" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/1293187?s=60&v=4" width="30" height="30" alt="@prattmic" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6374757" data-gid="DC_kwDOAWBuf84AYUVl" data-url="/golang/go/discussions/61182/comments/6374757" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="b5fd9677fa707d8819f89e958f8968ebdf72a53a19d28dcc25dca711b3feaea1" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6374757-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6374757-list" aria-labelledby="tooltip-05f7bf8b-9b5d-4d55-8bbf-47cd1785e256" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-05f7bf8b-9b5d-4d55-8bbf-47cd1785e256" for="Comment-actions-6374757-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6374757-list" role="menu" aria-labelledby="Comment-actions-6374757-text"> <include-fragment src="/golang/go/discussions/61182/comments/6374757/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6374757" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6374757,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="bdac1ce8fc2f8eaffc733c4b2a3cdb26592409d9c0585cc556b2d2daa325bffa" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">prattmic</a> <a href="#discussioncomment-6374757" id="discussioncomment-6374757-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T14:08:29Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6374757/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6374757" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">I like this idea, but I'm not certain it is possible to set up permissions to allow the author to push a new patch set to GerritBot's version of the CL (especially if the commit "author" is GitHub's noreply email rather than the actual author).</p> <p dir="auto">A similar option would be to auto-close PRs with a copy-pastable CLI snippet to automatically upload the same PR to Gerrit (add remote, add change-id hook, amend commit, push).</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-25a90e" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>5</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>5</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYTZI" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6370888" data-gid="DC_kwDOAWBuf84AYTZI" data-url="/golang/go/discussions/61182/comments/6370888" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="c7c488c1649298f9b9bf3d12de716749e2173da0cf8965e3c879303d1a07910d" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6370888-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6370888-list" aria-labelledby="tooltip-2e929d37-6d46-4173-83b8-24efe7486712" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-2e929d37-6d46-4173-83b8-24efe7486712" for="Comment-actions-6370888-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6370888-list" role="menu" aria-labelledby="Comment-actions-6370888-text"> <include-fragment src="/golang/go/discussions/61182/comments/6370888/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6370888" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6370888,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="5bb475b38a0f19e07c51183cca489cab51f45ad10cf980dda22f608c8b41a6af" data-hovercard-type="user" data-hovercard-url="/users/cristaloleg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/cristaloleg" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/366002?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">cristaloleg</span> </div></a> <a href="#discussioncomment-6370888" id="discussioncomment-6370888-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T07:36:29Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6370888/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6370888" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">Don't get me wrong but for a big project (like Go) Gerrit is a good firewall which raises a bar and prevents tons of PRs with a questionable changes. As a result it keeps core team less disrupted.</p> <p dir="auto">(sorry, don't have any numbers, just gut feelings)</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 2" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6370888" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>2</span> </button> <tool-tip id="tooltip-03111c8f-651a-4b7e-8d59-94237b29772c" for="discussion-upvote-button-DiscussionComment-6370888" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-b53e05" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>9</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>9</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6370888"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6371556,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4b961eb86b8c6aeb5c2025d732965cd87a42df2660ccdc73d401d1f00cf78709" data-hovercard-type="user" data-hovercard-url="/users/philpax/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/philpax"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/707827?s=60&v=4" width="30" height="30" alt="@philpax" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6371556" data-gid="DC_kwDOAWBuf84AYTjk" data-url="/golang/go/discussions/61182/comments/6371556" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="522afdc98fa6ce520ad0280666b51a46d93af300281656f8db7057d6f3a79ecf" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6371556-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6371556-list" aria-labelledby="tooltip-76a6f0f6-1995-48d0-bacc-d3ab64e43043" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-76a6f0f6-1995-48d0-bacc-d3ab64e43043" for="Comment-actions-6371556-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6371556-list" role="menu" aria-labelledby="Comment-actions-6371556-text"> <include-fragment src="/golang/go/discussions/61182/comments/6371556/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6371556" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6371556,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4b961eb86b8c6aeb5c2025d732965cd87a42df2660ccdc73d401d1f00cf78709" data-hovercard-type="user" data-hovercard-url="/users/philpax/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/philpax" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">philpax</a> <a href="#discussioncomment-6371556" id="discussioncomment-6371556-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T08:35:49Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6371556/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6371556" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">Manishearth discussed this in the original "switch to GitHub" thread: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="259350017" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/21956" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/21956/hovercard?comment_id=331353818&comment_type=issue_comment" href="https://github.com/golang/go/issues/21956#issuecomment-331353818">#21956 (comment)</a></p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-d4c15f" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>9</span> </button> <button name="input[content]" id="reactions--reaction_button_component-0d92dd" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>3</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>9</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>3</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYVXp" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6378985" data-gid="DC_kwDOAWBuf84AYVXp" data-url="/golang/go/discussions/61182/comments/6378985" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="c4a7df8d51530216c456f65d4d7cbc49a2ad7f84dbe44c910d7a0f3fa38118d3" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6378985-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6378985-list" aria-labelledby="tooltip-11f8b049-770b-4318-b9bb-e14bf1b6ff3c" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-11f8b049-770b-4318-b9bb-e14bf1b6ff3c" for="Comment-actions-6378985-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6378985-list" role="menu" aria-labelledby="Comment-actions-6378985-text"> <include-fragment src="/golang/go/discussions/61182/comments/6378985/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6378985" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6378985,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="224da206e67d00e3123df98b03cf92ca9c155bbe0541a1b9dc08afa9d4a0fc36" data-hovercard-type="user" data-hovercard-url="/users/earthboundkid/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/earthboundkid" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/222245?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">earthboundkid</span> </div></a> <a href="#discussioncomment-6378985" id="discussioncomment-6378985-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-06T23:53:14Z" class="no-wrap">Jul 6, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6378985/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6378985" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">The GitHub <code class="notranslate">gh</code> command line tool that I use to open PRs happens to be written in Go. That got me thinking: what if the Go project came with a version of the Gerrit tool that was built in Go? That would take away the step in the contribution process where you need to install an extra tool. You could run your build and tests with all.bash as usual and then if it works do contribute.bash or something to have it submit the changes. It wouldn’t need to be a full tool, just enough to mail in changes.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 2" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6378985" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>2</span> </button> <tool-tip id="tooltip-91c94f86-8f3e-4eab-8f9c-4ebaadfa6e1f" for="discussion-upvote-button-DiscussionComment-6378985" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-4a4d46" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6378985"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6379625,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="ee26ed943156a9f8a7f102a65900aa8a4f1f8ad16d1735b92d80da3edd7dc0cd" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3194333?s=60&v=4" width="30" height="30" alt="@ianlancetaylor" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6379625" data-gid="DC_kwDOAWBuf84AYVhp" data-url="/golang/go/discussions/61182/comments/6379625" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="33a53f0f44a0dfdffcdcbb66943824db5c1fcdc2d3fd1fd03b80d026042f22ea" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6379625-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6379625-list" aria-labelledby="tooltip-dc957ca0-c5f1-4722-82e6-e8e6cf999ddb" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-dc957ca0-c5f1-4722-82e6-e8e6cf999ddb" for="Comment-actions-6379625-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6379625-list" role="menu" aria-labelledby="Comment-actions-6379625-text"> <include-fragment src="/golang/go/discussions/61182/comments/6379625/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6379625" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6379625,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="ee26ed943156a9f8a7f102a65900aa8a4f1f8ad16d1735b92d80da3edd7dc0cd" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ianlancetaylor</a> <a href="#discussioncomment-6379625" id="discussioncomment-6379625-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T02:04:59Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6379625/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6379625" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">We have tooling, written in Go, to manage submitting changes to Gerrit. See the mentions of <code class="notranslate">git codereview</code> at <a href="https://go.dev/doc/contribute#sending_a_change_gerrit" rel="nofollow">https://go.dev/doc/contribute#sending_a_change_gerrit</a> .</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-2ba52a" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>4</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYVkH" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6379783" data-gid="DC_kwDOAWBuf84AYVkH" data-url="/golang/go/discussions/61182/comments/6379783" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="ff884335963c317426b50053e538fec8449b786083647adb1dab28e230f344e8" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6379783-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6379783-list" aria-labelledby="tooltip-8dbc01d9-4602-4cdb-94c2-05ce79d44f60" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-8dbc01d9-4602-4cdb-94c2-05ce79d44f60" for="Comment-actions-6379783-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6379783-list" role="menu" aria-labelledby="Comment-actions-6379783-text"> <include-fragment src="/golang/go/discussions/61182/comments/6379783/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6379783" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6379783,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="4bb1cdf9572c8dac4a912f26e79a8c9eb9fb4cf4f4f88bc53b2f6822185759c2" data-hovercard-type="user" data-hovercard-url="/users/Aoang/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Aoang" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/22998599?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">Aoang</span> </div></a> <a href="#discussioncomment-6379783" id="discussioncomment-6379783-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T02:43:05Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6379783/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6379783" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">This answer may not be suitable for reply here, but there isn't a more appropriate place found.</p> <p dir="auto">The choice of a tool for code review should not only be considered from the perspective of code review.<br> For example, users who currently oppose the use of Gerrit may argue that using GitHub will bring in more contributors and reviewers.</p> <p dir="auto">I believe we face yet another issue. The inability of Google search engine to index the content from Gerrit poses a problem.</p> <p dir="auto">This implies that one cannot access the content they are interested in through <code class="notranslate">site:go-review.googlesource.com http</code>.</p> <p dir="auto">Your only choice is to perform an internal site search: <code class="notranslate">https://go-review.googlesource.com/q/http</code>. However, you may encounter:</p> <div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="An error occurred Error 400: too many terms in query Endpoint: /changes/"><pre class="notranslate"><code class="notranslate">An error occurred Error 400: too many terms in query Endpoint: /changes/ </code></pre></div> <h4 dir="auto">What is my current strategy when I need to search for relevant issues?</h4> <ol dir="auto"> <li>Visit <code class="notranslate">github.com/golang/go</code>.</li> <li>Click on <code class="notranslate">Issues</code> then search <code class="notranslate">is:issue http3</code>.</li> <li>Begin your exploration here <code class="notranslate">https://github.com/golang/go/issues?q=is%3Aissue+http3</code>.</li> <li>If GitHub restricts searches, Google can be used as an alternative.</li> </ol> <h4 dir="auto">What are the limitations of this approach?</h4> <p dir="auto">I am unable to find comments made during the review process.</p> <h4 dir="auto">What's my ideal scenario?</h4> <p dir="auto">I should be able to find what I am looking for through Google/GitHub/Gerrit or any other platform.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 2" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6379783" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>2</span> </button> <tool-tip id="tooltip-99ba46c6-4a38-4c6d-a77c-57ceff8cf328" for="discussion-upvote-button-DiscussionComment-6379783" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-a9793a" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6379783"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385164,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="dd6efd6dc10dcdc2272e2912ae6d3452415fb2096989f615625ec780e71bd9e1" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6385164" data-gid="DC_kwDOAWBuf84AYW4M" data-url="/golang/go/discussions/61182/comments/6385164" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="c106609eb0e2c5496f0eb1b61824c495f9c192858c925f93ac72fa00596dfa26" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6385164-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6385164-list" aria-labelledby="tooltip-d166fc49-6f7f-4048-a25e-58d905192d5b" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-d166fc49-6f7f-4048-a25e-58d905192d5b" for="Comment-actions-6385164-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6385164-list" role="menu" aria-labelledby="Comment-actions-6385164-text"> <include-fragment src="/golang/go/discussions/61182/comments/6385164/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6385164" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6385164,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="dd6efd6dc10dcdc2272e2912ae6d3452415fb2096989f615625ec780e71bd9e1" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6385164" id="discussioncomment-6385164-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-07T14:16:49Z" class="no-wrap">Jul 7, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6385164/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6385164" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">This seems a bit off-topic. I think there is a Send Feedback option in the Gerrit UI that you can use to report it to the appropriate maintainers.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYneB" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6453121" data-gid="DC_kwDOAWBuf84AYneB" data-url="/golang/go/discussions/61182/comments/6453121" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="c355c7baa05ff02a1ced9d575cc3d4b71cacaf7ae3fe0f38459b728fa8111a0e" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6453121-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6453121-list" aria-labelledby="tooltip-3b6cd140-86d4-4d8e-9e1f-1a2f97fe1f25" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-3b6cd140-86d4-4d8e-9e1f-1a2f97fe1f25" for="Comment-actions-6453121-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6453121-list" role="menu" aria-labelledby="Comment-actions-6453121-text"> <include-fragment src="/golang/go/discussions/61182/comments/6453121/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6453121" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6453121,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="598ed9cb144dc34eeea8cbed768e2989f5cf07485b34af9396dbb18050e3cbac" data-hovercard-type="user" data-hovercard-url="/users/jnelle/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/jnelle" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/36324542?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">jnelle</span> </div></a> <a href="#discussioncomment-6453121" id="discussioncomment-6453121-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-14T20:31:03Z" class="no-wrap">Jul 14, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6453121/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6453121" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">We should consider staying on GitHub and taking inspiration from the Flutter project's success in building a vibrant community.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 1" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6453121" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>1</span> </button> <tool-tip id="tooltip-3f487731-44ad-421d-8bdc-0e427a922aa1" for="discussion-upvote-button-DiscussionComment-6453121" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-c31dcc" value="CONFUSED react" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="thinking_face"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 1 reply </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6453121"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6453352,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6c0749b85152aa8b01088c70501f3f4c7b441a00c34583cf065cf4040147018a" data-hovercard-type="user" data-hovercard-url="/users/thepudds/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thepudds"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/20628140?s=60&v=4" width="30" height="30" alt="@thepudds" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6453352" data-gid="DC_kwDOAWBuf84AYnho" data-url="/golang/go/discussions/61182/comments/6453352" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="7ae7b394d37ba565f40e688bb2baf4ab467d02bc1307ee7b8ab87c8f1be46d73" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6453352-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6453352-list" aria-labelledby="tooltip-ecdae0a1-e911-4805-aa22-c071c38e09ec" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-ecdae0a1-e911-4805-aa22-c071c38e09ec" for="Comment-actions-6453352-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6453352-list" role="menu" aria-labelledby="Comment-actions-6453352-text"> <include-fragment src="/golang/go/discussions/61182/comments/6453352/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6453352" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> <edit-history> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" aria-haspopup="true" aria-controls="discussion-edit-history-6453352-list" aria-expanded="false" id="discussion-edit-history-6453352-text" data-target="edit-history.menuTrigger" type="button" data-view-component="true" class="Button--invisible Button--small Button"> <span class="Button-content"> <span class="Button-label">edited</span> </span> <span class="Button-visual Button-trailingAction"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-triangle-down"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span> </button> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="discussion-edit-history-6453352-list" role="menu" aria-labelledby="discussion-edit-history-6453352-text"> <include-fragment src="/golang/go/discussions/61182/comments/6453352/edits_log" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="edit-history.deletedDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> {{actor}} deleted this content <relative-time class="no-wrap" datetime="{{datetime}}"></relative-time>. </div> </scrollable-region> </dialog></dialog-helper> </template> <template data-target="edit-history.diffDialogTemplate"> <dialog-helper> <dialog data-action="cancel:edit-history#removeDialog" id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-large Overlay--motion-scaleFade Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{editor}}'s edit </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body p-0"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> </edit-history> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6453352,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6c0749b85152aa8b01088c70501f3f4c7b441a00c34583cf065cf4040147018a" data-hovercard-type="user" data-hovercard-url="/users/thepudds/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/thepudds" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">thepudds</a> <a href="#discussioncomment-6453352" id="discussioncomment-6453352-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-14T21:22:26Z" class="no-wrap">Jul 14, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a collaborator on this repository." data-view-component="true" class="Label py-0 ml-1"> Collaborator </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6453352/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6453352" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <blockquote> <p dir="auto">We should consider staying on GitHub</p> </blockquote> <p dir="auto">Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jnelle/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jnelle">@jnelle</a>, just in case there was some ambiguity from some of the other comments, this discussion is not about leaving GitHub, and to my knowledge, no one is proposing that.</p> <p dir="auto">This discussion is just about the much narrower question of what to do about inbound GitHub PRs.</p> <p dir="auto">From the Flutter <a href="https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md">contribution guide</a>, it looks like the Flutter project uses GitHub PRs for reviews? FWIW, I think it is unlikely that the Go project would drop Gerrit in the near term and rely entirely on GitHub PRs for reviews. See for example Ian's comment <a href="https://github.com/golang/go/discussions/61182#discussioncomment-6379614" data-hovercard-type="discussion" data-hovercard-url="/golang/go/discussions/61182/hovercard?comment_id=6379614">here</a>.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-4d8a4b" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AYwBt" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6488173" data-gid="DC_kwDOAWBuf84AYwBt" data-url="/golang/go/discussions/61182/comments/6488173" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="db4749a2a80f0d7dd3ef47aea01ba8ecb68cb2f8a76ca0e1c75cc5ce455e50f9" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6488173-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6488173-list" aria-labelledby="tooltip-eb2d369f-9e37-4ea5-a07b-7ed3cbe32c5b" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-eb2d369f-9e37-4ea5-a07b-7ed3cbe32c5b" for="Comment-actions-6488173-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6488173-list" role="menu" aria-labelledby="Comment-actions-6488173-text"> <include-fragment src="/golang/go/discussions/61182/comments/6488173/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6488173" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6488173,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="3e4045096430efbb851b3110a155f891418c7411e839f8fabe97b7e8b41aa800" data-hovercard-type="user" data-hovercard-url="/users/qiulaidongfeng/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/qiulaidongfeng" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/96758349?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">qiulaidongfeng</span> </div></a> <a href="#discussioncomment-6488173" id="discussioncomment-6488173-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-19T12:10:09Z" class="no-wrap">Jul 19, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6488173/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6488173" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="841538183" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/45246" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/45246/hovercard" href="https://github.com/golang/go/issues/45246">#45246</a> If you stop importing GitHub PRs, how can you solve the following situation:</p> <details><summary></summary> <p dir="auto"> remote: PERMISSION_DENIED: The caller does not have permission </p><p dir="auto">remote: [type.googleapis.com/google.rpc.LocalizedMessage]</p> <p dir="auto">remote: locale: "en-US"</p> <p dir="auto">remote: message: "go.googlesource.com is not available from your location."</p> <p dir="auto">remote:</p> <p dir="auto">remote: [type.googleapis.com/google.rpc.RequestInfo]</p> <p dir="auto">remote: request_id: "c922a8c106674b4f9de1731653555818"</p> <p dir="auto">fatal: unable to access '<a href="https://go.googlesource.com/go/" rel="nofollow">https://go.googlesource.com/go/</a>': The requested URL returned error: 403</p> <p dir="auto">(running: git push -q origin HEAD:refs/for/master)</p> <p dir="auto">git-codereview: exit status 128</p> <p dir="auto"></p> </details> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 2" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6488173" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>2</span> </button> <tool-tip id="tooltip-38403e5b-8099-4809-9815-ef4a5d709d15" for="discussion-upvote-button-DiscussionComment-6488173" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 2 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-6488173"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6491719,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="8c014408a9493a274281e6de6b38f79c6ea915a23df29e16a9c50bd9e0bd988d" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/5200974?s=60&v=4" width="30" height="30" alt="@bcmills" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6491719" data-gid="DC_kwDOAWBuf84AYw5H" data-url="/golang/go/discussions/61182/comments/6491719" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="b0b24269ba97d559adc49e6b07c981a4eed84979a956ea8626808daee837b459" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6491719-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6491719-list" aria-labelledby="tooltip-8dec3d23-5a93-4a32-8841-cc633eed8186" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-8dec3d23-5a93-4a32-8841-cc633eed8186" for="Comment-actions-6491719-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6491719-list" role="menu" aria-labelledby="Comment-actions-6491719-text"> <include-fragment src="/golang/go/discussions/61182/comments/6491719/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6491719" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6491719,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="8c014408a9493a274281e6de6b38f79c6ea915a23df29e16a9c50bd9e0bd988d" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">bcmills</a> <a href="#discussioncomment-6491719" id="discussioncomment-6491719-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-19T18:09:31Z" class="no-wrap">Jul 19, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6491719/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6491719" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/qiulaidongfeng/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/qiulaidongfeng">@qiulaidongfeng</a>, I think I must be missing something. If you can't access <a href="https://go.googlesource.com/go" rel="nofollow">https://go.googlesource.com/go</a> in order to push to it, how do you access <a href="https://go-review.googlesource.com" rel="nofollow">https://go-review.googlesource.com</a> in order to address comments on the code review?</p> <p dir="auto">If <code class="notranslate">go-review.googlesource.com</code> is available in more places where <code class="notranslate">go.googlesource.com</code> is not, that seems likely to be a technical problem that should be fixed in one direction or the other.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6493978,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="513602ea225ac8a10fd68d14cc3b465be0e33b0ec13d1aacf21168cb298d4b04" data-hovercard-type="user" data-hovercard-url="/users/qiulaidongfeng/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/qiulaidongfeng"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/96758349?s=60&v=4" width="30" height="30" alt="@qiulaidongfeng" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-6493978" data-gid="DC_kwDOAWBuf84AYxca" data-url="/golang/go/discussions/61182/comments/6493978" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="777b334f7b579ef8c153152ffb8d4d488a56cc5725fbace6ca2c371b0d7ba61a" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6493978-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6493978-list" aria-labelledby="tooltip-d2191b81-8701-4435-87c1-4d3185d14b33" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-d2191b81-8701-4435-87c1-4d3185d14b33" for="Comment-actions-6493978-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6493978-list" role="menu" aria-labelledby="Comment-actions-6493978-text"> <include-fragment src="/golang/go/discussions/61182/comments/6493978/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6493978" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6493978,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="513602ea225ac8a10fd68d14cc3b465be0e33b0ec13d1aacf21168cb298d4b04" data-hovercard-type="user" data-hovercard-url="/users/qiulaidongfeng/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/qiulaidongfeng" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">qiulaidongfeng</a> <a href="#discussioncomment-6493978" id="discussioncomment-6493978-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-07-20T01:01:34Z" class="no-wrap">Jul 20, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6493978/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6493978" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">I modified "C:\Windows\System32\drivers\etc\hosts" this file access <a href="https://go-review.googlesource.com" rel="nofollow">https://go-review.googlesource.com</a> and <a href="https://go.googlesource.com/go" rel="nofollow">https://go.googlesource.com/go</a> .</p> <p dir="auto">This is the ping result.</p> <details> <summary></summary> <p dir="auto">PING go-review.googlesource.com (2607:f8b0:4024:c02::52): </p><p dir="auto">32 bytes from 2607:f8b0:4024:c02::52: icmp_seq=0 time=244.0446ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4024:c02::52: icmp_seq=1 time=246.9382ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4024:c02::52: icmp_seq=2 time=250.1194ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4024:c02::52: icmp_seq=3 time=247.7303ms ttl=-1</p> <p dir="auto"></p> <p dir="auto"> PING go.googlesource.com (2607:f8b0:4004:c17::52): </p><p dir="auto">32 bytes from 2607:f8b0:4004:c17::52: icmp_seq=0 time=261.9278ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4004:c17::52: icmp_seq=1 time=257.764ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4004:c17::52: icmp_seq=2 time=252.8123ms ttl=-1</p> <p dir="auto">32 bytes from 2607:f8b0:4004:c17::52: icmp_seq=3 time=259.2603ms ttl=-1</p> <p dir="auto"></p> </details> <p dir="auto">At present, except for the git codereview email, all other parts of the contribution guide are okay.</p> <p dir="auto">Through <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="841538183" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/45246" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/45246/hovercard" href="https://github.com/golang/go/issues/45246">#45246</a>, this <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="223301116" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/20065" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/20065/hovercard?comment_id=296231971&comment_type=issue_comment" href="https://github.com/golang/go/issues/20065#issuecomment-296231971">#20065 (comment)</a> seems to explain why.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AZgFe" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6685022" data-gid="DC_kwDOAWBuf84AZgFe" data-url="/golang/go/discussions/61182/comments/6685022" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="8d74a9250dca025a3a4ec94dfb0257a976b527ef08339e71acb377c4ff9552af" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6685022-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6685022-list" aria-labelledby="tooltip-63ce2864-4eb8-43c7-bc7b-333617641832" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-63ce2864-4eb8-43c7-bc7b-333617641832" for="Comment-actions-6685022-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6685022-list" role="menu" aria-labelledby="Comment-actions-6685022-text"> <include-fragment src="/golang/go/discussions/61182/comments/6685022/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6685022" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6685022,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="43fc83eb06100a31904eb75fd564db191f2f5440966801f9cc5169b00d8c38a1" data-hovercard-type="user" data-hovercard-url="/users/mitar/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mitar" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/585279?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">mitar</span> </div></a> <a href="#discussioncomment-6685022" id="discussioncomment-6685022-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-08-09T21:58:39Z" class="no-wrap">Aug 9, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6685022/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6685022" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">As somebody who occasionally contributes to Go I do like GitHub interaction. I have not found many (any?) issues with it. I make a PR like I am used to, I get a link to the Gerrit by the bot, I go there, and I star it with the account I have signed in there using my Gmail account. If needed, I respond to comments in Gerrit. But otherwise I just push new commits to my branch and PR is updated, and Gerrit as well. So I have found this very useful in the sense that I do not really need to learn how to use Gerrit in terminal, I use it just for comments through the browser. The rest I just do regular PRs.</p> <p dir="auto">About commit message formatting, I think that would be the issue with using just Gerrit as well. Go requires the message to be formatted in a particular way so one has to learn that.</p> <p dir="auto">One middleground solution could be that some basic git commit message checks are added to GitHub Actions and Gerrit bot is run only after that is cleared.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 4" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6685022" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>4</span> </button> <tool-tip id="tooltip-595832b9-51c9-4223-b722-b7429d15a793" for="discussion-upvote-button-DiscussionComment-6685022" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-0410e5" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>8</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>8</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 0 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker" data-child-comments id="child-comments-discussioncomment-6685022"> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AZlKy" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-6705842" data-gid="DC_kwDOAWBuf84AZlKy" data-url="/golang/go/discussions/61182/comments/6705842" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="640cd8c1f088bc1899ac4fcc1e4af2bd185facf4dd25bafc15ba7592aa57bb4d" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-6705842-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-6705842-list" aria-labelledby="tooltip-acadc8b5-6189-4aae-bcd0-b1c33017c4b5" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-acadc8b5-6189-4aae-bcd0-b1c33017c4b5" for="Comment-actions-6705842-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-6705842-list" role="menu" aria-labelledby="Comment-actions-6705842-text"> <include-fragment src="/golang/go/discussions/61182/comments/6705842/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F6705842" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":6705842,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="267aa4884335ed1ff78d4f63502a334eebffda18c2a9b5ef510a4bc24f396f07" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/5200974?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">bcmills</span> </div></a> <a href="#discussioncomment-6705842" id="discussioncomment-6705842-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2023-08-11T21:44:26Z" class="no-wrap">Aug 11, 2023</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is the author of this discussion." data-view-component="true" class="Label py-0 ml-1"> Author </span> </div> </div> </h3> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/6705842/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="6705842" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto">I discussed this with a broader subset of the Go team.</p> <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/thepudds/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/thepudds">@thepudds</a> (who is not on the Go team, but is a valued contributor!) has been making significant improvements for many of the friction points I named at the start of the discussion.</p> <p dir="auto">The consensus from internal discussions is that we would like to see how those improvements pan out, and if they end up reducing the friction of GitHub PRs by as much as we expect, then it is worthwhile to continue importing GitHub PRs.</p> <p dir="auto">Thanks everyone for the feedback and ideas, and especially to <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/thepudds/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/thepudds">@thepudds</a> for putting those ideas into action.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 3" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-6705842" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>3</span> </button> <tool-tip id="tooltip-4a6261cd-87a5-42ef-990a-4c6749888e61" for="discussion-upvote-button-DiscussionComment-6705842" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-27067c" value="THUMBS_UP react" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </button> <button name="input[content]" id="reactions--reaction_button_component-e30f17" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>2</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="+1"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span>6</span> </li> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>2</span> </li> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 0 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker" data-child-comments id="child-comments-discussioncomment-6705842"> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-item js-timeline-progressive-focus-container js-quote-selection-container" data-gid="DC_kwDOAWBuf84AkxYB" data-quote-markdown=".js-comment-body" > <div class="TimelineItem discussion-timeline-item mx-0 js-comment-container" data-open-edit-form-after-load="false" > <div class="discussions-timeline-scroll-target js-targetable-element" id="discussioncomment-9639425" data-gid="DC_kwDOAWBuf84AkxYB" data-url="/golang/go/discussions/61182/comments/9639425" > <div class=" timeline-comment-group reactions-with-gap discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body js-timeline-discussion-comment my-1 " data-error="" > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment" data-body-version="e3eccb5ceb1f46aad67df8204bb391f5195c4e4545a97115386a836b33ac135b" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-9639425-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-9639425-list" aria-labelledby="tooltip-7879db41-0187-4bfc-b900-8ae0a4487092" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-7879db41-0187-4bfc-b900-8ae0a4487092" for="Comment-actions-9639425-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-9639425-list" role="menu" aria-labelledby="Comment-actions-9639425-text"> <include-fragment src="/golang/go/discussions/61182/comments/9639425/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F9639425" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h3 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-0 pt-2"> <div class="d-flex flex-items-center"> <a data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":9639425,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="d2045664aeddc42c276b7415eb8da57cf93a9e5587bac8b063c7701b685dd4e1" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi" data-view-component="true" class="Truncate Link--primary Link d-flex flex-items-center text-bold"><img aria-hidden="true" src="https://avatars.githubusercontent.com/u/11512?s=64&v=4" alt="" size="32" height="32" width="32" data-view-component="true" class="avatar circle mr-2" /> <div class="d-flex flex-column Truncate"> <span data-view-component="true" class="Truncate-text text-bold">AlekSi</span> </div></a> <a href="#discussioncomment-9639425" id="discussioncomment-9639425-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2024-06-02T16:20:00Z" class="no-wrap">Jun 2, 2024</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h3> </div> </div> <div class="color-bg-default border-bottom position-relative"> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/9639425/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="9639425" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body" > <p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="477593595" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/33502" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/33502/hovercard" href="https://github.com/golang/go/issues/33502">#33502</a> keeps linking to this discussion:</p> <blockquote> <p dir="auto">Discussions (not yet proposals)<br> codereview: should the Go project stop importing GitHub PRs? <a href="https://go.dev/issue/61182" rel="nofollow">#61182</a></p> </blockquote> <p dir="auto">Yet this discussion is closed. So, what is the correct status there? <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/rsc/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rsc">@rsc</a> <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/bcmills">@bcmills</a></p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center mb-3 ml-3"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="d-flex"> <div data-replace-remote-form-target> <div class="text-center discussion-vote-form position-relative" > <button aria-label="Upvote: 1" aria-disabled="true" id="discussion-upvote-button-DiscussionComment-9639425" type="button" data-view-component="true" class="social-reaction-summary-item js-upvote-button Link--secondary btn-invisible btn d-flex flex-items-center mx-auto"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-arrow-up m-0"> <path d="M3.47 7.78a.75.75 0 0 1 0-1.06l4.25-4.25a.75.75 0 0 1 1.06 0l4.25 4.25a.751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018L9 4.81v7.44a.75.75 0 0 1-1.5 0V4.81L4.53 7.78a.75.75 0 0 1-1.06 0Z"></path> </svg> <span>1</span> </button> <tool-tip id="tooltip-10a31566-c24e-4b09-ad02-5ab42e22ca61" for="discussion-upvote-button-DiscussionComment-9639425" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be logged in to vote</tool-tip> </div> </div> </div> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> <div class="f6 mr-3"> <span class="color-fg-muted no-wrap" > 4 replies </span> </div> </div> </div> </div> </div> <div class="js-timeline-marker color-bg-inset border-top color-border-default mt-n1 rounded-bottom-2" data-child-comments id="child-comments-discussioncomment-9639425"> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":10875055,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0bddcf75af6a4a5b13d0df7a8c273481cddc0d463532c95b1d9d70d0a2e1be09" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/11512?s=60&v=4" width="30" height="30" alt="@AlekSi" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-10875055" data-gid="DC_kwDOAWBuf84ApfCv" data-url="/golang/go/discussions/61182/comments/10875055" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="332a664985d182123a1011e0af8b7126032313dc5b630b9eb977b6f386b0907e" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-10875055-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-10875055-list" aria-labelledby="tooltip-128c9a62-6c7b-4b1a-a1e6-02f5a2c2407c" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-128c9a62-6c7b-4b1a-a1e6-02f5a2c2407c" for="Comment-actions-10875055-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-10875055-list" role="menu" aria-labelledby="Comment-actions-10875055-text"> <include-fragment src="/golang/go/discussions/61182/comments/10875055/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F10875055" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":10875055,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="0bddcf75af6a4a5b13d0df7a8c273481cddc0d463532c95b1d9d70d0a2e1be09" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">AlekSi</a> <a href="#discussioncomment-10875055" id="discussioncomment-10875055-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2024-10-08T03:28:23Z" class="no-wrap">Oct 8, 2024</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/10875055/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="10875055" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/aclements/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/aclements">@aclements</a> ^</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-0e50a7" value="THUMBS_DOWN react" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="-1"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11850714,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="7285410a266e6bbe67d631aac5b8c57402201768e57d3b4c324c1288ebc4ebf0" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/11512?s=60&v=4" width="30" height="30" alt="@AlekSi" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-11850714" data-gid="DC_kwDOAWBuf84AtNPa" data-url="/golang/go/discussions/61182/comments/11850714" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="e6e7efef7cf1c4bd1db0137501c7076582f53c8b02a2da343e4805adb8bc7e22" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-11850714-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-11850714-list" aria-labelledby="tooltip-d982b96a-8c0b-4577-9038-e2fd2c847b77" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-d982b96a-8c0b-4577-9038-e2fd2c847b77" for="Comment-actions-11850714-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-11850714-list" role="menu" aria-labelledby="Comment-actions-11850714-text"> <include-fragment src="/golang/go/discussions/61182/comments/11850714/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F11850714" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11850714,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="7285410a266e6bbe67d631aac5b8c57402201768e57d3b4c324c1288ebc4ebf0" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">AlekSi</a> <a href="#discussioncomment-11850714" id="discussioncomment-11850714-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2025-01-16T05:19:48Z" class="no-wrap">Jan 16, 2025</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/11850714/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="11850714" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ianlancetaylor">@ianlancetaylor</a> ^</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11860010,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="29f060378ebad44fb1be8bf50c7e149b4788175d7cfb9b56c619d3ed290fd5e8" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/3194333?s=60&v=4" width="30" height="30" alt="@ianlancetaylor" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-11860010" data-gid="DC_kwDOAWBuf84AtPgq" data-url="/golang/go/discussions/61182/comments/11860010" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="bc3978444826f44e78b779aba095a5ef7365a16c85b25edd961e77d138a22b66" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-11860010-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-11860010-list" aria-labelledby="tooltip-1ff8962d-afc1-42ae-815c-3222130bc672" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-1ff8962d-afc1-42ae-815c-3222130bc672" for="Comment-actions-11860010-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-11860010-list" role="menu" aria-labelledby="Comment-actions-11860010-text"> <include-fragment src="/golang/go/discussions/61182/comments/11860010/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F11860010" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":11860010,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="29f060378ebad44fb1be8bf50c7e149b4788175d7cfb9b56c619d3ed290fd5e8" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">ianlancetaylor</a> <a href="#discussioncomment-11860010" id="discussioncomment-11860010-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2025-01-16T21:55:11Z" class="no-wrap">Jan 16, 2025</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/11860010/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="11860010" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/aclements/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/aclements">@aclements</a> Where does the list of discussions in the proposal minutes <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="477593595" data-permission-text="Title is private" data-url="https://github.com/golang/go/issues/33502" data-hovercard-type="issue" data-hovercard-url="/golang/go/issues/33502/hovercard" href="https://github.com/golang/go/issues/33502">#33502</a> come from? We should remove this discussion <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="5371795" data-permission-text="Title is private" data-url="https://github.com/golang/go/discussions/61182" data-hovercard-type="discussion" data-hovercard-url="/golang/go/discussions/61182/hovercard" href="https://github.com/golang/go/discussions/61182">#61182</a> from the list, as it is closed. Thanks.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-b27eff" value="HEART react" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="heart"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> <div class="TimelineItem js-comment-container js-nested-comment-container js-targetable-element ml-0 pb-2 pl-3 discussion-nested-comment-timeline-item discussion-primer-next-nested-comment-timeline-item width-full"> <div class="avatar-parent-child flex-column flex-items-center TimelineItem-avatar left-0 ml-3"><a class="d-inline-block" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":12066932,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="7e1df20345e08ad6867d3bcc72d81cd0aff84e28a5740dc6b5cdc132cf964342" data-hovercard-type="user" data-hovercard-url="/users/aclements/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/aclements"><img class="avatar rounded-2 mr-2 avatar-user" src="https://avatars.githubusercontent.com/u/2688315?s=60&v=4" width="30" height="30" alt="@aclements" /></a></div> <div class="discussions-timeline-scroll-target" id="discussioncomment-12066932" data-gid="DC_kwDOAWBuf84AuCB0" data-url="/golang/go/discussions/61182/comments/12066932" data-error="" > <div class=" timeline-comment-group discussion-comment js-discussion-comment js-minimizable-comment-group js-targetable-element TimelineItem-body discussion-nested-comment-group position-relative mt-0 pl-2 " > <div class="d-flex"> <div class="width-full"> <div class="timeline-comment unminimized-comment comment previewable-edit js-task-list-container flex-auto box-shadow-none js-comment border-0 color-bg-inset nested-discussion-timeline-comment ml-n3" data-body-version="6088279f741839e13b4be7628a451554764da71e2fd0958f8672c894968615bf" > <div class="edit-comment-hide"> <div class="clearfix d-flex px-3 flex-row-reverse flex-items-center border-bottom-0 color-bg-inset"> <div class="timeline-comment-actions flex-shrink-0"> <div class="d-flex flex-row flex-items-center"> <comment-actions-container> <experimental-action-menu data-anchor-align="end" data-anchor-side="outside-bottom" data-view-component="true"> <button role="button" id="Comment-actions-12066932-text" aria-haspopup="true" aria-expanded="false" aria-controls="Comment-actions-12066932-list" aria-labelledby="tooltip-072966f9-f536-410d-8f7c-108051fb5e91" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-072966f9-f536-410d-8f7c-108051fb5e91" for="Comment-actions-12066932-text" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Comment options</tool-tip> <div class="Overlay-backdrop--anchor" data-menu-overlay> <div class="Overlay Overlay-whenNarrow Overlay--height-auto Overlay--width-auto" hidden> <div class="Overlay-body Overlay-body--paddingNone"> <ul class="ActionList" id="Comment-actions-12066932-list" role="menu" aria-labelledby="Comment-actions-12066932-text"> <include-fragment src="/golang/go/discussions/61182/comments/12066932/comment_actions_menu?form_path=%2Fgolang%2Fgo%2Fdiscussions%2F61182%2Fcomments%2F12066932" loading="lazy" data-target="action-menu.includeFragment"> <li class="ActionList-item d-flex flex-items-center flex-justify-center text-center" data-target="action-menu.includeFragmentLoadingItem" aria-disabled="true" > <span data-view-component="true"> <svg aria-label="Loading content..." style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="m-2 anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </li> </include-fragment> </ul> </div> </div> </div> </experimental-action-menu> <template data-target="comment-actions-container.dialogTemplate"> <dialog-helper> <dialog id="{{dialogId}}" aria-modal="true" aria-labelledby="{{dialogId}}-title" aria-describedby="{{dialogId}}-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--size-auto Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="{{dialogId}}-title"> {{title}} </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="{{dialogId}}" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="{{dialogId}}-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment src="{{src}}"> <div class="text-center" data-hide-on-error> <span data-view-component="true"> <svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg></span> </div> <div class="text-center" data-show-on-error hidden> Something went wrong. </div> </include-fragment> </div> </scrollable-region> </dialog></dialog-helper> </template> <div data-target="comment-actions-container.dialogContainer"></div> <div hidden> <button data-hotkey="r" type="button" data-view-component="true" class="js-comment-quote-reply Button--secondary Button--medium Button"> <span class="Button-content"> <span class="Button-label">Quote reply</span> </span> </button> </div> </comment-actions-container> </div> </div> <div class="d-none d-sm-flex flex-items-center"> <span class="d-inline-block js-comment-edit-history"> </span> </div> <h4 data-view-component="true" class="timeline-comment-header-text text-normal f5 pb-1 pt-0"> <div class="d-flex flex-items-center"> <a width="fit" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":12066932,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="7e1df20345e08ad6867d3bcc72d81cd0aff84e28a5740dc6b5cdc132cf964342" data-hovercard-type="user" data-hovercard-url="/users/aclements/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/aclements" data-view-component="true" class="author css-truncate css-truncate-target lh-condensed Link--primary Link text-bold">aclements</a> <a href="#discussioncomment-12066932" id="discussioncomment-12066932-permalink" class="Link--secondary js-timestamp d-inline-block ml-2" > <relative-time datetime="2025-02-05T09:29:24Z" class="no-wrap">Feb 5, 2025</relative-time> </a> <div class="d-none d-sm-inline-flex ml-2" > <span title="This user is a maintainer on this repository." data-view-component="true" class="Label py-0 ml-1"> Maintainer </span> </div> </div> </h4> </div> </div> <div class=""> <div class="edit-comment-hide"> <task-lists disabled sortable> <inline-machine-translation detected-language="en" detect-language-url="/golang/go/discussions/61182/comments/12066932/language_detections" > <p hidden class="mx-3 mt-3 mb-0 f6 color-fg-muted" data-target="inline-machine-translation.triggerContainer"> <span data-target="inline-machine-translation.fromLanguageContainer"></span> - <button title="Translate content" data-action="click:inline-machine-translation#click" data-target="inline-machine-translation.button" type="button" data-view-component="true" class="btn-link"> <span data-target="inline-machine-translation.targetLanguageContainer"></span> </button> </p> </inline-machine-translation> <table class="d-block" role="presentation" data-paste-markdown-skip> <tbody class="d-block js-translation-source" data-target-translation-id="12066932" data-target-translation-type="comment" > <tr class="d-block"> <td class="d-block color-fg-default comment-body markdown-body js-comment-body px-3 pt-0 pb-2" > <p dir="auto">That's posted by the proposal minutes program, which at the moment only filters out "locked" issues. Probably because it was written before discussions <a href="https://github.blog/changelog/2023-03-14-adding-the-ability-to-close-github-discussions/" rel="nofollow"><em>could</em> be closed</a>! I'll work on fixing that, though I need to fix it in rsc.io/github first, so it may happen one more time.</p> </td> </tr> </tbody> </table> <p class="mx-3 mb-3 f6 color-fg-muted js-translation-feedback" hidden> <span data-view-component="true" class="Label Label--success Label--inline color-border-open-emphasis">Beta</span> <span data-view-component="true" class="js-was-this-translation-helpful color-fg-muted ml-1">Was this translation helpful?</span> <a href="#" data-view-component="true" class="js-give-feedback Link">Give feedback.</a> </p> </task-lists> <div class="d-block d-sm-flex flex-items-center ml-1"> <div class="d-flex flex-1 flex-justify-between flex-items-center"> <div class="d-flex flex-items-center"> <div class="reactions-container d-flex flex-items-start flex-row-reverse flex-justify-end d-md-flex ml-2 has-reactions" > <div class="js-reactions-container"> <div class=" js-comment-reactions-options d-flex flex-items-center flex-row flex-wrap"> <button name="input[content]" id="reactions--reaction_button_component-63fe0f" value="HOORAY react" data-button-index-position="3" data-reaction-label="Hooray" data-reaction-content="tada" aria-pressed="false" type="submit" disabled="disabled" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button btn-link d-flex no-underline color-fg-muted flex-items-baseline"> <g-emoji alias="tada" fallback-src="https://github.githubassets.com/assets/1f389-36899a2cb781.png" class="social-button-emoji">🎉</g-emoji> <span>1</span> </button> </div> <details class="dropdown details-reset details-overlay d-inline-block js-all-reactions-popover" hidden> <summary aria-haspopup="true" data-view-component="true" class="Button--link Button--medium Button"> <span class="Button-content"> <span class="Button-label">All reactions</span> </span> </summary> <ul class="dropdown-menu dropdown-menu-se"> <li class="dropdown-item" aria-label="tada"> <g-emoji alias="tada" fallback-src="https://github.githubassets.com/assets/1f389-36899a2cb781.png" class="social-button-emoji">🎉</g-emoji> <span>1</span> </li> </ul> </details> </div> </div> </div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> </div> </div></div> </div> </div> </div> </div> <div class="js-timeline-marker js-socket-channel js-updatable-content" data-timeline-updated-at="2025-02-05 09:29:24 UTC" data-gid="D_kwDOAWBuf84AUfeT" data-url="/golang/go/discussions/61182/timeline?timeline_last_modified=2025-02-05+09%3A29%3A24+UTC" data-channel="eyJjIjoiZGlzY3Vzc2lvbjo1MzcxNzk1OnRpbWVsaW5lIiwidCI6MTczOTgxMTg1OX0=--f9364cce91e1a4f50ee31cd7bec8e1c8bd713f93e500f0769800c33825a37aac" > </div> </option></form><form class="d-none js-timeline-marker-form" data-turbo="false" action="/_graphql/MarkNotificationSubjectAsRead" accept-charset="UTF-8" data-remote="true" method="post"><input type="hidden" data-csrf="true" name="authenticity_token" value="m3XhlP9JE8aTUUkELPXAdAZmrFos0s5Kzh2MG58TOI/CclGpOXX4DM1M1w+j7B6MNAoGWz2SDwV/b8uWFHmAuw==" /> <input type="hidden" name="variables[subjectId]" value="D_kwDOAWBuf84AUfeT"> </form></div> </div> <span id="issue-comment-box"></span> <div class="discussion-timeline-actions"> <div data-view-component="true" class="flash flash-warn mt-3"> <a rel="nofollow" class="btn btn-primary" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":23096959,"auth_type":"SIGN_UP","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6887c9fdf3f194745c45c559a938694ad902bbac1aefee7d0813088d0882e862" href="/join?source=comment-repo">Sign up for free</a> <strong>to join this conversation on GitHub</strong>. Already have an account? <a rel="nofollow" class="Link--inTextBlock" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":23096959,"auth_type":"LOG_IN","originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="7eade1d56c75b9e3554d12a044796a5da25947adc7ef757b8f1dc17a2caa7b45" data-test-selector="comments-sign-in-link" href="/login?return_to=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fdiscussions%2F61182">Sign in to comment</a> </div> </div> </div> </div> <div id="partial-discussion-sidebar" class="flex-shrink-0 col-12 col-md-3 mt-3 mt-md-0 js-socket-channel js-updatable-content" data-channel="eyJjIjoiZGlzY3Vzc2lvbjo1MzcxNzk1IiwidCI6MTczOTgxMTg1OH0=--55807ba6c14382feefc44978b720656f0c0c87e2bfd9e34382e3b9a3c9ad2a1b" data-gid="D_kwDOAWBuf84AUfeT" data-url="/golang/go/discussions/61182/sidebar" data-project-hovercards-enabled> <div class="discussion-sidebar-item pt-0"> <div> <div> <div class="text-bold discussion-sidebar-heading"> Category </div> <a href="/golang/go/discussions/categories/discussions" class="Link--onHover d-flex flex-row flex-items-center text-small color-fg-default text-bold no-underline" > <div class="d-flex flex-justify-center flex-items-center bg-discussions-row-emoji-box-small rounded-2 flex-shrink-0 mr-2" aria-hidden="true"> <g-emoji alias="turtle" fallback-src="https://github.githubassets.com/assets/1f422-53fdcdddedc7.png" class="f5">🐢</g-emoji> </div> Discussions </a> </div> </div> </div> <div class="discussion-sidebar-item js-discussion-sidebar-item"> <div class="discussion-sidebar-heading text-bold"> Labels </div> <div class="d-flex flex-wrap"> None yet </div> </div> <div id="partial-users-participants" class="discussion-sidebar-item"> <div class="participation"> <div class="discussion-sidebar-heading text-bold"> 31 participants </div> <div class="participation-avatars d-flex flex-wrap" > <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/bcmills/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/bcmills"> <img src="https://avatars.githubusercontent.com/u/5200974?s=48&v=4" alt="@bcmills" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/AlekSi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/AlekSi"> <img src="https://avatars.githubusercontent.com/u/11512?s=48&v=4" alt="@AlekSi" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/apparentlymart/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/apparentlymart"> <img src="https://avatars.githubusercontent.com/u/20180?s=48&v=4" alt="@apparentlymart" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/rsc/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/rsc"> <img src="https://avatars.githubusercontent.com/u/104030?s=48&v=4" alt="@rsc" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/dolmen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dolmen"> <img src="https://avatars.githubusercontent.com/u/129536?s=48&v=4" alt="@dolmen" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/earthboundkid/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/earthboundkid"> <img src="https://avatars.githubusercontent.com/u/222245?s=48&v=4" alt="@earthboundkid" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/cristaloleg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/cristaloleg"> <img src="https://avatars.githubusercontent.com/u/366002?s=48&v=4" alt="@cristaloleg" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/mitar/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mitar"> <img src="https://avatars.githubusercontent.com/u/585279?s=48&v=4" alt="@mitar" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/hherman1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/hherman1"> <img src="https://avatars.githubusercontent.com/u/611822?s=48&v=4" alt="@hherman1" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/philpax/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/philpax"> <img src="https://avatars.githubusercontent.com/u/707827?s=48&v=4" alt="@philpax" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/Merovius/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Merovius"> <img src="https://avatars.githubusercontent.com/u/720787?s=48&v=4" alt="@Merovius" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/achille-roussel/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/achille-roussel"> <img src="https://avatars.githubusercontent.com/u/865510?s=48&v=4" alt="@achille-roussel" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/benhoyt/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/benhoyt"> <img src="https://avatars.githubusercontent.com/u/999033?s=48&v=4" alt="@benhoyt" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/prattmic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/prattmic"> <img src="https://avatars.githubusercontent.com/u/1293187?s=48&v=4" alt="@prattmic" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/joeblubaugh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/joeblubaugh"> <img src="https://avatars.githubusercontent.com/u/1951900?s=48&v=4" alt="@joeblubaugh" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/aclements/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/aclements"> <img src="https://avatars.githubusercontent.com/u/2688315?s=48&v=4" alt="@aclements" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/deefdragon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/deefdragon"> <img src="https://avatars.githubusercontent.com/u/3053654?s=48&v=4" alt="@deefdragon" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/ianlancetaylor/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ianlancetaylor"> <img src="https://avatars.githubusercontent.com/u/3194333?s=48&v=4" alt="@ianlancetaylor" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/mvdan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/mvdan"> <img src="https://avatars.githubusercontent.com/u/3576549?s=48&v=4" alt="@mvdan" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/ncruces/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/ncruces"> <img src="https://avatars.githubusercontent.com/u/5637550?s=48&v=4" alt="@ncruces" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <a class="participant-avatar" data-hydro-click="{"event_type":"discussions.click","payload":{"event_context":"DISCUSSION_VIEW","target":"USER_PROFILE_LINK","current_repository_id":23096959,"discussion_repository_id":23096959,"org_level":false,"discussion_id":5371795,"discussion_comment_id":null,"originating_url":"https://github.com/golang/go/discussions/61182","user_id":null}}" data-hydro-click-hmac="6e9d5d52efcd9429f8b9a49dd1bce058bbadc8a7842e427843eb85d94897451a" data-hovercard-type="user" data-hovercard-url="/users/SuperSandro2000/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/SuperSandro2000"> <img src="https://avatars.githubusercontent.com/u/7258858?s=48&v=4" alt="@SuperSandro2000" size="24" height="24" width="24" data-view-component="true" class="avatar circle" /> </a> <span class="participation-more">and others</span> </div> </div> </div> </div> <template class="js-discussions-markdown-toolbar-template"> <markdown-toolbar role="presentation" for="{{ textareaId }}" data-no-focus="true" data-view-component="true" class="CommentBox-toolbar"> <action-bar role="toolbar" data-view-component="true" class="ActionBar overflow-visible"> <div data-target="action-bar.itemContainer" data-view-component="true" class="ActionBar-item-container"> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-0a0bc312-a843-47a6-b9ed-773f55453c7a" data-md-button="header-3" data-analytics-event="{"category":"comment_box","action":"HEADING","label":null}" aria-labelledby="tooltip-e5337f11-97e0-41f3-a342-46b9fd986953" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-heading Button-visual"> <path d="M3.75 2a.75.75 0 0 1 .75.75V7h7V2.75a.75.75 0 0 1 1.5 0v10.5a.75.75 0 0 1-1.5 0V8.5h-7v4.75a.75.75 0 0 1-1.5 0V2.75A.75.75 0 0 1 3.75 2Z"></path> </svg> </button><tool-tip id="tooltip-e5337f11-97e0-41f3-a342-46b9fd986953" for="action-bar-0a0bc312-a843-47a6-b9ed-773f55453c7a" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Heading</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-35a274f1-4592-48ef-b85d-c28b233ad1ac" data-md-button="bold" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+b" data-analytics-event="{"category":"comment_box","action":"BOLD","label":null}" aria-labelledby="tooltip-cc79b26a-2582-4e42-9576-21c73ea75381" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bold Button-visual"> <path d="M4 2h4.5a3.501 3.501 0 0 1 2.852 5.53A3.499 3.499 0 0 1 9.5 14H4a1 1 0 0 1-1-1V3a1 1 0 0 1 1-1Zm1 7v3h4.5a1.5 1.5 0 0 0 0-3Zm3.5-2a1.5 1.5 0 0 0 0-3H5v3Z"></path> </svg> </button><tool-tip id="tooltip-cc79b26a-2582-4e42-9576-21c73ea75381" for="action-bar-35a274f1-4592-48ef-b85d-c28b233ad1ac" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Bold</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-33a936b7-d409-443e-8548-17bb96184011" data-md-button="italic" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+i" data-analytics-event="{"category":"comment_box","action":"ITALIC","label":null}" aria-labelledby="tooltip-6e92d52e-25eb-47a7-81b9-bbedd6353ce9" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-italic Button-visual"> <path d="M6 2.75A.75.75 0 0 1 6.75 2h6.5a.75.75 0 0 1 0 1.5h-2.505l-3.858 9H9.25a.75.75 0 0 1 0 1.5h-6.5a.75.75 0 0 1 0-1.5h2.505l3.858-9H6.75A.75.75 0 0 1 6 2.75Z"></path> </svg> </button><tool-tip id="tooltip-6e92d52e-25eb-47a7-81b9-bbedd6353ce9" for="action-bar-33a936b7-d409-443e-8548-17bb96184011" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Italic</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-acfe746a-f22c-4f63-8826-4a92b0c92e5d" data-md-button="quote" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+Shift+>" data-analytics-event="{"category":"comment_box","action":"QUOTE","label":null}" aria-labelledby="tooltip-0ddd0b5b-f716-4663-be9b-0f8071d7dffe" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-quote Button-visual"> <path d="M1.75 2.5h10.5a.75.75 0 0 1 0 1.5H1.75a.75.75 0 0 1 0-1.5Zm4 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5ZM2.5 7.75v6a.75.75 0 0 1-1.5 0v-6a.75.75 0 0 1 1.5 0Z"></path> </svg> </button><tool-tip id="tooltip-0ddd0b5b-f716-4663-be9b-0f8071d7dffe" for="action-bar-acfe746a-f22c-4f63-8826-4a92b0c92e5d" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Quote</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-b3dc20fc-7b8b-4aa0-9639-05be49e7ae6f" data-md-button="code" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+e" data-analytics-event="{"category":"comment_box","action":"CODE","label":null}" aria-labelledby="tooltip-99ae6904-fb0a-4368-b6db-c72d79772cfd" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code Button-visual"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </button><tool-tip id="tooltip-99ae6904-fb0a-4368-b6db-c72d79772cfd" for="action-bar-b3dc20fc-7b8b-4aa0-9639-05be49e7ae6f" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Code</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-71ab50ec-c45f-4e65-9e08-a0ef4522961b" data-md-button="link" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+k" data-analytics-event="{"category":"comment_box","action":"LINK","label":null}" aria-labelledby="tooltip-94dc68df-c681-409a-a38a-c03891e02a44" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link Button-visual"> <path d="m7.775 3.275 1.25-1.25a3.5 3.5 0 1 1 4.95 4.95l-2.5 2.5a3.5 3.5 0 0 1-4.95 0 .751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018 1.998 1.998 0 0 0 2.83 0l2.5-2.5a2.002 2.002 0 0 0-2.83-2.83l-1.25 1.25a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042Zm-4.69 9.64a1.998 1.998 0 0 0 2.83 0l1.25-1.25a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042l-1.25 1.25a3.5 3.5 0 1 1-4.95-4.95l2.5-2.5a3.5 3.5 0 0 1 4.95 0 .751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018 1.998 1.998 0 0 0-2.83 0l-2.5 2.5a1.998 1.998 0 0 0 0 2.83Z"></path> </svg> </button><tool-tip id="tooltip-94dc68df-c681-409a-a38a-c03891e02a44" for="action-bar-71ab50ec-c45f-4e65-9e08-a0ef4522961b" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Link</tool-tip> </div> <hr role="presentation" aria-hidden="true" data-targets="action-bar.items" data-view-component="true" class="ActionBar-item ActionBar-divider" /> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-f3b1e14a-38d7-4da1-b8da-af4d0b6b38c7" data-md-button="ordered-list" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+Shift+&" data-analytics-event="{"category":"comment_box","action":"ORDERED_LIST","label":null}" aria-labelledby="tooltip-f0f31c98-2a66-410a-a66a-33cf68a80794" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-list-ordered Button-visual"> <path d="M5 3.25a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5A.75.75 0 0 1 5 3.25Zm0 5a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5A.75.75 0 0 1 5 8.25Zm0 5a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1-.75-.75ZM.924 10.32a.5.5 0 0 1-.851-.525l.001-.001.001-.002.002-.004.007-.011c.097-.144.215-.273.348-.384.228-.19.588-.392 1.068-.392.468 0 .858.181 1.126.484.259.294.377.673.377 1.038 0 .987-.686 1.495-1.156 1.845l-.047.035c-.303.225-.522.4-.654.597h1.357a.5.5 0 0 1 0 1H.5a.5.5 0 0 1-.5-.5c0-1.005.692-1.52 1.167-1.875l.035-.025c.531-.396.8-.625.8-1.078a.57.57 0 0 0-.128-.376C1.806 10.068 1.695 10 1.5 10a.658.658 0 0 0-.429.163.835.835 0 0 0-.144.153ZM2.003 2.5V6h.503a.5.5 0 0 1 0 1H.5a.5.5 0 0 1 0-1h.503V3.308l-.28.14a.5.5 0 0 1-.446-.895l1.003-.5a.5.5 0 0 1 .723.447Z"></path> </svg> </button><tool-tip id="tooltip-f0f31c98-2a66-410a-a66a-33cf68a80794" for="action-bar-f3b1e14a-38d7-4da1-b8da-af4d0b6b38c7" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Numbered list</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-5b66fd0a-ccf5-4a61-8bae-eb630caad68d" data-md-button="unordered-list" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+Shift+*" data-analytics-event="{"category":"comment_box","action":"UNORDERED_LIST","label":null}" aria-labelledby="tooltip-432ea074-9562-4a73-ac9a-d59d946ddf4a" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-list-unordered Button-visual"> <path d="M5.75 2.5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5ZM2 14a1 1 0 1 1 0-2 1 1 0 0 1 0 2Zm1-6a1 1 0 1 1-2 0 1 1 0 0 1 2 0ZM2 4a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path> </svg> </button><tool-tip id="tooltip-432ea074-9562-4a73-ac9a-d59d946ddf4a" for="action-bar-5b66fd0a-ccf5-4a61-8bae-eb630caad68d" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Unordered list</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-fbdbd933-6a02-4589-b5f6-f7282944ffa1" data-md-button="task-list" data-hotkey-scope="{{ textareaId }}" data-hotkey="Control+Shift+L" data-analytics-event="{"category":"comment_box","action":"TASK_LIST","label":null}" aria-labelledby="tooltip-b20f74e8-2f7f-4009-97a5-e8449d3a65b8" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-tasklist Button-visual"> <path d="M2 2h4a1 1 0 0 1 1 1v4a1 1 0 0 1-1 1H2a1 1 0 0 1-1-1V3a1 1 0 0 1 1-1Zm4.655 8.595a.75.75 0 0 1 0 1.06L4.03 14.28a.75.75 0 0 1-1.06 0l-1.5-1.5a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l.97.97 2.095-2.095a.75.75 0 0 1 1.06 0ZM9.75 2.5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm0 5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm0 5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm-7.25-9v3h3v-3Z"></path> </svg> </button><tool-tip id="tooltip-b20f74e8-2f7f-4009-97a5-e8449d3a65b8" for="action-bar-fbdbd933-6a02-4589-b5f6-f7282944ffa1" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Task list</tool-tip> </div> <hr role="presentation" aria-hidden="true" data-targets="action-bar.items" data-view-component="true" class="ActionBar-item ActionBar-divider" /> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-ac86a960-6107-49fe-b5fa-c6bbb049da94" data-analytics-event="{"category":"comment_box","action":"ATTACH_FILES","label":null}" data-file-attachment-for="fc-{{ textareaId }}" aria-labelledby="tooltip-57d553e1-711a-4eaa-b9af-58ed4ea5957f" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-paperclip Button-visual"> <path d="M12.212 3.02a1.753 1.753 0 0 0-2.478.003l-5.83 5.83a3.007 3.007 0 0 0-.88 2.127c0 .795.315 1.551.88 2.116.567.567 1.333.89 2.126.89.79 0 1.548-.321 2.116-.89l5.48-5.48a.75.75 0 0 1 1.061 1.06l-5.48 5.48a4.492 4.492 0 0 1-3.177 1.33c-1.2 0-2.345-.487-3.187-1.33a4.483 4.483 0 0 1-1.32-3.177c0-1.195.475-2.341 1.32-3.186l5.83-5.83a3.25 3.25 0 0 1 5.553 2.297c0 .863-.343 1.691-.953 2.301L7.439 12.39c-.375.377-.884.59-1.416.593a1.998 1.998 0 0 1-1.412-.593 1.992 1.992 0 0 1 0-2.828l5.48-5.48a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042l-5.48 5.48a.492.492 0 0 0 0 .707.499.499 0 0 0 .352.154.51.51 0 0 0 .356-.154l5.833-5.827a1.755 1.755 0 0 0 0-2.481Z"></path> </svg> </button><tool-tip id="tooltip-57d553e1-711a-4eaa-b9af-58ed4ea5957f" for="action-bar-ac86a960-6107-49fe-b5fa-c6bbb049da94" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Attach files</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-32f8b384-9c47-456f-b5b4-f9e8c2e065a0" data-md-button="mention" data-analytics-event="{"category":"comment_box","action":"MENTION","label":null}" aria-labelledby="tooltip-27bab5cc-8b65-4fba-829e-b3416fd9ceb8" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-mention Button-visual"> <path d="M4.75 2.37a6.501 6.501 0 0 0 6.5 11.26.75.75 0 0 1 .75 1.298A7.999 7.999 0 0 1 .989 4.148 8 8 0 0 1 16 7.75v1.5a2.75 2.75 0 0 1-5.072 1.475 3.999 3.999 0 0 1-6.65-4.19A4 4 0 0 1 12 8v1.25a1.25 1.25 0 0 0 2.5 0V7.867a6.5 6.5 0 0 0-9.75-5.496ZM10.5 8a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg> </button><tool-tip id="tooltip-27bab5cc-8b65-4fba-829e-b3416fd9ceb8" for="action-bar-32f8b384-9c47-456f-b5b4-f9e8c2e065a0" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Mention</tool-tip> </div> <div data-targets="action-bar.items" data-view-component="true" class="ActionBar-item"><button id="action-bar-2f065f77-e64e-4c09-855d-767b9e01b1ba" data-md-button="ref" data-analytics-event="{"category":"comment_box","action":"REFERENCE","label":null}" aria-labelledby="tooltip-57c74cfd-fa43-49d4-b8d9-476607c8807d" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference Button-visual"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </button><tool-tip id="tooltip-57c74cfd-fa43-49d4-b8d9-476607c8807d" for="action-bar-2f065f77-e64e-4c09-855d-767b9e01b1ba" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Reference</tool-tip> </div> </div> <action-menu data-target="action-bar.moreMenu" hidden="hidden" data-select-variant="none" data-view-component="true" class="ActionBar-more-menu"> <focus-group direction="vertical" mnemonics retain> <button id="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-button" popovertarget="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-overlay" aria-controls="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-list" aria-haspopup="true" aria-labelledby="tooltip-e9f0d553-fc26-4fbb-b8b7-2b57e9692e24" type="button" data-view-component="true" class="Button Button--iconOnly Button--invisible Button--medium"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal Button-visual"> <path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"></path> </svg> </button><tool-tip id="tooltip-e9f0d553-fc26-4fbb-b8b7-2b57e9692e24" for="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-button" popover="manual" data-direction="s" data-type="label" data-view-component="true" class="sr-only position-absolute">Menu</tool-tip> <anchored-position data-target="action-menu.overlay" id="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-overlay" anchor="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-button" align="end" side="outside-bottom" anchor-offset="normal" popover="auto" data-view-component="true"> <div data-view-component="true" class="Overlay Overlay--size-auto"> <div data-view-component="true" class="Overlay-body Overlay-body--paddingNone"> <action-list> <div data-view-component="true"> <ul aria-labelledby="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-button" id="action-bar-650f79e4-80f3-4b61-8ca0-508d9a00659d-list" role="menu" data-view-component="true" class="ActionListWrap--inset ActionListWrap"> <li value="" hidden="hidden" data-for="action-bar-0a0bc312-a843-47a6-b9ed-773f55453c7a" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-c6800007-127f-4499-9bb4-0a4da97b33db" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-heading"> <path d="M3.75 2a.75.75 0 0 1 .75.75V7h7V2.75a.75.75 0 0 1 1.5 0v10.5a.75.75 0 0 1-1.5 0V8.5h-7v4.75a.75.75 0 0 1-1.5 0V2.75A.75.75 0 0 1 3.75 2Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Heading </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-35a274f1-4592-48ef-b85d-c28b233ad1ac" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-366f61cc-596b-490a-8e80-72ba5cad5101" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bold"> <path d="M4 2h4.5a3.501 3.501 0 0 1 2.852 5.53A3.499 3.499 0 0 1 9.5 14H4a1 1 0 0 1-1-1V3a1 1 0 0 1 1-1Zm1 7v3h4.5a1.5 1.5 0 0 0 0-3Zm3.5-2a1.5 1.5 0 0 0 0-3H5v3Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Bold </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-33a936b7-d409-443e-8548-17bb96184011" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-dc381ebc-d428-4c1b-b5c2-9062e2626f7f" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-italic"> <path d="M6 2.75A.75.75 0 0 1 6.75 2h6.5a.75.75 0 0 1 0 1.5h-2.505l-3.858 9H9.25a.75.75 0 0 1 0 1.5h-6.5a.75.75 0 0 1 0-1.5h2.505l3.858-9H6.75A.75.75 0 0 1 6 2.75Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Italic </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-acfe746a-f22c-4f63-8826-4a92b0c92e5d" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-933d1d9a-8635-40cc-9b4b-98fd94b5e0b9" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-quote"> <path d="M1.75 2.5h10.5a.75.75 0 0 1 0 1.5H1.75a.75.75 0 0 1 0-1.5Zm4 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5ZM2.5 7.75v6a.75.75 0 0 1-1.5 0v-6a.75.75 0 0 1 1.5 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Quote </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-b3dc20fc-7b8b-4aa0-9639-05be49e7ae6f" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-bc037cc9-b74d-49b8-91fd-efa01790afdf" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-code"> <path d="m11.28 3.22 4.25 4.25a.75.75 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L13.94 8l-3.72-3.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-6.56 0a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L2.06 8l3.72 3.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L.47 8.53a.75.75 0 0 1 0-1.06Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Code </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-71ab50ec-c45f-4e65-9e08-a0ef4522961b" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-82b35d86-d67c-40d4-86ff-38141312a8a2" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-link"> <path d="m7.775 3.275 1.25-1.25a3.5 3.5 0 1 1 4.95 4.95l-2.5 2.5a3.5 3.5 0 0 1-4.95 0 .751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018 1.998 1.998 0 0 0 2.83 0l2.5-2.5a2.002 2.002 0 0 0-2.83-2.83l-1.25 1.25a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042Zm-4.69 9.64a1.998 1.998 0 0 0 2.83 0l1.25-1.25a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042l-1.25 1.25a3.5 3.5 0 1 1-4.95-4.95l2.5-2.5a3.5 3.5 0 0 1 4.95 0 .751.751 0 0 1-.018 1.042.751.751 0 0 1-1.042.018 1.998 1.998 0 0 0-2.83 0l-2.5 2.5a1.998 1.998 0 0 0 0 2.83Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Link </span> </button> </li> <li hidden="hidden" role="presentation" aria-hidden="true" data-view-component="true" class="ActionList-sectionDivider"></li> <li value="" hidden="hidden" data-for="action-bar-f3b1e14a-38d7-4da1-b8da-af4d0b6b38c7" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-c7c8f78d-517a-477d-8f93-9efc86a5004c" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-list-ordered"> <path d="M5 3.25a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5A.75.75 0 0 1 5 3.25Zm0 5a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5A.75.75 0 0 1 5 8.25Zm0 5a.75.75 0 0 1 .75-.75h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1-.75-.75ZM.924 10.32a.5.5 0 0 1-.851-.525l.001-.001.001-.002.002-.004.007-.011c.097-.144.215-.273.348-.384.228-.19.588-.392 1.068-.392.468 0 .858.181 1.126.484.259.294.377.673.377 1.038 0 .987-.686 1.495-1.156 1.845l-.047.035c-.303.225-.522.4-.654.597h1.357a.5.5 0 0 1 0 1H.5a.5.5 0 0 1-.5-.5c0-1.005.692-1.52 1.167-1.875l.035-.025c.531-.396.8-.625.8-1.078a.57.57 0 0 0-.128-.376C1.806 10.068 1.695 10 1.5 10a.658.658 0 0 0-.429.163.835.835 0 0 0-.144.153ZM2.003 2.5V6h.503a.5.5 0 0 1 0 1H.5a.5.5 0 0 1 0-1h.503V3.308l-.28.14a.5.5 0 0 1-.446-.895l1.003-.5a.5.5 0 0 1 .723.447Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Numbered list </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-5b66fd0a-ccf5-4a61-8bae-eb630caad68d" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-5b6b036f-4105-4bf0-b065-fafae381f350" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-list-unordered"> <path d="M5.75 2.5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5Zm0 5h8.5a.75.75 0 0 1 0 1.5h-8.5a.75.75 0 0 1 0-1.5ZM2 14a1 1 0 1 1 0-2 1 1 0 0 1 0 2Zm1-6a1 1 0 1 1-2 0 1 1 0 0 1 2 0ZM2 4a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Unordered list </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-fbdbd933-6a02-4589-b5f6-f7282944ffa1" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-afe24ad5-ca38-4486-a22f-8284db168b04" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-tasklist"> <path d="M2 2h4a1 1 0 0 1 1 1v4a1 1 0 0 1-1 1H2a1 1 0 0 1-1-1V3a1 1 0 0 1 1-1Zm4.655 8.595a.75.75 0 0 1 0 1.06L4.03 14.28a.75.75 0 0 1-1.06 0l-1.5-1.5a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215l.97.97 2.095-2.095a.75.75 0 0 1 1.06 0ZM9.75 2.5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm0 5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm0 5h5.5a.75.75 0 0 1 0 1.5h-5.5a.75.75 0 0 1 0-1.5Zm-7.25-9v3h3v-3Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Task list </span> </button> </li> <li hidden="hidden" role="presentation" aria-hidden="true" data-view-component="true" class="ActionList-sectionDivider"></li> <li value="" hidden="hidden" data-for="action-bar-ac86a960-6107-49fe-b5fa-c6bbb049da94" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-e9025d31-34f0-4bb7-a222-2aa48b320bd9" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-paperclip"> <path d="M12.212 3.02a1.753 1.753 0 0 0-2.478.003l-5.83 5.83a3.007 3.007 0 0 0-.88 2.127c0 .795.315 1.551.88 2.116.567.567 1.333.89 2.126.89.79 0 1.548-.321 2.116-.89l5.48-5.48a.75.75 0 0 1 1.061 1.06l-5.48 5.48a4.492 4.492 0 0 1-3.177 1.33c-1.2 0-2.345-.487-3.187-1.33a4.483 4.483 0 0 1-1.32-3.177c0-1.195.475-2.341 1.32-3.186l5.83-5.83a3.25 3.25 0 0 1 5.553 2.297c0 .863-.343 1.691-.953 2.301L7.439 12.39c-.375.377-.884.59-1.416.593a1.998 1.998 0 0 1-1.412-.593 1.992 1.992 0 0 1 0-2.828l5.48-5.48a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042l-5.48 5.48a.492.492 0 0 0 0 .707.499.499 0 0 0 .352.154.51.51 0 0 0 .356-.154l5.833-5.827a1.755 1.755 0 0 0 0-2.481Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Attach files </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-32f8b384-9c47-456f-b5b4-f9e8c2e065a0" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-0c3b0eb4-1854-424a-a5bb-71f65f3eb6ad" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-mention"> <path d="M4.75 2.37a6.501 6.501 0 0 0 6.5 11.26.75.75 0 0 1 .75 1.298A7.999 7.999 0 0 1 .989 4.148 8 8 0 0 1 16 7.75v1.5a2.75 2.75 0 0 1-5.072 1.475 3.999 3.999 0 0 1-6.65-4.19A4 4 0 0 1 12 8v1.25a1.25 1.25 0 0 0 2.5 0V7.867a6.5 6.5 0 0 0-9.75-5.496ZM10.5 8a2.5 2.5 0 1 0-5 0 2.5 2.5 0 0 0 5 0Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Mention </span> </button> </li> <li value="" hidden="hidden" data-for="action-bar-2f065f77-e64e-4c09-855d-767b9e01b1ba" data-action="click:action-bar#menuItemClick" data-targets="action-list.items" role="none" data-view-component="true" class="ActionListItem"> <button tabindex="-1" id="item-72889595-6dd6-48b3-96a7-23c03f20eaa7" type="button" role="menuitem" data-view-component="true" class="ActionListContent ActionListContent--visual16"> <span class="ActionListItem-visual ActionListItem-visual--leading"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-cross-reference"> <path d="M2.75 3.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h4.5a.25.25 0 0 0 .25-.25v-2.5a.75.75 0 0 1 1.5 0v2.5A1.75 1.75 0 0 1 13.25 13H9.06l-2.573 2.573A1.458 1.458 0 0 1 4 14.543V13H2.75A1.75 1.75 0 0 1 1 11.25v-7.5C1 2.784 1.784 2 2.75 2h5.5a.75.75 0 0 1 0 1.5ZM16 1.25v4.146a.25.25 0 0 1-.427.177L14.03 4.03l-3.75 3.75a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734l3.75-3.75-1.543-1.543A.25.25 0 0 1 11.604 1h4.146a.25.25 0 0 1 .25.25Z"></path> </svg> </span> <span data-view-component="true" class="ActionListItem-label"> Reference </span> </button> </li> </ul> </div></action-list> </div> </div></anchored-position> </focus-group> </action-menu></action-bar></markdown-toolbar> <dialog-helper> <dialog id="saved_replies_menu_{{ textareaId }}-dialog" aria-modal="true" aria-labelledby="saved_replies_menu_{{ textareaId }}-dialog-title" aria-describedby="saved_replies_menu_{{ textareaId }}-dialog-description" data-view-component="true" class="Overlay Overlay-whenNarrow Overlay--size-medium Overlay--motion-scaleFade Overlay--placement-bottom-whenNarrow js-saved-reply-container Overlay--disableScroll"> <div data-view-component="true" class="Overlay-header"> <div class="Overlay-headerContentWrap"> <div class="Overlay-titleWrap"> <h1 class="Overlay-title " id="saved_replies_menu_{{ textareaId }}-dialog-title"> Select a reply </h1> </div> <div class="Overlay-actionWrap"> <button data-close-dialog-id="saved_replies_menu_{{ textareaId }}-dialog" aria-label="Close" type="button" data-view-component="true" class="close-button Overlay-closeButton"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg></button> </div> </div> </div> <scrollable-region data-labelled-by="saved_replies_menu_{{ textareaId }}-dialog-title"> <div data-view-component="true" class="Overlay-body"> <include-fragment class="js-saved-reply-include-fragment" role="menuitem" aria-label="Loading" src="/settings/replies?context=none" loading="lazy"> <span data-view-component="true"> <svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="my-6 mx-auto d-block anim-rotate"> <circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" /> <path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" /> </svg> <span class="sr-only">Loading</span> </span> </include-fragment> </div> </scrollable-region> <div data-view-component="true" class="Overlay-footer Overlay-footer--alignEnd Overlay-footer--divided"> <a href="/settings/replies?return_to=1" data-view-component="true" class="Button--invisible Button--medium Button Button--fullWidth"> <span class="Button-content Button-content--alignStart"> <span class="Button-visual Button-leadingVisual"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-plus"> <path d="M7.75 2a.75.75 0 0 1 .75.75V7h4.25a.75.75 0 0 1 0 1.5H8.5v4.25a.75.75 0 0 1-1.5 0V8.5H2.75a.75.75 0 0 1 0-1.5H7V2.75A.75.75 0 0 1 7.75 2Z"></path> </svg> </span> <span class="Button-label">Create a new saved reply</span> </span> </a> </div> </dialog></dialog-helper> </template> <template id="emoji-reaction-button-template-+1"> <button name="input[content]" id="reactions--reaction_button_component-f5af0f" value="THUMBS_UP unreact" data-button-index-position="0" data-reaction-label="+1" data-reaction-content="+1" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="+1" fallback-src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png" class="social-button-emoji">👍</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-fd0220f0-16ca-4d8b-b951-0c3774e29bfa" for="reactions--reaction_button_component-f5af0f" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with thumbs up emoji</tool-tip> </template> <template id="emoji-reaction-button-template--1"> <button name="input[content]" id="reactions--reaction_button_component-77cf9f" value="THUMBS_DOWN unreact" data-button-index-position="1" data-reaction-label="-1" data-reaction-content="-1" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="-1" fallback-src="https://github.githubassets.com/assets/1f44e-ce91733aae25.png" class="social-button-emoji">👎</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-9bc7888c-a7d6-484c-9f3c-9a48abb9b9a3" for="reactions--reaction_button_component-77cf9f" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with thumbs down emoji</tool-tip> </template> <template id="emoji-reaction-button-template-smile"> <button name="input[content]" id="reactions--reaction_button_component-7ae969" value="LAUGH unreact" data-button-index-position="2" data-reaction-label="Laugh" data-reaction-content="smile" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="smile" fallback-src="https://github.githubassets.com/assets/1f604-7528822fb4c5.png" class="social-button-emoji">😄</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-d4a33754-3317-443d-85f5-2aefa389b7ba" for="reactions--reaction_button_component-7ae969" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with laugh emoji</tool-tip> </template> <template id="emoji-reaction-button-template-tada"> <button name="input[content]" id="reactions--reaction_button_component-8bc684" value="HOORAY unreact" data-button-index-position="3" data-reaction-label="Hooray" data-reaction-content="tada" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="tada" fallback-src="https://github.githubassets.com/assets/1f389-36899a2cb781.png" class="social-button-emoji">🎉</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-b4ea5213-f546-4e30-a7dc-a7ee70d24444" for="reactions--reaction_button_component-8bc684" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with hooray emoji</tool-tip> </template> <template id="emoji-reaction-button-template-thinking_face"> <button name="input[content]" id="reactions--reaction_button_component-e773cb" value="CONFUSED unreact" data-button-index-position="4" data-reaction-label="Confused" data-reaction-content="thinking_face" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="thinking_face" fallback-src="https://github.githubassets.com/assets/1f615-4bb1369c4251.png" class="social-button-emoji">😕</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-232246b9-5c2c-4778-8d13-96e5f1c2b772" for="reactions--reaction_button_component-e773cb" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with confused emoji</tool-tip> </template> <template id="emoji-reaction-button-template-heart"> <button name="input[content]" id="reactions--reaction_button_component-8f3350" value="HEART unreact" data-button-index-position="5" data-reaction-label="Heart" data-reaction-content="heart" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="heart" fallback-src="https://github.githubassets.com/assets/2764-982dc91ea48a.png" class="social-button-emoji">❤️</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-2e93c89f-c724-46a0-997c-6697dda06892" for="reactions--reaction_button_component-8f3350" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with heart emoji</tool-tip> </template> <template id="emoji-reaction-button-template-rocket"> <button name="input[content]" id="reactions--reaction_button_component-bf490e" value="ROCKET unreact" data-button-index-position="6" data-reaction-label="Rocket" data-reaction-content="rocket" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="rocket" fallback-src="https://github.githubassets.com/assets/1f680-d0ef47fdb515.png" class="social-button-emoji">🚀</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-bc663cf6-28aa-44fc-b67a-6bfa3dfd7bcc" for="reactions--reaction_button_component-bf490e" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with rocket emoji</tool-tip> </template> <template id="emoji-reaction-button-template-eyes"> <button name="input[content]" id="reactions--reaction_button_component-085929" value="EYES unreact" data-button-index-position="7" data-reaction-label="Eyes" data-reaction-content="eyes" aria-pressed="true" type="submit" data-view-component="true" class="social-reaction-summary-item js-reaction-group-button user-has-reacted btn-link d-flex no-underline flex-items-baseline"> <g-emoji alias="eyes" fallback-src="https://github.githubassets.com/assets/1f440-ee44e91e92a7.png" class="social-button-emoji">👀</g-emoji> <span class="js-discussion-reaction-group-count">1</span> </button> <tool-tip id="tooltip-6cf3e799-4efa-4163-bf69-10012759fa12" for="reactions--reaction_button_component-085929" popover="manual" data-direction="n" data-type="description" data-view-component="true" class="sr-only position-absolute"> reacted with eyes emoji</tool-tip> </template> </div> </div> </div> </turbo-frame> </main> </div> </div> <footer class="footer pt-8 pb-6 f6 color-fg-muted p-responsive" role="contentinfo" > <h2 class='sr-only'>Footer</h2> <div class="d-flex flex-justify-center flex-items-center flex-column-reverse flex-lg-row flex-wrap flex-lg-nowrap"> <div class="d-flex flex-items-center flex-shrink-0 mx-2"> <a aria-label="Homepage" title="GitHub" class="footer-octicon mr-2" href="https://github.com"> <svg aria-hidden="true" height="24" viewBox="0 0 24 24" version="1.1" width="24" data-view-component="true" class="octicon octicon-mark-github"> <path d="M12.5.75C6.146.75 1 5.896 1 12.25c0 5.089 3.292 9.387 7.863 10.91.575.101.79-.244.79-.546 0-.273-.014-1.178-.014-2.142-2.889.532-3.636-.704-3.866-1.35-.13-.331-.69-1.352-1.18-1.625-.402-.216-.977-.748-.014-.762.906-.014 1.553.834 1.769 1.179 1.035 1.74 2.688 1.25 3.349.948.1-.747.402-1.25.733-1.538-2.559-.287-5.232-1.279-5.232-5.678 0-1.25.445-2.285 1.178-3.09-.115-.288-.517-1.467.115-3.048 0 0 .963-.302 3.163 1.179.92-.259 1.897-.388 2.875-.388.977 0 1.955.13 2.875.388 2.2-1.495 3.162-1.179 3.162-1.179.633 1.581.23 2.76.115 3.048.733.805 1.179 1.825 1.179 3.09 0 4.413-2.688 5.39-5.247 5.678.417.36.776 1.05.776 2.128 0 1.538-.014 2.774-.014 3.162 0 .302.216.662.79.547C20.709 21.637 24 17.324 24 12.25 24 5.896 18.854.75 12.5.75Z"></path> </svg> </a> <span> © 2025 GitHub, Inc. </span> </div> <nav aria-label="Footer"> <h3 class="sr-only" id="sr-footer-heading">Footer navigation</h3> <ul class="list-style-none d-flex flex-justify-center flex-wrap mb-2 mb-lg-0" aria-labelledby="sr-footer-heading"> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to Terms","label":"text:terms"}" href="https://docs.github.com/site-policy/github-terms/github-terms-of-service" data-view-component="true" class="Link--secondary Link">Terms</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to privacy","label":"text:privacy"}" href="https://docs.github.com/site-policy/privacy-policies/github-privacy-statement" data-view-component="true" class="Link--secondary Link">Privacy</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to security","label":"text:security"}" href="https://github.com/security" data-view-component="true" class="Link--secondary Link">Security</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to status","label":"text:status"}" href="https://www.githubstatus.com/" data-view-component="true" class="Link--secondary Link">Status</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to docs","label":"text:docs"}" href="https://docs.github.com/" data-view-component="true" class="Link--secondary Link">Docs</a> </li> <li class="mx-2"> <a data-analytics-event="{"category":"Footer","action":"go to contact","label":"text:contact"}" href="https://support.github.com?tags=dotcom-footer" data-view-component="true" class="Link--secondary Link">Contact</a> </li> <li class="mx-2" > <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"cookies","context":"subfooter","tag":"link","label":"cookies_link_subfooter_footer"}" > Manage cookies </button> </cookie-consent-link> </li> <li class="mx-2"> <cookie-consent-link> <button type="button" class="Link--secondary underline-on-hover border-0 p-0 color-bg-transparent" data-action="click:cookie-consent-link#showConsentManagement" data-analytics-event="{"location":"footer","action":"dont_share_info","context":"subfooter","tag":"link","label":"dont_share_info_link_subfooter_footer"}" > Do not share my personal information </button> </cookie-consent-link> </li> </ul> </nav> </div> </footer> <ghcc-consent id="ghcc" class="position-fixed bottom-0 left-0" style="z-index: 999999" data-initial-cookie-consent-allowed="" data-cookie-consent-required="false"></ghcc-consent> <div id="ajax-error-message" class="ajax-error-message flash flash-error" hidden> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert"> <path d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path> </svg> <button type="button" class="flash-close js-ajax-error-dismiss" aria-label="Dismiss error"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> You can’t perform that action at this time. </div> <template id="site-details-dialog"> <details class="details-reset details-overlay details-overlay-dark lh-default color-fg-default hx_rsm" open> <summary role="button" aria-label="Close dialog"></summary> <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast hx_rsm-dialog hx_rsm-modal"> <button class="Box-btn-octicon m-0 btn-octicon position-absolute right-0 top-0" type="button" aria-label="Close dialog" data-close-dialog> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x"> <path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path> </svg> </button> <div class="octocat-spinner my-6 js-details-dialog-spinner"></div> </details-dialog> </details> </template> <div class="Popover js-hovercard-content position-absolute" style="display: none; outline: none;"> <div class="Popover-message Popover-message--bottom-left Popover-message--large Box color-shadow-large" style="width:360px;"> </div> </div> <template id="snippet-clipboard-copy-button"> <div class="zeroclipboard-container position-absolute right-0 top-0"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn js-clipboard-copy m-2 p-0" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon m-2"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none m-2"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> <template id="snippet-clipboard-copy-button-unpositioned"> <div class="zeroclipboard-container"> <clipboard-copy aria-label="Copy" class="ClipboardButton btn btn-invisible js-clipboard-copy m-2 p-0 d-flex flex-justify-center flex-items-center" data-copy-feedback="Copied!" data-tooltip-direction="w"> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy js-clipboard-copy-icon"> <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path> </svg> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-check js-clipboard-check-icon color-fg-success d-none"> <path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"></path> </svg> </clipboard-copy> </div> </template> </div> <div id="js-global-screen-reader-notice" class="sr-only mt-n1" aria-live="polite" aria-atomic="true" ></div> <div id="js-global-screen-reader-notice-assertive" class="sr-only mt-n1" aria-live="assertive" aria-atomic="true"></div> </body> </html>

CINXE.COM

codereview: should the Go project stop importing GitHub PRs? · golang/go · Discussion #61182 · GitHub